]> git.ipfire.org Git - thirdparty/suricata.git/log
thirdparty/suricata.git
13 days agodetect-urilen: convert unittests to FAIL/PASS APIs 14135/head
Olusegun Fajobi [Fri, 24 Oct 2025 09:34:41 +0000 (10:34 +0100)] 
detect-urilen: convert unittests to FAIL/PASS APIs

Ticket: #6325

13 days agorule/vars: convert unittests to new FAIL/PASS API
Jhonny Sousa [Wed, 22 Oct 2025 20:09:54 +0000 (17:09 -0300)] 
rule/vars: convert unittests to new FAIL/PASS API

Ticket: #6333

13 days agothreads: convert unittests for FAIL/PASS APIs
Olusegun Fajobi [Tue, 21 Oct 2025 18:50:39 +0000 (19:50 +0100)] 
threads: convert unittests for FAIL/PASS APIs

Ticket: #6327

2 weeks agodetect: address intermittent UT crash on OpenBSD 14104/head
Victor Julien [Tue, 21 Oct 2025 05:19:55 +0000 (07:19 +0200)] 
detect: address intermittent UT crash on OpenBSD

Add missing flow memset in test SCSigOrderingTest12 to avoid the crash.

Test SCSigOrderingTest12                                          : Info: unittest-helper: Sid 1 matched 1 times, as expected [UTHCheckPacketMatchResults:util-unittest-helper.c:638]
Info: unittest-helper: Sid 2 matched 1 times, as expected [UTHCheckPacketMatchResults:util-unittest-helper.c:638]
bash: line 144: 88567 Segmentation fault      (core dumped) ./src/suricata -u -l /tmp/

Bug: #8008.

2 weeks agoippair-storage: convert unittests to FAIL/PASS APIs
Olusegun Fajobi [Fri, 17 Oct 2025 19:51:48 +0000 (20:51 +0100)] 
ippair-storage: convert unittests to FAIL/PASS APIs

Ticket: #6315

2 weeks agorust: pin indexmap 14077/head
Jason Ish [Sat, 18 Oct 2025 20:00:29 +0000 (14:00 -0600)] 
rust: pin indexmap

Newer indexmap, pulled in by serde_json requires Rust 1.82, so pin
pack to 2.11.4 which still works with Rust 1.75.

2 weeks agodetect/dbv: Assert MT lock held
Jeff Lucovsky [Sun, 28 Sep 2025 12:53:13 +0000 (08:53 -0400)] 
detect/dbv: Assert MT lock held

Add a DBV assert to validate that the master->lock is held.

Suppress missing master->lock warning

Issue: 7819

2 weeks agoengine/mt: Ensure master lock held for reload
Jeff Lucovsky [Thu, 21 Aug 2025 13:57:27 +0000 (09:57 -0400)] 
engine/mt: Ensure master lock held for reload

Issue: 7819

DetectEngineReload must hold the `master->lock`; recent changes changed
the locking usages to avoid deadlock when registering/handling tenants.
These changes added the presumption that the master lock is held at a
higher level. Coverity highlighted that the lock is not held
consistently.

2 weeks agodoc: minor verbiage tweaks and reST fix 14070/head
David Wharton [Tue, 14 Oct 2025 02:35:07 +0000 (22:35 -0400)] 
doc: minor verbiage tweaks and reST fix

2 weeks agorust: bindgen more http range functions used in http2
Philippe Antoine [Mon, 6 Oct 2025 08:45:00 +0000 (10:45 +0200)] 
rust: bindgen more http range functions used in http2

Ticket: 7667

2 weeks agorust: bindgen SCHttpRangeFreeBlock
Philippe Antoine [Mon, 6 Oct 2025 08:32:56 +0000 (10:32 +0200)] 
rust: bindgen SCHttpRangeFreeBlock

Ticket: 7667

2 weeks agorust: bindgen SCHTTP2MimicHttp1Request
Philippe Antoine [Mon, 6 Oct 2025 08:08:51 +0000 (10:08 +0200)] 
rust: bindgen SCHTTP2MimicHttp1Request

Ticket: 7667

3 weeks agodetect: tcp.flags rejects non-sensical values 14067/head
Philippe Antoine [Thu, 16 Oct 2025 11:04:22 +0000 (13:04 +0200)] 
detect: tcp.flags rejects non-sensical values

ignored flags are only meaningful for equal mode

3 weeks agodetect: tcp.flags unit tests improvements
Philippe Antoine [Thu, 16 Oct 2025 09:54:03 +0000 (11:54 +0200)] 
detect: tcp.flags unit tests improvements

Tests better the ignored flags functionality.
This functionality is only used at detection for default mode,
it is not used for any, plus or not mode.

So, have unit tests about igored flags with default mode with
both matching and non matching cases

3 weeks agodetect/tcp: make tcp.flags a generic integer with bitflags
Philippe Antoine [Mon, 6 Oct 2025 19:39:18 +0000 (21:39 +0200)] 
detect/tcp: make tcp.flags a generic integer with bitflags

Ticket: 6724

Allows to use numerical values for example

Also fixes some unit tests that were returning 1 after goto error
FlagsTestParse05 especially took this path as
de->ignored_flags != (TH_SYN|TH_RST) was false
we had de->ignored_flags == 0xff ^ (TH_SYN|TH_RST)
And then, we had a match, instead of what the not-run code
was supposing.

3 weeks agodetect/ipv4: make fragbits a generic uint16 bitflags keyword
Philippe Antoine [Mon, 6 Oct 2025 12:44:35 +0000 (14:44 +0200)] 
detect/ipv4: make fragbits a generic uint16 bitflags keyword

Ticket: 6724

Allows to use numerical values

3 weeks agodetect/integers: generalize support for bitflags modifier
Philippe Antoine [Mon, 6 Oct 2025 12:44:35 +0000 (14:44 +0200)] 
detect/integers: generalize support for bitflags modifier

Ticket: 6724

Allows sugar syntax for bitflags keywords.
While the expressivity does not increase, because we could already
use numerial values with all generic integer modes, this modifier
prefix is used with the strings, and follows the syntax
that is already used for fragbits and tcp.flags keyword.

3 weeks agoippair-bit: Convert unittests to FAIL/PASS APIs
Olusegun Fajobi [Fri, 17 Oct 2025 02:40:28 +0000 (03:40 +0100)] 
ippair-bit: Convert unittests to FAIL/PASS APIs

Ticket: #6323

3 weeks agoapplayer/tls: do not free SAN for decoding error
Shivani Bhardwaj [Sat, 11 Oct 2025 08:45:37 +0000 (14:15 +0530)] 
applayer/tls: do not free SAN for decoding error

SSL connp maintains all the state and certificate data that was
parsed/decoded successfully and it must retain that for later usage.
There should be just one place to free this object which is SSLStateFree
for both the directions. By freeing the connp data during parsing error,
there is room for memory errors.
This works so far because the field parsed after this cannot error out so
if there's an error parsing this, it anyway does not exist. However, this
is incorrect and leaves scope for mistakes.

Remove this extra free and treat SAN like all other TLS keywords.

Bug 7996

3 weeks agopcap-log: fix bpf-filter not set for multi mode 14055/head
Victor Julien [Thu, 16 Oct 2025 11:08:19 +0000 (13:08 +0200)] 
pcap-log: fix bpf-filter not set for multi mode

Bug: #8002.

3 weeks agolibhtp: fix newer clippy lints with newer MSRV
Philippe Antoine [Thu, 16 Oct 2025 07:13:52 +0000 (09:13 +0200)] 
libhtp: fix newer clippy lints with newer MSRV

3 weeks agoquic/crypto: remove use of GenericArray
Jason Ish [Wed, 15 Oct 2025 21:41:58 +0000 (15:41 -0600)] 
quic/crypto: remove use of GenericArray

Its not needed, and gets rid of the deprecation warnings.

3 weeks agorust: update deps with cargo-update
Jason Ish [Wed, 15 Oct 2025 20:57:27 +0000 (14:57 -0600)] 
rust: update deps with cargo-update

Suppress deprecation warnings in quick/crypto.rs about GenericArray.

3 weeks agorust: update aes-gcm to 0.10.3
Jason Ish [Wed, 15 Oct 2025 20:42:35 +0000 (14:42 -0600)] 
rust: update aes-gcm to 0.10.3

3 weeks agorust: update aes to 0.8.4
Jason Ish [Wed, 15 Oct 2025 20:26:44 +0000 (14:26 -0600)] 
rust: update aes to 0.8.4

3 weeks agodetect/integers: count argument for multi-integers
Philippe Antoine [Wed, 24 Sep 2025 12:47:20 +0000 (14:47 +0200)] 
detect/integers: count argument for multi-integers

Ticket: 7211

Allows to count the number of elements, without matching on
individual elements

3 weeks agodoc: fix enip_command name in json schema
Philippe Antoine [Wed, 24 Sep 2025 12:21:57 +0000 (14:21 +0200)] 
doc: fix enip_command name in json schema

enip.command is not a keyword nor an alias

3 weeks agounittests: move http.cookie tests to FAIL/PASS API 14025/head
Victor Julien [Sun, 12 Oct 2025 18:58:20 +0000 (20:58 +0200)] 
unittests: move http.cookie tests to FAIL/PASS API

3 weeks agounittests: move http.stat_code tests to FAIL/PASS API
Victor Julien [Sun, 12 Oct 2025 18:09:01 +0000 (20:09 +0200)] 
unittests: move http.stat_code tests to FAIL/PASS API

3 weeks agounittests: convert http_raw_header tests to FAIL/PASS api
Victor Julien [Sun, 12 Oct 2025 09:01:31 +0000 (11:01 +0200)] 
unittests: convert http_raw_header tests to FAIL/PASS api

3 weeks agounittests: move http.stat_msg tests to FAIL/PASS API
Victor Julien [Sun, 12 Oct 2025 06:21:41 +0000 (08:21 +0200)] 
unittests: move http.stat_msg tests to FAIL/PASS API

3 weeks agounittests: move http.server_body tests to FAIL/PASS API
Victor Julien [Sun, 12 Oct 2025 06:04:16 +0000 (08:04 +0200)] 
unittests: move http.server_body tests to FAIL/PASS API

3 weeks agounittests: clean up memory for host storage tests
Victor Julien [Sat, 11 Oct 2025 18:28:33 +0000 (20:28 +0200)] 
unittests: clean up memory for host storage tests

3 weeks agounittests: clean up memory for ippair storage tests
Victor Julien [Sat, 11 Oct 2025 18:08:03 +0000 (20:08 +0200)] 
unittests: clean up memory for ippair storage tests

3 weeks agooutput: fix long logline test
Victor Julien [Sat, 11 Oct 2025 18:06:24 +0000 (20:06 +0200)] 
output: fix long logline test

Fixes: 023a2fe9ab1f ("unittests: fix format-truncation warning")
3 weeks agogithub-actions: check for leaks in unittests
Victor Julien [Sat, 11 Oct 2025 10:43:07 +0000 (12:43 +0200)] 
github-actions: check for leaks in unittests

3 weeks agounittests: clean up memory for icmpv4 tests
Victor Julien [Sat, 11 Oct 2025 10:25:22 +0000 (12:25 +0200)] 
unittests: clean up memory for icmpv4 tests

3 weeks agounittests: clean up memory for nsh tests
Victor Julien [Sat, 11 Oct 2025 10:24:39 +0000 (12:24 +0200)] 
unittests: clean up memory for nsh tests

3 weeks agounittests: clean up memory for ethernet tests
Victor Julien [Sat, 11 Oct 2025 10:23:55 +0000 (12:23 +0200)] 
unittests: clean up memory for ethernet tests

3 weeks agounittests: clean up memory for ipv6 tests
Victor Julien [Sat, 11 Oct 2025 10:23:11 +0000 (12:23 +0200)] 
unittests: clean up memory for ipv6 tests

3 weeks agounittests: clean up memory for ipv4 tests
Victor Julien [Sat, 11 Oct 2025 10:22:25 +0000 (12:22 +0200)] 
unittests: clean up memory for ipv4 tests

3 weeks agounittests: clean up memory for vlan tests
Victor Julien [Sat, 11 Oct 2025 10:21:19 +0000 (12:21 +0200)] 
unittests: clean up memory for vlan tests

3 weeks agounittests: clean up memory for esp tests
Victor Julien [Sat, 11 Oct 2025 10:16:44 +0000 (12:16 +0200)] 
unittests: clean up memory for esp tests

3 weeks agounittests: clean up memory for raw tests
Victor Julien [Sat, 11 Oct 2025 09:39:39 +0000 (11:39 +0200)] 
unittests: clean up memory for raw tests

Convert to FAIL/PASS api

3 weeks agounittests: clean up memory for chdlc tests
Victor Julien [Sat, 11 Oct 2025 09:36:29 +0000 (11:36 +0200)] 
unittests: clean up memory for chdlc tests

3 weeks agounittests: clean up memory for pppoe tests
Victor Julien [Sat, 11 Oct 2025 09:35:31 +0000 (11:35 +0200)] 
unittests: clean up memory for pppoe tests

3 weeks agounittests: clean up memory for gre tests
Victor Julien [Sat, 11 Oct 2025 09:33:20 +0000 (11:33 +0200)] 
unittests: clean up memory for gre tests

3 weeks agounittests: clean up memory for ppp tests
Victor Julien [Sat, 11 Oct 2025 08:24:47 +0000 (10:24 +0200)] 
unittests: clean up memory for ppp tests

3 weeks agounittests: clean up memory for dnp3 tests
Victor Julien [Sat, 11 Oct 2025 08:21:21 +0000 (10:21 +0200)] 
unittests: clean up memory for dnp3 tests

3 weeks agounittests: clean up memory for defrag tests
Victor Julien [Sat, 11 Oct 2025 07:36:19 +0000 (09:36 +0200)] 
unittests: clean up memory for defrag tests

3 weeks agounittests: clean up memory for detect stream_size tests
Victor Julien [Sat, 11 Oct 2025 07:16:17 +0000 (09:16 +0200)] 
unittests: clean up memory for detect stream_size tests

Convert tests to FAIL/PASS api

3 weeks agounittests: clean up memory for detect dce payload tests
Victor Julien [Sat, 11 Oct 2025 06:17:11 +0000 (08:17 +0200)] 
unittests: clean up memory for detect dce payload tests

3 weeks agounittests: clean up memory for detect sameip tests
Victor Julien [Sat, 11 Oct 2025 05:59:12 +0000 (07:59 +0200)] 
unittests: clean up memory for detect sameip tests

3 weeks agounittests: clean up memory for detect reference tests
Victor Julien [Sat, 11 Oct 2025 05:45:29 +0000 (07:45 +0200)] 
unittests: clean up memory for detect reference tests

3 weeks agounittests: clean up memory for detect rpc tests
Victor Julien [Sat, 11 Oct 2025 05:43:06 +0000 (07:43 +0200)] 
unittests: clean up memory for detect rpc tests

3 weeks agounittests: clean up memory for detect replace tests
Victor Julien [Sat, 11 Oct 2025 05:41:03 +0000 (07:41 +0200)] 
unittests: clean up memory for detect replace tests

3 weeks agounittests: clean up memory for detect quic tests
Victor Julien [Fri, 10 Oct 2025 19:54:37 +0000 (21:54 +0200)] 
unittests: clean up memory for detect quic tests

3 weeks agounittests: clean up memory for detect pcre tests
Victor Julien [Fri, 10 Oct 2025 19:49:38 +0000 (21:49 +0200)] 
unittests: clean up memory for detect pcre tests

3 weeks agounittests: clean up memory for detect msg tests
Victor Julien [Fri, 10 Oct 2025 19:15:27 +0000 (21:15 +0200)] 
unittests: clean up memory for detect msg tests

3 weeks agounittests: clean up memory for detect l3_proto tests
Victor Julien [Fri, 10 Oct 2025 19:12:42 +0000 (21:12 +0200)] 
unittests: clean up memory for detect l3_proto tests

3 weeks agounittests: clean up memory for detect iprep tests
Victor Julien [Fri, 10 Oct 2025 19:10:47 +0000 (21:10 +0200)] 
unittests: clean up memory for detect iprep tests

3 weeks agounittests: clean up memory for detect ipproto tests
Victor Julien [Fri, 10 Oct 2025 19:04:16 +0000 (21:04 +0200)] 
unittests: clean up memory for detect ipproto tests

3 weeks agounittests: clean up memory for detect icode tests
Victor Julien [Fri, 10 Oct 2025 18:59:50 +0000 (20:59 +0200)] 
unittests: clean up memory for detect icode tests

3 weeks agounittests: clean up memory for detect itype tests
Victor Julien [Fri, 10 Oct 2025 18:58:35 +0000 (20:58 +0200)] 
unittests: clean up memory for detect itype tests

3 weeks agounittests: clean up memory for detect fast_pattern tests
Victor Julien [Fri, 10 Oct 2025 18:54:21 +0000 (20:54 +0200)] 
unittests: clean up memory for detect fast_pattern tests

3 weeks agounittests: clean up memory for detect flowint tests
Victor Julien [Fri, 10 Oct 2025 18:52:53 +0000 (20:52 +0200)] 
unittests: clean up memory for detect flowint tests

3 weeks agounittests: clean up memory for detect fragoffset tests
Victor Julien [Fri, 10 Oct 2025 18:51:06 +0000 (20:51 +0200)] 
unittests: clean up memory for detect fragoffset tests

3 weeks agounittests: clean up memory for detect flow tests
Victor Julien [Fri, 10 Oct 2025 18:49:28 +0000 (20:49 +0200)] 
unittests: clean up memory for detect flow tests

3 weeks agounittests: clean up memory for csum tests
Victor Julien [Fri, 10 Oct 2025 18:45:08 +0000 (20:45 +0200)] 
unittests: clean up memory for csum tests

3 weeks agounittests: clean up memory for base64_decode tests
Victor Julien [Fri, 10 Oct 2025 18:39:23 +0000 (20:39 +0200)] 
unittests: clean up memory for base64_decode tests

3 weeks agounittests: clean up memory for bytemath tests
Victor Julien [Fri, 10 Oct 2025 18:36:24 +0000 (20:36 +0200)] 
unittests: clean up memory for bytemath tests

3 weeks agounittests: clean up memory for address tests
Victor Julien [Fri, 10 Oct 2025 18:32:57 +0000 (20:32 +0200)] 
unittests: clean up memory for address tests

3 weeks agounittests: clean up memory for tcp.ack tests
Victor Julien [Fri, 10 Oct 2025 17:42:38 +0000 (19:42 +0200)] 
unittests: clean up memory for tcp.ack tests

3 weeks agounittests: clean up memory for dsize tests
Victor Julien [Fri, 10 Oct 2025 17:35:41 +0000 (19:35 +0200)] 
unittests: clean up memory for dsize tests

3 weeks agounittests: clean up memory for detection filter tests
Victor Julien [Fri, 10 Oct 2025 16:49:00 +0000 (18:49 +0200)] 
unittests: clean up memory for detection filter tests

3 weeks agounittests: clean up memory for dcerpc tests
Victor Julien [Fri, 10 Oct 2025 16:44:47 +0000 (18:44 +0200)] 
unittests: clean up memory for dcerpc tests

3 weeks agounittests: clean up memory for tls tests
Victor Julien [Fri, 10 Oct 2025 16:41:58 +0000 (18:41 +0200)] 
unittests: clean up memory for tls tests

3 weeks agounittests: clean up memory for tag tests
Victor Julien [Fri, 10 Oct 2025 16:14:10 +0000 (18:14 +0200)] 
unittests: clean up memory for tag tests

3 weeks agounittests: clean up memory for ttl tests
Victor Julien [Fri, 10 Oct 2025 16:07:30 +0000 (18:07 +0200)] 
unittests: clean up memory for ttl tests

3 weeks agounittests: clean up memory for threshold tests
Victor Julien [Fri, 10 Oct 2025 15:10:20 +0000 (17:10 +0200)] 
unittests: clean up memory for threshold tests

3 weeks agounittests: clean up memory for content inspection tests
Victor Julien [Fri, 10 Oct 2025 15:07:48 +0000 (17:07 +0200)] 
unittests: clean up memory for content inspection tests

3 weeks agounittests: clean up memory for content tests
Victor Julien [Fri, 10 Oct 2025 15:05:10 +0000 (17:05 +0200)] 
unittests: clean up memory for content tests

3 weeks agounittests: clean up memory for http urilen tests
Victor Julien [Fri, 10 Oct 2025 14:14:27 +0000 (16:14 +0200)] 
unittests: clean up memory for http urilen tests

3 weeks agounittests: clean up memory for http header tests
Victor Julien [Fri, 10 Oct 2025 13:34:32 +0000 (15:34 +0200)] 
unittests: clean up memory for http header tests

3 weeks agounittests: clean up memory for http host tests
Victor Julien [Fri, 10 Oct 2025 13:26:01 +0000 (15:26 +0200)] 
unittests: clean up memory for http host tests

3 weeks agounittests: clean up memory for http method tests
Victor Julien [Fri, 10 Oct 2025 11:30:11 +0000 (13:30 +0200)] 
unittests: clean up memory for http method tests

Convert to runtest logic as used in other http tests.

3 weeks agounittests: clean up memory for http ua tests
Victor Julien [Fri, 10 Oct 2025 08:01:56 +0000 (10:01 +0200)] 
unittests: clean up memory for http ua tests

3 weeks agounittests: clean up memory for http raw header tests
Victor Julien [Fri, 10 Oct 2025 07:26:36 +0000 (09:26 +0200)] 
unittests: clean up memory for http raw header tests

3 weeks agounittests: clean up memory for http detect tests
Victor Julien [Fri, 10 Oct 2025 00:57:59 +0000 (02:57 +0200)] 
unittests: clean up memory for http detect tests

3 weeks agounittests: clean up memory for hostbit tests
Victor Julien [Thu, 9 Oct 2025 18:39:07 +0000 (20:39 +0200)] 
unittests: clean up memory for hostbit tests

3 weeks agounittests: clean up memory for htp body test
Victor Julien [Thu, 9 Oct 2025 18:38:26 +0000 (20:38 +0200)] 
unittests: clean up memory for htp body test

3 weeks agounittests: clean up memory for detect engine event tests
Victor Julien [Thu, 9 Oct 2025 15:16:34 +0000 (17:16 +0200)] 
unittests: clean up memory for detect engine event tests

3 weeks agounittests: clean up memory for icmpv6 tests
Victor Julien [Thu, 9 Oct 2025 14:03:02 +0000 (16:03 +0200)] 
unittests: clean up memory for icmpv6 tests

3 weeks agounittests: clean up memory for ippair bit tests
Victor Julien [Thu, 9 Oct 2025 13:33:42 +0000 (15:33 +0200)] 
unittests: clean up memory for ippair bit tests

3 weeks agounittests: clean up memory for ipopts tests
Victor Julien [Thu, 9 Oct 2025 12:18:33 +0000 (14:18 +0200)] 
unittests: clean up memory for ipopts tests

3 weeks agounittests: clean up memory for ip-only tests
Victor Julien [Thu, 9 Oct 2025 12:16:37 +0000 (14:16 +0200)] 
unittests: clean up memory for ip-only tests

3 weeks agounittests: clean up memory for app-layer tests
Victor Julien [Thu, 9 Oct 2025 10:43:07 +0000 (12:43 +0200)] 
unittests: clean up memory for app-layer tests

3 weeks agounittests: clean up memory for app-layer proto tests
Victor Julien [Thu, 9 Oct 2025 10:37:46 +0000 (12:37 +0200)] 
unittests: clean up memory for app-layer proto tests

3 weeks agounittests: clean up memory for fast.log tests
Victor Julien [Thu, 9 Oct 2025 10:32:14 +0000 (12:32 +0200)] 
unittests: clean up memory for fast.log tests

3 weeks agounittests: clean up memory for xbits tests
Victor Julien [Thu, 9 Oct 2025 10:26:53 +0000 (12:26 +0200)] 
unittests: clean up memory for xbits tests