]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
3 years agooomd: "descendent" → "descendant" 23200/head
Zbigniew Jędrzejewski-Szmek [Tue, 26 Apr 2022 20:08:02 +0000 (22:08 +0200)] 
oomd: "descendent" → "descendant"

The latter is the common spelling apparently.

3 years agoman: direct users to systemd-oomd if they read about OOMPolicy
Zbigniew Jędrzejewski-Szmek [Tue, 26 Apr 2022 20:05:41 +0000 (22:05 +0200)] 
man: direct users to systemd-oomd if they read about OOMPolicy

OOMPolicy remains valid, but let's push users for the userspace solution.

3 years agoman: beef up the description of systemd-oomd.service
Zbigniew Jędrzejewski-Szmek [Tue, 26 Apr 2022 20:04:31 +0000 (22:04 +0200)] 
man: beef up the description of systemd-oomd.service

The gist of the description is moved from systemd.resource-control
to systemd-oomd man page. Cross-references to OOMPolicy, memory.oom.group,
oomctl, ManagedOOMSwap and ManagedOOMMemoryPressure are added in all
places.

The descriptions are also more down-to-earth: instead of talking
about "taking action" let's just say "kill". We *might* add configuration
for different actions in the future, but we're not there yet, so let's
just describe what we do now.

3 years agooomd: actually fail if configuration is bad
Zbigniew Jędrzejewski-Szmek [Tue, 26 Apr 2022 06:54:39 +0000 (08:54 +0200)] 
oomd: actually fail if configuration is bad

Follow-up for a858355e4a7168625ec1b9e5d17fdb6a11dfecb8.

3 years agomeson: use a single constant for default compression setting 23160/head
Zbigniew Jędrzejewski-Szmek [Fri, 22 Apr 2022 11:10:07 +0000 (13:10 +0200)] 
meson: use a single constant for default compression setting

Suggested by Daniele Nicolodi:
https://github.com/systemd/systemd/pull/23160#discussion_r855853716

This is possible only if the macro is never used in #if, but only in C code.
This means that all places that use #if have to be refactored into C, but we
reduce the duplication a bit, and C is nicer to read than preprocessor
conditionals.

3 years agomeson: simplify setting of default compression
Zbigniew Jędrzejewski-Szmek [Thu, 21 Apr 2022 22:24:01 +0000 (00:24 +0200)] 
meson: simplify setting of default compression

Follow-up for da13d2ca0731b413841663052f2cc6832a855334. Instead of having
separate definitions of the bitmask flags, just define DEFAULT_COMPRESSION_FOO=0|1
directly.

(It *should* be possible to do this more simply, but the problem is that
anything that is used in #if cannot refer to C constants or enums. This is the
simplest I could come up with that preserves the property that we don't use #ifdef.)

The return value from compress_blob() is changed to propagate the error instead
of always returning -EOPNOTSUPP. The callers don't care about the specific error
value. compress_blob_*() are changed to return the compression method on success, so
that compress_blob() can be simplified. compress_stream_*() and compress_stream() are
changed in the same way for consistency, even though the callers do not currently use
this information (outside of tests).

3 years agohwdb 60-keyboard Add HP/Compaq KBR0133
Matthew Blythe [Thu, 21 Apr 2022 06:50:13 +0000 (00:50 -0600)] 
hwdb 60-keyboard Add HP/Compaq KBR0133

3 years agomain: voidify call to kmod_setup()
Lennart Poettering [Thu, 21 Apr 2022 08:37:12 +0000 (10:37 +0200)] 
main: voidify call to kmod_setup()

3 years agosd-bus: switch to a manual overflow check in sd_bus_track_add_name()
Lennart Poettering [Wed, 20 Apr 2022 20:30:22 +0000 (22:30 +0200)] 
sd-bus: switch to a manual overflow check in sd_bus_track_add_name()

This is generally used in a directly client controllable way, hence we
should handle ref count overflow gracefully, instead of hitting an
assert().

As discussed:

https://github.com/systemd/systemd/pull/23099#discussion_r854341850

3 years agomacro: upgrade ref counting overflow check assert() → assert_se()
Lennart Poettering [Wed, 20 Apr 2022 20:10:43 +0000 (22:10 +0200)] 
macro: upgrade ref counting overflow check assert() → assert_se()

The overflow check for ref counting should not be subject to NDEBUG,
hence upgrade assert() → assert_se(). (The check for zero is an
immediate bug in our code, and should be impossible to trigger, hence
it's fine if the check is optimized away if people are crazy enough to
set NDEBUG, so that can stay assert())

https://github.com/systemd/systemd/pull/23099#discussion_r854341850

3 years agoupdate TODO
Lennart Poettering [Wed, 20 Apr 2022 21:19:57 +0000 (23:19 +0200)] 
update TODO

3 years agoMerge pull request #23122 from poettering/creds-has-tpm2
Lennart Poettering [Wed, 20 Apr 2022 21:18:02 +0000 (23:18 +0200)] 
Merge pull request #23122 from poettering/creds-has-tpm2

tpm2: beef up tpm2 support checks

3 years agoman: update TPM2 PCR documentation
Lennart Poettering [Thu, 14 Apr 2022 12:38:52 +0000 (14:38 +0200)] 
man: update TPM2 PCR documentation

The assignments were partly simply incorrectly documented, partly changed
with 4d32507f5186a89e98093659fbbe386787a97b9f and partly missing.
Moreover kernel 5.17 now measures all initrds to PCR 9 on its own
(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f046fff8bc4c4d8f8a478022e76e40b818f692df)

Let's correct all this and bring it up-to-date.

And while we are at it extend the docs about this in systemd-stub, with
a new table that indicates which OS resource is protected by which PCR.

3 years agoMerge pull request #23084 from poettering/creds-no-tpm2-fallback
Yu Watanabe [Wed, 20 Apr 2022 19:11:19 +0000 (04:11 +0900)] 
Merge pull request #23084 from poettering/creds-no-tpm2-fallback

creds: add semi-automatic fallback support for initrd credentials on systems lacking TPM2

3 years agoMerge pull request #23099 from yuwata/sd-bus-track-fixlets
Lennart Poettering [Wed, 20 Apr 2022 16:23:05 +0000 (18:23 +0200)] 
Merge pull request #23099 from yuwata/sd-bus-track-fixlets

sd-bus: fix counter

3 years agoupdate TODO 23084/head
Lennart Poettering [Thu, 14 Apr 2022 14:20:45 +0000 (16:20 +0200)] 
update TODO

3 years agocreds-util: permit credentials encrypted/signed by fixed zero length keys as fallback...
Lennart Poettering [Thu, 14 Apr 2022 12:46:40 +0000 (14:46 +0200)] 
creds-util: permit credentials encrypted/signed by fixed zero length keys as fallback for systems lacking TPM2

This is supposed to be useful when generating credentials for immutable
initrd environments, where it is is relevant to support credentials even
on systems lacking a TPM2 chip.

With this, if `systemd-creds encrypt --with-key=auto-initrd` is used a
credential will be encrypted/signed with the TPM2 if it is available and
recognized by the firmware. Otherwise it will be encrypted/signed with
the fixed empty key, thus providing no confidentiality or authenticity.

The idea is that distributions use this mode to generically create
credentials that are as locked down as possible on the specific
platform.

3 years agocreds-util: add an explicit 128bit ID for identifying "automatic" key determination
Lennart Poettering [Thu, 14 Apr 2022 13:37:54 +0000 (15:37 +0200)] 
creds-util: add an explicit 128bit ID for identifying "automatic" key determination

Previously, when encrypting creds you could pick which key to use for
this via a 128bit ID identifying the key type, and use an all zero ID
for rquesting automatic mode.

Let's change this to use an explicitly picked 128bit ID for automatic
mode, i.e. something other than all zeros. This is in preparation for
adding one further automatic mode with slightly different semantics.

no change in behaviour.

Note that the new 128bit id is never written to disk but only used
internally to indicate a specific case.

3 years agocreds-util: refuse unexpected key types explicitly
Lennart Poettering [Thu, 14 Apr 2022 13:26:02 +0000 (15:26 +0200)] 
creds-util: refuse unexpected key types explicitly

3 years agoMerge pull request #23124 from yuwata/fixes-for-post-merge-review
Daan De Meyer [Wed, 20 Apr 2022 15:15:40 +0000 (17:15 +0200)] 
Merge pull request #23124 from yuwata/fixes-for-post-merge-review

Fixes for post merge review

3 years agoman: document new has-tpm2 verb 23122/head
Lennart Poettering [Tue, 19 Apr 2022 13:08:23 +0000 (15:08 +0200)] 
man: document new has-tpm2 verb

3 years agocreds-tool: add new "has-tpm2" verb
Lennart Poettering [Tue, 19 Apr 2022 12:47:02 +0000 (14:47 +0200)] 
creds-tool: add new "has-tpm2" verb

Sometimes it's useful from shell scripts to check if we have a working
TPM2 chip around. For example, when putting together encrypted
credentials for the initrd (after all: it might be wise to place the
root pw in a credential for the initrd to consume, but do so only if we
can lock it to the TPM2, and not otherwise, so that we risk nothing).

Hence, let's add a new "systemd-creds has-tpm2" verb: it returns zero if we
have a working TPM2 (which means: supported by kernel + firmware + us),
or non-zero otherwise. Also show which parts are available.

Use-case: in future the 'kernel-install' script should use this when
deciding whether to augment kernels with security sensitive credentials.

3 years agobootctl: use new tpm2_support() helper to show TPM2 info
Lennart Poettering [Tue, 19 Apr 2022 12:45:20 +0000 (14:45 +0200)] 
bootctl: use new tpm2_support() helper to show TPM2 info

Let's improve the output regarding TPM2 support in "bootctl": let's show
whether we have local driver support and/or firmware support, and
colorize it.

(For now, don't show if we natively support TPM2, since the tool is
mostly bout boot time stuff, where it dosn't really matter much what we
do in userspace)

3 years agocondition: rework ConditionSecurity=tpm2 check on top of tpm2_support()
Lennart Poettering [Tue, 19 Apr 2022 12:44:26 +0000 (14:44 +0200)] 
condition: rework ConditionSecurity=tpm2 check on top of tpm2_support()

No change in behaviour. Let's just use our new helper here.

3 years agotpm2-util: add helper that checks for the various facets of TPM2 support
Lennart Poettering [Tue, 19 Apr 2022 12:42:27 +0000 (14:42 +0200)] 
tpm2-util: add helper that checks for the various facets of TPM2 support

So far we were a bit sloppy regarding checks for TPM2 support. Let's
make things more precise and introduce a single helper that checks for
three axis of TPM2 support: whether we have a loaded kernel driver,
whether the firmware used it, and whether we ourselves are compiled for
it.

This only adds the helper. Follow-up patches will use it at various
places.

3 years agoupdate TODO
Lennart Poettering [Wed, 20 Apr 2022 13:32:10 +0000 (15:32 +0200)] 
update TODO

3 years agoupdate TODO
Lennart Poettering [Wed, 20 Apr 2022 12:49:43 +0000 (14:49 +0200)] 
update TODO

3 years agoMerge pull request #23126 from keszybz/clone3-prohibit
Luca Boccassi [Wed, 20 Apr 2022 09:27:58 +0000 (11:27 +0200)] 
Merge pull request #23126 from keszybz/clone3-prohibit

Prohibit clone3() when RestrictNamespaces is used

3 years agocompression: add separate pre-processor definitions
Luca Boccassi [Tue, 19 Apr 2022 14:23:53 +0000 (16:23 +0200)] 
compression: add separate pre-processor definitions

Follow-up for https://github.com/systemd/systemd/commit/cd3c6322dbc6370448bafc216ee4e19e32a79d9e

journal-def.h should be self-contained too, as it represents the journal object ABI.
Duplicate the enums, as they also need to be in config.h for it to be self-contained,
and enums are not available to the preprocessor. Use an assert to ensure they don't
diverge.

3 years agomanager: prohibit clone3() in seccomp filters 23126/head
Zbigniew Jędrzejewski-Szmek [Tue, 19 Apr 2022 10:44:26 +0000 (12:44 +0200)] 
manager: prohibit clone3() in seccomp filters

RestrictNamespaces should block clone3() like flatpak:
https://github.com/flatpak/flatpak/commit/a10f52a7565c549612c92b8e736a6698a53db330

clone3() passes arguments in a structure referenced by a pointer, so we can't
filter on the flags as with clone(). Let's disallow the whole function call.

3 years agonspawn: fix --ephemeral with --machine
Luca Boccassi [Tue, 19 Apr 2022 10:45:26 +0000 (12:45 +0200)] 
nspawn: fix --ephemeral with --machine

Follow-up for https://github.com/systemd/systemd/commit/2362fdde1bd4bf54772383ef29431f683729ba76

When --machine is specified with --ephemeral, no random suffix is added, so
the recently added assert would fail.

Add a top-level variable with the expected file name for nspawn files, and
compute it when the rest of the names are computed.

3 years agovirt: detect OpenStack Nova instance
w30023233 [Tue, 19 Apr 2022 13:05:25 +0000 (21:05 +0800)] 
virt: detect OpenStack Nova instance

3 years agofirewall-util: emphasize that nfnl_netlink_sendv() takes at least one message 23124/head
Yu Watanabe [Tue, 19 Apr 2022 17:27:14 +0000 (02:27 +0900)] 
firewall-util: emphasize that nfnl_netlink_sendv() takes at least one message

Addresses https://github.com/systemd/systemd/pull/23090#discussion_r853002631.

3 years agoefi-api: use string_replace_char()
Yu Watanabe [Tue, 19 Apr 2022 17:23:11 +0000 (02:23 +0900)] 
efi-api: use string_replace_char()

3 years agosd-device: use string_replace_char() and strspn_from_end()
Yu Watanabe [Tue, 19 Apr 2022 17:19:44 +0000 (02:19 +0900)] 
sd-device: use string_replace_char() and strspn_from_end()

3 years agostring-util: introduce strspn_from_end()
Yu Watanabe [Tue, 19 Apr 2022 17:15:01 +0000 (02:15 +0900)] 
string-util: introduce strspn_from_end()

3 years agostring-util: introduce string_replace_char()
Yu Watanabe [Tue, 19 Apr 2022 16:58:28 +0000 (01:58 +0900)] 
string-util: introduce string_replace_char()

3 years agosd-device: refuse O_DIRECTORY returned from path_extract_filename()
Yu Watanabe [Tue, 19 Apr 2022 16:43:11 +0000 (01:43 +0900)] 
sd-device: refuse O_DIRECTORY returned from path_extract_filename()

In both cases, it is expected that the symlink targets do not end with '/'.

Addresses https://github.com/systemd/systemd/pull/23089#discussion_r853007218.

3 years agopath-util: make readlink_value() refuse O_DIRECTORY returned from path_extract_filename()
Yu Watanabe [Tue, 19 Apr 2022 16:40:36 +0000 (01:40 +0900)] 
path-util: make readlink_value() refuse O_DIRECTORY returned from path_extract_filename()

The function is now only used by sd-device.c and pam_systemd.c, and they
expects the result are not directory. Hence, it is safe to change the
behavior.

Addresses https://github.com/systemd/systemd/pull/23089#discussion_r853006017.

3 years agohostnamed: display firmware version
Sonali Srivastava [Mon, 18 Apr 2022 18:47:50 +0000 (00:17 +0530)] 
hostnamed: display firmware version

3 years agoupdate TODO
Lennart Poettering [Tue, 19 Apr 2022 10:43:14 +0000 (12:43 +0200)] 
update TODO

3 years agoshared/seccomp: add note about clone2() being unimportant
Zbigniew Jędrzejewski-Szmek [Tue, 19 Apr 2022 09:56:23 +0000 (11:56 +0200)] 
shared/seccomp: add note about clone2() being unimportant

In case anyone else starts wondering whether it should be listed
as I did…

3 years agotest: add several tests for track item 23099/head
Yu Watanabe [Sat, 16 Apr 2022 22:58:45 +0000 (07:58 +0900)] 
test: add several tests for track item

3 years agotest: shorten code a bit
Yu Watanabe [Sat, 16 Apr 2022 22:35:05 +0000 (07:35 +0900)] 
test: shorten code a bit

3 years agosd-bus: use hashmap_contains() and drop unnecessary cast
Yu Watanabe [Sat, 16 Apr 2022 23:00:20 +0000 (08:00 +0900)] 
sd-bus: use hashmap_contains() and drop unnecessary cast

3 years agosd-bus: do not return negative errno when unknown name is specified
Yu Watanabe [Sat, 16 Apr 2022 22:29:24 +0000 (07:29 +0900)] 
sd-bus: do not return negative errno when unknown name is specified

When 'recursive' is false, then sd_bus_track_remove_name() does not
return negative errno when unknown name is specified. Let's follow the
same pattern for the case that 'recursive' is true.

3 years agosd-bus: do not read unused value
Yu Watanabe [Sat, 16 Apr 2022 22:25:09 +0000 (07:25 +0900)] 
sd-bus: do not read unused value

3 years agosd-bus: introduce ref/unref function for track_item
Yu Watanabe [Sat, 16 Apr 2022 22:20:16 +0000 (07:20 +0900)] 
sd-bus: introduce ref/unref function for track_item

3 years agosd-bus: fix reference counter to be incremented
Yu Watanabe [Sat, 16 Apr 2022 22:05:07 +0000 (07:05 +0900)] 
sd-bus: fix reference counter to be incremented

Fixes #23097.

3 years agomacro: check over flow in reference counter
Yu Watanabe [Sat, 16 Apr 2022 21:54:50 +0000 (06:54 +0900)] 
macro: check over flow in reference counter

3 years agojson: use unsigned for refernce counter
Yu Watanabe [Sat, 16 Apr 2022 21:46:25 +0000 (06:46 +0900)] 
json: use unsigned for refernce counter

For other places, we use unsigned for reference counter.

3 years agohwdb: 60-keyboard: Add Acer Aspire One AO532h keymappings
Hans de Goede [Mon, 18 Apr 2022 18:36:39 +0000 (20:36 +0200)] 
hwdb: 60-keyboard: Add Acer Aspire One AO532h keymappings

Add keymappings for the Acer Aspire One AO532h netbook.

Unmap the brightnesskeys because they send duplicate key events with
the ACPI video bus key events and add a mapping for the bluetooth
on/off hotkey.

3 years agonspawn: fix locating config files with --ephemeral
Luca Boccassi [Mon, 18 Apr 2022 16:39:18 +0000 (18:39 +0200)] 
nspawn: fix locating config files with --ephemeral

When --ephemeral is used, a random 16 characters suffix is added to the image
name, so matching on .nspawn files based on the image name no longer works.

Fixes https://github.com/systemd/systemd/issues/13297

3 years agohwdb: Update 60-keyboard.hwdb (#23074)
davijosw [Mon, 18 Apr 2022 11:51:45 +0000 (08:51 -0300)] 
hwdb: Update 60-keyboard.hwdb (#23074)

Fix Fn+F1 (toggle touchpad) that wasn't working.

Closes #23058

3 years agoMerge pull request #23107 from yuwata/man-network-numeric-prefix 23068/head
Yu Watanabe [Sun, 17 Apr 2022 22:02:10 +0000 (07:02 +0900)] 
Merge pull request #23107 from yuwata/man-network-numeric-prefix

man: recommend that .network or friends should have a numeric prefix

3 years agoMerge pull request #23101 from yuwata/sd-device-cleanups
Yu Watanabe [Sun, 17 Apr 2022 22:01:42 +0000 (07:01 +0900)] 
Merge pull request #23101 from yuwata/sd-device-cleanups

sd-device: several cleanups

3 years agoresolve: fix typo in dns_class_is_pseudo()
Yu Watanabe [Sun, 17 Apr 2022 17:09:58 +0000 (02:09 +0900)] 
resolve: fix typo in dns_class_is_pseudo()

3 years agocompression: add build-time option to select default
Luca Boccassi [Sat, 9 Apr 2022 17:38:06 +0000 (18:38 +0100)] 
compression: add build-time option to select default

Compression and decompression are controlled by the same build flag,
so if one wants to use, say, LZ4 to compress, ZSTD has to be disabled,
which means one loses the ability to read zstd-compressed journals.

Add a default-compression meson option, that allows to select any of
the available compression algorithms as the default.

3 years agosd-device: rename arguments and variables 23101/head
Yu Watanabe [Sun, 17 Apr 2022 07:09:57 +0000 (16:09 +0900)] 
sd-device: rename arguments and variables

3 years agosd-device: fix possible use-of-uninitialized-value
Yu Watanabe [Sun, 17 Apr 2022 07:09:11 +0000 (16:09 +0900)] 
sd-device: fix possible use-of-uninitialized-value

3 years agosd-device: use ERRNO_IS_DEVICE_ABSENT() at one more place
Yu Watanabe [Sun, 17 Apr 2022 05:59:06 +0000 (14:59 +0900)] 
sd-device: use ERRNO_IS_DEVICE_ABSENT() at one more place

3 years agosd-device: rename function arguments for storing results
Yu Watanabe [Sun, 17 Apr 2022 05:51:13 +0000 (14:51 +0900)] 
sd-device: rename function arguments for storing results

3 years agosd-device: use correct type and parser for device node uid and gid
Yu Watanabe [Sun, 17 Apr 2022 05:45:45 +0000 (14:45 +0900)] 
sd-device: use correct type and parser for device node uid and gid

3 years agosd-device: shorten code a bit
Yu Watanabe [Sun, 17 Apr 2022 05:29:07 +0000 (14:29 +0900)] 
sd-device: shorten code a bit

3 years agosd-device: use path_extract_filename() at one more place
Yu Watanabe [Sun, 17 Apr 2022 05:25:27 +0000 (14:25 +0900)] 
sd-device: use path_extract_filename() at one more place

This also does several cleanups.

3 years agosd-device: reset sysname and sysnum on renaming
Yu Watanabe [Sun, 17 Apr 2022 04:38:39 +0000 (13:38 +0900)] 
sd-device: reset sysname and sysnum on renaming

3 years agosd-device: reduce indentation
Yu Watanabe [Sun, 17 Apr 2022 04:11:08 +0000 (13:11 +0900)] 
sd-device: reduce indentation

3 years agosd-device: verify new syspath on renaming
Yu Watanabe [Sun, 17 Apr 2022 04:07:38 +0000 (13:07 +0900)] 
sd-device: verify new syspath on renaming

3 years agoman: DHCPPrefixDelegation= needs to be enabled on downstream side for assigning deleg... 23107/head
Yu Watanabe [Sun, 17 Apr 2022 18:58:29 +0000 (03:58 +0900)] 
man: DHCPPrefixDelegation= needs to be enabled on downstream side for assigning delegated prefixes

Closes #23041.

3 years agoman: recommend that .network or friends should have a numeric prefix
Yu Watanabe [Sun, 17 Apr 2022 18:08:55 +0000 (03:08 +0900)] 
man: recommend that .network or friends should have a numeric prefix

Closes #23105.

3 years agoudevadm: info: also show parent devices by --tree
Yu Watanabe [Thu, 14 Apr 2022 08:12:10 +0000 (17:12 +0900)] 
udevadm: info: also show parent devices by --tree

3 years agoMerge pull request #23100 from yuwata/network-fix-tunnel-address-parser
Luca Boccassi [Sun, 17 Apr 2022 19:24:38 +0000 (21:24 +0200)] 
Merge pull request #23100 from yuwata/network-fix-tunnel-address-parser

network: fix tunnel address parser

3 years agoAdd test support for systemd-tmpfiles.standalone
Mike Gilbert [Sun, 17 Apr 2022 13:48:28 +0000 (09:48 -0400)] 
Add test support for  systemd-tmpfiles.standalone

3 years agoMerge pull request #23093 from mrc0mmand/test-md-partitions
Yu Watanabe [Sun, 17 Apr 2022 16:26:30 +0000 (01:26 +0900)] 
Merge pull request #23093 from mrc0mmand/test-md-partitions

test: more MD coverage improvements

3 years agotest: partition the MD device 23093/head
Frantisek Sumsal [Fri, 15 Apr 2022 17:01:45 +0000 (19:01 +0200)] 
test: partition the MD device

Also, loop the assemble/disassemble part couple of times to test udev
even harder.

Resolves: #23092

3 years agotest: cleanup after the MD + LVM test case as well
Frantisek Sumsal [Sat, 16 Apr 2022 20:43:20 +0000 (05:43 +0900)] 
test: cleanup after the MD + LVM test case as well

3 years agosystemctl: colorize "enabled" in 'systemctl status ...'
amarjargal [Fri, 15 Apr 2022 17:29:15 +0000 (01:29 +0800)] 
systemctl: colorize "enabled" in 'systemctl status ...'

"enabled" state is highlighted in green and "disabled" state is
highlighted in yellow because I felt that white and grey colors were not
so distinguishable. Other states are not highlighted. Any other coloring
suggestions are welcome!

Closes #16932.

3 years agonetwork: l2tp: refuse null address 23100/head
Yu Watanabe [Sun, 17 Apr 2022 00:29:24 +0000 (09:29 +0900)] 
network: l2tp: refuse null address

3 years agonetwork: tunnel: handle null address as "any"
Yu Watanabe [Sun, 17 Apr 2022 00:19:26 +0000 (09:19 +0900)] 
network: tunnel: handle null address as "any"

Fixes oss-fuzz#44881 (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44881).

Fixes #23098.

3 years agoRevert "lgtm: disable cpp/missing-return (again)"
Frantisek Sumsal [Sat, 16 Apr 2022 09:36:02 +0000 (11:36 +0200)] 
Revert "lgtm: disable cpp/missing-return (again)"

This reverts commit 000096f4c61477f96fbd9c48b2d772c7c690d259.

After a couple of manual tests LGTM finally appears to have the fix for
https://github.com/github/codeql/issues/8409, so let's reenable the
check for the last time.

3 years agoMerge pull request #23089 from yuwata/sd-device-use-path_extract_filename
Yu Watanabe [Sat, 16 Apr 2022 05:33:58 +0000 (14:33 +0900)] 
Merge pull request #23089 from yuwata/sd-device-use-path_extract_filename

sd-device: use path_extract_filename()

3 years agoMerge pull request #23021 from fbuihuu/tmpfiles-fix-precedence-with-plus-sign
Yu Watanabe [Fri, 15 Apr 2022 16:36:51 +0000 (01:36 +0900)] 
Merge pull request #23021 from fbuihuu/tmpfiles-fix-precedence-with-plus-sign

Tmpfiles fix precedence with plus sign

3 years agoshared/install: fix crash when reenable is called without --root
Zbigniew Jędrzejewski-Szmek [Tue, 12 Apr 2022 18:42:32 +0000 (20:42 +0200)] 
shared/install: fix crash when reenable is called without --root

3 years agotest: add tests for sd_device_get_sysnum() 23089/head
Yu Watanabe [Fri, 15 Apr 2022 05:06:56 +0000 (14:06 +0900)] 
test: add tests for sd_device_get_sysnum()

3 years agosd-device: shorten code a bit
Yu Watanabe [Fri, 15 Apr 2022 04:45:26 +0000 (13:45 +0900)] 
sd-device: shorten code a bit

3 years agosd-device: use path_extract_filename() at one more place
Yu Watanabe [Fri, 15 Apr 2022 04:29:53 +0000 (13:29 +0900)] 
sd-device: use path_extract_filename() at one more place

3 years agonetworkctl: obey --full with lldp command
Simon Ellmann [Wed, 13 Apr 2022 19:53:10 +0000 (04:53 +0900)] 
networkctl: obey --full with lldp command

Do not ellipsize output when -l or --full is handed to networkctl lldp.

Fixes #22806.

3 years agofs-util: use path_extract_filename() at one more place
Yu Watanabe [Fri, 15 Apr 2022 04:33:43 +0000 (13:33 +0900)] 
fs-util: use path_extract_filename() at one more place

3 years agoMerge pull request #23090 from yuwata/firewall-util-cleanups
Yu Watanabe [Fri, 15 Apr 2022 11:11:58 +0000 (20:11 +0900)] 
Merge pull request #23090 from yuwata/firewall-util-cleanups

firewall-util: cleanups

3 years agofirewall-util: inline iterator and add several missing assertions 23090/head
Yu Watanabe [Fri, 15 Apr 2022 08:38:31 +0000 (17:38 +0900)] 
firewall-util: inline iterator and add several missing assertions

3 years agosd-netlink: use correct type of iterator
Yu Watanabe [Fri, 15 Apr 2022 08:37:52 +0000 (17:37 +0900)] 
sd-netlink: use correct type of iterator

3 years agoMerge pull request #23081 from mrc0mmand/more-md-tests
Yu Watanabe [Fri, 15 Apr 2022 05:30:55 +0000 (14:30 +0900)] 
Merge pull request #23081 from mrc0mmand/more-md-tests

test: extend the MD coverage with more RAID levels and LVM

3 years agoboot: Add missing continue statements
Jan Janssen [Thu, 14 Apr 2022 11:34:07 +0000 (13:34 +0200)] 
boot: Add missing continue statements

Fortunately, this was not causing any issues as it will just try
the other option branches unsuccessfuly before going to the next
config line.

3 years agoupdate TODO
Lennart Poettering [Thu, 14 Apr 2022 16:37:32 +0000 (18:37 +0200)] 
update TODO

3 years agoupdate TODO
Lennart Poettering [Thu, 14 Apr 2022 13:15:11 +0000 (15:15 +0200)] 
update TODO

3 years agotest: add a test case for MD + LVM + ext4 23081/head
Frantisek Sumsal [Thu, 14 Apr 2022 10:54:16 +0000 (12:54 +0200)] 
test: add a test case for MD + LVM + ext4

3 years agotest: extend testcase_mdadm_basic() with RAID 5 and 10
Frantisek Sumsal [Thu, 14 Apr 2022 10:30:42 +0000 (12:30 +0200)] 
test: extend testcase_mdadm_basic() with RAID 5 and 10

3 years agoMerge pull request #23073 from medhefgo/boot-fixes
Yu Watanabe [Thu, 14 Apr 2022 07:58:21 +0000 (16:58 +0900)] 
Merge pull request #23073 from medhefgo/boot-fixes

boot: Some fixes

3 years agoAdd ConditionCPUFeature to load-fragment-gperf.gperf (#23076)
Eduard Tolosa [Thu, 14 Apr 2022 06:30:03 +0000 (01:30 -0500)] 
Add ConditionCPUFeature to load-fragment-gperf.gperf (#23076)

Fixes #23075

3 years agoboot: Use correct device root when loading device trees 23073/head
Jan Janssen [Thu, 10 Mar 2022 11:32:15 +0000 (12:32 +0100)] 
boot: Use correct device root when loading device trees

If the boot entry comes from a XBOOT partition, we have to load the device
tree from that instead of the ESP.