]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
3 years agotest: add +x to assert.sh 25207/head
Luca Boccassi [Mon, 31 Oct 2022 21:18:53 +0000 (21:18 +0000)] 
test: add +x to assert.sh

The script has a shebang and .sh extension, so make it executable

W: systemd-tests: script-not-executable [usr/lib/systemd/tests/testdata/units/assert.sh]

3 years agoman: fix typo found by Lintian
Luca Boccassi [Mon, 31 Oct 2022 21:17:47 +0000 (21:17 +0000)] 
man: fix typo found by Lintian

3 years agoMerge pull request #25143 from yuwata/network-reconfigure-interface-when-renamed
Luca Boccassi [Mon, 31 Oct 2022 20:14:24 +0000 (21:14 +0100)] 
Merge pull request #25143 from yuwata/network-reconfigure-interface-when-renamed

network: reconfigure interface when renamed

3 years agonetwork: skip to reassign master ifindex if already set
Yu Watanabe [Thu, 27 Oct 2022 21:40:07 +0000 (06:40 +0900)] 
network: skip to reassign master ifindex if already set

Otherwise, the slave interface may go down, especially when the master
is bond.

Fixes #25067.

3 years agomeson: systemd-repart.standalone
Zbigniew JÄ™drzejewski-Szmek [Thu, 27 Oct 2022 06:31:30 +0000 (08:31 +0200)] 
meson: systemd-repart.standalone

Repart is growing into an important tool on its own, and users might
want to install newer versions on systems that have older systemd. Let's
make this easier by providing a standalone binary.

Related to https://github.com/systemd/mkosi/issues/1228.

3 years agoudev: drop trivial wrapper for udev_watch_begin()
Yu Watanabe [Tue, 25 Oct 2022 21:07:30 +0000 (06:07 +0900)] 
udev: drop trivial wrapper for udev_watch_begin()

3 years agoudev: Handle AMBA bus the same way as generic platform bus
Marek Vasut [Tue, 25 Oct 2022 10:50:09 +0000 (12:50 +0200)] 
udev: Handle AMBA bus the same way as generic platform bus

On various ARM systems, it is possible to find devices on AMBA bus.
This is defined in Linux kernel drivers/amba/bus.c as separate bus
type. Udev currently does not recognize this when building ID_PATH
which leads to ID_PATH containing the suffix from next recognized
parent device. On ST STM32MP15xx with SDIO WiFi, the ID_PATH looks
like 'platform-soc', which is not unique and basically useless. On
NXP i.MX8M Plus with SDIO WiFi, ID_PATH is 'platform-30b40000.mmc'
which is far more useful.

Add the 'amba' subsystem handling the same way 'platform' subsystem
is handled to get ID_PATH 'platform-soc-amba-48004000.sdmmc' on the
former, which is far more useful compared to 'platform-soc'.

---

```
$ udevadm info --attribute-walk --path=/devices/platform/soc/48004000.mmc/mmc_host/mmc1/mmc1:0001/mmc1:0001:1/net/wlan0

Udevadm info starts with the device specified by the devpath and then
walks up the chain of parent devices. It prints for every device
found, all possible attributes in the udev rules key format.
A rule to match, can be composed by the attributes of the device
and the attributes from one single parent device.

  looking at device '/devices/platform/soc/48004000.mmc/mmc_host/mmc1/mmc1:0001/mmc1:0001:1/net/wlan0':
    KERNEL=="wlan0"
    SUBSYSTEM=="net"
    DRIVER==""
    ATTR{addr_assign_type}=="0"
    ATTR{addr_len}=="6"
    ATTR{address}=="10:98:c3:5f:4b:80"
    ATTR{broadcast}=="ff:ff:ff:ff:ff:ff"
    ATTR{carrier_changes}=="1"
    ATTR{carrier_down_count}=="1"
    ATTR{carrier_up_count}=="0"
    ATTR{dev_id}=="0x0"
    ATTR{dev_port}=="0"
    ATTR{flags}=="0x1002"
    ATTR{gro_flush_timeout}=="0"
    ATTR{ifalias}==""
    ATTR{ifindex}=="3"
    ATTR{iflink}=="3"
    ATTR{link_mode}=="0"
    ATTR{mtu}=="1500"
    ATTR{napi_defer_hard_irqs}=="0"
    ATTR{netdev_group}=="0"
    ATTR{operstate}=="down"
    ATTR{power/control}=="auto"
    ATTR{power/runtime_active_time}=="0"
    ATTR{power/runtime_status}=="unsupported"
    ATTR{power/runtime_suspended_time}=="0"
    ATTR{proto_down}=="0"
    ATTR{queues/rx-0/rps_cpus}=="0"
    ATTR{queues/rx-0/rps_flow_cnt}=="0"
    ATTR{queues/tx-0/byte_queue_limits/hold_time}=="1000"
    ATTR{queues/tx-0/byte_queue_limits/inflight}=="0"
    ATTR{queues/tx-0/byte_queue_limits/limit}=="0"
    ATTR{queues/tx-0/byte_queue_limits/limit_max}=="1879048192"
    ATTR{queues/tx-0/byte_queue_limits/limit_min}=="0"
    ATTR{queues/tx-0/tx_maxrate}=="0"
    ATTR{queues/tx-0/tx_timeout}=="0"
    ATTR{queues/tx-0/xps_rxqs}=="0"
    ATTR{statistics/collisions}=="0"
    ATTR{statistics/multicast}=="0"
    ATTR{statistics/rx_bytes}=="0"
    ATTR{statistics/rx_compressed}=="0"
    ATTR{statistics/rx_crc_errors}=="0"
    ATTR{statistics/rx_dropped}=="0"
    ATTR{statistics/rx_errors}=="0"
    ATTR{statistics/rx_fifo_errors}=="0"
    ATTR{statistics/rx_frame_errors}=="0"
    ATTR{statistics/rx_length_errors}=="0"
    ATTR{statistics/rx_missed_errors}=="0"
    ATTR{statistics/rx_nohandler}=="0"
    ATTR{statistics/rx_over_errors}=="0"
    ATTR{statistics/rx_packets}=="0"
    ATTR{statistics/tx_aborted_errors}=="0"
    ATTR{statistics/tx_bytes}=="0"
    ATTR{statistics/tx_carrier_errors}=="0"
    ATTR{statistics/tx_compressed}=="0"
    ATTR{statistics/tx_dropped}=="0"
    ATTR{statistics/tx_errors}=="0"
    ATTR{statistics/tx_fifo_errors}=="0"
    ATTR{statistics/tx_heartbeat_errors}=="0"
    ATTR{statistics/tx_packets}=="0"
    ATTR{statistics/tx_window_errors}=="0"
    ATTR{threaded}=="0"
    ATTR{tx_queue_len}=="1000"
    ATTR{type}=="1"

  looking at parent device '/devices/platform/soc/48004000.mmc/mmc_host/mmc1/mmc1:0001/mmc1:0001:1':
    KERNELS=="mmc1:0001:1"
    SUBSYSTEMS=="sdio"
    DRIVERS=="brcmfmac"
    ATTRS{class}=="0x00"
    ATTRS{coredump}=="(write-only)"
    ATTRS{device}=="0xa9bf"
    ATTRS{power/control}=="auto"
    ATTRS{power/runtime_active_time}=="0"
    ATTRS{power/runtime_status}=="unsupported"
    ATTRS{power/runtime_suspended_time}=="0"
    ATTRS{revision}=="0.0"
    ATTRS{vendor}=="0x02d0"

  looking at parent device '/devices/platform/soc/48004000.mmc/mmc_host/mmc1/mmc1:0001':
    KERNELS=="mmc1:0001"
    SUBSYSTEMS=="mmc"
    DRIVERS==""
    ATTRS{device}=="0xa9bf"
    ATTRS{ocr}=="0x00200000"
    ATTRS{power/control}=="auto"
    ATTRS{power/runtime_active_time}=="0"
    ATTRS{power/runtime_status}=="unsupported"
    ATTRS{power/runtime_suspended_time}=="0"
    ATTRS{rca}=="0x0001"
    ATTRS{revision}=="0.0"
    ATTRS{type}=="SDIO"
    ATTRS{vendor}=="0x02d0"

  looking at parent device '/devices/platform/soc/48004000.mmc/mmc_host/mmc1':
    KERNELS=="mmc1"
    SUBSYSTEMS=="mmc_host"
    DRIVERS==""
    ATTRS{power/control}=="auto"
    ATTRS{power/runtime_active_time}=="0"
    ATTRS{power/runtime_status}=="unsupported"
    ATTRS{power/runtime_suspended_time}=="0"

  looking at parent device '/devices/platform/soc/48004000.mmc':
    KERNELS=="48004000.mmc"
    SUBSYSTEMS=="amba" <------------------------------------------------------- AMBA is here
    DRIVERS=="mmci-pl18x"
    ATTRS{driver_override}=="(null)"
    ATTRS{id}=="00253180"
    ATTRS{power/autosuspend_delay_ms}=="50"
    ATTRS{power/control}=="on"
    ATTRS{power/runtime_active_time}=="666709"
    ATTRS{power/runtime_status}=="active"
    ATTRS{power/runtime_suspended_time}=="0"

  looking at parent device '/devices/platform/soc':
    KERNELS=="soc"
    SUBSYSTEMS=="platform"
    DRIVERS=="simple-pm-bus"
    ATTRS{driver_override}=="(null)"
    ATTRS{power/control}=="auto"
    ATTRS{power/runtime_active_time}=="0"
    ATTRS{power/runtime_status}=="unsupported"
    ATTRS{power/runtime_suspended_time}=="0"

  looking at parent device '/devices/platform':
    KERNELS=="platform"
    SUBSYSTEMS==""
    DRIVERS==""
    ATTRS{power/control}=="auto"
    ATTRS{power/runtime_active_time}=="0"
    ATTRS{power/runtime_status}=="unsupported"
    ATTRS{power/runtime_suspended_time}=="0"
```

3 years agosd-bus: convenience functions to emit a signal to a destination (#25123)
Erik Moqvist [Mon, 31 Oct 2022 20:11:48 +0000 (21:11 +0100)] 
sd-bus: convenience functions to emit a signal to a destination (#25123)

* sd-bus: convenience functions to emit a signal to a destination

3 years agoudev-builtin-net_id: support getting usb path off the host
Charles Hardin [Mon, 10 Oct 2022 20:30:10 +0000 (13:30 -0700)] 
udev-builtin-net_id: support getting usb path off the host

To support predictable interface names in various embeeded systems
add support for an additional naming scheming using the USB host
interface. Several asics have usb controllers that are platform
devices and not children of a pci interface. These embedded systems
should be able to enumerate interfaces by udev path as well to support
configurations and policies.

Signed-off-by: Charles Hardin <charles.hardin@chargepoint.com>
3 years agodissect: add --list option
Antonio Alvarez Feijoo [Thu, 20 Oct 2022 06:07:37 +0000 (08:07 +0200)] 
dissect: add --list option

New option to print the paths of all the files and directories in the image to
stdout.

3 years agoMerge pull request #25092 from fbuihuu/random-seed-tweaks
Luca Boccassi [Mon, 31 Oct 2022 20:10:39 +0000 (21:10 +0100)] 
Merge pull request #25092 from fbuihuu/random-seed-tweaks

Random seed tweaks

3 years agoMerge pull request #24958 from Werkov/meson-generated-directives
Luca Boccassi [Mon, 31 Oct 2022 20:04:30 +0000 (21:04 +0100)] 
Merge pull request #24958 from Werkov/meson-generated-directives

Generate dirrectives for fuzzer tests

3 years agoMerge pull request #25134 from medhefgo/macro
Luca Boccassi [Mon, 31 Oct 2022 20:03:39 +0000 (21:03 +0100)] 
Merge pull request #25134 from medhefgo/macro

macro: Small IN_SET improvements

3 years agoMerge pull request #25136 from yuwata/udev-id-renaming
Luca Boccassi [Mon, 31 Oct 2022 20:02:41 +0000 (21:02 +0100)] 
Merge pull request #25136 from yuwata/udev-id-renaming

udev: cleanup for ID_RENAMING property

3 years agoMerge pull request #25142 from yuwata/network-fix-race-in-device-renaming-vs-dhcp
Luca Boccassi [Mon, 31 Oct 2022 20:01:57 +0000 (21:01 +0100)] 
Merge pull request #25142 from yuwata/network-fix-race-in-device-renaming-vs-dhcp

network,dhcp: fix theoretical race in device renaming

3 years agoMerge pull request #25166 from yuwata/network-router-preference
Luca Boccassi [Mon, 31 Oct 2022 19:59:36 +0000 (20:59 +0100)] 
Merge pull request #25166 from yuwata/network-router-preference

network: adjust route metric based on router preference

3 years agodocs/HACKING.md: clarify some portions
William Roberts [Tue, 25 Oct 2022 14:09:29 +0000 (09:09 -0500)] 
docs/HACKING.md: clarify some portions

Clarify portions of HACKING.md so folks don't spend as much time as I
did on it.

Signed-off-by: William Roberts <william.c.roberts@intel.com>
3 years agoFinalise 👻 SpOoOky 👻 NEWS for v252 v252
Release o'Lantern [Mon, 31 Oct 2022 18:53:41 +0000 (18:53 +0000)] 
Finalise ðŸ‘» SpOoOky ðŸ‘» NEWS for v252

3 years agoDisable code freeze banner
Luca Boccassi [Mon, 31 Oct 2022 18:57:04 +0000 (18:57 +0000)] 
Disable code freeze banner

3 years agoMerge pull request #25202 from poettering/measure-phase-fix
Luca Boccassi [Mon, 31 Oct 2022 18:50:31 +0000 (19:50 +0100)] 
Merge pull request #25202 from poettering/measure-phase-fix

measure: honour phases when signing

3 years agoMerge pull request #25200 from bluca/news
Luca Boccassi [Mon, 31 Oct 2022 15:53:10 +0000 (16:53 +0100)] 
Merge pull request #25200 from bluca/news

Update NEWS, hwdb

3 years agomeasure: honour phases when signing 25202/head
Lennart Poettering [Mon, 31 Oct 2022 15:50:20 +0000 (16:50 +0100)] 
measure: honour phases when signing

3 years agomeasure: banks and phases list are always non-empty
Lennart Poettering [Mon, 31 Oct 2022 15:50:13 +0000 (16:50 +0100)] 
measure: banks and phases list are always non-empty

When parsing parameters, we populate these lists with defaults when
empty, hence we can rely that there's at least one bank and one phase
defined.

3 years agoresolved: fix copypasta in resolved varlink API
Lennart Poettering [Mon, 31 Oct 2022 11:22:37 +0000 (12:22 +0100)] 
resolved: fix copypasta in resolved varlink API

As reported by @holtmann

3 years agoUpdate hwdb 25200/head
Luca Boccassi [Mon, 31 Oct 2022 11:20:13 +0000 (11:20 +0000)] 
Update hwdb

ninja -C build update-hwdb

3 years agoUpdate NEWS with latest changes
Luca Boccassi [Mon, 31 Oct 2022 12:15:02 +0000 (12:15 +0000)] 
Update NEWS with latest changes

3 years agoNEWS: update contributors list
Luca Boccassi [Mon, 31 Oct 2022 11:13:21 +0000 (11:13 +0000)] 
NEWS: update contributors list

3 years agoMerge pull request #25197 from weblate/weblate-systemd-master
Luca Boccassi [Mon, 31 Oct 2022 11:54:24 +0000 (12:54 +0100)] 
Merge pull request #25197 from weblate/weblate-systemd-master

Translations update from Fedora Weblate

3 years agopo: Translated using Weblate (Chinese (Simplified) (zh_CN)) 25197/head
Charles Lee [Mon, 31 Oct 2022 11:19:54 +0000 (12:19 +0100)] 
po: Translated using Weblate (Chinese (Simplified) (zh_CN))

Currently translated at 100.0% (193 of 193 strings)

Co-authored-by: Charles Lee <lchopn@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/zh_CN/
Translation: systemd/main

3 years agopo: Translated using Weblate (Croatian)
Gogo Gogsi [Mon, 31 Oct 2022 11:19:54 +0000 (12:19 +0100)] 
po: Translated using Weblate (Croatian)

Currently translated at 100.0% (193 of 193 strings)

Co-authored-by: Gogo Gogsi <linux.hr@protonmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/hr/
Translation: systemd/main

3 years agoman: make clear NNP has no effect on processes invoked through systemd-run/at/crontab...
Lennart Poettering [Mon, 31 Oct 2022 11:13:26 +0000 (12:13 +0100)] 
man: make clear NNP has no effect on processes invoked through systemd-run/at/crontab and such things

3 years agoupdate TODO
Lennart Poettering [Mon, 31 Oct 2022 11:13:15 +0000 (12:13 +0100)] 
update TODO

3 years agoNEWS: Clarify overlapping UKI PE section offsets
Jan Janssen [Mon, 31 Oct 2022 08:52:56 +0000 (09:52 +0100)] 
NEWS: Clarify overlapping UKI PE section offsets

3 years agoMerge pull request #25193 from takaswie/topic/udev/builtin/hwdb/ieee1394/support...
Yu Watanabe [Mon, 31 Oct 2022 06:03:44 +0000 (15:03 +0900)] 
Merge pull request #25193 from takaswie/topic/udev/builtin/hwdb/ieee1394/support-legacy-layout-of-configuration-rom

hwdb: ieee1394-unit-function: arrangement for legacy device

3 years agohwdb: ieee1394-unit-function: add comment about legacy AV/C devices 25193/head
Takashi Sakamoto [Mon, 31 Oct 2022 03:48:31 +0000 (12:48 +0900)] 
hwdb: ieee1394-unit-function: add comment about legacy AV/C devices

It appears that exceptional layout of legacy device requires extra care of
hwdb entry for node device since Linux FireWire subsystem do not pick up
numeric model identifier in vendor directory. In detail, see:

 * https://github.com/systemd/systemd/issues/25029

In the case, udev rule without model attribute is used. Thus hwdb entry
for generic AV/C device should match both cases with and without the
attribute. The wildcard added by a commit 5e577da5f824 ("hwdb: drop model
specifier from general entries") satisfies this condition,

This commit adds comment about it.

3 years agohwdb: ieee1394-unit-function: fullfill for Sony DCR-TRV310
Takashi Sakamoto [Mon, 31 Oct 2022 03:48:31 +0000 (12:48 +0900)] 
hwdb: ieee1394-unit-function: fullfill for Sony DCR-TRV310

It appeared that Sony DCR-TRV310 has legacy layout of configuration ROM
against 1394 TA standard documentation.

 * https://github.com/systemd/systemd/issues/25029

For the case, numeric model identifier and descriptor leaf for model name
are not picked up. This commit fulfill corresponding entry so that
applications can use model name from hardware database.

3 years agoMerge pull request #25190 from mrc0mmand/reenable-test_macsec
Yu Watanabe [Mon, 31 Oct 2022 01:39:11 +0000 (10:39 +0900)] 
Merge pull request #25190 from mrc0mmand/reenable-test_macsec

test-network: re-enable test_macsec

3 years agotest-network: add testcase for reconfiguring interface 25143/head
Yu Watanabe [Thu, 27 Oct 2022 21:25:56 +0000 (06:25 +0900)] 
test-network: add testcase for reconfiguring interface

3 years agonetwork: try to reconfigure when some information is updated
Yu Watanabe [Wed, 26 Oct 2022 02:08:17 +0000 (11:08 +0900)] 
network: try to reconfigure when some information is updated

When at least one of the name, MAC address, udev properties, and so on
for an interface is updated, try to find a matching .network file, and
reconfigure if a new .network file is assigned.

Fixes #24975.

3 years agonetwork: simplify the logic of reading driver and permanent HW address
Yu Watanabe [Wed, 26 Oct 2022 02:43:46 +0000 (11:43 +0900)] 
network: simplify the logic of reading driver and permanent HW address

No functional changes, just refactoring and preparation for later
commits.

Note, `link->dev` should always exist when link state is initialized or
later.

3 years agotest-network: suppress a couple of minor pylint complaints 25190/head
Frantisek Sumsal [Sun, 30 Oct 2022 19:47:04 +0000 (20:47 +0100)] 
test-network: suppress a couple of minor pylint complaints

3 years agotest-network: sort standard imports before "third-party" ones
Frantisek Sumsal [Sun, 30 Oct 2022 19:44:53 +0000 (20:44 +0100)] 
test-network: sort standard imports before "third-party" ones

3 years agotest-network: drop a couple of useless f-strings
Frantisek Sumsal [Sun, 30 Oct 2022 19:43:35 +0000 (20:43 +0100)] 
test-network: drop a couple of useless f-strings

3 years agotest-network: use raw strings where appropriate
Frantisek Sumsal [Sun, 30 Oct 2022 19:40:05 +0000 (20:40 +0100)] 
test-network: use raw strings where appropriate

3 years agotest-network: re-enable test_macsec
Frantisek Sumsal [Sun, 30 Oct 2022 19:27:55 +0000 (20:27 +0100)] 
test-network: re-enable test_macsec

The outstanding kernel panic should be already fixed in recent enough
kernels by [0]. To make the test safe to run anywhere, let's implement
a simple kernel version check and run the test only if we're running
with at least kernel 6.x. The patch might be in some 5.x kernels as
well, but let's be on the safe side and use 6.x as a baseline here
(which is currently the case for Arch and Fedora Rawhide anyway).

[0] https://lore.kernel.org/netdev/7b3fd03e1a46047e5ffe2a389fe74501f0a93206.1656519221.git.sd@queasysnail.net/T/#u

3 years agoboot: Mark some functions as static
Jan Janssen [Sun, 30 Oct 2022 08:28:44 +0000 (09:28 +0100)] 
boot: Mark some functions as static

3 years agoudev: always create device symlinks for USB disks
Yu Watanabe [Sun, 30 Oct 2022 00:43:05 +0000 (09:43 +0900)] 
udev: always create device symlinks for USB disks

Previously, ata_id might not be able to retrieve attributes correctly,
and properties from usb_id were used as a fallback. See issue #24921
and PR #24923. To keep backward compatibility, still we need to create
symlinks based on USB serial.

Fixes #25179.

3 years agoudev: fix for parsing MAC address
Yu Watanabe [Sat, 29 Oct 2022 21:59:31 +0000 (06:59 +0900)] 
udev: fix for parsing MAC address

Fixes a bug introduced by 5bbcfbaa11a92732f9bbc8d5f77e9311e6ac3d56.

Fixes #25181.

3 years agotest: support non-summer time
Yu Watanabe [Sun, 30 Oct 2022 02:59:10 +0000 (11:59 +0900)] 
test: support non-summer time

Follow-up for 759ed0a2533da8840dea315d07f92e6bb0272cdd.

3 years agoman: Add documentation for AssertCredential= (#25178)
Steve Ramage [Sat, 29 Oct 2022 21:07:21 +0000 (14:07 -0700)] 
man: Add documentation for AssertCredential= (#25178)

Fixes #25177.

Co-authored-by: Steve Ramage <gitcommits@sjrx.net>
3 years agoRemove duplicated word
Jochen Sprickerhof [Sat, 29 Oct 2022 05:02:37 +0000 (07:02 +0200)] 
Remove duplicated word

3 years agotest: remove brittle iszero_safe() test
David Seifert [Fri, 28 Oct 2022 21:55:07 +0000 (23:55 +0200)] 
test: remove brittle iszero_safe() test

The test relies on finite -> infinite conversion happening
when increasing DBL_MAX.

Fixes #25044.

3 years agoman: document reboot --poweroff exception
Nick Rosbrook [Fri, 28 Oct 2022 15:01:15 +0000 (11:01 -0400)] 
man: document reboot --poweroff exception

When reboot is invoked, the -p/--poweroff option is intentionally
ignored. Update the man page to reflect this exception.

3 years agotmpfiles: downgrade missing creds/source path log to debug
Luca Boccassi [Fri, 28 Oct 2022 17:08:58 +0000 (18:08 +0100)] 
tmpfiles: downgrade missing creds/source path log to debug

When installing systemd 252 in debian:

Setting up systemd (252~rc3-2) ...
Installing new version of config file /etc/systemd/logind.conf ...
Installing new version of config file /etc/systemd/system.conf ...
Installing new version of config file /etc/systemd/user.conf ...
/usr/lib/tmpfiles.d/provision.conf:13: Credential 'login.motd' not specified, skipping line.
/usr/lib/tmpfiles.d/provision.conf:14: Credential 'login.issue' not specified, skipping line.
/usr/lib/tmpfiles.d/provision.conf:17: Credential 'network.hosts' not specified, skipping line.
/usr/lib/tmpfiles.d/provision.conf:22: Credential 'ssh.authorized_keys.root' not specified, skipping line.
/usr/lib/tmpfiles.d/systemd.conf:43: Copy source path '/.extra/tpm2-pcr-signature.json' does not exist, skipping line.
/usr/lib/tmpfiles.d/systemd.conf:44: Copy source path '/.extra/tpm2-pcr-public-key.pem' does not exist, skipping line.

Downgrade to debug level

3 years agoinstall: process all Wants= symlinks even if some of them fail
Yu Watanabe [Tue, 25 Oct 2022 15:12:14 +0000 (00:12 +0900)] 
install: process all Wants= symlinks even if some of them fail

Follow-up for 94e7298d309fef7710174def820e9d38e512a086.

Fixes CID#1499992.

3 years agotest-network: rewrite wait-online address family tests
Yu Watanabe [Thu, 27 Oct 2022 19:48:31 +0000 (04:48 +0900)] 
test-network: rewrite wait-online address family tests

Fixes #25154.

3 years agoMerge pull request #25164 from yuwata/network-route-table-0
Luca Boccassi [Fri, 28 Oct 2022 09:23:26 +0000 (11:23 +0200)] 
Merge pull request #25164 from yuwata/network-route-table-0

network: fix handling of route table 0

3 years agonetwork: drop duplicated period in log message
Yu Watanabe [Fri, 28 Oct 2022 05:44:35 +0000 (14:44 +0900)] 
network: drop duplicated period in log message

3 years agotest-network: add testcase for router preference 25166/head
Yu Watanabe [Fri, 28 Oct 2022 05:38:23 +0000 (14:38 +0900)] 
test-network: add testcase for router preference

3 years agonetwork: adjust route priority based on preference
Yu Watanabe [Fri, 28 Oct 2022 03:55:59 +0000 (12:55 +0900)] 
network: adjust route priority based on preference

Even if different preference is specified, the kernel merges multiple
routes with the same preference. This is problematic when a network has
multiple routers.

Fixes #25138.

3 years agotest-network: show only IPv4 routes 25164/head
Yu Watanabe [Fri, 28 Oct 2022 02:28:10 +0000 (11:28 +0900)] 
test-network: show only IPv4 routes

3 years agonetwork: make RouteTable= also accept route table name
Yu Watanabe [Fri, 28 Oct 2022 02:06:27 +0000 (11:06 +0900)] 
network: make RouteTable= also accept route table name

3 years agonetwork: allow 0 for table number
Yu Watanabe [Fri, 28 Oct 2022 02:33:19 +0000 (11:33 +0900)] 
network: allow 0 for table number

Fixes #25089.

3 years agonetwork: Table= also accepts table name
Yu Watanabe [Fri, 28 Oct 2022 02:03:52 +0000 (11:03 +0900)] 
network: Table= also accepts table name

3 years agoMerge pull request #25163 from weblate/weblate-systemd-master
Yu Watanabe [Thu, 27 Oct 2022 23:27:39 +0000 (08:27 +0900)] 
Merge pull request #25163 from weblate/weblate-systemd-master

Translations update from Fedora Weblate

3 years agopo: Translated using Weblate (Swedish) 25163/head
Anders Jonsson [Thu, 27 Oct 2022 23:19:46 +0000 (01:19 +0200)] 
po: Translated using Weblate (Swedish)

Currently translated at 100.0% (193 of 193 strings)

Co-authored-by: Anders Jonsson <anders.jonsson@norsjovallen.se>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/sv/
Translation: systemd/main

3 years agopo: Translated using Weblate (Russian)
Olga Smirnova [Thu, 27 Oct 2022 23:19:46 +0000 (01:19 +0200)] 
po: Translated using Weblate (Russian)

Currently translated at 100.0% (193 of 193 strings)

Co-authored-by: Olga Smirnova <mistresssilvara@hotmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/ru/
Translation: systemd/main

3 years agonetwork: allow to (automatically) reconfigure failed interface
Yu Watanabe [Wed, 26 Oct 2022 01:46:08 +0000 (10:46 +0900)] 
network: allow to (automatically) reconfigure failed interface

We have already allowed to reconfigure failed interface manually, but
not allowed to do automatically, e.g. on carrier gain.
This makes that failed interfaces also reconfigured automatically.

Note, the condition is inversed to shorten the condition.

3 years agonetwork: drop redundant condition
Yu Watanabe [Wed, 26 Oct 2022 01:44:06 +0000 (10:44 +0900)] 
network: drop redundant condition

The function `link_reconfigure_impl()` has the same condition at the
beginning.

3 years agowait-online: ignore -ENODATA from sd_network_link_get_required_for_online()
Yu Watanabe [Thu, 27 Oct 2022 00:54:06 +0000 (09:54 +0900)] 
wait-online: ignore -ENODATA from sd_network_link_get_required_for_online()

Follow-up for 778e3da95ef16302956087e6f10ccf7d42499aec.

These settings are saved only when a .network file is assigned to the
interface. Let's silence noisy logs for unmanaged interfaces.

3 years agoMerge pull request #25146 from keszybz/relicese-to-mit-0
Zbigniew JÄ™drzejewski-Szmek [Thu, 27 Oct 2022 05:31:56 +0000 (07:31 +0200)] 
Merge pull request #25146 from keszybz/relicese-to-mit-0

Change license of code examples in docs to MIT-0

3 years agoMerge pull request #25137 from yuwata/sd-device-drop-device-copy-properties
Zbigniew JÄ™drzejewski-Szmek [Thu, 27 Oct 2022 05:28:22 +0000 (07:28 +0200)] 
Merge pull request #25137 from yuwata/sd-device-drop-device-copy-properties

sd-device: drop unused device_copy_properties()

3 years agodhcp: use the attached sd_device object when generating IAID 25142/head
Yu Watanabe [Tue, 25 Oct 2022 21:56:25 +0000 (06:56 +0900)] 
dhcp: use the attached sd_device object when generating IAID

Note, previously `use_mac` set with `test_mode`. As `dev`, which is set with
`client->dev`, is not set when running test or fuzzer. Hence, the condition
```
if (udev_available() && !use_mac)
```
is effectively equivalent to
```
if (dev)
```
So, this commit mostly does not change behavior. Except for the following
corner case.

The sd_device object assigned from networkd (that is, Link.dev) never
has ID_RENAMING udev property, as sd_device objects which has the property
are filtered out at `link_check_initialized()` or `manager_udev_process_link()`
in networkd-link.c.

However, sd_device object created in `dhcp_identifier_set_iaid()` in the
previous code may have it. Such situation may (at least, theoretically)
happen when the network interface is renamed after initialized, e.g. by
creating the following spurious .link file:
```
[Match]
OriginalName=eno1
[Link]
Name=lan
```
and then trigger uevent for the network interface while systemd-networkd
calling `dhcp_identifier_set_iaid()`.

3 years agotest: add test for IN_SET() with bitfield specifier 25134/head
Yu Watanabe [Tue, 25 Oct 2022 18:32:05 +0000 (03:32 +0900)] 
test: add test for IN_SET() with bitfield specifier

3 years agoupdate TODO
Lennart Poettering [Wed, 26 Oct 2022 09:09:04 +0000 (11:09 +0200)] 
update TODO

3 years agounit: also prioritize input devices when triggering devices
Yu Watanabe [Wed, 26 Oct 2022 05:00:47 +0000 (14:00 +0900)] 
unit: also prioritize input devices when triggering devices

As in most cases, tty device without input devices is meaningless.

This also swaps the priority of tty and net:
- input devices are often connected under USB bus, hence may take
  slightly much time to be initialized. As, described in the above,
  in most cases it is allowed that tty devices are initialized just
  before input devices,
- network configuration usually requires much time, e.g. DHCP or RA,
  hence it is better that network interfaces initialized. Then,
  network services can start DHCP client or friends earlier.

Fixes #24026.

3 years agonetwork: change license of examples to MIT-0 25146/head
Zbigniew JÄ™drzejewski-Szmek [Wed, 26 Oct 2022 06:34:13 +0000 (08:34 +0200)] 
network: change license of examples to MIT-0

Arguably, CC0 is just fine for examples since they are not code. But it's
easier to be consistent and just use MIT-0 for all "documentation". Thus,
the license is changed similarly code examples under man/.

Based on 'git shortlog -ns network/*' and 'git log -p', the following folks
should ack this:
  Zbigniew JÄ™drzejewski-Szmek
  Lennart Poettering
  Tom Gundersen
  Yu Watanabe
  Daan De Meyer
  Marc-André Lureau

3 years agosystemd-sysv-install: change license to MIT-0
Zbigniew JÄ™drzejewski-Szmek [Wed, 26 Oct 2022 06:26:45 +0000 (08:26 +0200)] 
systemd-sysv-install: change license to MIT-0

See parent commit for explanation.

git blame shows Martin Pitt is the author of the code.

(I was considering whether we should instead drop this file, but it's still
useful for *distributions*. Eveen if we discourage people from using sysv
scripts, distributions will have to deal with them for a while yet.)

3 years agoman: change license of examples to MIT-0
Zbigniew JÄ™drzejewski-Szmek [Wed, 26 Oct 2022 06:02:14 +0000 (08:02 +0200)] 
man: change license of examples to MIT-0

Quoting Richard Fontana in [1]:

  CC0 has been listed by Fedora as a 'good' license for code and content
  (corresponding to allowed and allowed-content under the new system). We plan
  to classify CC0 as allowed-content only, so that CC0 would no longer be
  allowed for code.

  Over a long period of time a consensus has been building in FOSS that
  licenses that preclude any form of patent licensing or patent forbearance
  cannot be considered FOSS. CC0 has a clause that says: "No trademark or
  patent rights held by Affirmer are waived, abandoned, surrendered, licensed
  or otherwise affected by this document." (The trademark side of that clause
  is nonproblematic from a FOSS licensing norms standpoint.) The regular
  Creative Commons licenses have similar clauses.

For the case of our documentation snippets, patent issues do not matter much.
But it is always nicer to have a license that is considerred acceptable without
any further considerations. So let's change the license to the (now recommended
replacement) MIT-0.

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/NO7KGDNL5GX3KCB7T3XTGFA3QPSUJA6R/

Using 'git blame -b' and 'git log -p --follow', I identified the following
folks as having made non-trivial changes to those snippets:

  Lennart Poettering
  Tom Gundersen
  Luca Bocassi
  Zbigniew JÄ™drzejewski-Szmek
  Thomas Mühlbacher
  Daan De Meyer

I'll ask for confirmation in the pull request.

3 years agolicenses: add a copy of MIT-0
Zbigniew JÄ™drzejewski-Szmek [Wed, 26 Oct 2022 06:18:23 +0000 (08:18 +0200)] 
licenses: add a copy of MIT-0

Taken from https://spdx.org/licenses/MIT-0.html.

3 years agoMerge pull request #25120 from bluca/test_machineid
Zbigniew JÄ™drzejewski-Szmek [Wed, 26 Oct 2022 05:43:48 +0000 (07:43 +0200)] 
Merge pull request #25120 from bluca/test_machineid

unit tests: do not fail when machine-id is missing

3 years agohwdb: drop model specifier from general entries
Yu Watanabe [Tue, 25 Oct 2022 19:00:10 +0000 (04:00 +0900)] 
hwdb: drop model specifier from general entries

Fixes #25029.

3 years agonetwork: attach device to DHCP clients
Yu Watanabe [Tue, 25 Oct 2022 21:36:39 +0000 (06:36 +0900)] 
network: attach device to DHCP clients

The attached sd_device object will be used later.

3 years agosd-dhcp6-client: introduce sd_dhcp6_client_attach_device()
Yu Watanabe [Tue, 25 Oct 2022 21:31:59 +0000 (06:31 +0900)] 
sd-dhcp6-client: introduce sd_dhcp6_client_attach_device()

It will be used later.

3 years agosd-dhcp-client: introduce sd_dhcp_client_attach_device()
Yu Watanabe [Tue, 25 Oct 2022 21:31:49 +0000 (06:31 +0900)] 
sd-dhcp-client: introduce sd_dhcp_client_attach_device()

It will be used later.

3 years agopo: Translated using Weblate (Georgian)
Temuri Doghonadze [Tue, 25 Oct 2022 22:19:35 +0000 (00:19 +0200)] 
po: Translated using Weblate (Georgian)

Currently translated at 100.0% (193 of 193 strings)

Co-authored-by: Temuri Doghonadze <temuri.doghonadze@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/ka/
Translation: systemd/main

3 years agosd-device: make device_shallow_clone() static 25137/head
Yu Watanabe [Tue, 25 Oct 2022 20:12:54 +0000 (05:12 +0900)] 
sd-device: make device_shallow_clone() static

3 years agosd-device: drop unused device_copy_properties()
Yu Watanabe [Tue, 25 Oct 2022 20:05:30 +0000 (05:05 +0900)] 
sd-device: drop unused device_copy_properties()

3 years agoudev: use ASSERT_PTR() at one more place 25136/head
Yu Watanabe [Tue, 25 Oct 2022 19:52:06 +0000 (04:52 +0900)] 
udev: use ASSERT_PTR() at one more place

3 years agoudev: drop ID_RENAMING from UdevEvent.dev_db_clone instead of UdevEvent.dev
Yu Watanabe [Tue, 25 Oct 2022 19:37:24 +0000 (04:37 +0900)] 
udev: drop ID_RENAMING from UdevEvent.dev_db_clone instead of UdevEvent.dev

As the properties loaded from the database are stored to UdevEvent.dev_db_clone,
instead of UdevEvent.dev.

This also makes the removal done unconditionally, for safety.

3 years agoMerge pull request #25133 from poettering/ddi-dissect
Yu Watanabe [Tue, 25 Oct 2022 18:37:44 +0000 (03:37 +0900)] 
Merge pull request #25133 from poettering/ddi-dissect

mention "DDIs" in systemd-dissect tool --help text/man page

3 years agomacro: fix indentation
Yu Watanabe [Tue, 25 Oct 2022 18:28:08 +0000 (03:28 +0900)] 
macro: fix indentation

3 years agomacro: Simply case macros for IN_SET
Jan Janssen [Tue, 25 Oct 2022 17:55:08 +0000 (19:55 +0200)] 
macro: Simply case macros for IN_SET

The CASE param would normally provide the operation for the compiler to
do in this macro magic. But in this case CASE_F_1 was hardcoding the
operation, making the parameter moot.
This just removes the somewhat pointless parameter instead of fixing
the one case. These macros are used for IN_SET case labels only and
not named generically anyways.

3 years agomacro: Use more correct type in IN_SET
Jan Janssen [Tue, 25 Oct 2022 17:33:40 +0000 (19:33 +0200)] 
macro: Use more correct type in IN_SET

This will now catch mistakes like this:
    struct s {
            int i:2;
    } s = { 1 };
    assert_se(IN_SET(s.i, ULLONG_MAX));

> warning: implicit conversion from 'unsigned long long' to
> 'typeof (+s.i)' (aka 'int') changes value from 18446744073709551615
> to -1 [-Wconstant-conversion]

3 years agotree-wide: fix typo
Yu Watanabe [Tue, 25 Oct 2022 18:24:45 +0000 (03:24 +0900)] 
tree-wide: fix typo

3 years agoMerge pull request #25131 from poettering/image-root-help-text-fix
Yu Watanabe [Tue, 25 Oct 2022 18:17:17 +0000 (03:17 +0900)] 
Merge pull request #25131 from poettering/image-root-help-text-fix

analyze/coredumpctl: add --image=/--root= to --help texts

3 years agoman: also use DDIs in systemd-dissect man page 25133/head
Lennart Poettering [Tue, 25 Oct 2022 16:59:10 +0000 (18:59 +0200)] 
man: also use DDIs in systemd-dissect man page

3 years agodissect: mention DDI moniker in --help text
Lennart Poettering [Tue, 25 Oct 2022 13:42:21 +0000 (15:42 +0200)] 
dissect: mention DDI moniker in --help text

3 years agoRevert "core: drop non-default value for DefaultLimitMEMLOCK=" (#25058)
xiaoyang [Tue, 25 Oct 2022 16:49:07 +0000 (00:49 +0800)] 
Revert "core: drop non-default value for DefaultLimitMEMLOCK=" (#25058)

This reverts commit 606104bcdbf9d2fe1f39594cc6379db9209569d9.

3 years agotest: rewrite tests for renaming network interface
Yu Watanabe [Mon, 24 Oct 2022 17:58:39 +0000 (02:58 +0900)] 
test: rewrite tests for renaming network interface

- use `udevadm wait` instead of `udevadm info --wait-initialized`,
- use `timeout` command instead of the fixed time sleep,
- add basic tests for #25106,
- add brief comment about #25115.