]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
2 years agotest-network: add testcase for no managed interface 25830/head
Yu Watanabe [Thu, 22 Dec 2022 07:42:55 +0000 (16:42 +0900)] 
test-network: add testcase for no managed interface

2 years agotest-network: split out wait-online related test case
Yu Watanabe [Thu, 22 Dec 2022 07:29:20 +0000 (16:29 +0900)] 
test-network: split out wait-online related test case

2 years agotest-network: move one test case
Yu Watanabe [Thu, 22 Dec 2022 07:27:58 +0000 (16:27 +0900)] 
test-network: move one test case

2 years agowait-online: exit with success when all interfaces are ready or unmanaged
Yu Watanabe [Thu, 22 Dec 2022 00:40:37 +0000 (09:40 +0900)] 
wait-online: exit with success when all interfaces are ready or unmanaged

Previously, when neither '--any' nor '--interface' options specified,
at least one of the interfaces must be in configured state.
This patch makes wait-online exit with success even if all interfaces
are in unmanaged state.

This may break backward compatibility in a rare situation. But in most
cases, this typically not change anything, as at least one interface
is managed by networkd.service when it is enabled.

This is mostly for making wait-online gracefully handle the case that
networkd.service and wait-online.service are enabled by mistake. In such
situation, all interfaces are typically not managed.

Fixes #25813.

2 years agogpt-auto-generator: honour rootfstype= and rootflags= kernel cmdline option
Lennart Poettering [Wed, 21 Dec 2022 08:47:46 +0000 (09:47 +0100)] 
gpt-auto-generator: honour rootfstype= and rootflags= kernel cmdline option

Even if root= is not specified on the kernel cmdline, we should honour
the other rootXYZ= options.

Fixes: #8411
See: #17034

2 years agohwdb: Add mic-mute, control-center and screen-rotation mappings for MSI laptops
Hans de Goede [Wed, 21 Dec 2022 11:18:52 +0000 (12:18 +0100)] 
hwdb: Add mic-mute, control-center and screen-rotation mappings for MSI laptops

The MSI Summit E16 Flip A12UCT laptop sends the following unmapped
atkbd scancodes:

0x91: Launch MSI Control Center
0xf1: Toggle mic mute
0xf2: Rotate screen

The 0x91, 0xf1 and 0xf2 codes are already present in the MSI Prestige/Modern
series specific keymappings and the 0xf1 mapping is also already present in
the MSI Bravo 15-B5DX FnKeys entry.

This shows that these are generic to many MSI models, so add mappings for
these to the generic MSI mappings.

Since the MSI Bravo 15-B5DX FnKeys entry only contains the 0xf1 mapping and
that is covered by the generic MSI mappings now, that entry is removed.

Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/822
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216824
2 years agohwdb: change definition of PROXIMITY_NEAR_LEVEL for sensors
Philipp Jungkamp [Wed, 21 Dec 2022 11:43:49 +0000 (12:43 +0100)] 
hwdb: change definition of PROXIMITY_NEAR_LEVEL for sensors

The [kernel documentation][0] for the in_proximity_nearlevel sysfs
attribute on iio proximity devices states:

    If the value read from the sensor is above or equal to the value in
    this file an object should typically be considered near.

Meaning a 'greater than or equal to' comparison.

Make the documentation comment in 60-sensors.hwdb suggest a
greater-or-equal rather than a strict greater-than comparison.

[0]: https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-bus-iio-proximity

Fixes #25793

2 years agosystemctl: fix typo
Antonio Alvarez Feijoo [Wed, 21 Dec 2022 10:25:03 +0000 (11:25 +0100)] 
systemctl: fix typo

2 years agorules: add missing line continuation
Yu Watanabe [Wed, 21 Dec 2022 08:32:56 +0000 (17:32 +0900)] 
rules: add missing line continuation

Fixes a bug introduced by 953c928c24455744d5534679998d129b947a5e04.

Fixes #25811.

2 years agoman: create a new section for nspawn files in systemd.syntax man page (#25807)
Steve Ramage [Wed, 21 Dec 2022 04:31:09 +0000 (20:31 -0800)] 
man: create a new section for nspawn files in systemd.syntax man page (#25807)

Closes #25806.

2 years agoresolve: fix enumerator name for DNS search domain
Jacek Migacz [Tue, 20 Dec 2022 14:26:12 +0000 (15:26 +0100)] 
resolve: fix enumerator name for DNS search domain

2 years agoMerge pull request #25789 from yuwata/EBADF
Lennart Poettering [Tue, 20 Dec 2022 18:01:54 +0000 (19:01 +0100)] 
Merge pull request #25789 from yuwata/EBADF

tree-wide: use -EBADF more

2 years agoMerge branch 'systemd-security/coredump-capabilities'
Zbigniew Jędrzejewski-Szmek [Tue, 20 Dec 2022 16:56:28 +0000 (17:56 +0100)] 
Merge branch 'systemd-security/coredump-capabilities'

CVE-2022-4415: systemd: coredump not respecting fs.suid_dumpable kernel setting
Affects systemd >= 247 with libacl support enabled.

This is a merge of https://github.com/systemd/systemd-security/pull/12/.
I'm doing the merge locally because github doesn't support merging directly
from systemd/systemd-security to systemd/systemd.

2 years agotree-wide: use -EBADF more 25789/head
Yu Watanabe [Tue, 20 Dec 2022 02:09:08 +0000 (11:09 +0900)] 
tree-wide: use -EBADF more

2 years agosystemctl: new option --drop-in for specifying drop-in filename
Mike Yuan [Sat, 17 Dec 2022 13:07:32 +0000 (21:07 +0800)] 
systemctl: new option --drop-in for specifying drop-in filename

Previously 'systemctl edit' would only operate on
'override.conf', but users may need more than that.
Thus the new option '--drop-in' is added to allow
users to specify the drop-in file name.

Closes #25767

2 years agogithub: update version in bug templates
Zbigniew Jędrzejewski-Szmek [Tue, 20 Dec 2022 14:12:28 +0000 (15:12 +0100)] 
github: update version in bug templates

2 years agotree-wide: introduce PIPE_EBADF macro
Yu Watanabe [Tue, 20 Dec 2022 01:10:19 +0000 (10:10 +0900)] 
tree-wide: introduce PIPE_EBADF macro

2 years agofuzz: sort headers
Yu Watanabe [Tue, 20 Dec 2022 02:08:53 +0000 (11:08 +0900)] 
fuzz: sort headers

2 years agoMerge pull request #25786 from keszybz/ebadf
Yu Watanabe [Tue, 20 Dec 2022 01:02:10 +0000 (10:02 +0900)] 
Merge pull request #25786 from keszybz/ebadf

Use -EBADF for fd initialization

2 years agoMerge pull request #25787 from msekletar/rename-process-cap
Yu Watanabe [Tue, 20 Dec 2022 00:58:47 +0000 (09:58 +0900)] 
Merge pull request #25787 from msekletar/rename-process-cap

units: allow systemd-userdbd to change process name

2 years agohwdb: Fn+F5 fix for MSI Bravo 15-B5DX (#25788)
noodlejetski [Tue, 20 Dec 2022 00:57:54 +0000 (01:57 +0100)] 
hwdb: Fn+F5 fix for MSI Bravo 15-B5DX (#25788)

Closes #25782.

2 years agounits: allow systemd-userdbd to change process name 25787/head
Michal Sekletar [Mon, 19 Dec 2022 16:58:49 +0000 (17:58 +0100)] 
units: allow systemd-userdbd to change process name

rename_process() requires CAP_SYS_RESOURCE so let's make sure it is in
our permitted set after execve() by adding in to the bounding set.

Previously,
systemd-userdbd.service - User Database Manager
     Loaded: loaded (/usr/lib/systemd/system/systemd-userdbd.service; indirect; preset: disabled)
     Active: active (running) since Mon 2022-12-19 17:07:21 CET; 17min ago
TriggeredBy: ● systemd-userdbd.socket
       Docs: man:systemd-userdbd.service(8)
   Main PID: 1880 (systemd-userdbd)
     Status: "Processing requests..."
      Tasks: 4 (limit: 2272)
     Memory: 5.2M
        CPU: 244ms
     CGroup: /system.slice/systemd-userdbd.service
             ├─1880 /usr/lib/systemd/systemd-userdbd
             ├─2270 systemd-userwork
             ├─2271 systemd-userwork
             └─2272 systemd-userwork

Now,
    Loaded: loaded (/usr/lib/systemd/system/systemd-userdbd.service; indirect; preset: disabled)
     Active: active (running) since Mon 2022-12-19 17:27:02 CET; 15s ago
TriggeredBy: ● systemd-userdbd.socket
       Docs: man:systemd-userdbd.service(8)
   Main PID: 2404 (systemd-userdbd)
     Status: "Processing requests..."
      Tasks: 4 (limit: 2272)
     Memory: 5.5M
        CPU: 89ms
     CGroup: /system.slice/systemd-userdbd.service
             ├─2404 /usr/lib/systemd/systemd-userdbd
             ├─2407 "systemd-userwork: waiting..."
             ├─2408 "systemd-userwork: waiting..."
             └─2409 "systemd-userwork: waiting..."

2 years agoargv-util: do proper permission check while when changing process name
Michal Sekletar [Mon, 19 Dec 2022 16:29:40 +0000 (17:29 +0100)] 
argv-util: do proper permission check while when changing process name

Process renaming happens very seldomly so we are able to afford proper
permission check, i.e. actually check for CAP_SYS_RESOURCE capability
instead of euid.

2 years agoMerge pull request #25783 from keszybz/trivial-cleanups
Lennart Poettering [Mon, 19 Dec 2022 16:01:51 +0000 (17:01 +0100)] 
Merge pull request #25783 from keszybz/trivial-cleanups

Trivial cleanups

2 years agoMerge pull request #25771 from bluca/pkcs11_dlopen
Lennart Poettering [Mon, 19 Dec 2022 16:01:02 +0000 (17:01 +0100)] 
Merge pull request #25771 from bluca/pkcs11_dlopen

p11kit: switch to dlopen()

2 years agobasic/hashmap: add comment 25783/head
Zbigniew Jędrzejewski-Szmek [Mon, 19 Dec 2022 10:19:18 +0000 (11:19 +0100)] 
basic/hashmap: add comment

Coverity complains that the check is suspicious. Add a comment to help
the reader.

2 years agoefi: do not use 'r' as pointer name
Zbigniew Jędrzejewski-Szmek [Mon, 19 Dec 2022 10:17:07 +0000 (11:17 +0100)] 
efi: do not use 'r' as pointer name

'r' should only be used as in 'int r'.

2 years agouserdb: fix typo
Zbigniew Jędrzejewski-Szmek [Fri, 16 Dec 2022 07:35:59 +0000 (08:35 +0100)] 
userdb: fix typo

2 years agoshared/dns-domain: reduce scope of variable declarations
Zbigniew Jędrzejewski-Szmek [Mon, 12 Dec 2022 14:01:49 +0000 (15:01 +0100)] 
shared/dns-domain: reduce scope of variable declarations

2 years agobasic/fd-util: rearrange variable declarations 25786/head
Zbigniew Jędrzejewski-Szmek [Mon, 19 Dec 2022 12:26:17 +0000 (13:26 +0100)] 
basic/fd-util: rearrange variable declarations

Having two blocks of normal variable declarations was unnecessary.
Also 'i' can be narrower in scope.

2 years agotree-wide: use -EBADF also in pipe initializers
Zbigniew Jędrzejewski-Szmek [Mon, 19 Dec 2022 12:20:30 +0000 (13:20 +0100)] 
tree-wide: use -EBADF also in pipe initializers

In some places, initialization is dropped when unnecesary.

2 years agotree-wide: change initialization to use EBADF instead of EBADFD
Zbigniew Jędrzejewski-Szmek [Mon, 19 Dec 2022 12:11:05 +0000 (13:11 +0100)] 
tree-wide: change initialization to use EBADF instead of EBADFD

Those fds never were, so it's not fair to say that they are in "bad state".
Let's use the shorter and more direct errno.

2 years agotree-wide: use -EBADF for fd initialization
Zbigniew Jędrzejewski-Szmek [Mon, 19 Dec 2022 12:07:42 +0000 (13:07 +0100)] 
tree-wide: use -EBADF for fd initialization

-1 was used everywhere, but -EBADF or -EBADFD started being used in various
places. Let's make things consistent in the new style.

Note that there are two candidates:
EBADF 9 Bad file descriptor
EBADFD 77 File descriptor in bad state

Since we're initializating the fd, we're just assigning a value that means
"no fd yet", so it's just a bad file descriptor, and the first errno fits
better. If instead we had a valid file descriptor that became invalid because
of some operation or state change, the other errno would fit better.

In some places, initialization is dropped if unnecessary.

2 years agosd-event: never pass negative errnos as signalfd to signalfd
Zbigniew Jędrzejewski-Szmek [Mon, 19 Dec 2022 13:36:08 +0000 (14:36 +0100)] 
sd-event: never pass negative errnos as signalfd to signalfd

We treat any negative value as "invalid fd", but signalfd only
accepts -1.

2 years agosocket-proxyd: do not hardcode -1 in a check for fd validity
Zbigniew Jędrzejewski-Szmek [Mon, 19 Dec 2022 13:35:05 +0000 (14:35 +0100)] 
socket-proxyd: do not hardcode -1 in a check for fd validity

2 years agoUpdate TODO 25771/head
Luca Boccassi [Sat, 17 Dec 2022 01:50:39 +0000 (01:50 +0000)] 
Update TODO

2 years agop11kit: switch to dlopen()
Luca Boccassi [Sat, 17 Dec 2022 01:33:46 +0000 (01:33 +0000)] 
p11kit: switch to dlopen()

2 years agoMerge pull request #25784 from poettering/bootctl-split
Lennart Poettering [Mon, 19 Dec 2022 13:37:52 +0000 (14:37 +0100)] 
Merge pull request #25784 from poettering/bootctl-split

bootctl: split up bootctl.c into multiple files

2 years agounit: use underbar for module name
Yu Watanabe [Thu, 15 Dec 2022 19:02:25 +0000 (04:02 +0900)] 
unit: use underbar for module name

For consistency with src/core/unit.c.

2 years agobootctl: split out "install" verb too 25784/head
Lennart Poettering [Mon, 19 Dec 2022 10:42:15 +0000 (11:42 +0100)] 
bootctl: split out "install" verb too

2 years agobootctl: split out "status" verb too
Lennart Poettering [Mon, 19 Dec 2022 10:04:17 +0000 (11:04 +0100)] 
bootctl: split out "status" verb too

2 years agobootctl: split out "set-efivar" verbs, too
Lennart Poettering [Fri, 16 Dec 2022 17:51:10 +0000 (18:51 +0100)] 
bootctl: split out "set-efivar" verbs, too

2 years agobootctl: also split out 'systemd-efi-options' verb
Lennart Poettering [Fri, 16 Dec 2022 17:45:55 +0000 (18:45 +0100)] 
bootctl: also split out 'systemd-efi-options' verb

2 years agobootctl: split out random seed verb, too
Lennart Poettering [Fri, 16 Dec 2022 17:42:39 +0000 (18:42 +0100)] 
bootctl: split out random seed verb, too

2 years agobootctl: let's start splitting up bootctl like we did for systemctl and others
Lennart Poettering [Fri, 16 Dec 2022 17:27:06 +0000 (18:27 +0100)] 
bootctl: let's start splitting up bootctl like we did for systemctl and others

2 years agoMerge pull request #25779 from bluca/journa_remote_vacuum
Yu Watanabe [Mon, 19 Dec 2022 00:44:04 +0000 (09:44 +0900)] 
Merge pull request #25779 from bluca/journa_remote_vacuum

journal-remote: follow-ups for #25076

2 years agojournal-remote: fix memory leak on initialization error 25779/head
Luca Boccassi [Sun, 18 Dec 2022 10:58:37 +0000 (10:58 +0000)] 
journal-remote: fix memory leak on initialization error

Follow-up for f12b399dd6362a03379cb769954ebfb9972236ed from
https://github.com/systemd/systemd/pull/25076

CID#1501550

2 years agojournal-remote: fix initialization of vacuum metrics
Luca Boccassi [Sun, 18 Dec 2022 10:51:36 +0000 (10:51 +0000)] 
journal-remote: fix initialization of vacuum metrics

Follow-up for f12b399dd6362a03379cb769954ebfb9972236ed from
https://github.com/systemd/systemd/pull/25076

CID#1501551

2 years agomeson: fix cross-compilation of LONG_MAX
asavah [Sat, 17 Dec 2022 16:00:56 +0000 (17:00 +0100)] 
meson: fix cross-compilation of LONG_MAX

https://github.com/systemd/systemd/pull/25618#issuecomment-1355019553

2 years agovacuum journal remote (#25076)
berenddeschouwer [Sat, 17 Dec 2022 13:54:16 +0000 (15:54 +0200)] 
vacuum journal remote (#25076)

* Support vacuuming for journal-remote

Co-authored-by: Berend De Schouwer <berend@deschouwer.co.za>
2 years agoMerge pull request #25221 from enr0n/nic-rename-fallback
Luca Boccassi [Sat, 17 Dec 2022 13:51:39 +0000 (14:51 +0100)] 
Merge pull request #25221 from enr0n/nic-rename-fallback

udev: set link alternative name if link is already up during rename

2 years agoMerge pull request #25387 from yuwata/core-fix-gc-logic
Luca Boccassi [Sat, 17 Dec 2022 13:49:21 +0000 (14:49 +0100)] 
Merge pull request #25387 from yuwata/core-fix-gc-logic

core: fix logic of merging units

2 years agoAdd basic systemctl edit test
наб [Tue, 22 Nov 2022 04:14:01 +0000 (05:14 +0100)] 
Add basic systemctl edit test

2 years agoTODO
Lennart Poettering [Fri, 16 Dec 2022 10:42:11 +0000 (11:42 +0100)] 
TODO

2 years agotest: systemd-mount --list and systemd-umount requires the device is initialized...
Yu Watanabe [Thu, 15 Dec 2022 18:04:22 +0000 (03:04 +0900)] 
test: systemd-mount --list and systemd-umount requires the device is initialized by udevd

Fixes #25674.

2 years agoman/systemd-oomd.service: Document command line options
Jade Lovelace [Wed, 7 Dec 2022 19:34:22 +0000 (11:34 -0800)] 
man/systemd-oomd.service: Document command line options

Previously these were not written down. This PR depends on #25670, since
`--dry-run` prints at debug level in `main`, which is surprising
behaviour.

2 years agoMerge pull request #25487 from poettering/systemctl-edit-newline-fix
Lennart Poettering [Thu, 15 Dec 2022 21:22:32 +0000 (22:22 +0100)] 
Merge pull request #25487 from poettering/systemctl-edit-newline-fix

systemctl: simplify trim_edit_markers()

2 years agoImplement SYSTEMD_HOME_MKFS_OPTIONS_* envvars to configure mkfs options for homed...
Aidan Dang [Sat, 10 Dec 2022 10:58:27 +0000 (21:58 +1100)] 
Implement SYSTEMD_HOME_MKFS_OPTIONS_* envvars to configure mkfs options for homed LUKS directories

2 years agorepart: Always derive fs/luks UUIDs from generated partition UUID
Daan De Meyer [Thu, 15 Dec 2022 14:06:40 +0000 (14:06 +0000)] 
repart: Always derive fs/luks UUIDs from generated partition UUID

When generating verity partitions, we only know the partition UUID
of the verity data and hash partition after doing the verity
formatting. This means we can't use the verity partition UUID as
input for deriving the filesystem/luks UUIDs. Currently, we derive
the filesystem/luks UUID from the null UUID instead, which isn't
ideal. Instead, let's always generate a partition UUID and use it
to derive the fs/luks UUIDs, but only use it as the actual partition
UUID if we're not doing verity for the partition.

2 years agopcrphase: gracefully exit if TPM2 support is incomplete
Lennart Poettering [Thu, 15 Dec 2022 17:07:20 +0000 (18:07 +0100)] 
pcrphase: gracefully exit if TPM2 support is incomplete

If everything points to the fact that TPM2 should work, but then the
driver fails to initialize we should handle this gracefully and not
cause failing services all over the place.

Fixes: #25700
2 years agotest: show and check almost all journal entries since the relevant command being...
Yu Watanabe [Thu, 15 Dec 2022 16:11:39 +0000 (01:11 +0900)] 
test: show and check almost all journal entries since the relevant command being invoked

For some reasons, journal timestamps from other sources sometimes
inconsistent. For example,
```
$ journalctl --file system.journal -o short-monotonic -u resmontest.service
[ 1112.168109] ns1.unsigned.test resolvectl[419]: → Q: ns1.unsigned.test IN AAAA
[ 1112.168109] ns1.unsigned.test resolvectl[419]: ← S: success
[ 1112.168109] ns1.unsigned.test resolvectl[419]: → Q: ns1.unsigned.test IN A
[ 1112.168109] ns1.unsigned.test resolvectl[419]: ← S: success
[ 1112.168109] ns1.unsigned.test resolvectl[419]: ← A: ns1.unsigned.test IN A 10.0.0.1
[ 1112.171961] ns1.unsigned.test systemd[1]: resmontest.service: Failed to load configuration: No such file or directory
[ 1112.172223] ns1.unsigned.test systemd[1]: resmontest.service: Trying to enqueue job resmontest.service/start/fail
[ 1112.179866] ns1.unsigned.test systemd[1]: resmontest.service: Installed new job resmontest.service/start as 312
[ 1112.179894] ns1.unsigned.test systemd[1]: resmontest.service: Enqueued job resmontest.service/start as 312
[ 1112.180389] ns1.unsigned.test systemd[1]: resmontest.service: Will spawn child (service_enter_start): /usr/bin/resolvectl
[ 1112.180418] ns1.unsigned.test systemd[1]: resmontest.service: Passing 0 fds to service
[ 1112.180447] ns1.unsigned.test systemd[1]: resmontest.service: About to execute /usr/bin/resolvectl monitor
[ 1112.180477] ns1.unsigned.test systemd[1]: resmontest.service: Forked /usr/bin/resolvectl as 419
[ 1112.180619] ns1.unsigned.test systemd[1]: resmontest.service: Changed dead -> start
[ 1112.180651] ns1.unsigned.test systemd[1]: Starting resmontest.service...
[ 1112.180799] ns1.unsigned.test systemd[419]: resmontest.service: Kernel keyring access prohibited, ignoring.
[ 1112.180895] ns1.unsigned.test systemd[419]: resmontest.service: Executing: /usr/bin/resolvectl monitor
[ 1112.181383] ns1.unsigned.test systemd[1]: resmontest.service: Got notification message from PID 419 (READY=1)
[ 1112.181413] ns1.unsigned.test systemd[1]: resmontest.service: Changed start -> running
[ 1112.181441] ns1.unsigned.test systemd[1]: resmontest.service: Job 312 resmontest.service/start finished, result=done
[ 1112.181469] ns1.unsigned.test systemd[1]: Started resmontest.service.
```
In such case, `journalctl -f` may not show the entries what we are interested in.

Fixes #25749. (At least, workarond for the issue.)

2 years agonetwork: wifi: check SSID when AP interfaces go up
Alvin Šipraga [Wed, 7 Dec 2022 15:43:06 +0000 (16:43 +0100)] 
network: wifi: check SSID when AP interfaces go up

When an AP goes up, the kernel may emit a netlink event indicating that
the interface has gained carrier. In that event, we should check if the
SSID has changed before attempting to reconfigure. Not doing so means
that the link->ssid member is not updated, leading to a potential
mismatch if some of the .network configurations match on SSID=.

There are however scenarios where the above heuristic is not enough.
Specifically, if the interface carrier state flip-flops within a short
enough interval, the internal throttling of netlink events inside the
kernel may suppress intermediate linkdown+linkup events (cf. Linux
net/core/link_watch.c). So there is no linkup event to react on.

To improve on the latter scenario, it is proposed to make newer kernels
emit an NL80211_CMD_START_AP multicast event when an AP goes up. This
event will not be dropped by link_watch. systemd-networkd can then react
to such events as well, and optionally reconfigure the link if the SSID
has changed. This will only work with newer kernels though.

2 years agocore/unit: fix log message 25387/head
Yu Watanabe [Tue, 15 Nov 2022 13:59:01 +0000 (22:59 +0900)] 
core/unit: fix log message

As you can see in the below, the dropped dependency Before=issue-24990.service
is not logged, but the dependency Before=test1.service which is not owned by
the units generated by the TEST-26 is logged.

Before:
systemd[1]: issue-24990.service: Dependency After=test1.service dropped, merged into issue-24990.service
systemd[1]: issue-24990.service: Dependency Before=test1.service dropped, merged into issue-24990.service

After:
systemd[1]: issue-24990.service: Dependency After=test1.service is dropped, as test1.service is merged into issue-24990.service.
systemd[1]: issue-24990.service: Dependency Before=issue-24990.service in test1.service is dropped, as test1.service is merged into issue-24990.service.

2 years agoman: add two signature key example to systemd-measure
Lennart Poettering [Thu, 15 Dec 2022 13:48:08 +0000 (14:48 +0100)] 
man: add two signature key example to systemd-measure

@keszybz asked for an example with --append= used in the systemd-measure
man page. Here it is.

As requested: https://github.com/systemd/systemd/pull/25224#pullrequestreview-1190709772

2 years agosystemctl: don't unlink non-existing temporary files 25487/head
Lennart Poettering [Thu, 24 Nov 2022 13:59:25 +0000 (14:59 +0100)] 
systemctl: don't unlink non-existing temporary files

2 years agosystemctl: if we edit a single file only, jump to the right line
Lennart Poettering [Tue, 22 Nov 2022 16:14:51 +0000 (17:14 +0100)] 
systemctl: if we edit a single file only, jump to the right line

2 years agosystemctl: stop using basename() at one more place
Lennart Poettering [Tue, 22 Nov 2022 17:46:20 +0000 (18:46 +0100)] 
systemctl: stop using basename() at one more place

2 years agosystemctl: line break string where the newlines are
Lennart Poettering [Tue, 22 Nov 2022 17:46:01 +0000 (18:46 +0100)] 
systemctl: line break string where the newlines are

2 years agosystemctl: minor modernizations/simplifications
Lennart Poettering [Tue, 22 Nov 2022 16:13:36 +0000 (17:13 +0100)] 
systemctl: minor modernizations/simplifications

2 years agosystemctl: simplify trim_edit_markers()
Lennart Poettering [Tue, 22 Nov 2022 15:22:41 +0000 (16:22 +0100)] 
systemctl: simplify trim_edit_markers()

This is not performance sensitive, don#t try to be smart with realloc()

Follow-up for: #25305
Fixes: #25303
2 years agotest: fix typo
Yu Watanabe [Thu, 15 Dec 2022 16:38:08 +0000 (01:38 +0900)] 
test: fix typo

2 years agoMerge pull request #25756 from yuwata/test-resolve-1
Yu Watanabe [Thu, 15 Dec 2022 15:53:52 +0000 (00:53 +0900)] 
Merge pull request #25756 from yuwata/test-resolve-1

test: several cleanups for TEST-75-RESOLVE

2 years agoMerge pull request #25718 from yuwata/locale-cleanups
Yu Watanabe [Thu, 15 Dec 2022 15:51:13 +0000 (00:51 +0900)] 
Merge pull request #25718 from yuwata/locale-cleanups

locale: avoid TOCTOU in reading config files

2 years agotest-network: add a test for renaming device to current altname 25221/head
Nick Rosbrook [Wed, 7 Dec 2022 17:28:28 +0000 (12:28 -0500)] 
test-network: add a test for renaming device to current altname

2 years agomkosi: work around a file conflict between systemd and systemd-boot
Frantisek Sumsal [Thu, 15 Dec 2022 12:52:52 +0000 (13:52 +0100)] 
mkosi: work around a file conflict between systemd and systemd-boot

2 years agorepart: Use "defer" in docs instead of "skip"
Daan De Meyer [Thu, 15 Dec 2022 14:27:08 +0000 (14:27 +0000)] 
repart: Use "defer" in docs instead of "skip"

2 years agosd-netlink: add a test for rtnl_set_link_name()
Nick Rosbrook [Tue, 22 Nov 2022 22:01:47 +0000 (17:01 -0500)] 
sd-netlink: add a test for rtnl_set_link_name()

Add a test that verifies a deleted alternative name is restored on error
in rtnl_set_link_name().

2 years agoudev: attempt device rename even if interface is up
Nick Rosbrook [Fri, 2 Dec 2022 20:35:25 +0000 (15:35 -0500)] 
udev: attempt device rename even if interface is up

Currently rename_netif() will not attempt to rename a device if it is
already up, because the kernel will return -EBUSY unless live renaming
is allowed on the device. This restriction will be removed in a future
kernel version [1].

To cover both cases, always attempt to rename the interface and return 0
if we get -EBUSY.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=bd039b5ea2a9

2 years agosd-netlink: restore altname on error in rtnl_set_link_name
Nick Rosbrook [Wed, 2 Nov 2022 09:36:14 +0000 (05:36 -0400)] 
sd-netlink: restore altname on error in rtnl_set_link_name

If a current alternative name is to be used to rename a network
interface, the alternative name must be removed first. If interface
renaming fails, restore the alternative name that was deleted if
necessary.

2 years agoManager: also log caller of daemon-reexec
Luca Boccassi [Thu, 15 Dec 2022 12:20:28 +0000 (12:20 +0000)] 
Manager: also log caller of daemon-reexec

2 years agosd-netlink: do not swap old name and alternative name
Nick Rosbrook [Fri, 2 Dec 2022 20:26:18 +0000 (15:26 -0500)] 
sd-netlink: do not swap old name and alternative name

Commit 434a348380 ("netlink: do not fail when new interface name is
already used as an alternative name") added logic to set the old
interface name as an alternative name, but only when the new name is
currently an alternative name. This is not the desired outcome in most
cases, and the important part of this commit was to delete the new name
from the list of alternative names if necessary.

2 years agoudev/net: allow new link name as an altname before renaming happens
Nick Rosbrook [Wed, 2 Nov 2022 15:05:01 +0000 (11:05 -0400)] 
udev/net: allow new link name as an altname before renaming happens

When configuring a link's alternative names, the link's new name to-be
is not allowed to be included because interface renaming will fail if
the new name is already present as an alternative name. However,
rtnl_set_link_name will delete the conflicting alternative name before
renaming the device, if necessary.

Allow the new link name to be set as an alternative name before the
device is renamed. This means that if the rename is later skipped (i.e.
because the link is already up), then the name can at least still be
present as an alternative name.

2 years agoMerge pull request #24058 from qdeslandes/journald_regex_filtering
Yu Watanabe [Thu, 15 Dec 2022 13:03:33 +0000 (22:03 +0900)] 
Merge pull request #24058 from qdeslandes/journald_regex_filtering

Allow for journald logs filtering on a per-unit basis

2 years agoRevert "test: wait for the monitoring service to become active" 25756/head
Yu Watanabe [Thu, 15 Dec 2022 07:28:52 +0000 (16:28 +0900)] 
Revert "test: wait for the monitoring service to become active"

This reverts commit 5dd34c2604567320707625bc009cf01c3769605f.

`resolvectl monitor` sends notify event, and systemd-run wait for the
service being in active state. Hence, the loop is not necessary.

2 years agotest: suppress echo in monitor_check_rr()
Yu Watanabe [Thu, 15 Dec 2022 06:28:56 +0000 (15:28 +0900)] 
test: suppress echo in monitor_check_rr()

2 years agopackit: drop/replace deprecated directives
Frantisek Sumsal [Thu, 15 Dec 2022 12:14:30 +0000 (13:14 +0100)] 
packit: drop/replace deprecated directives

2 years agorepart: Fix integration test
Daan De Meyer [Thu, 15 Dec 2022 12:01:35 +0000 (12:01 +0000)] 
repart: Fix integration test

2 years agoMerge pull request #25224 from poettering/measure-append
Yu Watanabe [Thu, 15 Dec 2022 12:47:29 +0000 (21:47 +0900)] 
Merge pull request #25224 from poettering/measure-append

add --append= switch to systemd-measure

2 years agoMerge pull request #25735 from yuwata/switch-root-follow-ups
Yu Watanabe [Thu, 15 Dec 2022 12:39:40 +0000 (21:39 +0900)] 
Merge pull request #25735 from yuwata/switch-root-follow-ups

mount-util: several follow-ups for recent mount_switch_root() changes

2 years agohwdb: Fix mount matrix for CSL Panther Tab HD (#25752)
mvzlb [Thu, 15 Dec 2022 10:59:14 +0000 (11:59 +0100)] 
hwdb: Fix mount matrix for CSL Panther Tab HD (#25752)

Commit a76d7aca sets ACCEL_MOUNT_MATRIX to match the device's casing
(landscape) instead of the LCD panel (portrait).

2 years agoupdate TODO 25224/head
Lennart Poettering [Tue, 1 Nov 2022 14:10:47 +0000 (15:10 +0100)] 
update TODO

2 years agotest: add integration test for systemd-measure --append=
Lennart Poettering [Thu, 15 Dec 2022 10:39:33 +0000 (11:39 +0100)] 
test: add integration test for systemd-measure --append=

2 years agomeasure: add --append= switch for merging signatures
Lennart Poettering [Tue, 1 Nov 2022 13:54:47 +0000 (14:54 +0100)] 
measure: add --append= switch for merging signatures

Often it's useful to add multiple signatures in the signature JSON file
to embedd in a single .pcrsig. (For example, a signature by key X for
boot phase "enter-initrd" and one by key Y for
"enter-initrd:leave-initrd" or so). Make this easy, by adding the
ability to append signatures to a previously generated JSON file.

2 years agojson: add helper for adding variant to array suppressing duplicates
Lennart Poettering [Tue, 1 Nov 2022 13:56:44 +0000 (14:56 +0100)] 
json: add helper for adding variant to array suppressing duplicates

2 years agojournal: add integration tests for log filtering 24058/head
Quentin Deslandes [Tue, 13 Sep 2022 15:12:36 +0000 (16:12 +0100)] 
journal: add integration tests for log filtering

Add integration tests for journald's log filtering feature.

2 years agojournal: filter log based on LogFilterPatterns
Quentin Deslandes [Tue, 13 Sep 2022 15:15:13 +0000 (16:15 +0100)] 
journal: filter log based on LogFilterPatterns

Use LogFilterPatterns from the unit's cgroup xattr in order to keep or
discard log messages before writing them to the journal.
When a log message is discarded, it won't be written to syslog, console...
either.

When a native, syslog, or standard output log message is received,
systemd-journald will process it if it matches against at least one
allowed pattern (if any) and none of the denied patterns (if any).

2 years agoCreate hash_ops structure to free keys of type pcre2_code
Quentin Deslandes [Tue, 13 Sep 2022 15:14:52 +0000 (16:14 +0100)] 
Create hash_ops structure to free keys of type pcre2_code

2 years agosystemctl: add support for LogFilterPatterns for show command
Quentin Deslandes [Wed, 14 Sep 2022 17:17:19 +0000 (18:17 +0100)] 
systemctl: add support for LogFilterPatterns for show command

Parse DBus structure send by LogFilterPatterns to print it in systemctl
show.

2 years agojournal: log filtering options support in PID1
Quentin Deslandes [Mon, 7 Nov 2022 19:30:01 +0000 (20:30 +0100)] 
journal: log filtering options support in PID1

Define new unit parameter (LogFilterPatterns) to filter logs processed by
journald.

This option is used to store a regular expression which is carried from
PID1 to systemd-journald through a cgroup xattrs:
`user.journald_log_filter_patterns`.

2 years agoset: add set_make_nulstr
Quentin Deslandes [Mon, 7 Nov 2022 19:25:46 +0000 (20:25 +0100)] 
set: add set_make_nulstr

Add function set_make_nulstr() to create a nulstr out of a set. Behave
the same way as strv_make_nulstr().