]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
2 years agoresolved: fix the canonical name returned by hosts lookup by name 28370/head
Dmitry V. Levin [Tue, 11 Jul 2023 08:00:00 +0000 (08:00 +0000)] 
resolved: fix the canonical name returned by hosts lookup by name

In etc_hosts_lookup_by_name(), return the canonical name of the resolved
address instead of the name used to obtain that address.

Resolves: #20158

2 years agoresolved: fix the canonical name returned by hosts lookup by address
Dmitry V. Levin [Mon, 10 Jul 2023 08:00:00 +0000 (08:00 +0000)] 
resolved: fix the canonical name returned by hosts lookup by address

In etc_hosts_lookup_by_address(), make sure the canonical name of the given
address is returned first in the list of names that address resolves to.

Resolves: #25088

2 years agoresolved: keep track of first names listed for each address in /etc/hosts
Dmitry V. Levin [Sun, 9 Jul 2023 08:00:00 +0000 (08:00 +0000)] 
resolved: keep track of first names listed for each address in /etc/hosts

These names will be used later in responses as canonical names.

2 years agoMerge pull request #26365 from dtardon/multiple-polkit-calls
Luca Boccassi [Fri, 14 Jul 2023 13:13:53 +0000 (14:13 +0100)] 
Merge pull request #26365 from dtardon/multiple-polkit-calls

Allow D-Bus methods to auth. for more than one polkit action

2 years agopo: Translated using Weblate (Ukrainian)
Yuri Chornoivan [Fri, 14 Jul 2023 11:47:02 +0000 (13:47 +0200)] 
po: Translated using Weblate (Ukrainian)

Currently translated at 100.0% (227 of 227 strings)

po: Translated using Weblate (Ukrainian)

Currently translated at 93.8% (213 of 227 strings)

Co-authored-by: Yuri Chornoivan <yurchor@ukr.net>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/uk/
Translation: systemd/main

2 years agopo: Update translation files
Weblate [Fri, 14 Jul 2023 09:35:42 +0000 (11:35 +0200)] 
po: Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Co-authored-by: Weblate <noreply@weblate.org>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/
Translation: systemd/main

2 years agopackit: temporarily use older Rawhide spec
Frantisek Sumsal [Fri, 14 Jul 2023 10:38:41 +0000 (12:38 +0200)] 
packit: temporarily use older Rawhide spec

Until [0] is deployed to production.

[0] https://github.com/packit/specfile/commit/2bdcec3db5cbee5e1f61fd578edd6a3393afd787

2 years agokernel-install: Avoid reopening file descriptor via /proc
Daan De Meyer [Fri, 14 Jul 2023 08:51:18 +0000 (10:51 +0200)] 
kernel-install: Avoid reopening file descriptor via /proc

kernel-install used to work without /proc mounted before the rewrite
in C. Let's restore that property by making sure we don't reopen
file descriptors via /proc. In this case, parse_env_file_fdv() calls
fdopen_independent() to get a FILE * for the given file descriptor
(which itself calls fd_reopen()). Let's avoid the call to
fdopen_independent() by using chase_and_fopenat_unlocked() which
gives us a FILE * immediately without having to reopen any file
descriptors.

2 years agoMerge pull request #28380 from bluca/homed_translate
Luca Boccassi [Fri, 14 Jul 2023 09:35:58 +0000 (10:35 +0100)] 
Merge pull request #28380 from bluca/homed_translate

homed: make all pam_prompt strings translatable

2 years agopo: add homed file and regenerate pot 28380/head
Luca Boccassi [Thu, 13 Jul 2023 11:39:48 +0000 (12:39 +0100)] 
po: add homed file and regenerate pot

2 years agoMerge pull request #28376 from yuwata/json_append
Daan De Meyer [Fri, 14 Jul 2023 08:07:48 +0000 (10:07 +0200)] 
Merge pull request #28376 from yuwata/json_append

Use json_append() and json_variant_append_array()

2 years agonetwork: check lifetime of address and route before configure
Yu Watanabe [Wed, 12 Jul 2023 01:50:53 +0000 (10:50 +0900)] 
network: check lifetime of address and route before configure

Otherwise, we may configure a route that depends on the existence
of an address or another route, and may fail when lifetime of one
of them are already zero.

Hopefully fixes #28358.

2 years agosd-journal: fix 'the the'
Yu Watanabe [Fri, 14 Jul 2023 07:53:41 +0000 (16:53 +0900)] 
sd-journal: fix 'the the'

2 years agoMerge pull request #27526 from mrc0mmand/journal-fss
Yu Watanabe [Fri, 14 Jul 2023 04:30:30 +0000 (13:30 +0900)] 
Merge pull request #27526 from mrc0mmand/journal-fss

journal: clean up the FSS related code a bit & add a couple of tests

2 years agocore: fix race condition during startup of a service with ExitType=cgroup
Fuminobu TAKEYAMA [Mon, 10 Jul 2023 15:30:27 +0000 (00:30 +0900)] 
core: fix race condition during startup of a service with ExitType=cgroup

This commit allows service_sigchld_event() is executed before
service_dispatch_exec_io(), which might happen when a main process exits
very quickly.

Also do not check PID for service goodness because the main process have
already been exited in this case.

Fix: #27919

2 years agoMerge pull request #28385 from YHNdnzj/fstab-initrd-bind-mount
Yu Watanabe [Fri, 14 Jul 2023 02:21:14 +0000 (11:21 +0900)] 
Merge pull request #28385 from YHNdnzj/fstab-initrd-bind-mount

fstab-generator: resolve bind mount source when in initrd

2 years agofstab-generator: resolve bind mount source when in initrd 28385/head
Mike Yuan [Thu, 13 Jul 2023 14:44:19 +0000 (22:44 +0800)] 
fstab-generator: resolve bind mount source when in initrd

We currently prepend /sysroot to mount points for entries
in /sysroot/etc/fstab. But when it comes to bind mounts,
the source needs to canonicalized too.

Fixes #6827
Replaces #7894

2 years agofstab-util: add fstab_is_bind
Mike Yuan [Thu, 13 Jul 2023 15:13:10 +0000 (23:13 +0800)] 
fstab-util: add fstab_is_bind

2 years agoukify: Derive public key from private key if not specified
Daan De Meyer [Mon, 10 Jul 2023 11:50:30 +0000 (13:50 +0200)] 
ukify: Derive public key from private key if not specified

2 years agobus-polkit: avoid extra variable 26365/head
David Tardon [Tue, 27 Jun 2023 13:31:51 +0000 (15:31 +0200)] 
bus-polkit: avoid extra variable

2 years agobus-polkit: allow to auth. a bus call for multiple actions
David Tardon [Thu, 29 Jun 2023 14:35:21 +0000 (16:35 +0200)] 
bus-polkit: allow to auth. a bus call for multiple actions

In #20155, verify_shutdown_creds() needs to authenticate for both
org.freedesktop.login1.hibernate-multiple-sessions and
org.freedesktop.login1.hibernate-ignore-inhibit . Previously, the second
authentication attempt would fail with -ESTALE.

Fixes #20155.

2 years agobus-polkit: parse reply from polkit on receive
David Tardon [Thu, 29 Jun 2023 14:20:25 +0000 (16:20 +0200)] 
bus-polkit: parse reply from polkit on receive

... and store just the result.

2 years agobus-polkit: extract action into a separate struct
David Tardon [Thu, 29 Jun 2023 14:03:30 +0000 (16:03 +0200)] 
bus-polkit: extract action into a separate struct

This is a preparation for later commits.

2 years agobus-polkit: describe async. polkit verification
David Tardon [Fri, 28 Apr 2023 14:31:27 +0000 (16:31 +0200)] 
bus-polkit: describe async. polkit verification

2 years agobus-polkit: refactor a bit to avoid goto
David Tardon [Tue, 27 Jun 2023 12:52:57 +0000 (14:52 +0200)] 
bus-polkit: refactor a bit to avoid goto

2 years agobus-polkit: drop unused argument
David Tardon [Tue, 27 Jun 2023 12:39:33 +0000 (14:39 +0200)] 
bus-polkit: drop unused argument

2 years agobus-polkit: use automatic cleanup
David Tardon [Fri, 23 Jun 2023 14:00:44 +0000 (16:00 +0200)] 
bus-polkit: use automatic cleanup

2 years agotest: add a couple of tests for FSS journals 27526/head
Frantisek Sumsal [Thu, 4 May 2023 11:44:12 +0000 (13:44 +0200)] 
test: add a couple of tests for FSS journals

2 years agojournal: clean up the FSS handling code a bit
Frantisek Sumsal [Thu, 4 May 2023 11:43:09 +0000 (13:43 +0200)] 
journal: clean up the FSS handling code a bit

2 years agohomed: make all pam_prompt strings translatable
Luca Boccassi [Thu, 13 Jul 2023 11:38:54 +0000 (12:38 +0100)] 
homed: make all pam_prompt strings translatable

Users get prompted with these, so they should be translated.
Note that a comment is moved up, as otherwise the pot generation picks
it up and copies it into the translation file.

Fixes https://github.com/systemd/systemd/issues/28379

2 years agodocs: fix order
David Tardon [Thu, 13 Jul 2023 09:22:51 +0000 (11:22 +0200)] 
docs: fix order

2 years agonetwork: use json_append() and json_variant_append_array() 28376/head
Yu Watanabe [Thu, 13 Jul 2023 06:30:11 +0000 (15:30 +0900)] 
network: use json_append() and json_variant_append_array()

2 years agohashmap: introduce hashmap_dump_sorted() and friends
Yu Watanabe [Thu, 13 Jul 2023 05:43:45 +0000 (14:43 +0900)] 
hashmap: introduce hashmap_dump_sorted() and friends

2 years agologs-show: use json_variant_append_array()
Yu Watanabe [Thu, 13 Jul 2023 02:30:04 +0000 (11:30 +0900)] 
logs-show: use json_variant_append_array()

2 years agotpm2-util: use json_variant_append_array()
Yu Watanabe [Thu, 13 Jul 2023 01:59:43 +0000 (10:59 +0900)] 
tpm2-util: use json_variant_append_array()

2 years agobusctl: use json_variant_append_array()
Yu Watanabe [Thu, 13 Jul 2023 01:54:53 +0000 (10:54 +0900)] 
busctl: use json_variant_append_array()

2 years agoloop-write: do strlen() implicitly if size is specified as SIZE_MAX
Lennart Poettering [Wed, 12 Jul 2023 20:29:17 +0000 (22:29 +0200)] 
loop-write: do strlen() implicitly if size is specified as SIZE_MAX

This reduces repetition in the function calls, since quite often we
write out strings with loop_write().

Noticed while reviewing #28077.

2 years agondisc: honour MTU for onlink prefix
Susant Sahani [Tue, 11 Jul 2023 13:19:14 +0000 (18:49 +0530)] 
ndisc: honour MTU for onlink prefix

Fixes #26520

2 years agoMerge pull request #28368 from mrc0mmand/test-fail-on-error
Luca Boccassi [Wed, 12 Jul 2023 22:51:42 +0000 (23:51 +0100)] 
Merge pull request #28368 from mrc0mmand/test-fail-on-error

test: a couple of clean ups

2 years agoAdd alternate name for MX Ergo as found on some devices
Roger Gammans [Wed, 12 Jul 2023 20:10:53 +0000 (21:10 +0100)] 
Add alternate name for MX Ergo as found on some devices

Fixes #28349

2 years agoupdate TODO
Lennart Poettering [Wed, 12 Jul 2023 20:27:12 +0000 (22:27 +0200)] 
update TODO

2 years agoMerge pull request #28365 from DaanDeMeyer/udevadm-query
Daan De Meyer [Wed, 12 Jul 2023 19:48:04 +0000 (21:48 +0200)] 
Merge pull request #28365 from DaanDeMeyer/udevadm-query

Various fixes and improvements

2 years agologs-show: Rename json_data to JsonData and add typedef 28365/head
Daan De Meyer [Wed, 12 Jul 2023 17:46:46 +0000 (19:46 +0200)] 
logs-show: Rename json_data to JsonData and add typedef

2 years agojson: free array in json_variant_unref_many()
Daan De Meyer [Wed, 12 Jul 2023 12:10:47 +0000 (14:10 +0200)] 
json: free array in json_variant_unref_many()

This allows using it with CLEANUP_ARRAY(). For the 2 call sites
where we don't need to free the array, we do a regular for loop
calling json_variant_unref() instead.

2 years agobasic: Fix color + underline functions/macros
Daan De Meyer [Wed, 12 Jul 2023 08:42:43 +0000 (10:42 +0200)] 
basic: Fix color + underline functions/macros

We currently concatenate ANSI_UNDERLINE to the color of our choice
in DEFINE_ANSI_FUNC_UNDERLINE() and DEFINE_ANSI_FUNC_UNDERLINE_256().
The first thing that ANSI_UNDERLINE does is reset all previous ansi
escape sequences, so you just get underlining without any colors.

Let's fix the issue by actually concatenating _UNDERLINE to the given
color macro name so this works properly.

Also add missing color macros that this uncovered.

2 years agodevice-util: Declare iterator variables inline
Daan De Meyer [Wed, 12 Jul 2023 06:52:12 +0000 (08:52 +0200)] 
device-util: Declare iterator variables inline

2 years agocore: refuse late merge only for anchor job when JOB_RESTART_DEPENDENCIES
Mike Yuan [Sat, 8 Jul 2023 11:45:51 +0000 (19:45 +0800)] 
core: refuse late merge only for anchor job when JOB_RESTART_DEPENDENCIES

Follow-up for 2a39b91459a4c27985d9a58309c0fda25f3cd397

The mentioned change makes all jobs in the transaction unmergeable
if mode == JOB_RESTART_DEPENDENCIES, but we only want the anchor job
to be re-enqueued.

2 years agoMerge pull request #28344 from YHNdnzj/compare-device-node
Lennart Poettering [Wed, 12 Jul 2023 15:59:28 +0000 (17:59 +0200)] 
Merge pull request #28344 from YHNdnzj/compare-device-node

hibernate-resume: add & use devnode_same to compare device nodes

2 years agodocs: cleanups to ROOT_STORAGE_DAEMONS
Micah Abbott [Tue, 11 Jul 2023 15:50:20 +0000 (11:50 -0400)] 
docs: cleanups to ROOT_STORAGE_DAEMONS

There were a couple spelling/grammatical errors in the docs that made
it hard to read and understand parts of this doc. I cleaned up those
errors and reflowed the line breaks to keep to the 80 char limit.

2 years agomkosi: Make sure we build kernel headers
Daan De Meyer [Wed, 12 Jul 2023 06:52:47 +0000 (08:52 +0200)] 
mkosi: Make sure we build kernel headers

Required for building kernel selftests

2 years agotest: unify /testok & /failed handling 28368/head
Frantisek Sumsal [Wed, 12 Jul 2023 13:49:55 +0000 (15:49 +0200)] 
test: unify /testok & /failed handling

And drop it where not necessary.

2 years agotest: fail if we find units/tests in failed state
Frantisek Sumsal [Wed, 12 Jul 2023 13:27:26 +0000 (15:27 +0200)] 
test: fail if we find units/tests in failed state

Instead of relying on the post-test /failed file check.

2 years agotest: drop redundant 'function' keyword
Frantisek Sumsal [Wed, 12 Jul 2023 13:31:14 +0000 (15:31 +0200)] 
test: drop redundant 'function' keyword

2 years agotest: drop spurious whitespaces
Frantisek Sumsal [Wed, 12 Jul 2023 13:52:04 +0000 (15:52 +0200)] 
test: drop spurious whitespaces

2 years agotest: copy out the necessary test data before we start overmounting stuff
Frantisek Sumsal [Tue, 11 Jul 2023 19:03:22 +0000 (21:03 +0200)] 
test: copy out the necessary test data before we start overmounting stuff

Otherwise the get_testdata_dir() call fails if the source tree is under
/root (which is usually the case in CIs).

I got bitten by this after leaving the source tree under /root but moving the
$BUILD_DIR elsewhere. This used to work by accident, as load_testdata_env()
would try to read $BUILD_DIR/systemd-runtest.env, but would fail if the
$BUILD_DIR is also under /root and fall back to SYSTEMD_TEST_DATA
(/lib/systemd/tests/testdata), which usually exist as we install the just built
revision. However, if the $BUILD_DIR is outside of /root we'd read
$BUILD_DIR/systemd-runtest.env which contains
SYSTEMD_TEST_DATA=/path/to/source/tree/test and that source tree is not visible
once we overmount /root with tmpfs making the test fail:

/* test_run_tests_unprivileged */
Successfully forked off '(test-execute-unprivileged)' as PID 10672.
Changing mount flags / (MS_REMOUNT|MS_BIND "")...
Changing mount propagation / (MS_REC|MS_SHARED "")
Mounting tmpfs (tmpfs) on /dev/shm (MS_NOSUID|MS_NODEV "")...
Mounting tmpfs (tmpfs) on /root (MS_NOSUID|MS_NODEV "")...
Mounting tmpfs (tmpfs) on /tmp (MS_NOSUID|MS_NODEV "")...
Mounting tmpfs (tmpfs) on /var/tmp (MS_NOSUID|MS_NODEV "")...
Mounting tmpfs (tmpfs) on /var/lib (MS_NOSUID|MS_NODEV "")...
Mounting tmpfs (tmpfs) on /run/test-execute-unit-dir (MS_NOSUID|MS_NODEV "")...
ERROR: $SYSTEMD_TEST_DATA directory [/root/systemd/test] not accessible: No such file or directory
Assertion 'get_testdata_dir("test-execute/", &unit_dir) >= 0' failed at src/test/test-execute.c:1306, function prepare_ns(). Aborting.
(test-execute-unprivileged) terminated by signal ABRT.

2 years agotest: actually mount / read-only
Frantisek Sumsal [Tue, 11 Jul 2023 18:18:19 +0000 (20:18 +0200)] 
test: actually mount / read-only

2 years agotree-wide: fix typos reported by Fossies Codespell report
Yu Watanabe [Wed, 12 Jul 2023 01:14:50 +0000 (10:14 +0900)] 
tree-wide: fix typos reported by Fossies Codespell report

2 years agoman: move <varlistentry> in <variablelist>
Yu Watanabe [Tue, 11 Jul 2023 06:06:02 +0000 (15:06 +0900)] 
man: move <varlistentry> in <variablelist>

2 years agoimport-creds: don't import creds from SMBIOS/qemu in confidential VMs
Lennart Poettering [Fri, 7 Jul 2023 14:00:09 +0000 (16:00 +0200)] 
import-creds: don't import creds from SMBIOS/qemu in confidential VMs

2 years agohibernate-resume: use devnode_same to compare device nodes 28344/head
Mike Yuan [Mon, 10 Jul 2023 13:04:49 +0000 (21:04 +0800)] 
hibernate-resume: use devnode_same to compare device nodes

Addresses https://github.com/systemd/systemd/pull/28321#discussion_r1257866179

When devnode_same() fails we only debug log about it, because
the device nodes might not have appeared by the time the generator
is run.

Fixes #28340

2 years agoshared/device-nodes: add devnode_same
Mike Yuan [Mon, 10 Jul 2023 12:58:57 +0000 (20:58 +0800)] 
shared/device-nodes: add devnode_same

2 years agopath-util: make path_equal_or_inode_same static inline
Mike Yuan [Mon, 10 Jul 2023 12:42:01 +0000 (20:42 +0800)] 
path-util: make path_equal_or_inode_same static inline

No functional change, just refactoring.

2 years agoseccomp: add arm_fadvise64_64 to system-service group
Yu Watanabe [Tue, 11 Jul 2023 03:28:06 +0000 (12:28 +0900)] 
seccomp: add arm_fadvise64_64 to system-service group

fadvise64 and fadvise64_64 are already in the group, but arm_ version
was not.

Fixes #28350.

2 years agoMerge pull request #28348 from YHNdnzj/async-close-waitpid
Lennart Poettering [Tue, 11 Jul 2023 09:53:03 +0000 (11:53 +0200)] 
Merge pull request #28348 from YHNdnzj/async-close-waitpid

shared/async: don't use WEXITED for waitpid()

2 years agoshared/async: don't use WEXITED for waitpid() 28348/head
Mike Yuan [Mon, 10 Jul 2023 17:46:29 +0000 (01:46 +0800)] 
shared/async: don't use WEXITED for waitpid()

Follow-up for c26d7837bb08508c8d906d849dff8f1bc465063e

waitpid() doesn't support WEXITED and returns -1 (EINVAL),
which results in the intermediate close process not getting
reaped.

Fixes https://github.com/systemd/systemd/issues/26744#issuecomment-1628240782

2 years agoshared/async: prefix process name with sd-
Mike Yuan [Tue, 11 Jul 2023 04:06:14 +0000 (12:06 +0800)] 
shared/async: prefix process name with sd-

2 years agoMerge pull request #28343 from poettering/daemon-reload-common
Yu Watanabe [Mon, 10 Jul 2023 23:42:19 +0000 (08:42 +0900)] 
Merge pull request #28343 from poettering/daemon-reload-common

tree-wide: add common implementation of Reload() bus call to PID 1

2 years agoMerge pull request #28333 from DaanDeMeyer/tpm-support-dlopen
Daan De Meyer [Mon, 10 Jul 2023 16:14:17 +0000 (18:14 +0200)] 
Merge pull request #28333 from DaanDeMeyer/tpm-support-dlopen

tpm2-util: Only assume system support if we can dlopen() the tpm libraries

2 years agotree-wide: drop trailing newline from various log calls 28343/head
Lennart Poettering [Mon, 10 Jul 2023 12:54:11 +0000 (14:54 +0200)] 
tree-wide: drop trailing newline from various log calls

We generate this implicitly, hence we generally don't include it
explicitly.

2 years agobus-unit-util: add common code for reloading PID 1
Lennart Poettering [Wed, 5 Jul 2023 15:54:01 +0000 (17:54 +0200)] 
bus-unit-util: add common code for reloading PID 1

We have this very similar code in various places, and it#s not entirely
obvious (since we want a prolonged timeout for the reload), hence unify
this at one place.

2 years agotest-fstab-generator: use test_env
Luca Boccassi [Mon, 10 Jul 2023 10:59:57 +0000 (11:59 +0100)] 
test-fstab-generator: use test_env

When running from the build directory systemd-detect-virt might not be installed,
so tell meson to set up the PATH accordingly to point to the build directory.

Fixes https://github.com/systemd/systemd/issues/28316

2 years agosd-gpt: add missing SD_GPT_*NATIVE* defines for mips/mips64/parisc
Luca Boccassi [Mon, 10 Jul 2023 11:58:02 +0000 (12:58 +0100)] 
sd-gpt: add missing SD_GPT_*NATIVE* defines for mips/mips64/parisc

We already had the arch-specific UUIDs defined, but they were not wired up

2 years agoMerge pull request #28308 from bluca/casting
Luca Boccassi [Mon, 10 Jul 2023 14:27:13 +0000 (15:27 +0100)] 
Merge pull request #28308 from bluca/casting

Fix compilation on mipsel, ia64 and x32

2 years agotest: reorder the machinectl signal tests
Frantisek Sumsal [Mon, 10 Jul 2023 08:39:00 +0000 (10:39 +0200)] 
test: reorder the machinectl signal tests

So the multiple-machines tests run last to avoid a race where the
checked signal would get ignored while the stub init is still processing
the previous signals:

[   17.380417] testsuite-13.sh[376]: + machinectl reboot long-running long-running long-running
[   17.389888] systemd-nspawn[495]: ++ touch /reboot
[   17.390904] testsuite-13.sh[376]: + rm -f /var/lib/machines/long-running/trap
[   17.393937] testsuite-13.sh[376]: + machinectl kill --signal=SIGTRAP --kill-whom=leader long-running
[   17.408905] testsuite-13.sh[376]: + timeout 10 bash -c 'while ! test -e /var/lib/machines/long-running/trap; do sleep .5; done'
[   27.413210] testsuite-13.sh[376]: + at_exit
...
[   27.993376] testsuite-13.sh[373]: + echo 'Subtest /usr/lib/systemd/tests/testdata/units/testsuite-13.machinectl.sh failed'

2 years agomkosi: Add tpm2-tools to the initrd
Daan De Meyer [Mon, 10 Jul 2023 12:48:34 +0000 (14:48 +0200)] 
mkosi: Add tpm2-tools to the initrd

To provide tpm2_eventlog for PCR debugging.

2 years agoMerge pull request #28334 from DaanDeMeyer/network-generator
Daan De Meyer [Mon, 10 Jul 2023 13:49:42 +0000 (15:49 +0200)] 
Merge pull request #28334 from DaanDeMeyer/network-generator

Network generator fixes

2 years agoanalyze-pcrs: Fix typo 28333/head
Daan De Meyer [Mon, 10 Jul 2023 10:49:52 +0000 (12:49 +0200)] 
analyze-pcrs: Fix typo

2 years agotpm2-util: Check for dlopen() when calculating tpm2 support
Daan De Meyer [Mon, 10 Jul 2023 10:20:33 +0000 (12:20 +0200)] 
tpm2-util: Check for dlopen() when calculating tpm2 support

2 years agosleep: fix unused variable warning 28308/head
Luca Boccassi [Sun, 9 Jul 2023 12:03:44 +0000 (13:03 +0100)] 
sleep: fix unused variable warning

log_level_ignored is used only inside the ifdef, so declare it there too

2 years agoprocess-util: use clone2 on ia64
Luca Boccassi [Sat, 8 Jul 2023 15:43:28 +0000 (16:43 +0100)] 
process-util: use clone2 on ia64

glibc does not provide clone() on ia64, only clone2. But only as a
symbol in the shared library, there's no prototype in the gblic
headers, so we have to define it, copied from the manpage.

2 years agoCast st_dev to dev_t when printing
Luca Boccassi [Sat, 8 Jul 2023 15:35:00 +0000 (16:35 +0100)] 
Cast st_dev to dev_t when printing

st_dev is not the same as dev_t, and on O32 architectures like
mipsel it's an unsigned long, but dev_t is still unsigned long long,
so they don't match and compilation fails:

../src/journal/cat.c: In function ‘run’:
../src/basic/format-util.h:46:19: error: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘long unsigned int’ [-Werror=format=]
   46 | #  define DEV_FMT "%" PRIu64
      |                   ^~~
../src/journal/cat.c:168:34: note: in expansion of macro ‘DEV_FMT’
  168 |                 if (asprintf(&s, DEV_FMT ":" INO_FMT, st.st_dev, st.st_ino) < 0)
      |                                  ^~~~~~~
In file included from ../src/systemd/sd-journal.h:20,
                 from ../src/journal/cat.c:11:
/usr/include/inttypes.h:105:41: note: format string is defined here
  105 | # define PRIu64         __PRI64_PREFIX "u"

2 years agonetwork-generator: Add missing umask(0022) 28334/head
Daan De Meyer [Mon, 10 Jul 2023 10:30:35 +0000 (12:30 +0200)] 
network-generator: Add missing umask(0022)

2 years agonetwork-generator: Add missing log_setup()
Daan De Meyer [Mon, 10 Jul 2023 10:30:15 +0000 (12:30 +0200)] 
network-generator: Add missing log_setup()

2 years agoboot: Fix build for x32
Jan Janssen [Sun, 9 Jul 2023 17:30:27 +0000 (19:30 +0200)] 
boot: Fix build for x32

When building on a x32 system we need to explicitly pass `-m64` to get
the right ABI as the kernel and EFI are still 64bit. For this to
actually work, a suitable multilib compiler, 32bit libc headers and
libgcc need to be installed (similar to ia32 builds on x86_64).

2 years agoPrint ssize_t as %zd
Luca Boccassi [Sat, 8 Jul 2023 15:21:37 +0000 (16:21 +0100)] 
Print ssize_t as %zd

On some architectures (x32) ssize_t is int, not long int.

../src/basic/confidential-virt.c: In function ‘msr’:
../src/basic/confidential-virt.c:133:27: error: format ‘%ld’ expects argument of type ‘long int’, but argument 7 has type ‘ssize_t’ {aka ‘int’} [-Werror=format=]
  133 |                 log_debug("Short read %ld bytes from MSR device %s (index %" PRIu64 "), ignoring",
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  134 |                           rv,
      |                           ~~
      |                           |
      |                           ssize_t {aka int}
../src/basic/log.h:214:86: note: in definition of macro ‘log_full_errno_zerook’
  214 |                         ? log_internal(_level, _e, PROJECT_FILE, __LINE__, __func__, __VA_ARGS__) \
      |                                                                                      ^~~~~~~~~~~
../src/basic/log.h:242:28: note: in expansion of macro ‘log_full’
  242 | #define log_debug(...)     log_full(LOG_DEBUG,   __VA_ARGS__)
      |                            ^~~~~~~~
../src/basic/confidential-virt.c:133:17: note: in expansion of macro ‘log_debug’
  133 |                 log_debug("Short read %ld bytes from MSR device %s (index %" PRIu64 "), ignoring",
      |                 ^~~~~~~~~
../src/basic/confidential-virt.c:133:41: note: format string is defined here
  133 |                 log_debug("Short read %ld bytes from MSR device %s (index %" PRIu64 "), ignoring",
      |                                       ~~^
      |                                         |
      |                                         long int
      |                                       %d

2 years agotest: mount_option_supported() returns EAGAIN when new mount API is not supported
Luca Boccassi [Mon, 10 Jul 2023 00:00:18 +0000 (01:00 +0100)] 
test: mount_option_supported() returns EAGAIN when new mount API is not supported

Don't fail test-mountpoint-util if we get EAGAIN as it's expected on old
kernels

2 years agoefi: skip libefitest if 'bootloader' is explicitly set to false
Luca Boccassi [Sun, 9 Jul 2023 13:39:05 +0000 (14:39 +0100)] 
efi: skip libefitest if 'bootloader' is explicitly set to false

On x32 efi_arch will be set as the kernel architecture is just x86_64,
but there's no userland support to build the EFI ABI. When -Dbootloader=false
is set, skip libefitest too.

2 years agoMerge pull request #28321 from YHNdnzj/hibernate-resume-compare-dev
Luca Boccassi [Sun, 9 Jul 2023 23:13:08 +0000 (00:13 +0100)] 
Merge pull request #28321 from YHNdnzj/hibernate-resume-compare-dev

hibernate-resume: follow-ups

2 years agohibernate-resume: compare device nodes using path_equal_or_inode_same 28321/head
Mike Yuan [Sun, 9 Jul 2023 16:40:13 +0000 (00:40 +0800)] 
hibernate-resume: compare device nodes using path_equal_or_inode_same

Follow-up for 9deeca127520b1098c3dfab9cdfd3b9c6bf983a4

2 years agohibernate-resume: add missing newline to the generated unit
Mike Yuan [Sun, 9 Jul 2023 16:35:31 +0000 (00:35 +0800)] 
hibernate-resume: add missing newline to the generated unit

2 years agohibernate-resume: refuse resume if resume_offset= is set but not resume=
Mike Yuan [Sat, 8 Jul 2023 22:10:18 +0000 (06:10 +0800)] 
hibernate-resume: refuse resume if resume_offset= is set but not resume=

2 years agococcinelle/take-fd: match for -EBADF instead of -1
Mike Yuan [Sat, 8 Jul 2023 18:33:26 +0000 (02:33 +0800)] 
coccinelle/take-fd: match for -EBADF instead of -1

Follow-up for 254d1313ae5a69c08c9b93032aaaf3d6083cfc07

2 years agoLICENSES/README.md: fix syntax
Mike Yuan [Sat, 8 Jul 2023 22:16:10 +0000 (06:16 +0800)] 
LICENSES/README.md: fix syntax

2 years agoseccomp: add riscv_hwprobe to @default
Xeonacid [Sat, 8 Jul 2023 12:56:47 +0000 (20:56 +0800)] 
seccomp: add riscv_hwprobe to @default

This syscall is for probing hardware capabilities from userspace and should do no harm.
Added in https://github.com/torvalds/linux/commit/ea3de9ce8aa280c5175c835bd3e94a3a9b814b74

2 years agoMerge pull request #28309 from weblate/weblate-systemd-master
Mike Yuan [Sat, 8 Jul 2023 17:47:01 +0000 (01:47 +0800)] 
Merge pull request #28309 from weblate/weblate-systemd-master

Translations update from Fedora Weblate

2 years agopo: Translated using Weblate (Georgian) 28309/head
Temuri Doghonadze [Sat, 8 Jul 2023 17:21:02 +0000 (19:21 +0200)] 
po: Translated using Weblate (Georgian)

Currently translated at 100.0% (195 of 195 strings)

Co-authored-by: Temuri Doghonadze <temuri.doghonadze@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/ka/
Translation: systemd/main

2 years agopo: Translated using Weblate (Ukrainian)
Yuri Chornoivan [Sat, 8 Jul 2023 17:21:02 +0000 (19:21 +0200)] 
po: Translated using Weblate (Ukrainian)

Currently translated at 100.0% (195 of 195 strings)

Co-authored-by: Yuri Chornoivan <yurchor@ukr.net>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/uk/
Translation: systemd/main

2 years agopo: Translated using Weblate (Swedish)
Luna Jernberg [Sat, 8 Jul 2023 17:21:02 +0000 (19:21 +0200)] 
po: Translated using Weblate (Swedish)

Currently translated at 100.0% (195 of 195 strings)

Co-authored-by: Luna Jernberg <bittin@reimu.nl>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/sv/
Translation: systemd/main

2 years agopo: Translated using Weblate (Korean)
김인수 [Sat, 8 Jul 2023 17:21:02 +0000 (19:21 +0200)] 
po: Translated using Weblate (Korean)

Currently translated at 100.0% (195 of 195 strings)

Co-authored-by: 김인수 <simmon@nplob.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/ko/
Translation: systemd/main

2 years agopo: Translated using Weblate (Czech)
Pavel Borecki [Sat, 8 Jul 2023 17:21:01 +0000 (19:21 +0200)] 
po: Translated using Weblate (Czech)

Currently translated at 100.0% (195 of 195 strings)

Co-authored-by: Pavel Borecki <pavel.borecki@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/cs/
Translation: systemd/main