]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
18 months agotest: do not fill journal with diff 32885/head
Yu Watanabe [Fri, 17 May 2024 05:15:51 +0000 (14:15 +0900)] 
test: do not fill journal with diff

18 months agotest: do not fill journal with "wait"
Yu Watanabe [Fri, 17 May 2024 05:14:00 +0000 (14:14 +0900)] 
test: do not fill journal with "wait"

18 months agorepart: remove duplicate word in --help
Zbigniew Jędrzejewski-Szmek [Sat, 11 May 2024 11:10:14 +0000 (13:10 +0200)] 
repart: remove duplicate word in --help

My bad; follow-up for 4955d2e36706bba9ba6595b0c5babb8f17f13465.

18 months agotest: Enable TEST-69-SHUTDOWN for mkosi
Daan De Meyer [Thu, 16 May 2024 10:28:51 +0000 (12:28 +0200)] 
test: Enable TEST-69-SHUTDOWN for mkosi

In mkosi, we run the test inside the VM instead of outside. To simplify
the implementation we drop the reboot part and only verify that we can
schedule and cancel shutdowns and that the wall messages are sent as
expected.

18 months agoRevert "CI: add manual workflow to publish pages to fix submodule issue"
Luca Boccassi [Thu, 16 May 2024 14:31:52 +0000 (15:31 +0100)] 
Revert "CI: add manual workflow to publish pages to fix submodule issue"

Nope, it's broken, never mind

This reverts commit b0f9c3c6483eadd630b0a6a4de23db761e8158c8.

18 months agoCI: add manual workflow to publish pages to fix submodule issue
Luca Boccassi [Thu, 16 May 2024 14:19:32 +0000 (15:19 +0100)] 
CI: add manual workflow to publish pages to fix submodule issue

Cloning the fedora/centos submodules fails because --depth 1 is used. Fork the actions workflow and use fetch-depth: 0 to disable it.

18 months agoMerge pull request #32863 from YHNdnzj/switch-root-followup
Luca Boccassi [Thu, 16 May 2024 13:53:18 +0000 (15:53 +0200)] 
Merge pull request #32863 from YHNdnzj/switch-root-followup

Two minor followups

18 months agoMerge pull request #32842 from DaanDeMeyer/cryptsetup
Daan De Meyer [Thu, 16 May 2024 13:50:55 +0000 (15:50 +0200)] 
Merge pull request #32842 from DaanDeMeyer/cryptsetup

test: Enable TEST-24-CRYPTSETUP for mkosi

18 months agotest: Enable TEST-24-CRYPTSETUP for mkosi 32842/head
Daan De Meyer [Wed, 15 May 2024 11:19:19 +0000 (13:19 +0200)] 
test: Enable TEST-24-CRYPTSETUP for mkosi

Encrypted /var is skipped because meson's limitations make per test
images not really feasible and we can't encrypt /var by default because
it slows down the image build too much.

Co-authored-by: Richard Maw <richard.maw@codethink.co.uk>
18 months agonetwork: configure a tun host0 interface in a container
Helmut Grohne [Wed, 15 May 2024 05:21:53 +0000 (07:21 +0200)] 
network: configure a tun host0 interface in a container

While containers often have their host0 network provided by veth when
the container runtime is privileged, unprivileged containers tend to
have their network provided via slirp4netns or pasta. These tools use a
tun interface rather than a veth interface and systemd should still set
configure such networks.

We should have different .network files for the veth and tun use cases
as there may arise a need to configure them differently.  We should not
rename 80-container-host0.network as that would cause existing drop-ins
to no longer apply.

Closes: #32095
Fixes: f139393dd20a ("network: use Kind= instead of Driver=")
Signed-off-by: Helmut Grohne <helmut@subdivi.de>
18 months agotest: add coverate for Compress=yes config option
Luca Boccassi [Thu, 16 May 2024 10:03:42 +0000 (11:03 +0100)] 
test: add coverate for Compress=yes config option

Avoid regressions like https://github.com/systemd/systemd/issues/32856

Follow-up for 2ef7cdc4255883d1c50860661248c9db69a86aa1

18 months agomkosi: Update centos to latest
Daan De Meyer [Thu, 16 May 2024 10:14:17 +0000 (12:14 +0200)] 
mkosi: Update centos to latest

18 months agojournal-importer: Consider ECONNRESET as EOF
Daan De Meyer [Wed, 15 May 2024 19:40:12 +0000 (21:40 +0200)] 
journal-importer: Consider ECONNRESET as EOF

Otherwise we log a noisy error when we get ECONNRESET.

18 months agoswitch-root: update comment regarding dropped mounts 32863/head
Mike Yuan [Thu, 16 May 2024 11:15:11 +0000 (19:15 +0800)] 
switch-root: update comment regarding dropped mounts

Follow-up for 07c5c2ab8b80f75a1c89fc405db1ce1dfd08534b

18 months agofd-util: check and log error properly for fd_reopen_propagate_append_and_position
Mike Yuan [Thu, 16 May 2024 11:12:38 +0000 (19:12 +0800)] 
fd-util: check and log error properly for fd_reopen_propagate_append_and_position

Follow-up for b8e25bff386548f679902c6b797a5a8ff1542c8b

18 months agope-binary: .initrd section is optional for UKI
Yu Watanabe [Wed, 15 May 2024 21:08:27 +0000 (06:08 +0900)] 
pe-binary: .initrd section is optional for UKI

.osrel is also optional, but sd-boot and bootctl requires it.
So, let's keep .osrel section at least now.

Fixes #32774.

18 months agoMerge pull request #32800 from YHNdnzj/preserve-cred-mounts
Zbigniew Jędrzejewski-Szmek [Thu, 16 May 2024 10:45:40 +0000 (12:45 +0200)] 
Merge pull request #32800 from YHNdnzj/preserve-cred-mounts

switch-root: preserve the whole cred mount tree (/run/credentials/)

18 months agoTEST-24-CRYPTSETUP: Store tokens in /usr
Daan De Meyer [Wed, 15 May 2024 12:00:51 +0000 (14:00 +0200)] 
TEST-24-CRYPTSETUP: Store tokens in /usr

We want to be able to boot with empty /var.

18 months agorepart: Improve error message
Daan De Meyer [Wed, 15 May 2024 14:21:45 +0000 (16:21 +0200)] 
repart: Improve error message

18 months agoMerge pull request #32857 from dtardon/drop-assert
Luca Boccassi [Thu, 16 May 2024 10:04:51 +0000 (12:04 +0200)] 
Merge pull request #32857 from dtardon/drop-assert

Drop invalid asserts

18 months agocore: Skip private /tmp for generators in manager test runs
Daan De Meyer [Wed, 15 May 2024 18:54:33 +0000 (20:54 +0200)] 
core: Skip private /tmp for generators in manager test runs

For manager test runs, the generator output paths are located in
/tmp, which means that if we mount a private /tmp for generators,
we lose all the generated units (actually the generators will just
fail because the directories don't exist, but if they did exist,
we'd still lose all the units).

Let's avoid the problem by skipping the private /tmp for manager
test runs. This also avoids any possible privilege issues with
mounting a private /tmp that might happen in this scenario.

18 months agojournald-server: drop another invalid assert() 32857/head
David Tardon [Thu, 16 May 2024 07:03:40 +0000 (09:03 +0200)] 
journald-server: drop another invalid assert()

config_parse_forward_to_socket() is not used for parsing unit files
either.

Follow-up-for: f31cff849d3db074d0d8157e4117d9b8372c03e8

18 months agojournald-server: drop invalid assert()
David Tardon [Thu, 16 May 2024 06:59:50 +0000 (08:59 +0200)] 
journald-server: drop invalid assert()

config_parse_compress() is not used for parsing unit files, hence unit
is always NULL.

Fixes #32856

Follow-up-for: 6813be2eba24a2f864d5d47326437dbff38cd675

18 months agoMerge pull request #32784 from YHNdnzj/release-version
Luca Boccassi [Wed, 15 May 2024 18:25:59 +0000 (20:25 +0200)] 
Merge pull request #32784 from YHNdnzj/release-version

docs/RELEASE: use meson.version for tags

18 months agohwdb.d/60-keyboard.hwdb: enable Clevo quirk for model V5x0TU
Michał Kopeć [Wed, 15 May 2024 15:33:39 +0000 (17:33 +0200)] 
hwdb.d/60-keyboard.hwdb: enable Clevo quirk for model V5x0TU

Enable the display switch function key quirk for a new model.

Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
18 months agosystemctl: fix "applying zero offset to null pointer" UBSan error
Yu Watanabe [Wed, 15 May 2024 15:45:06 +0000 (00:45 +0900)] 
systemctl: fix "applying zero offset to null pointer" UBSan error

Fixes #32837.

18 months agoTEST-82-SOFTREBOOT: test that creds for surviving units are carried over 32800/head
Mike Yuan [Tue, 14 May 2024 11:34:11 +0000 (19:34 +0800)] 
TEST-82-SOFTREBOOT: test that creds for surviving units are carried over

18 months agoswitch-root: preserve the whole cred mount tree (/run/credentials/)
Mike Yuan [Tue, 14 May 2024 09:03:00 +0000 (17:03 +0800)] 
switch-root: preserve the whole cred mount tree (/run/credentials/)

Currently, during soft-reboot, some services may survive,
but their associated credential mounts are dropped.
Let's instead preserve them, as discussed.

18 months agotest/test-rpm-macros.sh: add build directory to pkg-config search path
Radoslav Kolev [Tue, 14 May 2024 09:19:22 +0000 (12:19 +0300)] 
test/test-rpm-macros.sh: add build directory to pkg-config search path

If tests are run during build time, without an already installed
systemd they fail to resolve the sysusersdir and tpmfilesdir pkg-config variables.

18 months agoMerge pull request #32844 from YHNdnzj/mount-defaultdep-followup
Luca Boccassi [Wed, 15 May 2024 16:23:26 +0000 (18:23 +0200)] 
Merge pull request #32844 from YHNdnzj/mount-defaultdep-followup

core/mount: correctly set DefaultDependencies=no for mounts from mountinfo

18 months agoMerge pull request #32818 from keszybz/libsystemd-network-size-check
Luca Boccassi [Wed, 15 May 2024 15:33:22 +0000 (17:33 +0200)] 
Merge pull request #32818 from keszybz/libsystemd-network-size-check

Check packet size in libsystemd-network

18 months agocore/mount: correctly set DefaultDependencies=no for mounts from mountinfo 32844/head
Mike Yuan [Wed, 15 May 2024 13:49:00 +0000 (21:49 +0800)] 
core/mount: correctly set DefaultDependencies=no for mounts from mountinfo

Follow-up for 3c0a1b1e70c1fe6e0b6707fab7dc86b1500d0f82

Before this commit, DefaultDependencies=no is set in
mount_add_extras(). However, when generating mount units
from /proc/self/mountinfo, we don't have a unit in memory
yet, and mount_setup_new_unit() doesn't call into
mount_add_extras().

Fixes #32838

18 months agocore/swap: rename variable 'new' -> 'new_unit'
Mike Yuan [Wed, 15 May 2024 13:52:47 +0000 (21:52 +0800)] 
core/swap: rename variable 'new' -> 'new_unit'

Follow-up for ba31a5018f99864c22dd4e0f10712456c7abc934

'new' is already used as a macro for memory allocation.
Let's avoid the confusion here.

Addresses https://github.com/systemd/systemd/pull/31902#discussion_r1557672858

18 months agoman: fix typo 'ot' -> 'or'
Luca Boccassi [Wed, 15 May 2024 10:57:06 +0000 (11:57 +0100)] 
man: fix typo 'ot' -> 'or'

18 months agocore: Fix assertion in parse_smbios_strings()
Daan De Meyer [Wed, 15 May 2024 10:26:33 +0000 (12:26 +0200)] 
core: Fix assertion in parse_smbios_strings()

18 months agoTEST-08-INITRD: Fix result check
Daan De Meyer [Wed, 15 May 2024 10:32:57 +0000 (12:32 +0200)] 
TEST-08-INITRD: Fix result check

18 months agoMerge pull request #32835 from DaanDeMeyer/test
Daan De Meyer [Wed, 15 May 2024 09:58:22 +0000 (11:58 +0200)] 
Merge pull request #32835 from DaanDeMeyer/test

test: Enable TEST-08-INITRD on mkosi

18 months agotest: Enable TEST-08-INITRD on mkosi 32835/head
Daan De Meyer [Wed, 15 May 2024 08:09:53 +0000 (10:09 +0200)] 
test: Enable TEST-08-INITRD on mkosi

18 months agotest: Rename "shutdown initrd" to "exitrd"
Daan De Meyer [Wed, 15 May 2024 06:48:46 +0000 (08:48 +0200)] 
test: Rename "shutdown initrd" to "exitrd"

18 months agoTEST-64-UDEV-STORAGE: Give higher priority
Daan De Meyer [Wed, 15 May 2024 05:27:00 +0000 (07:27 +0200)] 
TEST-64-UDEV-STORAGE: Give higher priority

Some of the udev storage tests can take quite a while, so let's make
sure they start early enough.

18 months agoTEST-85-NETWORK: Give higher priority
Daan De Meyer [Wed, 15 May 2024 05:26:15 +0000 (07:26 +0200)] 
TEST-85-NETWORK: Give higher priority

Some of the networkd tests can take quite a while, so let's make sure
they start early enough.

18 months agoTEST-21-DFUZZER: Fix priority
Daan De Meyer [Wed, 15 May 2024 06:26:34 +0000 (08:26 +0200)] 
TEST-21-DFUZZER: Fix priority

Tests with higher priority, not lower priority are started first.

18 months agoMerge pull request #32666 from DaanDeMeyer/mkosi-network
Daan De Meyer [Wed, 15 May 2024 05:30:04 +0000 (07:30 +0200)] 
Merge pull request #32666 from DaanDeMeyer/mkosi-network

test: Add TEST-85-NETWORK to run systemd-networkd-tests.py

18 months agoFinalize for v256~rc2 v256-rc2
Luca Boccassi [Tue, 14 May 2024 23:29:01 +0000 (00:29 +0100)] 
Finalize for v256~rc2

18 months agoMerge pull request #32830 from yuwata/home-skel
Luca Boccassi [Tue, 14 May 2024 23:26:15 +0000 (01:26 +0200)] 
Merge pull request #32830 from yuwata/home-skel

home: fix ownership of files copied from skelton directory

18 months agotest: add tests for "homectl --skel" 32830/head
Yu Watanabe [Tue, 14 May 2024 21:34:43 +0000 (06:34 +0900)] 
test: add tests for "homectl --skel"

18 months agoTEST-21-DFUZZER: Fix script name
Daan De Meyer [Tue, 14 May 2024 18:52:28 +0000 (20:52 +0200)] 
TEST-21-DFUZZER: Fix script name

18 months agohome: fix ownership of files copied from skelton directory
Yu Watanabe [Tue, 14 May 2024 21:19:42 +0000 (06:19 +0900)] 
home: fix ownership of files copied from skelton directory

Fixes #32808.

18 months agocore,vconsole-setup: treat locking failure as non-fatal
Zbigniew Jędrzejewski-Szmek [Tue, 14 May 2024 18:00:48 +0000 (20:00 +0200)] 
core,vconsole-setup: treat locking failure as non-fatal

Locking of the tty device and then /dev/console was added to synchronize
vconsole-setup with other writers to the console. But it turns out that often
the locking doesn't work and we carved out various cases where we ignore
failure:
- lack of permissions (in the user manager)
- missing device node

It turns out that there's at least one more failure mode: we get -EIO when the
console is (mis-)configured to point to an invalid device. E.g. in
rhbug#2273069 the reporter has a VM in Proxmox without a virtual console
configured and has 'console=tty console=ttyS0' on the kernel cmdline. I
couldn't reproduce this under libvirt, but failure with EIO has been reported
by at least four users in #30501.

Note that in systemd-vconsole-setup we report this is a hard failure, while
in the manager, we only do a debug line. So it's possible that the failure
also occured there, causing the rest of the setup of the tty to be skipped
without further notice.

Ignore the locking failure, since there's just too many ways it can fail. If we
proceed without a lock, we're back to the situation before we started locking,
which wasn't too bad. OTOH, skipping setup of the console is problematic for
users, and it seems better to try to do the setup without locking.

Fixes https://github.com/systemd/systemd/issues/30501,
https://bugzilla.redhat.com/show_bug.cgi?id=2273069.

18 months agotest: Enable TEST-54-CREDS on mkosi
Daan De Meyer [Tue, 14 May 2024 20:14:27 +0000 (22:14 +0200)] 
test: Enable TEST-54-CREDS on mkosi

18 months agotest: Add TEST-85-NETWORK to run systemd-networkd-tests.py 32666/head
Daan De Meyer [Mon, 6 May 2024 13:23:24 +0000 (15:23 +0200)] 
test: Add TEST-85-NETWORK to run systemd-networkd-tests.py

This adds a testsuite unit to run systemd-networkd-tests.py. This is
mkosi only for now as python is not available in the images set up
by the bash framework. We give the test a lower priority as it takes
a while to run so we want to start it as soon as possible.

18 months agotest: Allow using TEST_MATCH_TESTCASE with systemd-networkd-tests.py
Daan De Meyer [Tue, 14 May 2024 13:22:06 +0000 (15:22 +0200)] 
test: Allow using TEST_MATCH_TESTCASE with systemd-networkd-tests.py

18 months agomkosi: Disable journald rate-limiting
Daan De Meyer [Mon, 13 May 2024 19:19:14 +0000 (21:19 +0200)] 
mkosi: Disable journald rate-limiting

18 months agoMerge pull request #32817 from YHNdnzj/core-varlink
Luca Boccassi [Tue, 14 May 2024 20:40:01 +0000 (22:40 +0200)] 
Merge pull request #32817 from YHNdnzj/core-varlink

core/core-varlink: trivial cleanups

18 months agopo: Update translation files
Weblate [Tue, 14 May 2024 20:06:31 +0000 (22:06 +0200)] 
po: Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Co-authored-by: Weblate <noreply@weblate.org>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/
Translation: systemd/main

18 months agoMerge pull request #32816 from bluca/chores
Luca Boccassi [Tue, 14 May 2024 20:07:40 +0000 (22:07 +0200)] 
Merge pull request #32816 from bluca/chores

Chores for RC2

18 months agotest: Enable TEST-82-SOFTREBOOT on mkosi
Daan De Meyer [Tue, 14 May 2024 18:08:00 +0000 (20:08 +0200)] 
test: Enable TEST-82-SOFTREBOOT on mkosi

18 months agomkosi: Restore job for F40
Zbigniew Jędrzejewski-Szmek [Tue, 14 May 2024 19:02:40 +0000 (21:02 +0200)] 
mkosi: Restore job for F40

This partially reverts ecf8468dd4abbf006cb607d023018edee51c851d.
dist-git was made compatible again with F40.

18 months agoMerge pull request #32812 from DaanDeMeyer/test
Daan De Meyer [Tue, 14 May 2024 18:50:38 +0000 (20:50 +0200)] 
Merge pull request #32812 from DaanDeMeyer/test

test: Only add tpm2.target dependency to TEST-70-TPM2.service

18 months agosysusers: simplify meson config
Zbigniew Jędrzejewski-Szmek [Mon, 13 May 2024 16:53:51 +0000 (18:53 +0200)] 
sysusers: simplify meson config

There were two parts, for templated and non-templated files, and
they were more different than they should be.

18 months agomkosi: Update fedora to latest
Daan De Meyer [Mon, 13 May 2024 13:17:06 +0000 (15:17 +0200)] 
mkosi: Update fedora to latest

We drop the Fedora 40 job as the latest rawhide spec introduced
dependencies that are not available in Fedora 40.

18 months agocore/exec-credential: downgrade warning about missing cred to debug
Zbigniew Jędrzejewski-Szmek [Tue, 14 May 2024 14:19:31 +0000 (16:19 +0200)] 
core/exec-credential: downgrade warning about missing cred to debug

Follow-up for 6b34871f5d3b0729ef125d79dfe2d493f3b52b40.

The general idea is that the list of credentials to load can and will specify
credentials which actually aren't provided, so a warning is too much. Let's
downgrade this to "info". If it turns out to be too noisy, we can downgrade
further in the future.

18 months agotest: rename file with stub functions 32818/head
Zbigniew Jędrzejewski-Szmek [Tue, 14 May 2024 15:59:09 +0000 (17:59 +0200)] 
test: rename file with stub functions

icmp6-util-linux.c sounds like a specialized implementation of the functions in
icmp6-util.c. But it's just a set of stub versions used in tests. Rename the
file to make this more obvious.

18 months agolibsystemd-network: use normal style for error checking
Zbigniew Jędrzejewski-Szmek [Tue, 14 May 2024 16:51:57 +0000 (18:51 +0200)] 
libsystemd-network: use normal style for error checking

We generally use a flat list. The switch stmt was generating excessive
indentation.

18 months agolibsystemd-network: check size of icmpv6 packets
Zbigniew Jędrzejewski-Szmek [Tue, 14 May 2024 16:43:29 +0000 (18:43 +0200)] 
libsystemd-network: check size of icmpv6 packets

Coverity was complaining that we use the received packet size as a loop bound
without checking. This is indeed a bit iffy, because depending on how the host
is configured, the packet could be rather large. Let's refuse anything more
than the standard size early to prevent suspicious activity.

Resolves coverity CID#1534892, CID#1543949.

18 months agolibsystemd-network: remove double initialization
Zbigniew Jędrzejewski-Szmek [Tue, 14 May 2024 16:04:31 +0000 (18:04 +0200)] 
libsystemd-network: remove double initialization

18 months agocore/varlink: make manager_setup_varlink_server static 32817/head
Mike Yuan [Tue, 14 May 2024 16:41:06 +0000 (00:41 +0800)] 
core/varlink: make manager_setup_varlink_server static

Follow-up for 6906c028e83b77b35eaaf87b27d0fe5c6e1984b7

Also, use correct log level for varlink_server_add_interface_many().

18 months agocore/varlink: use FOREACH_ELEMENT more
Mike Yuan [Tue, 14 May 2024 16:44:13 +0000 (00:44 +0800)] 
core/varlink: use FOREACH_ELEMENT more

18 months agotree-wide: 'allows to' -> 'allows one to'
Luca Boccassi [Tue, 14 May 2024 13:38:37 +0000 (14:38 +0100)] 
tree-wide: 'allows to' -> 'allows one to'

As flagged by Lintian

18 months agoTEST-64-UDEV-STORAGE: Fix drive ID 32812/head
Daan De Meyer [Tue, 14 May 2024 16:23:59 +0000 (18:23 +0200)] 
TEST-64-UDEV-STORAGE: Fix drive ID

18 months agoUpdate translation files 32816/head
Luca Boccassi [Tue, 14 May 2024 16:12:04 +0000 (17:12 +0100)] 
Update translation files

ninja -C build systemd-pot
ninja -C build systemd-update-po

18 months agoUpdate syscalls table
Luca Boccassi [Tue, 14 May 2024 16:01:08 +0000 (17:01 +0100)] 
Update syscalls table

ninja -C build update-syscall-tables update-syscall-header

18 months agoUpdate hwdb
Luca Boccassi [Tue, 14 May 2024 16:00:29 +0000 (17:00 +0100)] 
Update hwdb

ninja -C build update-hwdb

18 months agoNEWS: update contributors list
Luca Boccassi [Tue, 14 May 2024 15:58:11 +0000 (16:58 +0100)] 
NEWS: update contributors list

18 months agocgroup-util: allow cg_read_pid() to skip unmapped (zero) pids
Timo Rothenpieler [Sun, 28 Apr 2024 14:27:06 +0000 (16:27 +0200)] 
cgroup-util: allow cg_read_pid() to skip unmapped (zero) pids

18 months agotest: Only add tpm2.target dependency to TEST-70-TPM2.service
Daan De Meyer [Tue, 14 May 2024 13:35:59 +0000 (15:35 +0200)] 
test: Only add tpm2.target dependency to TEST-70-TPM2.service

Let's not add the dependency unless required.

18 months agolibsystemd-network: skip dhcp server test in case of EAFNOSUPPORT
Radoslav Kolev [Tue, 14 May 2024 07:25:49 +0000 (10:25 +0300)] 
libsystemd-network: skip dhcp server test in case of EAFNOSUPPORT

We want to eanble running tests as part of the build, but
our builds run in VMs with networking disabled.

18 months agoMerge pull request #32804 from YHNdnzj/bootspec-modernization
Mike Yuan [Tue, 14 May 2024 12:55:52 +0000 (20:55 +0800)] 
Merge pull request #32804 from YHNdnzj/bootspec-modernization

shared/bootspec: some fixes/modernizations

18 months agoMerge pull request #32766 from DaanDeMeyer/test
Daan De Meyer [Tue, 14 May 2024 12:45:35 +0000 (14:45 +0200)] 
Merge pull request #32766 from DaanDeMeyer/test

Various test improvements

18 months agotest: Run TEST-64-UDEV-STORAGE with mkosi 32766/head
Daan De Meyer [Sun, 12 May 2024 19:27:58 +0000 (21:27 +0200)] 
test: Run TEST-64-UDEV-STORAGE with mkosi

We add a configure script for each subtest to add the required
qemu arguments.

Co-authored-by: Richard Maw <richard.maw@codethink.co.uk>
18 months agomkosi: Mask mdmonitor and isc-dhcp-server services
Daan De Meyer [Tue, 14 May 2024 07:11:51 +0000 (09:11 +0200)] 
mkosi: Mask mdmonitor and isc-dhcp-server services

They always fail and do not ship with proper units so we can't
disable them with presets so we mask them instead.

18 months agoTEST-64-UDEV-STORAGE: Skip LVM subtests on Ubuntu
Daan De Meyer [Mon, 13 May 2024 17:08:42 +0000 (19:08 +0200)] 
TEST-64-UDEV-STORAGE: Skip LVM subtests on Ubuntu

These fail for unknown reasons on Ubuntu. Until someone from Ubuntu
who cares can figure out why, let's skip these tests on Ubuntu.

18 months agoTEST-64-UDEV-STORAGE: Bump timeout for testcase_simultaneous_events_1
Daan De Meyer [Mon, 13 May 2024 15:00:11 +0000 (17:00 +0200)] 
TEST-64-UDEV-STORAGE: Bump timeout for testcase_simultaneous_events_1

The timeout is reliably hit when running tests in mkosi.

18 months agoTEST-64-UDEV-STORAGE: Skip btrfs_basic if btrfs module is not available
Daan De Meyer [Mon, 13 May 2024 14:58:23 +0000 (16:58 +0200)] 
TEST-64-UDEV-STORAGE: Skip btrfs_basic if btrfs module is not available

18 months agoTEST-64-UDEV-STORAGE: Check for tgt and tgtd services
Daan De Meyer [Mon, 13 May 2024 13:08:07 +0000 (15:08 +0200)] 
TEST-64-UDEV-STORAGE: Check for tgt and tgtd services

On Debian/Ubuntu, the unit is named tgt.service instead of tgtd.service,
so let's make sure we take that into account.

On CentOS, tgtd.service is not available, so let's skip the test if we
can't find the service.

18 months agoTEST-64-UDEV-STORAGE: Add missing udevadm settle
Daan De Meyer [Mon, 13 May 2024 13:06:50 +0000 (15:06 +0200)] 
TEST-64-UDEV-STORAGE: Add missing udevadm settle

Otherwise we try to do the check before the udev queue is empty which
will make it fail.

18 months agoTEST-64-UDEV-STORAGE: Use virtio-scsi-pci instead of ahci
Daan De Meyer [Mon, 13 May 2024 13:04:16 +0000 (15:04 +0200)] 
TEST-64-UDEV-STORAGE: Use virtio-scsi-pci instead of ahci

The debian cloud kernel does not support ahci, so let's use
virtio-scsi-pci everywhere instead.

18 months agoTEST-64-UDEV-STORAGE: Use ID based paths
Daan De Meyer [Sun, 12 May 2024 19:26:41 +0000 (21:26 +0200)] 
TEST-64-UDEV-STORAGE: Use ID based paths

18 months agotest: Ignore configure scripts in minimal images
Daan De Meyer [Sun, 12 May 2024 13:16:37 +0000 (15:16 +0200)] 
test: Ignore configure scripts in minimal images

These are always aimed at the system image so ignore any specified
configure scripts in the minimal images.

18 months agotest: Add cmdline field to configure extra kernel command line args
Daan De Meyer [Sun, 12 May 2024 09:13:58 +0000 (11:13 +0200)] 
test: Add cmdline field to configure extra kernel command line args

Configuring extra cmdline arguments as a list is much nicer than
having to pass the --kernel-command-line-extra argument manually.

18 months agotest: Generate basic testsuite services with meson
Daan De Meyer [Sun, 12 May 2024 08:50:47 +0000 (10:50 +0200)] 
test: Generate basic testsuite services with meson

Most of these are identical, let's just generate from a meson
template.

18 months agoTEST-46-HOMED: Simplify service unit
Daan De Meyer [Tue, 14 May 2024 07:20:21 +0000 (09:20 +0200)] 
TEST-46-HOMED: Simplify service unit

Let's remove the unneeded NotifyAccess=all and start the socket
and service in the test itself instead of via the service unit. This
makes the test unit identical to the other test units which will allow
us to autogenerate it in a later commit.

18 months agoTEST-06-SELINUX: Simplify auto-relabeling
Daan De Meyer [Mon, 13 May 2024 10:36:40 +0000 (12:36 +0200)] 
TEST-06-SELINUX: Simplify auto-relabeling

Let's ship a .autorelabel file so we can get rid of
firstboot-autorelabel.service.

18 months agotest: Rename mkosi_args to mkosi-args
Daan De Meyer [Sun, 12 May 2024 20:01:19 +0000 (22:01 +0200)] 
test: Rename mkosi_args to mkosi-args

18 months agotest: Disable tests via 'enabled' field
Daan De Meyer [Sat, 11 May 2024 18:22:10 +0000 (20:22 +0200)] 
test: Disable tests via 'enabled' field

This allows doing other stuff with the test without actually defining
the test, such as generating a service unit automatically.

18 months agotest: Simplify argument/variable names
Daan De Meyer [Sat, 11 May 2024 17:40:03 +0000 (19:40 +0200)] 
test: Simplify argument/variable names

18 months agotest: Rename testsuite-XX units to match test name
Daan De Meyer [Sat, 11 May 2024 17:17:13 +0000 (19:17 +0200)] 
test: Rename testsuite-XX units to match test name

Having these named differently than the test itself mostly creates
unecessary confusion and makes writing logic against the tests harder
so let's rename the testsuite-xx units and scripts to just use the
test name itself.

18 months agotest: Rework integration test definitions
Daan De Meyer [Sat, 11 May 2024 13:55:54 +0000 (15:55 +0200)] 
test: Rework integration test definitions

Let's make this behave more like all the rest of the meson stuff.
This also is the first step to making it a bit more flexible so we
can define integration tests in different ways as will be seen in
the next commits.

18 months agoTEST-01-BASIC: Drop logic to run test without install-tests=true
Daan De Meyer [Mon, 13 May 2024 09:26:58 +0000 (11:26 +0200)] 
TEST-01-BASIC: Drop logic to run test without install-tests=true

We don't support this for any other tests either so let's drop the
support for running TEST-01-BASIC without installing as well to make
the upcoming commit easier to implement.

18 months agomkosi: Update to latest
Daan De Meyer [Sun, 12 May 2024 21:06:07 +0000 (23:06 +0200)] 
mkosi: Update to latest