]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
16 months agobootctl: add comments to Varlink interface 33407/head
Lennart Poettering [Wed, 19 Jun 2024 11:54:47 +0000 (13:54 +0200)] 
bootctl: add comments to Varlink interface

This is mostly intended as test case for the early enum comment bugfix,
as this Varlink IDL description now contains such comments, and
test-varlink-idl will process it forth and back aleady.

16 months agobootctl: normalize how we report no boot entries found
Lennart Poettering [Wed, 19 Jun 2024 11:54:35 +0000 (13:54 +0200)] 
bootctl: normalize how we report no boot entries found

This normalizes how we report an empty list of boot entries in
ListBootEntries(). Our usual pattern is to return one item per method
call, but when there is none we usually return a NoSuchXYZ error. Do so
here too.

Before this we'd return a null item instead here, and only here.

This is a minor compat break, but given that this IPC interface is very
new and probably not used so far (we don't use it in our code at least,
and google doesn#t find any other use) I think this normalization is OK
at this point.

16 months agovarlink: correctly format comments for enums too
Lennart Poettering [Wed, 19 Jun 2024 08:46:27 +0000 (10:46 +0200)] 
varlink: correctly format comments for enums too

I apparently never tested comments on enum values and hence they didn#t
work. Fix that.

16 months agobootctl: add --random-seed=yes/no
Ludwig Nussel [Wed, 17 Apr 2024 09:30:03 +0000 (11:30 +0200)] 
bootctl: add --random-seed=yes/no

16 months agoMerge pull request #33420 from poettering/build-with-object
Yu Watanabe [Thu, 20 Jun 2024 04:04:32 +0000 (13:04 +0900)] 
Merge pull request #33420 from poettering/build-with-object

sd-json: add sd_json_build() flavour that implies we are building an object

16 months agoman: fix typo in systemd-tmpfiles
Diego Viola [Thu, 20 Jun 2024 00:15:38 +0000 (21:15 -0300)] 
man: fix typo in systemd-tmpfiles

Signed-off-by: Diego Viola <diego.viola@gmail.com>
16 months agoMerge pull request #33419 from YHNdnzj/install-report-symlink
Yu Watanabe [Thu, 20 Jun 2024 04:00:44 +0000 (13:00 +0900)] 
Merge pull request #33419 from YHNdnzj/install-report-symlink

shared/install: several fixes for change reporting

16 months agocore/namespace: ensure private tmpfs is mounted earlier
Yu Watanabe [Wed, 19 Jun 2024 16:33:51 +0000 (01:33 +0900)] 
core/namespace: ensure private tmpfs is mounted earlier

And drop spurious assertion.

Fortunately, the previous logic worked, as /run/systemd/unit-private-tmp
is ordered earlier than /tmp or /var/tmp. But, let's ensure the tmpfs
mounted earlier to make the logic clearer.

Follow-up for 0e551b04efb911d38b586cca1a6a462c87a2cb1b.

16 months agoMerge pull request #33410 from poettering/sd-json-log-level-clean-up
Yu Watanabe [Thu, 20 Jun 2024 03:59:06 +0000 (12:59 +0900)] 
Merge pull request #33410 from poettering/sd-json-log-level-clean-up

sd-json: clean up SD_JSON_WARNING/SD_JSON_DEBUG definition and comments

16 months agoupdate TODO 33420/head
Lennart Poettering [Wed, 19 Jun 2024 14:55:13 +0000 (16:55 +0200)] 
update TODO

16 months agotree-wide: port over to new builder apis
Lennart Poettering [Tue, 18 Jun 2024 15:08:49 +0000 (17:08 +0200)] 
tree-wide: port over to new builder apis

16 months agosd-json: add sd_json_build() wrapper macro that implies SD_JSON_BUILD_OBJECT()
Lennart Poettering [Tue, 18 Jun 2024 10:21:31 +0000 (12:21 +0200)] 
sd-json: add sd_json_build() wrapper macro that implies SD_JSON_BUILD_OBJECT()

In 99% of uses of sd_json_build() we want to build an object as
outermost construct. Let's shorten this most common case a bit, by
adding sd_json_buildo() that implies this. This allows us to shorten
much of our code, all across the tree.

16 months agoupdate TODO 33410/head
Lennart Poettering [Tue, 18 Jun 2024 09:46:41 +0000 (11:46 +0200)] 
update TODO

16 months agosd-json: add comment clarifying that _SD_JSON_BUILD* enums are not to be used directly
Lennart Poettering [Tue, 18 Jun 2024 09:47:06 +0000 (11:47 +0200)] 
sd-json: add comment clarifying that _SD_JSON_BUILD* enums are not to be used directly

16 months agosd-json.h: reword SD_JSON_WARNING/SD_JSON_DEBUG comments
Lennart Poettering [Tue, 18 Jun 2024 09:43:58 +0000 (11:43 +0200)] 
sd-json.h: reword SD_JSON_WARNING/SD_JSON_DEBUG comments

Even though we don't export json_log() in the public API, let's
officially make the SD_JSON_WARNING/SD_JSON_DEBUG that control its
effect in the public API.

After all, for our own dispatcher functions they have a nice effect, and
they are trivially reimplemented in user code independently.

(We might eventually consider exporting json_log() as public API, but
this is quite involved, given its use of macros/inline functions and
iternal logging API).

This mostly just swaps around the bit flags and cleans up comments.

16 months agotest-install-root: introduce test case for #33411 33419/head
Mike Yuan [Wed, 19 Jun 2024 19:28:05 +0000 (21:28 +0200)] 
test-install-root: introduce test case for #33411

16 months agoshared/install: correctly report changes in install_info_symlink_alias()
Mike Yuan [Wed, 19 Jun 2024 16:45:14 +0000 (18:45 +0200)] 
shared/install: correctly report changes in install_info_symlink_alias()

Follow-up for b2751cf0394d36c24590b5f7b33e9f864b57ba0d

Also make the conditions consistent for install_info_symlink_wants().

Fixes #33411

16 months agoshared/install: propagate all errors in install_info_apply()
Mike Yuan [Wed, 19 Jun 2024 16:59:15 +0000 (18:59 +0200)] 
shared/install: propagate all errors in install_info_apply()

Currently, install_info_apply() only updates r if it's 0,
meaning that if one of the earlier install_info_symlink_alias/wants()
calls returns > 0, errors generated by later calls will be discarded.
Fix that.

16 months agoshared/install: drop unneeded initialization
Mike Yuan [Wed, 19 Jun 2024 16:44:26 +0000 (18:44 +0200)] 
shared/install: drop unneeded initialization

16 months agoMerge pull request #33034 from yuwata/update-kernel-headers
Yu Watanabe [Wed, 19 Jun 2024 18:53:16 +0000 (03:53 +0900)] 
Merge pull request #33034 from yuwata/update-kernel-headers

basic/linux: update kernel headers from v6.10-rc3

16 months agokernel-install: correct the place where it works in man and help text
Antonio Alvarez Feijoo [Wed, 19 Jun 2024 12:41:55 +0000 (14:41 +0200)] 
kernel-install: correct the place where it works in man and help text

16 months agoman/systemd.exec: list inaccessible files for ProtectKernelTunables
Maximilian Wilhelm [Wed, 19 Jun 2024 11:41:39 +0000 (13:41 +0200)] 
man/systemd.exec: list inaccessible files for ProtectKernelTunables

16 months agovmspawn: define QEMU_MACHINE_TYPE for riscv
Xeonacid [Wed, 19 Jun 2024 09:56:57 +0000 (17:56 +0800)] 
vmspawn: define QEMU_MACHINE_TYPE for riscv

Use ["virt"](https://www.qemu.org/docs/master/system/target-riscv.html#board-specific-documentation) as a commonly used generic platform on riscv.

16 months agoMerge pull request #32868 from keszybz/more-whomification
Yu Watanabe [Wed, 19 Jun 2024 17:59:14 +0000 (02:59 +0900)] 
Merge pull request #32868 from keszybz/more-whomification

Fix confusion between killer and prey

16 months agocore: drop unnecessary auto_fs4.h inclusion 33034/head
Yu Watanabe [Tue, 28 May 2024 02:21:35 +0000 (11:21 +0900)] 
core: drop unnecessary auto_fs4.h inclusion

auto_fs4.h is a trivial wrapper of auto_fs.h, and it is already included
by auto_dev-ioctl.h.

16 months agomissing: drop BCACHEFS_SUPER_MAGIC as it is now defined in linux/magic.h
Yu Watanabe [Fri, 31 May 2024 02:28:15 +0000 (11:28 +0900)] 
missing: drop BCACHEFS_SUPER_MAGIC as it is now defined in linux/magic.h

16 months agobasic/linux: update kernel headers from v6.10-rc3
Yu Watanabe [Tue, 28 May 2024 02:04:47 +0000 (11:04 +0900)] 
basic/linux: update kernel headers from v6.10-rc3

This also
- merges basic/linux and shared/linux,
- moves BPF_JUMP_A() to basic/missing_bpf.h,
- copies from usrspace kernel headers directory generated by 'make headers',
  rather than copying from kernel tree,
- copies const.h into our tree to reduce change in ethtool.h,
- copies auto_fs.h into our tree to reduce change in auto_dev-ioctl.h.

16 months agoupdate TODO
Lennart Poettering [Wed, 19 Jun 2024 14:53:48 +0000 (16:53 +0200)] 
update TODO

16 months agovarious: move ptr indicator to return value 32868/head
Zbigniew Jędrzejewski-Szmek [Fri, 17 May 2024 06:54:00 +0000 (08:54 +0200)] 
various: move ptr indicator to return value

16 months agovarious: move const ptr indicator to return value
Zbigniew Jędrzejewski-Szmek [Fri, 17 May 2024 06:54:00 +0000 (08:54 +0200)] 
various: move const ptr indicator to return value

16 months agoFix confusion between killer and prey
Zbigniew Jędrzejewski-Szmek [Thu, 16 May 2024 14:45:04 +0000 (16:45 +0200)] 
Fix confusion between killer and prey

"who" is the entity doing the killing, "whom" is the target.
Follow-up for 4ccde410a3fc141c9ddf285f24a22dfea99e0287.

16 months agovarlink-idl: allow unbalanced quote and trailing backslash in comment
Yu Watanabe [Wed, 19 Jun 2024 06:17:26 +0000 (15:17 +0900)] 
varlink-idl: allow unbalanced quote and trailing backslash in comment

Fixes #33381.
Fixes OSS-FUZZ#69730.
Follow-up for fbb69c0306d434153ca85b227c7d42b9c92872e4.

16 months agoudev-spawn: fix typo and simplify code
Antonio Alvarez Feijoo [Mon, 27 May 2024 15:17:52 +0000 (17:17 +0200)] 
udev-spawn: fix typo and simplify code

Follow-up for 11706971e8b6aa289af56454330fffd87f5d5a78

16 months agoUse consistent spelling of systemd.condition_first_boot argument
pyfisch [Tue, 18 Jun 2024 20:22:15 +0000 (22:22 +0200)] 
Use consistent spelling of systemd.condition_first_boot argument

16 months agoman/systemd.journal-fields: document _SOURCE_{MONOTONIC,BOOTTIME}_TIMESTAMP
Mike Yuan [Tue, 18 Jun 2024 16:37:44 +0000 (18:37 +0200)] 
man/systemd.journal-fields: document _SOURCE_{MONOTONIC,BOOTTIME}_TIMESTAMP

Follow-up for a9357c2ce2d188b5b63592fd271f14d335867c23

16 months agoMerge pull request #33391 from YHNdnzj/runtime-dir-cleanup
Yu Watanabe [Wed, 19 Jun 2024 05:44:01 +0000 (14:44 +0900)] 
Merge pull request #33391 from YHNdnzj/runtime-dir-cleanup

login/user-runtime-dir: free ignored sd_bus_error, avoid triggering assertion

16 months agologin/user-runtime-dir: free ignored sd_bus_error, avoid triggering assertion 33391/head
Mike Yuan [Tue, 18 Jun 2024 14:32:14 +0000 (16:32 +0200)] 
login/user-runtime-dir: free ignored sd_bus_error, avoid triggering assertion

Fixes #33388

16 months agologin/user-runtime-dir: use STRLEN where appropriate
Mike Yuan [Tue, 18 Jun 2024 14:31:12 +0000 (16:31 +0200)] 
login/user-runtime-dir: use STRLEN where appropriate

Also, add missing trailing / to paths used in STRLEN/sizeof.

16 months agostrv: replace always-true condition with assertion
Yu Watanabe [Tue, 18 Jun 2024 09:12:39 +0000 (18:12 +0900)] 
strv: replace always-true condition with assertion

Follow-up for aca093018c5d2cd8a63129cab67941fe1b8fd850.
Fixes CID#1547105.

16 months agoMerge pull request #33386 from yuwata/journal-timestamp 33380/head
Luca Boccassi [Tue, 18 Jun 2024 15:27:36 +0000 (16:27 +0100)] 
Merge pull request #33386 from yuwata/journal-timestamp

journal: fix _SOURCE_MONOTONIC_TIMESTAMP field

16 months agorepart: fix memory leak
Antonio Alvarez Feijoo [Tue, 18 Jun 2024 12:07:50 +0000 (14:07 +0200)] 
repart: fix memory leak

16 months agomkosi: restrict noble-backports to noble builds
Luca Boccassi [Tue, 18 Jun 2024 12:35:32 +0000 (13:35 +0100)] 
mkosi: restrict noble-backports to noble builds

Follow-up for c01cb8cbff8512b65b7903b55f78c8d12661b8d7

16 months agoMerge pull request #33383 from poettering/tmpfiles-limit-purge
Luca Boccassi [Tue, 18 Jun 2024 14:44:32 +0000 (15:44 +0100)] 
Merge pull request #33383 from poettering/tmpfiles-limit-purge

tmpfiles: make --purge more restrictive, and various other tweaks

16 months agoinstall: allow removing symlinks even for units that are gone
Luca Boccassi [Fri, 7 Jun 2024 20:39:45 +0000 (21:39 +0100)] 
install: allow removing symlinks even for units that are gone

If a symlink is leftover, still allow cleaning it up via 'disable'. This
happens when a unit is stopped and removed, but not disabled, and a reload
has already happened. At that point, cleaning up the old symlinks becomes
impossible through the APIs, and needs to be done manually. Always allow
cleaning up symlinks, if they exist, by only erroring out if there is an
OOM.

Follow-up for f31f10a6207efc9ae9e0b1f73975b5b610914017

16 months agoman: suffix tmpfiles.d with /, as per coding style 33383/head
Lennart Poettering [Tue, 18 Jun 2024 08:27:06 +0000 (10:27 +0200)] 
man: suffix tmpfiles.d with /, as per coding style

16 months agotmpfiles: mention that --create also adjusts files/directories in --help text
Lennart Poettering [Tue, 18 Jun 2024 08:00:16 +0000 (10:00 +0200)] 
tmpfiles: mention that --create also adjusts files/directories in --help text

16 months agotmpfiles: suffix --replace= properly with = in comment
Lennart Poettering [Tue, 18 Jun 2024 07:56:49 +0000 (09:56 +0200)] 
tmpfiles: suffix --replace= properly with = in comment

16 months agotmpfiles: make --tldr help text symmetric to --cat-config
Lennart Poettering [Tue, 18 Jun 2024 07:56:36 +0000 (09:56 +0200)] 
tmpfiles: make --tldr help text symmetric to --cat-config

16 months agotmpfiles: improve debug logging around O_NOATIME fallback
Lennart Poettering [Tue, 18 Jun 2024 07:55:48 +0000 (09:55 +0200)] 
tmpfiles: improve debug logging around O_NOATIME fallback

16 months agotmpfiles: remove pointless empty line
Lennart Poettering [Tue, 18 Jun 2024 07:55:32 +0000 (09:55 +0200)] 
tmpfiles: remove pointless empty line

16 months agotmpfiles: move --purge to command section in --help text where it belongs
Lennart Poettering [Tue, 18 Jun 2024 07:56:15 +0000 (09:56 +0200)] 
tmpfiles: move --purge to command section in --help text where it belongs

Also, make contrast between --remove and --purge clearer: one deletes
files marked for deletion, the other deletes files marked for creation.

16 months agotmpfiles: insist on at least one configuration file being specified on --purge
Lennart Poettering [Tue, 18 Jun 2024 07:55:20 +0000 (09:55 +0200)] 
tmpfiles: insist on at least one configuration file being specified on --purge

Also, extend the man page explanation substantially, matching more
closely what --create says.

Fixes: #33349
16 months agoAdd OrangePi NEO Scancodes
Derek J. Clark [Mon, 17 Jun 2024 18:49:30 +0000 (11:49 -0700)] 
Add OrangePi NEO Scancodes

Adds scancodes for the OrangePi NEO Handheld Gaming computer. This
device ships with an AT Translated Set 2 Keyboard device that
provides two buttons, ~~LC (Top Left) and RC (Top Right)~~
Home (front, bottom left) and Gamepad (front, bottom right). The
scancodes do not properly map in Linux. This change maps these
scancodes to ensure the hardware behaves as the OEM expects.

16 months agoNEWS: fix typo
Carlo Teubner [Tue, 18 Jun 2024 08:41:59 +0000 (09:41 +0100)] 
NEWS: fix typo

16 months agologs-show: use _SOURCE_MONOTONIC_TIMESTAMP when _SOURCE_BOOTTIME_TIMESTAMP field... 33386/head
Yu Watanabe [Tue, 18 Jun 2024 09:00:33 +0000 (18:00 +0900)] 
logs-show: use _SOURCE_MONOTONIC_TIMESTAMP when _SOURCE_BOOTTIME_TIMESTAMP field exists

With the previous commit, now the _SOURCE_MONOTONIC_TIMESTAMP field is
usable but only when _SOURCE_BOOTTIME_TIMESTAMP exists.

16 months agojournal: introduce _SOURCE_BOOTTIME_TIMESTAMP field
Yu Watanabe [Tue, 18 Jun 2024 08:36:51 +0000 (17:36 +0900)] 
journal: introduce _SOURCE_BOOTTIME_TIMESTAMP field

Then, fix the monotonic timestamp.

The _SOURCE_MONOTONIC_TIMESTAMP field is already used in other projects.
Hence, we cannot remove the field. But, let's store the correct value.
The existence of the new _SOURCE_BOOTTIME_TIMESTAMP field can indicate
that the monotonic timestamp field is reliable or not.

16 months agosd-journal: realign flags
Yu Watanabe [Tue, 18 Jun 2024 08:24:47 +0000 (17:24 +0900)] 
sd-journal: realign flags

16 months agologs-show: do not use _SOURCE_MONOTONIC_TIMESTAMP field
Yu Watanabe [Tue, 18 Jun 2024 08:55:31 +0000 (17:55 +0900)] 
logs-show: do not use _SOURCE_MONOTONIC_TIMESTAMP field

The timestamp is not in CLOCK_MONOTONIC, but CLOCK_BOOTTIME,
while header monotonic timestamp is in CLOCK_MONOTONIC. Hence, we cannot
adjust timestamp by comparing with header monotonic timestamp and
_SOURCE_MONOTONIC_TIMESTAMP field.

Fixes a regression caused by affde1d7e79a634ee6053dbd4a57b3b51b74c170.
Fixes #33293.

16 months agotmpfiles: honour --dry-run when removing directories
Lennart Poettering [Tue, 18 Jun 2024 07:54:33 +0000 (09:54 +0200)] 
tmpfiles: honour --dry-run when removing directories

16 months agotmpfiles: sort needs_purge line list in same order as enum defines them
Lennart Poettering [Tue, 18 Jun 2024 08:15:02 +0000 (10:15 +0200)] 
tmpfiles: sort needs_purge line list in same order as enum defines them

16 months agoupdate TODO
Lennart Poettering [Tue, 18 Jun 2024 07:27:57 +0000 (09:27 +0200)] 
update TODO

16 months agohwdb: add scancodes for AYANEO devices (#33378)
Derek J. Clark [Tue, 18 Jun 2024 00:19:30 +0000 (17:19 -0700)] 
hwdb: add scancodes for AYANEO devices (#33378)

AYANEO has multiple models that all use the same AT Translated Set
2 Keyboard device with 3-4 buttons available. Starting with the
AYANEO 2 there was a change to the IMU programming they were using
that caused the scancodes to no longer present the correct values
in Linux. This change adds a blanket scancode mapping to present
the correct keycodes as designed by the OEM.

In some cases a kernel bug will cause the AT Translated Set 2
Keyboard to present as an AT Raw Set 2 keyboard. I have also
adjusted the scancodes for this scenario as well so they are
in line with expected behavior. Currently only the Kun is still
experiencing this bug.

Example userspace tool refs:
https://github.com/ShadowBlip/InputPlumber/blob/main/rootfs/usr/lib/udev/hwdb.d/59-inputplumber.hwdb
https://github.com/ShadowBlip/HandyGCCS/blob/main/usr/lib/udev/hwdb.d/59-handygccs-ayaneo.hwdb
https://github.com/hhd-dev/hhd/tree/master/usr/lib/udev/hwdb.d

16 months agovarlink-idl: fix typo
Yu Watanabe [Tue, 18 Jun 2024 00:11:48 +0000 (09:11 +0900)] 
varlink-idl: fix typo

Follow-ups for fbb69c0306d434153ca85b227c7d42b9c92872e4.

16 months agocatalog: fix typo
Yu Watanabe [Tue, 18 Jun 2024 00:09:26 +0000 (09:09 +0900)] 
catalog: fix typo

Follow-up for d6518003f8ebbfb6f85dbf227736ae05b0961199.

16 months agoMerge pull request #33376 from yuwata/strv_sort_uniq
Luca Boccassi [Mon, 17 Jun 2024 23:22:19 +0000 (00:22 +0100)] 
Merge pull request #33376 from yuwata/strv_sort_uniq

strv: introduce strv_sort_uniq()

16 months agoMerge pull request #33359 from bluca/test_apparmor_unpriv
Luca Boccassi [Mon, 17 Jun 2024 23:13:15 +0000 (00:13 +0100)] 
Merge pull request #33359 from bluca/test_apparmor_unpriv

mkosi: enable unprivileged user ns for integration tests

16 months agoMerge pull request #32724 from bluca/dynamic_user_no_private_tmp
Luca Boccassi [Mon, 17 Jun 2024 23:11:11 +0000 (00:11 +0100)] 
Merge pull request #32724 from bluca/dynamic_user_no_private_tmp

core: do not imply PrivateTmp with DynamicUser, create a private tmpfs instead

16 months agoMerge pull request #33377 from yuwata/strbuf-cleanups
Luca Boccassi [Mon, 17 Jun 2024 19:08:22 +0000 (20:08 +0100)] 
Merge pull request #33377 from yuwata/strbuf-cleanups

strbuf: several cleanups

16 months agoMerge pull request #33375 from yuwata/trivial-follow-ups
Luca Boccassi [Mon, 17 Jun 2024 19:06:46 +0000 (20:06 +0100)] 
Merge pull request #33375 from yuwata/trivial-follow-ups

Trivial follow ups for recent PRs

16 months agoMerge pull request #33374 from YHNdnzj/coverity-fixes-1
Luca Boccassi [Mon, 17 Jun 2024 19:05:58 +0000 (20:05 +0100)] 
Merge pull request #33374 from YHNdnzj/coverity-fixes-1

core: a few more fixes for serialization

16 months agoMerge pull request #32559 from poettering/varlink-comments
Luca Boccassi [Mon, 17 Jun 2024 17:53:11 +0000 (18:53 +0100)] 
Merge pull request #32559 from poettering/varlink-comments

varlink: add nice commenting to our varlink IDL data

16 months agoMerge pull request #32872 from YHNdnzj/pidref-inode
Mike Yuan [Mon, 17 Jun 2024 16:47:44 +0000 (18:47 +0200)] 
Merge pull request #32872 from YHNdnzj/pidref-inode

pidref: record pidfd inode number in PidRef struct

16 months agomkosi: bump to latest 33359/head
Luca Boccassi [Mon, 17 Jun 2024 14:40:10 +0000 (15:40 +0100)] 
mkosi: bump to latest

16 months agoCI: disable secure boot in mkosi GHA runs
Luca Boccassi [Mon, 17 Jun 2024 16:40:28 +0000 (17:40 +0100)] 
CI: disable secure boot in mkosi GHA runs

Booting a guest with secure boot is broken in Azure due to a hypervisor
bug. Disable it for now. Given there's no option, need to edit
the configuration on the fly.

16 months agoportable: drop explicit PrivateTmp=yes from profiles 32724/head
Luca Boccassi [Wed, 8 May 2024 19:16:05 +0000 (20:16 +0100)] 
portable: drop explicit PrivateTmp=yes from profiles

It is already implied by DynamicUser=yes if not set, but dropping it
allows users to instead define TemporaryFileSystem=/tmp/ /var/tmp/
in their portable services, which has fewer side effects.

16 months agocore: do not imply PrivateTmp with DynamicUser, create a private tmpfs instead
Luca Boccassi [Wed, 8 May 2024 19:12:57 +0000 (20:12 +0100)] 
core: do not imply PrivateTmp with DynamicUser, create a private tmpfs instead

DynamicUser= enables PrivateTmp= implicitly to avoid files owned by reusable uids
leaking into the host. Change it to instead create a fully private tmpfs instance
instead, which also ensures the same result, since it has less impactful semantics
with respect to PrivateTmp=yes, which links the mount namespace to the host's /tmp
instead. If a user specifies PrivateTmp manually, let the existing behaviour
unchanged to ensure backward compatibility is not broken.

16 months agotree-wide: replace strv_sort() + strv_uniq() -> strv_sort_uniq() 33376/head
Yu Watanabe [Mon, 17 Jun 2024 15:06:59 +0000 (00:06 +0900)] 
tree-wide: replace strv_sort() + strv_uniq() -> strv_sort_uniq()

16 months agostrbuf: use _cleanup_ attribute at one more place 33377/head
Yu Watanabe [Wed, 12 Jun 2024 15:24:38 +0000 (00:24 +0900)] 
strbuf: use _cleanup_ attribute at one more place

16 months agostrbuf: several cleanups
Yu Watanabe [Wed, 12 Jun 2024 15:20:26 +0000 (00:20 +0900)] 
strbuf: several cleanups

- use FOREACH_ARRAY(),
- add one missing assertion,
- reduce indentation.

16 months agostrbuf: use CMP() macro
Yu Watanabe [Wed, 12 Jun 2024 15:17:20 +0000 (00:17 +0900)] 
strbuf: use CMP() macro

strbuf_child_entry.c is uint8_t, so using CMP() is safer.

This also adds missing assertions.

16 months agostrv: introduce strv_sort_uniq()
Yu Watanabe [Mon, 17 Jun 2024 14:52:14 +0000 (23:52 +0900)] 
strv: introduce strv_sort_uniq()

We often call strv_sort() and strv_uniq(). If a strv is already sorted.
uniquifying can be faster.

Prompted by https://github.com/systemd/systemd/pull/33012#discussion_r1636633627.

16 months agotest-network: mention that the captive portal option is supported since v2.20 33375/head
Yu Watanabe [Mon, 17 Jun 2024 15:09:03 +0000 (00:09 +0900)] 
test-network: mention that the captive portal option is supported since v2.20

The current latest release is v2.19, hence the test is typically skipped now.

16 months agojson: const char *func() -> const char* func()
Yu Watanabe [Mon, 17 Jun 2024 14:10:18 +0000 (23:10 +0900)] 
json: const char *func() -> const char* func()

Follow-up for 309a747fa6cfeac0a0165543f23a924866727c9b.

16 months agocore/mount: suffix function name with paren
Yu Watanabe [Mon, 17 Jun 2024 14:08:36 +0000 (23:08 +0900)] 
core/mount: suffix function name with paren

Follow-up for 88188e1ff1ffa2a4a41c9b8ee127f75cc03bc18d.

16 months agologind: tweaklets
Lennart Poettering [Mon, 27 May 2024 12:33:22 +0000 (14:33 +0200)] 
logind: tweaklets

16 months agopretty-print: take console glyph width into account when drawing progress bar
Lennart Poettering [Fri, 24 May 2024 11:56:10 +0000 (13:56 +0200)] 
pretty-print: take console glyph width into account when drawing progress bar

So far this used string length, not character width. Fix that.

16 months agocore/service: fix accept-socket deserialization 33374/head
Mike Yuan [Mon, 17 Jun 2024 05:47:20 +0000 (07:47 +0200)] 
core/service: fix accept-socket deserialization

Follow-up for 45b1017488cef2a5bacdf82028ce900a311c9a1c

16 months agocore: cast ignored retval of deserialize_* to void
Mike Yuan [Mon, 17 Jun 2024 05:21:43 +0000 (07:21 +0200)] 
core: cast ignored retval of deserialize_* to void

Fixes CID#1547098

16 months agocore/socket: use FOREACH_ARRAY at one more place
Mike Yuan [Mon, 17 Jun 2024 14:39:59 +0000 (16:39 +0200)] 
core/socket: use FOREACH_ARRAY at one more place

16 months agotest: use 'auto' instead of 'uefi' for automated fallback
Luca Boccassi [Mon, 17 Jun 2024 14:37:43 +0000 (15:37 +0100)] 
test: use 'auto' instead of 'uefi' for automated fallback

mkosi will prefer UEFI if the architecture supports it, but fallback
to 'linux' if it doesn't.

16 months agotest: support TEST_NO_QEMU in mkosi integration wrapper
Luca Boccassi [Mon, 17 Jun 2024 13:09:40 +0000 (14:09 +0100)] 
test: support TEST_NO_QEMU in mkosi integration wrapper

Same as the old integration test suite, allow skipping tests that
require qemu.
ppc64el's vsock support doesn't appear to work, so we'll skip it,
as it is already done in the legacy framework.

16 months agotest: support TEST_NO_KVM
Luca Boccassi [Sun, 16 Jun 2024 18:15:24 +0000 (19:15 +0100)] 
test: support TEST_NO_KVM

The shell integration suite allows to manually deselect KVM, so
suppor the same env var for the same purpose in python.

16 months agotest: drop obsolete comment
Luca Boccassi [Sun, 16 Jun 2024 18:21:32 +0000 (19:21 +0100)] 
test: drop obsolete comment

We want to keep various logic here instead of mkosi, so drop the
temporary comment

16 months agohwdb: add support for AIPTEK Media Tablet Ultimate (#33371)
reDBo0n [Mon, 17 Jun 2024 14:05:23 +0000 (16:05 +0200)] 
hwdb: add support for AIPTEK Media Tablet Ultimate (#33371)

The "AIPTEK Media Tablet Ultimate", detected as "Waltop International Corp. Batteryless Tablet",
is missing the resolution of the x-/y-axes.

Adding a new rule to 60-evdev.hwdb with the same values as another entry
"WALTOP International Corp. Batteryless Tablet" just with another matching string makes the
device usable.

Fixes #33362.

16 months agotest: drop unneeded firmware: uefi setting
Luca Boccassi [Sun, 16 Jun 2024 15:08:57 +0000 (16:08 +0100)] 
test: drop unneeded firmware: uefi setting

These tests no longer need this, as they are running in nspawn, drop it

16 months agotest: check the skip condition before installing additional files
Luca Boccassi [Sun, 16 Jun 2024 12:41:50 +0000 (13:41 +0100)] 
test: check the skip condition before installing additional files

16 months agomkosi: install EFI packages only on EFI architectures
Luca Boccassi [Sun, 16 Jun 2024 19:42:12 +0000 (20:42 +0100)] 
mkosi: install EFI packages only on EFI architectures

sbsigntool, systemd-boot and systemd-boot-efi do not  exist on other
architectures

16 months agomkosi: use ports.ubuntu.com for non-x86 backports
Luca Boccassi [Sun, 16 Jun 2024 14:28:56 +0000 (15:28 +0100)] 
mkosi: use ports.ubuntu.com for non-x86 backports

Follow-up for 46368556afee7a1f3a1685609942438ef2d9d6c1

16 months agomkosi: enable unprivileged user ns for integration tests
Luca Boccassi [Sun, 16 Jun 2024 10:16:21 +0000 (11:16 +0100)] 
mkosi: enable unprivileged user ns for integration tests

Ubuntu disables them by default in Noble, ship a sysctl to turn them back on
so that tests can use them

16 months agoMerge pull request #33355 from YHNdnzj/shutdown-cad
Luca Boccassi [Mon, 17 Jun 2024 08:19:08 +0000 (09:19 +0100)] 
Merge pull request #33355 from YHNdnzj/shutdown-cad

shutdown: re-enable CAD handling in kernel at start, several other cleanups