]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
10 months agovmspawn: Switch to virtconsole for headless console 35836/head
Daan De Meyer [Fri, 3 Jan 2025 10:14:44 +0000 (11:14 +0100)] 
vmspawn: Switch to virtconsole for headless console

virtconsole is the modern way to set up a headless serial connection
to a virtual machine so let's make use of it instead of -serial. This
also allows us to get rid of the per architecture serial console device
names and makes vmspawn more consistent with mkosi qemu which already uses
virtconsole.

10 months agovmspawn: Use vmspawn in drive ID name instead of mkosi
Daan De Meyer [Fri, 3 Jan 2025 10:14:09 +0000 (11:14 +0100)] 
vmspawn: Use vmspawn in drive ID name instead of mkosi

10 months agohwdb: Add macro keys for HP 430 Programmable Wireless Keypad
Chris Mayo [Thu, 2 Jan 2025 19:22:10 +0000 (19:22 +0000)] 
hwdb: Add macro keys for HP 430 Programmable Wireless Keypad

10 months agorandom-util: our baseline includes getrandom() (v3.17) now (#35816)
Daan De Meyer [Fri, 3 Jan 2025 08:23:06 +0000 (09:23 +0100)] 
random-util: our baseline includes getrandom() (v3.17) now (#35816)

10 months agoresolved: stop mdns/lnrr when config changes to disabled on reload
Luca Boccassi [Thu, 2 Jan 2025 17:30:21 +0000 (17:30 +0000)] 
resolved: stop mdns/lnrr when config changes to disabled on reload

Currently on reload mdns/lnrr are enabled if they were disabled,
but not viceversa. Fix it.

Follow-up for 14a52176798bc2d013297b503ac6fa49a64e2725

10 months agoCorrect ACCEL_MOUNT_MATRIX for Chuwi Hi10 Max
Michael Limiero [Thu, 2 Jan 2025 15:41:28 +0000 (10:41 -0500)] 
Correct ACCEL_MOUNT_MATRIX for Chuwi Hi10 Max

10 months agoterminal-util: introduce terminal_{new,detach}_session helpers (#35811)
Daan De Meyer [Fri, 3 Jan 2025 08:21:19 +0000 (09:21 +0100)] 
terminal-util: introduce terminal_{new,detach}_session helpers (#35811)

10 months agonetwork/dhcp: introduce global setting for DHCPv4 client identifier (#35783)
Daan De Meyer [Fri, 3 Jan 2025 08:19:55 +0000 (09:19 +0100)] 
network/dhcp: introduce global setting for DHCPv4 client identifier (#35783)

Typically, the same client identifier setting is used for all
interfaces. Hence, better to provide the system-wide setting to specify
the client identifier.

10 months agoterminal-util: introduce terminal_{new,detach}_session helpers 35811/head
Mike Yuan [Thu, 2 Jan 2025 15:25:40 +0000 (16:25 +0100)] 
terminal-util: introduce terminal_{new,detach}_session helpers

Prompted by #35761

10 months agoterminal-util: regroup some functions
Mike Yuan [Thu, 2 Jan 2025 15:12:35 +0000 (16:12 +0100)] 
terminal-util: regroup some functions

10 months agorandom-util: our baseline includes getrandom() (v3.17) now 35816/head
Mike Yuan [Thu, 2 Jan 2025 19:03:33 +0000 (20:03 +0100)] 
random-util: our baseline includes getrandom() (v3.17) now

Plus, linux/random.h never defined getrandom(), hence remove
the custom machinery for sys/random.h vs linux/random.h
in favor of single HAVE_GETRANDOM.

10 months agorandom-util: drop needless conditionalization of sys/auxv.h
Mike Yuan [Thu, 2 Jan 2025 18:59:56 +0000 (19:59 +0100)] 
random-util: drop needless conditionalization of sys/auxv.h

We assume its existence in basic/build-path.c, shared/userdb.c,
and coredump/coredump.c already, for which nothing has been reported
so far. So this seems safe to drop.

10 months agomissing_syscall: mandate __NR_memfd_create
Mike Yuan [Thu, 2 Jan 2025 19:32:51 +0000 (20:32 +0100)] 
missing_syscall: mandate __NR_memfd_create

Follow-up for 6db5a6e799db9d95185cd0c2a327109e80114aea

For basic system functionality we require memfd nowadays,
so fail the build if syscall number not available.

10 months agoREADME: document kernel version for GRND_INSECURE and close_range()
Mike Yuan [Thu, 2 Jan 2025 19:03:00 +0000 (20:03 +0100)] 
README: document kernel version for GRND_INSECURE and close_range()

10 months agoshared/hibernate-util: handle the case where no swap has available backing dev (...
Mike Yuan [Thu, 2 Jan 2025 18:26:58 +0000 (19:26 +0100)] 
shared/hibernate-util: handle the case where no swap has available backing dev (#35802)

Fixes https://github.com/systemd/systemd/issues/35798
Replaces https://github.com/systemd/systemd/pull/35801

10 months agoask-password: add varlink IPC interface and various other additions and fixes (#35074)
Lennart Poettering [Thu, 2 Jan 2025 17:21:35 +0000 (18:21 +0100)] 
ask-password: add varlink IPC interface and various other additions and fixes (#35074)

10 months agocore/socket: several fixlets (#35637)
Lennart Poettering [Thu, 2 Jan 2025 17:20:48 +0000 (18:20 +0100)] 
core/socket: several fixlets (#35637)

Fixes https://github.com/systemd/systemd/issues/35635

10 months agotest: update README's Ubuntu CI section for mkosi changes
Luca Boccassi [Thu, 2 Jan 2025 16:21:42 +0000 (16:21 +0000)] 
test: update README's Ubuntu CI section for mkosi changes

10 months agoTwo doc updates (#35810)
Luca Boccassi [Thu, 2 Jan 2025 16:04:00 +0000 (16:04 +0000)] 
Two doc updates (#35810)

10 months agotest: add CI test validating the new varlink interface and more 35074/head
Lennart Poettering [Wed, 6 Nov 2024 22:47:37 +0000 (23:47 +0100)] 
test: add CI test validating the new varlink interface and more

10 months agoask-password: add comment with well-known errors from ask_password_auto()
Lennart Poettering [Thu, 7 Nov 2024 14:07:18 +0000 (15:07 +0100)] 
ask-password: add comment with well-known errors from ask_password_auto()

10 months agoask-password: add Varlink API for querying passwords from the user
Lennart Poettering [Wed, 6 Nov 2024 10:56:46 +0000 (11:56 +0100)] 
ask-password: add Varlink API for querying passwords from the user

This turns systemd-ask-password into a small Varlink service, so that
there's an standard IPC way to ask for a password. It mostly directly
exposes the functionality of the Varlink service.

10 months agoask-password-api: add new "hup_fd" field to AskPasswordReq
Lennart Poettering [Thu, 7 Nov 2024 10:38:23 +0000 (11:38 +0100)] 
ask-password-api: add new "hup_fd" field to AskPasswordReq

This new field allows specification of an fd on which the password
prompt logic will look for POLLHUP events for, and if seen will abort
the query.

The usecase for this is that when we query for a pw on behalf of a
Varlink client we can abort the query automatically if the client dies.

10 months agoask-password-api: move timeout into AskPasswordRequest structure too
Lennart Poettering [Thu, 7 Nov 2024 09:41:56 +0000 (10:41 +0100)] 
ask-password-api: move timeout into AskPasswordRequest structure too

10 months agoask-password-api: move tty_fd into AskPasswordRequest structure, too
Lennart Poettering [Thu, 7 Nov 2024 09:30:34 +0000 (10:30 +0100)] 
ask-password-api: move tty_fd into AskPasswordRequest structure, too

10 months agoask-password-api: move 'flag_file' from function parameter into AskPasswordRequest...
Lennart Poettering [Thu, 7 Nov 2024 09:00:53 +0000 (10:00 +0100)] 
ask-password-api: move 'flag_file' from function parameter into AskPasswordRequest structure

10 months agoask-password-agent: send READY=1 when we established inotify watch
Lennart Poettering [Wed, 6 Nov 2024 22:38:17 +0000 (23:38 +0100)] 
ask-password-agent: send READY=1 when we established inotify watch

10 months agoask-password-agent: optionally read pw to reply from env var
Lennart Poettering [Wed, 6 Nov 2024 22:38:01 +0000 (23:38 +0100)] 
ask-password-agent: optionally read pw to reply from env var

10 months agopcrextend: split out varlink server setup into its own function
Lennart Poettering [Wed, 6 Nov 2024 10:58:56 +0000 (11:58 +0100)] 
pcrextend: split out varlink server setup into its own function

10 months agosd-varlink: expose api to get input/output fd separately
Lennart Poettering [Thu, 7 Nov 2024 10:49:33 +0000 (11:49 +0100)] 
sd-varlink: expose api to get input/output fd separately

10 months agodocs: Update code coverage documentation 35810/head
Daan De Meyer [Thu, 2 Jan 2025 15:25:19 +0000 (16:25 +0100)] 
docs: Update code coverage documentation

10 months agodocs: Use mkosi sandbox in test documentation as well
Daan De Meyer [Thu, 2 Jan 2025 15:17:53 +0000 (16:17 +0100)] 
docs: Use mkosi sandbox in test documentation as well

Same change as in HACKING.md, but for running the integration tests.

10 months agoshared/hibernate-util: drop support for kernels lacking /sys/power/resume_offset 35802/head
Mike Yuan [Thu, 2 Jan 2025 03:32:00 +0000 (04:32 +0100)] 
shared/hibernate-util: drop support for kernels lacking /sys/power/resume_offset

The current fallback path is actually unreliable, given
the kernel *supports* setting the resume offset through
cmdline after all, but just not exposed under /sys/.
For v258 let's drop it hence.

I didn't bump the baseline to 4.17, but merely documented
new requirement in README, because there's certainly more
compat stuff to drop between 4.3 and 4.17, and README is
a useful list for things to kill. We'll get to 5.4 eventually.

10 months agoREADME: document a bunch of new kernel APIs we utilize
Mike Yuan [Thu, 2 Jan 2025 14:44:59 +0000 (15:44 +0100)] 
README: document a bunch of new kernel APIs we utilize

10 months agoshared/blockdev-util: shorten the code a bit
Mike Yuan [Thu, 2 Jan 2025 03:22:46 +0000 (04:22 +0100)] 
shared/blockdev-util: shorten the code a bit

If btrfs_get_block_device_fd() returns 0, ret is already initialized.

10 months agoshared/hibernate-util: handle the case where no swap has available backing dev
Mike Yuan [Thu, 2 Jan 2025 03:17:47 +0000 (04:17 +0100)] 
shared/hibernate-util: handle the case where no swap has available backing dev

This also makes find_suitable_hibernation_device() report
more accurate error (ENOSPC -> ESTALE) if there's
no swap space on the system at all but resume= is set.

Fixes #35798
Replaces #35801

10 months agoshared/hibernate-util: don't attempt to fiemap fd if no backing dev available
Mike Yuan [Thu, 2 Jan 2025 03:13:23 +0000 (04:13 +0100)] 
shared/hibernate-util: don't attempt to fiemap fd if no backing dev available

Prompted by #35798

Co-authored-by: Yu Watanabe <watanabe.yu+github@gmail.com>
10 months agosystemctl: certainly ignore ENOENT in checking inhibitors
Yu Watanabe [Thu, 2 Jan 2025 12:15:02 +0000 (21:15 +0900)] 
systemctl: certainly ignore ENOENT in checking inhibitors

Fixes a bug caused by 804874d26ac73e0af07c4c5d7165c95372f03f6d.

Follow-up for 084f361b509cbffe7ffd5ab6085469f76f799fe5 and
a1417e5563acb73a0accdc12b3af91e4ec1c7f46.

Note, ERRNO_IS_NEG_DISCONNECT() includes ENONET rather than ENOENT...
So, ENOENT needs to be handled explicitly.

Fixes #35757 and #35806.

10 months agomkosi: Allow disabling vcs-tag via environment variable
Daan De Meyer [Thu, 2 Jan 2025 12:11:48 +0000 (13:11 +0100)] 
mkosi: Allow disabling vcs-tag via environment variable

10 months agobash-completion/journalctl: list user units when --user is already specified (#35799)
Luca Boccassi [Thu, 2 Jan 2025 11:20:31 +0000 (11:20 +0000)] 
bash-completion/journalctl: list user units when --user is already specified (#35799)

Also, escape the current input before matching listed user units.

Fixes #35794.

10 months agoerrno-list: prefer strerrorname_np() as errno_to_name() provider
Mike Yuan [Tue, 31 Dec 2024 01:46:28 +0000 (02:46 +0100)] 
errno-list: prefer strerrorname_np() as errno_to_name() provider

10 months agobash-completion/journalctl: also escape the current input of user unit 35799/head
Yu Watanabe [Thu, 2 Jan 2025 02:50:38 +0000 (11:50 +0900)] 
bash-completion/journalctl: also escape the current input of user unit

Follow-up for cec82cb943d0fd23dd09309be62c6bcde6b47839.

10 months agobash-completion/journalctl: list user units when --user is already specified
Yu Watanabe [Thu, 2 Jan 2025 02:48:58 +0000 (11:48 +0900)] 
bash-completion/journalctl: list user units when --user is already specified

Follow-up for 52051dd84c45c745ca877d8893be6f71aa27bf97.
Fixes #35794.

10 months ago60-sensor.hwdb: Loosen model mask to include entire series
richfifeg [Mon, 30 Dec 2024 18:07:02 +0000 (10:07 -0800)] 
60-sensor.hwdb: Loosen model mask to include entire series

This sensor is the same for Asus's entire Q5##L series, so match accordingly.

Tested with my Q502LAB.

10 months agopo: Translated using Weblate (German)
Ettore Atalan [Mon, 30 Dec 2024 22:38:37 +0000 (23:38 +0100)] 
po: Translated using Weblate (German)

Currently translated at 96.8% (249 of 257 strings)

Co-authored-by: Ettore Atalan <atalanttore@googlemail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/de/
Translation: systemd/main

10 months agoTEST-07-PID1: add test case for #35635 35637/head
Mike Yuan [Mon, 30 Dec 2024 22:35:32 +0000 (23:35 +0100)] 
TEST-07-PID1: add test case for #35635

10 months agotest: move test for MaxConnectionsPerSource= to TEST-07-PID1
Mike Yuan [Mon, 30 Dec 2024 22:04:21 +0000 (23:04 +0100)] 
test: move test for MaxConnectionsPerSource= to TEST-07-PID1

Follow-up for 3456c89ac26872f4befa2bdf7c260529932e3909

10 months agocore/socket: introduce intermediate SOCKET_START_OPEN state
Mike Yuan [Mon, 16 Dec 2024 00:54:11 +0000 (01:54 +0100)] 
core/socket: introduce intermediate SOCKET_START_OPEN state

Prior to this commit, if no Exec*= is defined for socket,
and the unit was in SOCKET_FAILED state, failure of socket_open_fds()
would induce state transition SOCKET_FAILED -> SOCKET_FAILED,
and OnFailure= deps get unexpectedly skipped. Let's introduce
an intermediate state, so that during unit start we enter
UNIT_ACTIVATING at least once.

Fixes #35635

10 months agocore/socket: clean up usbffs handling
Mike Yuan [Mon, 16 Dec 2024 18:59:17 +0000 (19:59 +0100)] 
core/socket: clean up usbffs handling

- Log about errors in socket_open_fds()
- Open parent dir fd and operate under it, instead of constructing paths
  everywhere
- Replace scandir() with readdir_all()

10 months agobasic/recurse-dir: modernize readdir_all()
Mike Yuan [Mon, 16 Dec 2024 15:41:58 +0000 (16:41 +0100)] 
basic/recurse-dir: modernize readdir_all()

10 months agocore/socket: close fds also on SOCKET_CLEAN state
Mike Yuan [Mon, 16 Dec 2024 00:28:02 +0000 (01:28 +0100)] 
core/socket: close fds also on SOCKET_CLEAN state

Follow-up for c968d76a382f905b419cacd23a6b20aa31aca580

We'd only transition to SOCKET_CLEAN state if previously
inactive (see socket_clean()), hence no fds shall be persisted
in this state.

10 months agocore/socket: use correct kill operation for SOCKET_STOP_PRE_SIGTERM
Mike Yuan [Tue, 17 Dec 2024 12:51:24 +0000 (13:51 +0100)] 
core/socket: use correct kill operation for SOCKET_STOP_PRE_SIGTERM

Follow-up for a232ebcc2cd3d5e16b0d0fb0be61549f25fb8239

10 months agocore/socket: trivial coding style cleanups
Mike Yuan [Mon, 16 Dec 2024 00:29:35 +0000 (01:29 +0100)] 
core/socket: trivial coding style cleanups

10 months agosysusers.d/basic: fix alignment
Mike Yuan [Mon, 16 Dec 2024 14:26:02 +0000 (15:26 +0100)] 
sysusers.d/basic: fix alignment

Follow-up for a4c0528f14257e23a8fad8855f178ef71d99978b

10 months agomkosi: switch to github mirror of openSUSE sources from build.opensuse.org (#35789)
Luca Boccassi [Mon, 30 Dec 2024 18:42:29 +0000 (18:42 +0000)] 
mkosi: switch to github mirror of openSUSE sources from build.opensuse.org (#35789)

The commit history of
[src.opensuse.org](https://src.opensuse.org/pool/systemd/src/branch/devel)
has been reset again to 2015 (both branches, factory and devel)... this
is unusable for now. I'd suggest switching to the github mirror of
code.opensuse.org, maintained since 2019 (at least github is not down
that often and the commit history does not change).

10 months agomkosi: switch to github mirror of openSUSE sources from build.opensuse.org 35789/head
Antonio Alvarez Feijoo [Mon, 30 Dec 2024 16:39:16 +0000 (17:39 +0100)] 
mkosi: switch to github mirror of openSUSE sources from build.opensuse.org

The current src.opensuse.org is very unstable and commit hashes are reset (or
even removed) every now and then. While the official repo is not fixed, let's
move to a more stable source, the github mirror of code.opensuse.org, maintained
since 2019.

10 months agomkosi: add libopenssl devel package to openSUSE tools tree
Antonio Alvarez Feijoo [Mon, 30 Dec 2024 16:38:36 +0000 (17:38 +0100)] 
mkosi: add libopenssl devel package to openSUSE tools tree

Otherwise, the build fails with:

```
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -C /mnt/work/src/systemd/upstream-fork/main/build-mkosi
ninja: Entering directory `/mnt/work/src/systemd/upstream-fork/main/build-mkosi'
[463/2561] Compiling C object src/shared/libsystemd-shared-258.a.p/openssl-util.c.o
FAILED: src/shared/libsystemd-shared-258.a.p/openssl-util.c.o
cc -Isrc/shared/libsystemd-shared-258.a.p -Isrc/shared -I../src/shared -Isrc/basic -I../src/basic -Isrc/fundamental -I../src/fundamental -Isrc/systemd -I../src/systemd -I. -I.. -I../src/libsystemd/sd-bus -I../src/libsystemd/sd-device -I../src/libsystemd/sd-event -I../src/libsystemd/sd-hwdb -I../src/libsystemd/sd-id128 -I../src/libsystemd/sd-journal -I../src/libsystemd/sd-json -I../src/libsystemd/sd-netlink -I../src/libsystemd/sd-network -I../src/libsystemd/sd-path -I../src/libsystemd/sd-resolve -I../src/libsystemd/sd-varlink -I/usr/include/blkid -I/usr/include/libmount -I/usr/include/p11-kit-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O0 -g -Wno-missing-field-initializers -Wno-unused-parameter -Wno-nonnull-compare -Warray-bounds -Warray-bounds=2 -Wdate-time -Wendif-labels -Werror=format=2 -Werror=format-signedness -Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-pointer-types -Werror=int-conversion -Werror=missing-declarations -Werror=missing-prototypes -Werror=overflow -Werror=override-init -Werror=return-type -Werror=shift-count-overflow -Werror=shift-overflow=2 -Werror=strict-flex-arrays -Werror=undef -Wfloat-equal -Wimplicit-fallthrough=5 -Winit-self -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-aliasing=2 -Wstrict-prototypes -Wsuggest-attribute=noreturn -Wunused-function -Wwrite-strings -Wzero-length-bounds -fdiagnostics-show-option -fno-common -fstack-protector -fstack-protector-strong -fstrict-flex-arrays=3 --param=ssp-buffer-size=4 -Wno-unused-result -Werror=shadow -fPIC -fno-strict-aliasing -fstrict-flex-arrays=1 -fvisibility=hidden -fno-omit-frame-pointer -include config.h -pthread -fvisibility=default -MD -MQ src/shared/libsystemd-shared-258.a.p/openssl-util.c.o -MF src/shared/libsystemd-shared-258.a.p/openssl-util.c.o.d -o src/shared/libsystemd-shared-258.a.p/openssl-util.c.o -c ../src/shared/openssl-util.c
../src/shared/openssl-util.c: In function ‘openssl_ask_password_ui_read’:
../src/shared/openssl-util.c:1395:65: error: implicit declaration of function ‘UI_method_get_ex_data’; did you mean ‘UI_method_get_reader’? [-Wimplicit-function-declaration]
 1395 |                 AskPasswordRequest *req = (AskPasswordRequest*) UI_method_get_ex_data(UI_get_method(ui), 0);
      |                                                                 ^~~~~~~~~~~~~~~~~~~~~
      |                                                                 UI_method_get_reader
../src/shared/openssl-util.c:1395:65: warning: nested extern declaration of ‘UI_method_get_ex_data’ [-Wnested-externs]
../src/shared/openssl-util.c:1395:43: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 1395 |                 AskPasswordRequest *req = (AskPasswordRequest*) UI_method_get_ex_data(UI_get_method(ui), 0);
      |                                           ^
../src/shared/openssl-util.c: In function ‘openssl_ask_password_ui_new’:
../src/shared/openssl-util.c:1479:13: error: implicit declaration of function ‘UI_method_set_ex_data’; did you mean ‘UI_method_set_reader’? [-Wimplicit-function-declaration]
 1479 |         if (UI_method_set_ex_data(ui->method, 0, &ui->request) == 0)
      |             ^~~~~~~~~~~~~~~~~~~~~
      |             UI_method_set_reader
../src/shared/openssl-util.c:1479:13: warning: nested extern declaration of ‘UI_method_set_ex_data’ [-Wnested-externs]
[480/2561] Compiling C object src/shared/libsystemd-shared-258.a.p/pkcs11-util.c.o
ninja: build stopped: subcommand failed.
```

10 months agoFollow-ups for recent PRs plus modernizations prompted thereby (#35760)
Mike Yuan [Mon, 30 Dec 2024 15:35:59 +0000 (16:35 +0100)] 
Follow-ups for recent PRs plus modernizations prompted thereby (#35760)

Please backport the first commit to stable.

10 months agomkosi: update openSUSE commit reference
Antonio Alvarez Feijoo [Mon, 30 Dec 2024 10:00:07 +0000 (11:00 +0100)] 
mkosi: update openSUSE commit reference

Force-pushed as usual, now HEAD is v257.1.

10 months agoukify: fix typos
Antonio Alvarez Feijoo [Mon, 30 Dec 2024 08:41:32 +0000 (09:41 +0100)] 
ukify: fix typos

10 months agotest-network: add test cases for global [DHCPv4] ClientIdentifier= setting 35783/head
Yu Watanabe [Mon, 30 Dec 2024 02:18:59 +0000 (11:18 +0900)] 
test-network: add test cases for global [DHCPv4] ClientIdentifier= setting

10 months agonetwork: introduce system wide default setting for DHCPv4 client ID
Yu Watanabe [Mon, 30 Dec 2024 01:16:37 +0000 (10:16 +0900)] 
network: introduce system wide default setting for DHCPv4 client ID

Typically, the same client identifier setting is used for all
interfaces. Hence, better to provide the system-wide setting to specify
the client identifier.

10 months agoman/networkd.conf: update section explanation
Yu Watanabe [Mon, 30 Dec 2024 01:14:07 +0000 (10:14 +0900)] 
man/networkd.conf: update section explanation

These section contains not only DUID related settings.

Follow-up for 418f2dc75564330d4ff6c86193f4a3c8ffbb1f1b.

10 months agoman: change "secureboot-private-key.pem" filename for consistency
cvlc12 [Sat, 28 Dec 2024 18:19:08 +0000 (19:19 +0100)] 
man: change "secureboot-private-key.pem" filename for consistency

10 months agoman: adjust description of PrivateUsers= so it is in line with reality
Michal Sekletar [Fri, 15 Nov 2024 22:08:37 +0000 (23:08 +0100)] 
man: adjust description of PrivateUsers= so it is in line with reality

When the option is not available unit will not even start so there is
no security risk.

Fixes #34983

10 months agotree-wide: replace FLAGS_SET(..., 1 << v) with BIT_SET(..., v) 35760/head
Mike Yuan [Thu, 26 Dec 2024 19:30:12 +0000 (20:30 +0100)] 
tree-wide: replace FLAGS_SET(..., 1 << v) with BIT_SET(..., v)

10 months agoshared/condition: use BIT_SET where appropriate
Mike Yuan [Thu, 26 Dec 2024 18:53:23 +0000 (19:53 +0100)] 
shared/condition: use BIT_SET where appropriate

10 months agocapability-util: make CAPABILITY_QUINTET_NULL const, introduce capability_quintet_is_...
Mike Yuan [Tue, 24 Dec 2024 15:59:48 +0000 (16:59 +0100)] 
capability-util: make CAPABILITY_QUINTET_NULL const, introduce capability_quintet_is_fully_set() helper

Follow-up for 1184626a269e38dcdfcd1042975a31d4eb30cd5e

See 9bb64f1b8d2252d558f209a04b171d65b5ef131b for rationale
of the first change.

10 months agocapability-util: minor modernizations
Mike Yuan [Thu, 26 Dec 2024 18:53:12 +0000 (19:53 +0100)] 
capability-util: minor modernizations

10 months agosd-varlink: add missing error check in sd_varlink_listen_auto()
Mike Yuan [Wed, 25 Dec 2024 14:23:19 +0000 (15:23 +0100)] 
sd-varlink: add missing error check in sd_varlink_listen_auto()

Follow-up for 50994b2f91093079917e01d04004425f101327ba

10 months agocore/unit-serialize: fix serialization of markers
Mike Yuan [Thu, 26 Dec 2024 20:15:44 +0000 (21:15 +0100)] 
core/unit-serialize: fix serialization of markers

Follow-up for ff68472a20c208121b69ea13586f3105a219bc14

10 months agolocale-setup: do not load locale from environemnt when /etc/locale.conf is unchanged
Yu Watanabe [Sat, 28 Dec 2024 06:07:31 +0000 (15:07 +0900)] 
locale-setup: do not load locale from environemnt when /etc/locale.conf is unchanged

Previously, when /etc/locale.conf is unchanged, locales were loaded from
possibly outdated environment variable.

Fixes a bug introduced by 018befcff6b51f8a50ca232e1984d34526037241 (v253).
Fixes #35717.

10 months agomachine: GC machine when no leader PID is set
Yu Watanabe [Sat, 28 Dec 2024 02:38:24 +0000 (11:38 +0900)] 
machine: GC machine when no leader PID is set

After d8854ff1aca4434db0d7d6dcaf9fcf2f38105fb4, if a serialized
leader PID of a machine is already dead when deserialized, then the
leader PID and PIDFD are unset for the machine, and subsequent
machine_start() -> machine_watch_pidfd() will trigger an assertion.
This makes a Machine object without leader PID GCed.

Fixes a bug introduced by the combination of
d8854ff1aca4434db0d7d6dcaf9fcf2f38105fb4 (v255) and
1762c2c045d3a78d3cad54c6b1e5ee9624b32b00 (v257).

Fixes #35602.

10 months agoTEST-74-AUX: add reproducer of issue #35746
Yu Watanabe [Sat, 28 Dec 2024 03:06:24 +0000 (12:06 +0900)] 
TEST-74-AUX: add reproducer of issue #35746

Addresses https://github.com/systemd/systemd/pull/35752#pullrequestreview-2523080117.

10 months agosystemctl: also ignore ENOENT in checking inhibitors
Yu Watanabe [Sat, 28 Dec 2024 04:36:32 +0000 (13:36 +0900)] 
systemctl: also ignore ENOENT in checking inhibitors

Fixes a bug caused by 804874d26ac73e0af07c4c5d7165c95372f03f6d.
Follow-up for a1417e5563acb73a0accdc12b3af91e4ec1c7f46.
Fixes #35757.

10 months agologs-show: skip journal entry with an invalid timestamp (#35774)
Yu Watanabe [Sat, 28 Dec 2024 11:34:15 +0000 (20:34 +0900)] 
logs-show: skip journal entry with an invalid timestamp (#35774)

Fixes #35737.

10 months agostring-util: modernize split_pair()
Yu Watanabe [Sat, 21 Dec 2024 18:34:43 +0000 (03:34 +0900)] 
string-util: modernize split_pair()

- use _cleanup_free_ attribute,
- rename output arguments,
- trigger assertion when an empty separator is passed.

10 months agofuzz-journal-remote: use ASSERT_OK() and friends 35774/head
Yu Watanabe [Sat, 28 Dec 2024 05:17:47 +0000 (14:17 +0900)] 
fuzz-journal-remote: use ASSERT_OK() and friends

10 months agologs-show: skip journal entry with an invalid timestamp
Yu Watanabe [Sat, 28 Dec 2024 05:09:22 +0000 (14:09 +0900)] 
logs-show: skip journal entry with an invalid timestamp

Follow-up for 275e6be052e690adcad5d2a557acb9dcb5bedbc6.
Fixes oss-fuzz#385221809 (https://issues.oss-fuzz.com/issues/385221809).
Fixes #35737.

10 months agoGrammar fixes to manpages (#35753)
Yu Watanabe [Sat, 28 Dec 2024 03:46:56 +0000 (12:46 +0900)] 
Grammar fixes to manpages (#35753)

Fix some missing commas, missing conjunction words, wrong
inflections, and trim excess parenthesizing.

10 months agodocs: Clarify requirement
Alexander Krabler [Fri, 27 Dec 2024 17:29:57 +0000 (18:29 +0100)] 
docs: Clarify requirement

10 months agocreds: fix use-after-free in varlink interface
Luca Boccassi [Fri, 27 Dec 2024 15:06:39 +0000 (15:06 +0000)] 
creds: fix use-after-free in varlink interface

All other usages of sd_varlink_call* do not free the json return parameter,
and it is owned by the varlink object instead. Do the same here.

TEST-54-CREDS.sh[1074]: ==1074==ERROR: AddressSanitizer: heap-use-after-free on address 0x50c00000095a at pc 0x55cf8cd18a0f bp 0x7ffd7b9d4f10 sp 0x7ffd7b9d4f08
TEST-54-CREDS.sh[1074]: READ of size 2 at 0x50c00000095a thread T0 ((sd-mkdcreds))
TEST-54-CREDS.sh[1074]:     #0 0x55cf8cd18a0e in sd_json_variant_unref /usr/src/debug/systemd/src/libsystemd/sd-json/sd-json.c:887:16
TEST-54-CREDS.sh[1074]:     #1 0x55cf8cd4cecb in varlink_clear_current /usr/src/debug/systemd/src/libsystemd/sd-varlink/sd-varlink.c:593:22
TEST-54-CREDS.sh[1074]:     #2 0x55cf8cd4975e in varlink_clear /usr/src/debug/systemd/src/libsystemd/sd-varlink/sd-varlink.c:614:9
TEST-54-CREDS.sh[1074]:     #3 0x55cf8cd3dc3c in varlink_destroy /usr/src/debug/systemd/src/libsystemd/sd-varlink/sd-varlink.c:651:9
TEST-54-CREDS.sh[1074]:     #4 0x55cf8cd3dc3c in sd_varlink_unref /usr/src/debug/systemd/src/libsystemd/sd-varlink/sd-varlink.c:657:1
TEST-54-CREDS.sh[1074]:     #5 0x55cf8cb47a82 in sd_varlink_unrefp /usr/src/debug/systemd/src/systemd/sd-varlink.h:279:1
TEST-54-CREDS.sh[1074]:     #6 0x55cf8cb47a82 in ipc_decrypt_credential /usr/src/debug/systemd/src/shared/creds-util.c:1660:1
TEST-54-CREDS.sh[1074]:     #7 0x55cf8caca99a in maybe_decrypt_and_write_credential /usr/src/debug/systemd/src/core/exec-credential.c:486:29
TEST-54-CREDS.sh[1074]:     #8 0x55cf8cac790b in load_credential /usr/src/debug/systemd/src/core/exec-credential.c:713:16
TEST-54-CREDS.sh[1074]:     #9 0x55cf8cac5403 in acquire_credentials /usr/src/debug/systemd/src/core/exec-credential.c:819:29
TEST-54-CREDS.sh[1074]:     #10 0x55cf8cac5403 in setup_credentials_internal /usr/src/debug/systemd/src/core/exec-credential.c:1023:13
TEST-54-CREDS.sh[1074]:     #11 0x55cf8cac42d4 in exec_setup_credentials /usr/src/debug/systemd/src/core/exec-credential.c:1168:21
TEST-54-CREDS.sh[1074]:     #12 0x55cf8ca59569 in exec_invoke /usr/src/debug/systemd/src/core/exec-invoke.c:4866:13
TEST-54-CREDS.sh[1074]:     #13 0x55cf8ca428d8 in run /usr/src/debug/systemd/src/core/executor.c:244:13
TEST-54-CREDS.sh[1074]:     #14 0x55cf8ca428d8 in main /usr/src/debug/systemd/src/core/executor.c:275:13
TEST-54-CREDS.sh[1074]:     #15 0x7f64b40110c7 in __libc_start_call_main (/lib64/libc.so.6+0x40c7) (BuildId: 159846287d47eef88f2a478f59803f6e8fc81d05)
TEST-54-CREDS.sh[1074]:     #16 0x7f64b401118a in __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x418a) (BuildId: 159846287d47eef88f2a478f59803f6e8fc81d05)
TEST-54-CREDS.sh[1074]:     #17 0x55cf8ca41cb4  (/usr/lib/systemd/systemd-executor+0x124cb4) (BuildId: 24f2b1608c3aaee3226cdd14fa2b6e6741156222)
TEST-54-CREDS.sh[1074]: 0x50c00000095a is located 26 bytes inside of 120-byte region [0x50c000000940,0x50c0000009b8)
TEST-54-CREDS.sh[1074]: freed by thread T0 ((sd-mkdcreds)) here:
TEST-54-CREDS.sh[1074]:     #0 0x7f64b48d57ea in free (/usr/lib/clang/19/lib/x86_64-redhat-linux-gnu/libclang_rt.asan.so+0xd57ea) (BuildId: c59bbd28ceb74038a60373d4a8cd4c258bcf0b4e)
TEST-54-CREDS.sh[1074]:     #1 0x55cf8cd188ab in sd_json_variant_unref /usr/src/debug/systemd/src/libsystemd/sd-json/sd-json.c:895:25
TEST-54-CREDS.sh[1074]:     #2 0x55cf8cb47a4c in sd_json_variant_unrefp /usr/src/debug/systemd/src/systemd/sd-json.h:98:1
TEST-54-CREDS.sh[1074]:     #3 0x55cf8cb47a4c in ipc_decrypt_credential /usr/src/debug/systemd/src/shared/creds-util.c:1660:1
TEST-54-CREDS.sh[1074]:     #4 0x55cf8caca99a in maybe_decrypt_and_write_credential /usr/src/debug/systemd/src/core/exec-credential.c:486:29
TEST-54-CREDS.sh[1074]:     #5 0x55cf8cac790b in load_credential /usr/src/debug/systemd/src/core/exec-credential.c:713:16
TEST-54-CREDS.sh[1074]:     #6 0x55cf8cac5403 in acquire_credentials /usr/src/debug/systemd/src/core/exec-credential.c:819:29
TEST-54-CREDS.sh[1074]:     #7 0x55cf8cac5403 in setup_credentials_internal /usr/src/debug/systemd/src/core/exec-credential.c:1023:13
TEST-54-CREDS.sh[1074]:     #8 0x55cf8cac42d4 in exec_setup_credentials /usr/src/debug/systemd/src/core/exec-credential.c:1168:21
TEST-54-CREDS.sh[1074]:     #9 0x55cf8ca59569 in exec_invoke /usr/src/debug/systemd/src/core/exec-invoke.c:4866:13
TEST-54-CREDS.sh[1074]:     #10 0x55cf8ca428d8 in run /usr/src/debug/systemd/src/core/executor.c:244:13
TEST-54-CREDS.sh[1074]:     #11 0x55cf8ca428d8 in main /usr/src/debug/systemd/src/core/executor.c:275:13
TEST-54-CREDS.sh[1074]:     #12 0x7f64b40110c7 in __libc_start_call_main (/lib64/libc.so.6+0x40c7) (BuildId: 159846287d47eef88f2a478f59803f6e8fc81d05)
TEST-54-CREDS.sh[1074]:     #13 0x7f64b401118a in __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x418a) (BuildId: 159846287d47eef88f2a478f59803f6e8fc81d05)
TEST-54-CREDS.sh[1074]:     #14 0x55cf8ca41cb4  (/usr/lib/systemd/systemd-executor+0x124cb4) (BuildId: 24f2b1608c3aaee3226cdd14fa2b6e6741156222)
TEST-54-CREDS.sh[1074]: previously allocated by thread T0 ((sd-mkdcreds)) here:
TEST-54-CREDS.sh[1074]:     #0 0x7f64b48d5a83 in malloc (/usr/lib/clang/19/lib/x86_64-redhat-linux-gnu/libclang_rt.asan.so+0xd5a83) (BuildId: c59bbd28ceb74038a60373d4a8cd4c258bcf0b4e)
TEST-54-CREDS.sh[1074]:     #1 0x55cf8cd16bb7 in malloc_multiply /usr/src/debug/systemd/src/basic/alloc-util.h:119:16
TEST-54-CREDS.sh[1074]:     #2 0x55cf8cd16bb7 in sd_json_variant_new_object /usr/src/debug/systemd/src/libsystemd/sd-json/sd-json.c:737:13
TEST-54-CREDS.sh[1074]:     #3 0x55cf8cd32e58 in json_parse_internal /usr/src/debug/systemd/src/libsystemd/sd-json/sd-json.c:3161:29
TEST-54-CREDS.sh[1074]:     #4 0x55cf8cd37326 in sd_json_parse_with_source /usr/src/debug/systemd/src/libsystemd/sd-json/sd-json.c:3408:16
TEST-54-CREDS.sh[1074]:     #5 0x55cf8cd37326 in sd_json_parse /usr/src/debug/systemd/src/libsystemd/sd-json/sd-json.c:3437:16
TEST-54-CREDS.sh[1074]:     #6 0x55cf8cd3f753 in varlink_parse_message /usr/src/debug/systemd/src/libsystemd/sd-varlink/sd-varlink.c:962:13
TEST-54-CREDS.sh[1074]:     #7 0x55cf8cd3f753 in sd_varlink_process /usr/src/debug/systemd/src/libsystemd/sd-varlink/sd-varlink.c:1466:13
TEST-54-CREDS.sh[1074]:     #8 0x55cf8cd4c0a9 in sd_varlink_call_full /usr/src/debug/systemd/src/libsystemd/sd-varlink/sd-varlink.c:2160:21
TEST-54-CREDS.sh[1074]:     #9 0x55cf8cd4d617 in sd_varlink_callb_ap /usr/src/debug/systemd/src/libsystemd/sd-varlink/sd-varlink.c:2237:16
TEST-54-CREDS.sh[1074]:     #10 0x55cf8cd4da3c in sd_varlink_callb /usr/src/debug/systemd/src/libsystemd/sd-varlink/sd-varlink.c:2251:13
TEST-54-CREDS.sh[1074]:     #11 0x55cf8cb47686 in ipc_decrypt_credential /usr/src/debug/systemd/src/shared/creds-util.c:1623:13
TEST-54-CREDS.sh[1074]:     #12 0x55cf8caca99a in maybe_decrypt_and_write_credential /usr/src/debug/systemd/src/core/exec-credential.c:486:29
TEST-54-CREDS.sh[1074]:     #13 0x55cf8cac790b in load_credential /usr/src/debug/systemd/src/core/exec-credential.c:713:16
TEST-54-CREDS.sh[1074]:     #14 0x55cf8cac5403 in acquire_credentials /usr/src/debug/systemd/src/core/exec-credential.c:819:29
TEST-54-CREDS.sh[1074]:     #15 0x55cf8cac5403 in setup_credentials_internal /usr/src/debug/systemd/src/core/exec-credential.c:1023:13
TEST-54-CREDS.sh[1074]:     #16 0x55cf8cac42d4 in exec_setup_credentials /usr/src/debug/systemd/src/core/exec-credential.c:1168:21
TEST-54-CREDS.sh[1074]:     #17 0x55cf8ca59569 in exec_invoke /usr/src/debug/systemd/src/core/exec-invoke.c:4866:13
TEST-54-CREDS.sh[1074]:     #18 0x55cf8ca428d8 in run /usr/src/debug/systemd/src/core/executor.c:244:13
TEST-54-CREDS.sh[1074]:     #19 0x55cf8ca428d8 in main /usr/src/debug/systemd/src/core/executor.c:275:13
TEST-54-CREDS.sh[1074]:     #20 0x7f64b40110c7 in __libc_start_call_main (/lib64/libc.so.6+0x40c7) (BuildId: 159846287d47eef88f2a478f59803f6e8fc81d05)
TEST-54-CREDS.sh[1074]:     #21 0x7f64b401118a in __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x418a) (BuildId: 159846287d47eef88f2a478f59803f6e8fc81d05)
TEST-54-CREDS.sh[1074]:     #22 0x55cf8ca41cb4  (/usr/lib/systemd/systemd-executor+0x124cb4) (BuildId: 24f2b1608c3aaee3226cdd14fa2b6e6741156222)
TEST-54-CREDS.sh[1074]: SUMMARY: AddressSanitizer: heap-use-after-free /usr/src/debug/systemd/src/libsystemd/sd-json/sd-json.c:887:16 in sd_json_variant_unref
TEST-54-CREDS.sh[1074]: Shadow bytes around the buggy address:
TEST-54-CREDS.sh[1074]:   0x50c000000680: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
TEST-54-CREDS.sh[1074]:   0x50c000000700: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
TEST-54-CREDS.sh[1074]:   0x50c000000780: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
TEST-54-CREDS.sh[1074]:   0x50c000000800: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
TEST-54-CREDS.sh[1074]:   0x50c000000880: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
TEST-54-CREDS.sh[1074]: =>0x50c000000900: fa fa fa fa fa fa fa fa fd fd fd[fd]fd fd fd fd
TEST-54-CREDS.sh[1074]:   0x50c000000980: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
TEST-54-CREDS.sh[1074]:   0x50c000000a00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
TEST-54-CREDS.sh[1074]:   0x50c000000a80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
TEST-54-CREDS.sh[1074]:   0x50c000000b00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
TEST-54-CREDS.sh[1074]:   0x50c000000b80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
TEST-54-CREDS.sh[1074]: Shadow byte legend (one shadow byte represents 8 application bytes):
TEST-54-CREDS.sh[1074]:   Addressable:           00
TEST-54-CREDS.sh[1074]:   Partially addressable: 01 02 03 04 05 06 07
TEST-54-CREDS.sh[1074]:   Heap left redzone:       fa
TEST-54-CREDS.sh[1074]:   Freed heap region:       fd
TEST-54-CREDS.sh[1074]:   Stack left redzone:      f1
TEST-54-CREDS.sh[1074]:   Stack mid redzone:       f2
TEST-54-CREDS.sh[1074]:   Stack right redzone:     f3
TEST-54-CREDS.sh[1074]:   Stack after return:      f5
TEST-54-CREDS.sh[1074]:   Stack use after scope:   f8
TEST-54-CREDS.sh[1074]:   Global redzone:          f9
TEST-54-CREDS.sh[1074]:   Global init order:       f6
TEST-54-CREDS.sh[1074]:   Poisoned by user:        f7
TEST-54-CREDS.sh[1074]:   Container overflow:      fc
TEST-54-CREDS.sh[1074]:   Array cookie:            ac
TEST-54-CREDS.sh[1074]:   Intra object redzone:    bb
TEST-54-CREDS.sh[1074]:   ASan internal:           fe
TEST-54-CREDS.sh[1074]:   Left alloca redzone:     ca
TEST-54-CREDS.sh[1074]:   Right alloca redzone:    cb

Follow-up for 2c3cbc5c018e05b3a3e5ec6c6a2da6f3c6c3fb09

10 months agomkosi: update opensuse spec repo commit
Luca Boccassi [Thu, 26 Dec 2024 12:08:34 +0000 (12:08 +0000)] 
mkosi: update opensuse spec repo commit

10 months agotree-wide: add missing header for glibc < 2.34 (#35756)
Luca Boccassi [Thu, 26 Dec 2024 12:24:26 +0000 (12:24 +0000)] 
tree-wide: add missing header for glibc < 2.34 (#35756)

`unistd.h` gets into the dependency tree via
`/usr/include/bits/sigstksz.h`, which was added with glibc-2.34.

10 months agoptyfwd: fix draining on exit (#35752)
Daan De Meyer [Thu, 26 Dec 2024 10:53:46 +0000 (11:53 +0100)] 
ptyfwd: fix draining on exit (#35752)

Fixes a bug introduced by #35663.
Fixes #35746.

10 months agoudevd: add missing header for glibc < 2.34 35756/head
Antonio Alvarez Feijoo [Thu, 26 Dec 2024 10:02:55 +0000 (11:02 +0100)] 
udevd: add missing header for glibc < 2.34

```
[77/1697] Compiling C object udevadm.p/src_udev_udevd.c.o
FAILED: udevadm.p/src_udev_udevd.c.o
cc -Iudevadm.p -I. -I.. -Isrc/basic -I../src/basic -Isrc/fundamental -I../src/fundamental -Isrc/systemd -I../src/systemd -I../src/libsystemd/sd-bus -I../src/libsystemd/sd-device -I../src/libsystemd/sd-event -I../src/libsystemd/sd-hwdb -I../src/libsystemd/sd-id128 -I../src/libsystemd/sd-journal -I../src/libsystemd/sd-json -I../src/libsystemd/sd-netlink -I../src/libsystemd/sd-network -I../src/libsystemd/sd-path -I../src/libsystemd/sd-resolve -I../src/libsystemd/sd-varlink -Isrc/shared -I../src/shared -I/usr/include/blkid -I/usr/include/kmod -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O0 -g -Wno-missing-field-initializers -Wno-unused-parameter -Wno-nonnull-compare -Warray-bounds -Warray-bounds=2 -Wdate-time -Wendif-labels -Werror=format=2 -Werror=format-signedness -Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-pointer-types -Werror=int-conversion -Werror=missing-declarations -Werror=missing-prototypes -Werror=overflow -Werror=override-init -Werror=return-type -Werror=shift-count-overflow -Werror=shift-overflow=2 -Werror=undef -Wfloat-equal -Wimplicit-fallthrough=5 -Winit-self -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-aliasing=2 -Wstrict-prototypes -Wsuggest-attribute=noreturn -Wunused-function -Wwrite-strings -Wzero-length-bounds -fdiagnostics-show-option -fno-common -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -Wno-unused-result -Werror=shadow -fno-strict-aliasing -fvisibility=hidden -fno-omit-frame-pointer -include config.h -pthread -MD -MQ udevadm.p/src_udev_udevd.c.o -MF udevadm.p/src_udev_udevd.c.o.d -o udevadm.p/src_udev_udevd.c.o -c ../src/udev/udevd.c
../src/udev/udevd.c: In function ‘run_udevd’:
../src/udev/udevd.c:67:23: error: implicit declaration of function ‘fork’ [-Werror=implicit-function-declaration]
   67 |                 pid = fork();
      |                       ^~~~
../src/udev/udevd.c:75:24: error: implicit declaration of function ‘setsid’; did you mean ‘setbit’? [-Werror=implicit-function-declaration]
   75 |                 (void) setsid();
      |                        ^~~~~~
      |                        setbit
../src/udev/udevd.c:75:24: warning: nested extern declaration of ‘setsid’ [-Wnested-externs]
```

Follow-up for 394a678aec3b8bba0f0b1a8d7b9427c62468fe68

10 months agovmspawn-register: add missing header for glibc < 2.34
Antonio Alvarez Feijoo [Thu, 26 Dec 2024 10:02:34 +0000 (11:02 +0100)] 
vmspawn-register: add missing header for glibc < 2.34

Fixes #35755

10 months agoman: grammar fixes for userdbctl(1) 35753/head
Jan Engelhardt [Wed, 25 Dec 2024 15:08:49 +0000 (16:08 +0100)] 
man: grammar fixes for userdbctl(1)

10 months agoman: grammar fixes for varlinkctl(1)
Jan Engelhardt [Wed, 25 Dec 2024 11:30:47 +0000 (12:30 +0100)] 
man: grammar fixes for varlinkctl(1)

Fix some missing commas, missing conjunction words, wrong
inflections, and trim excess parenthesizing.

10 months agoman: grammar fixes for introductory adverbs/phrases
Jan Engelhardt [Wed, 25 Dec 2024 16:07:17 +0000 (17:07 +0100)] 
man: grammar fixes for introductory adverbs/phrases

10 months agoman: expand word contractions
Jan Engelhardt [Wed, 25 Dec 2024 15:13:02 +0000 (16:13 +0100)] 
man: expand word contractions

For written text, contractions are not normally used.

10 months agoman: grammar fixes for "regardless"
Jan Engelhardt [Wed, 25 Dec 2024 15:59:15 +0000 (16:59 +0100)] 
man: grammar fixes for "regardless"

10 months agoman: grammar fixes: replace "respectively"
Jan Engelhardt [Wed, 25 Dec 2024 11:28:04 +0000 (12:28 +0100)] 
man: grammar fixes: replace "respectively"

Unlike the German "bzw.", "respectively" cannot be used as an infix,
and is not abbreviated either.

10 months agoptyfwd: try to drain on exit only once 35752/head
Yu Watanabe [Wed, 25 Dec 2024 08:38:54 +0000 (17:38 +0900)] 
ptyfwd: try to drain on exit only once

Reading or writing a fd may fail with EBUSY, and the loop might run
without doing mostly nothing and the event loop may finish with ELOOP.

10 months agoptyfwd,run: process remaining outputs in IO event sources
Yu Watanabe [Wed, 25 Dec 2024 08:40:04 +0000 (17:40 +0900)] 
ptyfwd,run: process remaining outputs in IO event sources

This partially reverts 12807b5a49d1fe60434d473afe11ff81a4c92306.

Otherwise, reading or writing a fd in on_exit_event() handler may return
EBUSY, and the event loop may finish with -ELOOP.

Also, this makes drained() returns true if the PTY forwarder is already
disconnected, for safety. Hence, it is not necessary to re-introduce
pty_forward_is_done().

10 months agoptyfwd: fix infinite loop
Yu Watanabe [Wed, 25 Dec 2024 05:10:11 +0000 (14:10 +0900)] 
ptyfwd: fix infinite loop

This makes we exit from the loop in do_shovel() when
PTYForward.out_buffer_write_len is zero but PTYForward.out_buffer_full
is non-zero.

Fixes a bug introduced by 5e6a48bf99d2adb3c9d22414197a593f2aa8a121.
Fixes #35746.

10 months agoDrop legacy glibc version check and inclusion of linux/memfd.h (#35748)
Yu Watanabe [Wed, 25 Dec 2024 04:58:02 +0000 (13:58 +0900)] 
Drop legacy glibc version check and inclusion of linux/memfd.h (#35748)

10 months agodocs: Explicitly mention ~/.local/bin in section on installing mkosi
Daan De Meyer [Mon, 23 Dec 2024 20:30:32 +0000 (21:30 +0100)] 
docs: Explicitly mention ~/.local/bin in section on installing mkosi

10 months agodocs: Use meson compile instead of ninja
Daan De Meyer [Tue, 24 Dec 2024 08:53:53 +0000 (09:53 +0100)] 
docs: Use meson compile instead of ninja

"ninja -C build mkosi" doesn't actually work and fails because ninja
thinks the mkosi target does not exist. "meson compile -C build mkosi"
dpes work so let's use that instead.

Fixes #35741

10 months agopo: Translated using Weblate (Italian)
Salvatore Cocuzza [Tue, 24 Dec 2024 03:29:00 +0000 (04:29 +0100)] 
po: Translated using Weblate (Italian)

Currently translated at 100.0% (257 of 257 strings)

Co-authored-by: Salvatore Cocuzza <info@salvatorecocuzza.it>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/it/
Translation: systemd/main