]> git.ipfire.org Git - thirdparty/suricata.git/log
thirdparty/suricata.git
12 years agoFix luajit compilation failure introduced by the transaction update. 370/head
Anoop Saldanha [Fri, 17 May 2013 10:51:54 +0000 (16:21 +0530)] 
Fix luajit compilation failure introduced by the transaction update.
Fix coverity lock issues reported by transaction update as well.

12 years agoTransaction engine redesigned.
Anoop Saldanha [Fri, 3 May 2013 15:04:58 +0000 (20:34 +0530)] 
Transaction engine redesigned.

Improved accuracy, improved performance.  Performance improvement
noticeable with http heavy traffic and ruleset.

A lot of other cosmetic changes carried out as well.  Wrappers introduced
for a lot of app layer functions.

Failing dce unittests disabled.  Will be reintroduced in the updated dce
engine.

Cross transaction matching taken care of.  FPs emanating from these
matches have now disappeared.  Double inspection of transactions taken
care of as well.

12 years agoTrack transaction progress separately for each direction in libhtp.
Anoop Saldanha [Fri, 3 May 2013 04:33:48 +0000 (10:03 +0530)] 
Track transaction progress separately for each direction in libhtp.

Currently libhtp tracks it using the same var.  This can lead to misleading
states, since a response can come in without a full request.

12 years agohsbd mpm and packet mpm share same mpm ctx id.
Anoop Saldanha [Fri, 12 Apr 2013 07:48:17 +0000 (13:18 +0530)] 
hsbd mpm and packet mpm share same mpm ctx id.

This is a bug emanating from we having a var reference for hsbd mpm,
but failing to initialize it, and we default to using the packet mpm.

12 years agococcinelle: update pkt not set test 361/head
Eric Leblond [Thu, 16 May 2013 08:22:27 +0000 (10:22 +0200)] 
coccinelle: update pkt not set test

This patch updates the test to add the support of initialization
of a Packet via the INITIALIZE macro.

12 years agoPreserve PKT_ALLOC flag inside PACKET_RECYCLE().
Ken Steele [Tue, 14 May 2013 19:38:00 +0000 (15:38 -0400)] 
Preserve PKT_ALLOC flag inside PACKET_RECYCLE().

The PKT_ALLOC flag was being cleared by PACKET_RECYCLE(), which could
then result in a packet being pushed back to the Packet ring buffer
incorrectly.

12 years agoMove memset() out of PACKET_INITIALIZE()
Ken Steele [Tue, 14 May 2013 19:00:21 +0000 (15:00 -0400)] 
Move memset() out of PACKET_INITIALIZE()

The memset() inside PACKET_INITIALIZE() is redundant in some cases and
it is cleaner to do as part of the memory allocation. This simplifies
changes for integrating Tilera mPIPE support because the size of memory
cleared in that case is different from SIZE_OF_PACKET.

For the cases where Packets are directly allocated and then call
PACKET_INITIALIZE() without memset() first, this patch adds memset() calls.

A further change would use GetPacketFromAlloc() directly.

12 years agoMove fallback to CLS detection to configure script.
Victor Julien [Wed, 8 May 2013 12:51:15 +0000 (14:51 +0200)] 
Move fallback to CLS detection to configure script.

12 years agoFix CLS detection on systems that have getconf, but don't support the LEVEL1_DCACHE_L...
Victor Julien [Wed, 8 May 2013 10:41:10 +0000 (12:41 +0200)] 
Fix CLS detection on systems that have getconf, but don't support the LEVEL1_DCACHE_LINESIZE option.

12 years agoDetect L1 cache line size at build time. Fall back to 64 bytes if detection failed.
Victor Julien [Tue, 7 May 2013 12:41:36 +0000 (14:41 +0200)] 
Detect L1 cache line size at build time. Fall back to 64 bytes if detection failed.

12 years agoNFQ: convert batchcount related yaml errors to warnings.
Victor Julien [Mon, 6 May 2013 09:31:24 +0000 (11:31 +0200)] 
NFQ: convert batchcount related yaml errors to warnings.

12 years agoNFQ: fix configure check for finding out signed/unsigned args for nfq_get_payload
Victor Julien [Mon, 6 May 2013 09:10:11 +0000 (11:10 +0200)] 
NFQ: fix configure check for finding out signed/unsigned args for nfq_get_payload

12 years agonfq: add errno display when verdict fail 348/head
Eric Leblond [Thu, 24 Jan 2013 21:37:39 +0000 (22:37 +0100)] 
nfq: add errno display when verdict fail

In case of error, errno is set by sendmsg which is called by
nfnetlink and which is called by libnetfilter_queue. This patch
displays the string expression of errno if verdict has failed.

12 years agonfq: add support for batch verdicts
Florian Westphal [Wed, 16 Jan 2013 12:05:48 +0000 (13:05 +0100)] 
nfq: add support for batch verdicts

Normally, there is one verdict per packet, i.e., we receive a packet,
process it, and then tell the kernel what to do with that packet (eg.
DROP or ACCEPT).

recv(), packet id x
send verdict v, packet id x
recv(), packet id x+1
send verdict v, packet id x+1
[..]
recv(), packet id x+n
send verdict v, packet id x+n

An alternative is to process several packets from the queue, and then send
a batch-verdict.

recv(), packet id x
recv(), packet id x+1
[..]
recv(), packet id x+n
send batch verdict v, packet id x+n

A batch verdict affects all previous packets (packet_id <= x+n),
we thus only need to remember the last packet_id seen.

Caveats:
- can't modify payload
- verdict is applied to all packets
- nfmark (if set) will be set for all packets
- increases latency (packets remain queued by the kernel
  until batch verdict is sent).

To solve this, we only defer verdict for up to 20 packets and
send pending batch-verdict immediately if:
- no packets are currently queue
- current packet should be dropped
- current packet has different nfmark
- payload of packet was modified

This patch adds a configurable batch verdict support for workers runmode.
The batch verdicts are turned off by default.

Problem is that batch verdicts only work with kernels >= 3.1, i.e.
using newer libnetfilter_queue with an old kernel means non-working
suricata. So the functionnality has to be disabled by default.

12 years agonfq: avoid extra copy when running in workers mode
Florian Westphal [Wed, 16 Jan 2013 11:56:44 +0000 (12:56 +0100)] 
nfq: avoid extra copy when running in workers mode

currently, the packet payload recv()d from the nfqueue netlink
socket is copied into a new packet buffer.

This is required because the recv-buffer space used is tied
to the current thread, but a packet may be handed off to other
threads, and the recv-buffer can be re-used while the packet
is handled by another thread.

However, in worker runmode, the packet will always be handled
by the current thread, and the recv-buffer will only be reused
after the entire packet processing stack is done with the packet.

Thus, in worker runmode, we can avoid the copy and assign
the packet data area directly.

12 years agoalert-debuglog: cleanup TCP check
Victor Julien [Tue, 23 Apr 2013 14:09:01 +0000 (16:09 +0200)] 
alert-debuglog: cleanup TCP check

12 years agounified2: more udp fixes
Victor Julien [Tue, 23 Apr 2013 14:08:16 +0000 (16:08 +0200)] 
unified2: more udp fixes

12 years agoprofiling: enabled app layer profiling for UDP app layer modules
Victor Julien [Sat, 20 Apr 2013 09:41:49 +0000 (11:41 +0200)] 
profiling: enabled app layer profiling for UDP app layer modules

12 years agoprelude: only call stream callback for TCP
Victor Julien [Mon, 22 Apr 2013 09:04:24 +0000 (11:04 +0200)] 
prelude: only call stream callback for TCP

12 years agounified2: only call stream callback for TCP
Victor Julien [Mon, 22 Apr 2013 09:04:10 +0000 (11:04 +0200)] 
unified2: only call stream callback for TCP

12 years agoSuppress warnings when StreamSegmentForEach is called for UDP or SCTP, unless debug...
Victor Julien [Mon, 22 Apr 2013 09:03:32 +0000 (11:03 +0200)] 
Suppress warnings when StreamSegmentForEach is called for UDP or SCTP, unless debug is compiled in.

12 years agoUDP: inspection app layer state as soon as we have it.
Victor Julien [Mon, 22 Apr 2013 08:42:50 +0000 (10:42 +0200)] 
UDP: inspection app layer state as soon as we have it.

12 years agoBug 780 unittests, showing no problem.
Victor Julien [Fri, 19 Apr 2013 13:08:43 +0000 (15:08 +0200)] 
Bug 780 unittests, showing no problem.

12 years agoBug 794: stream SACK list needs to respect memcap
Victor Julien [Fri, 19 Apr 2013 13:28:13 +0000 (15:28 +0200)] 
Bug 794: stream SACK list needs to respect memcap

12 years agostream: default 'random' setting when running unittests is disabled, so that test...
Victor Julien [Fri, 19 Apr 2013 10:15:57 +0000 (12:15 +0200)] 
stream: default 'random' setting when running unittests is disabled, so that test results are predictable.

12 years agostreaming: randomize chunk size
Eric Leblond [Wed, 27 Mar 2013 13:08:37 +0000 (14:08 +0100)] 
streaming: randomize chunk size

By randomizing chunk size around the choosen value, it is possible
to escape some evasion technics that are using the fact they know
chunk size to split the attack at the correct place.
This patch activates randomization by default and set the random
interval to chunk size value +- 10%.

12 years agoUpdate DetectContentDataParse to reflect the actual data types content uses.
Victor Julien [Fri, 19 Apr 2013 09:24:20 +0000 (11:24 +0200)] 
Update DetectContentDataParse to reflect the actual data types content uses.

12 years agoRemove filemagic debug statement
Victor Julien [Fri, 19 Apr 2013 09:12:37 +0000 (11:12 +0200)] 
Remove filemagic debug statement

12 years agoRemove obsolete DetectParseContentString function, it has been replaced by DetectCont...
Victor Julien [Fri, 19 Apr 2013 09:07:18 +0000 (11:07 +0200)] 
Remove obsolete DetectParseContentString function, it has been replaced by DetectContentDataParse

12 years agofile: make fileext, filename and filemagic use the same rule parsing function as...
Victor Julien [Fri, 19 Apr 2013 09:04:00 +0000 (11:04 +0200)] 
file: make fileext, filename and filemagic use the same rule parsing function as others. This has as a side effect that we enforce doubly qouted values now.

12 years agoflowvar: cleanup keyword argument parsing. Should also address Coverity 400655.
Victor Julien [Fri, 19 Apr 2013 08:38:51 +0000 (10:38 +0200)] 
flowvar: cleanup keyword argument parsing. Should also address Coverity 400655.

12 years agoCoverity 1005134: fix minor memory leak on flowvar rule setup errors.
Victor Julien [Fri, 19 Apr 2013 08:05:38 +0000 (10:05 +0200)] 
Coverity 1005134: fix minor memory leak on flowvar rule setup errors.

12 years agoCoverity 1005133: fix unlikely case where malformed pcre statement in rule would...
Victor Julien [Fri, 19 Apr 2013 08:02:36 +0000 (10:02 +0200)] 
Coverity 1005133: fix unlikely case where malformed pcre statement in rule would lead to null-deref.

12 years agostream: handle extra different SYN/ACK
Victor Julien [Sat, 6 Apr 2013 18:54:25 +0000 (20:54 +0200)] 
stream: handle extra different SYN/ACK

Until now, when processing the TCP 3 way handshake (3whs), retransmissions
of SYN/ACKs are silently accepted, unless they are different somehow. If
the SEQ or ACK values are different they are considered wrong and events
are set. The stream events rules will match on this.

In some cases, this is wrong. If the client missed the SYN/ACK, the server
may send a different one with a different SEQ. This commit deals with this.

As it is impossible to predict which one the client will accept, each is
added to a list. Then on receiving the final ACK from the 3whs, the list
is checked and the state is updated according to the queued SYN/ACK.

12 years agoflowvar: clean up properly on signature clean up.
Victor Julien [Wed, 17 Apr 2013 09:58:00 +0000 (11:58 +0200)] 
flowvar: clean up properly on signature clean up.

12 years agoflowvar: add unittests for #802.
Victor Julien [Wed, 17 Apr 2013 09:05:08 +0000 (11:05 +0200)] 
flowvar: add unittests for #802.

12 years agoflowvar: fix deadlock with http buffers
Victor Julien [Tue, 16 Apr 2013 19:47:42 +0000 (21:47 +0200)] 
flowvar: fix deadlock with http buffers

Bug #802

Flowvars are set from pcre, and lock the flow when being set. However
when HTTP buffers were inspected, flow was already locked: deadlock.

This patch introduces a post-match list in the detection engine thread
ctx, where store candidates are kept. Then a post-match function is used
to finalize the storing if the rule matches.

Solves the deadlock and brings the handling of flowvars more in line
with flowbits and flowints.

12 years agoflowvars: update funcs to accept u16 id
Victor Julien [Tue, 16 Apr 2013 12:53:23 +0000 (14:53 +0200)] 
flowvars: update funcs to accept u16 id

All id's are u16, but flowvar functions would only accept u8.

Minor cleanups.

12 years agoprofiling: add formatted totals, percents to packet stats
Victor Julien [Thu, 11 Apr 2013 12:59:03 +0000 (14:59 +0200)] 
profiling: add formatted totals, percents to packet stats

12 years agoMinor SigValidate cleanup
Victor Julien [Fri, 12 Apr 2013 08:45:54 +0000 (10:45 +0200)] 
Minor SigValidate cleanup

12 years agoUpdate the way we handle http_host keywords.
Anoop Saldanha [Wed, 27 Mar 2013 09:25:05 +0000 (14:55 +0530)] 
Update the way we handle http_host keywords.

Previously we would have forced all users to use nocase with http_host
keywords(since the hostname buffer is lowercase).

We now error out on sigs that has nocase set with http_host set.  Also if
the http_host pattern or http_host pcre has an uppercase character set, we
invalidate such sigs.  Unittests also updated to reflect the above change.

12 years agoMinor reshuffling of Signature struct.
Victor Julien [Wed, 10 Apr 2013 08:51:00 +0000 (10:51 +0200)] 
Minor reshuffling of Signature struct.

12 years agoUse define instead of magic number for pmq's per detect thread
Victor Julien [Wed, 10 Apr 2013 08:30:48 +0000 (10:30 +0200)] 
Use define instead of magic number for pmq's per detect thread

12 years agodetection engine: consolidate thread setup
Victor Julien [Wed, 10 Apr 2013 08:22:32 +0000 (10:22 +0200)] 
detection engine: consolidate thread setup

DetectEngineThreadCtxInit and DetectEngineThreadCtxInitForLiveRuleSwap did
pretty much the same thing, except for a counters registration. As can be
predicted with code duplication like this, things got out of sync. To make
sure this doesn't happen again, I created a helper function that does the
heavy lifting in this function.

12 years agoFix PmqSetup calls in Liveswap thread init. Func was out of sync with normal thread...
Victor Julien [Wed, 10 Apr 2013 08:06:30 +0000 (10:06 +0200)] 
Fix PmqSetup calls in Liveswap thread init. Func was out of sync with normal thread init.

12 years agoUpdate comment in yaml to indicate size limit for the following vars -
Anoop Saldanha [Tue, 19 Mar 2013 12:49:15 +0000 (18:19 +0530)] 
Update comment in yaml to indicate size limit for the following vars -
stream.reassembly.toserver-chunk-size and stream.reassembly.toclient-chunk-size

12 years agococcinelle: add tcp flag check 341/head
Eric Leblond [Mon, 8 Apr 2013 17:16:31 +0000 (19:16 +0200)] 
coccinelle: add tcp flag check

The different TCP related structures have all a flags field and its
value must match the type of structure. This patch adds a check
alerting on invalid value usage.

12 years agostream: intro function for SYN/ACK state update
Victor Julien [Sat, 6 Apr 2013 15:52:44 +0000 (17:52 +0200)] 
stream: intro function for SYN/ACK state update

As the TCP SSN state can be updated from several points in the state
machine on accepting a SYN/ACK, move the update logic into a separate
function.

12 years agostream: remove unused 'pause' feature
Victor Julien [Sat, 6 Apr 2013 15:40:13 +0000 (17:40 +0200)] 
stream: remove unused 'pause' feature

12 years agostream: zero ts is a per stream flag
Victor Julien [Sat, 6 Apr 2013 15:26:33 +0000 (17:26 +0200)] 
stream: zero ts is a per stream flag

Ssn flag STREAMTCP_FLAG_ZERO_TIMESTAMP was used in stream only. Due to
it's value it did not conflict with a real stream flag. Renamed it to
STREAMTCP_STREAM_FLAG_ZERO_TIMESTAMP.

12 years agostream: don't use ssn timestamp flag in stream
Victor Julien [Sat, 6 Apr 2013 15:17:15 +0000 (17:17 +0200)] 
stream: don't use ssn timestamp flag in stream

The STREAMTCP_FLAG_TIMESTAMP flag is a ssn flag, however it was used in
the stream flag field. As it has the same value as
STREAMTCP_STREAM_FLAG_DEPTH_REACHED it's possible that stream reassembly
got confused by the timestamp.

12 years agoChange logic of SCErrorToString causing any missing entries to result in a compiler...
Victor Julien [Mon, 21 Jan 2013 14:49:15 +0000 (15:49 +0100)] 
Change logic of SCErrorToString causing any missing entries to result in a compiler warning.

12 years agoHandle the case of pcre combined with a relative content, where pcre has the
Anoop Saldanha [Wed, 27 Mar 2013 12:27:55 +0000 (17:57 +0530)] 
Handle the case of pcre combined with a relative content, where pcre has the
set to match from start of line and we discontinue matching on not finding
match.

12 years agounittest to display #784.
Anoop Saldanha [Tue, 26 Mar 2013 07:50:54 +0000 (13:20 +0530)] 
unittest to display #784.

12 years agoDon't try to sniff 'default' interface
Eric Leblond [Tue, 26 Mar 2013 17:24:46 +0000 (18:24 +0100)] 
Don't try to sniff 'default' interface

Whan running suricata via 'suricata --af-packet', the list of interfaces
was containing the 'default' interface and sniffing it was attempted.
This was not wanted.

12 years agobpf filter: use SCLogError instead of fprintf
Eric Leblond [Tue, 26 Mar 2013 16:59:35 +0000 (17:59 +0100)] 
bpf filter: use SCLogError instead of fprintf

12 years agoaf-packet: warn about BPF filter consequence in IPS mode
Eric Leblond [Tue, 26 Mar 2013 15:32:36 +0000 (16:32 +0100)] 
af-packet: warn about BPF filter consequence in IPS mode

This patch add a message to warn user about the impact of using a
BPF filter in IPS mode.

12 years agoExit if bpf is used in IPS mode
Eric Leblond [Tue, 26 Mar 2013 13:16:23 +0000 (14:16 +0100)] 
Exit if bpf is used in IPS mode

12 years agoconfigure: use correct syntax for help string 332/head
Eric Leblond [Tue, 26 Mar 2013 11:17:28 +0000 (12:17 +0100)] 
configure: use correct syntax for help string

12 years agoconfigure: add --enable-unix-socket flag
Eric Leblond [Tue, 26 Mar 2013 11:05:11 +0000 (12:05 +0100)] 
configure: add --enable-unix-socket flag

This new flag allows the user to force unix socket build or to
disallow it completely. Default which is test is maintained.

12 years agojansson: change function test to be sure of version
Eric Leblond [Mon, 18 Mar 2013 22:08:18 +0000 (23:08 +0100)] 
jansson: change function test to be sure of version

12 years agoUpdate version number of bundled htp to 0.2.12, so it matches the non-bundled version.
Victor Julien [Mon, 25 Mar 2013 18:38:56 +0000 (19:38 +0100)] 
Update version number of bundled htp to 0.2.12, so it matches the non-bundled version.

12 years agoAfter some discussion we decided that var declarations inside a for statement are...
Victor Julien [Wed, 20 Mar 2013 16:18:38 +0000 (17:18 +0100)] 
After some discussion we decided that var declarations inside a for statement are not in line with our coding style. So removing a bunch. Decision was not unanimous ^^.

12 years agoLive rule swap logs added to report SigLoadSignatures() failure. Also set
Anoop Saldanha [Wed, 20 Mar 2013 12:49:25 +0000 (18:19 +0530)] 
Live rule swap logs added to report SigLoadSignatures() failure. Also set
thread_closed flag on exit for live swap thread.

12 years agoMinor fixes against the last set of patches for #564, 565, 581 + fp automation.
Anoop Saldanha [Wed, 20 Mar 2013 12:47:42 +0000 (18:17 +0530)] 
Minor fixes against the last set of patches for #564, 565, 581 + fp automation.

Rename struct DetectFigureFPAndId_t_ to DetectFPAndItsId_ and move it's
definition from inside the function where it's used to the global namespace,
as requested on #suricata.

Rename DetectEngineContentModifiedBufferSetup to DetectEngineContentModifierBufferSetup.

Also rename DetectFigureFPAndId() to DetectSetFastPatternAndItsId().

Updated DetectSetFastPatternAndItsId() to not exit on failure and return error.

12 years agofix for #564.
Anoop Saldanha [Sun, 3 Mar 2013 12:19:03 +0000 (17:49 +0530)] 
fix for #564.

Get rid of the hash table, and use a single-one_time_alloc'ed array for
pattern id assignment.

12 years agoWe now print content flags in engine fp analyzer.
Anoop Saldanha [Sat, 2 Mar 2013 20:13:49 +0000 (01:43 +0530)] 
We now print content flags in engine fp analyzer.

12 years agoWe now assign ids to fp patterns only. Rest of them don't need one.
Anoop Saldanha [Fri, 1 Mar 2013 14:41:06 +0000 (20:11 +0530)] 
We now assign ids to fp patterns only.  Rest of them don't need one.

12 years agoUpdate content id assignment.
Anoop Saldanha [Fri, 1 Mar 2013 11:12:08 +0000 (16:42 +0530)] 
Update content id assignment.

All fp id assignment now happens in one go.
Also noticing a slight perf increase, probably emanating from improved cache
perf.
Removed irrelevant unittests as well.

12 years agoFigure out sig fp during validation stage, instead of staging stage.
Anoop Saldanha [Fri, 1 Mar 2013 08:21:14 +0000 (13:51 +0530)] 
Figure out sig fp during validation stage, instead of staging stage.

12 years agoEnable a conf option to enable/disable legacy keywords.
Anoop Saldanha [Fri, 1 Mar 2013 06:19:27 +0000 (11:49 +0530)] 
Enable a conf option to enable/disable legacy keywords.

Currently, uricontent is declared a legacy keyword, and is enabled by default.

12 years agoFast pattern setup now configurable in our code.
Anoop Saldanha [Fri, 1 Mar 2013 03:48:52 +0000 (09:18 +0530)] 
Fast pattern setup now configurable in our code.

You can either enable/disable fp for a particular type + set priority.

12 years agoDetect sm_list rearranged for performance reasons.
Anoop Saldanha [Thu, 28 Feb 2013 13:06:09 +0000 (18:36 +0530)] 
Detect sm_list rearranged for performance reasons.

12 years agoFurther customize content modifier buffer registration.
Anoop Saldanha [Thu, 28 Feb 2013 10:51:43 +0000 (16:21 +0530)] 
Further customize content modifier buffer registration.

Allow modifier setups functions to have CustomCallbacks to enable their
internal conditions.

12 years agohttp_* setup unified.
Anoop Saldanha [Thu, 28 Feb 2013 06:58:52 +0000 (12:28 +0530)] 
http_* setup unified.

12 years agouricontent simplified to use the existing content + http_uri infrastructure.
Anoop Saldanha [Sun, 24 Feb 2013 14:53:41 +0000 (20:23 +0530)] 
uricontent simplified to use the existing content + http_uri infrastructure.

12 years agocode cleanup for all content based keywords.
Anoop Saldanha [Sat, 23 Feb 2013 10:06:00 +0000 (15:36 +0530)] 
code cleanup for all content based keywords.

12 years agoturn dce_stub_data into a sticky buffer.
Anoop Saldanha [Fri, 22 Feb 2013 18:30:18 +0000 (00:00 +0530)] 
turn dce_stub_data into a sticky buffer.

12 years agoAllow the use of relative without the presence of a related previous keyword.
Anoop Saldanha [Fri, 22 Feb 2013 13:13:41 +0000 (18:43 +0530)] 
Allow the use of relative without the presence of a related previous keyword.

12 years agotcp stream: don't move to LAST_ACK on toserver resent of FIN
Victor Julien [Tue, 19 Mar 2013 11:23:37 +0000 (12:23 +0100)] 
tcp stream: don't move to LAST_ACK on toserver resent of FIN

12 years agoCoverity 989710 and 989711: small recourse leaks in filemd5 parsing code.
Victor Julien [Wed, 13 Mar 2013 09:16:15 +0000 (10:16 +0100)] 
Coverity 989710 and 989711: small recourse leaks in filemd5 parsing code.

12 years agofix for #770.
Anoop Saldanha [Tue, 12 Mar 2013 06:39:31 +0000 (12:09 +0530)] 
fix for #770.

Invalidate sigs with negative depth.

12 years agofix for #771. 315/head
Anoop Saldanha [Tue, 12 Mar 2013 03:04:33 +0000 (08:34 +0530)] 
fix for #771.

Fix /etc/protocols parsing.  Remove trailing newspace stored under some cases.

12 years agoIf an IP-only pass rule matches, set the no inspect flag for that flow. Bug #718.
Victor Julien [Tue, 15 Jan 2013 11:55:31 +0000 (12:55 +0100)] 
If an IP-only pass rule matches, set the no inspect flag for that flow. Bug #718.

12 years agofix for #769.
Anoop Saldanha [Thu, 7 Mar 2013 11:08:16 +0000 (16:38 +0530)] 
fix for #769.

Packet inserted by live swap flagged as pseudo packet.

12 years agoFix valgrind error/warning in ip reputation parsing code
Victor Julien [Thu, 7 Mar 2013 16:23:26 +0000 (17:23 +0100)] 
Fix valgrind error/warning in ip reputation parsing code

12 years agofix for #758. Add redmine wiki link and desc for icmp-id keyword.
Anoop Saldanha [Fri, 1 Mar 2013 15:18:28 +0000 (20:48 +0530)] 
fix for #758.  Add redmine wiki link and desc for icmp-id keyword.

12 years agoTry to use pkg-config to resolve libnspr and related dependencies.
Victor Julien [Thu, 7 Mar 2013 14:56:54 +0000 (15:56 +0100)] 
Try to use pkg-config to resolve libnspr and related dependencies.

12 years agoTry to use pkg-config to resolve libnss and related dependencies.
Christian Kreibich [Tue, 15 Jan 2013 08:23:53 +0000 (00:23 -0800)] 
Try to use pkg-config to resolve libnss and related dependencies.

12 years agoOpen 2.0 dev branch
Victor Julien [Thu, 7 Mar 2013 12:55:01 +0000 (13:55 +0100)] 
Open 2.0 dev branch

12 years agonfq: add missing error string
Victor Julien [Thu, 20 Dec 2012 09:46:06 +0000 (10:46 +0100)] 
nfq: add missing error string

12 years agoFix potential Null deref.
Eric Leblond [Wed, 6 Mar 2013 15:15:16 +0000 (16:15 +0100)] 
Fix potential Null deref.

12 years agoFix potential iprep file parsing issue (2).
Victor Julien [Wed, 6 Mar 2013 14:35:25 +0000 (15:35 +0100)] 
Fix potential iprep file parsing issue (2).

12 years agoFix potential iprep file parsing issue.
Victor Julien [Wed, 6 Mar 2013 14:32:53 +0000 (15:32 +0100)] 
Fix potential iprep file parsing issue.

12 years agoFix test AddressTestParse36 on Big Endian systems
Victor Julien [Fri, 1 Mar 2013 13:02:55 +0000 (14:02 +0100)] 
Fix test AddressTestParse36 on Big Endian systems

12 years agofix for #760.
Anoop Saldanha [Sat, 2 Mar 2013 14:08:49 +0000 (19:38 +0530)] 
fix for #760.

If udpv4 csum isn't calculated, udpv4-csum detection shouldn't run on the
csum.

12 years agofix for #725.
Anoop Saldanha [Mon, 21 Jan 2013 06:38:25 +0000 (12:08 +0530)] 
fix for #725.

Update trec_len, trec_pos to 32 bits from 16 bits.
Handle handshakes that are fragmented across records.

12 years agotemporarily patched smb + dcerpc parsers for direction demaraction.
Anoop Saldanha [Wed, 27 Feb 2013 15:21:36 +0000 (20:51 +0530)] 
temporarily patched smb + dcerpc parsers for direction demaraction.

12 years agopcap-file: treat the case of unsupported pcap link
Eric Leblond [Thu, 28 Feb 2013 15:52:43 +0000 (16:52 +0100)] 
pcap-file: treat the case of unsupported pcap link

In unix socket mode, Suricata was stopping processing pcap files
when a pcap file with an unsupported datalink was treated. This
patch updates error handling to allow Suricata to treat other
pcap files.

12 years agoaf-packet: leave reading loop at each turn
Eric Leblond [Mon, 25 Feb 2013 13:57:55 +0000 (14:57 +0100)] 
af-packet: leave reading loop at each turn

The idea of this patch is to be sure to leave the ring reading loop
enough to be able to sync counters. This should fix #706.