]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
4 days agobpf-restrict-fs: use a 32-bit magic key on big-endian too 42840/head
Luca Boccassi [Wed, 1 Jul 2026 16:03:06 +0000 (17:03 +0100)] 
bpf-restrict-fs: use a 32-bit magic key on big-endian too

The inner map is created with a uint32_t key, but the update passed
&magic[i] where magic is a (possibly 64-bit) statfs_f_type_t. On
little-endian the low 32 bits happen to be read; on big-endian 64-bit
(s390x, ppc64 BE) the zero high word is read instead, so every
filesystem collides on key 0 (the allow/deny selector) and
RestrictFileSystems= is silently broken. Pass a truncated copy.

Follow-up for 184b4f78cfbded54a6e06bbe1152256c204a7a73

4 days agocore/scope: don't assert when start is retried during cgroup chown
Luca Boccassi [Wed, 1 Jul 2026 16:01:27 +0000 (17:01 +0100)] 
core/scope: don't assert when start is retried during cgroup chown

While a delegated scope waits for the async cgroup chown helper it sits
in SCOPE_START_CHOWN (UNIT_ACTIVATING). unit_start() forwards to
->start() while activating, so scope_start() could be re-entered in
that state and trip assert(s->state == SCOPE_DEAD), aborting PID 1.
Treat SCOPE_START_CHOWN as already-starting instead.

Follow-up for 03860190fefce8bbea3a6f0e77919b882ade517c

4 days agocore: donate the fdset to do_reexecute() to avoid a double free
Luca Boccassi [Wed, 1 Jul 2026 15:59:43 +0000 (16:59 +0100)] 
core: donate the fdset to do_reexecute() to avoid a double free

do_reexecute() freed the FDSet on the switch-root/soft-reboot fallback
but the caller's copy stayed live, so main() freed it again if every
fallback exec then failed. Donate the fdset instead: pass it with
TAKE_PTR() and take ownership via a _cleanup_ local, freeing it exactly
once on every exit path.

Follow-up for 3c7878f94b02f65676889fa58a937ff4d4de4a4d

4 days agoshared/install: give the borrowed name back before bailing on error
Luca Boccassi [Wed, 1 Jul 2026 15:55:28 +0000 (16:55 +0100)] 
shared/install: give the borrowed name back before bailing on error

In the unmask path, when install_changes_add() fails the borrowed
*name was not handed back via TAKE_PTR() before returning, so
install_info_clear() freed the caller's strv entry, leaving a dangling
pointer that is double-freed at the caller's strv_free().

Follow-up for f31f10a6207efc9ae9e0b1f73975b5b610914017

4 days agoquotacheck: don't apply an invalid quotacheck.mode= value
Luca Boccassi [Wed, 1 Jul 2026 15:52:59 +0000 (16:52 +0100)] 
quotacheck: don't apply an invalid quotacheck.mode= value

quota_check_mode_from_string() returns -EINVAL on a bad value, storing
it in the global arg_mode. Only change arg_mode on success.

Follow-up for d73691c64e05650d838aaeb7da94fd8bdfb60907
Follow-up for dba4fe9a60e8876addcd6a597c9e1d5f529309ca

4 days agocore: avoid using uninitialized buffer on bad systemd.random_seed=
Luca Boccassi [Wed, 1 Jul 2026 15:45:34 +0000 (16:45 +0100)] 
core: avoid using uninitialized buffer on bad systemd.random_seed=

unbase64mem() leaves p/sz uninitialized on failure, and the
deserialization doesn't bail out in that case, unlike other cases.

Follow-up for d247f232a8fd68f91769274f196566a6e9e75d15

4 days agotpm2-setup: Create and persist an endorsement key
Chris Coulson [Tue, 2 Jun 2026 13:48:55 +0000 (14:48 +0100)] 
tpm2-setup: Create and persist an endorsement key

This updates systemd-tpm2-setup to create and persist an endorsement
key if there isn't one already. For each supported EK template profile,
it will read the EK certificate from its NV index if there is one.
When there is an EK certificate present, a primary key is created using
the corresponding template. If the resulting EKpub matches the public
key in the certificate, the created EK is persisted and the process is
complete.

The low-range templates and the high-range RSA 2048/3072 and ECC NIST
P256/P384 storage templates are supported, as detailed in section
5.3 of the "TCG EK Credential Profile For TPM Family 2.0" spec v2.7.
High-range templates are preferred because these permit EK usage without
requiring knowledge of the authorization value for the endorsement
hierarchy, meaning that, like with the SRK, it is possible to restrict
the usage of the endorsement hierarchy whilst still permitting use of
the persistent EK.

The EK is always persisted at handle 0x81010001. This handle is
reserved in Table 2 of the "TCG TPM v2.0 Provisioning Guidance" spec
v1.0r1.0, although this is only a recommendation. This
handle is within the block of handles reserved for endorsement
primary keys in the "Registry of Reserved TPM 2.0 Handles and
Localities" spec v1.2r1.00. Section 2.3.2 of this specification also
makes a suggestion that there should be a relationship between the EK
certificate NV index and a corresponding persistent EK handle by
using handles at the same offsets within their respective ranges.
However, this contradicts the provisioning guidance spec which reserves
0x81010001 when there isn't a certificate at 0x01c00001. For simplicity,
I've chosen to use a single handle for the EK regardless of which profile
it is created with.

The "TCG EK Credential Profile For TPM Family 2.0" spec also provides a
way for endorsement keys to be certified with non-standard templates by
storing the template in a NV index. This is also supported.

The EK creation is not executed with tpm2-setup --early, as there's no
need for it to be created so early, unlike with the SRK. I also haven't
stored EKpub in /var/lib/systemd like with the SRKpub, as I'm not sure
there will be a use case for this yet.

A follow-up PR may be needed to add some internal helpers to make use
of the persisted EK, as use of low-range EKs requires a policy session.
High-range EKs can be used with a HMAC session because they have the
userWithAuth attribute set and we are creating them with an empty
authorization value.

https://trustedcomputinggroup.org/resource/http-trustedcomputinggroup-org-wp-content-uploads-tcg-ek-credential-profile/
https://trustedcomputinggroup.org/resource/tcg-tpm-v2-0-provisioning-guidance/
https://trustedcomputinggroup.org/resource/registry/

4 days agocore: add absolute-path properties to varlink StartTransient
Michael Vogt [Thu, 21 May 2026 14:57:15 +0000 (16:57 +0200)] 
core: add absolute-path properties to varlink StartTransient

Similar to PR#42360 this commit adds missing properties for
absolute path handling in io.systemd.Unit.StartTransient for
the `Exec` context and a macro helper to share the common code.

The properties added are:
IPCNamespacePath, NetworkNamespacePath, RootDirectory, RootHashPath,
RootHashSignaturePath, RootImage, RootVerity, UserNamespacePath,
RootMStack.

Note that RootHashPath, RootHashSignaturePath need custom apply
functions because the varlink name "RootHashPath" differs from the
name that needs to be written into the unit file ("RootHash=")
and the iovec must be cleared.

4 days agopcrlock: add vl methods for fw and sb
Luca Boccassi [Tue, 30 Jun 2026 23:47:22 +0000 (00:47 +0100)] 
pcrlock: add vl methods for fw and sb

Add varlink method wrappers for locking/unlocking firmware code and config,
and secure boot policy and authority.

4 days agoAdd more shutdown timestamps and preserve via LUO (#42671)
Luca Boccassi [Wed, 1 Jul 2026 13:12:21 +0000 (14:12 +0100)] 
Add more shutdown timestamps and preserve via LUO (#42671)

Add more shutdown timestamps, export them via D-Bus/Varlink, use them in
`systemd-analyze time`, and preserve them across kexec via LUO. This is
useful to measure reboot performance with added measurement points and
more granular intervals.

4 days agobuild(deps): bump the actions group with 6 updates
dependabot[bot] [Wed, 1 Jul 2026 09:35:55 +0000 (09:35 +0000)] 
build(deps): bump the actions group with 6 updates

Bumps the actions group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [actions/checkout](https://github.com/actions/checkout) | `6.0.2` | `7.0.0` |
| [actions/setup-python](https://github.com/actions/setup-python) | `6.2.0` | `6.3.0` |
| [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) | `4.36.0` | `4.36.2` |
| [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) | `6.1.2` | `6.2.0` |
| [super-linter/super-linter/slim](https://github.com/super-linter/super-linter) | `8.6.0` | `8.7.0` |
| [softprops/action-gh-release](https://github.com/softprops/action-gh-release) | `3.0.0` | `3.0.1` |

Updates `actions/checkout` from 6.0.2 to 7.0.0
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/de0fac2e4500dabe0009e67214ff5f5447ce83dd...9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0)

Updates `actions/setup-python` from 6.2.0 to 6.3.0
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/a309ff8b426b58ec0e2a45f0f869d46889d02405...ece7cb06caefa5fff74198d8649806c4678c61a1)

Updates `github/codeql-action/upload-sarif` from 4.36.0 to 4.36.2
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/7211b7c8077ea37d8641b6271f6a365a22a5fbfa...8aad20d150bbac5944a9f9d289da16a4b0d87c1e)

Updates `aws-actions/configure-aws-credentials` from 6.1.2 to 6.2.0
- [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases)
- [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md)
- [Commits](https://github.com/aws-actions/configure-aws-credentials/compare/acca2b1b2070338fb9fd1ca27ecee81d687e58e5...e7f100cf4c008499ea8adda475de1042d6975c7b)

Updates `super-linter/super-linter/slim` from 8.6.0 to 8.7.0
- [Release notes](https://github.com/super-linter/super-linter/releases)
- [Changelog](https://github.com/super-linter/super-linter/blob/main/CHANGELOG.md)
- [Commits](https://github.com/super-linter/super-linter/compare/9e863354e3ff62e0727d37183162c4a88873df41...4ce20838b8ab83717e78138c5b3a1407148e0918)

Updates `softprops/action-gh-release` from 3.0.0 to 3.0.1
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](https://github.com/softprops/action-gh-release/compare/b4309332981a82ec1c5618f44dd2e27cc8bfbfda...718ea10b132b3b2eba29c1007bb80653f286566b)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 7.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: actions/setup-python
  dependency-version: 6.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
- dependency-name: github/codeql-action/upload-sarif
  dependency-version: 4.36.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
- dependency-name: aws-actions/configure-aws-credentials
  dependency-version: 6.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
- dependency-name: super-linter/super-linter/slim
  dependency-version: 8.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
- dependency-name: softprops/action-gh-release
  dependency-version: 3.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
4 days agocore: deserialize soft-reboot shutdown timestamps into previous-* fields 42671/head
Luca Boccassi [Fri, 26 Jun 2026 12:57:27 +0000 (13:57 +0100)] 
core: deserialize soft-reboot shutdown timestamps into previous-* fields

Until now the SHUTDOWN_START/FINISH timestamps were carried across a
soft-reboot in the same fields, so afterwards they described the
previous boot rather than the current one, mixing current- and
previous-boot data in the same set. Mirror what is now done on kexec
and move them into the PREVIOUS_SHUTDOWN_* fields on deserialization.

Also reset local timestamps for events that rerun (eg: generators,
units loading, etc) on soft-reboot and switch-root.

4 days agoAssorted hardening issues flagged by kres (#42802)
Luca Boccassi [Wed, 1 Jul 2026 09:39:04 +0000 (10:39 +0100)] 
Assorted hardening issues flagged by kres (#42802)

4 days agoman: update description for sd_device_enumerator_add_match_subsystem
Davis-Rippon [Wed, 1 Jul 2026 04:55:39 +0000 (14:55 +1000)] 
man: update description for sd_device_enumerator_add_match_subsystem

Signed-off-by: Davis-Rippon <drip0002@student.monash.edu>
5 days agotest: reduce number of disks in TEST-64-UDEV-STORAGE-simultaneous_events on Debian...
Nick Rosbrook [Fri, 26 Jun 2026 14:00:21 +0000 (10:00 -0400)] 
test: reduce number of disks in TEST-64-UDEV-STORAGE-simultaneous_events on Debian/Ubuntu

This test never finishes in Ubuntu autopkgtest with the current values,
and is currently skipped all together on Debian. When running on either,
reduce the number of disks to make the test more reliable.

5 days agoFix: exec invoke errno and resolvectl leak (#42812)
Luca Boccassi [Tue, 30 Jun 2026 13:03:08 +0000 (14:03 +0100)] 
Fix: exec invoke errno and resolvectl leak (#42812)

5 days agosd-journal: rate-limit tail timestamp refresh during iteration
dongshengyuan [Wed, 24 Jun 2026 05:01:32 +0000 (13:01 +0800)] 
sd-journal: rate-limit tail timestamp refresh during iteration

journal_file_read_tail_timestamp() is called unconditionally in
next_beyond_location() for every file on every iteration step,
resulting in O(N x files) volatile mmap reads. For large queries
like 'journalctl -n 1000000' this makes the command unusably slow
(~5 minutes on systems with many journal files).

Rather than suppressing the call entirely (which would make the
inotify path fully load-bearing for cross-boot ordering), rate-limit
it to at most once per second per file. This reduces the overhead
from O(N x files) to O(T x files) where T is the iteration time in
seconds, while still providing periodic refresh as a fallback for
any missed inotify events and keeping cross-boot ordering
reasonably fresh.

Embed a RateLimit struct in JournalFile for this purpose.

Measured improvement on a real system: 5:24 -> 2:39 (-51%) for
'journalctl -n 1000000'.

Fixes: #42521
Regression introduced in: #26355 (34af74946e)

Signed-off-by: dongshengyuan <dongshengyuan@uniontech.com>
5 days agoman: fix wrong KillUserProcesses= default in systemd-run(1)
Shihao Ren [Tue, 30 Jun 2026 06:18:14 +0000 (14:18 +0800)] 
man: fix wrong KillUserProcesses= default in systemd-run(1)

systemd-run(1) hard-coded "the default" wording for KillUserProcesses=, but the
actual compile-time default is determined by the -Ddefault-kill-user-processes=
meson build option, which distributions set differently at packaging time.

Consistent with logind.conf(5).

Fixes: #42805
Signed-off-by: Shihao Ren <renshihao.rsh@gmail.com>
5 days agoptyfwd: avoid touching forwarder after exit drain 42802/head
Luca Boccassi [Mon, 29 Jun 2026 17:07:01 +0000 (18:07 +0100)] 
ptyfwd: avoid touching forwarder after exit drain

on_exit_event() can synchronously drain buffered data through
shovel_force(). If that completes the drain, pty_forward_done() runs
the hangup handler and may free the forwarder, so do not call
pty_forward_done() again afterwards.

[   25.052879] TEST-74-AUX-UTILS.sh[909]: ==909==ERROR: AddressSanitizer: heap-use-after-free on address 0x7ccc8a5e0b41 at pc 0x7efc8cde106e bp 0x7ffd668629b0 sp 0x7ffd668629a8
[   25.053136] TEST-74-AUX-UTILS.sh[909]: READ of size 1 at 0x7ccc8a5e0b41 thread T0
[   25.092784] TEST-74-AUX-UTILS.sh[909]:     #0 0x7efc8cde106d in pty_forward_done ../src/src/shared/ptyfwd.c:187
[   25.093920] TEST-74-AUX-UTILS.sh[909]:     #1 0x7efc8cdedba1 in on_exit_event ../src/src/shared/ptyfwd.c:904
[   25.094148] TEST-74-AUX-UTILS.sh[909]:     #2 0x7efc8d375eff in source_dispatch ../src/src/libsystemd/sd-event/sd-event.c:4301
[   25.095074] TEST-74-AUX-UTILS.sh[909]:     #3 0x7efc8d378032 in dispatch_exit ../src/src/libsystemd/sd-event/sd-event.c:4431
[   25.095295] TEST-74-AUX-UTILS.sh[909]:     #4 0x7efc8d37e932 in sd_event_dispatch ../src/src/libsystemd/sd-event/sd-event.c:4896
[   25.095467] TEST-74-AUX-UTILS.sh[909]:     #5 0x7efc8d37fc8c in sd_event_run ../src/src/libsystemd/sd-event/sd-event.c:4971
[   25.095647] TEST-74-AUX-UTILS.sh[909]:     #6 0x7efc8d3800ad in sd_event_loop ../src/src/libsystemd/sd-event/sd-event.c:4992
[   25.097174] TEST-74-AUX-UTILS.sh[909]:     #7 0x56049b541aba in start_transient_service ../src/src/run/run.c:2479
[   25.097403] TEST-74-AUX-UTILS.sh[909]:     #8 0x56049b552a65 in run ../src/src/run/run.c:3288
[   25.097569] TEST-74-AUX-UTILS.sh[909]:     #9 0x56049b552cb0 in main ../src/src/run/run.c:3291
[   25.097780] TEST-74-AUX-UTILS.sh[909]:     #10 0x7efc8b882300 in __libc_start_call_main (/lib64/libc.so.6+0x7d300) (BuildId: 830c94f480c13d9b01dc65a1035310882136094a)
[   25.097952] TEST-74-AUX-UTILS.sh[909]:     #11 0x7efc8b882417 in __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x7d417) (BuildId: 830c94f480c13d9b01dc65a1035310882136094a)
[   25.098139] TEST-74-AUX-UTILS.sh[909]:     #12 0x56049b51cf54 in _start (/usr/bin/systemd-run+0x19f54) (BuildId: 0daacdb9f20151f3517312ee99e489a9b8f4989c)
[   25.098316] TEST-74-AUX-UTILS.sh[909]: 0x7ccc8a5e0b41 is located 193 bytes inside of 2384-byte region [0x7ccc8a5e0a80,0x7ccc8a5e13d0)
[   25.099202] TEST-74-AUX-UTILS.sh[909]: freed by thread T0 here:
[   25.099410] TEST-74-AUX-UTILS.sh[909]:     #0 0x7efc8e76420f in free.part.0 (/lib64/libasan.so.8+0x16420f) (BuildId: 173395e60f171589489dde2b7a156d0ae380734b)
[   25.099557] TEST-74-AUX-UTILS.sh[909]:     #1 0x7efc8cdf14d1 in pty_forward_free ../src/src/shared/ptyfwd.c:1122
[   25.099691] TEST-74-AUX-UTILS.sh[909]:     #2 0x56049b535328 in pty_forward_handler ../src/src/run/run.c:1952
[   25.100063] TEST-74-AUX-UTILS.sh[909]:     #3 0x7efc8cde138c in pty_forward_done ../src/src/shared/ptyfwd.c:196
[   25.100197] TEST-74-AUX-UTILS.sh[909]:     #4 0x7efc8cdec757 in shovel ../src/src/shared/ptyfwd.c:813
[   25.101144] TEST-74-AUX-UTILS.sh[909]:     #5 0x7efc8cdecc1f in shovel_force ../src/src/shared/ptyfwd.c:828
[   25.102273] TEST-74-AUX-UTILS.sh[909]:     #6 0x7efc8cdedb82 in on_exit_event ../src/src/shared/ptyfwd.c:899
[   25.103564] TEST-74-AUX-UTILS.sh[909]:     #7 0x7efc8d375eff in source_dispatch ../src/src/libsystemd/sd-event/sd-event.c:4301
[   25.103712] TEST-74-AUX-UTILS.sh[909]:     #8 0x7efc8d378032 in dispatch_exit ../src/src/libsystemd/sd-event/sd-event.c:4431
[   25.104081] TEST-74-AUX-UTILS.sh[909]:     #9 0x7efc8d37e932 in sd_event_dispatch ../src/src/libsystemd/sd-event/sd-event.c:4896
[   25.104954] TEST-74-AUX-UTILS.sh[909]:     #10 0x7efc8d37fc8c in sd_event_run ../src/src/libsystemd/sd-event/sd-event.c:4971
[   25.105160] TEST-74-AUX-UTILS.sh[909]:     #11 0x7efc8d3800ad in sd_event_loop ../src/src/libsystemd/sd-event/sd-event.c:4992
[   25.105310] TEST-74-AUX-UTILS.sh[909]:     #12 0x56049b541aba in start_transient_service ../src/src/run/run.c:2479
[   25.105454] TEST-74-AUX-UTILS.sh[909]:     #13 0x56049b552a65 in run ../src/src/run/run.c:3288
[   25.105572] TEST-74-AUX-UTILS.sh[909]:     #14 0x56049b552cb0 in main ../src/src/run/run.c:3291
[   25.106136] TEST-74-AUX-UTILS.sh[909]:     #15 0x7efc8b882300 in __libc_start_call_main (/lib64/libc.so.6+0x7d300) (BuildId: 830c94f480c13d9b01dc65a1035310882136094a)
[   25.106263] TEST-74-AUX-UTILS.sh[909]:     #16 0x7efc8b882417 in __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x7d417) (BuildId: 830c94f480c13d9b01dc65a1035310882136094a)
[   25.106385] TEST-74-AUX-UTILS.sh[909]:     #17 0x56049b51cf54 in _start (/usr/bin/systemd-run+0x19f54) (BuildId: 0daacdb9f20151f3517312ee99e489a9b8f4989c)
[   25.106792] TEST-74-AUX-UTILS.sh[909]: previously allocated by thread T0 here:
[   25.106957] TEST-74-AUX-UTILS.sh[909]:     #0 0x7efc8e76515f in malloc (/lib64/libasan.so.8+0x16515f) (BuildId: 173395e60f171589489dde2b7a156d0ae380734b)
[   25.108013] TEST-74-AUX-UTILS.sh[909]:     #1 0x7efc8cddebed in malloc_multiply ../src/src/basic/alloc-util.h:92
[   25.108188] TEST-74-AUX-UTILS.sh[909]:     #2 0x7efc8cdee47b in pty_forward_new ../src/src/shared/ptyfwd.c:955
[   25.108324] TEST-74-AUX-UTILS.sh[909]:     #3 0x56049b538700 in run_context_setup_ptyfwd ../src/src/run/run.c:2130
[   25.108472] TEST-74-AUX-UTILS.sh[909]:     #4 0x56049b5419f9 in start_transient_service ../src/src/run/run.c:2465
[   25.109152] TEST-74-AUX-UTILS.sh[909]:     #5 0x56049b552a65 in run ../src/src/run/run.c:3288
[   25.109311] TEST-74-AUX-UTILS.sh[909]:     #6 0x56049b552cb0 in main ../src/src/run/run.c:3291
[   25.109450] TEST-74-AUX-UTILS.sh[909]:     #7 0x7efc8b882300 in __libc_start_call_main (/lib64/libc.so.6+0x7d300) (BuildId: 830c94f480c13d9b01dc65a1035310882136094a)
[   25.109847] TEST-74-AUX-UTILS.sh[909]:     #8 0x7efc8b882417 in __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x7d417) (BuildId: 830c94f480c13d9b01dc65a1035310882136094a)
[   25.110760] TEST-74-AUX-UTILS.sh[909]:     #9 0x56049b51cf54 in _start (/usr/bin/systemd-run+0x19f54) (BuildId: 0daacdb9f20151f3517312ee99e489a9b8f4989c)
[   25.110911] TEST-74-AUX-UTILS.sh[909]: SUMMARY: AddressSanitizer: heap-use-after-free ../src/src/shared/ptyfwd.c:187 in pty_forward_done
[   25.111054] TEST-74-AUX-UTILS.sh[909]: Shadow bytes around the buggy address:
[   25.111213] TEST-74-AUX-UTILS.sh[909]:   0x7ccc8a5e0880: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
[   25.111378] TEST-74-AUX-UTILS.sh[909]:   0x7ccc8a5e0900: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
[   25.111520] TEST-74-AUX-UTILS.sh[909]:   0x7ccc8a5e0980: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
[   25.112210] TEST-74-AUX-UTILS.sh[909]:   0x7ccc8a5e0a00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
[   25.112399] TEST-74-AUX-UTILS.sh[909]:   0x7ccc8a5e0a80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
[   25.112767] TEST-74-AUX-UTILS.sh[909]: =>0x7ccc8a5e0b00: fd fd fd fd fd fd fd fd[fd]fd fd fd fd fd fd fd
[   25.112901] TEST-74-AUX-UTILS.sh[909]:   0x7ccc8a5e0b80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
[   25.113789] TEST-74-AUX-UTILS.sh[909]:   0x7ccc8a5e0c00: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
[   25.113906] TEST-74-AUX-UTILS.sh[909]:   0x7ccc8a5e0c80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
[   25.114046] TEST-74-AUX-UTILS.sh[909]:   0x7ccc8a5e0d00: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
[   25.114159] TEST-74-AUX-UTILS.sh[909]:   0x7ccc8a5e0d80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
[   25.114278] TEST-74-AUX-UTILS.sh[909]: Shadow byte legend (one shadow byte represents 8 application bytes):
[   25.114400] TEST-74-AUX-UTILS.sh[909]:   Addressable:           00
[   25.115099] TEST-74-AUX-UTILS.sh[909]:   Partially addressable: 01 02 03 04 05 06 07
[   25.115246] TEST-74-AUX-UTILS.sh[909]:   Heap left redzone:       fa
[   25.115365] TEST-74-AUX-UTILS.sh[909]:   Freed heap region:       fd
[   25.115483] TEST-74-AUX-UTILS.sh[909]:   Stack left redzone:      f1
[   25.115618] TEST-74-AUX-UTILS.sh[909]:   Stack mid redzone:       f2
[   25.115882] TEST-74-AUX-UTILS.sh[909]:   Stack right redzone:     f3
[   25.116735] TEST-74-AUX-UTILS.sh[909]:   Stack after return:      f5
[   25.116857] TEST-74-AUX-UTILS.sh[909]:   Stack use after scope:   f8
[   25.116974] TEST-74-AUX-UTILS.sh[909]:   Global redzone:          f9
[   25.117108] TEST-74-AUX-UTILS.sh[909]:   Global init order:       f6
[   25.117257] TEST-74-AUX-UTILS.sh[909]:   Poisoned by user:        f7
[   25.118128] TEST-74-AUX-UTILS.sh[909]:   Container overflow:      fc
[   25.118288] TEST-74-AUX-UTILS.sh[909]:   Array cookie:            ac
[   25.118433] TEST-74-AUX-UTILS.sh[909]:   Intra object redzone:    bb
[   25.118546] TEST-74-AUX-UTILS.sh[909]:   ASan internal:           fe
[   25.118684] TEST-74-AUX-UTILS.sh[909]:   Left alloca redzone:     ca
[   25.118792] TEST-74-AUX-UTILS.sh[909]:   Right alloca redzone:    cb
[   25.119282] TEST-74-AUX-UTILS.sh[909]: Command: systemd-run --quiet --pty -- bash -c echo PTY_FORWARD_READY; exec sleep 60
[   25.119395] TEST-74-AUX-UTILS.sh[909]: ==909==ABORTING

Follow-up for d3218c4c80c99583d3e7a31ff2f509ffb097568e

5 days agoboot/random-seed: create \loader\ dir if missing when seeding
dongshengyuan [Tue, 30 Jun 2026 01:47:22 +0000 (09:47 +0800)] 
boot/random-seed: create \loader\ dir if missing when seeding

When the random seed file doesn't exist but we have good entropy
(seeded_by_efi=true), we attempt to create it. This requires a handle
to the \loader\ directory, which may not exist on systems using
UKI+EFISTUB without systemd-boot installed.

Obtain the directory handle by first trying a read-only open; if that
returns EFI_NOT_FOUND, create the directory. We deliberately avoid
requesting write access on an already-present directory because some
firmware implementations return EFI_INVALID_PARAMETER for a
WRITE|CREATE open on an existing directory — this would be logged at
LOG_ERR and abort seed creation on systems where \loader\ exists but
random-seed does not (the normal systemd-boot layout).

Once a handle to \loader\ is obtained, open the seed file relative to
that handle rather than using the full path from root.

Introduced-by: c0e7046c17 ("boot: log about RO I/O errors at debug level.")
Fixes: #42801
Signed-off-by: dongshengyuan <dongshengyuan@uniontech.com>
5 days agoupdate TODO
Lennart Poettering [Tue, 23 Jun 2026 10:04:07 +0000 (12:04 +0200)] 
update TODO

5 days agoenv-util: ensure NUL termination of the replace_env_argv() output array
Luca Boccassi [Mon, 29 Jun 2026 14:05:51 +0000 (15:05 +0100)] 
env-util: ensure NUL termination of the replace_env_argv() output array

The output array is allocated with new() and left uninitialized, but a
bare unset "$VAR" token expands to nothing and writes no terminator.
When such a token leads or is the only word, the returned strv is left
without a trailing NULL.

Follow-up for f331434d13488425ccd8485327085d15f8f92aea

5 days agofido2: reject zero-length HMAC secret
Luca Boccassi [Mon, 29 Jun 2026 13:01:08 +0000 (14:01 +0100)] 
fido2: reject zero-length HMAC secret

The CTAP2 HMAC-SECRET output should never be zero length, so enforce
that at both retrieval sites.

Follow-up for 1c0c4a43c6118aa4057222789e4b777b61e4bb27

5 days agoresolvectl: fix JSON reply cleanup in varlink_dump_dns_configuration 42812/head
dongshengyuan [Tue, 30 Jun 2026 09:13:10 +0000 (17:13 +0800)] 
resolvectl: fix JSON reply cleanup in varlink_dump_dns_configuration

varlink_call_and_log() does not hand out a new reference for the reply
object, so the caller should not unref it. The _cleanup_(sd_json_variant_unrefp)
on reply was therefore wrong from the start.

The original TAKE_PTR(reply) was working around this incorrect cleanup
by preventing it from firing, but that left reply's refcount one too
high after sd_json_variant_ref(v) incremented the parent's count.

Fix by dropping _cleanup_(sd_json_variant_unrefp) from the reply
variable declaration entirely, as suggested by Lennart Poettering.

Signed-off-by: dongshengyuan <dongshengyuan@uniontech.com>
5 days agocore: rename LUO 'kexecsCount' state field to 'KExecsCount'
Luca Boccassi [Fri, 26 Jun 2026 12:57:06 +0000 (13:57 +0100)] 
core: rename LUO 'kexecsCount' state field to 'KExecsCount'

Match the casing of the corresponding KExecsCount D-Bus/Varlink property.

Follow-up for f9e6419f3426ce1b9d281e833f924e91b84b1127

5 days agoanalyze: use shutdown timestamps in time verb
Luca Boccassi [Fri, 19 Jun 2026 23:36:53 +0000 (00:36 +0100)] 
analyze: use shutdown timestamps in time verb

 [root@fedora ~]# systemd-analyze
 Startup finished in 486ms (stopping) + 48ms (exit) + 116ms (systemd-shutdown) + 774ms (kernel) + 1.939s (initrd) + 3.878s (userspace) = 7.243s
 graphical.target reached after 3.876s in userspace.

5 days agocore: preserve shutdown timestamps via LUO
Luca Boccassi [Fri, 19 Jun 2026 22:49:44 +0000 (23:49 +0100)] 
core: preserve shutdown timestamps via LUO

5 days agocore: publish shutdown timestamps via varlink
Luca Boccassi [Fri, 19 Jun 2026 22:55:39 +0000 (23:55 +0100)] 
core: publish shutdown timestamps via varlink

5 days agocore: publish shutdown timestamps via D-Bus
Luca Boccassi [Fri, 19 Jun 2026 22:49:23 +0000 (23:49 +0100)] 
core: publish shutdown timestamps via D-Bus

5 days agocore/shutdown: add more shutdown timestamps
Luca Boccassi [Fri, 19 Jun 2026 22:48:21 +0000 (23:48 +0100)] 
core/shutdown: add more shutdown timestamps

We already record when shutdown.target is initiated (ShutdownStart).
This adds a few more measuring points during shutdown: when
shutdown.target completes (i.e., all units stopped), when the shutdown
binary starts executing, and immediately before it hands off to the
kernel.

Obviously these are immediately lost upon reboot. But they will later
be wired in LUO so they get preserved on kexec, and can be inspected,
which is very useful for performance measurements.

5 days agoexec-invoke: fix wrong errno in log_error_errno for setenv failure
dongshengyuan [Tue, 30 Jun 2026 09:11:32 +0000 (17:11 +0800)] 
exec-invoke: fix wrong errno in log_error_errno for setenv failure

When setenv("CREDENTIALS_DIRECTORY") fails, log_error_errno() was
called with the stale return value of exec_context_get_credential_directory()
(which is >= 0 on success) instead of errno.

The %m in the format string correctly expands from libc's errno, so
the human-readable log message was unaffected. However, the structured
journal field ERRNO= received an incorrect value (0 or positive),
making automated log analysis and alerting on this failure unreliable.

Signed-off-by: dongshengyuan <dongshengyuan@uniontech.com>
5 days agojson-util: add json_dispatch_dual_timestamp()
Luca Boccassi [Fri, 26 Jun 2026 16:38:25 +0000 (17:38 +0100)] 
json-util: add json_dispatch_dual_timestamp()

5 days agorun: do not munge user.slice with --slice-inherit
Ronan Pigott [Mon, 29 Jun 2026 19:14:58 +0000 (12:14 -0700)] 
run: do not munge user.slice with --slice-inherit

When using --slice-inherit, setting arg_slice would inadvertently munge
user.slice into the current user slice, usually producing a slice name
like user-1000-user.slice. This is treated as a user-UID slice by
user-.slice.d/10-defaults.conf, resulting in a strange description:
literally "User slice for UID user" (instead of an actual user UID).

Keep arg_slice empty when using --slice-inherit so that we actually
inherit from the relevant slice instead of a munged version.

Fixes: #42601
5 days agoluo-util: use new LIVEUPDATE_SESSION_GET_NAME ioctl to get session name if available
Luca Boccassi [Mon, 22 Jun 2026 15:33:23 +0000 (16:33 +0100)] 
luo-util: use new LIVEUPDATE_SESSION_GET_NAME ioctl to get session name if available

Added in kernel 7.2. Fallback can be removed once baseline
moves above. Ubuntu 26.04 uses 7.0.

5 days agoImport linux/liveupdate.h UAPI header from 7.2-rc1
Luca Boccassi [Mon, 22 Jun 2026 15:15:30 +0000 (16:15 +0100)] 
Import linux/liveupdate.h UAPI header from 7.2-rc1

5 days agoportable: leave room for trailing NUL in metadata receive buffer
Syed Mohammed Nayyar [Sun, 28 Jun 2026 11:22:43 +0000 (16:52 +0530)] 
portable: leave room for trailing NUL in metadata receive buffer

receive_portable_metadata() reads each item into a stack buffer of
PATH_MAX + NAME_MAX + 2 bytes, passes the full sizeof() as the recv
iovec length, and then NUL-terminates with iov_buffer[n] = 0. recvmsg()
can return n equal to the buffer size, so the terminator is written one
byte past the end.

Grow the buffer by one byte and cap the iovec at sizeof - 1, so a full
record is still received and the trailing NUL always fits, matching the
coredump-receive.c reader.

5 days agoman: document that $XDG_CONFIG_HOME affects environment.d lookup path
dongshengyuan [Mon, 29 Jun 2026 05:24:51 +0000 (13:24 +0800)] 
man: document that $XDG_CONFIG_HOME affects environment.d lookup path

Align the documentation with the actual behavior: if $XDG_CONFIG_HOME is
set to an absolute path in the user service manager environment, it takes
precedence over the default ~/.config/ when locating environment.d files.
Also note the bootstrapping limitation that variables defined inside
environment.d files are not yet available when the generator runs.

Fixes: #42777
Signed-off-by: dongshengyuan <dongshengyuan@uniontech.com>
6 days agolocale-util: drop libintl dependency
Yu Watanabe [Sun, 28 Jun 2026 12:40:07 +0000 (21:40 +0900)] 
locale-util: drop libintl dependency

Both glibc and musl provides dgettext(). Hence it is not necessary to
use libintl.so provided by gettext.

This partially reverts 590e22643722cf1268bd24f9056c7115ab0c1cf2,
fully reverts commit e6e65dc26157207a6b720fccc49632ac77236384 and
bd19ffd9cb618b15cbd74110aeca2abab745fe9e.

Then, introduce minimal libintl.h for musl build, to avoid using
libintl.h by gettext, which is typically installed on musl-based
build systems.

6 days agotest: make TEST-07-PID1.issue-14566 more robust (#42798)
Luca Boccassi [Mon, 29 Jun 2026 14:16:39 +0000 (15:16 +0100)] 
test: make TEST-07-PID1.issue-14566 more robust (#42798)

e.g.:
https://artifacts.dev.testing-farm.io/f5150e83-eccf-4d84-aa8b-ff25cd7a3cb4/

6 days agoshared/varlink: fix license of varlink-io.systemd.Udev.c
Luca Boccassi [Fri, 26 Jun 2026 20:28:27 +0000 (21:28 +0100)] 
shared/varlink: fix license of varlink-io.systemd.Udev.c

Sources in src/shared need to be licensed LGPL-2.1-or-later, not
GPL-2.0-or-later, which is the license for src/udev. Fix it.

Follow-up for 2f0aa9a80445ef18086260a60fad71920ad9486c

6 days agotest: drop ASAN workaround in TEST-07-PID1.issue-14566 42798/head
Luca Boccassi [Mon, 29 Jun 2026 11:06:28 +0000 (12:06 +0100)] 
test: drop ASAN workaround in TEST-07-PID1.issue-14566

https://bugzilla.redhat.com/show_bug.cgi?id=2098125 was marked as
fixed some years ago, so it should be safe to run this test again
now.

Follow-up for 11562ee585d5f2e42cb583f06aa01c7383d85f55

6 days agotest: use /run/ for temporary files in TEST-07-PID1.issue-14566
Luca Boccassi [Mon, 29 Jun 2026 11:02:41 +0000 (12:02 +0100)] 
test: use /run/ for temporary files in TEST-07-PID1.issue-14566

And delete the file before starting, to be safe against reruns

Follow-up for c1566ef0d22ed786b9ecf4c476e53b8a91e67578

6 days agotest: make TEST-07-PID1.issue-14566 more robust
Luca Boccassi [Mon, 29 Jun 2026 10:56:30 +0000 (11:56 +0100)] 
test: make TEST-07-PID1.issue-14566 more robust

The test slept a fixed 4s after starting the service, then read the
child PID from /leakedtestpid. On a loaded host the executor had not
exec'd the script yet:

[ 1571.079978] TEST-07-PID1.sh[17329]: + systemctl start issue14566-repro
[ 1571.079978] TEST-07-PID1.sh[17329]: + sleep 4
[ 1571.079978] TEST-07-PID1.sh[17329]: + systemctl status issue14566-repro
[ 1562.350438] systemd[1]: init.scope: Child 17296 belongs to init.scope.
[ 1571.081084] TEST-07-PID1.sh[17333]: ● issue14566-repro.service - Issue 14566 Repro
[ 1571.081084] TEST-07-PID1.sh[17333]:      Loaded: loaded (/usr/lib/systemd/tests/testdata/TEST-07-PID1.units/issue14566-repro.service; static)
[ 1571.081084] TEST-07-PID1.sh[17333]:     Drop-In: /usr/lib/systemd/system/service.d
[ 1571.081084] TEST-07-PID1.sh[17333]:              └─10-timeout-abort.conf
[ 1571.081084] TEST-07-PID1.sh[17333]:      Active: active (running) since Mon 2026-06-29 06:19:07 UTC; 4s ago
[ 1571.081084] TEST-07-PID1.sh[17333]:  Invocation: b3356aa5fff24eee85e302250ecb06b1
[ 1571.081084] TEST-07-PID1.sh[17333]:    Main PID: 17331 (9)
[ 1571.081084] TEST-07-PID1.sh[17333]:       Tasks: 1 (limit: 4468)
[ 1571.081084] TEST-07-PID1.sh[17333]:      Memory: 768K (peak: 768K)
[ 1571.081084] TEST-07-PID1.sh[17333]:         CPU: 1ms
[ 1571.081084] TEST-07-PID1.sh[17333]:      CGroup: /system.slice/issue14566-repro.service
[ 1571.081084] TEST-07-PID1.sh[17333]:              └─17331 systemd-executor --deserialize 66 --log-level debug,console:info --log-target journal
[ 1562.350492] systemd[1]: Child 17297 ((sd-close)) died (code=exited, status=0/SUCCESS)
[ 1571.082379] TEST-07-PID1.sh[17334]: ++ cat /leakedtestpid
[ 1571.082379] TEST-07-PID1.sh[17334]: cat: /leakedtestpid: No such file or directory

Make the service Type=notify and notify readiness after writing the PID
file, and wait for the service to go inactive in a timeout loop instead
of fixed sleeps.

Follow-up for c1566ef0d22ed786b9ecf4c476e53b8a91e67578

6 days agomkosi: fix license of mkosi.finalize
Luca Boccassi [Mon, 29 Jun 2026 10:42:27 +0000 (11:42 +0100)] 
mkosi: fix license of mkosi.finalize

Every mkosi file/script is LGPL-2.1-or-later, but this one is CC-0,
fix it

Follow-up for 858e59c82c2246d34d84bd495f46c971d9303dba

6 days agoshell-completion: add missing commands and options to timedatectl zsh
wangzhaohui [Wed, 24 Jun 2026 03:10:56 +0000 (11:10 +0800)] 
shell-completion: add missing commands and options to timedatectl zsh

The zsh completion for timedatectl was missing three commands ('show',
'ntp-servers', 'revert') and five options (--monitor, -p/--property=,
-a/--all, --value, -P) that are already present in the bash completion,
documented in the man page, and implemented in the binary.

Fixes #16507

6 days agologind: fix typo in reboot-to-boot-loader-entry path
dongshengyuan [Mon, 29 Jun 2026 06:54:51 +0000 (14:54 +0800)] 
logind: fix typo in reboot-to-boot-loader-entry path

SetRebootToBootLoaderEntry on non-EFI systems wrote the boot loader
entry name to /run/systemd/reboot-boot-to-loader-entry (wrong order),
while the getter and unlink both use the correct path
/run/systemd/reboot-to-boot-loader-entry.

The written value was never read back, silently breaking the feature
on non-EFI systems.

Signed-off-by: dongshengyuan <dongshengyuan@uniontech.com>
6 days agojournal-verify: fix offset reported for tail hash mismatch
dongshengyuan [Mon, 29 Jun 2026 06:53:35 +0000 (14:53 +0800)] 
journal-verify: fix offset reported for tail hash mismatch

After walking a hash chain, the loop exits with p == 0. The error()
call for a tail_hash_offset mismatch passed p as the file offset,
printing 0000000000000000 instead of the actual last data object.

Pass 'last' instead, which holds the offset of the final chain entry.

Signed-off-by: dongshengyuan <dongshengyuan@uniontech.com>
6 days agopo: Translated using Weblate (Indonesian)
Arif Budiman [Mon, 29 Jun 2026 06:17:54 +0000 (06:17 +0000)] 
po: Translated using Weblate (Indonesian)

Currently translated at 100.0% (286 of 286 strings)

Co-authored-by: Arif Budiman <arifpedia@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/id/
Translation: systemd/main

7 days agoRevert "mkosi: Grow the root partition on boot"
Yu Watanabe [Sun, 28 Jun 2026 04:28:17 +0000 (13:28 +0900)] 
Revert "mkosi: Grow the root partition on boot"

This reverts commit 7f33ee8bb42a905f5c71bc0b49e946b527b3135a.

The file is located outside mkosi/ subdirectory, hence currently unused.
If this is moved to mkosi/ subdirectory, the config conflicts with
TEST-58-REPART. Let's remove it at least now, and reintroduce it later
at correct place with test adjustment if this is really useful.

7 days agocryptenroll: add interactive mode and Varlink IPC API (#42380)
Lennart Poettering [Sun, 28 Jun 2026 06:47:27 +0000 (08:47 +0200)] 
cryptenroll: add interactive mode and Varlink IPC API (#42380)

Replaces: #31096
Fixes: #36298
7 days agorun: make custom slice imply XDG_SESSION_CLASS=none
Ronan Pigott [Wed, 17 Jun 2026 19:36:16 +0000 (12:36 -0700)] 
run: make custom slice imply XDG_SESSION_CLASS=none

--slice and --slice-inherit are intended to make the new service unit
part of a specific slice. Logind is incompatible with that goal, as a
session of any kind will prompt logind to immediately yoink the new
command from the service unit into a new session scope, which does not
inherit from run0's own slice. The use can still explicitly request a
session with --setenv=XDG_SESSION_CLASS=<class>.

Also make --slice and --slice-inherit conflict with --lightweight and
--area, which depend on logind to be effective.

7 days agonuma: add support for preferred-many and weighted-interleave policies
dongshengyuan [Mon, 22 Jun 2026 02:55:13 +0000 (10:55 +0800)] 
numa: add support for preferred-many and weighted-interleave policies

Add support for two newer NUMA memory policies:

- MPOL_PREFERRED_MANY (Linux 5.15): like MPOL_PREFERRED but accepts
  a set of nodes instead of a single node, falling back to all nodes
  if preferred nodes cannot satisfy the allocation.

- MPOL_WEIGHTED_INTERLEAVE (Linux 6.9): like MPOL_INTERLEAVE but
  distributes pages across nodes proportionally to per-node weights
  configured via /sys/kernel/mm/mempolicy/weighted_interleave/.

On kernels that do not support the requested policy, set_mempolicy()
returns EINVAL. We convert EINVAL to EOPNOTSUPP only for the two new
policies (MPOL_PREFERRED_MANY, MPOL_WEIGHTED_INTERLEAVE), so that a
bad NUMAMask= for already-supported policies still fails the service
rather than being silently ignored.

The NUMA subsystem being absent (ENOSYS) continues to be handled
silently at debug level, as before.

Varlink serialization uses json_underscorify() on an owned copy of
the policy name string to convert hyphenated names to the underscore
form declared in the IDL enum, avoiding mutation of the read-only
static string table.

Signed-off-by: dongshengyuan <dongshengyuan@uniontech.com>
7 days agoCorrect allocation size computation in xescape_full
Jouke Witteveen [Sun, 21 Jun 2026 12:28:45 +0000 (14:28 +0200)] 
Correct allocation size computation in xescape_full

Amends 17260a9 (#42524).

Since there is no return path with an incomplete write, the effect of
the memset block was unobservable, so drop it.

7 days agovmspawn: complain loudly if we can't prepare a unix socket for virtiofsd
Frantisek Sumsal [Sat, 27 Jun 2026 17:08:06 +0000 (19:08 +0200)] 
vmspawn: complain loudly if we can't prepare a unix socket for virtiofsd

I couldn't convince vmspawn to start a VM on a Fedora image I just
downloaded, and it was pretty light on any useful details:

$ build/systemd-vmspawn --image ~/Downloads/Fedora-Server-Guest-Generic-Rawhide-20260627.n.0.x86_64.qcow2 --image-format=qcow2 --bind-ro=/tmp/bar; echo $?
░ Spawning VM Fedora-Server-Guest-Generic-Rawhide-20260627.n.0.x8664.qcow2 on /home/mrc0mmand/Downloads/Fedora-Server-Guest-Generic-Rawhide-20260627.n.0.x86_64.qcow2.
░ Press Ctrl-] three times within 1s to kill VM.
1

Turns out that the unix socket path vmspawn generates for the virtiofsd
socket is too long. Let's relay this information to the user as well to
make debugging this a little less painful:

$ build/systemd-vmspawn --image ~/Downloads/Fedora-Server-Guest-Generic-Rawhide-20260627.n.0.x86_64.qcow2 --image-format=qcow2 --bind-ro=/tmp/bar
░ Spawning VM Fedora-Server-Guest-Generic-Rawhide-20260627.n.0.x8664.qcow2 on /home/mrc0mmand/Downloads/Fedora-Server-Guest-Generic-Rawhide-20260627.n.0.x86_64.qcow2.
░ Press Ctrl-] three times within 1s to kill VM.
Failed to prepare unix socket '/run/user/1000/systemd/vmspawn/Fedora-Server-Guest-Generic-Rawhide-20260627.n.0.x8664.qcow2/sock-9594581dcf598992': File name too long

8 days agojournal: replace libgcrypt with openssl (#42695)
Yu Watanabe [Sat, 27 Jun 2026 18:45:22 +0000 (03:45 +0900)] 
journal: replace libgcrypt with openssl (#42695)

8 days agoupdate TODO 42380/head
Lennart Poettering [Fri, 29 May 2026 10:40:47 +0000 (12:40 +0200)] 
update TODO

8 days agoshell-completion: catch up with cryptenroll command line
Lennart Poettering [Wed, 24 Jun 2026 09:01:43 +0000 (11:01 +0200)] 
shell-completion: catch up with cryptenroll command line

8 days agotest: cover the io.systemd.CryptEnroll Varlink interface
Lennart Poettering [Thu, 28 May 2026 12:23:04 +0000 (14:23 +0200)] 
test: cover the io.systemd.CryptEnroll Varlink interface

Extend the existing systemd-cryptenroll test with varlinkctl invocations
equivalent to the command line ones: enrolling a recovery key and passwords
(unlocking via a key file by path and via a passed file descriptor), listing
slots, combining enrollment with a type-based wipe, and the negative cases
(ListSlots without 'more', and the pkcs11/tpm2 mechanisms that are not part of
the EnrollMechanism allowlist).

8 days agocryptenroll: refuse reading a key longer than 4 MiB
Lennart Poettering [Mon, 22 Jun 2026 12:27:02 +0000 (14:27 +0200)] 
cryptenroll: refuse reading a key longer than 4 MiB

If we open this up to external processes let's tighten rules and refuse
reading more than 4 MiB as key, after all this is locked memory.

8 days agocryptenroll: add interactive --firstboot enrollment wizard
Lennart Poettering [Thu, 28 May 2026 12:15:56 +0000 (14:15 +0200)] 
cryptenroll: add interactive --firstboot enrollment wizard

Add a --firstboot mode that interactively walks the user through enrolling a
passphrase, a recovery key, or a FIDO2 token, with one menu entry per suitable
token currently plugged in (driven by a new fido2_enumerate_devices() helper).
Pressing enter at the top-level menu leaves the volume unchanged; for each
already-enrolled credential type the wizard offers to wipe it as part of the
operation. It populates the same EnrollContext the command line and Varlink
paths use, so the actual enrollment goes through the shared enroll_now() path.

A companion --prompt-suppress= option takes a list of slot types: if a slot of
any listed type already exists, the wizard does nothing and exits successfully.
This lets it be hooked into the boot process while staying quiet once the
system has been set up.

The accompanying systemd-cryptenroll-firstboot.service runs this from the
initrd, after systemd-repart has created the encrypted volume but before we
transition to the host, suppressing itself once a password, recovery key or
FIDO2 token is enrolled. To make that work, determine_default_node() now looks
below /sysroot/ when running in the initrd, since the host file systems aren't
at their final location yet.

While the wizard is active it draws the same installer-style chrome (blue bars
at the top and bottom of the terminal) as systemd-sysinstall, using the shared
prompt_loop_yes_no() helper for its wipe confirmations.

Honours the systemd.firstboot= kernel command line option.

Fixes: #36298
8 days agocryptenroll: add --unlock-headless as a new pseudo-unlock mechanism
Lennart Poettering [Fri, 29 May 2026 09:37:48 +0000 (11:37 +0200)] 
cryptenroll: add --unlock-headless as a new pseudo-unlock mechanism

THis simply tries TPM2 if available, and falls back to empty password.

8 days agocryptenroll: add --unlock-empty to unlock via an empty password
Lennart Poettering [Fri, 29 May 2026 09:29:32 +0000 (11:29 +0200)] 
cryptenroll: add --unlock-empty to unlock via an empty password

8 days agocryptenroll: move load_volume_key_keyfile() to cryptenroll-password.c
Lennart Poettering [Fri, 29 May 2026 10:19:34 +0000 (12:19 +0200)] 
cryptenroll: move load_volume_key_keyfile() to cryptenroll-password.c

Conceptually a keyfile and a password are pretty much the same thing,
hence put them in the same file.

8 days agocryptenroll: expose enrollment as an io.systemd.CryptEnroll Varlink service
Lennart Poettering [Thu, 28 May 2026 11:32:13 +0000 (13:32 +0200)] 
cryptenroll: expose enrollment as an io.systemd.CryptEnroll Varlink service

Add a Varlink interface for systemd-cryptenroll, building on the EnrollContext
introduced previously. A single Enroll method covers password, recovery-key and
FIDO2 enrollment; PKCS#11 and TPM2 are not exposed for now (they are not
part of the EnrollMechanism allowlist, so the generic InvalidParameter error
applies). A ListSlots method enumerates the currently enrolled keyslots.

The dispatcher populates the same EnrollContext the command line uses and then
runs the shared enroll_now()/prepare_luks()/wipe_slots() paths, so both
front-ends behave identically. FIDO2 enrollment that requires user presence
reports an imminent touch via a non-terminating "state":"touch" reply when the
caller passes 'more'. Credential material (password, FIDO2 PIN, recovery key)
is handled as sensitive, and key files may be passed either by path or as an
fd index.

The server is allocated root-only plus caller's-own-UID, with the listening
socket created in 0644 mode.

Replaces: #31096

8 days agocryptenroll: add an "unlock_password" field to ExecContext
Lennart Poettering [Wed, 24 Jun 2026 09:23:19 +0000 (11:23 +0200)] 
cryptenroll: add an "unlock_password" field to ExecContext

This is preparation for the Varlinkification, as then we want to pass
the password in via IPC instead of prompting the user.

Note that this only adds the field, and applies it, but never actually
sets it. That's for the varlinkification later.

8 days agocryptenroll: collect all enrollment parameters in an EnrollContext
Lennart Poettering [Thu, 28 May 2026 10:35:21 +0000 (12:35 +0200)] 
cryptenroll: collect all enrollment parameters in an EnrollContext

Introduce an EnrollContext structure that carries everything the enrollment
and unlocking helpers need, and route all enroll_*()/load_volume_key_*()/
wipe_slots() calls through it. The command line still populates the existing
arg_* globals as before; once parsing is complete they are copied into a
self-contained EnrollContext (which owns its strings/arrays) and the rest of
the code only ever reads from the context.

This is preparation for the upcoming varlinkification of systemd-cryptenroll:
a Varlink dispatcher (and later an interactive first-boot wizard) can populate
the very same EnrollContext without going through the arg_* parsing layer.

To support non-interactive (e.g. Varlink) callers, the context carries an
'interactive' flag: when false, every credential prompt is disabled and the
helpers fail with -ENOPKG (the established "querying disabled via headless"
code) instead of blocking on a tty. Passwords, FIDO2 PINs and PKCS#11 PINs are
all covered, and an optional FIDO2 PIN can be supplied directly via the
context. enroll_recovery() additionally grows a quiet mode that returns the
recovery key instead of printing it.

This also adds one new field to EnrollContext which didn't exist before:
the unlock_password is useful for the Varlink hookup later.

No change in command line behaviour.

8 days agomute-console: allow NULL being passed
Lennart Poettering [Tue, 16 Jun 2026 12:21:36 +0000 (14:21 +0200)] 
mute-console: allow NULL being passed

8 days agoshared: add a generic prompt_loop_yes_no() helper
Lennart Poettering [Thu, 28 May 2026 13:33:49 +0000 (15:33 +0200)] 
shared: add a generic prompt_loop_yes_no() helper

Factor a yes/no variant of prompt_loop() out into prompt-util.[ch], so the
various interactive tools can share a single implementation, and convert
systemd-sysinstall's installation confirmation question over to it.

8 days agogcrypt-util: drop several unused definitions 42695/head
Yu Watanabe [Tue, 23 Jun 2026 16:04:02 +0000 (01:04 +0900)] 
gcrypt-util: drop several unused definitions

8 days agotree-wide: drop gcrypt dependency from all binaries except for unit tests
Yu Watanabe [Mon, 22 Jun 2026 10:32:01 +0000 (19:32 +0900)] 
tree-wide: drop gcrypt dependency from all binaries except for unit tests

With this change, gcrypt dependency is not mandatory. Hence, allow to build
systemd even when -D gcrypt=enabled but gcrypt devel package is not installed.

8 days agojournal: replace gcrypt with openssl
Yu Watanabe [Mon, 22 Jun 2026 07:34:35 +0000 (16:34 +0900)] 
journal: replace gcrypt with openssl

8 days agofsprg-openssl: rewrite fsprg with OpenSSL
Yu Watanabe [Fri, 19 Jun 2026 18:29:47 +0000 (03:29 +0900)] 
fsprg-openssl: rewrite fsprg with OpenSSL

This introduce OpenSSL port of fsprg, which is implemented by using libgcrypt.

8 days agocrypto-util: load several more functions from libcrypto.so
Yu Watanabe [Thu, 25 Jun 2026 12:10:05 +0000 (21:10 +0900)] 
crypto-util: load several more functions from libcrypto.so

They will be used in later commits.

8 days agocrypto-util: sort symbols
Yu Watanabe [Thu, 25 Jun 2026 11:51:34 +0000 (20:51 +0900)] 
crypto-util: sort symbols

8 days agotest-fsprg: add unit test for FSPRG
Yu Watanabe [Fri, 19 Jun 2026 17:42:13 +0000 (02:42 +0900)] 
test-fsprg: add unit test for FSPRG

8 days agotest-journal-verify: replace HAVE_GCRYPT ifdef with journal_auth_supported()
Yu Watanabe [Sat, 27 Jun 2026 06:49:31 +0000 (15:49 +0900)] 
test-journal-verify: replace HAVE_GCRYPT ifdef with journal_auth_supported()

8 days agosd-journal: allow to verify sealed journals even when sealing support is disabled
Yu Watanabe [Sat, 27 Jun 2026 06:20:27 +0000 (15:20 +0900)] 
sd-journal: allow to verify sealed journals even when sealing support is disabled

Of course, if disabled, seal tags cannot be verified, hence the check is skipped.

8 days agosd-journal: allow to read sealed journal files when sealing is not supported
Yu Watanabe [Sat, 27 Jun 2026 06:04:24 +0000 (15:04 +0900)] 
sd-journal: allow to read sealed journal files when sealing is not supported

8 days agosd-journal: drop libgcrypt dependency from libsystemd
Yu Watanabe [Thu, 25 Jun 2026 14:38:16 +0000 (23:38 +0900)] 
sd-journal: drop libgcrypt dependency from libsystemd

This introduce a vtable for journal tagging feature in sd-journal,
and makes libgcrypt dependent features loaded by users (journald,
journalctl, journal-remote, and unit tests) when necessary.

8 days agojournal-authenticate: save mmaped size rather than file size field in the file
Yu Watanabe [Sat, 27 Jun 2026 05:24:52 +0000 (14:24 +0900)] 
journal-authenticate: save mmaped size rather than file size field in the file

8 days agosd-journal: introduce JournalAuthContext
Yu Watanabe [Thu, 25 Jun 2026 16:26:21 +0000 (01:26 +0900)] 
sd-journal: introduce JournalAuthContext

Then, move several components for journal tagging in JournalFile
to JournalAuthContext.
This also introduces wrapper functions that checks gcrypt support.

8 days agojournal-authenticate: initialize hmac when necessary 42772/head
Yu Watanabe [Fri, 26 Jun 2026 19:59:08 +0000 (04:59 +0900)] 
journal-authenticate: initialize hmac when necessary

8 days agojournal-authenticate: several trivial cleanups
Yu Watanabe [Thu, 25 Jun 2026 15:31:22 +0000 (00:31 +0900)] 
journal-authenticate: several trivial cleanups

- adds several overflow check,
- adds missing assertion,
- drop unnecessary conditions,
- declare variables when necessary.

8 days agojournal-authenticate: check overflow
Yu Watanabe [Thu, 25 Jun 2026 16:23:46 +0000 (01:23 +0900)] 
journal-authenticate: check overflow

8 days agojournal-authenticate: merge several functions into journal_file_maybe_append_tag()
Yu Watanabe [Thu, 25 Jun 2026 16:08:10 +0000 (01:08 +0900)] 
journal-authenticate: merge several functions into journal_file_maybe_append_tag()

8 days agojournal-authenticate: move several more functions
Yu Watanabe [Thu, 25 Jun 2026 15:53:35 +0000 (00:53 +0900)] 
journal-authenticate: move several more functions

8 days agojournal-authenticate: move one more function
Yu Watanabe [Thu, 25 Jun 2026 15:47:33 +0000 (00:47 +0900)] 
journal-authenticate: move one more function

8 days agojournal-authenticate: move functions
Yu Watanabe [Thu, 25 Jun 2026 15:30:37 +0000 (00:30 +0900)] 
journal-authenticate: move functions

8 days agomkosi: update debian commit ref and install new split-out packages (#42769)
Luca Boccassi [Sat, 27 Jun 2026 14:33:38 +0000 (15:33 +0100)] 
mkosi: update debian commit ref and install new split-out packages (#42769)

8 days agojournal: several cleanups for journal sealing feature (#42770)
Yu Watanabe [Sat, 27 Jun 2026 14:01:09 +0000 (23:01 +0900)] 
journal: several cleanups for journal sealing feature (#42770)

8 days agojournal: drop journal_file_tag_seqnum() and embed into journal_file_append_tag() 42770/head
Yu Watanabe [Thu, 25 Jun 2026 15:13:58 +0000 (00:13 +0900)] 
journal: drop journal_file_tag_seqnum() and embed into journal_file_append_tag()

8 days agojournal: use FSS_HEADER_SIGNATURE at one more place
Yu Watanabe [Thu, 25 Jun 2026 15:08:41 +0000 (00:08 +0900)] 
journal: use FSS_HEADER_SIGNATURE at one more place

8 days agojournalctl-misc: several cleanups
Yu Watanabe [Thu, 25 Jun 2026 07:56:56 +0000 (16:56 +0900)] 
journalctl-misc: several cleanups

- honor -ENOKEY from journal_file_verify(),
- use RET_GATHER(),
- use usec_sub_unsigned(),
- reduce indentation,
- tighten variable scope.

8 days agojournal-verify: coding style fixlets
Yu Watanabe [Thu, 25 Jun 2026 07:51:14 +0000 (16:51 +0900)] 
journal-verify: coding style fixlets

8 days agojournal-authenticate: refuse invalid start and interval parameters
Yu Watanabe [Sat, 27 Jun 2026 05:08:03 +0000 (14:08 +0900)] 
journal-authenticate: refuse invalid start and interval parameters

We have already checked that in journal_file_fss_load().
Let's also check the same in loading user provided key.

8 days agomkosi: pull new split-out packages for deb/ubuntu 42769/head
Luca Boccassi [Sat, 27 Jun 2026 09:16:24 +0000 (10:16 +0100)] 
mkosi: pull new split-out packages for deb/ubuntu

8 days agomkosi: update debian commit reference to 0b390d268323a49191a9a3bcc07a46b573c1e464
Luca Boccassi [Sat, 27 Jun 2026 09:12:58 +0000 (10:12 +0100)] 
mkosi: update debian commit reference to 0b390d268323a49191a9a3bcc07a46b573c1e464

0b390d2683 One more fixup for d/copyright
91d3dadcb5 Update changelog for 261.1-1 release
3c287e1f86 d/copyright: update to add new licenses
a82117f9a3 Install new files for upstream build
020caeb149 Override new Lintian false positive
d55b67b66e d/control: demote libnss-{myhostname,resolve} to Suggests for systemd-resolved
1c537705ec Update changelog for 261-2 release
6235897bbc Note new package split in NEWS
a440cb2c4a Install new files for upstream build
7eaa21ad05 Split tpm tools into new systemd-tpm package
52b28b74f3 Split metrics reporting tools into new systemd-report package
de2f367f22 Split imds tools into new systemd-imds package
2d0a07f5ae d/t/control: do not install xserver-xorg-video-dummy on loong64
c886c3efc8 Install new files for upstream build
0efa66b4af Update changelog for 261-1 release
e36cf82a1d lintian-overrides: override error about derivative.ubuntu build profile
fbd38c36ea d/control: do not build systemd-boot-efi-*-signed-template on ubuntu

8 days agojournal: use recognizable error code
Yu Watanabe [Thu, 25 Jun 2026 07:43:13 +0000 (16:43 +0900)] 
journal: use recognizable error code

EINVAL is too generic and widely used. Let's use more specific error code.

8 days agosd-journal: use iovec for fsprg state and friends
Yu Watanabe [Tue, 23 Jun 2026 13:15:17 +0000 (22:15 +0900)] 
sd-journal: use iovec for fsprg state and friends

This also makes them erased before freed.

8 days agojournalctl: use iovec for fsprg state and friends
Yu Watanabe [Tue, 23 Jun 2026 12:57:24 +0000 (21:57 +0900)] 
journalctl: use iovec for fsprg state and friends

This also makes them erased on exit.