Tilghman Lesher [Wed, 27 Feb 2008 08:20:15 +0000 (08:20 +0000)]
Bring Voicetronix driver up to date with current drivers
(closes issue #12084)
Reported by: mmickan
Patches:
chan_vpb.cc.diff uploaded by mmickan (license 400)
module.h.diff uploaded by mmickan (license 400)
vpb.conf.sample uploaded by mmickan (license 400)
Russell Bryant [Wed, 27 Feb 2008 04:14:54 +0000 (04:14 +0000)]
Add the stuff from the janitor projects page that is still relevant. I figure
that if we keep this in the tree, it will be much easier to keep up to date.
The page on asterisk.org just links to this on svn.digium.com/view
Russell Bryant [Wed, 27 Feb 2008 00:55:12 +0000 (00:55 +0000)]
Blocked revisions 104332 via svnmerge
........
r104332 | russell | 2008-02-26 18:54:29 -0600 (Tue, 26 Feb 2008) | 5 lines
Zaptel 1.4 now exposes FXO battery state as an alarm. However, Asterisk 1.4
does not know what to do with these alarms. Only Asterisk 1.6 cares about it.
So, if we get an unknown alarm in chan_zap, don't generate confusing log messages
about it.
Russell Bryant [Tue, 26 Feb 2008 20:02:14 +0000 (20:02 +0000)]
Rename version.h to ast_version.h. Next, I will be re-adding version.h as an
automatically generated file like it used to be. This still needs to be there
for modules that have to check it to compile against multiple asterisk versions.
Joshua Colp [Tue, 26 Feb 2008 19:14:04 +0000 (19:14 +0000)]
Add an 'e' option to ResetCDR which re-enables a CDR that has been disabled.
(closes issue #11170)
Reported by: kratzers
Patches:
ResetCDR.1.diff uploaded by kratzers (license 307)
Tilghman Lesher [Tue, 26 Feb 2008 18:40:26 +0000 (18:40 +0000)]
1) Make braces mandatory for if/for/while, even around single statements.
2) Revise the argument parsing section, showing use of the standard macros.
3) Fix a typo.
Fix a very bizarre issue we were seeing with our buildbot when using a DESTDIR that
wasn't an absolute path (such as DESTDIR=~/asterisk-1.4).
Apparently what was happening, was that some of the targets were being expanded to
the full path, so $@ ended up being /root/asterisk-1.4/[...]/ rather than ~/asterisk-1.4/[...]/
It appears that this may be a new "feature" in GNU make.
(*cough* http://en.wikipedia.org/wiki/Principle_of_least_surprise *cough*)
Russell Bryant [Tue, 26 Feb 2008 00:31:40 +0000 (00:31 +0000)]
Merged revisions 104119 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r104119 | russell | 2008-02-25 18:25:29 -0600 (Mon, 25 Feb 2008) | 33 lines
Merge changes from team/russell/smdi-1.4
This commit brings in a significant set of changes to the SMDI support in Asterisk.
There were a number of bugs in the current implementation, most notably being that
it was very likely on busy systems to pop off the wrong message from the SMDI message
queue. So, this set of changes fixes the issues discovered as well as introducing
some new ways to use the SMDI support which are required to avoid the bugs with
grabbing the wrong message off of the queue.
This code introduces a new interface to SMDI, with two dialplan functions. First,
you get an SMDI message in the dialplan using SMDI_MSG_RETRIEVE() and then you access
details in the message using the SMDI_MSG() function. A side benefit of this is that
it now supports more than just chan_zap.
For example, with this implementation, you can have some FXO lines being terminated
on a SIP gateway, but the SMDI link in Asterisk.
Another issue with the current implementation is that it is quite common that the
station ID that comes in on the SMDI link is not necessarily the same as the Asterisk
voicemail box. There are now additional directives in the smdi.conf configuration
file which let you map SMDI station IDs to Asterisk voicemail boxes.
Yet another issue with the current SMDI support was related to MWI reporting over
the SMDI link. The current code could only report a MWI change when the change
was made by someone calling into voicemail. If the change was made by some other
entity (such as with IMAP storage, or with a web interface of some kind), then the
MWI change would never be sent. The SMDI module can now poll for MWI changes if
configured to do so.
This work was inspired by and primarily done for the University of Pennsylvania.
Russell Bryant [Mon, 25 Feb 2008 23:48:16 +0000 (23:48 +0000)]
Merged revisions 104106 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r104106 | russell | 2008-02-25 17:42:42 -0600 (Mon, 25 Feb 2008) | 10 lines
This patch fixes some pretty significant problems with how app_chanspy handles
pointers to channels that are being spied upon. It was very likely that a
crash would occur if the channel being spied upon hung up. This was because
the current ast_channel handling _requires_ that the object is locked or else
it could disappear at any time (except in the owning channel thread). So, this
patch uses some channel datastore magic on the spied upon channel to be able to
detect if and when the channel goes away.
(closes issue #11877)
(patch written by me, but thanks to kpfleming for the idea, and to file for review)
Russell Bryant [Mon, 25 Feb 2008 23:19:31 +0000 (23:19 +0000)]
Merged revisions 104102 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r104102 | russell | 2008-02-25 17:19:05 -0600 (Mon, 25 Feb 2008) | 7 lines
Improve the lock tracking code a bit so that a bunch of old locks that threads
failed to lock don't sit around in the history. When a lock is first locked,
this checks to see if the last lock in the list was one that was failed to be
locked. If it is, then that was a lock that we're no longer sitting in a trylock
loop trying to lock, so just remove it.
(inspired by issue #11712)
Tilghman Lesher [Mon, 25 Feb 2008 23:04:20 +0000 (23:04 +0000)]
Permit additional CDR columns to be saved in Postgres. Note that these
changes are backward-compatible, so no changes to UPGRADE.txt are
necessary.
(closes issue #9279)
Reported by: rottenroddy
Patches:
20080125__bug9279.diff.txt uploaded by Corydon76 (license 14)
Tested by: Corydon76
Tilghman Lesher [Mon, 25 Feb 2008 21:56:19 +0000 (21:56 +0000)]
Shared space for variables (instead of letting other channels muck with your own)
(closes issue #11943)
Reported by: ramonpeek
Patches:
20080208__bug11943__2.diff.txt uploaded by Corydon76 (license 14)
Tested by: jmls
Make it so a users.conf user creates both a SIP peer and a SIP user. The user will be used for inbound authentication for the device, and peer will be used for placing calls to the device.
(closes issue #9044)
Reported by: queuetue
Patches:
sip-gui-friend.diff uploaded by qwell (license 4)
Allow the use of #include and #exec in situations where the max include depth was only 1.
Specifically, this fixes using #include and #exec in extconfig.conf.
This was basically caused because the config file itself raises the include level to 1.
I opted not to raise the include limit, because recursion here could cause very bizarre behavior.
If a resubscription comes in for a dialog we no longer know about tell the remote side that the dialog does not exist so they subscribe again using a new dialog.
(closes issue #10727)
Reported by: s0l4rb03
Patches:
10727-2.diff uploaded by file (license 11)
Due to recent changes tag will no longer be NULL if not present so we have to use ast_strlen_zero to see if it's actually blank.
(closes issue #12061)
Reported by: flefoll
Patches:
chan_sip.c.br14.patch_pedantic_no_totag uploaded by flefoll (license 244)
Tilghman Lesher [Fri, 22 Feb 2008 22:39:21 +0000 (22:39 +0000)]
Allow database password to be NULL and several other cleanups.
(closes issue #12048)
Reported by: bukaj
Patches:
20080222__bug12048.diff.txt uploaded by Corydon76 (license 14)
Tested by: bukaj
Remove an incorrect debug message. It reported that it had received a specific event and tried to report
which event was received. What actually was happening was that it was reporting the number of bytes returned
from a call to read().
Thanks to Jared Smith for bringing the issue up on IRC
Mark Michelson [Thu, 21 Feb 2008 17:44:34 +0000 (17:44 +0000)]
Instead of a notice, make the message about a hung-up channel a debug message, and revert the original
logic on the if statement. Thanks to Juggie for bringing this to my attention.
Doug Bailey [Thu, 21 Feb 2008 17:38:40 +0000 (17:38 +0000)]
Added configuration distinction between neon and fsk mwi detection
Add the detection for neon MWI events
got rid of extraneous handle_init_event call in monitor loop
Joshua Colp [Thu, 21 Feb 2008 16:44:57 +0000 (16:44 +0000)]
Disable epoll as it has caused more obscure issues then any of my previous code. I will continue to work on it in a separate branch to make it stable for a release and test it against the following issues.
(closes issue #11253)
Reported by: falves11
(closes issue #11657)
Reported by: davevg
(closes issue #11033)
Reported by: falves11
Clear up confusion when viewing the QUEUE_WAITING_COUNT of a
"dead" realtime queue. Since from the user's perspective, the queue
does exist, we shouldn't tell them we couldn't find the queue. Instead
since it is a dead queue, report a 0 waiting count
Don't wait for additional digits when overlap dialing is enabled if the setup message contains the sending_complete information element.
(closes issue #11785)
Reported by: klaus3000
Patches:
sending_complete_overlap_asterisk-1.4.17.patch.txt uploaded by klaus3000 (license 65)
Jason Parker [Wed, 20 Feb 2008 21:36:46 +0000 (21:36 +0000)]
Largely refactor DSP tone detection routines.
Separate fax detection from digit detected.
Added CED (called) tone detection for fax (previously, only CNG (calling) was supported).
Separate DTMF/MF code paths where appropriate.
Allow detection of arbitary tones.
Joshua Colp [Tue, 19 Feb 2008 21:54:09 +0000 (21:54 +0000)]
Add a log message that appears when you try to unload a module that isn't loaded.
(closes issue #12033)
Reported by: jamesgolovich
Patches:
asterisk-loader.diff.txt uploaded by jamesgolovich (license 176)
Joshua Colp [Tue, 19 Feb 2008 21:38:39 +0000 (21:38 +0000)]
Only output a log message saying the format does not exist if it actually does not exist, not if the file itself could not be opened.
(closes issue #11828)
Reported by: IgorG
Patches:
readfile.v1.diff uploaded by IgorG (license 20)
Joshua Colp [Tue, 19 Feb 2008 19:27:50 +0000 (19:27 +0000)]
len already contains the position we want to examine, if we move one left again we'll actually probably be looking at a digit.
(issue #12030)
Reported by: alligosh
Joshua Colp [Tue, 19 Feb 2008 18:40:22 +0000 (18:40 +0000)]
Add CHANNELREDIRECT_STATUS variable to ChannelRedirect() dialplan application. This will either be set to NOCHANNEL if the given channel was not found or SUCCESS if it worked.
(closes issue #11553)
Reported by: johan
Patches:
UPGRADE.txt.channelredirect.patch uploaded by johan (license 334)
CHANGES.channelredirect.patch uploaded by johan (license 334)
app_channelredirect-20080219.patch uploaded by johan (license 334)
Jeff Peeler [Tue, 19 Feb 2008 18:14:56 +0000 (18:14 +0000)]
(closes issue #11864)
Reported by: julianjm
Patches:
chan_zap.c-1.4-devicestate-v1.diff uploaded by julianjm (license 99)
Patch fixes problem of device state incorrectly reporting idle before PBX answers incoming call on FXO channel. Device status is updated now during new channel creation.
Ensure that emulated DTMFs do not get interrupted by another begin frame.
(closes issue #11740)
Reported by: gserra
Patches:
v1-11740.patch uploaded by dimas (license 88)
(closes issue #11955)
Reported by: tsearle
(closes issue #10530)
Reported by: xmarksthespot
Joshua Colp [Mon, 18 Feb 2008 23:47:01 +0000 (23:47 +0000)]
Add a non-invasive API for application level manipulation of T38 on a channel. This uses control frames (so they can even pass across IAX2) to negotiate T38 and provided a way of getting the current status of T38 using queryoption. This should by no means cause any issues and if it does I will take responsibility for it.
(closes issue #11873)
Reported by: dimas
Patches:
v4-t38-api.patch uploaded by dimas (license 88)
There was an invalid assumption when calculating the duration of a file that the filestream in question
was created properly. Unfortunately this led to a segfault in the situation where an unknown format was
specified in voicemail.conf and a voicemail was recorded. Now, we first check to be sure that the stream
was written correctly or else assume a zero duration.
When a SIP channel is being auto-destroyed, it's possible for it to still be
in bridge code. When that happens, we crash. Delay the RTP destruction until
the bridge is ended.
(closes issue #11960)
Reported by: norman
Patches:
20080215__bug11960__2.diff.txt uploaded by Corydon76 (license 14)
Tested by: norman
Joshua Colp [Mon, 18 Feb 2008 15:47:00 +0000 (15:47 +0000)]
Add an API call (ast_async_parseable_goto) which parses a goto string and does an async goto instead of an explicit goto.
(closes issue #11753)
Reported by: johan