]> git.ipfire.org Git - thirdparty/bind9.git/log
thirdparty/bind9.git
8 years ago[rt46602] Changes to get tests running on Windows
Stephen Morris [Fri, 26 Jan 2018 19:42:57 +0000 (19:42 +0000)] 
[rt46602] Changes to get tests running on Windows

1. Track changes to conf.sh.in in conf.sh.win32
2. Modifications to prevent Windows "Configure" script replacing
   the sed "@PORT@" substitution tokens in conf.sh.win32.
3. runall.sh now runs Windows tests sequentially

8 years ago[rt46602] Miscellaneous changes to fix rebase issues
Stephen Morris [Thu, 15 Feb 2018 15:58:38 +0000 (15:58 +0000)] 
[rt46602] Miscellaneous changes to fix rebase issues

8 years ago[rt46602] Change name of shell variable holding current test directory
Stephen Morris [Thu, 15 Feb 2018 15:55:57 +0000 (15:55 +0000)] 
[rt46602] Change name of shell variable holding current test directory

It was TESTNAME, but this is an obvious name and was used in one of
the system tests, something that interfered with the content of
progress messages.  It is now SYSTESTDIR.

8 years ago[rt46602] Export environment variables in a portable manner
Michał Kępień [Mon, 29 Jan 2018 11:33:33 +0000 (12:33 +0100)] 
[rt46602] Export environment variables in a portable manner

8 years ago[rt46602] Sanitize test names to fix "make check" on Solaris
Michał Kępień [Mon, 29 Jan 2018 11:08:41 +0000 (12:08 +0100)] 
[rt46602] Sanitize test names to fix "make check" on Solaris

8 years ago[rt46602] Add .gitignore file for catz
Stephen Morris [Fri, 26 Jan 2018 19:37:43 +0000 (19:37 +0000)] 
[rt46602] Add .gitignore file for catz

8 years ago[rt46602] Pass noclean option to Makefile via exported variable
Stephen Morris [Fri, 26 Jan 2018 19:41:47 +0000 (19:41 +0000)] 
[rt46602] Pass noclean option to Makefile via exported variable

8 years ago[rt46602] Mention conf.sh.win32 in instructions for adding a test.
Stephen Morris [Fri, 26 Jan 2018 19:40:12 +0000 (19:40 +0000)] 
[rt46602] Mention conf.sh.win32 in instructions for adding a test.

8 years ago[rt46602] Fix various typos, formatting issues and stylistic nits
Michał Kępień [Thu, 25 Jan 2018 11:29:31 +0000 (12:29 +0100)] 
[rt46602] Fix various typos, formatting issues and stylistic nits

8 years ago[rt46602] Remove redundant variable assignment
Michał Kępień [Thu, 25 Jan 2018 11:23:32 +0000 (12:23 +0100)] 
[rt46602] Remove redundant variable assignment

8 years ago[rt46602] named.port is no longer created by setup.sh for allow_query
Michał Kępień [Thu, 25 Jan 2018 12:57:01 +0000 (13:57 +0100)] 
[rt46602] named.port is no longer created by setup.sh for allow_query

8 years ago[rt46602] Consistently print usage for runall.sh to stderr
Michał Kępień [Thu, 25 Jan 2018 11:49:36 +0000 (12:49 +0100)] 
[rt46602] Consistently print usage for runall.sh to stderr

8 years ago[rt46602] Clean up getopts usage
Michał Kępień [Fri, 26 Jan 2018 12:05:02 +0000 (13:05 +0100)] 
[rt46602] Clean up getopts usage

Ensure case clauses are in sync with the string passed to getopts.
Remove catch-all clauses as they will never be evaluated.

8 years ago[rt46602] Assign default values to variables set by command line options and consiste...
Michał Kępień [Thu, 25 Jan 2018 11:13:19 +0000 (12:13 +0100)] 
[rt46602] Assign default values to variables set by command line options and consistently treat them as integers

8 years ago[rt46602] named.port cannot be ignored by git because it is required to be present...
Michał Kępień [Thu, 25 Jan 2018 12:59:31 +0000 (13:59 +0100)] 
[rt46602] named.port cannot be ignored by git because it is required to be present by notify/ns4

8 years ago[rt46602] Re-add clean.sh invocation to catz/setup.sh
Michał Kępień [Fri, 26 Jan 2018 12:46:46 +0000 (13:46 +0100)] 
[rt46602] Re-add clean.sh invocation to catz/setup.sh

Commit 57aa7b60fd caused catz/setup.sh to no longer call clean.sh, which
results in the catz system test failing on subsequent runs if the first
run is interrupted or fails.

8 years ago[rt46602] Remove option to format the printed start time of a test
Stephen Morris [Thu, 25 Jan 2018 17:47:33 +0000 (17:47 +0000)] 
[rt46602] Remove option to format the printed start time of a test

There was too much incompatibility between operating systems as to
the allowed options for "date".

8 years ago[rt46602] Escape line ends in shell script variable assignment
Stephen Morris [Thu, 25 Jan 2018 14:45:49 +0000 (14:45 +0000)] 
[rt46602] Escape line ends in shell script variable assignment

Escape the line ends in a multi-line variable assignment.  Under some
circumstances, substituting the variable caused syntax errors when
used as the list of values in a shell script "for" statement.

8 years ago[rt46602] Fix EXTRAPORT substitutions in copy_setport
Stephen Morris [Thu, 18 Jan 2018 18:11:07 +0000 (18:11 +0000)] 
[rt46602] Fix EXTRAPORT substitutions in copy_setport

Fix problems where all EXTRAPORT macros were being replaced by
the EXTRAPORT1 value. (Copy and paste issue.)

8 years ago[rt46602] Minor documentation changes
Stephen Morris [Thu, 21 Dec 2017 18:18:17 +0000 (18:18 +0000)] 
[rt46602] Minor documentation changes

8 years ago[rt46602] Correct way allow_query test produces RNDC output
Stephen Morris [Thu, 21 Dec 2017 18:15:50 +0000 (18:15 +0000)] 
[rt46602] Correct way allow_query test produces RNDC output

8 years ago[rt46602] Simplify the cleanup code
Stephen Morris [Thu, 21 Dec 2017 18:14:34 +0000 (18:14 +0000)] 
[rt46602] Simplify the cleanup code

8 years ago[rt46602] Extensions to README
Stephen Morris [Thu, 21 Dec 2017 17:00:08 +0000 (17:00 +0000)] 
[rt46602] Extensions to README

Added descriptions of how nameservers are started and stopped
during the tests, and how the framework cleans up the files created.

8 years ago[rt46602] Miscellenous small changes
Stephen Morris [Wed, 20 Dec 2017 19:14:36 +0000 (19:14 +0000)] 
[rt46602] Miscellenous small changes

8 years ago[rt46602] Handle echoing of multi-line output from tests
Stephen Morris [Wed, 20 Dec 2017 19:11:20 +0000 (19:11 +0000)] 
[rt46602] Handle echoing of multi-line output from tests

8 years ago[rt46602] Rename "test" variable to "systest"
Stephen Morris [Wed, 20 Dec 2017 19:08:57 +0000 (19:08 +0000)] 
[rt46602] Rename "test" variable to "systest"

... to avoid confusion between the variable and the command of the
same name.

8 years ago[rt46602] Add ability to prevent deletion of output files when running all tests
Stephen Morris [Wed, 20 Dec 2017 19:05:59 +0000 (19:05 +0000)] 
[rt46602] Add ability to prevent deletion of output files when running all tests

Some tests may need to examine all output files from all system tests.
Allow the deletion of these files to be inhibited if required.

8 years ago[rt46602] Error messages before start of test are output to stderr
Stephen Morris [Wed, 20 Dec 2017 15:50:03 +0000 (15:50 +0000)] 
[rt46602] Error messages before start of test are output to stderr

Error messages concerning the invocation of run.sh are output to
stderr.  Messages after the test has started are output to stdout.

8 years ago[rt46602] Ensure that output sent to stderr is routed to the output file
Stephen Morris [Wed, 20 Dec 2017 14:54:37 +0000 (14:54 +0000)] 
[rt46602] Ensure that output sent to stderr is routed to the output file

8 years ago[rt46602] Minor tidying up of documentation
Stephen Morris [Wed, 20 Dec 2017 14:53:07 +0000 (14:53 +0000)] 
[rt46602] Minor tidying up of documentation

8 years ago[rt46602] Check prerequsities before network interfaces when running test.
Stephen Morris [Fri, 15 Dec 2017 19:30:55 +0000 (19:30 +0000)] 
[rt46602] Check prerequsities before network interfaces when running test.

8 years ago[rt46602] Minor formatting changes to Perl files
Stephen Morris [Fri, 15 Dec 2017 18:42:52 +0000 (18:42 +0000)] 
[rt46602] Minor formatting changes to Perl files

8 years ago[rt46603] Provide echostart() and echoend() to output test start/end messages.
Stephen Morris [Fri, 15 Dec 2017 18:36:53 +0000 (18:36 +0000)] 
[rt46603] Provide echostart() and echoend() to output test start/end messages.

8 years ago[rt46602] Ensure test output in systests.output is not mixed up
Stephen Morris [Fri, 15 Dec 2017 15:56:33 +0000 (15:56 +0000)] 
[rt46602] Ensure test output in systests.output is not mixed up

When running all the system tests, output from a test is sent to a
test.output file in the test directory.  These are combined in to
systests.output when the run finishes.

8 years ago[rt46602] Miscellaneous minor fixes
Stephen Morris [Thu, 14 Dec 2017 19:13:48 +0000 (19:13 +0000)] 
[rt46602] Miscellaneous minor fixes

... for misspellings, typos, trailing spaces, duplicated lines etc.

8 years ago[rt46602] Allocate 100 ports to each test
Stephen Morris [Thu, 14 Dec 2017 17:17:28 +0000 (17:17 +0000)] 
[rt46602] Allocate 100 ports to each test

8 years ago[rt46602] Pass port numbers to tests via environment variables
Stephen Morris [Thu, 14 Dec 2017 15:02:01 +0000 (15:02 +0000)] 
[rt46602] Pass port numbers to tests via environment variables

8 years ago[rt46602] Ensure parallel tests are in alphabetical order
Stephen Morris [Thu, 14 Dec 2017 14:59:46 +0000 (14:59 +0000)] 
[rt46602] Ensure parallel tests are in alphabetical order

8 years ago[rt46602] Expanded system tests README
Stephen Morris [Fri, 24 Nov 2017 12:55:52 +0000 (12:55 +0000)] 
[rt46602] Expanded system tests README

Add more information on running the tests, together with a section
on how the tests are organised, aimed at new developers.

8 years ago[rt46602] More updates to the test running framework
Stephen Morris [Fri, 24 Nov 2017 12:50:19 +0000 (12:50 +0000)] 
[rt46602] More updates to the test running framework

Tidy up the stop/start files and make switch usage consistent. Also
tidy up the various "clean" targets in the Makefile.

8 years ago[rt46602] Modify some test files to cope with the "-p" flag
Stephen Morris [Fri, 24 Nov 2017 12:24:09 +0000 (12:24 +0000)] 
[rt46602] Modify some test files to cope with the "-p" flag

8 years ago[rt46602] Tidy up run management
Stephen Morris [Thu, 23 Nov 2017 10:02:15 +0000 (10:02 +0000)] 
[rt46602] Tidy up run management

Miscellaneous tidying up of run management.  The most significant
change is that "runall.sh" now runs _all_ the tests, even the
ones that can run in parallel.  runsequential.sh is the script
to run tests that have not been converted to parallel running.

8 years ago[rt46602] Assign block of ports for each test
Stephen Morris [Thu, 23 Nov 2017 09:58:57 +0000 (09:58 +0000)] 
[rt46602] Assign block of ports for each test

Some tests use more ports than just the query and control ports.
Each test that can run in parallel with other tests is now assigned
a unique block of 10 ports.

8 years ago[rt46602] Allow catz system test to run in parallel with other tests
Stephen Morris [Wed, 22 Nov 2017 12:37:17 +0000 (12:37 +0000)] 
[rt46602] Allow catz system test to run in parallel with other tests

8 years ago[rt46602] Miscellaneous changes to existing parallelised tests
Stephen Morris [Fri, 17 Nov 2017 17:29:21 +0000 (17:29 +0000)] 
[rt46602] Miscellaneous changes to existing parallelised tests

Currently these tests are allow_query, rpzrecurse and serve-stale

1. Function to copy files and set port numbers renamed from copy_config
to copy_setports, as this is used to change the ports in Perl and Python
test scripts as well.
2. Changes to rpzrecurse/tests.sh to handle two calls to getopts (one to
parse port numbers, the other to parse rpzrecurse-specific options). Also
fixed various commands to use correct ports.
3. Updates to "clean.sh" scripts to ensure that all files created in the
test are removed.

8 years ago[rt46602] Ensure that tests running in parallel use unique ports
Stephen Morris [Fri, 17 Nov 2017 13:21:05 +0000 (13:21 +0000)] 
[rt46602] Ensure that tests running in parallel use unique ports

Via an intermediate make file, tests that have been modified to be able
to run in parallel are assigned unique query and control port numbers
(other than 5300 and 9953 respectively).  Tests that have not yet been
modified all use ports 5300 and 9953, so must be run sequentially.

8 years ago[rt46602] Miscellaneous tidying up of code cherry-picked from experimental branch
Stephen Morris [Wed, 15 Nov 2017 18:44:54 +0000 (18:44 +0000)] 
[rt46602] Miscellaneous tidying up of code cherry-picked from experimental branch

8 years ago[rt46602] Allow parallel run of new dynamic port tests and the old ones
Ondřej Surý [Wed, 18 Oct 2017 15:20:20 +0000 (17:20 +0200)] 
[rt46602] Allow parallel run of new dynamic port tests and the old ones

8 years ago[rt46602] Put back original .gitignore files in the system tests
Ondřej Surý [Wed, 18 Oct 2017 15:07:06 +0000 (17:07 +0200)] 
[rt46602] Put back original .gitignore files in the system tests

8 years ago[rt46602] Adjust rpzrecurse for dynamic port usage
Ondřej Surý [Wed, 18 Oct 2017 12:56:26 +0000 (14:56 +0200)] 
[rt46602] Adjust rpzrecurse for dynamic port usage

Resolve conflict in run.sh during cherry-pick from an experimental branch.

8 years ago[rt46602] Add $SEDPORTS variable to help with @PORT@ and @CONTROLPORT@ replacement
Ondřej Surý [Wed, 18 Oct 2017 13:11:08 +0000 (15:11 +0200)] 
[rt46602] Add $SEDPORTS variable to help with @PORT@ and @CONTROLPORT@ replacement

8 years ago[rt46602] Move most of ignored files to top of system tests directory
Ondřej Surý [Wed, 18 Oct 2017 12:36:56 +0000 (14:36 +0200)] 
[rt46602] Move most of ignored files to top of system tests directory

8 years ago[rt46602] Fix output from rndc reload
Ondřej Surý [Wed, 18 Oct 2017 12:34:27 +0000 (14:34 +0200)] 
[rt46602] Fix output from rndc reload

8 years ago[rt46602] Add .gitignore to allow_query
Ondřej Surý [Wed, 18 Oct 2017 12:34:11 +0000 (14:34 +0200)] 
[rt46602] Add .gitignore to allow_query

8 years ago[rt46602] Utilize echo_i to allow mixed test output
Ondřej Surý [Wed, 18 Oct 2017 12:23:35 +0000 (14:23 +0200)] 
[rt46602] Utilize echo_i to allow mixed test output

8 years ago[rt46602] Prefix R:<result> as R:<test>:<result>
Ondřej Surý [Wed, 18 Oct 2017 12:20:48 +0000 (14:20 +0200)] 
[rt46602] Prefix R:<result> as R:<test>:<result>

Resolve conflict in run.sh during cherry-pick from experimental branch.

8 years ago[rt46602] Add echo_i function to print I:<testname>:string
Ondřej Surý [Wed, 18 Oct 2017 12:19:28 +0000 (14:19 +0200)] 
[rt46602] Add echo_i function to print I:<testname>:string

8 years ago[rt46602] Add serve-stale working files to .gitignore
Ondřej Surý [Wed, 18 Oct 2017 12:18:59 +0000 (14:18 +0200)] 
[rt46602] Add serve-stale working files to .gitignore

8 years ago[rt46602] Convert allow_query to dynamic port
Ondřej Surý [Wed, 18 Oct 2017 11:38:20 +0000 (13:38 +0200)] 
[rt46602] Convert allow_query to dynamic port

8 years ago[rt46602] Update server-stale test to run on port passed from run.sh script
Ondřej Surý [Wed, 18 Oct 2017 11:01:14 +0000 (13:01 +0200)] 
[rt46602] Update server-stale test to run on port passed from run.sh script

8 years ago[rt46602] Change the system tests script to support running individual tests on diffe...
Ondřej Surý [Wed, 18 Oct 2017 11:00:15 +0000 (13:00 +0200)] 
[rt46602] Change the system tests script to support running individual tests on different ports

Resolved conflict in run.sh.

8 years agoRemove hard copies of RFCs and I-D from BIND repository, the authoritative source...
Ondřej Surý [Fri, 16 Feb 2018 14:55:58 +0000 (15:55 +0100)] 
Remove hard copies of RFCs and I-D from BIND repository, the authoritative source is IETF, and our copies doesn't reflect any errata, expired-by, etc.

8 years agoMerge branch 'gitlab-ci-limit-runners' into 'master'
Michał Kępień [Fri, 16 Feb 2018 11:36:12 +0000 (06:36 -0500)] 
Merge branch 'gitlab-ci-limit-runners' into 'master'

Limit the combination of architectures and distributions that are normally run

See merge request isc-projects/bind9!33

8 years agoMerge branch 'fix-dnstap-output-file-rolling' into 'master'
Michał Kępień [Fri, 16 Feb 2018 10:20:41 +0000 (05:20 -0500)] 
Merge branch 'fix-dnstap-output-file-rolling' into 'master'

Fix dnstap output file rolling

See merge request isc-projects/bind9!21

8 years agoLimit the combination of architectures and distributions that are normally run
Ondřej Surý [Fri, 16 Feb 2018 09:35:12 +0000 (10:35 +0100)] 
Limit the combination of architectures and distributions that are normally run

8 years agoAdd CHANGES entry
Michał Kępień [Fri, 16 Feb 2018 08:38:48 +0000 (09:38 +0100)] 
Add CHANGES entry

4894. [bug] named could crash while rolling a dnstap output file.
[RT #46942]

8 years agoMake dns_dt_send() call dns_dt_reopen() asynchronously
Michał Kępień [Mon, 5 Feb 2018 20:04:39 +0000 (21:04 +0100)] 
Make dns_dt_send() call dns_dt_reopen() asynchronously

Instead of checking current dnstap output file size and potentially
synchronously calling dns_dt_reopen() upon every call to dns_dt_send():

  - call dns_dt_reopen() asynchronously by queuing an event to the task
    specified at dnstap environment creation time,

  - ensure no roll event is outstanding before checking dnstap output
    file size and potentially queuing another roll event.

This causes dnstap output files to exceed their configured size limits,
but prevents any two threads from performing the roll simultaneously
(which causes crashes).

8 years agoMake dns_dt_reopen() request task-exclusive mode on its own
Michał Kępień [Mon, 5 Feb 2018 20:22:53 +0000 (21:22 +0100)] 
Make dns_dt_reopen() request task-exclusive mode on its own

Instead of relying on the caller to set up task-exclusive mode, make
dns_dt_reopen() enforce task-exclusive mode itself, using the task
specified at dnstap environment creation time.

8 years agoAdd dns_dt_create2()
Michał Kępień [Mon, 5 Feb 2018 20:19:44 +0000 (21:19 +0100)] 
Add dns_dt_create2()

Implement a new variant of dns_dt_create() to enable a dnstap
environment structure to hold the task in the context of which
dns_dt_reopen() will be executed.

8 years ago4893. [bug] Address various issues reported by cppcheck. [GL #51]
Mark Andrews [Fri, 16 Feb 2018 02:24:39 +0000 (21:24 -0500)] 
4893.   [bug]           Address various issues reported by cppcheck. [GL #51]

See merge request isc-projects/bind9!26

8 years agoregen master
Tinderbox User [Fri, 16 Feb 2018 01:09:12 +0000 (01:09 +0000)] 
regen master

8 years agos/cppchecker/cppcheck
Mark Andrews [Fri, 16 Feb 2018 00:24:29 +0000 (11:24 +1100)] 
s/cppchecker/cppcheck

8 years agoadd GL issue number
Mark Andrews [Fri, 16 Feb 2018 00:21:16 +0000 (11:21 +1100)] 
add GL issue number

8 years ago[master] add missing release note
Evan Hunt [Fri, 16 Feb 2018 00:19:25 +0000 (16:19 -0800)] 
[master] add missing release note

8 years agoadd CHANGES note
Mark Andrews [Thu, 15 Feb 2018 23:34:49 +0000 (10:34 +1100)] 
add CHANGES note

8 years agonewcopyrights
Tinderbox User [Thu, 15 Feb 2018 23:30:12 +0000 (23:30 +0000)] 
newcopyrights

8 years agoadd POST(len);
Mark Andrews [Thu, 15 Feb 2018 21:41:41 +0000 (08:41 +1100)] 
add POST(len);

8 years agoconditionally declare stacksize
Mark Andrews [Thu, 15 Feb 2018 21:37:33 +0000 (08:37 +1100)] 
conditionally declare stacksize

8 years agoadd POST(len);
Mark Andrews [Thu, 15 Feb 2018 07:18:19 +0000 (18:18 +1100)] 
add POST(len);

8 years agoClarify calculation precedence for '&' and '?'
Mark Andrews [Thu, 15 Feb 2018 07:09:29 +0000 (18:09 +1100)] 
Clarify calculation precedence for '&' and '?'

8 years agoadd POST(tl)
Mark Andrews [Thu, 15 Feb 2018 05:21:57 +0000 (16:21 +1100)] 
add POST(tl)

8 years agoreturn failure count
Mark Andrews [Thu, 15 Feb 2018 05:14:08 +0000 (16:14 +1100)] 
return failure count

8 years agoconditionally declare strbuf
Mark Andrews [Thu, 15 Feb 2018 05:07:01 +0000 (16:07 +1100)] 
conditionally declare strbuf

8 years agotest for == 0 rather than <= as value is unsigned
Mark Andrews [Thu, 15 Feb 2018 05:04:01 +0000 (16:04 +1100)] 
test for == 0 rather than <= as value is unsigned

8 years agoadd brackets
Mark Andrews [Thu, 15 Feb 2018 04:58:19 +0000 (15:58 +1100)] 
add brackets

8 years agoreorder test to silence cppcheck
Mark Andrews [Thu, 15 Feb 2018 04:53:47 +0000 (15:53 +1100)] 
reorder test to silence cppcheck

8 years agoremove event which is only used for sizeof
Mark Andrews [Thu, 15 Feb 2018 04:00:34 +0000 (15:00 +1100)] 
remove event which is only used for sizeof

8 years agoremember the masters count
Mark Andrews [Thu, 15 Feb 2018 03:56:13 +0000 (14:56 +1100)] 
remember the masters count

8 years agoreorder test to silence cppcheck
Mark Andrews [Thu, 15 Feb 2018 03:50:36 +0000 (14:50 +1100)] 
reorder test to silence cppcheck

8 years agouse %u instead of %d
Mark Andrews [Thu, 15 Feb 2018 03:25:37 +0000 (14:25 +1100)] 
use %u instead of %d

8 years agouse %u instead of %d
Mark Andrews [Thu, 15 Feb 2018 03:23:54 +0000 (14:23 +1100)] 
use %u instead of %d

8 years agouse %u instead of %d
Mark Andrews [Thu, 15 Feb 2018 03:23:15 +0000 (14:23 +1100)] 
use %u instead of %d

8 years agouse %u instead of %d
Mark Andrews [Thu, 15 Feb 2018 03:21:42 +0000 (14:21 +1100)] 
use %u instead of %d

8 years agouse %u instead of %d
Mark Andrews [Thu, 15 Feb 2018 03:20:16 +0000 (14:20 +1100)] 
use %u instead of %d

8 years agouse %u instead of %d
Mark Andrews [Thu, 15 Feb 2018 02:43:13 +0000 (13:43 +1100)] 
use %u instead of %d

8 years agouse %u instead of %d
Mark Andrews [Thu, 15 Feb 2018 02:29:22 +0000 (13:29 +1100)] 
use %u instead of %d

8 years agouse %u instead of %d
Mark Andrews [Thu, 15 Feb 2018 02:27:03 +0000 (13:27 +1100)] 
use %u instead of %d

8 years agouse %u instead of %d
Mark Andrews [Thu, 15 Feb 2018 02:26:09 +0000 (13:26 +1100)] 
use %u instead of %d

8 years agouse %u instead of %d
Mark Andrews [Thu, 15 Feb 2018 02:23:11 +0000 (13:23 +1100)] 
use %u instead of %d

8 years agocase to unsigned; reorder expression
Mark Andrews [Thu, 15 Feb 2018 02:20:59 +0000 (13:20 +1100)] 
case to unsigned; reorder expression