]> git.ipfire.org Git - thirdparty/dovecot/core.git/log
thirdparty/dovecot/core.git
2 years agoauth: Don't use the last userdb's default_fields and override_fields if user is not...
Timo Sirainen [Thu, 11 Jan 2024 16:53:37 +0000 (11:53 -0500)] 
auth: Don't use the last userdb's default_fields and override_fields if user is not found there

default_fields and override_fields are supposed to be used only for the
userdbs where the user is actually found. This worked for all userdbs,
except the last one, where they were always used if the userdb lookup
had succeeded.

2 years agoauth: Fix userdb extra fields handling for negative cache entry
Timo Sirainen [Tue, 4 Aug 2020 10:32:19 +0000 (13:32 +0300)] 
auth: Fix userdb extra fields handling for negative cache entry

If negative cache entry was found, it cleared all previous userdb extra
fields.

However, due to other bugs/issues, this was practically never happened to
a successful request.

2 years agoauth: Cache all userdb lookups, not just the last userdb
Timo Sirainen [Fri, 12 Jan 2024 14:45:22 +0000 (09:45 -0500)] 
auth: Cache all userdb lookups, not just the last userdb

2 years agoauth: Fix caching userdb's "user not found" result.
Timo Sirainen [Tue, 4 Aug 2020 10:33:33 +0000 (13:33 +0300)] 
auth: Fix caching userdb's "user not found" result.

The result was changed to "ok" if a previous userdb lookup was already
successful. However, caching is supposed to be independent for each lookup.

This didn't usually break anything, because of another bug that only the
last userdb lookup is cached.

2 years agoconfig: Fix nested non-named filters
Timo Sirainen [Wed, 22 Nov 2023 21:14:16 +0000 (23:14 +0200)] 
config: Fix nested non-named filters

2 years agodoc: Modernize solr9 config and schema
Aki Tuomi [Fri, 22 Dec 2023 07:48:54 +0000 (09:48 +0200)] 
doc: Modernize solr9 config and schema

2 years agodoc: Remove symlink
Aki Tuomi [Fri, 22 Dec 2023 07:48:38 +0000 (09:48 +0200)] 
doc: Remove symlink

There is no default solr.

2 years agolib-master: stats_client_wait() - Increase deinit flush timeout to 60 seconds
Markus Valentin [Thu, 7 Dec 2023 14:59:12 +0000 (15:59 +0100)] 
lib-master: stats_client_wait() - Increase deinit flush timeout to 60 seconds

2 years agoconfig: Remove unused config from main
Aki Tuomi [Tue, 5 Dec 2023 13:25:40 +0000 (15:25 +0200)] 
config: Remove unused config from main

2 years agoconfig: Fix memory leak on config reload
Aki Tuomi [Tue, 5 Dec 2023 13:24:18 +0000 (15:24 +0200)] 
config: Fix memory leak on config reload

2 years agoconfig: Extract config_global_reload()
Aki Tuomi [Tue, 5 Dec 2023 13:22:13 +0000 (15:22 +0200)] 
config: Extract config_global_reload()

2 years agoconfig: Make config_parsed_free() NULL no-op
Aki Tuomi [Tue, 5 Dec 2023 13:36:42 +0000 (15:36 +0200)] 
config: Make config_parsed_free() NULL no-op

2 years agolib-json: json-istream - Fix json_istream_finish() to work in the middle of parsing
Stephan Bosch [Thu, 30 Nov 2023 22:43:11 +0000 (23:43 +0100)] 
lib-json: json-istream - Fix json_istream_finish() to work in the middle of parsing

Skipping the remainder of the input caused an assert failure when skipping means
descending into arrays and objects, rather than only ascending from the last
node hierarchy. Simplified it to fully omit all activities other than parsing by
returning immediately from all parser callbacks once json_istream_finish() is
called.

2 years agoconfig: Fix memory leaks in config parsing
Timo Sirainen [Thu, 30 Nov 2023 19:45:05 +0000 (21:45 +0200)] 
config: Fix memory leaks in config parsing

2 years agolib: lib-event - Free iter in event_categories_iterate_deinit()
Aki Tuomi [Thu, 30 Nov 2023 12:48:41 +0000 (14:48 +0200)] 
lib: lib-event - Free iter in event_categories_iterate_deinit()

Forgotten in 40333adb8015536c3898a4c4f1a10c898dd03cae

2 years agoconfig: Ensure parent->filter_name is not NULL in config_filter_add_new_filter()
Aki Tuomi [Thu, 30 Nov 2023 08:17:01 +0000 (10:17 +0200)] 
config: Ensure parent->filter_name is not NULL in config_filter_add_new_filter()

Satisifies static analysers.

2 years agolib-settings: Ensure set->last_filter_key is not NULL in settings_override_get_value()
Aki Tuomi [Thu, 30 Nov 2023 08:13:58 +0000 (10:13 +0200)] 
lib-settings: Ensure set->last_filter_key is not NULL in settings_override_get_value()

Satisfies static analysers.

2 years agolib-auth-client: Keep pointer for ioloop separate
Aki Tuomi [Thu, 30 Nov 2023 07:37:24 +0000 (09:37 +0200)] 
lib-auth-client: Keep pointer for ioloop separate

Callback might free conn.

2 years agoauth: Remove auth_userdb_settings_check()
Aki Tuomi [Tue, 28 Nov 2023 08:04:01 +0000 (10:04 +0200)] 
auth: Remove auth_userdb_settings_check()

It does not do anything

2 years agolib: net - Ensure addrinfo is NULL on error
Aki Tuomi [Tue, 28 Nov 2023 08:01:31 +0000 (10:01 +0200)] 
lib: net - Ensure addrinfo is NULL on error

Found by static analyser.

2 years agolib-json: json-parser - Fix stream read size calculations in JSON string istream
Stephan Bosch [Tue, 28 Nov 2023 20:54:30 +0000 (21:54 +0100)] 
lib-json: json-parser - Fix stream read size calculations in JSON string istream

2 years agolib-json: json-parser - Rename local variable in json_string_istream_read()
Stephan Bosch [Tue, 28 Nov 2023 20:59:36 +0000 (21:59 +0100)] 
lib-json: json-parser - Rename local variable in json_string_istream_read()

Also restructure its use a bit to make its function more clear.

2 years agoauth: auth-request - Remove auth_request_log_*()
Stephan Bosch [Sun, 22 Oct 2023 23:26:08 +0000 (01:26 +0200)] 
auth: auth-request - Remove auth_request_log_*()

2 years agoauth: auth-request - Log about passdb skipping on main request event
Stephan Bosch [Sun, 22 Oct 2023 23:32:37 +0000 (01:32 +0200)] 
auth: auth-request - Log about passdb skipping on main request event

2 years agoauth: auth-request - Add auth_request_db_log_unknown_user() and use it
Stephan Bosch [Sun, 22 Oct 2023 22:10:23 +0000 (00:10 +0200)] 
auth: auth-request - Add auth_request_db_log_unknown_user() and use it

2 years agoauth: auth-request - Add auth_request_db_log_password_mismatch() and use it
Stephan Bosch [Sun, 22 Oct 2023 22:22:25 +0000 (00:22 +0200)] 
auth: auth-request - Add auth_request_db_log_password_mismatch() and use it

2 years agoauth: auth-request - Add auth_request_db_log_login_failure() and use it
Stephan Bosch [Mon, 23 Oct 2023 00:03:02 +0000 (02:03 +0200)] 
auth: auth-request - Add auth_request_db_log_login_failure() and use it

2 years agoauth: auth-request - Add auth_request_db_password_verify*() and use them
Stephan Bosch [Sun, 22 Oct 2023 23:13:11 +0000 (01:13 +0200)] 
auth: auth-request - Add auth_request_db_password_verify*() and use them

2 years agoauth: auth-request - Use event directly with auth_request_password_verify*()
Stephan Bosch [Sun, 22 Oct 2023 22:49:53 +0000 (00:49 +0200)] 
auth: auth-request - Use event directly with auth_request_password_verify*()

2 years agoauth: auth-request - Use event directly with auth_request_log_unknown_user()
Stephan Bosch [Mon, 23 Oct 2023 00:25:33 +0000 (02:25 +0200)] 
auth: auth-request - Use event directly with auth_request_log_unknown_user()

Drop subsystem parameter. Caller is now providing the event.

2 years agoauth: auth-request - Use event directly with auth_request_log_password_mismatch()
Stephan Bosch [Sun, 22 Oct 2023 22:30:59 +0000 (00:30 +0200)] 
auth: auth-request - Use event directly with auth_request_log_password_mismatch()

Drop subsystem parameter. Caller is now providing the event.

2 years agoauth: auth-request - Use event directly with auth_request_log_login_failure()
Stephan Bosch [Sun, 22 Oct 2023 22:02:36 +0000 (00:02 +0200)] 
auth: auth-request - Use event directly with auth_request_log_login_failure()

Drop subsystem parameter. Caller is now providing the event.

2 years agoauth: auth-request - Use event directly with log_password_failure()
Stephan Bosch [Sun, 22 Oct 2023 21:55:46 +0000 (23:55 +0200)] 
auth: auth-request - Use event directly with log_password_failure()

Drop subsystem parameter. Caller is now providing the event.

2 years agoauth: db-password-file - Replace auth_request_log_info() with e_info()
Stephan Bosch [Sun, 22 Oct 2023 19:27:27 +0000 (21:27 +0200)] 
auth: db-password-file - Replace auth_request_log_info() with e_info()

This also fixes the log prefix.

2 years agoauth: auth-master-connection - Replace auth_request_log_info() with e_info()
Stephan Bosch [Sun, 22 Oct 2023 19:25:14 +0000 (21:25 +0200)] 
auth: auth-master-connection - Replace auth_request_log_info() with e_info()

This also fixes the log prefix.

2 years agoauth: auth-master-connection - Replace auth_request_log_error() with e_error()
Stephan Bosch [Sun, 22 Oct 2023 19:21:24 +0000 (21:21 +0200)] 
auth: auth-master-connection - Replace auth_request_log_error() with e_error()

This also fixes the log prefix.

2 years agoauth: passdb-sql - auth: mech-digest-md5 - Replace auth_request_log_error() with...
Stephan Bosch [Sun, 22 Oct 2023 19:13:29 +0000 (21:13 +0200)] 
auth: passdb-sql -  auth: mech-digest-md5 - Replace auth_request_log_error() with e_error()

2 years agoauth: mech-digest-md5 - Replace auth_request_log_info() with e_info()
Stephan Bosch [Thu, 5 Oct 2023 23:45:19 +0000 (01:45 +0200)] 
auth: mech-digest-md5 - Replace auth_request_log_info() with e_info()

2 years agoauth: mech-digest-md5 - Add local variables for struct auth_request
Stephan Bosch [Tue, 7 Mar 2023 03:22:25 +0000 (04:22 +0100)] 
auth: mech-digest-md5 - Add local variables for struct auth_request

2 years agoauth: auth-request - Add request ID to the event log prefix for worker requests
Stephan Bosch [Fri, 3 Nov 2023 19:46:24 +0000 (20:46 +0100)] 
auth: auth-request - Add request ID to the event log prefix for worker requests

2 years agoauth: auth-request - Add SASL state to the event log prefix
Stephan Bosch [Tue, 24 Oct 2023 12:07:04 +0000 (14:07 +0200)] 
auth: auth-request - Add SASL state to the event log prefix

2 years agoauth: auth-request - Move most of the log prefix to the main request event
Stephan Bosch [Sun, 22 Oct 2023 21:16:22 +0000 (23:16 +0200)] 
auth: auth-request - Move most of the log prefix to the main request event

This way, any request-related logging will have a prefix with all the necessary
information. Before, the main request event had no prefix and when no sub-event
was available no prefix was added to log lines, meaning that the request these
related to could not be determined. Sub-events will now have a smaller
additional prefix that relates to the subsystem alone.

2 years agoauth: auth-request - Move get_log_identifier()
Stephan Bosch [Sun, 22 Oct 2023 20:55:34 +0000 (22:55 +0200)] 
auth: auth-request - Move get_log_identifier()

2 years agoauth: test-mech - Run the test as a master service
Stephan Bosch [Wed, 25 Oct 2023 00:58:26 +0000 (02:58 +0200)] 
auth: test-mech - Run the test as a master service

2 years agoauth: test-auth - Run the test as a master service
Stephan Bosch [Thu, 2 Nov 2023 12:32:27 +0000 (13:32 +0100)] 
auth: test-auth - Run the test as a master service

2 years agoauth: Reformat mech-digest-md5.c
Stephan Bosch [Tue, 7 Mar 2023 03:38:56 +0000 (04:38 +0100)] 
auth: Reformat mech-digest-md5.c

2 years agolib-master: master-service - Improve comment for master_service_set_killed_callback()
Stephan Bosch [Sun, 19 Nov 2023 22:07:25 +0000 (23:07 +0100)] 
lib-master: master-service - Improve comment for  master_service_set_killed_callback()

2 years agoindexer: Remove unused worker-pool.c
Timo Sirainen [Tue, 28 Nov 2023 21:01:44 +0000 (23:01 +0200)] 
indexer: Remove unused worker-pool.c

Forgotten in 093b312e13700ca18a1a8b8c16480ef86565fb84

2 years agofts-solr: Drop solr_old
Marco Bettini [Thu, 23 Nov 2023 13:26:47 +0000 (13:26 +0000)] 
fts-solr: Drop solr_old

2 years agolib-json: test-json-generator - Fix test to reach the last state
Stephan Bosch [Fri, 24 Nov 2023 18:48:50 +0000 (19:48 +0100)] 
lib-json: test-json-generator - Fix test to reach the last state

2 years agoauth: auth-policy - Fix request JSON success field
Stephan Bosch [Fri, 24 Nov 2023 18:37:41 +0000 (19:37 +0100)] 
auth: auth-policy - Fix request JSON success field

It was always emitted as success = true.

Broken by a953dbf8cce1285a27b321eb28ad83f55c083d4f.

2 years agolib-json: json-istream - Clear and dereference stream tree fields early upon error
Stephan Bosch [Fri, 24 Nov 2023 18:15:40 +0000 (19:15 +0100)] 
lib-json: json-istream - Clear and dereference stream tree fields early upon error

2 years agolib-json: json-types - Rename value-get functions for consistency
Stephan Bosch [Fri, 24 Nov 2023 17:59:54 +0000 (18:59 +0100)] 
lib-json: json-types - Rename value-get functions for consistency

2 years agolib-json: json-types - Remove stray definition
Stephan Bosch [Fri, 24 Nov 2023 17:56:44 +0000 (18:56 +0100)] 
lib-json: json-types - Remove stray definition

2 years agolib-json: test-json-io - Add tests for json_text_format*()
Stephan Bosch [Wed, 22 Nov 2023 00:54:53 +0000 (01:54 +0100)] 
lib-json: test-json-io - Add tests for json_text_format*()

2 years agolib-json: json-ostream - Make sure ostream_r is initialized by json_ostream_open_stri...
Stephan Bosch [Tue, 21 Nov 2023 18:03:36 +0000 (19:03 +0100)] 
lib-json: json-ostream - Make sure ostream_r is initialized by json_ostream_open_string_stream()

2 years agolib-json: json-ostream - Fix error handling of json_ostream_write_tree()
Stephan Bosch [Tue, 21 Nov 2023 17:52:17 +0000 (18:52 +0100)] 
lib-json: json-ostream - Fix error handling of json_ostream_write_tree()

2 years agolib-json: json-parser - Fix dead assignment in json_parser_continue()
Stephan Bosch [Tue, 21 Nov 2023 18:49:01 +0000 (19:49 +0100)] 
lib-json: json-parser - Fix dead assignment in json_parser_continue()

2 years agolib-json: json-parser - Remove dead assignment in json_string_istream_read()
Stephan Bosch [Tue, 21 Nov 2023 17:32:55 +0000 (18:32 +0100)] 
lib-json: json-parser - Remove dead assignment in json_string_istream_read()

2 years agolib-json: json-generator - Fix dead assignment in json_generate_string_write_data()
Stephan Bosch [Tue, 21 Nov 2023 18:48:05 +0000 (19:48 +0100)] 
lib-json: json-generator - Fix dead assignment in json_generate_string_write_data()

2 years agolib-json: test-json-istream - Make string input stream tests robust to failure
Stephan Bosch [Tue, 21 Nov 2023 18:49:44 +0000 (19:49 +0100)] 
lib-json: test-json-istream - Make string input stream tests robust to failure

2 years agolib-json: test-json-istream - Fix read result assertion in test_json_istream_error()
Stephan Bosch [Tue, 21 Nov 2023 18:09:26 +0000 (19:09 +0100)] 
lib-json: test-json-istream - Fix read result assertion in test_json_istream_error()

2 years agolib-json: test-json-istream - Fix assertion of read results
Stephan Bosch [Tue, 21 Nov 2023 17:28:19 +0000 (18:28 +0100)] 
lib-json: test-json-istream - Fix assertion of read results

2 years agolib-json: test-json-generator - Remove dead assignment in test_json_generate_stream()
Stephan Bosch [Tue, 21 Nov 2023 17:37:20 +0000 (18:37 +0100)] 
lib-json: test-json-generator - Remove dead assignment in test_json_generate_stream()

2 years agolib-json: test-json-generator - Fix return value assertions
Stephan Bosch [Tue, 21 Nov 2023 17:22:28 +0000 (18:22 +0100)] 
lib-json: test-json-generator - Fix return value assertions

2 years agolib-json: json-istream - Correctly handle NULL pointer for node_r in *_stream()
Stephan Bosch [Tue, 21 Nov 2023 17:05:08 +0000 (18:05 +0100)] 
lib-json: json-istream - Correctly handle NULL pointer for node_r in *_stream()

2 years agolib-json: json-tree - Make use of result from tree addition functions optional
Stephan Bosch [Tue, 21 Nov 2023 13:01:43 +0000 (14:01 +0100)] 
lib-json: json-tree - Make use of result from tree addition functions optional

2 years agolib-json: test-json-tree - Change code line breaks
Stephan Bosch [Tue, 21 Nov 2023 13:16:19 +0000 (14:16 +0100)] 
lib-json: test-json-tree - Change code line breaks

2 years agolib-json: test-json-ostream - Change code line breaks
Stephan Bosch [Tue, 21 Nov 2023 13:14:27 +0000 (14:14 +0100)] 
lib-json: test-json-ostream - Change code line breaks

2 years agolib-json: test-json-tree - Fix dead assignments
Stephan Bosch [Tue, 21 Nov 2023 13:08:38 +0000 (14:08 +0100)] 
lib-json: test-json-tree - Fix dead assignments

2 years agolib-json: test-json-ostream - Fix dead assignments
Stephan Bosch [Tue, 21 Nov 2023 13:08:16 +0000 (14:08 +0100)] 
lib-json: test-json-ostream - Fix dead assignments

2 years agolib-json: test-json-istream - Fix string stream error assertions
Stephan Bosch [Tue, 21 Nov 2023 12:42:29 +0000 (13:42 +0100)] 
lib-json: test-json-istream - Fix string stream error assertions

2 years agolib-json: json-format - Fix error handling
Stephan Bosch [Tue, 21 Nov 2023 12:41:10 +0000 (13:41 +0100)] 
lib-json: json-format - Fix error handling

2 years agolib-json: Fix comments in json-types.h
Stephan Bosch [Mon, 20 Nov 2023 21:40:43 +0000 (22:40 +0100)] 
lib-json: Fix comments in json-types.h

2 years agodoveadm: doveadm-fs - Support setting metadata in put
Aki Tuomi [Mon, 18 Sep 2023 10:42:25 +0000 (13:42 +0300)] 
doveadm: doveadm-fs - Support setting metadata in put

2 years agolib-fs: metawrap - Indicate metadata support
Aki Tuomi [Mon, 18 Sep 2023 10:42:02 +0000 (13:42 +0300)] 
lib-fs: metawrap - Indicate metadata support

Forgotten in c59b9c273b41f7bcf51f6803110b67813879ff05

2 years agofs-crypt: Limit minimum buffer size to 1k
Aki Tuomi [Mon, 18 Sep 2023 10:39:45 +0000 (13:39 +0300)] 
fs-crypt: Limit minimum buffer size to 1k

Otherwise we might not get enough data to decrypt
the stream.

2 years agofs-compress: Limit minimum buffer size to 1k
Aki Tuomi [Mon, 18 Sep 2023 10:38:50 +0000 (13:38 +0300)] 
fs-compress: Limit minimum buffer size to 1k

Otherwise we might not get enough data to decompress
the stream.

2 years agolib-storage: Rebuild list-index using MAILBOX_LIST_ITER_FORCE_RESYNC
Markus Valentin [Wed, 2 Aug 2023 15:07:34 +0000 (17:07 +0200)] 
lib-storage: Rebuild list-index using MAILBOX_LIST_ITER_FORCE_RESYNC

In case the list index file was just created use
MAILBOX_LIST_ITER_FORCE_RESYNC to rediscover mailboxes that might have
been hidden.

2 years agolib-storage: fs_list_entry() - Do not list MAILBOX_NOINFERIORS for index iterations
Markus Valentin [Mon, 6 Nov 2023 10:50:11 +0000 (11:50 +0100)] 
lib-storage: fs_list_entry() - Do not list MAILBOX_NOINFERIORS for index iterations

The index directory is only expected to contain child directories for
mailboxes. Any files in there shouldn't be listed.

2 years agolib-storage: fs_list_entry() - Do not delete \Noselect leaf mailboxes with force...
Markus Valentin [Mon, 30 Oct 2023 13:52:49 +0000 (14:52 +0100)] 
lib-storage: fs_list_entry() - Do not delete \Noselect leaf mailboxes with force-resync

2 years agolib-storage: Allow rediscovering lost mailboxes when using ITERINDEX and LAYOUT=fs
Markus Valentin [Mon, 11 Sep 2023 06:58:00 +0000 (08:58 +0200)] 
lib-storage: Allow rediscovering lost mailboxes when using ITERINDEX and LAYOUT=fs

This is meant to prevent losing mailboxes if the index directory of a
mailbox got lost. A force-resync allows to rediscover and recreate
missing directories.

2 years agodoveadm: cmd_force_resync_run() - Add MAILBOX_LIST_ITER_RAW_LIST
Markus Valentin [Wed, 2 Aug 2023 14:58:48 +0000 (16:58 +0200)] 
doveadm: cmd_force_resync_run() - Add MAILBOX_LIST_ITER_RAW_LIST

This flag makes sure existing indexes are ignored when running a
force-resync.

2 years agolib-storage: Make mailbox_mkdir() public
Markus Valentin [Mon, 11 Sep 2023 07:52:58 +0000 (09:52 +0200)] 
lib-storage: Make mailbox_mkdir() public

2 years agolib-storage: Set iter_from_index_dir directly on mailbox_list_iterate_context
Markus Valentin [Mon, 11 Sep 2023 06:55:29 +0000 (08:55 +0200)] 
lib-storage: Set iter_from_index_dir directly on mailbox_list_iterate_context

2 years agoimap: Suppress permission errors when getmetadata mailbox has wildcards
Marco Bettini [Mon, 30 Oct 2023 16:29:13 +0000 (16:29 +0000)] 
imap: Suppress permission errors when getmetadata mailbox has wildcards

When one of the mailboxes matching the wildcard has ACL permissions "l"
(only lookup, with no extra rights supporting it), it causes a PERM error
that is propagated as either untagged or last tagged response. This fix
allows to skip the offending folders rather report errors in the response.

2 years agoimap: Send NONEXISTENT unconditionally
Marco Bettini [Mon, 6 Nov 2023 11:29:47 +0000 (11:29 +0000)] 
imap: Send NONEXISTENT unconditionally

The response code will always be emitted rather than checkng
for COMMAND_FLAG_USE_NONEXISTENT. Despite what RFC 5530 states,
this behavior is useful for the other commands as well, and it
also is required for imapc GETMETADATA to work properly.

2 years agoimapc: Implement remote getmetadata and setmetadata
Marco Bettini [Thu, 2 Nov 2023 13:06:16 +0000 (13:06 +0000)] 
imapc: Implement remote getmetadata and setmetadata

2 years agoimapc: Add no-metadata feature
Marco Bettini [Thu, 2 Nov 2023 11:02:57 +0000 (11:02 +0000)] 
imapc: Add no-metadata feature

2 years agolib-master: stats_client_deinit() - Unref output ostream
Markus Valentin [Thu, 23 Nov 2023 10:00:02 +0000 (11:00 +0100)] 
lib-master: stats_client_deinit() - Unref output ostream

2 years agolib-master: stats_client_init_unittest() - Set no error handling for ostream
Markus Valentin [Thu, 23 Nov 2023 09:59:29 +0000 (10:59 +0100)] 
lib-master: stats_client_init_unittest() - Set no error handling for ostream

2 years agolib-master: Add asserts to make sure error string is set
Timo Sirainen [Tue, 21 Nov 2023 12:38:57 +0000 (14:38 +0200)] 
lib-master: Add asserts to make sure error string is set

Fixes scan-build complaint.

2 years agolib-master: Fix error handling if config fd wasn't received
Timo Sirainen [Tue, 21 Nov 2023 12:38:41 +0000 (14:38 +0200)] 
lib-master: Fix error handling if config fd wasn't received

2 years agoconfig: Fix potential crash with unknown settings
Timo Sirainen [Tue, 21 Nov 2023 12:34:41 +0000 (14:34 +0200)] 
config: Fix potential crash with unknown settings

2 years agoconfig: Remove dead code
Timo Sirainen [Tue, 21 Nov 2023 12:32:00 +0000 (14:32 +0200)] 
config: Remove dead code

2 years agoconfig: Add data stack frame when dumping filters
Timo Sirainen [Wed, 22 Nov 2023 08:41:47 +0000 (10:41 +0200)] 
config: Add data stack frame when dumping filters

2 years agolib-settings: settings_*get*() - Add data stack frame
Timo Sirainen [Wed, 22 Nov 2023 08:41:29 +0000 (10:41 +0200)] 
lib-settings: settings_*get*() - Add data stack frame

2 years agolib-master: stats_client_wait() - Distinguish between handshake and deinit
Markus Valentin [Tue, 21 Nov 2023 10:25:35 +0000 (11:25 +0100)] 
lib-master: stats_client_wait() - Distinguish between handshake and deinit

stats_client_wait() is used to wait for the handshake response as well
as waiting for the stats flushing on stats_client_deinit(). Previously
the stats_client_deinit() could easily have timed out.

This adds a specific error message for the deinit timeout as well as a
bigger timeout (30 seconds).

2 years agoconfig: Optimize away config exporter creation when it has nothing to export
Timo Sirainen [Mon, 5 Jun 2023 21:07:10 +0000 (00:07 +0300)] 
config: Optimize away config exporter creation when it has nothing to export

2 years agolib-settings: test-settings-parser - Test that invalid setting values aren't accepted
Timo Sirainen [Wed, 31 May 2023 09:31:48 +0000 (12:31 +0300)] 
lib-settings: test-settings-parser - Test that invalid setting values aren't accepted