]>
git.ipfire.org Git - thirdparty/dovecot/core.git/log
Karl Fleischmann [Wed, 3 Aug 2022 12:53:36 +0000 (14:53 +0200)]
imap: Handle rawlogs when starting a compressed communication
The rawlogs should not contain compressed data when starting a
compressed communication channel. This commit amends rawlog management
data on the imap client to keep track of rawlog streams, and
appropriately handle rawlogs when imap compression is enabled.
Karl Fleischmann [Mon, 25 Jul 2022 06:36:22 +0000 (08:36 +0200)]
doveadm-zlib: Retrieve error from deflated stream
Karl Fleischmann [Wed, 20 Jul 2022 14:44:23 +0000 (16:44 +0200)]
imap: Remove imap_compress_deflate_level setting
It was decided that the default compression level is good enough for
most purposes and thus to remove the configuration option.
Karl Fleischmann [Fri, 15 Jul 2022 12:52:50 +0000 (14:52 +0200)]
imap-zlib: Remove plugin sources
Remove the now unused imap-zlib plugin. The functionality is retained
with the core imap command COMPRESS.
Karl Fleischmann [Fri, 15 Jul 2022 12:46:01 +0000 (14:46 +0200)]
imap: Move imap-zlib plugin functionality into imap core
This commit auto-enables the imap's COMPRESS functionality by copying
the imap-zlib plugin functionality into the imap directory and making it
available as the COMPRESS command.
It also disables compilation of the still existing imap-zlib plugin.
Karl Fleischmann [Thu, 4 Aug 2022 15:14:40 +0000 (17:14 +0200)]
global: Make zlib support required for compilation
As zlib is virtually universally available and with version v3.0 dovecot
will require important libraries by default it makes sense to start
requiring this particular library as well.
Timo Sirainen [Thu, 11 Aug 2022 22:44:00 +0000 (01:44 +0300)]
doveadm: Simplify -A (all-users) parameter handling
Change it to internally work the same way as -u '*'
Timo Sirainen [Thu, 11 Aug 2022 19:19:00 +0000 (22:19 +0300)]
doveadm: Fix -F parameter to work again
Broken by recent parameter handling changes.
Timo Sirainen [Fri, 12 Aug 2022 10:26:12 +0000 (13:26 +0300)]
doveadm: Remove unused doveadm_print_unstick_headers()
Timo Sirainen [Thu, 11 Aug 2022 19:16:03 +0000 (22:16 +0300)]
doveadm: Move username printing from server side to client side
The client requests output for only a single user from the server side, so
it makes sense that the client is the one printing the username.
This also changes sticky headers to be usable only for the username.
Unfortunately it's not easy to remove support for sticky header entirely,
because the username must not be printed before the first proper
doveadm_print() call. For example if "doveadm fetch" doesn't find any
mails, it shouldn't print the username either.
Timo Sirainen [Fri, 12 Aug 2022 05:53:19 +0000 (08:53 +0300)]
doveadm mailbox cache decision: Avoid using sticky header
The following changes makes the sticky headers not work quite so well.
Karl Fleischmann [Thu, 11 Aug 2022 14:36:03 +0000 (16:36 +0200)]
m4: want_mysql.m4 - Remove HAVE_OPENSSL definition when detecting mysql features
The HAVE_OPENSSL macro has no effect on the exposed features when
including mysql.h, thus it can be removed from the feature detection.
Karl Fleischmann [Thu, 11 Aug 2022 14:35:46 +0000 (16:35 +0200)]
lib-http: Remove ifdef-conditions based on HAVE_OPENSSL
This macro was removed in
6b0b7141a8a50ffc99ad51b4f27c75f876e58616 but
the test-specific ifdefs weren't.
Karl Fleischmann [Thu, 11 Aug 2022 14:31:40 +0000 (16:31 +0200)]
lib-smtp: Remove ifdef-conditions based on HAVE_OPENSSL
This macro was removed in
6b0b7141a8a50ffc99ad51b4f27c75f876e58616 but
the test-specific ifdefs weren't.
Timo Sirainen [Mon, 25 Jul 2022 16:26:47 +0000 (19:26 +0300)]
lib-imap-storage, imap: imap_msgpart_url_parse() - Change to return only 0/-1
It was previously never returning -1.
Timo Sirainen [Mon, 25 Jul 2022 16:21:44 +0000 (19:21 +0300)]
lib-imap-urlauth: Cleanup - Remove unnecessary ret assignment
Timo Sirainen [Mon, 25 Jul 2022 16:19:32 +0000 (19:19 +0300)]
lib-imap-storage: imap_msgpart_url_parse() - Fix return value for client errors
If imap_msgpart_url_create() fails, it's always due to invalid client input
rather than due to a storage error.
Timo Sirainen [Mon, 25 Jul 2022 16:18:16 +0000 (19:18 +0300)]
imap: If CATENATE processing stops, skip the rest of the command line
This fixes sending duplicate tagged reply or "Invalid tag" reply.
Timo Sirainen [Mon, 25 Jul 2022 16:17:49 +0000 (19:17 +0300)]
imap: APPEND - Fix CATENATE error message when URL/TEXT is missing the string
Timo Sirainen [Mon, 25 Jul 2022 16:14:33 +0000 (19:14 +0300)]
imap: APPEND - Fix crash if CATENATE list ends with URL atom but without the URL string
Timo Sirainen [Mon, 25 Jul 2022 16:47:34 +0000 (19:47 +0300)]
lib-index: Makefile.am - Fix double-linking of mail-index-util.o
This fixes linking with slibtool.
Timo Sirainen [Tue, 9 Aug 2022 08:09:26 +0000 (11:09 +0300)]
fts: Fix crash in expunge log event handling
fts_expunge_log_flat_write() was trying to access ->log->event, but the
read_log parameter was created by fts_expunge_log_flatten(), which leaves
the log NULL.
Broken by
0588f98a337c17de67dabea52fde20e1a0640fc3
Markus Valentin [Wed, 27 Jul 2022 13:42:58 +0000 (15:42 +0200)]
imapc: imapc_connection_init() - Call event_set_append_log_prefix()
Update logging calls accordingly.
Markus Valentin [Wed, 27 Jul 2022 13:28:16 +0000 (15:28 +0200)]
imapc: Introduce imapc_connection specific event
Markus Valentin [Fri, 5 Aug 2022 12:07:06 +0000 (14:07 +0200)]
imapc: imapc_client_init() - Add event_set_forced_debug() call
Marco Bettini [Tue, 12 Jul 2022 08:51:27 +0000 (08:51 +0000)]
plugins: zlib - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 12 Jul 2022 12:16:54 +0000 (12:16 +0000)]
plugins: welcome - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 12 Jul 2022 08:51:57 +0000 (08:51 +0000)]
plugins: virtual - Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 7 Jul 2022 14:00:29 +0000 (14:00 +0000)]
plugins: trash - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 26 Jul 2022 10:25:48 +0000 (10:25 +0000)]
plugins: replication - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 26 Jul 2022 10:23:37 +0000 (10:23 +0000)]
plugins: replication_fifo_notify() - Unnest return checks
Marco Bettini [Tue, 12 Jul 2022 09:12:17 +0000 (09:12 +0000)]
plugins: quota - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 12 Jul 2022 09:39:21 +0000 (09:39 +0000)]
plugins: pop3-migration - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 12 Jul 2022 10:30:52 +0000 (10:30 +0000)]
plugins: notify-status - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 12 Jul 2022 09:52:59 +0000 (09:52 +0000)]
plugins: mail-log - Replace i_<log>() with e_<log>()
Marco Bettini [Mon, 1 Aug 2022 09:28:09 +0000 (09:28 +0000)]
plugins: mail-log - Drop MAIL_LOG_FIELD_BOX from MAIL_LOG_DEFAULT_FIELDS
the prefix is now already injected in box->event, so adding it here too becomes redundant
Marco Bettini [Thu, 7 Jul 2022 14:21:38 +0000 (14:21 +0000)]
plugins: mail-crypt - Replace i_debug() with e_debug()
Marco Bettini [Tue, 12 Jul 2022 10:09:10 +0000 (10:09 +0000)]
plugins: last-login - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 12 Jul 2022 10:43:24 +0000 (10:43 +0000)]
plugins: imap-zlib - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 12 Jul 2022 10:08:56 +0000 (10:08 +0000)]
plugins: imap-quota - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 12 Jul 2022 10:09:40 +0000 (10:09 +0000)]
plugins: fts-solr - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 12 Jul 2022 10:09:24 +0000 (10:09 +0000)]
plugins: fts - Replace i_<log>() with e_<log>()
Marco Bettini [Wed, 27 Jul 2022 14:55:09 +0000 (14:55 +0000)]
plugins: fts - Pass event into fts_indexer_cmd
Marco Bettini [Mon, 1 Aug 2022 09:12:53 +0000 (09:12 +0000)]
plugins: fts - Add event to struct fts_parser_context
Marco Bettini [Thu, 28 Jul 2022 15:38:53 +0000 (15:38 +0000)]
plugins: fts - Add event to struct fts_expunge_log
Marco Bettini [Thu, 28 Jul 2022 15:20:41 +0000 (15:20 +0000)]
plugins: fts - Add event to struct script_fts_parser
Marco Bettini [Wed, 27 Jul 2022 12:40:43 +0000 (12:40 +0000)]
plugins: fts - Add event to struct fts_backend
Marco Bettini [Tue, 12 Jul 2022 10:08:42 +0000 (10:08 +0000)]
plugins: charset-alias - Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 7 Jul 2022 14:43:03 +0000 (14:43 +0000)]
plugins: acl - Replace i_<log>() with e_<log>()
Marco Bettini [Fri, 15 Jul 2022 13:23:23 +0000 (13:23 +0000)]
plugins: struct acl_backend - Add event
Marco Bettini [Fri, 5 Aug 2022 08:48:55 +0000 (08:48 +0000)]
plugins: Remove stray whitespaces
Marco Bettini [Fri, 8 Jul 2022 10:46:34 +0000 (10:46 +0000)]
lib-storage: index/pop3c - Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 7 Jul 2022 08:01:10 +0000 (08:01 +0000)]
lib-storage: index/mbox - Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 7 Jul 2022 08:01:09 +0000 (08:01 +0000)]
lib-storage: index/maildir - Replace i_<log>() with e_<log>()
Marco Bettini [Fri, 8 Jul 2022 13:11:49 +0000 (13:11 +0000)]
lib-storage: index/imapc - Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 7 Jul 2022 08:01:09 +0000 (08:01 +0000)]
lib-storage: index/dbox-multi - Replace i_<log>() with e_<log>()
Marco Bettini [Thu, 7 Jul 2022 08:01:09 +0000 (08:01 +0000)]
lib-storage: index/dbox-single - Replace i_<log>() with e_<log>()
Marco Bettini [Mon, 11 Jul 2022 07:30:58 +0000 (07:30 +0000)]
lib-storage: index/dbox-common - Replace i_<log>() with e_<log>()
Marco Bettini [Tue, 19 Jul 2022 12:27:04 +0000 (12:27 +0000)]
lib-storage: index - Replace i_<log>() with e_<log>()
Marco Bettini [Mon, 18 Jul 2022 12:59:13 +0000 (12:59 +0000)]
lib-storage: service_auth_userdb_lookup() - Replace i_debug() with e_debug()
Marco Bettini [Thu, 7 Jul 2022 08:30:10 +0000 (08:30 +0000)]
lib-storage: mail_storage_service_lookup_real() - Anticipate the creation of the event before service_auth_userdb_lookup()
Marco Bettini [Tue, 19 Jul 2022 10:31:53 +0000 (10:31 +0000)]
lib-storage: Add prefix to storage event
Marco Bettini [Mon, 1 Aug 2022 10:04:15 +0000 (10:04 +0000)]
lib-storage: Factor in sanitize_box_name()
Martti Rannanjärvi [Fri, 3 Jun 2022 08:15:05 +0000 (11:15 +0300)]
auth: userdb - Stop calling USERDB_RESULT_OK after template expansion failure
Call only USERDB_RESULT_INTERNAL_FAILURE. This was broken by
0f5dc4da3982053036be65190e44bf28a67b1ca2 .
Timo Sirainen [Fri, 8 Jul 2022 13:33:14 +0000 (16:33 +0300)]
login-common: Fail early if redirection destination has empty hostname
Timo Sirainen [Fri, 8 Jul 2022 13:32:38 +0000 (16:32 +0300)]
lmtp: Use hostname (not IP) for proxy_redirect_host_next
This makes it consistent with login-common and doveadm.
Timo Sirainen [Wed, 3 Aug 2022 09:23:09 +0000 (12:23 +0300)]
lib-http: Fix unlimited size parameters for i_stream_create_limit()
The type is uoff_t, not size_t, so the value should be UOFF_T_MAX.
Timo Sirainen [Wed, 3 Aug 2022 09:22:31 +0000 (12:22 +0300)]
lib-http: Wrap server response payload istream into istream-limit
This way if the underlying istream is accessed by other code, lib-http won't
be affected by the seek offset changes.
Timo Sirainen [Wed, 3 Aug 2022 09:05:57 +0000 (12:05 +0300)]
lib-http: Wrap client request payload istream into istream-limit
This way if the underlying istream is accessed by other code, lib-http won't
be affected by the seek offset changes.
Karl Fleischmann [Wed, 27 Jul 2022 13:50:48 +0000 (15:50 +0200)]
m4: dovecot.m4 - Make C standard check aware of autoconf version
Version 2.70 of autoconf deprecated AC_PROG_CC_C99 in favor of using
different cache veriables that are set by AC_PROG_CC. This commit uses
the appropriate mechanism depending on the m4 version used.
Karl Fleischmann [Wed, 27 Jul 2022 13:11:25 +0000 (15:11 +0200)]
m4: dovecot.m4 - Fix formatting
Replace indentation of C99 checks from tabs/arbitrary numbered spaces to
consistent indenting with 2 spaces per level.
Karl Fleischmann [Wed, 27 Jul 2022 12:55:11 +0000 (14:55 +0200)]
configure: Remove obsolescent AC_HEADER_STDC macro
As per the documentation current systems have the relevant headers
included, so the check is unnecessary.
Timo Sirainen [Fri, 29 Jul 2022 12:49:09 +0000 (15:49 +0300)]
lib-lua: Add dovecot.net_ip_family()
This returns the family of the IP address, or 0 if it's not a valid IP.
Markus Valentin [Fri, 29 Jul 2022 07:53:50 +0000 (09:53 +0200)]
virtual: virtual_get_storage() - Fix error handling
Broken by
aeedbb12e74610d83830050297424cf1507fe199
Timo Sirainen [Thu, 28 Jul 2022 10:11:35 +0000 (13:11 +0300)]
lib-test: fuzzer_t_strndup_replace_zero() - Fix NUL termination
Markus Valentin [Fri, 22 Jul 2022 08:40:34 +0000 (10:40 +0200)]
doveadm: Add missing doveadm_client_unref()
doveadm_client_unref() got required to be called, but got forgotten to
be added in doveadm_cmd_callback.
Broken in
24c1c355bb46a3a824573467f887972ad13a33cb
Markus Valentin [Wed, 27 Jul 2022 11:48:10 +0000 (13:48 +0200)]
lib-storage: Add istream_broken field to struct index_mail_data
To prevent correctly cached information being marked as corrupted
by an broken mail input stream use istream_broken flag.
Timo Sirainen [Mon, 25 Jul 2022 10:06:53 +0000 (13:06 +0300)]
Timo Sirainen [Mon, 25 Jul 2022 09:47:37 +0000 (12:47 +0300)]
lib: mmap_get_page_size() - Assert that sysconf() return value is valid
Timo Sirainen [Mon, 25 Jul 2022 09:35:02 +0000 (12:35 +0300)]
anvil: Use time_to_uint32() to cast time_t to unsigned int where needed
This was forgotten in earlier changes.
Marco Bettini [Mon, 25 Jul 2022 09:16:09 +0000 (09:16 +0000)]
lib-imap: fuzz-imap-bodystructure - fix inverted case/ignorecase calls
Aki Tuomi [Fri, 22 Jul 2022 06:49:49 +0000 (09:49 +0300)]
lmtp: lmtp-proxy - Fix memory leak
auth_pool is not always free'd.
Broken in
f8d778ecea227290f87f6666e991289b3b51b37a
Marco Bettini [Thu, 7 Jul 2022 12:47:05 +0000 (12:47 +0000)]
auth: Remove explicit auth_verbose checks in logging
This way the e_info() is logged also when it matches log_debug, even if auth_verbose=no.
Marco Bettini [Thu, 7 Jul 2022 12:36:56 +0000 (12:36 +0000)]
login-common: login_settings_check() - Stop cascading auth_debug_passwords -> auth_debug -> auth_verbose
Marco Bettini [Thu, 30 Jun 2022 14:05:26 +0000 (14:05 +0000)]
config: Inject category=auth into log_debug when auth_debug=yes
Restores the (deprecated) behavior for auth_debug=yes to before
d49f5b30 . Note that module loading debug lines will NOT appear anymore.
Aki Tuomi [Tue, 19 Jul 2022 10:29:44 +0000 (13:29 +0300)]
login-common: Rename AUTH_PLAINTEXT_DISABLED_MSG to AUTH_CLEARTEXT_DISABLED_MSG
Aki Tuomi [Fri, 15 Jul 2022 05:53:39 +0000 (08:53 +0300)]
login-common: Use AUTH_PLAINTEXT_DISABLED_MSG in sasl-server
For consistency
Aki Tuomi [Fri, 15 Jul 2022 05:47:28 +0000 (08:47 +0300)]
login-common: Send BAD alert about cleartext login attempt with AUTHENTICATE too
Aki Tuomi [Fri, 15 Jul 2022 05:18:07 +0000 (08:18 +0300)]
login-common: Change plaintext to cleartext on login error
Marco Bettini [Wed, 20 Jul 2022 13:58:13 +0000 (13:58 +0000)]
push-notification: Replace i_<log>() with e_<log>()
Marco Bettini [Wed, 20 Jul 2022 13:40:44 +0000 (13:40 +0000)]
push-notification: struct push_notification_event_config - Add and propagate log_event
Marco Bettini [Wed, 20 Jul 2022 13:51:05 +0000 (13:51 +0000)]
push-notification: dlog - Introduce driver and transaction log events
Aki Tuomi [Thu, 14 Jul 2022 10:59:48 +0000 (13:59 +0300)]
config: Handle disable_plaintext_auth in old-set-parser
Aki Tuomi [Thu, 14 Jul 2022 07:53:53 +0000 (10:53 +0300)]
example-config: Replace disable_plaintext_auth with auth_allow_cleartext
Aki Tuomi [Thu, 14 Jul 2022 07:53:32 +0000 (10:53 +0300)]
director: Change disable_plaintext_auth to auth_allow_cleartext
Aki Tuomi [Thu, 14 Jul 2022 07:48:50 +0000 (10:48 +0300)]
login: Rename disable_plaintext_auth to auth_allow_cleartext
The old setting is too often confused for PLAIN mechanism,
the new setting makes it more clear that we are talking
about lack of confidentiality, and not actual mechs.
Marco Bettini [Fri, 15 Jul 2022 12:51:53 +0000 (12:51 +0000)]
lib-imap: remove_newlines_and_append() - Drop unnecessary +1 in t_str_new() call
Marco Bettini [Tue, 19 Jul 2022 09:16:05 +0000 (09:16 +0000)]
lib-imap: remove_newlines_and_append() - Clarify what function does
Marco Bettini [Fri, 15 Jul 2022 09:19:27 +0000 (09:19 +0000)]
lib-imap: fuzz-imap-bodystructure - Handle CR/LF suppression operated on nstrings
Aki Tuomi [Mon, 18 Jul 2022 10:02:59 +0000 (13:02 +0300)]
lib-doveadm: Add return to luaL_error in lua_doveadm_client_cmd
Satisfies static analyzers.