]>
git.ipfire.org Git - thirdparty/freeradius-server.git/log
Alan T. DeKok [Wed, 18 Jan 2023 19:10:42 +0000 (14:10 -0500)]
pull OSS-FUZZ patches in.
And rework them to follow our normal processes
Alan T. DeKok [Wed, 18 Jan 2023 01:00:36 +0000 (20:00 -0500)]
use *p_result for "current interpreter result"
request->rcode should really be a cached version, and should
maybe not even exist at all.
Alan T. DeKok [Tue, 17 Jan 2023 21:58:13 +0000 (16:58 -0500)]
typo
Alan T. DeKok [Tue, 17 Jan 2023 21:28:07 +0000 (16:28 -0500)]
sample tacacs client and configuration
Alan T. DeKok [Tue, 17 Jan 2023 21:27:47 +0000 (16:27 -0500)]
TACACS+ client connections always start at 1, and increment by 2
Alan T. DeKok [Tue, 17 Jan 2023 20:49:30 +0000 (15:49 -0500)]
track outstanding status, not u->packet
because once we write the packet, we throw away all of the encoded
data.
Alan T. DeKok [Tue, 17 Jan 2023 20:29:20 +0000 (15:29 -0500)]
track packets in the written buffer a bit better
Alan T. DeKok [Tue, 17 Jan 2023 20:11:10 +0000 (15:11 -0500)]
various minor fixes
Alan T. DeKok [Tue, 17 Jan 2023 20:10:46 +0000 (15:10 -0500)]
initialize h->send after setting send_buff_actual
Alan T. DeKok [Tue, 17 Jan 2023 20:09:15 +0000 (15:09 -0500)]
fix typos
Alan T. DeKok [Tue, 17 Jan 2023 20:08:40 +0000 (15:08 -0500)]
comment out until we double-check it
Alan T. DeKok [Tue, 17 Jan 2023 20:08:05 +0000 (15:08 -0500)]
typo
Alan T. DeKok [Tue, 17 Jan 2023 19:22:19 +0000 (14:22 -0500)]
allow it to run for tacclient
Alan T. DeKok [Tue, 17 Jan 2023 19:20:33 +0000 (14:20 -0500)]
typo
Alan T. DeKok [Tue, 17 Jan 2023 19:01:55 +0000 (14:01 -0500)]
allow for empty or non-existent secrets
Alan T. DeKok [Tue, 17 Jan 2023 19:01:25 +0000 (14:01 -0500)]
it helps to parse the io_submodule
Alan T. DeKok [Tue, 17 Jan 2023 18:52:56 +0000 (13:52 -0500)]
Packet-Type does not map to codes in the packet
it's a synthetic type created during the packet decoding
Alan T. DeKok [Tue, 17 Jan 2023 15:28:50 +0000 (10:28 -0500)]
first pass of fixing statistics
They still don't work, but at least there's a path forward
Nick Porter [Mon, 16 Jan 2023 18:40:38 +0000 (18:40 +0000)]
Debian sid and Ubuntu >= 22.04 use OpenSSL v3
Nick Porter [Mon, 16 Jan 2023 18:03:36 +0000 (18:03 +0000)]
Work round for eapol_test not compiling on debian sid
Nick Porter [Mon, 16 Jan 2023 18:03:04 +0000 (18:03 +0000)]
Bump hostap to latest released version
Alan T. DeKok [Mon, 16 Jan 2023 15:37:37 +0000 (10:37 -0500)]
remove unused assignment
Alan T. DeKok [Mon, 16 Jan 2023 14:20:08 +0000 (09:20 -0500)]
it would help if the local compiler was as picky as CI
Alan T. DeKok [Mon, 16 Jan 2023 13:55:08 +0000 (08:55 -0500)]
more NDEBUG
Alan T. DeKok [Mon, 16 Jan 2023 13:34:26 +0000 (08:34 -0500)]
remove unused variable
Alan T. DeKok [Mon, 16 Jan 2023 13:26:52 +0000 (08:26 -0500)]
clean up "todos"
Alan T. DeKok [Mon, 16 Jan 2023 13:26:34 +0000 (08:26 -0500)]
allow for and initialize retries
Alan T. DeKok [Mon, 16 Jan 2023 13:13:31 +0000 (08:13 -0500)]
do retries
we don't actually resend the packets for TCP, but a retransmit
timer allows the packets to fail over from one connection to another
Alan T. DeKok [Mon, 16 Jan 2023 13:12:25 +0000 (08:12 -0500)]
reset can also reset the timer
Alan T. DeKok [Mon, 16 Jan 2023 13:05:54 +0000 (08:05 -0500)]
ctype macros should take explicitly unsigned input
to avoid chars with high bits being converted to negative numbers
perl -p -i -e 's/(tolower|toupper|isupper|islower|isdigit|isalpha|isspace|isxdigit)\(\s*\*/${1}((uint8_t) */g' $(find . -name "*.[ch]" -print)
perl -p -i -e 's/(tolower|toupper|isupper|islower|isdigit|isalpha|isspace|isxdigit)\(\(int\)/${1}((uint8_t)/g' $(find . -name "*.[ch]" -print)
Alan T. DeKok [Fri, 13 Jan 2023 21:56:48 +0000 (16:56 -0500)]
add TCP output which is compile-tested.
The basic logic should be mostly correct. The timers haven't
been double-checked, so they're likely off. But it's a good start
Nick Porter [Mon, 16 Jan 2023 12:28:03 +0000 (12:28 +0000)]
Explicitly ignore return code (CID #
1519000 )
Nick Porter [Mon, 16 Jan 2023 12:06:47 +0000 (12:06 +0000)]
Remove useless code (CID #
1519003 )
Nick Porter [Mon, 16 Jan 2023 11:49:36 +0000 (11:49 +0000)]
Use MEM() to add safety check (CID #
1519004 )
Nick Porter [Mon, 16 Jan 2023 10:37:17 +0000 (10:37 +0000)]
Use print_hex() to dump hex data
Nick Porter [Fri, 13 Jan 2023 18:05:38 +0000 (18:05 +0000)]
Use accessor function for PyFrameObject members on python >= 3.10
Arran Cudbard-Bell [Fri, 13 Jan 2023 23:23:39 +0000 (17:23 -0600)]
Fix comment
Jorge Pereira [Wed, 11 Jan 2023 22:37:24 +0000 (19:37 -0300)]
Add function for set global library directory
Alan T. DeKok [Fri, 13 Jan 2023 21:36:59 +0000 (16:36 -0500)]
grumble
Alan T. DeKok [Fri, 13 Jan 2023 20:37:39 +0000 (15:37 -0500)]
remove unused variable
Alan T. DeKok [Fri, 13 Jan 2023 18:37:32 +0000 (13:37 -0500)]
add and use fr_tacacs_packet_log_hex()
Which makes my head hurt, because the TACACS+ packet format
was created by drunken orangutans throwing darts at a pumpkin.
The resulting Jackson Pollock eyesore was the published as
a work of utter genius.
Alan T. DeKok [Fri, 13 Jan 2023 17:20:11 +0000 (12:20 -0500)]
Revert "fix decode_args() function"
This reverts commit
0aa0f42d90b15366ab79ac364d55b45cffae7a60 .
Alan T. DeKok [Fri, 13 Jan 2023 03:38:07 +0000 (22:38 -0500)]
run busy loop over 1msec. Fixes #4846 in a clearer manner.
Pleas enter the commit message for your changes. Lines starting
Alan T. DeKok [Sat, 7 Jan 2023 16:30:39 +0000 (11:30 -0500)]
first draft of "front end" for TACACS+ client
Alan T. DeKok [Sat, 7 Jan 2023 13:58:35 +0000 (08:58 -0500)]
move commonly used functions to the trunk code
There's no need to reproduce these in multiple client IO modules.
Alan T. DeKok [Fri, 6 Jan 2023 22:10:08 +0000 (17:10 -0500)]
fix decode_args() function
the arg_list does *not* start at the body of the packet. Instead,
it starts after the fixed arguments have been decoded.
Alan T. DeKok [Fri, 6 Jan 2023 21:55:46 +0000 (16:55 -0500)]
no need to update the output ptr
Alan T. DeKok [Fri, 6 Jan 2023 16:25:27 +0000 (11:25 -0500)]
print packet name, too
so that the _msg argument to the macro is used
Alan T. DeKok [Fri, 6 Jan 2023 15:13:03 +0000 (10:13 -0500)]
allow parsing expressions on the RHS of edit instructions
the compiler doesn't do anything with them yet, but the parsing
seems to work.
Alan T. DeKok [Tue, 3 Jan 2023 15:29:12 +0000 (10:29 -0500)]
we don't support "filter" any more
Alan T. DeKok [Tue, 3 Jan 2023 15:29:01 +0000 (10:29 -0500)]
remove extraneous brackets
Alan T. DeKok [Tue, 3 Jan 2023 15:07:54 +0000 (10:07 -0500)]
make the skip condition code a bit more generic
Alan T. DeKok [Sat, 31 Dec 2022 15:43:20 +0000 (10:43 -0500)]
don't resolve enums here, the caller should do that
Alan T. DeKok [Sat, 31 Dec 2022 15:41:57 +0000 (10:41 -0500)]
hoist rcode parsing
so that tmpl_tokenize functions don't need to parse bare words
as enums
Arran Cudbard-Bell [Thu, 12 Jan 2023 22:04:09 +0000 (16:04 -0600)]
Include talloc headers in atexit code and fix erroneous uses of include <talloc.h>
Arran Cudbard-Bell [Thu, 12 Jan 2023 22:00:36 +0000 (16:00 -0600)]
Punctuation
Arran Cudbard-Bell [Thu, 12 Jan 2023 21:58:42 +0000 (15:58 -0600)]
Add generic talloc free function for the atexit code
Arran Cudbard-Bell [Thu, 12 Jan 2023 20:17:47 +0000 (14:17 -0600)]
Just create two fr_atexit_global_once macros
One that returns values, one that doesn't
Arran Cudbard-Bell [Thu, 12 Jan 2023 19:52:29 +0000 (13:52 -0600)]
...as demonstrated by these
Arran Cudbard-Bell [Thu, 12 Jan 2023 19:43:31 +0000 (13:43 -0600)]
Type and func macros don't use semicolons in other places
Arran Cudbard-Bell [Thu, 12 Jan 2023 19:43:16 +0000 (13:43 -0600)]
Another attempt at accepting NULL macro args
Arran Cudbard-Bell [Thu, 12 Jan 2023 19:06:20 +0000 (13:06 -0600)]
Allow global at exit init functions to return error codes
Arran Cudbard-Bell [Thu, 12 Jan 2023 19:06:02 +0000 (13:06 -0600)]
Too many semicolons
Arran Cudbard-Bell [Thu, 12 Jan 2023 18:40:34 +0000 (12:40 -0600)]
Fix -Werror=address complaints... maybe
Arran Cudbard-Bell [Thu, 12 Jan 2023 16:08:28 +0000 (10:08 -0600)]
Allow NULL init and free functions for fr_atexit_global_once
Nick Porter [Wed, 21 Dec 2022 19:25:07 +0000 (19:25 +0000)]
Tests for slab allocator
Nick Porter [Wed, 21 Dec 2022 19:09:55 +0000 (19:09 +0000)]
Define a talloc based slab allocator
Allows regularly re-used objects to be allocated from a slab once and
reused.
Arran Cudbard-Bell [Wed, 11 Jan 2023 15:24:07 +0000 (09:24 -0600)]
Just sneak this in there...
Arran Cudbard-Bell [Wed, 11 Jan 2023 15:09:02 +0000 (09:09 -0600)]
Fix rpmbuilding for Alma Linux
Arran Cudbard-Bell [Tue, 10 Jan 2023 20:33:48 +0000 (14:33 -0600)]
Remove confe file
Arran Cudbard-Bell [Tue, 10 Jan 2023 20:28:29 +0000 (14:28 -0600)]
rpmbuild really wants these flags together
Arran Cudbard-Bell [Tue, 10 Jan 2023 20:24:52 +0000 (14:24 -0600)]
Doesn't seem necessary to use perl here... and rpmbuild seems to sub it anyway
Jorge Pereira [Tue, 10 Jan 2023 16:50:30 +0000 (13:50 -0300)]
Fix typo. refs #4836 (#4843)
Arran Cudbard-Bell [Tue, 10 Jan 2023 16:15:10 +0000 (10:15 -0600)]
Force openSSL version check literals to unsigned long
Nick Porter [Tue, 10 Jan 2023 11:50:16 +0000 (11:50 +0000)]
Correct syntax of debug_ policies
Terry Burton [Mon, 9 Jan 2023 23:24:09 +0000 (23:24 +0000)]
rlm_rest: Prefer the Content-Type provided in a REST-HTTP-Header attribute (#4841)
* rlm_rest: Prefer the Content-Type provided in a REST-HTTP-Header attribute
* More than just SP is allowed between header attributes and values
* Simplify content_type use
Co-authored-by: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Nick Porter [Mon, 9 Jan 2023 13:36:42 +0000 (13:36 +0000)]
eapol_test-build.sh log output should be to stderr
stdout is where the path to the final binary is output.
Nick Porter [Fri, 6 Jan 2023 19:36:17 +0000 (19:36 +0000)]
Update default delay for rlm_delay
Due to the option being parsed as a tmpl, if it is 1.0, it becomes a
float, which doesn't have a cast to fr_time_delta_t.
Adding the time unit, makes it a string which parses fine.
Nick Porter [Fri, 6 Jan 2023 16:53:26 +0000 (16:53 +0000)]
Handle corner case in using fr_sbuff_is...() functions on markers (#4839)
* Corner case fix for calling an fr_sbuff_is... function on a marker
Previously if fr_sbuff_is_...() was called on a marker and the buffer
had advanced past the end, then the function always returned false,
regardless of the character the marker was pointing at.
* Test to check fr_sbuff_is..() handles markers regardless of buffer position
* Correct parsing <num>.0 into fr_time_delta_t
Terry Burton [Fri, 6 Jan 2023 16:34:54 +0000 (16:34 +0000)]
rlm_rest: Don't skip alternate REST-HTTP-Header entries (#4838)
Nick Porter [Fri, 6 Jan 2023 11:16:03 +0000 (11:16 +0000)]
Only cleanup child processes if the exec has been populated
Nick Porter [Fri, 6 Jan 2023 11:14:34 +0000 (11:14 +0000)]
Add error message when delay value fails to parse
github-actions[bot] [Fri, 6 Jan 2023 09:34:55 +0000 (09:34 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Fri, 6 Jan 2023 09:34:52 +0000 (09:34 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Fri, 6 Jan 2023 09:34:49 +0000 (09:34 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Fri, 6 Jan 2023 09:34:46 +0000 (09:34 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Fri, 6 Jan 2023 09:34:43 +0000 (09:34 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Fri, 6 Jan 2023 09:34:40 +0000 (09:34 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Fri, 6 Jan 2023 09:34:37 +0000 (09:34 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Fri, 6 Jan 2023 09:34:33 +0000 (09:34 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
Arran Cudbard-Bell [Thu, 5 Jan 2023 20:12:49 +0000 (15:12 -0500)]
Revert "util: Add new fr_dict_global_set_lib_dir() function (#4835)"
This reverts commit
2a1a9df08f4baf7d76592325d39c9dd1dd704912 .
Jorge Pereira [Thu, 5 Jan 2023 19:57:28 +0000 (16:57 -0300)]
util: Add new fr_dict_global_set_lib_dir() function (#4835)
It helps to add extra directories to be checked during library load.
Nick Porter [Thu, 5 Jan 2023 17:54:20 +0000 (17:54 +0000)]
Use correct value for last argument of delay_add()
Nick Porter [Thu, 5 Jan 2023 17:07:07 +0000 (17:07 +0000)]
Align worker bounds on max_request_time with docs
Nick Porter [Thu, 5 Jan 2023 17:05:54 +0000 (17:05 +0000)]
max_request_time is a fr_time_delta_t not uint32_t
Jorge Pereira [Thu, 5 Jan 2023 15:40:16 +0000 (12:40 -0300)]
eapol_test: Add new 'HOSTAPD_REPO' variable (#4834)
It allows us to build the 'eapol_test' using external repos like:
$ HOSTAPD_REPO="https://github.com/NetworkRADIUS/hostap" \
HOSTAPD_GIT_TAG="feature/get_radius_reply" \
./scripts/ci/eapol_test-build.sh
$
Alan T. DeKok [Fri, 30 Dec 2022 15:17:02 +0000 (10:17 -0500)]
use enums when upcasting for comparisons
Note that (for now), we're not doing it in tmpl_cast_in_place(),
which *explicitly* avoids passing enums when casting.
We're also not doing it for expression / math calculations, as
it doesn't make sense to do
Service-Type = Framed-User + 1
It might make sense to use enums for IP address calculations? e.g.
Framed-IP-Address = network & mask
but at that point, you might as well just use attributes or local
variables for everything.
This is in preparation for updating the parser to force the user
to use single-quoted strings for enum names, as in:
Service-Type == 'Framed-User'
Which then means we'll also have to update the printing routines
to always print quotation marks around enums, and then update the
users file, SQL, detail file, etc.
Alan T. DeKok [Thu, 29 Dec 2022 19:12:09 +0000 (14:12 -0500)]
user-visible error messages shouldn't have function names in them
Alan T. DeKok [Thu, 29 Dec 2022 19:10:57 +0000 (14:10 -0500)]
we can't define ENUMs for strings or structural types
Alan T. DeKok [Thu, 29 Dec 2022 18:57:48 +0000 (13:57 -0500)]
notes for when we parse expressions