]>
git.ipfire.org Git - thirdparty/freeradius-server.git/log
Arran Cudbard-Bell [Thu, 17 Nov 2022 16:24:54 +0000 (10:24 -0600)]
Simplify release parsing, add +git into git package versions
Arran Cudbard-Bell [Thu, 17 Nov 2022 16:09:29 +0000 (10:09 -0600)]
Produce git versioned .deb files
Arran Cudbard-Bell [Thu, 17 Nov 2022 15:14:20 +0000 (09:14 -0600)]
Add explicit return types for xlat functions
Alan T. DeKok [Thu, 17 Nov 2022 14:34:37 +0000 (09:34 -0500)]
more corner cases, as caught by ASAN
Alan T. DeKok [Thu, 17 Nov 2022 13:56:05 +0000 (08:56 -0500)]
more cleanups
require that attributes always have leading &, and deal with the
consequences
Alan T. DeKok [Wed, 16 Nov 2022 20:14:35 +0000 (15:14 -0500)]
bump up buffer size to shut up compiler
Alan T. DeKok [Wed, 16 Nov 2022 20:13:41 +0000 (15:13 -0500)]
remove unused assignment
Alan T. DeKok [Wed, 16 Nov 2022 18:44:20 +0000 (13:44 -0500)]
run some edits under the new regime
The behavior which isn't yet converted is:
* giving "update list { ... }" and then a *different* list for
an attribute inside of the update section.
The new code doesn't like this, for good reason.
* assigning &request += &control[*]
the new code doesn't expect to see the [*], and therefore
just ignores the assignment.
* creating empty attributes if the RHS of an evaluate fails.
The new code does nothing.
* using array indexes in LHS of assignment for sub-list,
update foo { bar[1] = baz}.
The new code doesn't allow it.
* some compile-time errors are produced at different locations
Alan T. DeKok [Wed, 16 Nov 2022 18:43:55 +0000 (13:43 -0500)]
notes on what needs fixing for new "auto-convert to edit"
Alan T. DeKok [Wed, 16 Nov 2022 18:13:04 +0000 (13:13 -0500)]
more cleanups and fixes for corner cases
Alan T. DeKok [Wed, 16 Nov 2022 18:02:40 +0000 (13:02 -0500)]
forbid array references in sublists
&list := {
&foo[1] = "bar"
}
The edit code does not support this, because it doesn't really
make a lot of sense. If we do need to support it, then the edit
code needs to be updated to support it.
Note that we can already do
&list.foo[1] = "bar"
so this limitation isn't much of an issue. The problem comes when
doing multiple attribute assignments, and those using array indexes
inside of a sublist. What does it mean when we do
&list := {
&foo[0] = "bar"
&foo[1] = "baz"
&foo[0] = "ugh"
}
What the heck is going on here? The real answer is "don't do that"
Alan T. DeKok [Wed, 16 Nov 2022 17:50:54 +0000 (12:50 -0500)]
print attributes in debug, not info level
Alan T. DeKok [Wed, 16 Nov 2022 15:11:25 +0000 (10:11 -0500)]
don't need " \" at EOL any more
Alan T. DeKok [Wed, 16 Nov 2022 15:07:35 +0000 (10:07 -0500)]
use test_fail instead of "fail"
Alan T. DeKok [Wed, 16 Nov 2022 14:43:31 +0000 (09:43 -0500)]
catch more corner cases
update {
&Foo = bar
}
should use "list_def"
Alan T. DeKok [Wed, 16 Nov 2022 13:48:39 +0000 (08:48 -0500)]
this depends on edit, too
Alan T. DeKok [Wed, 16 Nov 2022 12:57:40 +0000 (07:57 -0500)]
forbid update in most places
except tests which actually use update
The bext step is to take all of the update tests, and run them
twice. once as normal, and once with "-S rewrite_update=yes"
Alan T. DeKok [Wed, 16 Nov 2022 12:57:23 +0000 (07:57 -0500)]
add migration configuration to forbid the use of "update"
Alan T. DeKok [Wed, 16 Nov 2022 12:36:12 +0000 (07:36 -0500)]
auto-convert update sections.
via some pretty disgusting methods. But it's not a lot of code,
and it catches the common use-cases.
Alan T. DeKok [Wed, 16 Nov 2022 11:43:31 +0000 (06:43 -0500)]
better error messages
Alan T. DeKok [Wed, 16 Nov 2022 11:42:24 +0000 (06:42 -0500)]
better error message
Alan T. DeKok [Wed, 16 Nov 2022 11:42:06 +0000 (06:42 -0500)]
temporary hack to set name2_quote
Alan T. DeKok [Tue, 15 Nov 2022 20:45:43 +0000 (15:45 -0500)]
quit coverity. Fixes CID #
1516908
Alan T. DeKok [Tue, 15 Nov 2022 15:11:04 +0000 (10:11 -0500)]
add main_config_migrate_option_get()
so that various things in the code can query what they should do,
without having global variables all over the place
Alan T. DeKok [Tue, 15 Nov 2022 15:10:36 +0000 (10:10 -0500)]
add cf_item_insert_after()
for use with automagically rewriting edit sections
Nick Porter [Thu, 17 Nov 2022 10:05:21 +0000 (10:05 +0000)]
Package process_dhcp*.so with dhcp module
Nick Porter [Thu, 17 Nov 2022 09:48:23 +0000 (09:48 +0000)]
Ensure module specific process_foo*.so are not packaged in freeradius package
Nick Porter [Thu, 17 Nov 2022 09:47:34 +0000 (09:47 +0000)]
rlm_sql_foo goes in package freeradius-foo not freeradius-sql-foo
Nick Porter [Wed, 16 Nov 2022 09:04:18 +0000 (09:04 +0000)]
Add recv_buff option to proto_ldap_sync
Arran Cudbard-Bell [Wed, 16 Nov 2022 23:28:15 +0000 (17:28 -0600)]
Add more ldap sync stuff to debian packages
Arran Cudbard-Bell [Wed, 16 Nov 2022 22:42:30 +0000 (16:42 -0600)]
Package libfreeradius-ldap
Arran Cudbard-Bell [Tue, 15 Nov 2022 19:15:51 +0000 (13:15 -0600)]
Add XLAT_ARGS helper macro to pull xlat arguments from the input list
Arran Cudbard-Bell [Tue, 15 Nov 2022 14:22:55 +0000 (08:22 -0600)]
Add type specific dcursors for value boxes
Doesn't perform any refactoring, just defines the types
Arran Cudbard-Bell [Tue, 15 Nov 2022 14:20:43 +0000 (08:20 -0600)]
Fail on internal exec error
Alan T. DeKok [Tue, 15 Nov 2022 11:24:35 +0000 (06:24 -0500)]
reorganization
Alan T. DeKok [Tue, 15 Nov 2022 11:12:53 +0000 (06:12 -0500)]
typo
Alan T. DeKok [Tue, 15 Nov 2022 11:01:39 +0000 (06:01 -0500)]
add documentation for limit and timeout
Alan T. DeKok [Tue, 15 Nov 2022 10:40:09 +0000 (05:40 -0500)]
only insert instructions which have thread alloc / instantiate
Arran Cudbard-Bell [Tue, 15 Nov 2022 00:06:31 +0000 (18:06 -0600)]
More verbose sanity checks
Arran Cudbard-Bell [Mon, 14 Nov 2022 23:04:00 +0000 (17:04 -0600)]
Use type safe functions for value box lists
Alan T. DeKok [Mon, 14 Nov 2022 22:13:27 +0000 (17:13 -0500)]
add "limit" keyword
Alan T. DeKok [Mon, 14 Nov 2022 22:06:28 +0000 (17:06 -0500)]
insert instructions into the unlang_instruction_tree
Alan T. DeKok [Mon, 14 Nov 2022 21:40:56 +0000 (16:40 -0500)]
add unlang_thread_instance()
which for now is only called from the "limit" keyword.
The thread instance data could arguably go into the stack frame,
but 99.9% of the stack frames won't use it. So for now we just
make the users call it manually
Alan T. DeKok [Mon, 14 Nov 2022 21:39:51 +0000 (16:39 -0500)]
thread_instantiate may be NULL
but we may still have thread instance data, which is just
counters
Alan T. DeKok [Mon, 14 Nov 2022 20:25:09 +0000 (15:25 -0500)]
remove unnecessary debug message
Alan T. DeKok [Mon, 14 Nov 2022 20:23:09 +0000 (15:23 -0500)]
close sockfd on error. Fixes CID #
1516897
Alan T. DeKok [Mon, 14 Nov 2022 15:34:04 +0000 (10:34 -0500)]
allow tmpls as arguments for timeout
Alan T. DeKok [Mon, 14 Nov 2022 15:09:13 +0000 (10:09 -0500)]
add timeout keyword
Arran Cudbard-Bell [Mon, 14 Nov 2022 16:57:57 +0000 (10:57 -0600)]
Always initialise the output PID even on error
Arran Cudbard-Bell [Mon, 14 Nov 2022 16:50:19 +0000 (10:50 -0600)]
Fix the exec legacy header to stop vscode complaining
Arran Cudbard-Bell [Mon, 14 Nov 2022 16:45:58 +0000 (10:45 -0600)]
Ensure we use all the arguments
Arran Cudbard-Bell [Mon, 14 Nov 2022 16:45:07 +0000 (10:45 -0600)]
Quiet deprecated warnings for macos
Arran Cudbard-Bell [Mon, 14 Nov 2022 16:44:40 +0000 (10:44 -0600)]
More uncommitted sbuff notes
James Jones [Mon, 14 Nov 2022 15:24:24 +0000 (09:24 -0600)]
Check return from fr_dict_unknown_attr_afrom_num() (CID #
1503891 ) (#4748)
James Jones [Mon, 14 Nov 2022 15:22:53 +0000 (09:22 -0600)]
Make correct changes to deal with toctou issues (CIDs below) (#4793)
1271307 ,
1445217 : use *at() calls to work around toctou
James Jones [Mon, 14 Nov 2022 15:01:11 +0000 (09:01 -0600)]
Don't compare with bounds in SBUFF_PARSE_[U]INT_DEF (CIDs
15040045 ,
1504004 ) (#4794)
Explicit comparison with the bounds makes sense but when you hit
the type the underlying conversion function uses, it's pointless,
and when it's part of a larger expression, coverity considers it
a possible coding error.
So... rather than doing an explicit comparison, we use the following
characterization: it's an error if the cast to the desired type changes
the value. To distinguish between overflow and underflow for signed
integer types, overflow happens if the cast value is less than the
return from strtoll(), underflow if it's greater.
Alan T. DeKok [Mon, 14 Nov 2022 14:52:37 +0000 (09:52 -0500)]
allow digits, in name2, too.
mostly for "timeout"
Alan T. DeKok [Mon, 14 Nov 2022 14:52:26 +0000 (09:52 -0500)]
move counters to callbacks
where they're correct, rather than using ad-hoc and in-line things
Alan T. DeKok [Mon, 14 Nov 2022 14:51:38 +0000 (09:51 -0500)]
expose frame_signal for use in timeout keyword
Alan T. DeKok [Mon, 14 Nov 2022 12:06:53 +0000 (07:06 -0500)]
if max_rtx_foo is defined, it has to be >0 time duration
Alan T. DeKok [Mon, 14 Nov 2022 11:58:03 +0000 (06:58 -0500)]
document actions and retries
Alan T. DeKok [Sun, 13 Nov 2022 18:52:19 +0000 (13:52 -0500)]
flag TBD
Alan T. DeKok [Thu, 27 Oct 2022 20:09:36 +0000 (16:09 -0400)]
don't use "update"
Arran Cudbard-Bell [Mon, 14 Nov 2022 05:46:12 +0000 (23:46 -0600)]
Fix redis_ippool behaviour on DHCPv6 solicit
Nick Porter [Wed, 9 Nov 2022 15:45:23 +0000 (15:45 +0000)]
Align trigger_exec() prototype with function definition
Nick Porter [Wed, 9 Nov 2022 15:43:34 +0000 (15:43 +0000)]
Ensure rate limited triggers are fired on first occurrence
github-actions[bot] [Sat, 5 Nov 2022 09:40:28 +0000 (09:40 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:25 +0000 (09:40 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:21 +0000 (09:40 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:19 +0000 (09:40 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:15 +0000 (09:40 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:13 +0000 (09:40 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:10 +0000 (09:40 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:06 +0000 (09:40 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
Nick Porter [Fri, 4 Nov 2022 16:52:11 +0000 (16:52 +0000)]
Handle timeout from ldap_results() when performing persistent searches
Nick Porter [Wed, 2 Nov 2022 19:44:18 +0000 (19:44 +0000)]
Adapt RFC4533 ldap_sync tests to validate new cookie store behaviour
Arran Cudbard-Bell [Thu, 3 Nov 2022 22:02:26 +0000 (22:02 +0000)]
Fix typo
Nick Porter [Wed, 2 Nov 2022 12:10:57 +0000 (12:10 +0000)]
CI: Bump freebsd vm action version
Nick Porter [Wed, 2 Nov 2022 11:15:56 +0000 (11:15 +0000)]
Ensure Python 3.10 used on MacOS until 3.11 supported
There are deprecated functions which break the build with Python 3.11
Nick Porter [Tue, 1 Nov 2022 21:13:41 +0000 (21:13 +0000)]
rlm_python is Python3
On some deb systems python-dev installs python-dev-is-python2
and hence python2-dev
Nick Porter [Tue, 1 Nov 2022 18:41:47 +0000 (18:41 +0000)]
Correctly detect working python when using gcc
gcc wants -l options after the source file - so populate $LIBS
Nick Porter [Tue, 1 Nov 2022 09:36:52 +0000 (09:36 +0000)]
Send correct cookie
sync->cookie is the latest received.
sync_packet_ctx->cookie is the one for the checkpoint we've reached.
Nick Porter [Tue, 1 Nov 2022 08:20:35 +0000 (08:20 +0000)]
Explicity ignore return code (CID #
1516561 )
Arran Cudbard-Bell [Mon, 31 Oct 2022 23:20:12 +0000 (17:20 -0600)]
Minor fixes
Arran Cudbard-Bell [Mon, 31 Oct 2022 22:07:03 +0000 (16:07 -0600)]
Slightly better messages
Arran Cudbard-Bell [Mon, 31 Oct 2022 21:48:21 +0000 (15:48 -0600)]
Print as much information as possible about why we failed waiting for a process
Arran Cudbard-Bell [Mon, 31 Oct 2022 21:22:32 +0000 (15:22 -0600)]
Don't print confusing PID, this is exeptected
Arran Cudbard-Bell [Mon, 31 Oct 2022 20:12:11 +0000 (14:12 -0600)]
Revert "Ensure there's no way linelog tests can conflict"
This reverts commit
fb9e85ad6a41b323c19ded3b4e242a1dd5a6fe61 .
Arran Cudbard-Bell [Mon, 31 Oct 2022 18:56:21 +0000 (12:56 -0600)]
Ensure there's no way linelog tests can conflict
James Jones [Mon, 31 Oct 2022 18:19:14 +0000 (13:19 -0500)]
Add -Wdeclaration-after-statement where supported (#4762)
* Add -Wdeclaration-after-statement where supported
This enforces one of the FreeRADIUS coding standards.
NOTE: I had to do a "make force-reconfig" to get the changes
made to configure.ac and m4/ax_cc.m4 to have an effect in
configure. This caused changes in thirty-five other configure
files that are unrelated to this change. I am including only
the changes to the files relevant to adding the above option
to CFLAGS, namely the files I explicitly changed and configure
itself.
We also add changes to fix the declaration after statement
instances this addition turns up.
* Don't declare vars in loops
* Don't declare vars in groups
Co-authored-by: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Nick Porter [Mon, 31 Oct 2022 18:11:04 +0000 (18:11 +0000)]
v4: Add functionality to rate limit LDAP sync store Cookie (#4784)
* Simplify arguments for ldap_sync_cookie_store
* Add config items for cookie store interval
* Add module instance to sync_state_t
And pass it to sync initialisation functions to populate the
sync_state_t
* Define structure for tracking sync packets
* Add list to sync_state for tracking pending packets
* Create sync packet ctx to track progress of each change
* Add counters for batching cookie storing
* Store received cookies in list of pending packets
rather than sending immediately
* Use counters to send cookies based on number of processed changes
* Use timer to send cookies on a periodic basis
Arran Cudbard-Bell [Mon, 31 Oct 2022 16:52:38 +0000 (10:52 -0600)]
We need to have cyrus-sasl-devel installed when building the LDAP packages otherwise we don't get SASL support
Nick Porter [Mon, 31 Oct 2022 08:27:21 +0000 (08:27 +0000)]
CI-DEB: 2nd instance of use "sid" in place of "bookworm"
Max Khon [Sun, 30 Oct 2022 22:25:15 +0000 (00:25 +0200)]
Try to shift up to sbuff start as current sbuff can be child sbuff with no used space (#4761)
* Try to shift up to sbuff start as current sbuff can be child sbuff with no used space.
Co-authored-by: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Arran Cudbard-Bell [Fri, 28 Oct 2022 15:49:26 +0000 (10:49 -0500)]
Sync openssl version checks with tls/version.c
Nick Porter [Fri, 28 Oct 2022 09:07:51 +0000 (10:07 +0100)]
Only run self-hosted cleanup job on main repo
Alan T. DeKok [Thu, 27 Oct 2022 18:53:21 +0000 (14:53 -0400)]
track the correct list, and still insert leaf attributes
Alan T. DeKok [Thu, 27 Oct 2022 18:34:37 +0000 (14:34 -0400)]
Revert "ignore the inserted child list, not the parent one"
This reverts commit
0806bb103d9ac5840e0113ea89c920ac3474f06d .
Alan T. DeKok [Thu, 27 Oct 2022 13:45:30 +0000 (09:45 -0400)]
ignore the inserted child list, not the parent one
Alan T. DeKok [Thu, 27 Oct 2022 13:21:19 +0000 (09:21 -0400)]
remove dead code