]>
git.ipfire.org Git - thirdparty/freeradius-server.git/log
github-actions[bot] [Sun, 3 Jul 2022 09:41:28 +0000 (09:41 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Sun, 3 Jul 2022 09:41:24 +0000 (09:41 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Sun, 3 Jul 2022 09:41:22 +0000 (09:41 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
Alan T. DeKok [Sat, 2 Jul 2022 20:06:33 +0000 (16:06 -0400)]
add const to quiet compiler
Alan T. DeKok [Fri, 1 Jul 2022 21:07:16 +0000 (17:07 -0400)]
allocate and use an "exists" node where necessary
which means we can now have a xlat_tokenize_condition() which works,
and the previous "check for attr" hacks in || and && can be removed
Alan T. DeKok [Sat, 2 Jul 2022 14:40:01 +0000 (10:40 -0400)]
check correct field.
if there's no dict_def in vpt, then we load it from the tr rules
Alan T. DeKok [Sat, 2 Jul 2022 12:20:47 +0000 (08:20 -0400)]
fix parsing of &Outer-Realm-Name, with terminating characters
It should not be
&Outer - Realm-Name
even if "-" is a terminating character.
The correct answer is "don't have ambiguous grammars", but it's
very difficult to fix that now
Alan T. DeKok [Sat, 2 Jul 2022 12:19:56 +0000 (08:19 -0400)]
zero-length strings are allowed to have NULL ptrs
Alan T. DeKok [Sat, 2 Jul 2022 01:52:40 +0000 (21:52 -0400)]
this doesn't need if-multivalue
Alan T. DeKok [Fri, 1 Jul 2022 14:13:36 +0000 (10:13 -0400)]
add "exists" xlat
Alan T. DeKok [Fri, 1 Jul 2022 13:26:43 +0000 (09:26 -0400)]
use consistent names
Alan T. DeKok [Fri, 1 Jul 2022 12:47:05 +0000 (08:47 -0400)]
update docs
Alan T. DeKok [Thu, 30 Jun 2022 12:37:24 +0000 (08:37 -0400)]
typo
Alan T. DeKok [Thu, 30 Jun 2022 12:29:25 +0000 (08:29 -0400)]
remove request_list from paircmp callbacks
Alan T. DeKok [Thu, 30 Jun 2022 11:47:17 +0000 (07:47 -0400)]
remove unused field
Alan T. DeKok [Thu, 30 Jun 2022 11:46:11 +0000 (07:46 -0400)]
we don't need \ at EOL
this should arguably be an error
Arran Cudbard-Bell [Fri, 1 Jul 2022 14:47:41 +0000 (09:47 -0500)]
Still need to call the right module instance
Arran Cudbard-Bell [Fri, 1 Jul 2022 14:18:30 +0000 (09:18 -0500)]
attr filter just has a send method
Arran Cudbard-Bell [Fri, 1 Jul 2022 14:05:20 +0000 (09:05 -0500)]
Minor fixes
Arran Cudbard-Bell [Fri, 1 Jul 2022 13:44:54 +0000 (08:44 -0500)]
Section name comparisons are case insensitive
Arran Cudbard-Bell [Fri, 1 Jul 2022 02:01:55 +0000 (21:01 -0500)]
Typo
Arran Cudbard-Bell [Thu, 30 Jun 2022 21:58:34 +0000 (16:58 -0500)]
Add hack to make test.authorize work again
Arran Cudbard-Bell [Thu, 30 Jun 2022 20:59:25 +0000 (15:59 -0500)]
Simple function for matching name1/name2 to a section name
Arran Cudbard-Bell [Thu, 30 Jun 2022 20:46:33 +0000 (15:46 -0500)]
s/module_method_names_t/module_method_name_t/
Arran Cudbard-Bell [Wed, 29 Jun 2022 21:57:14 +0000 (16:57 -0500)]
Remove component based module methods
This moves us fully to the name based system of looking up modules
James Jones [Thu, 30 Jun 2022 19:00:14 +0000 (14:00 -0500)]
Don't fclose() twice (CID #
1506722 ) (#4593)
The globally-writable directory case goes to perm_error,
which fclose()s fp. No need to do it twice.
Alan T. DeKok [Wed, 29 Jun 2022 21:22:57 +0000 (17:22 -0400)]
horrible temporary hacks to parse conditions
once the config file stuff is moved to sbuffs, this can be deleted.
The root cause of this hack is to avoid having the xlat code call
cf_expand_variables(). The old condition code did that, which "worked"
but was arguably wrong.
Moving the cf_expand_variables() call to cf_file.c made it difficult
to parse multi-line "if" conditions. So we necessitate this hack.
Alan T. DeKok [Wed, 29 Jun 2022 20:40:28 +0000 (16:40 -0400)]
there's no Tmp-Bool-0
Alan T. DeKok [Wed, 29 Jun 2022 15:51:20 +0000 (11:51 -0400)]
allow sync tmpls to be pushed, too
and remove 'inline_exec' flag, which was checked but never used.
Alan T. DeKok [Wed, 29 Jun 2022 13:20:48 +0000 (09:20 -0400)]
added tmpl_eval()
which only does asynchronous tmpls
Alan T. DeKok [Wed, 29 Jun 2022 14:02:50 +0000 (10:02 -0400)]
respect casts for results of exec, too
Alan T. DeKok [Wed, 29 Jun 2022 12:38:27 +0000 (08:38 -0400)]
move eval cast code to tmpl_eval_cast
and call it from tmpl_eval_pair(), so that the caller doesn't have
to.
Alan T. DeKok [Tue, 28 Jun 2022 21:09:01 +0000 (17:09 -0400)]
move "eval pair" code from unlang to tmpl code
This function is only for attributes which can be done
synchronously, i.e. without blocking.
Arran Cudbard-Bell [Wed, 29 Jun 2022 18:59:52 +0000 (13:59 -0500)]
Don't ignore .vscode
Arran Cudbard-Bell [Wed, 29 Jun 2022 18:59:41 +0000 (13:59 -0500)]
Add a standard launch file for radiusd to allow easy testing in the build tree
James Jones [Wed, 29 Jun 2022 16:58:23 +0000 (11:58 -0500)]
Annotate Coverity false positive of non-NUL-termination (CID #
1469156 ) (#4592)
def->name is built up with memcpy() calls that have the same
effect as sprintf(def->name, "HAVE_%s=1", symbol); The last
memcpy() makes a point of including the '\0' at the end of "=1"
and thus def->name is NUL-terminated, as is def->name + 5 (which
just skips the leading "HAVE_").
Arran Cudbard-Bell [Wed, 29 Jun 2022 16:46:21 +0000 (11:46 -0500)]
Fix comments in Makefile
Arran Cudbard-Bell [Wed, 29 Jun 2022 16:43:16 +0000 (11:43 -0500)]
Yet more broken expansions
Arran Cudbard-Bell [Wed, 29 Jun 2022 16:30:05 +0000 (11:30 -0500)]
Fix extension
Arran Cudbard-Bell [Wed, 29 Jun 2022 16:21:00 +0000 (11:21 -0500)]
Check dollar expansions work for non-strings
Arran Cudbard-Bell [Wed, 29 Jun 2022 16:08:47 +0000 (11:08 -0500)]
Add basic tests for dollar expansions in conditions
James Jones [Wed, 29 Jun 2022 15:14:43 +0000 (10:14 -0500)]
More MEM() checks (#4591)
This affects the following CIDs:
1503978 ,
1504031 ,
1504047
Arran Cudbard-Bell [Wed, 29 Jun 2022 15:14:06 +0000 (10:14 -0500)]
Missed rpm
Arran Cudbard-Bell [Wed, 29 Jun 2022 15:08:41 +0000 (10:08 -0500)]
fr_atexit_thread_trigger_all is a noop when we're not building with threads
Arran Cudbard-Bell [Wed, 29 Jun 2022 14:56:40 +0000 (09:56 -0500)]
Exit gracefully from unit_test_attribute
Arran Cudbard-Bell [Wed, 29 Jun 2022 14:56:24 +0000 (09:56 -0500)]
Typo
Arran Cudbard-Bell [Wed, 29 Jun 2022 14:28:44 +0000 (09:28 -0500)]
Typo
Arran Cudbard-Bell [Wed, 29 Jun 2022 14:18:44 +0000 (09:18 -0500)]
Indent things, and define variables correctly when we're not including Make.inc Closes #4587
Arran Cudbard-Bell [Tue, 28 Jun 2022 18:40:45 +0000 (13:40 -0500)]
Rework the atexit code to function without pthreads
Arran Cudbard-Bell [Tue, 28 Jun 2022 17:44:23 +0000 (12:44 -0500)]
Emit errors if stat fails, and use fstat not stat to avoid TOCTOU issues
Arran Cudbard-Bell [Tue, 28 Jun 2022 15:08:12 +0000 (10:08 -0500)]
Fix building libfreeradius-util under emscripten
Arran Cudbard-Bell [Tue, 28 Jun 2022 15:07:08 +0000 (10:07 -0500)]
Add the option to dlopen RTLD_DEFAULT for all module loading
Arran Cudbard-Bell [Mon, 27 Jun 2022 23:26:41 +0000 (18:26 -0500)]
Base vscode project settings everyone should be using
Arran Cudbard-Bell [Mon, 27 Jun 2022 23:25:03 +0000 (18:25 -0500)]
Basic clangd config to suppress the most stupid warnings
Arran Cudbard-Bell [Mon, 27 Jun 2022 23:21:14 +0000 (18:21 -0500)]
Various fixes for jlibtool
Arran Cudbard-Bell [Mon, 27 Jun 2022 21:35:12 +0000 (16:35 -0500)]
Missing includes in rlm_mschap.h
Arran Cudbard-Bell [Mon, 27 Jun 2022 21:34:51 +0000 (16:34 -0500)]
Fix additional legitimate bugs and style issues in jlibtool
Arran Cudbard-Bell [Mon, 27 Jun 2022 20:42:44 +0000 (15:42 -0500)]
Fix legitimate bug found by clangd
Arran Cudbard-Bell [Mon, 27 Jun 2022 20:42:29 +0000 (15:42 -0500)]
Quiet clangd's linter
Arran Cudbard-Bell [Mon, 27 Jun 2022 20:20:49 +0000 (15:20 -0500)]
Emit compile receipts when building source files
Arran Cudbard-Bell [Mon, 27 Jun 2022 20:17:36 +0000 (15:17 -0500)]
Add phony target for compile commands
Arran Cudbard-Bell [Mon, 27 Jun 2022 20:16:26 +0000 (15:16 -0500)]
Ignore compile commands (it's system specific)
Alan T. DeKok [Mon, 27 Jun 2022 18:21:51 +0000 (14:21 -0400)]
-4 is a number, not a function unary_minus(4)
Which helps a bit with optimization.
Alan T. DeKok [Sat, 25 Jun 2022 13:43:25 +0000 (09:43 -0400)]
simplification
Alan T. DeKok [Fri, 24 Jun 2022 12:32:32 +0000 (08:32 -0400)]
complain about poorly formed expressions
!foo == bar
is really
(!foo) == bar
due to operator precedence rules. So we complain about this,
and force the user to be clearer, and to use the parantheses
Alan T. DeKok [Fri, 24 Jun 2022 12:31:47 +0000 (08:31 -0400)]
clear errors before each command
to avoid spurious errors which are left over from previous commands
Alan T. DeKok [Thu, 23 Jun 2022 19:50:38 +0000 (15:50 -0400)]
hoist casts when hoisting xlats
and update tests which now have casts all over the place
Alan T. DeKok [Thu, 23 Jun 2022 13:50:39 +0000 (09:50 -0400)]
save the rcode for consumption by the xlat expressions
Arran Cudbard-Bell [Mon, 27 Jun 2022 14:06:30 +0000 (09:06 -0500)]
Quiet issue with sign comparisons
Max Khon [Mon, 27 Jun 2022 12:35:17 +0000 (15:35 +0300)]
git-archive submodules when creating source tarball (#4586)
Max Khon [Mon, 27 Jun 2022 12:34:58 +0000 (15:34 +0300)]
Sync "git for-each-ref" output parsing with other Dockerfile.deps (#4584)
Max Khon [Sun, 26 Jun 2022 15:27:27 +0000 (18:27 +0300)]
- Allow to specify additional rpmbuild flags (RPMBUILD_FLAGS) (#4585)
- Allow non-root builds (by specifying SUDO)
James Jones [Fri, 24 Jun 2022 21:03:42 +0000 (16:03 -0500)]
Correct coverity annotations (#4581)
James Jones [Fri, 24 Jun 2022 21:03:27 +0000 (16:03 -0500)]
Annotate SBUFF_PARSE_[U]INT_DEF() bounds checking (CID #
1504004 , #
1504045 ) (#4582)
For signed or unsigned long long, the bounds checking will have
tests that always have the same result, which triggers coverity.
The fiddling with _Generic() required to avoid this is excessive,
and the macros as they stand pass tests. We therefore annotate
those comparisons to placate coverity.
Arran Cudbard-Bell [Fri, 24 Jun 2022 20:19:44 +0000 (15:19 -0500)]
Remove NULLness check
Arran Cudbard-Bell [Fri, 24 Jun 2022 20:12:47 +0000 (15:12 -0500)]
Print request refs correctly
Arran Cudbard-Bell [Fri, 24 Jun 2022 19:04:31 +0000 (14:04 -0500)]
Remove duplicate extern
Arran Cudbard-Bell [Fri, 24 Jun 2022 18:51:45 +0000 (13:51 -0500)]
Remove whitespace
Arran Cudbard-Bell [Fri, 24 Jun 2022 18:51:35 +0000 (13:51 -0500)]
Support multiple levels of request qualifiers
Alan T. DeKok [Wed, 22 Jun 2022 18:25:10 +0000 (14:25 -0400)]
respect casts
Alan T. DeKok [Wed, 22 Jun 2022 18:25:01 +0000 (14:25 -0400)]
typo
Alan T. DeKok [Wed, 22 Jun 2022 15:29:10 +0000 (11:29 -0400)]
escape tainted values when processing regular expressions
Alan T. DeKok [Wed, 22 Jun 2022 15:28:53 +0000 (11:28 -0400)]
typo
Alan T. DeKok [Wed, 22 Jun 2022 15:22:22 +0000 (11:22 -0400)]
respect escape rules for tainted inputs
when concatenating a value-box list to a string
Alan T. DeKok [Wed, 22 Jun 2022 13:57:58 +0000 (09:57 -0400)]
allow for single-quoted strings in regular expressions
Arran Cudbard-Bell [Wed, 22 Jun 2022 23:10:10 +0000 (18:10 -0500)]
Fix rlm_rest all.mk file Closes #4580
Arran Cudbard-Bell [Wed, 22 Jun 2022 21:31:14 +0000 (16:31 -0500)]
Build doesn't exist either...
Max Khon [Wed, 22 Jun 2022 21:40:27 +0000 (00:40 +0300)]
Create relative symlinks so that the source tree can be shared (#4574)
across several hosts to be accessed remotely
Max Khon [Wed, 22 Jun 2022 21:32:18 +0000 (00:32 +0300)]
Ignore Visual Studio Code project files (#4579)
James Jones [Wed, 22 Jun 2022 21:12:01 +0000 (16:12 -0500)]
Annotate issues Coverity see that we have decided to ignore. (#4553)
This change deals with the following CIDs:
1503889 ,
1503901 ,
1503908 ,
1503916 ,
1503936 ,
1504024 ,
1504280 ,
1504282 ,
1503894 ,
1503899 ,
1504013
Most of these are sbuff/dbuff operations that can only fail if
the buffers can't be reallocated or have reached their specified
maximum size.
In
1503899 , we know, but Coverity doesn't, that no log_keyword
passed to _make_vlog() will overrun the fixed-size buffer it uses.
1503894 is what Coverity thinks is a copy/paste error that clearly
makes sense as written.
James Jones [Wed, 22 Jun 2022 21:11:40 +0000 (16:11 -0500)]
Annotate calls that as used will not return NULL (CID #
1503961 ) (#4577)
The calls in question are those in pair_list_init() that iterate
over a pair list built up from a string. As long as the string
is non-empty, the pair list won't be empty. As long as perc (the
percentage) is no larger than 100, the code won't pass NULL to
fr_pair_copy()... and one can see that's the case for all calls
to pair_list_init(). Coverity apparently doesn't look at that
context.
James Jones [Wed, 22 Jun 2022 21:10:03 +0000 (16:10 -0500)]
Placate Coverity for mschap_xlat() (CID #
1503902 ) (#4556)
James Jones [Wed, 22 Jun 2022 21:09:38 +0000 (16:09 -0500)]
Wrap unchecked value box calls in xlat_idna() in MEM() (CID #
1503962 ) (#4578)
James Jones [Wed, 22 Jun 2022 21:09:20 +0000 (16:09 -0500)]
Set *err to -2 when the list isn't found in tmp_dcursor_init() (#4571)
This change honors the comments describing how err is handled, and
also means, given tmpl_find_vp()'s use of tmpl_dcursor_init(),
means callers of tmpl_find_vp() can check its return value
rather than having to look at the written vp (e.g. sometimes_return();
see CID #
1503995 ).
Max Khon [Wed, 22 Jun 2022 21:02:06 +0000 (00:02 +0300)]
fr_sbuff_extend_file(): update "end" of parent sbuffs (#4576)
This fixes parsing when streaming from file and parsed object (string)
spans fhe I/O buffer boundary.
James Jones [Wed, 22 Jun 2022 20:59:41 +0000 (15:59 -0500)]
Annotate to assure coverity that buffers are initialized (CID #
1504042 , #
1504436 ) (#4543)
Terry Burton [Wed, 22 Jun 2022 20:59:12 +0000 (21:59 +0100)]
New optional lightweight Acct-On/Off strategy with helper SP and view (#4550)
Currently supported by MySQL, PostgreSQL and SQLite.
Arran Cudbard-Bell [Wed, 22 Jun 2022 20:56:25 +0000 (15:56 -0500)]
BUILD_DIR isn't available if we're building packages. Closes #4575
Arran Cudbard-Bell [Wed, 22 Jun 2022 20:15:08 +0000 (15:15 -0500)]
sbuff->shifted should be reinitialised to 0 with each new sbuff in the chain
This breaks the file streaming sbuff, so record the shifted count separately in the fr_sbuff_uctx_file_t structure
Arran Cudbard-Bell [Wed, 22 Jun 2022 13:51:25 +0000 (08:51 -0500)]
Optional include