]>
git.ipfire.org Git - thirdparty/freeradius-server.git/log
Arran Cudbard-Bell [Thu, 2 Jun 2022 18:14:16 +0000 (14:14 -0400)]
Move libcurl init to global_lib framework
Arran Cudbard-Bell [Thu, 2 Jun 2022 17:57:06 +0000 (13:57 -0400)]
Having pre-generated certificates saves very little time and breaks CI regularly
Arran Cudbard-Bell [Thu, 2 Jun 2022 17:41:31 +0000 (13:41 -0400)]
Rename some more global_lib functions
Arran Cudbard-Bell [Thu, 2 Jun 2022 17:40:20 +0000 (13:40 -0400)]
Table formatting in libldap
Arran Cudbard-Bell [Thu, 2 Jun 2022 17:10:31 +0000 (13:10 -0400)]
Move global_lib_init and instantiation calls inside the module code
Arran Cudbard-Bell [Thu, 2 Jun 2022 16:51:34 +0000 (12:51 -0400)]
Minor fixes
Nick Porter [Thu, 2 Jun 2022 16:50:31 +0000 (17:50 +0100)]
v4: Framework for configuring, initialising and freeing libraries (#4541)
* Add endforeach macro to close code blocks opened by foreach macros
* Define framework for initialising and freeing libraries
Reading library configuration from a subsection of a global {} config
section.
* Initialise global list of libraries
* Register handlers for "lib" symbols to auto initialise and free libraries
github-actions[bot] [Thu, 2 Jun 2022 09:51:19 +0000 (09:51 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Thu, 2 Jun 2022 09:51:16 +0000 (09:51 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Thu, 2 Jun 2022 09:51:13 +0000 (09:51 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Thu, 2 Jun 2022 09:51:09 +0000 (09:51 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Thu, 2 Jun 2022 09:51:07 +0000 (09:51 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Thu, 2 Jun 2022 09:51:04 +0000 (09:51 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Thu, 2 Jun 2022 09:51:01 +0000 (09:51 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Thu, 2 Jun 2022 09:50:58 +0000 (09:50 +0000)]
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
James Jones [Wed, 1 Jun 2022 14:43:30 +0000 (09:43 -0500)]
Check fr_sbuff_in_bstrncpy() return in xlat_func_rpad() (CID #
15039490 ) (#4515)
James Jones [Wed, 1 Jun 2022 01:25:31 +0000 (20:25 -0500)]
Cast to void where we know a call will work or just want side effects (#4537)
This deals with the following CIDs:
1469133 ,
1503911 ,
1503964 ,
1504282 (#1 of 5)
James Jones [Wed, 1 Jun 2022 01:24:18 +0000 (20:24 -0500)]
Deal with unchecked return value Coverity reports (#4532)
This deals with the following CIDs:
1503943 ,
1503949 ,
1455233 ,
1503981
James Jones [Wed, 1 Jun 2022 01:22:37 +0000 (20:22 -0500)]
Remove needless checks from xlat_config_escape(). (#4536)
The VLA escaped[] is declared to be large enough to hold the text
from the value box even if every single character needs the
largest possible encoding (MIME, which takes three characters to
encode one). The bound checks will therefore never cause an error
return.
Arran Cudbard-Bell [Tue, 31 May 2022 15:41:04 +0000 (11:41 -0400)]
Add some more text about identity privacy
Nick Porter [Tue, 31 May 2022 08:06:21 +0000 (09:06 +0100)]
Use eapol_test-build.sh to build eapol_test on deb CI
Nick Porter [Mon, 30 May 2022 15:48:51 +0000 (16:48 +0100)]
Update test certificates
Arran Cudbard-Bell [Sat, 21 May 2022 20:57:19 +0000 (15:57 -0500)]
Always build jlibtool with debugging symbols
Arran Cudbard-Bell [Wed, 18 May 2022 19:16:44 +0000 (14:16 -0500)]
Add $(E) suffix for executable targets and $(L) suffix for dynamic libraries
Arran Cudbard-Bell [Wed, 18 May 2022 19:15:34 +0000 (14:15 -0500)]
Add rule for .js files and fix Linux specific extension substitution
Arran Cudbard-Bell [Mon, 16 May 2022 14:31:23 +0000 (09:31 -0500)]
Use BUILD and TARGET not HOST and TARGET
Alan T. DeKok [Wed, 25 May 2022 20:45:54 +0000 (16:45 -0400)]
fix final issues
Nick Porter [Wed, 25 May 2022 16:45:45 +0000 (17:45 +0100)]
Remove module bootstrapping from conf parsing (#4538)
Alan T. DeKok [Wed, 25 May 2022 14:36:18 +0000 (10:36 -0400)]
set and print quotes for string values.
Alan T. DeKok [Wed, 25 May 2022 14:22:10 +0000 (10:22 -0400)]
tests for unary not
Alan T. DeKok [Wed, 25 May 2022 14:20:40 +0000 (10:20 -0400)]
append argument as group, not as raw node
Alan T. DeKok [Wed, 25 May 2022 12:19:31 +0000 (08:19 -0400)]
validate data type where possible.
This doesn't catch all of the cases, but it catches enough to be
useful.
Josef Vybíhal [Wed, 25 May 2022 05:08:57 +0000 (07:08 +0200)]
Fix typo (#4531)
Alan T. DeKok [Tue, 24 May 2022 18:57:49 +0000 (14:57 -0400)]
just pass all of the tmpl_rules to the xlat tokenize functions
so that they all take the same thing, and so that we have better
control over non-attribute parsing
Alan T. DeKok [Tue, 24 May 2022 18:21:07 +0000 (14:21 -0400)]
check fields only when they're valid
Alan T. DeKok [Tue, 24 May 2022 14:44:42 +0000 (10:44 -0400)]
lots of fixes.
Set flags better. Do more resolution of binary operations.
We still need to add xlat_expr_resolve_unary()
update tests to show that most pure things can now be purified.
Alan T. DeKok [Tue, 24 May 2022 14:28:30 +0000 (10:28 -0400)]
comments
Alan T. DeKok [Tue, 24 May 2022 14:19:43 +0000 (10:19 -0400)]
allow for instantiated xlats to be put into other ones
tmpl_tokenize() will call xlat_instantiate_ephemeral() on things
it sees. However, if we then hoist that xlat out of the tmpl
and into the main xlat tree, we can't re-instantiate the node.
Rather than adding flags to change the rest of the code, we just
catch that here. This should likely be cleaned up later
Alan T. DeKok [Tue, 24 May 2022 14:18:52 +0000 (10:18 -0400)]
allow for pruning of xlat walk
Alan T. DeKok [Tue, 24 May 2022 14:14:33 +0000 (10:14 -0400)]
print data types, too
Alan T. DeKok [Mon, 23 May 2022 20:27:26 +0000 (16:27 -0400)]
set more flags correctly
Alan T. DeKok [Mon, 23 May 2022 19:21:46 +0000 (15:21 -0400)]
print out indexes, which can help at times.
Alan T. DeKok [Mon, 23 May 2022 18:40:58 +0000 (14:40 -0400)]
check for xlat / exec tmpls
which should really be handled, but let's debug other code first.
Alan T. DeKok [Mon, 23 May 2022 18:40:40 +0000 (14:40 -0400)]
more debugging
Alan T. DeKok [Mon, 23 May 2022 18:38:40 +0000 (14:38 -0400)]
clean up flag handling
things are pure unless marked impure.
check input allow_unresolved once per loop, and not in some of the
individual "case" statements
Terry Burton [Tue, 24 May 2022 18:38:45 +0000 (19:38 +0100)]
CI FreeBSD: Bump vmactions/freebsd-vm and prune before pushback (#4533)
Pushback of the working directory over rsync sometimes fails with
"ssh_dispatch_run_fatal: Connection to A.B.C.D: message authentication code
incorrect" irrespective of the MAC used by the SSH connection.
Cleaning the unnecessary parts of the working directory should reduce the
chances of such failures until the cause is determined.
We keep any changes to the eapol_test build since this is cached between runs.
Terry Burton [Tue, 24 May 2022 17:00:59 +0000 (18:00 +0100)]
Raise limit for number of Redis xlat components (#4534)
Arran Cudbard-Bell [Wed, 18 May 2022 19:15:19 +0000 (14:15 -0500)]
Correct arguments in the enscripten target
Arran Cudbard-Bell [Tue, 10 May 2022 13:08:27 +0000 (09:08 -0400)]
Init proto
Arran Cudbard-Bell [Sat, 21 May 2022 15:37:35 +0000 (10:37 -0500)]
Typo
Arran Cudbard-Bell [Sat, 21 May 2022 15:34:24 +0000 (10:34 -0500)]
Fixes for tmpl_resolve
Alan T. DeKok [Sat, 21 May 2022 14:22:32 +0000 (10:22 -0400)]
add void to shut up compiler
Alan T. DeKok [Sat, 21 May 2022 14:20:03 +0000 (10:20 -0400)]
add custom resolve callback handler
Alan T. DeKok [Sat, 21 May 2022 14:19:15 +0000 (10:19 -0400)]
add more debug output for xlat_purify
which can help track down issues with the flags
Alan T. DeKok [Sat, 21 May 2022 14:15:44 +0000 (10:15 -0400)]
purify arguments, even if the function can't be purified
and hoist can_purify up to the parent.
We should really have a merge flags just for XLAT_FUNC, which
would cut down on some of this repetition.
Alan T. DeKok [Sat, 21 May 2022 12:55:11 +0000 (08:55 -0400)]
move more logic into tmpl_resolve()
Jorge Pereira [Sat, 21 May 2022 12:29:53 +0000 (09:29 -0300)]
rlm_expr: Fix typo with double '&' (#4525)
Alan T. DeKok [Fri, 20 May 2022 20:01:49 +0000 (16:01 -0400)]
head can be NULL
Alan T. DeKok [Fri, 20 May 2022 19:17:32 +0000 (15:17 -0400)]
update comments
Alan T. DeKok [Fri, 20 May 2022 18:53:29 +0000 (14:53 -0400)]
just use talloc_const_free()
Alan T. DeKok [Fri, 20 May 2022 18:52:56 +0000 (14:52 -0400)]
just use talloc_const_free
James Jones [Fri, 20 May 2022 16:27:28 +0000 (11:27 -0500)]
Placate -Wincompatible-pointer-types-discards-qualifiers (#4523)
Alan T. DeKok [Fri, 20 May 2022 16:07:20 +0000 (12:07 -0400)]
re-enable purify.txt tests
With some hacks to do xlat thread instantiation only when running
the xlat_purify tests. If "-p" is passed in other circumstances,
you will get weird and esoteric errors. Oh well.
That will be fixed once we get rid of conditions, and replace them
with the new xlat expressions.
Alan T. DeKok [Fri, 20 May 2022 13:42:23 +0000 (09:42 -0400)]
try to resolve tmpls, and give better errors
Alan T. DeKok [Fri, 20 May 2022 13:41:38 +0000 (09:41 -0400)]
resolve function arguments before the function itself
otherwise the function may steal the arguments into its internal
structures, where they cannot be resolved.
Alan T. DeKok [Fri, 20 May 2022 13:41:18 +0000 (09:41 -0400)]
lists are resolved as attributes
Alan T. DeKok [Fri, 20 May 2022 13:29:15 +0000 (09:29 -0400)]
initialize more fields
Alan T. DeKok [Thu, 19 May 2022 23:23:55 +0000 (19:23 -0400)]
set more flags properly, and try to resolve things.
There's (as yet) no "resolve" callback for the xlat functions,
so we can't parse things like
&Service-Type == Framed-User
The LHS will be an attribute, and the RHS will be TMPL_UNRESOLVED.
The interpreter currently does this resolution in all kinds of
complex pass2_fixup functions. We will need to move those fixups
to common code, and call the custom resolvers from xlat_resolve()
Alan T. DeKok [Thu, 19 May 2022 23:27:25 +0000 (19:27 -0400)]
let's assert at the right point.
Alan T. DeKok [Thu, 19 May 2022 23:06:55 +0000 (19:06 -0400)]
move prototype of xlat_purify()
Alan T. DeKok [Thu, 19 May 2022 23:06:41 +0000 (19:06 -0400)]
heads start out as pure
Alan T. DeKok [Thu, 19 May 2022 23:06:13 +0000 (19:06 -0400)]
initialize more fields
Alan T. DeKok [Thu, 19 May 2022 23:01:03 +0000 (19:01 -0400)]
only set destructors if they're going to do work.
This papers over certain issues with pure functions, and purifying
them. But arguably pure functions should use no instance data,
and should take no destructors. If they do, they're not pure.
Alan T. DeKok [Thu, 19 May 2022 20:12:19 +0000 (16:12 -0400)]
print flags, and don't assume XLAT_TMPLs are all attributes
Alan T. DeKok [Thu, 19 May 2022 20:11:04 +0000 (16:11 -0400)]
let's set can_purify here, too.
Note that we don't deal well with an N-ary operation which
starts off with pure children, and then has impure children
later appended. That needs a bit more thinking
Nick Porter [Fri, 20 May 2022 13:00:39 +0000 (14:00 +0100)]
Fix permissions for mods_config/sql extras in rpms
Arran Cudbard-Bell [Fri, 20 May 2022 12:46:24 +0000 (07:46 -0500)]
Don't assert on resync Close #4522
Jorge Pereira [Thu, 19 May 2022 23:00:49 +0000 (20:00 -0300)]
rlm_couchbase: Fix several issues (#4517)
James Jones [Thu, 19 May 2022 22:59:43 +0000 (17:59 -0500)]
Check return values in rlm_date.c (CID #
1503947 , #
1503971 ) (#4520)
James Jones [Thu, 19 May 2022 22:56:13 +0000 (17:56 -0500)]
Catch the non-OSX cmd->install_path == NULL case (CID #
1504302 ) (#4521)
Alan T. DeKok [Thu, 19 May 2022 18:28:50 +0000 (14:28 -0400)]
add xlat_purify() function
for now, it calls unlang_interpret_synchronous(). We'll fix
that later.
Alan T. DeKok [Thu, 19 May 2022 18:28:03 +0000 (14:28 -0400)]
shut up clang scan
Alan T. DeKok [Thu, 19 May 2022 15:59:54 +0000 (11:59 -0400)]
on second thought, this isn't necessary
Alan T. DeKok [Thu, 19 May 2022 15:38:07 +0000 (11:38 -0400)]
double-check and fix flags.
We now have a "can_purify" flag. This is set to "true" for
pure functions which have pure arguments. And for alternations
which have pure arguments.
%% is set to pure. XLAT_BOX and XLAT_LITERAL are pure, but
they are not "can_purify".
The result is that we tell if there are portions of the tree
which need additional work for purification.
Alan T. DeKok [Thu, 19 May 2022 14:48:26 +0000 (10:48 -0400)]
this loop isn't necessary. It's done by xlat_copy.
Alan T. DeKok [Thu, 19 May 2022 14:39:49 +0000 (10:39 -0400)]
update APIs to allow for "evaluate only one node"
instead of looping through everything
Nick Porter [Thu, 19 May 2022 10:36:15 +0000 (11:36 +0100)]
Add util-linux as dependency for freeradius-config rpm
Required to run the certificate generation post install script
James Jones [Wed, 18 May 2022 21:24:34 +0000 (16:24 -0500)]
Always put something in temporary buffer, if only "" (CID #
1503992 ) (#4519)
From the point where src->dst_type is determined to have fixed
size, fr_value_box_from_substr() works with a local copy... but
if fr_sbuff_remaining() returned zero, nothing was written in the
local copy. With this change, in that case, the local copy is made
an empty string, NUL-terminated.
Nick Porter [Wed, 18 May 2022 10:01:21 +0000 (11:01 +0100)]
Add a second run of installing rpm build dependencies
It has been observed that not all dependencies get installed first time
on rocky 8
Alan T. DeKok [Wed, 18 May 2022 00:30:50 +0000 (20:30 -0400)]
Revert "clean up internal requests if they have no parent"
This reverts commit
9f8b9bb3ad94687b378f5539a1010310a089bc80 .
the interpreter should still clean up some requests which have
no parent, as there are very much cases where those are leaked.
however, until we track all of those issues down, let's not
break CI
Alan T. DeKok [Wed, 18 May 2022 00:17:51 +0000 (20:17 -0400)]
clean up internal requests if they have no parent
Specifically for trigger_exec(), which can be called with
a real interpreter, but no parent for the "request" which is
running the trigger.
Alan T. DeKok [Wed, 18 May 2022 00:15:19 +0000 (20:15 -0400)]
Revert "put yielded increment / decrement into the callbacks"
This reverts commit
a3aee1615ab0986cebe596c536e840e667de2943 .
intp->func.resume() is called when a request _starts_ running
for the first time, too. Which means that we can't decrement
the "yielded" count, because it's already at zero
Alan T. DeKok [Wed, 18 May 2022 00:04:25 +0000 (20:04 -0400)]
add "help" target for laziness
Alan T. DeKok [Tue, 17 May 2022 23:58:36 +0000 (19:58 -0400)]
used
Alan T. DeKok [Tue, 17 May 2022 21:43:11 +0000 (17:43 -0400)]
remove old code and just use unlang_module_yield_to_section()
there are a few other places which use unlang_interpret_synchronous()
which could likely also be converted.
Alan T. DeKok [Tue, 17 May 2022 20:57:05 +0000 (16:57 -0400)]
check for a new event list only once.
Alan T. DeKok [Tue, 17 May 2022 20:55:25 +0000 (16:55 -0400)]
put yielded increment / decrement into the callbacks
which makes the main interpret loop a little clearer
Alan T. DeKok [Tue, 17 May 2022 15:08:19 +0000 (11:08 -0400)]
add dict in preparation for xlat_purify
Alan T. DeKok [Tue, 17 May 2022 14:39:19 +0000 (10:39 -0400)]
Revert "close on error. Fixes #4518"
This reverts commit
4040e326d7bc637f55cdb029ea3c3127de3d2a96 .
this is done by cf_stack_cleanup(), and there are many other paths
in cf_file_include() which do "return -1" without closing the
file.
Jorge Pereira [Tue, 17 May 2022 14:07:20 +0000 (11:07 -0300)]
radsniff: Add '-Z' option allowing to dump the packets (#4504)
* log: Fix fr_pair_list_log() to accept level identation parameter
* log: Fix fr_log_init_file() 'fd' set
* log: Fix fr_log_close() 'dst' check
* radsniff: Add '-Z' option allowing to dump the packets