]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
4 years agoFix another overflow
Arran Cudbard-Bell [Fri, 29 Oct 2021 03:56:16 +0000 (23:56 -0400)] 
Fix another overflow

4 years agoFix potential buffer overflow
Arran Cudbard-Bell [Fri, 29 Oct 2021 03:45:29 +0000 (23:45 -0400)] 
Fix potential buffer overflow

4 years agoAdd substr parser from time deltas
Arran Cudbard-Bell [Thu, 28 Oct 2021 22:00:40 +0000 (18:00 -0400)] 
Add substr parser from time deltas

4 years agoWe do need to include dcursor.c?
Arran Cudbard-Bell [Thu, 28 Oct 2021 19:09:40 +0000 (15:09 -0400)] 
We do need to include dcursor.c?

4 years agortlib and unwindlib need to align
Arran Cudbard-Bell [Thu, 28 Oct 2021 19:05:30 +0000 (15:05 -0400)] 
rtlib and unwindlib need to align

4 years ago*sigh* we don't need to bake time.c into the strerror tests
Arran Cudbard-Bell [Thu, 28 Oct 2021 18:58:47 +0000 (14:58 -0400)] 
*sigh* we don't need to bake time.c into the strerror tests

4 years agoDon't include the source file for the code under test unless we really need to
Arran Cudbard-Bell [Thu, 28 Oct 2021 18:55:00 +0000 (14:55 -0400)] 
Don't include the source file for the code under test unless we really need to

4 years agomacOS doesn't require --unwindlib and complaints bitterly
Arran Cudbard-Bell [Thu, 28 Oct 2021 18:49:12 +0000 (14:49 -0400)] 
macOS doesn't require --unwindlib and complaints bitterly

4 years agoOpt
Arran Cudbard-Bell [Thu, 28 Oct 2021 18:33:04 +0000 (14:33 -0400)] 
Opt

4 years agoWe don't actually need to include strerror.c here
Arran Cudbard-Bell [Thu, 28 Oct 2021 17:56:13 +0000 (13:56 -0400)] 
We don't actually need to include strerror.c here

4 years agoMaybe the missing extern it causing two versions of fr_time_multiplier_by_res to...
Arran Cudbard-Bell [Thu, 28 Oct 2021 17:49:53 +0000 (13:49 -0400)] 
Maybe the missing extern it causing two versions of fr_time_multiplier_by_res to be created?

4 years agoLet's hope the clang packages pull in lubunwind too *sigh*
Arran Cudbard-Bell [Thu, 28 Oct 2021 17:31:54 +0000 (13:31 -0400)] 
Let's hope the clang packages pull in lubunwind too *sigh*

4 years agoMaybe it doesn't like comments being inline
Arran Cudbard-Bell [Thu, 28 Oct 2021 17:21:20 +0000 (13:21 -0400)] 
Maybe it doesn't like comments being inline

4 years agoWe need to specify the unwind lib too
Arran Cudbard-Bell [Thu, 28 Oct 2021 17:16:33 +0000 (13:16 -0400)] 
We need to specify the unwind lib too

4 years agoApparently clang needs us to link to compiler-rt to get at the builtins...
Arran Cudbard-Bell [Thu, 28 Oct 2021 16:57:50 +0000 (12:57 -0400)] 
Apparently clang needs us to link to compiler-rt to get at the builtins...

4 years agoAdd generic time scaling functions
Arran Cudbard-Bell [Thu, 28 Oct 2021 16:32:07 +0000 (12:32 -0400)] 
Add generic time scaling functions

Deal with integer overflow in time manipulation and scaling functions by returning min/max.

4 years agoMove time precision table into value.c
Arran Cudbard-Bell [Thu, 28 Oct 2021 16:29:00 +0000 (12:29 -0400)] 
Move time precision table into value.c

4 years agoUse builtins for overflow detection
Arran Cudbard-Bell [Thu, 28 Oct 2021 16:27:46 +0000 (12:27 -0400)] 
Use builtins for overflow detection

4 years agoAdd some fudge to prevent spurious failures
Arran Cudbard-Bell [Thu, 28 Oct 2021 16:27:00 +0000 (12:27 -0400)] 
Add some fudge to prevent spurious failures

4 years agouse scale function instead of inline code
Alan T. DeKok [Thu, 28 Oct 2021 12:51:04 +0000 (08:51 -0400)] 
use scale function instead of inline code

the scale function also checks for overflow, and clamps the
output.

4 years agobetter variable name
Alan T. DeKok [Thu, 28 Oct 2021 12:50:56 +0000 (08:50 -0400)] 
better variable name

4 years agomove fr_unix_time_from_str() to time.c
Alan T. DeKok [Thu, 28 Oct 2021 12:35:29 +0000 (08:35 -0400)] 
move fr_unix_time_from_str() to time.c

4 years agoremove unused variable
Alan T. DeKok [Thu, 28 Oct 2021 12:35:13 +0000 (08:35 -0400)] 
remove unused variable

4 years agoremove redundant check
Alan T. DeKok [Wed, 27 Oct 2021 18:38:36 +0000 (14:38 -0400)] 
remove redundant check

4 years agotimeout too.
Arran Cudbard-Bell [Wed, 27 Oct 2021 20:58:03 +0000 (16:58 -0400)] 
timeout too.

4 years agoRun "slow-unit" output files too and pass _all_ matching crash files, not just the...
Arran Cudbard-Bell [Wed, 27 Oct 2021 20:46:20 +0000 (16:46 -0400)] 
Run "slow-unit" output files too and pass _all_ matching crash files, not just the first

4 years agoMake sure we really have overflowed
Arran Cudbard-Bell [Wed, 27 Oct 2021 20:00:40 +0000 (16:00 -0400)] 
Make sure we really have overflowed

4 years agoFix undefined behaviour in fr_time_delta_from_str
Arran Cudbard-Bell [Wed, 27 Oct 2021 19:46:01 +0000 (15:46 -0400)] 
Fix undefined behaviour in fr_time_delta_from_str

4 years agowhich -s is apparently nonstandard
Arran Cudbard-Bell [Wed, 27 Oct 2021 19:31:50 +0000 (15:31 -0400)] 
which -s is apparently nonstandard

4 years agoNo flock on macOS
Arran Cudbard-Bell [Wed, 27 Oct 2021 19:19:29 +0000 (15:19 -0400)] 
No flock on macOS

4 years agoDeal with zero length strings being cast to octets
Arran Cudbard-Bell [Wed, 27 Oct 2021 19:09:36 +0000 (15:09 -0400)] 
Deal with zero length strings being cast to octets

4 years agoFold data[0] by the number of types
Arran Cudbard-Bell [Wed, 27 Oct 2021 18:21:52 +0000 (14:21 -0400)] 
Fold data[0] by the number of types

4 years agoapparently this is needed
Alan T. DeKok [Wed, 27 Oct 2021 18:09:47 +0000 (14:09 -0400)] 
apparently this is needed

4 years agothese are only in clang>=13
Alan T. DeKok [Wed, 27 Oct 2021 15:05:44 +0000 (11:05 -0400)] 
these are only in clang>=13

4 years agoDon't use an intermediary buffer
Arran Cudbard-Bell [Wed, 27 Oct 2021 17:55:52 +0000 (13:55 -0400)] 
Don't use an intermediary buffer

4 years agoFix inlining for tmpl_cast_quote
Arran Cudbard-Bell [Wed, 27 Oct 2021 17:19:14 +0000 (13:19 -0400)] 
Fix inlining for tmpl_cast_quote

4 years agoSwitch ethernet parsing to substring parsing
Arran Cudbard-Bell [Wed, 27 Oct 2021 17:01:25 +0000 (13:01 -0400)] 
Switch ethernet parsing to substring parsing

4 years agoUse the cast type in fr_cond_promot_types
Arran Cudbard-Bell [Wed, 27 Oct 2021 17:00:57 +0000 (13:00 -0400)] 
Use the cast type in fr_cond_promot_types

4 years agoFill missed element in decode array
Arran Cudbard-Bell [Wed, 27 Oct 2021 16:59:30 +0000 (12:59 -0400)] 
Fill missed element in decode array

Break if either !a || !b even if it's not an error

4 years agoOnly raise an error on base 0 if we find trailing hexits AND a hex prefix
Arran Cudbard-Bell [Wed, 27 Oct 2021 16:58:56 +0000 (12:58 -0400)] 
Only raise an error on base 0 if we find trailing hexits AND a hex prefix

4 years agoAdd fr_value_box_from_substr
Arran Cudbard-Bell [Wed, 27 Oct 2021 16:15:47 +0000 (12:15 -0400)] 
Add fr_value_box_from_substr

it's not yet complete, but even the addition of the function caused significant issues.  It should now be safe at least...

4 years agoradict should only load the specified protocol
Arran Cudbard-Bell [Wed, 27 Oct 2021 15:51:38 +0000 (11:51 -0400)] 
radict should only load the specified protocol

4 years agoMissing error code string
Arran Cudbard-Bell [Wed, 27 Oct 2021 15:32:31 +0000 (11:32 -0400)] 
Missing error code string

4 years agoAdd escape rule lookup by char
Arran Cudbard-Bell [Wed, 27 Oct 2021 15:30:47 +0000 (11:30 -0400)] 
Add escape rule lookup by char

4 years agoFix radict to work with nested attributes
Arran Cudbard-Bell [Tue, 26 Oct 2021 21:29:26 +0000 (17:29 -0400)] 
Fix radict to work with nested attributes

4 years agosbuff reparse should set current to start
Arran Cudbard-Bell [Tue, 26 Oct 2021 20:36:12 +0000 (16:36 -0400)] 
sbuff reparse should set current to start

4 years agocheck bounds
Alan T. DeKok [Wed, 27 Oct 2021 13:57:30 +0000 (09:57 -0400)] 
check bounds

4 years agowe're not using this yet
Alan T. DeKok [Wed, 27 Oct 2021 13:20:58 +0000 (09:20 -0400)] 
we're not using this yet

4 years agojust find the files manually
Alan T. DeKok [Tue, 26 Oct 2021 19:12:09 +0000 (15:12 -0400)] 
just find the files manually

4 years agonew log-id targets and scripts
Alan T. DeKok [Tue, 26 Oct 2021 19:06:15 +0000 (15:06 -0400)] 
new log-id targets and scripts

4 years agoTypo
Arran Cudbard-Bell [Tue, 26 Oct 2021 18:33:37 +0000 (14:33 -0400)] 
Typo

4 years agoTypo
Arran Cudbard-Bell [Tue, 26 Oct 2021 18:27:34 +0000 (14:27 -0400)] 
Typo

4 years agoDetermine when typeof(ssize_t) == typeof(int64_t) and fix _Generic expressions which...
Arran Cudbard-Bell [Tue, 26 Oct 2021 18:21:42 +0000 (14:21 -0400)] 
Determine when typeof(ssize_t) == typeof(int64_t) and fix _Generic expressions which use both

4 years agoMove type compatibility check macro to build.h
Arran Cudbard-Bell [Tue, 26 Oct 2021 18:20:39 +0000 (14:20 -0400)] 
Move type compatibility check macro to build.h

4 years agoparent from the correct ctx
Alan T. DeKok [Tue, 26 Oct 2021 12:39:46 +0000 (08:39 -0400)] 
parent from the correct ctx

4 years agofix these, too
Alan T. DeKok [Tue, 26 Oct 2021 12:35:32 +0000 (08:35 -0400)] 
fix these, too

4 years agoUINT8_MAX is 255. Characters go from 0..255. Which is 256
Alan T. DeKok [Tue, 26 Oct 2021 12:32:56 +0000 (08:32 -0400)] 
UINT8_MAX is 255.  Characters go from 0..255.  Which is 256

4 years agoNot committed yet
Arran Cudbard-Bell [Mon, 25 Oct 2021 18:25:10 +0000 (14:25 -0400)] 
Not committed yet

4 years agoConvert fixed width type conversion sbuff functions to return a fr_slen_t
Arran Cudbard-Bell [Mon, 25 Oct 2021 18:21:06 +0000 (14:21 -0400)] 
Convert fixed width type conversion sbuff functions to return a fr_slen_t

4 years agoAdd function to converting parse errors to strerrors
Arran Cudbard-Bell [Mon, 25 Oct 2021 18:20:04 +0000 (14:20 -0400)] 
Add function to converting parse errors to strerrors

4 years agoError out if setting tmpl cast failed
Arran Cudbard-Bell [Mon, 25 Oct 2021 18:19:24 +0000 (14:19 -0400)] 
Error out if setting tmpl cast failed

4 years agoMore verbose assert on type mismatch
Arran Cudbard-Bell [Mon, 25 Oct 2021 18:18:01 +0000 (14:18 -0400)] 
More verbose assert on type mismatch

4 years agoAssert that *out isn't set if the substr parsers return an error
Arran Cudbard-Bell [Mon, 25 Oct 2021 18:17:19 +0000 (14:17 -0400)] 
Assert that *out isn't set if the substr parsers return an error

4 years agoUse a single error label in compile_switch
Arran Cudbard-Bell [Mon, 25 Oct 2021 18:16:29 +0000 (14:16 -0400)] 
Use a single error label in compile_switch

4 years agoFix some capitalisation
Arran Cudbard-Bell [Mon, 25 Oct 2021 18:15:44 +0000 (14:15 -0400)] 
Fix some capitalisation

4 years agoAdd macro for automatic thread-local sbuffs
Arran Cudbard-Bell [Mon, 25 Oct 2021 18:14:44 +0000 (14:14 -0400)] 
Add macro for automatic thread-local sbuffs

4 years agoUse size_t for recording token len
Arran Cudbard-Bell [Mon, 25 Oct 2021 18:10:53 +0000 (14:10 -0400)] 
Use size_t for recording token len

4 years agoHandle is used
Arran Cudbard-Bell [Mon, 25 Oct 2021 17:55:06 +0000 (13:55 -0400)] 
Handle is used

4 years agoMove tmpl parse rules to value.c
Arran Cudbard-Bell [Mon, 25 Oct 2021 17:53:01 +0000 (13:53 -0400)] 
Move tmpl parse rules to value.c

4 years agofree unknown da's, too.
Alan T. DeKok [Mon, 25 Oct 2021 16:52:38 +0000 (12:52 -0400)] 
free unknown da's, too.

just to have less peak memory usage when decoding bad packets.

4 years agoallocate and free decode_ctx on every run
Alan T. DeKok [Mon, 25 Oct 2021 17:09:21 +0000 (13:09 -0400)] 
allocate and free decode_ctx on every run

4 years agoreturn correct offset
Alan T. DeKok [Mon, 25 Oct 2021 17:02:56 +0000 (13:02 -0400)] 
return correct offset

4 years agoAd hoc fuzzing: Allow selection of a single protocol (in addition to runtime) (#4293)
Terry Burton [Mon, 25 Oct 2021 13:23:02 +0000 (14:23 +0100)] 
Ad hoc fuzzing: Allow selection of a single protocol (in addition to runtime) (#4293)

4 years agoFixed for nightly fuzzing to align with new Make approach (#4289)
Terry Burton [Sun, 24 Oct 2021 19:09:21 +0000 (20:09 +0100)] 
Fixed for nightly fuzzing to align with new Make approach (#4289)

* Fix nightly fuzzing; dynamic matrix of protocols to fuzz

* CI: Don't run all tests for special fuzzer runs

4 years agoignore fuzzer files. Fixes #4287
Alan T. DeKok [Fri, 22 Oct 2021 19:59:19 +0000 (15:59 -0400)] 
ignore fuzzer files.  Fixes #4287

4 years agominimize more includes
Alan T. DeKok [Fri, 22 Oct 2021 13:54:53 +0000 (09:54 -0400)] 
minimize more includes

4 years agov4: Remove old sychronous LDAP code (#4286)
Nick Porter [Fri, 22 Oct 2021 18:54:49 +0000 (19:54 +0100)] 
v4: Remove old sychronous LDAP code (#4286)

4 years agoSome coverity workflow fixes (#4288)
Terry Burton [Fri, 22 Oct 2021 18:28:30 +0000 (19:28 +0100)] 
Some coverity workflow fixes (#4288)

* Don't trigger package builds on push to coverity_scan branch

* Allow out-of-project coverity scans on push to coverity_scan

* Key the cache for the Coverity scan tool based on its MD5

4 years agofuzzer CI: Don't choke on log output alone; sufficient parallelism for all (#4284)
Terry Burton [Fri, 22 Oct 2021 12:16:09 +0000 (13:16 +0100)] 
fuzzer CI: Don't choke on log output alone; sufficient parallelism for all (#4284)

4 years agoFix oracle packaging
Arran Cudbard-Bell [Fri, 22 Oct 2021 02:02:52 +0000 (22:02 -0400)] 
Fix oracle packaging

4 years agoremove unused assignment
Alan T. DeKok [Thu, 21 Oct 2021 22:18:59 +0000 (18:18 -0400)] 
remove unused assignment

4 years agoone more fix
Alan T. DeKok [Thu, 21 Oct 2021 20:32:13 +0000 (16:32 -0400)] 
one more fix

4 years agogit-lfs requires an external mutex (#4283)
Terry Burton [Thu, 21 Oct 2021 19:17:34 +0000 (20:17 +0100)] 
git-lfs requires an external mutex (#4283)

4 years agoneed this too
Alan T. DeKok [Thu, 21 Oct 2021 18:03:23 +0000 (14:03 -0400)] 
need this too

4 years agoclean auto-generated headers only on "make distclean"
Alan T. DeKok [Thu, 21 Oct 2021 18:01:43 +0000 (14:01 -0400)] 
clean auto-generated headers only on "make distclean"

because (at least on OSX) it takes a very long time to regenerate
them.

4 years agomore "run min-includes"
Alan T. DeKok [Thu, 21 Oct 2021 17:44:32 +0000 (13:44 -0400)] 
more "run min-includes"

4 years agorun min-includes
Alan T. DeKok [Thu, 21 Oct 2021 17:42:57 +0000 (13:42 -0400)] 
run min-includes

now that the "include everything" headers have been removed.

4 years agono need to include server/base.h everywhere
Alan T. DeKok [Thu, 21 Oct 2021 17:30:35 +0000 (13:30 -0400)] 
no need to include server/base.h everywhere

4 years agofewer includes
Alan T. DeKok [Thu, 21 Oct 2021 17:29:55 +0000 (13:29 -0400)] 
fewer includes

4 years agoremove unnecessary includes
Alan T. DeKok [Thu, 21 Oct 2021 17:06:18 +0000 (13:06 -0400)] 
remove unnecessary includes

4 years agostart of defining macros, etc. for log IDs
Alan T. DeKok [Thu, 21 Oct 2021 16:08:18 +0000 (12:08 -0400)] 
start of defining macros, etc. for log IDs

only for a few libraries, and not yet plumbed into anything else.

4 years agoremove util/base.h, and replace with specific files
Alan T. DeKok [Thu, 21 Oct 2021 16:06:13 +0000 (12:06 -0400)] 
remove util/base.h, and replace with specific files

4 years agorun min_includes.pl on these files
Alan T. DeKok [Thu, 21 Oct 2021 15:03:45 +0000 (11:03 -0400)] 
run min_includes.pl on these files

which removes extraneous includes.  Not that it does not reorder
the includes, or try to figure out which includes are necessary
for what.  That may be better done by something like
include-what-you-use, but the output of that tool requires
substantial work to understand.

4 years agofixes
Alan T. DeKok [Thu, 21 Oct 2021 15:02:43 +0000 (11:02 -0400)] 
fixes

4 years agoFix rlm_cache build issues (#4282)
Jorge Pereira [Thu, 21 Oct 2021 15:47:16 +0000 (12:47 -0300)] 
Fix rlm_cache build issues (#4282)

4 years agoFix rlm_sql_oracle minor issues (#4281)
Jorge Pereira [Thu, 21 Oct 2021 15:19:38 +0000 (12:19 -0300)] 
Fix rlm_sql_oracle minor issues (#4281)

4 years agoAdd Oracle session pool to rlm_sql oracle driver (#2868)
Robert Biktimirov [Thu, 21 Oct 2021 14:19:23 +0000 (17:19 +0300)] 
Add Oracle session pool to rlm_sql oracle driver (#2868)

Adding support for receiving connections using the built-in oracle client session mechanism.
Changing the function of preparing a query for execution from OCIStmtPrepare to OCIStmtPrepare2, since this function was deprecated beginning with Oracle Database 12c Release 2 (12.2).
This breaks the ability to use Oracle client below 10g

Co-authored-by: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
4 years agoAdd methods cache.{store,load,status,clear,ttl} for rlm_cache (#3013)
Jorge Pereira [Thu, 21 Oct 2021 14:17:55 +0000 (11:17 -0300)] 
Add methods cache.{store,load,status,clear,ttl} for rlm_cache (#3013)

* Add methods cache.{store,load,status,clear,ttl} for rlm_cache

Now the rlm_cache has the capability of handling the cache entries using
methods.

* Add tests for the methods

It adds tests for the new rlm_cache methods.

* Update the raddb/mods-available/cache

Add references related to the new rlm_cache methods.

4 years agoFix acct_unique policy (#4278) (#4280)
Jorge Pereira [Thu, 21 Oct 2021 14:17:48 +0000 (11:17 -0300)] 
Fix acct_unique policy (#4278) (#4280)

As the 'acct_unique' is setting the request:Tmp-String-9,
then we should unset it!

4 years agoattempts to allow for sorting of includes.
Alan T. DeKok [Thu, 21 Oct 2021 14:05:17 +0000 (10:05 -0400)] 
attempts to allow for sorting of includes.

it's likely that we still need manual edits after that, especially
for stuff in src/lib/util which does PRIVATE things.