]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
4 years agoFix fr_dlist_foreach_safe
Arran Cudbard-Bell [Mon, 6 Sep 2021 20:31:59 +0000 (15:31 -0500)] 
Fix fr_dlist_foreach_safe

4 years agoFix more issues
Arran Cudbard-Bell [Mon, 6 Sep 2021 16:35:01 +0000 (11:35 -0500)] 
Fix more issues

4 years ago...and here
Arran Cudbard-Bell [Mon, 6 Sep 2021 16:10:08 +0000 (11:10 -0500)] 
...and here

4 years agoTypo
Arran Cudbard-Bell [Mon, 6 Sep 2021 16:06:20 +0000 (11:06 -0500)] 
Typo

4 years agoMaintain a list of "reap" requests, and make sure they're all cleaned up when the...
Arran Cudbard-Bell [Mon, 6 Sep 2021 16:02:20 +0000 (11:02 -0500)] 
Maintain a list of "reap" requests, and make sure they're all cleaned up when the event loop exits

4 years agoMake the repo commands prettier
Arran Cudbard-Bell [Mon, 6 Sep 2021 14:00:02 +0000 (09:00 -0500)] 
Make the repo commands prettier

4 years agoGet CODENAME and DIST dynamically from lsb_release
Arran Cudbard-Bell [Mon, 6 Sep 2021 13:39:10 +0000 (08:39 -0500)] 
Get CODENAME and DIST dynamically from lsb_release

4 years ago...same but with an actions script
Arran Cudbard-Bell [Mon, 6 Sep 2021 13:03:38 +0000 (08:03 -0500)] 
...same but with an actions script

4 years agoAdd NR repo to main CI workflow
Arran Cudbard-Bell [Mon, 6 Sep 2021 12:52:59 +0000 (07:52 -0500)] 
Add NR repo to main CI workflow

4 years agoNote on what vps is.
Arran Cudbard-Bell [Mon, 30 Aug 2021 17:59:30 +0000 (12:59 -0500)] 
Note on what vps is.

4 years agoallow foo.bar.baz = 1 for laziness
Alan T. DeKok [Fri, 3 Sep 2021 18:01:52 +0000 (14:01 -0400)] 
allow foo.bar.baz = 1 for laziness

with some caveats and qualifications

4 years agotime_delta is signed by default
Alan T. DeKok [Thu, 2 Sep 2021 15:33:47 +0000 (11:33 -0400)] 
time_delta is signed by default

add tests.

Catch the case (parsing and printing) of negative zero

4 years agoprint out the strings we have, too
Alan T. DeKok [Thu, 2 Sep 2021 15:33:26 +0000 (11:33 -0400)] 
print out the strings we have, too

4 years agoparse 1h, 1m, etc. correctly
Alan T. DeKok [Thu, 2 Sep 2021 15:01:24 +0000 (11:01 -0400)] 
parse 1h, 1m, etc. correctly

4 years agouse correct MOD macro.
Alan T. DeKok [Thu, 2 Sep 2021 15:00:28 +0000 (11:00 -0400)] 
use correct MOD macro.

4 years agouse Acct-Delay-Time when calculating Event-Timestamp
Alan T. DeKok [Thu, 2 Sep 2021 14:48:24 +0000 (10:48 -0400)] 
use Acct-Delay-Time when calculating Event-Timestamp

4 years agoclean up and check for overflows
Alan T. DeKok [Wed, 1 Sep 2021 21:10:02 +0000 (17:10 -0400)] 
clean up and check for overflows

4 years agoparse *signed* time deltas
Alan T. DeKok [Wed, 1 Sep 2021 20:37:06 +0000 (16:37 -0400)] 
parse *signed* time deltas

and don't allow fractional minutes, hours, or days.  That doesn't
make any sense.

There are still many possibilities for overflow, so fixing that
is next.

4 years agoprint out signed time_delta, too
Alan T. DeKok [Wed, 1 Sep 2021 20:30:34 +0000 (16:30 -0400)] 
print out signed time_delta, too

4 years agoallow time_delta to be _unsigned_ when we encode it in the network
Alan T. DeKok [Wed, 1 Sep 2021 13:53:08 +0000 (09:53 -0400)] 
allow time_delta to be _unsigned_ when we encode it in the network

e.g. for RADIUS, with Session-Timeout

4 years agominor rearrangement
Alan T. DeKok [Wed, 1 Sep 2021 13:52:19 +0000 (09:52 -0400)] 
minor rearrangement

4 years agotime deltas are signed
Alan T. DeKok [Wed, 1 Sep 2021 13:45:51 +0000 (09:45 -0400)] 
time deltas are signed

so we need to unpack them as signed values, too

4 years agocorrect the parser for dates / time deltas
Alan T. DeKok [Wed, 1 Sep 2021 13:13:54 +0000 (09:13 -0400)] 
correct the parser for dates / time deltas

4 years agoremove UNUSED
Alan T. DeKok [Tue, 31 Aug 2021 22:46:23 +0000 (18:46 -0400)] 
remove UNUSED

4 years agoshut up clang analyzer
Alan T. DeKok [Tue, 31 Aug 2021 22:15:10 +0000 (18:15 -0400)] 
shut up clang analyzer

4 years agoadd retry tests
Alan T. DeKok [Tue, 31 Aug 2021 22:00:54 +0000 (18:00 -0400)] 
add retry tests

4 years agoincrement count before checking mrc
Alan T. DeKok [Tue, 31 Aug 2021 19:59:22 +0000 (15:59 -0400)] 
increment count before checking mrc

4 years agoimplement retries for sections and modules
Alan T. DeKok [Tue, 31 Aug 2021 19:36:07 +0000 (15:36 -0400)] 
implement retries for sections and modules

if the module doesn't natively support retries, it's just
re-run over and over until it succeeds, or the retry limits
are hit.

4 years agoensure that retries don't get carried to subsections on compilation
Alan T. DeKok [Tue, 31 Aug 2021 19:35:16 +0000 (15:35 -0400)] 
ensure that retries don't get carried to subsections on compilation

we probably want to do the same thing for MOD_ACTION_RETURN, too

4 years agoupdate / fix restrictions on retries.
Alan T. DeKok [Tue, 31 Aug 2021 18:35:58 +0000 (14:35 -0400)] 
update / fix restrictions on retries.

4 years agoadd "fail = retry" and sanity check it in the parser
Alan T. DeKok [Tue, 31 Aug 2021 15:01:46 +0000 (11:01 -0400)] 
add "fail = retry" and sanity check it in the parser

note that if we have a section which is doing retries, it can
have "fail = retry".  But its sub-sections cannot have "fail=retry"
because that doesn't make much sense.

4 years agotweak messages
Alan T. DeKok [Tue, 31 Aug 2021 15:00:54 +0000 (11:00 -0400)] 
tweak messages

4 years agono name2 and NULL means it's a match
Alan T. DeKok [Tue, 31 Aug 2021 13:40:04 +0000 (09:40 -0400)] 
no name2 and NULL means it's a match

4 years agomore error messages
Alan T. DeKok [Tue, 31 Aug 2021 13:31:54 +0000 (09:31 -0400)] 
more error messages

4 years agoshut up compiler
Alan T. DeKok [Mon, 30 Aug 2021 21:19:45 +0000 (17:19 -0400)] 
shut up compiler

4 years agoadd retry and timeout signals to modules
Alan T. DeKok [Mon, 30 Aug 2021 20:44:37 +0000 (16:44 -0400)] 
add retry and timeout signals to modules

and add a "retry" method to the "test" module.

tests to follow

4 years agoon compile subsection, reset actions.retry to zero
Alan T. DeKok [Mon, 30 Aug 2021 20:00:00 +0000 (16:00 -0400)] 
on compile subsection, reset actions.retry to zero

otherwise each individual section will duplicate all of the
retry actions

4 years agoadd RETRY_CAPABLE flag, and check it in module compilation
Alan T. DeKok [Mon, 30 Aug 2021 18:24:22 +0000 (14:24 -0400)] 
add RETRY_CAPABLE flag, and check it in module compilation

so that we don't erroneously resume modules on timers, when the
modules don't expect to be resumed.

4 years agoadd function to change resumption handler for a module.
Alan T. DeKok [Mon, 30 Aug 2021 18:04:19 +0000 (14:04 -0400)] 
add function to change resumption handler for a module.

4 years agoset default module actions, too
Alan T. DeKok [Mon, 30 Aug 2021 17:53:05 +0000 (13:53 -0400)] 
set default module actions, too

and do some minor cleanups and comments for action / retry
handling

4 years agoadd and compile "actions" in module configurations
Alan T. DeKok [Mon, 30 Aug 2021 17:39:36 +0000 (13:39 -0400)] 
add and compile "actions" in module configurations

4 years agorename for clarity
Alan T. DeKok [Mon, 30 Aug 2021 17:35:30 +0000 (13:35 -0400)] 
rename for clarity

4 years agovariables are USED
Alan T. DeKok [Mon, 30 Aug 2021 17:31:15 +0000 (13:31 -0400)] 
variables are USED

4 years agoRemove ref to radius_exec_program_legacy
Arran Cudbard-Bell [Mon, 30 Aug 2021 17:18:58 +0000 (12:18 -0500)] 
Remove ref to radius_exec_program_legacy

4 years agoSplit out legacy exec functions to make them easier to remove in future
Arran Cudbard-Bell [Mon, 30 Aug 2021 17:16:46 +0000 (12:16 -0500)] 
Split out legacy exec functions to make them easier to remove in future

4 years agoLast remaining exec issues (hopefully)
Arran Cudbard-Bell [Mon, 30 Aug 2021 16:58:03 +0000 (11:58 -0500)] 
Last remaining exec issues (hopefully)

4 years agofix scan / warnings
Alan T. DeKok [Sat, 28 Aug 2021 12:48:57 +0000 (08:48 -0400)] 
fix scan / warnings

4 years agotrack and clean up old packets
Alan T. DeKok [Fri, 27 Aug 2021 20:33:30 +0000 (16:33 -0400)] 
track and clean up old packets

When we send a reply, track the State in a new hash table,
and associate the fr_io_track_t with that state.

When we create a new tracking entry for a packet with a State,
look up the &request.State.  If there's a matching entry, then
free it.  Which means that we don't keep old packets around
in the dedup tree.

4 years agodebug3 print header, and fix error in length check on decode
Alan T. DeKok [Fri, 27 Aug 2021 20:03:01 +0000 (16:03 -0400)] 
debug3 print header, and fix error in length check on decode

4 years agomore descriptive error messages
Alan T. DeKok [Fri, 27 Aug 2021 19:42:28 +0000 (15:42 -0400)] 
more descriptive error messages

4 years agotrack client->packets in track create / free
Alan T. DeKok [Fri, 27 Aug 2021 15:25:45 +0000 (11:25 -0400)] 
track client->packets in track create / free

because there's no good reason to do it elsewhere

4 years agoUse the generated certs for rlm_cipher
Arran Cudbard-Bell [Mon, 30 Aug 2021 01:02:49 +0000 (20:02 -0500)] 
Use the generated certs for rlm_cipher

4 years agoFix verify_mode parsing (has to be done before checking cert attributes)
Arran Cudbard-Bell [Mon, 30 Aug 2021 00:58:25 +0000 (19:58 -0500)] 
Fix verify_mode parsing (has to be done before checking cert attributes)

4 years agoel is used
Arran Cudbard-Bell [Sun, 29 Aug 2021 17:27:18 +0000 (12:27 -0500)] 
el is used

4 years agoQuiet CI error on macOS
Arran Cudbard-Bell [Sun, 29 Aug 2021 16:23:49 +0000 (11:23 -0500)] 
Quiet CI error on macOS

4 years ago...and one more
Arran Cudbard-Bell [Sun, 29 Aug 2021 00:10:09 +0000 (19:10 -0500)] 
...and one more

4 years agoUse correct exec status
Arran Cudbard-Bell [Sun, 29 Aug 2021 00:06:02 +0000 (19:06 -0500)] 
Use correct exec status

4 years agoUse a single unified exec cleanup function for cleaning up
Arran Cudbard-Bell [Sat, 28 Aug 2021 16:47:46 +0000 (11:47 -0500)] 
Use a single unified exec cleanup function for cleaning up

Represent cleaned up PIDs as -1, just like we do with FDs

4 years agoUse fr_event_pid_reap instead of fr_event_pid_wait in exec.c
Arran Cudbard-Bell [Sat, 28 Aug 2021 16:46:42 +0000 (11:46 -0500)] 
Use fr_event_pid_reap instead of fr_event_pid_wait in exec.c

4 years agoRemove untrue comment
Arran Cudbard-Bell [Sat, 28 Aug 2021 16:45:24 +0000 (11:45 -0500)] 
Remove untrue comment

4 years agoMore docs for EVFILT_PROC in event.c
Arran Cudbard-Bell [Sat, 28 Aug 2021 16:44:22 +0000 (11:44 -0500)] 
More docs for EVFILT_PROC in event.c

4 years agoAdd pid reaping function
Arran Cudbard-Bell [Sat, 28 Aug 2021 16:43:34 +0000 (11:43 -0500)] 
Add pid reaping function

4 years agoUse waitid as the backup method for determining if a process has exited not waitpid
Arran Cudbard-Bell [Sat, 28 Aug 2021 15:25:19 +0000 (10:25 -0500)] 
Use waitid as the backup method for determining if a process has exited not waitpid

Waitpid reaps the process which would cause an error in the resumption callback.

4 years agoBetter error handling in fr_event_pid_wait
Arran Cudbard-Bell [Sat, 28 Aug 2021 02:35:53 +0000 (21:35 -0500)] 
Better error handling in fr_event_pid_wait

4 years agoNotes on stdin cleanup
Arran Cudbard-Bell [Sat, 28 Aug 2021 00:10:26 +0000 (19:10 -0500)] 
Notes on stdin cleanup

4 years agoFix spurious warning
Arran Cudbard-Bell [Fri, 27 Aug 2021 23:59:48 +0000 (18:59 -0500)] 
Fix spurious warning

4 years agoFix minor build errors
Arran Cudbard-Bell [Fri, 27 Aug 2021 23:11:41 +0000 (18:11 -0500)] 
Fix minor build errors

4 years agopid is signed, so give it a default value of -1
Arran Cudbard-Bell [Fri, 27 Aug 2021 23:05:13 +0000 (18:05 -0500)] 
pid is signed, so give it a default value of -1

4 years agoDeal with race between EVFILT_READ and EVFILT_PROC
Arran Cudbard-Bell [Fri, 27 Aug 2021 23:01:59 +0000 (18:01 -0500)] 
Deal with race between EVFILT_READ and EVFILT_PROC

If EVFILT_PROC is delivered first we may never end up reading pending stdout/stderr data.

4 years agoDeal with EWOULDBLOCK gracefully in log_request_fd_event
Arran Cudbard-Bell [Fri, 27 Aug 2021 23:00:58 +0000 (18:00 -0500)] 
Deal with EWOULDBLOCK gracefully in log_request_fd_event

4 years agoCalling __builtin_clzll with a 0 value is undefined (and it does the wrong thing)
Arran Cudbard-Bell [Fri, 27 Aug 2021 22:56:26 +0000 (17:56 -0500)] 
Calling __builtin_clzll with a 0 value is undefined (and it does the wrong thing)

4 years agoAllow users of event.c to get at the callbacks registered
Arran Cudbard-Bell [Fri, 27 Aug 2021 22:55:55 +0000 (17:55 -0500)] 
Allow users of event.c to get at the callbacks registered

This is mainly for the exec code so it can manually call the read callbacks before processes exit.

4 years agoAdd atexit.h macro for doing automatic initialisation and freeing of global resources
Arran Cudbard-Bell [Fri, 27 Aug 2021 22:52:14 +0000 (17:52 -0500)] 
Add atexit.h macro for doing automatic initialisation and freeing of global resources

Should be much cheaper than pthread_once

4 years agoAdjust initial LST pivot stack size in accordance with initial size (#4213)
James Jones [Fri, 27 Aug 2021 15:44:41 +0000 (10:44 -0500)] 
Adjust initial LST pivot stack size in accordance with initial size (#4213)

It's now initially max(1, log2(initial array size)).

4 years agoorder requests by sequence number, too
Alan T. DeKok [Fri, 27 Aug 2021 14:57:40 +0000 (10:57 -0400)] 
order requests by sequence number, too

4 years agopass fr_io_track_t to track_create function
Alan T. DeKok [Fri, 27 Aug 2021 14:40:29 +0000 (10:40 -0400)] 
pass fr_io_track_t to track_create function

so that we can free old tracking entries by just talloc_free'ing
them

4 years agopass instance / thread instance to track_create
Alan T. DeKok [Fri, 27 Aug 2021 14:22:14 +0000 (10:22 -0400)] 
pass instance / thread instance to track_create

in preparation for doing more aggressive cleanups of tracking
entries

4 years agoFix error marker check
Arran Cudbard-Bell [Fri, 27 Aug 2021 14:53:00 +0000 (09:53 -0500)] 
Fix error marker check

4 years agoMake lst_validate() consistent with current lst functions and types (#4212)
James Jones [Fri, 27 Aug 2021 04:30:45 +0000 (23:30 -0500)] 
Make lst_validate() consistent with current lst functions and types (#4212)

4 years agoRemove LOCAL_PID hacks, we'll reimplement it in libkqueue
Arran Cudbard-Bell [Fri, 27 Aug 2021 01:12:39 +0000 (20:12 -0500)] 
Remove LOCAL_PID hacks, we'll reimplement it in libkqueue

4 years agoFix event_timer_location_cmp
Arran Cudbard-Bell [Thu, 26 Aug 2021 23:32:46 +0000 (23:32 +0000)] 
Fix event_timer_location_cmp

4 years agoAdd init parameter to LST creation closes #4210
James Jones [Thu, 26 Aug 2021 16:02:56 +0000 (11:02 -0500)] 
Add init parameter to LST creation closes #4210

The parameter determines the initial capacity choice: 0 will get
the default initial capacity, while any other value will be rounded
up to a power of 2 and used as the initial capacity.

4 years agoMeant to revert the other commit
Arran Cudbard-Bell [Thu, 26 Aug 2021 18:32:49 +0000 (13:32 -0500)] 
Meant to revert the other commit

This reverts commit f1760b1302a00524c3a8cf6298b0bb0b5ea53524.

4 years agoit's now fr_unix_time_from_tm()
Alan T. DeKok [Wed, 25 Aug 2021 21:17:26 +0000 (17:17 -0400)] 
it's now fr_unix_time_from_tm()

all of the uses of it either set the time zone, or used mktime()
and then called fr_unix_time_from_timeval().  So to simplify things,
we just use fr_unix_time_from_tm()

4 years agochange to passing CONF_SECTION, and publish it
Alan T. DeKok [Wed, 25 Aug 2021 15:57:04 +0000 (11:57 -0400)] 
change to passing CONF_SECTION, and publish it

4 years agoupdate initializer
Alan T. DeKok [Wed, 25 Aug 2021 15:50:54 +0000 (11:50 -0400)] 
update initializer

4 years agopass actions to compile function
Alan T. DeKok [Wed, 25 Aug 2021 15:34:21 +0000 (11:34 -0400)] 
pass actions to compile function

in preparation for making it public

4 years agoparse "retry" subsection of "actions"
Alan T. DeKok [Wed, 25 Aug 2021 15:03:38 +0000 (11:03 -0400)] 
parse "retry" subsection of "actions"

4 years agoadd "retry" subsection to actions
Alan T. DeKok [Wed, 25 Aug 2021 13:06:23 +0000 (09:06 -0400)] 
add "retry" subsection to actions

4 years agomacro to initialize data structure
Alan T. DeKok [Wed, 25 Aug 2021 13:04:58 +0000 (09:04 -0400)] 
macro to initialize data structure

4 years agoMore fr_time_from_utc fixes
Arran Cudbard-Bell [Wed, 25 Aug 2021 20:56:10 +0000 (15:56 -0500)] 
More fr_time_from_utc fixes

4 years agoAdd safety check for mod_post_auth
Arran Cudbard-Bell [Wed, 25 Aug 2021 20:51:45 +0000 (15:51 -0500)] 
Add safety check  for mod_post_auth

4 years agoRemove perl keyword test
Arran Cudbard-Bell [Wed, 25 Aug 2021 19:17:15 +0000 (14:17 -0500)] 
Remove perl keyword test

4 years agoMove perl xlat tests into the module module
Arran Cudbard-Bell [Wed, 25 Aug 2021 18:57:14 +0000 (13:57 -0500)] 
Move perl xlat tests into the module module

4 years agoOptional modules shouldn't be in keywords
Arran Cudbard-Bell [Wed, 25 Aug 2021 18:29:41 +0000 (13:29 -0500)] 
Optional modules shouldn't be in keywords

4 years agoFix sign issue with unix time conversions
Arran Cudbard-Bell [Wed, 25 Aug 2021 18:02:45 +0000 (13:02 -0500)] 
Fix sign issue with unix time conversions

4 years agoFix unbound timeouts
Arran Cudbard-Bell [Wed, 25 Aug 2021 16:57:48 +0000 (11:57 -0500)] 
Fix unbound timeouts

4 years agoAllow xlat calls without instance data
Arran Cudbard-Bell [Wed, 25 Aug 2021 16:47:05 +0000 (11:47 -0500)] 
Allow xlat calls without instance data

4 years agoMore helpful TLS alert messages
Arran Cudbard-Bell [Wed, 25 Aug 2021 16:46:51 +0000 (11:46 -0500)] 
More helpful TLS alert messages

4 years agoMove tls/utils functions into a new header
Arran Cudbard-Bell [Wed, 25 Aug 2021 16:44:24 +0000 (11:44 -0500)] 
Move tls/utils functions into a new header