]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 years agoThread interpreter may be NULL
Arran Cudbard-Bell [Fri, 2 Apr 2021 17:18:55 +0000 (18:18 +0100)] 
Thread interpreter may be NULL

5 years agoRun triggers synchronously in certain situations
Arran Cudbard-Bell [Fri, 2 Apr 2021 17:07:25 +0000 (18:07 +0100)] 
Run triggers synchronously in certain situations

5 years agoDon't SEGV if we don't have a parent and experience an error
Arran Cudbard-Bell [Fri, 2 Apr 2021 15:35:41 +0000 (16:35 +0100)] 
Don't SEGV if we don't have a parent and experience an error

5 years agoDon't detach if already detached
Arran Cudbard-Bell [Fri, 2 Apr 2021 14:55:53 +0000 (15:55 +0100)] 
Don't detach if already detached

5 years agoAllow worker to set a default interpreter for a thread
Arran Cudbard-Bell [Fri, 2 Apr 2021 12:41:16 +0000 (13:41 +0100)] 
Allow worker to set a default interpreter for a thread

5 years agoCopy the interpreter from the parent
Arran Cudbard-Bell [Fri, 2 Apr 2021 12:20:24 +0000 (13:20 +0100)] 
Copy the interpreter from the parent

5 years agoFixup trigger code
Arran Cudbard-Bell [Fri, 2 Apr 2021 12:06:27 +0000 (13:06 +0100)] 
Fixup trigger code

5 years agoset LIBRARY_EXT if it's not already set
Alan T. DeKok [Fri, 2 Apr 2021 09:52:01 +0000 (05:52 -0400)] 
set LIBRARY_EXT if it's not already set

5 years agoreturn PUSHED_CHILD, not YIELD
Alan T. DeKok [Wed, 31 Mar 2021 15:40:06 +0000 (11:40 -0400)] 
return PUSHED_CHILD, not YIELD

which saves another bounce through the event loop

5 years agosuppress leaks on OSX
Alan T. DeKok [Wed, 31 Mar 2021 15:39:41 +0000 (11:39 -0400)] 
suppress leaks on OSX

5 years agoMove MAC validation into eap-sim/aka/aka' module
Arran Cudbard-Bell [Thu, 1 Apr 2021 22:10:10 +0000 (23:10 +0100)] 
Move MAC validation into eap-sim/aka/aka' module

5 years agoSet IDs correctly
Arran Cudbard-Bell [Thu, 1 Apr 2021 21:40:43 +0000 (22:40 +0100)] 
Set IDs correctly

5 years agoMore debugging
Arran Cudbard-Bell [Thu, 1 Apr 2021 21:40:29 +0000 (22:40 +0100)] 
More debugging

5 years agoMove checkcode calculations from state machine to module
Arran Cudbard-Bell [Thu, 1 Apr 2021 16:32:15 +0000 (17:32 +0100)] 
Move checkcode calculations from state machine to module

5 years agoUse correct expected MK length
Arran Cudbard-Bell [Thu, 1 Apr 2021 16:31:10 +0000 (17:31 +0100)] 
Use correct expected MK length

5 years agoand another one...
Arran Cudbard-Bell [Wed, 31 Mar 2021 21:58:11 +0000 (22:58 +0100)] 
and another one...

5 years agoRemove debugging statements
Arran Cudbard-Bell [Wed, 31 Mar 2021 21:55:46 +0000 (22:55 +0100)] 
Remove debugging statements

5 years agoUse cmp macro in more places to fix ordering issues
Arran Cudbard-Bell [Wed, 31 Mar 2021 21:53:51 +0000 (22:53 +0100)] 
Use cmp macro in more places to fix ordering issues

5 years agoDon't update MK, we still need the original for storing new fast reauth IDs
Arran Cudbard-Bell [Wed, 31 Mar 2021 21:52:10 +0000 (22:52 +0100)] 
Don't update MK, we still need the original for storing new fast reauth IDs

5 years agoAdd debugging functions for the next time we have issues with dictionary ref counts
Arran Cudbard-Bell [Wed, 31 Mar 2021 20:43:02 +0000 (21:43 +0100)] 
Add debugging functions for the next time we have issues with dictionary ref counts

5 years agoIncrement instance count when initialising unlang
Arran Cudbard-Bell [Wed, 31 Mar 2021 20:39:31 +0000 (21:39 +0100)] 
Increment instance count when initialising unlang

5 years agoAdditional EAP-SIM regression test
Arran Cudbard-Bell [Wed, 31 Mar 2021 20:38:59 +0000 (21:38 +0100)] 
Additional EAP-SIM regression test

5 years agoRework EAP-AKA' to provide a truncated MK for session resumption
Arran Cudbard-Bell [Wed, 31 Mar 2021 16:58:34 +0000 (17:58 +0100)] 
Rework EAP-AKA' to provide a truncated MK for session resumption

This now makes EAP-AKA' capable of session resumption

5 years agoLet not used
Arran Cudbard-Bell [Wed, 31 Mar 2021 15:25:33 +0000 (16:25 +0100)] 
Let not used

5 years agoInitialise OpenSSL in unit_test_attribute prior to loading other libraries that might...
Arran Cudbard-Bell [Wed, 31 Mar 2021 14:16:22 +0000 (15:16 +0100)] 
Initialise OpenSSL in unit_test_attribute prior to loading other libraries that might also initialise OpenSSL

5 years agoRename thread_local to atexit
Arran Cudbard-Bell [Wed, 31 Mar 2021 12:51:25 +0000 (13:51 +0100)] 
Rename thread_local to atexit

5 years agoAdd function to explicitly trigger all thread local destructors
Arran Cudbard-Bell [Wed, 31 Mar 2021 12:42:06 +0000 (13:42 +0100)] 
Add function to explicitly trigger all thread local destructors

5 years agoAdd debug output for thread local code
Arran Cudbard-Bell [Wed, 31 Mar 2021 08:50:36 +0000 (09:50 +0100)] 
Add debug output for thread local code

5 years agoshut up static analyzer
Alan T. DeKok [Wed, 31 Mar 2021 12:21:52 +0000 (08:21 -0400)] 
shut up static analyzer

5 years agostart of cond_eval_async()
Alan T. DeKok [Tue, 30 Mar 2021 17:15:20 +0000 (13:15 -0400)] 
start of cond_eval_async()

5 years agoRemove request->backlog
Arran Cudbard-Bell [Tue, 30 Mar 2021 10:22:22 +0000 (11:22 +0100)] 
Remove request->backlog

5 years agoUse the $(MAKE) expansion, not `make` else we'll likely end up running the system...
Arran Cudbard-Bell [Tue, 30 Mar 2021 10:21:23 +0000 (11:21 +0100)] 
Use the $(MAKE) expansion, not `make` else we'll likely end up running the system version of make

Which in macos is still 3.81

5 years agodon't load make libraries for "clean".
Alan T. DeKok [Mon, 29 Mar 2021 20:58:55 +0000 (16:58 -0400)] 
don't load make libraries for "clean".

and strip the -fsanitize=... options from the libfreeradius-make
libraries, as GNU Make isn't built with the address/leak sanitizer

5 years agono need to call cond_eval_map()
Alan T. DeKok [Mon, 29 Mar 2021 19:06:25 +0000 (15:06 -0400)] 
no need to call cond_eval_map()

5 years agocache if this condition requires async expansion
Alan T. DeKok [Mon, 29 Mar 2021 16:13:21 +0000 (12:13 -0400)] 
cache if this condition requires async expansion

5 years agoremove depth and condition count after doing validation tests
Alan T. DeKok [Mon, 29 Mar 2021 15:14:35 +0000 (11:14 -0400)] 
remove depth and condition count after doing validation tests

5 years agoFix unused variable
Arran Cudbard-Bell [Mon, 29 Mar 2021 18:52:50 +0000 (19:52 +0100)] 
Fix unused variable

5 years agoRemove more references to "backlog"
Arran Cudbard-Bell [Mon, 29 Mar 2021 16:16:52 +0000 (17:16 +0100)] 
Remove more references to "backlog"

5 years agodon't run unlang_subrequest_child_run multiple times if the child isn't freed immediately
Arran Cudbard-Bell [Mon, 29 Mar 2021 16:16:40 +0000 (17:16 +0100)] 
don't run unlang_subrequest_child_run multiple times if the child isn't freed immediately

5 years agoMove the majority of the SIM/AKA/AKA' logic into process modules
Arran Cudbard-Bell [Mon, 29 Mar 2021 16:16:10 +0000 (17:16 +0100)] 
Move the majority of the SIM/AKA/AKA' logic into process modules

5 years agostandardise encode_ctx vs encoder_ctx and decode_ctx vs decoder_ctx
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:46:34 +0000 (15:46 +0100)] 
standardise encode_ctx vs encoder_ctx and decode_ctx vs decoder_ctx

5 years agoAvoid allocating a new EVP_CIPHER_CTX for every operation
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:43:42 +0000 (15:43 +0100)] 
Avoid allocating a new EVP_CIPHER_CTX for every operation

5 years agoBetter way to free detached requests
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:41:07 +0000 (15:41 +0100)] 
Better way to free detached requests

5 years agoUse a single code path when stopping requests
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:40:48 +0000 (15:40 +0100)] 
Use a single code path when stopping requests

Instead of a bunch of them, and miss critical cleanup phases

5 years agoDon't crash if we can't find the right public module symbol
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:39:12 +0000 (15:39 +0100)] 
Don't crash if we can't find the right public module symbol

5 years agoTypo in pair.h (pairs were being prepended not appended)
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:38:53 +0000 (15:38 +0100)] 
Typo in pair.h (pairs were being prepended not appended)

5 years agoFix issue in request.c with -M flag
Arran Cudbard-Bell [Mon, 29 Mar 2021 14:38:32 +0000 (15:38 +0100)] 
Fix issue in request.c with -M flag

5 years agoMark up lengths as unsigned
Arran Cudbard-Bell [Mon, 29 Mar 2021 10:23:30 +0000 (11:23 +0100)] 
Mark up lengths as unsigned

5 years agoFree detached requests when they're done
Arran Cudbard-Bell [Mon, 29 Mar 2021 10:22:11 +0000 (11:22 +0100)] 
Free detached requests when they're done

5 years agoBetter error message
Arran Cudbard-Bell [Mon, 29 Mar 2021 10:21:47 +0000 (11:21 +0100)] 
Better error message

5 years agoAdd functions for removing and freeing an item in a dlist
Arran Cudbard-Bell [Mon, 29 Mar 2021 10:21:13 +0000 (11:21 +0100)] 
Add functions for removing and freeing an item in a dlist

5 years agoAdd missing line prefix for L_DBG_INFO
Arran Cudbard-Bell [Mon, 29 Mar 2021 10:19:36 +0000 (11:19 +0100)] 
Add missing line prefix for L_DBG_INFO

5 years agore-enable make dl libraries
Alan T. DeKok [Mon, 29 Mar 2021 13:59:13 +0000 (09:59 -0400)] 
re-enable make dl libraries

5 years agodon't hoist things too far
Alan T. DeKok [Mon, 29 Mar 2021 13:22:21 +0000 (09:22 -0400)] 
don't hoist things too far

do less hoisting during normalization.  Do one last set of
hoisting just before we return.

5 years agocomment out dlopen stuff
Alan T. DeKok [Mon, 29 Mar 2021 12:58:13 +0000 (08:58 -0400)] 
comment out dlopen stuff

until we figure out why builds are failing

5 years agocalculate total depth, and number of conditions
Alan T. DeKok [Mon, 29 Mar 2021 12:36:40 +0000 (08:36 -0400)] 
calculate total depth, and number of conditions

needed to evaluate the conditional tree

5 years agoconditionally load plugins
Alan T. DeKok [Mon, 29 Mar 2021 11:28:45 +0000 (07:28 -0400)] 
conditionally load plugins

until such time as we find out why CI fails with an error about
autoconf.h

5 years agoadd more WARNINGs so that people who read them will be enlightened.
Alan T. DeKok [Sun, 28 Mar 2021 14:35:45 +0000 (10:35 -0400)] 
add more WARNINGs so that people who read them will be enlightened.

Manual port of commit e26b9f8e14f

5 years agoauto-build libfreeradius-make*
Alan T. DeKok [Fri, 26 Mar 2021 13:35:40 +0000 (09:35 -0400)] 
auto-build libfreeradius-make*

so that we can finally use our C functions in the GNU make
build process

5 years agoFormatting
Arran Cudbard-Bell [Thu, 25 Mar 2021 20:44:01 +0000 (20:44 +0000)] 
Formatting

5 years ago"unlikely" requires an argument which is a boolean, not ptr
Alan T. DeKok [Fri, 26 Mar 2021 12:51:28 +0000 (08:51 -0400)] 
"unlikely" requires an argument which is a boolean, not ptr

5 years agoremove redundant declaration
Alan T. DeKok [Fri, 26 Mar 2021 12:21:32 +0000 (08:21 -0400)] 
remove redundant declaration

5 years agoformat args
Alan T. DeKok [Fri, 26 Mar 2021 11:54:34 +0000 (07:54 -0400)] 
format args

5 years agoremove unused variable, and more cleanups
Alan T. DeKok [Fri, 26 Mar 2021 11:38:59 +0000 (07:38 -0400)] 
remove unused variable, and more cleanups

5 years agoEnable sim/aka tests again
Arran Cudbard-Bell [Thu, 25 Mar 2021 19:23:09 +0000 (19:23 +0000)] 
Enable sim/aka tests again

5 years agoremove RLM_MODULE_YIELD
Arran Cudbard-Bell [Thu, 25 Mar 2021 17:59:48 +0000 (17:59 +0000)] 
remove RLM_MODULE_YIELD

5 years agoSwap remaining bad calls to unlang_interpret to unlang_interpret_synchronous
Arran Cudbard-Bell [Thu, 25 Mar 2021 17:52:10 +0000 (17:52 +0000)] 
Swap remaining bad calls to unlang_interpret to unlang_interpret_synchronous

5 years agoIgnore current reply code
Arran Cudbard-Bell [Thu, 25 Mar 2021 17:50:27 +0000 (17:50 +0000)] 
Ignore current reply code

If the submodules don't return the correct EAP codes then that's an issue...

5 years agoFix process authenticate to match the current structure of virtual servers....
Arran Cudbard-Bell [Thu, 25 Mar 2021 17:48:09 +0000 (17:48 +0000)] 
Fix process authenticate to match the current structure of virtual servers....

5 years agoRestore session state in the RADIUS process module
Arran Cudbard-Bell [Thu, 25 Mar 2021 17:39:53 +0000 (17:39 +0000)] 
Restore session state in the RADIUS process module

5 years agoMore consistent logging
Arran Cudbard-Bell [Thu, 25 Mar 2021 17:39:16 +0000 (17:39 +0000)] 
More consistent logging

Don't trash the request->number or name for internal requests

5 years agoAdditional subrequest rework
Arran Cudbard-Bell [Thu, 25 Mar 2021 16:47:26 +0000 (16:47 +0000)] 
Additional subrequest rework

Ensures the subrequest frame in the parent is marked as resumable.

5 years agoRework subrequests to behave more like parallel child requests
Arran Cudbard-Bell [Wed, 24 Mar 2021 22:30:40 +0000 (22:30 +0000)] 
Rework subrequests to behave more like parallel child requests

5 years agoFix multiple issues in module.c
Arran Cudbard-Bell [Wed, 24 Mar 2021 22:26:48 +0000 (22:26 +0000)] 
Fix multiple issues in module.c

- UNLANG_ACTION_PUSHED_CHILD should not print the current rcode
- UNLANG_ACTION_YIELD should not be rewritten to UNLANG_ACTION_PUSHED_CHILD under any circumstances
- The frame state should not change to unlang_module_resume_final (ever)
- unlang_module_resume_final is useless and should be removed.
- When a section is pushed the ua should be UNLANG_ACTION_PUSHED_CHILD not UNLANG_ACTION_YIELD

5 years agoMove common utility inline functions into unlang_priv.h
Arran Cudbard-Bell [Wed, 24 Mar 2021 22:20:19 +0000 (22:20 +0000)] 
Move common utility inline functions into unlang_priv.h

5 years agoRemove hacks for RLM_MODULE_YIELD
Arran Cudbard-Bell [Wed, 24 Mar 2021 22:17:03 +0000 (22:17 +0000)] 
Remove hacks for RLM_MODULE_YIELD

5 years agocleanups and comments for future work
Alan T. DeKok [Wed, 24 Mar 2021 18:19:56 +0000 (14:19 -0400)] 
cleanups and comments for future work

5 years agoremove unused assignment
Alan T. DeKok [Wed, 24 Mar 2021 17:29:42 +0000 (13:29 -0400)] 
remove unused assignment

5 years agomore comments on fields
Alan T. DeKok [Wed, 24 Mar 2021 17:29:00 +0000 (13:29 -0400)] 
more comments on fields

in preparation for separating out the meanings into different
fields.

5 years agoremove unnecessary file
Alan T. DeKok [Wed, 24 Mar 2021 15:26:01 +0000 (11:26 -0400)] 
remove unnecessary file

5 years agoset internal flags based on attribute number
Alan T. DeKok [Wed, 24 Mar 2021 15:02:48 +0000 (11:02 -0400)] 
set internal flags based on attribute number

not on recommended attribute numbers from 15 years ago

5 years agodon't overload names
Alan T. DeKok [Wed, 24 Mar 2021 14:52:32 +0000 (10:52 -0400)] 
don't overload names

in preparation for cleaning up the dict attr flags

5 years agoTypo
Arran Cudbard-Bell [Wed, 24 Mar 2021 11:10:07 +0000 (11:10 +0000)] 
Typo

5 years agodon't run send twice.
Alan T. DeKok [Tue, 23 Mar 2021 20:53:55 +0000 (16:53 -0400)] 
don't run send twice.

If the "recv foo" function pushes an "auth_type" resumption frame
onto the stack, then the "resume_auth_type" function should just
call state->send() directly.

If it calls unlang_module_yield_to_section(cs, state->send),
then the interpreter will run "cs", and then call state->send(),
which will also run "cs".

5 years agoprint module rcode only if it doesn't yield
Alan T. DeKok [Tue, 23 Mar 2021 20:45:44 +0000 (16:45 -0400)] 
print module rcode only if it doesn't yield

5 years agotry to set default reply, even if modules don't do that
Alan T. DeKok [Tue, 23 Mar 2021 19:41:50 +0000 (15:41 -0400)] 
try to set default reply, even if modules don't do that

5 years agomove DHCPv4 to new process state machine
Alan T. DeKok [Tue, 23 Mar 2021 18:47:06 +0000 (14:47 -0400)] 
move DHCPv4 to new process state machine

5 years agono, this seems wrong
Alan T. DeKok [Tue, 23 Mar 2021 18:44:41 +0000 (14:44 -0400)] 
no, this seems wrong

5 years agouse consistent (email), not <email>
Alan T. DeKok [Tue, 23 Mar 2021 16:20:18 +0000 (12:20 -0400)] 
use consistent (email), not <email>

doxygen doesn't like <email>

5 years agoupdate to new state machine
Alan T. DeKok [Tue, 23 Mar 2021 13:54:56 +0000 (09:54 -0400)] 
update to new state machine

and fix a bunch of minor things, so that we have more unique
packet types

5 years agoadd a default reply code
Alan T. DeKok [Tue, 23 Mar 2021 13:06:11 +0000 (09:06 -0400)] 
add a default reply code

so that modules which return HANDLED, but don't set the reply
will get a default reply

5 years agolet's free memory we allocated
Alan T. DeKok [Tue, 23 Mar 2021 12:40:28 +0000 (08:40 -0400)] 
let's free memory we allocated

5 years agoassertions and more debug
Alan T. DeKok [Tue, 23 Mar 2021 12:23:31 +0000 (08:23 -0400)] 
assertions and more debug

5 years agoFudge module names, smushing hyphens to underscores
Arran Cudbard-Bell [Mon, 22 Mar 2021 20:44:54 +0000 (20:44 +0000)] 
Fudge module names, smushing hyphens to underscores

5 years agoDefault code should be noop
Arran Cudbard-Bell [Mon, 22 Mar 2021 20:44:29 +0000 (20:44 +0000)] 
Default code should be noop

5 years agoprint out names if we have them
Alan T. DeKok [Mon, 22 Mar 2021 17:01:27 +0000 (13:01 -0400)] 
print out names if we have them

5 years agoremove duplicate code
Alan T. DeKok [Mon, 22 Mar 2021 16:57:59 +0000 (12:57 -0400)] 
remove duplicate code

any function which calls recv_generic does not need to duplicate
the checks

5 years agomove ARP to the new state machine
Alan T. DeKok [Mon, 22 Mar 2021 16:50:55 +0000 (12:50 -0400)] 
move ARP to the new state machine

5 years agomove VMPS to using new process state machine
Alan T. DeKok [Mon, 22 Mar 2021 16:25:32 +0000 (12:25 -0400)] 
move VMPS to using new process state machine

5 years agowe send a response, not receive it
Alan T. DeKok [Mon, 22 Mar 2021 16:03:57 +0000 (12:03 -0400)] 
we send a response, not receive it