]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 years agouse better / new names
Alan T. DeKok [Mon, 22 Mar 2021 14:32:53 +0000 (10:32 -0400)] 
use better / new names

5 years agoremove "todo" which we have now done
Alan T. DeKok [Mon, 22 Mar 2021 14:32:33 +0000 (10:32 -0400)] 
remove "todo" which we have now done

5 years agoEnsure the request is used
Arran Cudbard-Bell [Mon, 22 Mar 2021 12:57:13 +0000 (12:57 +0000)] 
Ensure the request is used

5 years agominor hacks for control sockets
Alan T. DeKok [Mon, 22 Mar 2021 12:53:52 +0000 (08:53 -0400)] 
minor hacks for control sockets

5 years agoCall the resume function whenever the interpreter is called
Arran Cudbard-Bell [Mon, 22 Mar 2021 12:36:39 +0000 (12:36 +0000)] 
Call the resume function whenever the interpreter is called

5 years agoMore debug
Arran Cudbard-Bell [Mon, 22 Mar 2021 12:36:19 +0000 (12:36 +0000)] 
More debug

5 years agoRemove old asserts and code, add function to check if a request is scheduled
Arran Cudbard-Bell [Mon, 22 Mar 2021 12:14:22 +0000 (12:14 +0000)] 
Remove old asserts and code, add function to check if a request is scheduled

5 years agoClean up debug for empty groups
Arran Cudbard-Bell [Mon, 22 Mar 2021 12:13:50 +0000 (12:13 +0000)] 
Clean up debug for empty groups

The closing bracket here is emitted already

5 years agoDon't need to push empty top_frame stack
Arran Cudbard-Bell [Mon, 22 Mar 2021 12:13:31 +0000 (12:13 +0000)] 
Don't need to push empty top_frame stack

Set default rcode correctly for the instruction we pushed

5 years agoWe still need an event loop assigned to the request
Arran Cudbard-Bell [Mon, 22 Mar 2021 11:42:20 +0000 (11:42 +0000)] 
We still need an event loop assigned to the request

5 years agoActually remove the server_cs field
Arran Cudbard-Bell [Mon, 22 Mar 2021 10:35:44 +0000 (10:35 +0000)] 
Actually remove the server_cs field

5 years agoUse the synchronous interpreter for xlats
Arran Cudbard-Bell [Mon, 22 Mar 2021 10:31:02 +0000 (10:31 +0000)] 
Use the synchronous interpreter for xlats

5 years agoAlloc a dummy async section
Arran Cudbard-Bell [Mon, 22 Mar 2021 10:30:48 +0000 (10:30 +0000)] 
Alloc a dummy async section

5 years agoRemove some references to unlang_interpret
Arran Cudbard-Bell [Sun, 21 Mar 2021 23:11:13 +0000 (23:11 +0000)] 
Remove some references to unlang_interpret

5 years agoTypo in unlang_call_current
Arran Cudbard-Bell [Sun, 21 Mar 2021 22:58:25 +0000 (22:58 +0000)] 
Typo in unlang_call_current

5 years agosynchronous intepreter - Deal with requests which immediately yield
Arran Cudbard-Bell [Sun, 21 Mar 2021 22:58:09 +0000 (22:58 +0000)] 
synchronous intepreter - Deal with requests which immediately yield

5 years agoAllow functions to be top_frames and remove garbage frame in child requests
Arran Cudbard-Bell [Sun, 21 Mar 2021 22:27:51 +0000 (22:27 +0000)] 
Allow functions to be top_frames and remove garbage frame in child requests

5 years agoFix pairs test
Arran Cudbard-Bell [Sun, 21 Mar 2021 22:27:25 +0000 (22:27 +0000)] 
Fix pairs test

5 years agoReturn should not return _through_ the current module
Arran Cudbard-Bell [Sun, 21 Mar 2021 22:08:13 +0000 (22:08 +0000)] 
Return should not return _through_ the current module

5 years agoFix stupid errors in DHCPv6 state tables and restore code
Arran Cudbard-Bell [Sun, 21 Mar 2021 21:57:56 +0000 (21:57 +0000)] 
Fix stupid errors in DHCPv6 state tables and restore code

5 years agoNo modules should call RETURN_MODULE_YIELD
Arran Cudbard-Bell [Sun, 21 Mar 2021 21:57:28 +0000 (21:57 +0000)] 
No modules should call RETURN_MODULE_YIELD

5 years agoResume rcode should be set from *p_result
Arran Cudbard-Bell [Sun, 21 Mar 2021 21:57:15 +0000 (21:57 +0000)] 
Resume rcode should be set from *p_result

5 years agoDon't force rcode to OK
Arran Cudbard-Bell [Sun, 21 Mar 2021 20:36:32 +0000 (20:36 +0000)] 
Don't force rcode to OK

5 years agoCorrect action-return test
Arran Cudbard-Bell [Sun, 21 Mar 2021 20:36:13 +0000 (20:36 +0000)] 
Correct action-return test

5 years agoSent reply code to OK in the success policy
Arran Cudbard-Bell [Sun, 21 Mar 2021 20:32:03 +0000 (20:32 +0000)] 
Sent reply code to OK in the success policy

5 years agoDon't want server-id for solicit
Arran Cudbard-Bell [Sun, 21 Mar 2021 20:29:00 +0000 (20:29 +0000)] 
Don't want server-id for solicit

5 years agoInclude entry for DO_NOT_RESPOND
Arran Cudbard-Bell [Sun, 21 Mar 2021 20:28:47 +0000 (20:28 +0000)] 
Include entry for DO_NOT_RESPOND

5 years agoAllow "Do-Not-Respond"
Arran Cudbard-Bell [Sun, 21 Mar 2021 20:27:57 +0000 (20:27 +0000)] 
Allow "Do-Not-Respond"

5 years agoAdd fr_pair_find_by_ancestor
Arran Cudbard-Bell [Sun, 21 Mar 2021 20:27:29 +0000 (20:27 +0000)] 
Add fr_pair_find_by_ancestor

5 years agoQualify reference
Arran Cudbard-Bell [Sun, 21 Mar 2021 20:25:46 +0000 (20:25 +0000)] 
Qualify reference

5 years agofill in the correct attributes for Protocol-Error
Alan T. DeKok [Sun, 21 Mar 2021 19:51:01 +0000 (15:51 -0400)] 
fill in the correct attributes for Protocol-Error

5 years agoadd support for Protocol-Error
Alan T. DeKok [Sun, 21 Mar 2021 18:54:42 +0000 (14:54 -0400)] 
add support for Protocol-Error

5 years agouse name from header file
Alan T. DeKok [Sun, 21 Mar 2021 18:49:50 +0000 (14:49 -0400)] 
use name from header file

5 years agoremove unnecessary "reject" field
Alan T. DeKok [Sun, 21 Mar 2021 18:42:19 +0000 (14:42 -0400)] 
remove unnecessary "reject" field

5 years agoStart of new DHCPv6 process module
Arran Cudbard-Bell [Sun, 21 Mar 2021 18:03:04 +0000 (18:03 +0000)] 
Start of new DHCPv6 process module

5 years agoupdate configuration to match new process module
Alan T. DeKok [Sun, 21 Mar 2021 14:00:04 +0000 (10:00 -0400)] 
update configuration to match new process module

5 years agofailure to load a process module is an error
Alan T. DeKok [Sun, 21 Mar 2021 13:58:49 +0000 (09:58 -0400)] 
failure to load a process module is an error

so we'll need one for the "control" virtual server.

Also don't push the config rules manually, dl_module_instance()
has already done that for us.

5 years agoNot used
Arran Cudbard-Bell [Sat, 20 Mar 2021 20:05:45 +0000 (20:05 +0000)] 
Not used

5 years agoremove request->server_cs
Arran Cudbard-Bell [Sat, 20 Mar 2021 20:00:20 +0000 (20:00 +0000)] 
remove request->server_cs

Dynamically calculating the value removes lots of annoying boilerplate, and means it's always accurate

5 years agoTypo
Arran Cudbard-Bell [Sat, 20 Mar 2021 19:59:31 +0000 (19:59 +0000)] 
Typo

5 years agoUse internal times for the state tree
Arran Cudbard-Bell [Sat, 20 Mar 2021 18:20:39 +0000 (18:20 +0000)] 
Use internal times for the state tree

Don't has the current server cs, use a unique id provided by the process module.

5 years agoRemove the majority of call keyword logic
Arran Cudbard-Bell [Sat, 20 Mar 2021 17:46:09 +0000 (17:46 +0000)] 
Remove the majority of call keyword logic

Have everything else use virtual_server_push to push virtual servers onto the stack

5 years agoFix Auth-Type Accept/Reject
Arran Cudbard-Bell [Sat, 20 Mar 2021 17:45:23 +0000 (17:45 +0000)] 
Fix Auth-Type Accept/Reject

5 years agoprocess_radius - Use server_cs pointer from bootstrap instead of the request
Arran Cudbard-Bell [Sat, 20 Mar 2021 17:44:35 +0000 (17:44 +0000)] 
process_radius - Use server_cs pointer from bootstrap instead of the request

5 years agomove code to common function and macros
Alan T. DeKok [Sat, 20 Mar 2021 16:12:03 +0000 (12:12 -0400)] 
move code to common function and macros

This makes most of the "process protocol" state machines to be
little more than "define data structures, and call generic functions"

5 years agolet's make this more generic
Alan T. DeKok [Sat, 20 Mar 2021 14:35:22 +0000 (10:35 -0400)] 
let's make this more generic

5 years agotypo
Alan T. DeKok [Sat, 20 Mar 2021 13:08:26 +0000 (09:08 -0400)] 
typo

5 years agoNotfound should be a reject
Arran Cudbard-Bell [Fri, 19 Mar 2021 23:29:09 +0000 (23:29 +0000)] 
Notfound should be a reject

5 years agoFixup RADIUS enums/macros and radius_process type names
Arran Cudbard-Bell [Sun, 21 Mar 2021 15:57:38 +0000 (15:57 +0000)] 
Fixup RADIUS enums/macros and radius_process type names

5 years agoFix bad logic, and don't free the subrequests
Arran Cudbard-Bell [Fri, 19 Mar 2021 21:00:45 +0000 (21:00 +0000)] 
Fix bad logic, and don't free the subrequests

5 years agohacky hack
Arran Cudbard-Bell [Fri, 19 Mar 2021 21:00:21 +0000 (21:00 +0000)] 
hacky hack

5 years agoremove unused functions
Alan T. DeKok [Fri, 19 Mar 2021 20:58:46 +0000 (16:58 -0400)] 
remove unused functions

5 years agoPacket-Type is always a uint32_t...
Alan T. DeKok [Fri, 19 Mar 2021 20:51:13 +0000 (16:51 -0400)] 
Packet-Type is always a uint32_t...

this doesn't make a lot of difference, but on some systems aligned
access is better.

5 years agoTypo
Arran Cudbard-Bell [Fri, 19 Mar 2021 20:44:20 +0000 (20:44 +0000)] 
Typo

5 years agoOnly say we're entering a section when we have a section to enter
Arran Cudbard-Bell [Fri, 19 Mar 2021 20:41:13 +0000 (20:41 +0000)] 
Only say we're entering a section when we have a section to enter

5 years agoCompile authenticate sections
Arran Cudbard-Bell [Fri, 19 Mar 2021 20:35:54 +0000 (20:35 +0000)] 
Compile authenticate sections

5 years agoSet the reply rcode _THEN_ update the state pointer
Arran Cudbard-Bell [Fri, 19 Mar 2021 20:32:13 +0000 (20:32 +0000)] 
Set the reply rcode _THEN_ update the state pointer

5 years agosearch for auth_Type in the correct list
Arran Cudbard-Bell [Fri, 19 Mar 2021 20:31:56 +0000 (20:31 +0000)] 
search for auth_Type in the correct list

5 years agoTypo
Arran Cudbard-Bell [Fri, 19 Mar 2021 20:31:45 +0000 (20:31 +0000)] 
Typo

5 years agoReturn an error code when we can't find an unlang_group_t associated with a CS
Arran Cudbard-Bell [Fri, 19 Mar 2021 20:30:20 +0000 (20:30 +0000)] 
Return an error code when we can't find an unlang_group_t associated with a CS

5 years agoIntegrate packet type array into radius_state
Arran Cudbard-Bell [Fri, 19 Mar 2021 20:16:35 +0000 (20:16 +0000)] 
Integrate packet type array into radius_state

5 years agoExecute process modules using the unlang stack
Arran Cudbard-Bell [Wed, 31 Mar 2021 15:06:23 +0000 (16:06 +0100)] 
Execute process modules using the unlang stack

5 years agoAdd trace macro
Arran Cudbard-Bell [Fri, 19 Mar 2021 19:55:30 +0000 (19:55 +0000)] 
Add trace macro

5 years agoAdd macro for checking packet code validity
Arran Cudbard-Bell [Fri, 19 Mar 2021 19:54:01 +0000 (19:54 +0000)] 
Add macro for checking packet code validity

5 years agoarg alignment
Arran Cudbard-Bell [Fri, 19 Mar 2021 19:52:14 +0000 (19:52 +0000)] 
arg alignment

5 years agoquiet warnings
Arran Cudbard-Bell [Fri, 19 Mar 2021 15:16:56 +0000 (15:16 +0000)] 
quiet warnings

5 years agoPush the process function directly
Arran Cudbard-Bell [Fri, 19 Mar 2021 15:16:47 +0000 (15:16 +0000)] 
Push the process function directly

5 years agoremove entry_point_set()
Alan T. DeKok [Fri, 19 Mar 2021 13:33:54 +0000 (09:33 -0400)] 
remove entry_point_set()

and instead just call the virtual server function

5 years agoshut up compiler
Alan T. DeKok [Fri, 19 Mar 2021 13:12:56 +0000 (09:12 -0400)] 
shut up compiler

5 years agocall new the process functions
Alan T. DeKok [Fri, 19 Mar 2021 13:12:44 +0000 (09:12 -0400)] 
call new the process functions

5 years agolook at unlang action, instead of rcode
Alan T. DeKok [Fri, 19 Mar 2021 12:53:13 +0000 (08:53 -0400)] 
look at unlang action, instead of rcode

5 years agoadd temp unlang_virtual_server_push()
Alan T. DeKok [Fri, 19 Mar 2021 12:46:39 +0000 (08:46 -0400)] 
add temp unlang_virtual_server_push()

5 years agoremove unused variable
Alan T. DeKok [Fri, 19 Mar 2021 12:38:56 +0000 (08:38 -0400)] 
remove unused variable

5 years agocreate fake module instance for process functions
Alan T. DeKok [Fri, 19 Mar 2021 12:37:34 +0000 (08:37 -0400)] 
create fake module instance for process functions

and start off real modules at number 1, so that the fake module
instances don't interact with real ones

5 years agostart modules at 1, not 0
Alan T. DeKok [Fri, 19 Mar 2021 12:37:14 +0000 (08:37 -0400)] 
start modules at 1, not 0

so that when we create fake modules for virtual s

5 years agofirst stab at radius processor
Alan T. DeKok [Thu, 18 Mar 2021 21:02:43 +0000 (17:02 -0400)] 
first stab at radius processor

5 years agoUse the standard string escaping functions when printing keys
Arran Cudbard-Bell [Tue, 30 Mar 2021 17:16:10 +0000 (18:16 +0100)] 
Use the standard string escaping functions when printing keys

5 years agoFix erroneous \0 byte being added to pool and range IDs
Arran Cudbard-Bell [Tue, 30 Mar 2021 17:15:47 +0000 (18:15 +0100)] 
Fix erroneous \0 byte being added to pool and range IDs

5 years agoIf we don't start with 1 connection the pool isn't mapped and certain commands fail
Arran Cudbard-Bell [Tue, 30 Mar 2021 17:15:22 +0000 (18:15 +0100)] 
If we don't start with 1 connection the pool isn't mapped and certain commands fail

5 years agoInclude exuberant ctags configuration file
Arran Cudbard-Bell [Sat, 27 Mar 2021 13:31:13 +0000 (13:31 +0000)] 
Include exuberant ctags configuration file

5 years agoParent the arg buffers correctly
Arran Cudbard-Bell [Tue, 30 Mar 2021 16:18:15 +0000 (17:18 +0100)] 
Parent the arg buffers correctly

5 years agoCheck for request
Arran Cudbard-Bell [Tue, 30 Mar 2021 11:45:37 +0000 (12:45 +0100)] 
Check for request

5 years agov4: Convert %{expr: } to new xlat api (#4042)
Nick Porter [Tue, 30 Mar 2021 11:29:05 +0000 (12:29 +0100)] 
v4: Convert %{expr: } to new xlat api (#4042)

* Convert %{expr: } to new xlat api

* Remove incorrect "UNUSED"

5 years agoctx is actually used
Arran Cudbard-Bell [Tue, 30 Mar 2021 11:27:59 +0000 (12:27 +0100)] 
ctx is actually used

5 years agoAvoid allocating dummy requests in rlm_redis_ippool_tool
Arran Cudbard-Bell [Tue, 30 Mar 2021 11:25:09 +0000 (12:25 +0100)] 
Avoid allocating dummy requests in rlm_redis_ippool_tool

That now requires the dictionaries, and we really don't want to add that dependency...

5 years agoFix trigger args assert
Arran Cudbard-Bell [Tue, 30 Mar 2021 10:50:36 +0000 (11:50 +0100)] 
Fix trigger args assert

5 years agoComment fix (#4040)
Nick Porter [Mon, 29 Mar 2021 18:50:17 +0000 (19:50 +0100)] 
Comment fix (#4040)

5 years agov4: Convert dict xlats to new api (#4039)
Nick Porter [Mon, 29 Mar 2021 14:27:36 +0000 (15:27 +0100)] 
v4: Convert dict xlats to new api (#4039)

* Convert %(attr_by_num: ) to new xlat api

* Convert %(attr_by_oid: ) to new xlat api

* Convert %(vendor: ) to new xlat api

* Convert %(vendor_num: ) to new xlat api

* Convert %(attr: ) to new xlat api

* Convert %(attr_num: ) to new xlat api

5 years agov4: Convert %(client: ) to new xlat api (#4038)
Nick Porter [Mon, 29 Mar 2021 14:26:48 +0000 (15:26 +0100)] 
v4: Convert %(client: ) to new xlat api (#4038)

* Convert %(client: ) to new xlat api

* Update documentation for %(client: ) xlat

* Update existing uses of %(client: ) xlat in raddb

* Update existing reference to %(client: ) in tests

* Add specific test for %(client: ) xlat

* Tidy client map test

* Fix docs

They were very wrong...

* Fix examples in config file too

Co-authored-by: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
5 years agov4: Define arguments for %(length: ) xlat (#4037)
Nick Porter [Mon, 29 Mar 2021 14:22:01 +0000 (15:22 +0100)] 
v4: Define arguments for %(length: ) xlat (#4037)

* Define arguments for %(length: ) xlat

* Update tests that use %(length: ) xlat

* Update docs for %(length: ) xlat

* Make xlat_fmt_aprint() reflect original call syntax

* Make xlat_print reflect original call syntax

5 years agov4: Convert %(interpreter: ) to new xlat api (#4036)
Nick Porter [Mon, 29 Mar 2021 14:19:25 +0000 (15:19 +0100)] 
v4: Convert %(interpreter: ) to new xlat api (#4036)

* Convert %(interpreter: ) to new xlat api

* Update existing tests to use new %(interpreter: ) syntax

* Update documentation for %(interpreter: ) xlat

* Add test for %(interpreter: ) xlat

* Typo

Co-authored-by: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
5 years agov4: convert %(config :) to new xlat api (#4033)
Nick Porter [Mon, 29 Mar 2021 09:18:04 +0000 (10:18 +0100)] 
v4: convert %(config :) to new xlat api (#4033)

* Convert %{config: } to new xlat api

* Update documentation for new %(config: ) xlat syntax

* Remove former config xlat escape function

* Add test for %(config: ) xlat

5 years agoAmend xlat register in unit_test_attribute to new api (#4032)
Nick Porter [Fri, 26 Mar 2021 17:51:59 +0000 (17:51 +0000)] 
Amend xlat register in unit_test_attribute to new api (#4032)

5 years agov4: Convert eap-aka-sim xlats to new api (#4030)
Nick Porter [Thu, 25 Mar 2021 19:32:27 +0000 (19:32 +0000)] 
v4: Convert eap-aka-sim xlats to new api (#4030)

* Convert %{aka_sim_id_method: } to new xlat api

* Update docs for new %(aka_sim_id_method: ) syntax

* Update tests for new %(aka_sim_id_method: ) syntax

* Convert %{aka_sim_id_type: } to new xlat api

* Update docs for new %(aka_sim_id_type: ) syntax

* Update tests for new %(aka_sim_id_type: ) syntax

* Convert %{3gpp_pseudonym_key_index: } xlat to new api

* Update docs for new %(3gpp_pseudonym_key_index: ) syntax

* Convert %(3gpp_pseudonym_decrypt: ) to new xlat api

* Amend documentation for new syntax of %(3gpp_pseudonym_decrypt: ) xlat

* Auto load eap_aka_sim enums for xlats

* Convert %(3gpp_pseudonym_encrypt: ) to new xlat api

* Update documentation to new %(3gpp_pseudonym_encrypt: ) syntax

* Update tests to use new %(3gpp_pseudonym_encrypt: ) syntax

* Move eap_aka_sim tests to eap_sim to match module name so they run.

* Tidy eap_sim test files

5 years agoRefresh test certificates
Arran Cudbard-Bell [Thu, 25 Mar 2021 19:18:43 +0000 (19:18 +0000)] 
Refresh test certificates

5 years agov4: Define arguments for json xlats (#4027)
Nick Porter [Thu, 25 Mar 2021 10:14:55 +0000 (10:14 +0000)] 
v4: Define arguments for json xlats (#4027)

* Define args for json xlats

* Update json tests to match new generic failure message

* Missing arguments will mean no child

* Simplify json encode tests

* Remove input argument errors from json encode test and create error test

* Correct ERROR handling for module tests

* Simplify unlang in json eval tests

* Simplify unlang in json parser tests

* Simplify unlang in json quote tests

* Enable 64bit json eval tests

5 years agov4: Define arguments for redis xlats already using new api (#4028)
Nick Porter [Thu, 25 Mar 2021 10:10:11 +0000 (10:10 +0000)] 
v4: Define arguments for redis xlats already using new api (#4028)

* Define args for %(redis_node: ) xlat

* Define arguments for %(redis_remap: ) xlat

* Minor formatting

Co-authored-by: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
5 years agoICMP xlat should be defined arguments, not a stream (#4026)
Nick Porter [Thu, 25 Mar 2021 10:07:16 +0000 (10:07 +0000)] 
ICMP xlat should be defined arguments, not a stream (#4026)

5 years agoFix issue with delete command that caused entries to remain if the address had never...
Arran Cudbard-Bell [Wed, 24 Mar 2021 19:39:48 +0000 (19:39 +0000)] 
Fix issue with delete command that caused entries to remain if the address had never been used

5 years agoLinter: Perl fixes (#4019)
Terry Burton [Wed, 24 Mar 2021 13:58:20 +0000 (13:58 +0000)] 
Linter: Perl fixes (#4019)