]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 years agofr_cursor_eval_t should take "const"
Alan T. DeKok [Fri, 6 Nov 2020 14:38:12 +0000 (09:38 -0500)] 
fr_cursor_eval_t should take "const"

evaluation functions should be idempotent

5 years agoprint out packet before encrypting
Alan T. DeKok [Fri, 6 Nov 2020 12:52:11 +0000 (07:52 -0500)] 
print out packet before encrypting

5 years ago:gear: tacacs: Fix typo (#3723)
Jorge Pereira [Fri, 6 Nov 2020 12:51:20 +0000 (09:51 -0300)] 
:gear: tacacs: Fix typo (#3723)

* :gear: tacacs: Better formatting

* :gear: tacacs: Fix typo

5 years agoDon't double advance buffer
Arran Cudbard-Bell [Fri, 6 Nov 2020 04:19:42 +0000 (22:19 -0600)] 
Don't double advance buffer

5 years agoIt's not an error if we don't have any WITH_ macros
Arran Cudbard-Bell [Fri, 6 Nov 2020 02:44:38 +0000 (20:44 -0600)] 
It's not an error if we don't have any WITH_ macros

5 years agoAlways build with udpfromto
Arran Cudbard-Bell [Fri, 6 Nov 2020 02:32:10 +0000 (20:32 -0600)] 
Always build with udpfromto

5 years agoMore reorganising
Arran Cudbard-Bell [Fri, 6 Nov 2020 02:20:03 +0000 (20:20 -0600)] 
More reorganising

5 years agoReorg argument order
Arran Cudbard-Bell [Fri, 6 Nov 2020 02:15:17 +0000 (20:15 -0600)] 
Reorg argument order

5 years agoOnly use src_ipaddr if it's not a wildcard address
Arran Cudbard-Bell [Fri, 6 Nov 2020 01:54:03 +0000 (19:54 -0600)] 
Only use src_ipaddr if it's not a wildcard address

5 years agoRemove more ippool-dhcp references
Arran Cudbard-Bell [Fri, 6 Nov 2020 01:35:30 +0000 (19:35 -0600)] 
Remove more ippool-dhcp references

5 years agoFormatting
Arran Cudbard-Bell [Fri, 6 Nov 2020 01:31:39 +0000 (19:31 -0600)] 
Formatting

5 years agoTypo
Arran Cudbard-Bell [Fri, 6 Nov 2020 01:30:06 +0000 (19:30 -0600)] 
Typo

5 years agoSet the protocol for sockets
Arran Cudbard-Bell [Fri, 6 Nov 2020 01:27:32 +0000 (19:27 -0600)] 
Set the protocol for sockets

5 years agoFormatting
Arran Cudbard-Bell [Fri, 6 Nov 2020 01:04:31 +0000 (19:04 -0600)] 
Formatting

5 years agoNot used
Arran Cudbard-Bell [Fri, 6 Nov 2020 01:00:17 +0000 (19:00 -0600)] 
Not used

5 years agoRemove useless wrapper
Arran Cudbard-Bell [Fri, 6 Nov 2020 00:54:04 +0000 (18:54 -0600)] 
Remove useless wrapper

5 years agoReorganise
Arran Cudbard-Bell [Fri, 6 Nov 2020 00:41:21 +0000 (18:41 -0600)] 
Reorganise

5 years agoFix typo
Arran Cudbard-Bell [Fri, 6 Nov 2020 00:38:53 +0000 (18:38 -0600)] 
Fix typo

5 years agotacacs: Fix uninitialized memory issue (#3722)
Jorge Pereira [Thu, 5 Nov 2020 23:49:03 +0000 (20:49 -0300)] 
tacacs: Fix uninitialized memory issue (#3722)

* :gear: tacacs: Remove unecessary UNUSED attribute

* :gear: tacacs: Typo

* :gear: tacacs: Fix uninitialized memory issue

The issue appeared only agains gcc >= 7

* :gear: tacacs: Add missing dbuff calls

It is helpful to clears any markers handled by dbuff.

5 years agoTypo
Arran Cudbard-Bell [Thu, 5 Nov 2020 20:45:57 +0000 (14:45 -0600)] 
Typo

5 years agoRemove dhcp_sqlippool, qualify attribute references in sqlippool
Arran Cudbard-Bell [Thu, 5 Nov 2020 20:37:22 +0000 (14:37 -0600)] 
Remove dhcp_sqlippool, qualify attribute references in sqlippool

5 years agoTreat requested_address as an expansion string, not an attribute
Arran Cudbard-Bell [Thu, 5 Nov 2020 20:31:16 +0000 (14:31 -0600)] 
Treat requested_address as an expansion string, not an attribute

5 years agoBetter name for attribute_name
Arran Cudbard-Bell [Thu, 5 Nov 2020 20:19:59 +0000 (14:19 -0600)] 
Better name for attribute_name

5 years agoMerge ippool and dhcp-ippool configurations
Arran Cudbard-Bell [Thu, 5 Nov 2020 19:33:37 +0000 (13:33 -0600)] 
Merge ippool and dhcp-ippool configurations

5 years agoAdd back bulk_release_clear
Arran Cudbard-Bell [Thu, 5 Nov 2020 19:33:01 +0000 (13:33 -0600)] 
Add back bulk_release_clear

and remove DHCPv4 specific text

5 years agoPull the requested address and gateway from the sqlippool configuration file
Arran Cudbard-Bell [Thu, 5 Nov 2020 18:44:40 +0000 (12:44 -0600)] 
Pull the requested address and gateway from the sqlippool configuration file

5 years agoAddress should be 43 bytes to allow for IPv6 prefixes
Arran Cudbard-Bell [Thu, 5 Nov 2020 18:06:47 +0000 (12:06 -0600)] 
Address should be 43 bytes to allow for IPv6 prefixes

5 years agofix doxyen @file
Alan T. DeKok [Thu, 5 Nov 2020 17:08:23 +0000 (12:08 -0500)] 
fix doxyen @file

5 years agomove decode_proto API and callers to use fr_pair_list_t
Alan T. DeKok [Thu, 5 Nov 2020 16:41:38 +0000 (11:41 -0500)] 
move decode_proto API and callers to use fr_pair_list_t

5 years agodefine fr_pair_list_init() and use in internal decoder
Alan T. DeKok [Thu, 5 Nov 2020 16:35:10 +0000 (11:35 -0500)] 
define fr_pair_list_init() and use in internal decoder

5 years agoupdate and clarify
Alan T. DeKok [Thu, 5 Nov 2020 15:05:31 +0000 (10:05 -0500)] 
update and clarify

5 years agoregenerate from config
Alan T. DeKok [Thu, 5 Nov 2020 14:57:44 +0000 (09:57 -0500)] 
regenerate from config

5 years agos/fr_pair_t**/fr_pair_list_t*/
Alan T. DeKok [Wed, 4 Nov 2020 20:07:08 +0000 (15:07 -0500)] 
s/fr_pair_t**/fr_pair_list_t*/

5 years agos/fr_pair_t**/fr_pair_list_t*/
Alan T. DeKok [Wed, 4 Nov 2020 20:04:27 +0000 (15:04 -0500)] 
s/fr_pair_t**/fr_pair_list_t*/

and the compiler is smart enough to not care too much about
passing "fr_pair_t**" to a function which now takes
"fr_pair_list_t*"

5 years agoremove old uses of fr_pair_list_t
Alan T. DeKok [Tue, 3 Nov 2020 18:19:37 +0000 (13:19 -0500)] 
remove old uses of fr_pair_list_t

5 years agoremove more fr_pair_list_t, and replace with fr_pair_t**
Alan T. DeKok [Tue, 3 Nov 2020 18:18:03 +0000 (13:18 -0500)] 
remove more fr_pair_list_t, and replace with fr_pair_t**

5 years agomake internal encoder use fr_pair_t** instead of fr_pair_list_t*
Alan T. DeKok [Tue, 3 Nov 2020 17:52:01 +0000 (12:52 -0500)] 
make internal encoder use fr_pair_t** instead of fr_pair_list_t*

until such time as we redefine fr_pair_list_t*

5 years agoremove unused functions
Alan T. DeKok [Tue, 3 Nov 2020 17:39:41 +0000 (12:39 -0500)] 
remove unused functions

5 years agolook at vp->vp_group, not vp->children.slist
Alan T. DeKok [Tue, 3 Nov 2020 17:22:18 +0000 (12:22 -0500)] 
look at vp->vp_group, not vp->children.slist

because that's the correct name

5 years agoOwner and gateway should be 128 in sqlite too
Arran Cudbard-Bell [Thu, 5 Nov 2020 14:34:53 +0000 (08:34 -0600)] 
Owner and gateway should be 128 in sqlite too

5 years agoTypo
Arran Cudbard-Bell [Thu, 5 Nov 2020 14:34:39 +0000 (08:34 -0600)] 
Typo

5 years agoFix random gateway and owner lengths
Arran Cudbard-Bell [Thu, 5 Nov 2020 14:21:38 +0000 (08:21 -0600)] 
Fix random gateway and owner lengths

15, 30 and 64 are too small.

5 years agosync redis ipool terms with sql ippool
Arran Cudbard-Bell [Wed, 4 Nov 2020 22:55:51 +0000 (16:55 -0600)] 
sync redis ipool terms with sql ippool

5 years agos/pool_key/owner/g
Arran Cudbard-Bell [Wed, 4 Nov 2020 22:39:58 +0000 (16:39 -0600)] 
s/pool_key/owner/g

Use a more generic term for the owner of the lease

5 years agoCorrect the table named in the MySQL stored procedures
Arran Cudbard-Bell [Wed, 4 Nov 2020 22:12:52 +0000 (16:12 -0600)] 
Correct the table named in the MySQL stored procedures

I guess this was never tested

5 years agoPrefix index names in the mssql schema
Arran Cudbard-Bell [Wed, 4 Nov 2020 22:12:29 +0000 (16:12 -0600)] 
Prefix index names in the mssql schema

5 years agos/dhcpstatus/fr_ippool_status/g
Arran Cudbard-Bell [Wed, 4 Nov 2020 22:08:51 +0000 (16:08 -0600)] 
s/dhcpstatus/fr_ippool_status/g

Use the same table prefix for ippool statuses

5 years agos/fr_dhcp_/fr_ippool_/g
Arran Cudbard-Bell [Wed, 4 Nov 2020 22:07:33 +0000 (16:07 -0600)] 
s/fr_dhcp_/fr_ippool_/g

Store procedure prefixes should be the same as the table prefixes

5 years agoFormatting
Arran Cudbard-Bell [Wed, 4 Nov 2020 22:06:14 +0000 (16:06 -0600)] 
Formatting

5 years agos/dhcpippool/fr_ippool/g
Arran Cudbard-Bell [Wed, 4 Nov 2020 22:04:31 +0000 (16:04 -0600)] 
s/dhcpippool/fr_ippool/g

dhcpippool isn't correctly namespaced and doesn't provide a hint as to what's using it.  If were going something generic it's not good to use a protocol name either.

5 years agos/FramedIpAddress/address/g
Arran Cudbard-Bell [Wed, 4 Nov 2020 22:02:53 +0000 (16:02 -0600)] 
s/FramedIpAddress/address/g

FramedIpAddress is a RADIUS specific term.  There's no need to use it for a Generic IP pool allocation module.

5 years agoMore pair list fixes
Arran Cudbard-Bell [Tue, 3 Nov 2020 22:56:50 +0000 (16:56 -0600)] 
More pair list fixes

5 years agoFormatting
Arran Cudbard-Bell [Tue, 3 Nov 2020 22:31:52 +0000 (16:31 -0600)] 
Formatting

5 years agoMove challenge lookup to outside encode function
Arran Cudbard-Bell [Tue, 3 Nov 2020 22:31:44 +0000 (16:31 -0600)] 
Move challenge lookup to outside encode function

5 years agoMore pair list fixups
Arran Cudbard-Bell [Tue, 3 Nov 2020 22:30:35 +0000 (16:30 -0600)] 
More pair list fixups

5 years agos/RADIUS_PACKET/fr_radius_packet_t/
Arran Cudbard-Bell [Tue, 3 Nov 2020 22:03:38 +0000 (16:03 -0600)] 
s/RADIUS_PACKET/fr_radius_packet_t/

5 years agoMore macro conversions
Arran Cudbard-Bell [Tue, 3 Nov 2020 22:01:58 +0000 (16:01 -0600)] 
More macro conversions

5 years agoUnused
Arran Cudbard-Bell [Tue, 3 Nov 2020 21:54:15 +0000 (15:54 -0600)] 
Unused

5 years agoFix some magic numbers in DHCPv6
Arran Cudbard-Bell [Tue, 3 Nov 2020 21:33:00 +0000 (15:33 -0600)] 
Fix some magic numbers in DHCPv6

5 years agoRemove dbuff encode wrappers
Arran Cudbard-Bell [Tue, 3 Nov 2020 20:16:40 +0000 (14:16 -0600)] 
Remove dbuff encode wrappers

5 years agoNot an rcode, an slen...
Arran Cudbard-Bell [Tue, 3 Nov 2020 19:52:39 +0000 (13:52 -0600)] 
Not an rcode, an slen...

5 years agoFix talloc steal
Arran Cudbard-Bell [Tue, 3 Nov 2020 19:44:37 +0000 (13:44 -0600)] 
Fix talloc steal

5 years agoDon't run IMAP or SMTP unless we've explicitly setup the test server
Arran Cudbard-Bell [Tue, 3 Nov 2020 19:15:57 +0000 (13:15 -0600)] 
Don't run IMAP or SMTP unless we've explicitly setup the test server

5 years agoMake rlm_icmp work under docker.
Arran Cudbard-Bell [Tue, 3 Nov 2020 19:12:00 +0000 (13:12 -0600)] 
Make rlm_icmp work under docker.

5 years agoPrint arguments when we're trying to open icmp sockets
Arran Cudbard-Bell [Tue, 3 Nov 2020 18:38:00 +0000 (12:38 -0600)] 
Print arguments when we're trying to open icmp sockets

5 years agoShould use euid not uid as changing from root removes root's caps
Arran Cudbard-Bell [Tue, 3 Nov 2020 18:30:12 +0000 (12:30 -0600)] 
Should use euid not uid as changing from root removes root's caps

5 years agogcc defines things that clash in unexpected ways
Matthew Newton [Tue, 3 Nov 2020 16:11:04 +0000 (16:11 +0000)] 
gcc defines things that clash in unexpected ways

5 years agorearrange checks in the proper order
Alan T. DeKok [Tue, 3 Nov 2020 15:37:28 +0000 (10:37 -0500)] 
rearrange checks in the proper order

so that the correct message is produced

5 years agoRevert "v4: Add a "substring" xlat keyword (#3684)"
Arran Cudbard-Bell [Tue, 3 Nov 2020 15:08:19 +0000 (09:08 -0600)] 
Revert "v4: Add a "substring" xlat keyword (#3684)"

Uses legacy API, and disagree with syntax

5 years agoTighter scope for reply_ok, reply_fail
Arran Cudbard-Bell [Tue, 3 Nov 2020 15:06:36 +0000 (09:06 -0600)] 
Tighter scope for reply_ok, reply_fail

5 years agoFormatting
Arran Cudbard-Bell [Mon, 2 Nov 2020 01:50:42 +0000 (19:50 -0600)] 
Formatting

5 years agohard-code Relay-Reply to avoid admin stupidities
Alan T. DeKok [Tue, 3 Nov 2020 14:57:56 +0000 (09:57 -0500)] 
hard-code Relay-Reply to avoid admin stupidities

the reply to a Relay-Request is _always_ a Relay-Reply.

See RFC 8415

5 years agoupdate for new name
Alan T. DeKok [Tue, 3 Nov 2020 13:27:44 +0000 (08:27 -0500)] 
update for new name

5 years agowe use brackets
Alan T. DeKok [Tue, 3 Nov 2020 13:19:04 +0000 (08:19 -0500)] 
we use brackets

5 years agov4: Add a "substring" xlat keyword (#3684)
Nick Porter [Tue, 3 Nov 2020 13:18:50 +0000 (13:18 +0000)] 
v4: Add a "substring" xlat keyword (#3684)

* Add a "substring" xlat function to rlm_unpack

Return a substring of the string representation of a string or attribute
using the syntax:
"%{substring:<string:attribute> <start> <len>}"

Negative `start` or `len` values count from the end of the string

* Tests for substring xlat

* Correct return of zero length string

5 years agoConvert DHCPv6 encode_value() to use dbuffs
James Jones [Fri, 28 Aug 2020 16:40:03 +0000 (11:40 -0500)] 
Convert DHCPv6 encode_value() to use dbuffs

5 years agoDocs: Fix SQL Howto markup and tidy
Terry Burton [Tue, 27 Oct 2020 13:00:12 +0000 (13:00 +0000)] 
Docs: Fix SQL Howto markup and tidy

5 years agoMake fr_radius_encode() a layer around fr_radius_encode_dbuff()
James Jones [Sat, 24 Oct 2020 01:04:16 +0000 (20:04 -0500)] 
Make fr_radius_encode() a layer around fr_radius_encode_dbuff()

5 years agoMake fr_dhcpv4_encode() a wrapper around a dbuff version
James Jones [Wed, 21 Oct 2020 16:08:08 +0000 (11:08 -0500)] 
Make fr_dhcpv4_encode() a wrapper around a dbuff version

Both functions are visible; the dbuff version calls the
now-exposed fr_dbuff_dhcpv4_encode_option_dbuff() and
takes advantage of dbuff functionality.

5 years agoAdd fr_dhcpv6_encode_dbuff()
James Jones [Tue, 20 Oct 2020 14:45:00 +0000 (09:45 -0500)] 
Add fr_dhcpv6_encode_dbuff()

5 years ago:gear: arp: Update fr_arp_encode() to use dbuff
Jorge Pereira [Thu, 29 Oct 2020 22:44:31 +0000 (19:44 -0300)] 
:gear: arp: Update fr_arp_encode() to use dbuff

5 years ago:gear: vmps: Update fr_vmps_encode() to use dbuffs.
Jorge Pereira [Thu, 29 Oct 2020 21:53:11 +0000 (18:53 -0300)] 
:gear: vmps: Update fr_vmps_encode() to use dbuffs.

5 years ago:gear: tacacs: Update TACACS+ fr_tacacs_encode() to use dbuffs
Jorge Pereira [Wed, 28 Oct 2020 23:52:09 +0000 (20:52 -0300)] 
:gear: tacacs: Update TACACS+ fr_tacacs_encode() to use dbuffs

5 years agodon't rely on accidental behavior for checks
Alan T. DeKok [Mon, 2 Nov 2020 15:58:37 +0000 (10:58 -0500)] 
don't rely on accidental behavior for checks

have an explicit flag, instead of relying on "vp" being left over
as a pointer to something

5 years agouse merge to merge lists of cursors
Alan T. DeKok [Mon, 2 Nov 2020 14:10:17 +0000 (09:10 -0500)] 
use merge to merge lists of cursors

5 years agoinitialize the reply, for nested relay packets
Alan T. DeKok [Mon, 2 Nov 2020 13:37:58 +0000 (08:37 -0500)] 
initialize the reply, for nested relay packets

5 years agoFormatting
Arran Cudbard-Bell [Mon, 2 Nov 2020 00:22:51 +0000 (18:22 -0600)] 
Formatting

5 years agoHack subrequest so it does what we want
Arran Cudbard-Bell [Sun, 1 Nov 2020 23:58:59 +0000 (17:58 -0600)] 
Hack subrequest so it does what we want

We really need some way of specifying "all children of"

5 years agoAdd pair list debug function we can call from lldb
Arran Cudbard-Bell [Sun, 1 Nov 2020 23:38:14 +0000 (17:38 -0600)] 
Add pair list debug function we can call from lldb

5 years agoInvert argument order of unlang callback functions
Arran Cudbard-Bell [Sun, 1 Nov 2020 23:24:14 +0000 (17:24 -0600)] 
Invert argument order of unlang callback functions

5 years agoUpdate the docs for call
Arran Cudbard-Bell [Sun, 1 Nov 2020 22:52:02 +0000 (16:52 -0600)] 
Update the docs for call

5 years agoFix explosions when we hit the unlang stack limit
Arran Cudbard-Bell [Sun, 1 Nov 2020 22:45:14 +0000 (16:45 -0600)] 
Fix explosions when we hit the unlang stack limit

5 years agoAsserts are no longer correct
Arran Cudbard-Bell [Sun, 1 Nov 2020 21:54:21 +0000 (15:54 -0600)] 
Asserts are no longer correct

5 years agoHave call operate on the original request
Arran Cudbard-Bell [Sun, 1 Nov 2020 21:53:29 +0000 (15:53 -0600)] 
Have call operate on the original request

5 years agoSimplify unlang_module_push
Arran Cudbard-Bell [Sun, 1 Nov 2020 19:39:34 +0000 (13:39 -0600)] 
Simplify unlang_module_push

5 years agoMore cleanups
Arran Cudbard-Bell [Sun, 1 Nov 2020 16:24:11 +0000 (10:24 -0600)] 
More cleanups

5 years agoUnused
Arran Cudbard-Bell [Sun, 1 Nov 2020 15:53:43 +0000 (09:53 -0600)] 
Unused

The new call code will do almost the same thing

5 years agoMore struct name fixes
Arran Cudbard-Bell [Sun, 1 Nov 2020 15:50:18 +0000 (09:50 -0600)] 
More struct name fixes

5 years agoMove redundant struct around
Arran Cudbard-Bell [Sun, 1 Nov 2020 15:28:10 +0000 (09:28 -0600)] 
Move redundant struct around

5 years agoUse the same names for frame process functions
Arran Cudbard-Bell [Sun, 1 Nov 2020 15:24:49 +0000 (09:24 -0600)] 
Use the same names for frame process functions