]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 months agocheck for DO_NOT_RESPOND, and for rcode in authentication continue
Alan T. DeKok [Mon, 16 Feb 2026 17:03:16 +0000 (12:03 -0500)] 
check for DO_NOT_RESPOND, and for rcode in authentication continue

5 months agoensure Disconnect-Request and Protocol-Error save/restore Proxy-State
Alan T. DeKok [Mon, 16 Feb 2026 16:48:21 +0000 (11:48 -0500)] 
ensure Disconnect-Request and Protocol-Error save/restore Proxy-State

5 months agoadd notes for what to do when modifying rlm_rcode_t
Alan T. DeKok [Mon, 16 Feb 2026 16:36:00 +0000 (11:36 -0500)] 
add notes for what to do when modifying rlm_rcode_t

because TIMEOUT was added, and some things were missed

5 months agocorrect logic and add new functionality.
Alan T. DeKok [Mon, 16 Feb 2026 16:05:18 +0000 (11:05 -0500)] 
correct logic and add new functionality.

* RLM_RCODE_TIMEOUT was missing from authenticate handler
* add pointer to documentation if the shared secret is wrong
* allow 'authenticate' section to set reply.Packet-Type
* various other minor tweaks and logic corrections

5 months agodon't add Event-Timestamp in code
Alan T. DeKok [Mon, 16 Feb 2026 16:03:30 +0000 (11:03 -0500)] 
don't add Event-Timestamp in code

it should be a policy.  And ignore Acct-Delay-Time if its value
is unreasonable

5 months agocheck if state_tree_init fails
Alan T. DeKok [Mon, 16 Feb 2026 15:31:47 +0000 (10:31 -0500)] 
check if state_tree_init fails

5 months agotypo
Alan T. DeKok [Mon, 16 Feb 2026 15:31:20 +0000 (10:31 -0500)] 
typo

5 months agofix typos and add missing things
Alan T. DeKok [Mon, 16 Feb 2026 15:18:55 +0000 (10:18 -0500)] 
fix typos and add missing things

5 months agouse process_rctx_t instead of local struct
Alan T. DeKok [Mon, 16 Feb 2026 13:39:34 +0000 (08:39 -0500)] 
use process_rctx_t instead of local struct

any local struct has to go within the process_rctx_t

5 months agoswap check so that our define doesn't create an error
Alan T. DeKok [Mon, 16 Feb 2026 13:38:52 +0000 (08:38 -0500)] 
swap check so that our define doesn't create an error

5 months agoasciidoctor / pandoc are not required to build .debs
Nick Porter [Mon, 16 Feb 2026 15:46:04 +0000 (15:46 +0000)] 
asciidoctor / pandoc are not required to build .debs

5 months agoTests run under Docker don't have sudo
Nick Porter [Mon, 16 Feb 2026 13:25:50 +0000 (13:25 +0000)] 
Tests run under Docker don't have sudo

5 months agovarious bug fixes in cf_file.c
Alan T. DeKok [Mon, 16 Feb 2026 12:49:47 +0000 (07:49 -0500)] 
various bug fixes in cf_file.c

5 months agomake check clearer and more consistent
Alan T. DeKok [Mon, 16 Feb 2026 12:32:17 +0000 (07:32 -0500)] 
make check clearer and more consistent

5 months agoPacify clang scan
Nick Porter [Mon, 16 Feb 2026 11:05:26 +0000 (11:05 +0000)] 
Pacify clang scan

5 months agoCheck return (CID #1681379, #1681380)
Nick Porter [Mon, 16 Feb 2026 09:03:37 +0000 (09:03 +0000)] 
Check return (CID #1681379, #1681380)

5 months agoCheck map->rhs before dereference (CID #1681378)
Nick Porter [Mon, 16 Feb 2026 08:57:08 +0000 (08:57 +0000)] 
Check map->rhs before dereference (CID #1681378)

5 months ago%time.next() needs > 0 input (CID #1681377)
Nick Porter [Mon, 16 Feb 2026 08:51:12 +0000 (08:51 +0000)] 
%time.next() needs > 0 input (CID #1681377)

5 months agoPacify Coverity (CID #1681274)
Nick Porter [Mon, 16 Feb 2026 08:38:17 +0000 (08:38 +0000)] 
Pacify Coverity (CID #1681274)

Not much can be done if the timer is not set.

5 months agoOnly attempt to close fd if it's open (CID #1681275)
Nick Porter [Mon, 16 Feb 2026 08:31:24 +0000 (08:31 +0000)] 
Only attempt to close fd if it's open (CID #1681275)

5 months agoHandle return value (CID #1681276)
Nick Porter [Mon, 16 Feb 2026 08:23:43 +0000 (08:23 +0000)] 
Handle return value (CID #1681276)

Failure to set the timer is not fatal; even with no timer writes, logs
will be written when the buffer is full.

5 months agoEnsure file->log_header exists (CID #1681277)
Nick Porter [Mon, 16 Feb 2026 08:15:10 +0000 (08:15 +0000)] 
Ensure file->log_header exists (CID #1681277)

5 months agoSpelling
Nick Porter [Thu, 12 Feb 2026 15:40:12 +0000 (15:40 +0000)] 
Spelling

5 months agoFix fr_pair_list_replace_by_da
Nick Porter [Thu, 12 Feb 2026 15:39:37 +0000 (15:39 +0000)] 
Fix fr_pair_list_replace_by_da

5 months agoswap order of assignment
Alan T. DeKok [Sun, 15 Feb 2026 21:59:17 +0000 (16:59 -0500)] 
swap order of assignment

so that we don't over-write a value before we read it

5 months agojust replace the value
Alan T. DeKok [Sun, 15 Feb 2026 21:57:56 +0000 (16:57 -0500)] 
just replace the value

5 months agomake cf_item_foreach() safe with remove, and use it in free_children
Alan T. DeKok [Sun, 15 Feb 2026 21:52:49 +0000 (16:52 -0500)] 
make cf_item_foreach() safe with remove, and use it in free_children

which means that the children are removed from the ident trees, too

5 months agoproduce better errors when parsing octal strings.
Alan T. DeKok [Sun, 15 Feb 2026 21:45:50 +0000 (16:45 -0500)] 
produce better errors when parsing octal strings.

because it's still 1981 somewhere.

5 months agoupdate based on returned argv, which may be >1
Alan T. DeKok [Sun, 15 Feb 2026 21:37:30 +0000 (16:37 -0500)] 
update based on returned argv, which may be >1

5 months agoremove unused functions
Alan T. DeKok [Sun, 15 Feb 2026 21:36:59 +0000 (16:36 -0500)] 
remove unused functions

5 months agoupdate variable with mutex held
Alan T. DeKok [Sun, 15 Feb 2026 21:32:06 +0000 (16:32 -0500)] 
update variable with mutex held

5 months agostop iterating over minmax heap if the heap changes
Alan T. DeKok [Sun, 15 Feb 2026 21:30:03 +0000 (16:30 -0500)] 
stop iterating over minmax heap if the heap changes

5 months agocheck previous state, not current state for connected
Alan T. DeKok [Sun, 15 Feb 2026 21:26:53 +0000 (16:26 -0500)] 
check previous state, not current state for connected

5 months agotypo - use correct variable in error message
Alan T. DeKok [Sun, 15 Feb 2026 21:25:40 +0000 (16:25 -0500)] 
typo - use correct variable in error message

5 months agoEAP-SIM doesn't have Packet-Type, and therefore can't have 'finally'
Alan T. DeKok [Sun, 15 Feb 2026 21:22:18 +0000 (16:22 -0500)] 
EAP-SIM doesn't have Packet-Type, and therefore can't have 'finally'

5 months agotweak names and don't pass cs=NULL to log function
Alan T. DeKok [Sun, 15 Feb 2026 21:18:04 +0000 (16:18 -0500)] 
tweak names and don't pass cs=NULL to log function

5 months agofix memory handling
Alan T. DeKok [Sun, 15 Feb 2026 21:05:59 +0000 (16:05 -0500)] 
fix memory handling

don't free mmc, we didn't allocate it.

also free dynamic modules

5 months agofix typo min -> max
Alan T. DeKok [Sun, 15 Feb 2026 21:00:20 +0000 (16:00 -0500)] 
fix typo min -> max

5 months agotrigger is run with mutex held
Alan T. DeKok [Sun, 15 Feb 2026 20:59:39 +0000 (15:59 -0500)] 
trigger is run with mutex held

5 months agoremove state entry from tree if dedup check fails
Alan T. DeKok [Sun, 15 Feb 2026 20:57:33 +0000 (15:57 -0500)] 
remove state entry from tree if dedup check fails

5 months agofix prioritization functions
Alan T. DeKok [Sun, 15 Feb 2026 20:21:36 +0000 (15:21 -0500)] 
fix prioritization functions

so that higher priority requests are handled earlier

5 months agoremove unnecessary code
Alan T. DeKok [Sun, 15 Feb 2026 20:26:34 +0000 (15:26 -0500)] 
remove unnecessary code

5 months agouse CMP to avoid manual calculations
Alan T. DeKok [Sun, 15 Feb 2026 19:57:46 +0000 (14:57 -0500)] 
use CMP to avoid manual calculations

5 months agovarious bug fixes for tmpl_tokenize.c
Alan T. DeKok [Sun, 15 Feb 2026 19:52:30 +0000 (14:52 -0500)] 
various bug fixes for tmpl_tokenize.c

5 months agodon't mash string length
Alan T. DeKok [Sun, 15 Feb 2026 19:48:58 +0000 (14:48 -0500)] 
don't mash string length

5 months agoex->trigger_prefix needs to be talloc'd
Alan T. DeKok [Sun, 15 Feb 2026 19:46:55 +0000 (14:46 -0500)] 
ex->trigger_prefix needs to be talloc'd

5 months agodelay free until after we're done using pointer
Alan T. DeKok [Sun, 15 Feb 2026 19:44:19 +0000 (14:44 -0500)] 
delay free until after we're done using pointer

5 months agomove bracket for typo
Alan T. DeKok [Sun, 15 Feb 2026 19:43:27 +0000 (14:43 -0500)] 
move bracket for typo

5 months agovarious bug fixes for virtual_servers.c
Alan T. DeKok [Sun, 15 Feb 2026 19:42:13 +0000 (14:42 -0500)] 
various bug fixes for virtual_servers.c

5 months agopassword_normify() returns NULL on failure, not on OOM
Alan T. DeKok [Sun, 15 Feb 2026 19:34:09 +0000 (14:34 -0500)] 
password_normify() returns NULL on failure, not on OOM

5 months agoinstantiate / free all libraries, even if one is already done
Alan T. DeKok [Sun, 15 Feb 2026 19:32:13 +0000 (14:32 -0500)] 
instantiate  / free all libraries, even if one is already done

5 months agofix typos
Alan T. DeKok [Sun, 15 Feb 2026 19:31:20 +0000 (14:31 -0500)] 
fix typos

5 months agocheck correct variable
Alan T. DeKok [Sun, 15 Feb 2026 19:30:29 +0000 (14:30 -0500)] 
check correct variable

5 months agofix various bugs in module.c
Alan T. DeKok [Sun, 15 Feb 2026 19:29:23 +0000 (14:29 -0500)] 
fix various bugs in module.c

5 months agodon't use strcpy()
Alan T. DeKok [Sun, 15 Feb 2026 19:24:26 +0000 (14:24 -0500)] 
don't use strcpy()

5 months agoescape strings properly, and use heap instead of stack
Alan T. DeKok [Sun, 15 Feb 2026 19:20:00 +0000 (14:20 -0500)] 
escape strings properly, and use heap instead of stack

5 months agoreturn on error
Alan T. DeKok [Sun, 15 Feb 2026 19:07:26 +0000 (14:07 -0500)] 
return on error

5 months agocopy the entire environment
Alan T. DeKok [Sun, 15 Feb 2026 19:07:09 +0000 (14:07 -0500)] 
copy the entire environment

5 months agoactually do mprotect()
Alan T. DeKok [Sun, 15 Feb 2026 19:06:37 +0000 (14:06 -0500)] 
actually do mprotect()

5 months agotweaks to keep analyzer happy
Alan T. DeKok [Sun, 15 Feb 2026 17:26:17 +0000 (12:26 -0500)] 
tweaks to keep analyzer happy

5 months agovarious bug fixes for xlat_eval.c
Alan T. DeKok [Sun, 15 Feb 2026 17:17:30 +0000 (12:17 -0500)] 
various bug fixes for xlat_eval.c

5 months agovarious bug fixes for edit.c
Alan T. DeKok [Sun, 15 Feb 2026 17:16:54 +0000 (12:16 -0500)] 
various bug fixes for edit.c

5 months agotypo, use subcs and not parent cs
Alan T. DeKok [Sun, 15 Feb 2026 16:54:27 +0000 (11:54 -0500)] 
typo, use subcs and not parent cs

5 months agovarious bug fixes in subrequest.c
Alan T. DeKok [Sun, 15 Feb 2026 16:33:06 +0000 (11:33 -0500)] 
various bug fixes in subrequest.c

free child for completeness

if we fail to start the child, then we had pushed a frame in the
parent which is now invalid.  So we mark that frame as unwinding
which does little more than reduce maximum memory pressure, as it
was parented from "request"

5 months agotypos
Alan T. DeKok [Sun, 15 Feb 2026 16:32:12 +0000 (11:32 -0500)] 
typos

5 months agoold "foreach" syntax is an error
Alan T. DeKok [Sun, 15 Feb 2026 14:32:41 +0000 (09:32 -0500)] 
old "foreach" syntax is an error

5 months agovarious bug fixes in xlat_builtin.c
Alan T. DeKok [Sun, 15 Feb 2026 14:05:46 +0000 (09:05 -0500)] 
various bug fixes in xlat_builtin.c

5 months agovarious bug fixes in compile.c
Alan T. DeKok [Sun, 15 Feb 2026 14:05:29 +0000 (09:05 -0500)] 
various bug fixes in compile.c

5 months agopass correct thread data to retry callback
Alan T. DeKok [Sun, 15 Feb 2026 13:52:29 +0000 (08:52 -0500)] 
pass correct thread data to retry callback

5 months agoincrement callers only after success, and update ua on failure
Alan T. DeKok [Sun, 15 Feb 2026 13:50:12 +0000 (08:50 -0500)] 
increment callers only after success, and update ua on failure

5 months agovarious bug fixes in parallel.c
Alan T. DeKok [Sun, 15 Feb 2026 13:48:29 +0000 (08:48 -0500)] 
various bug fixes in parallel.c

cr->request may be NULL if a child was not initialized
i.e. if it's cancelled before it has a chance to run

on error initializing parallel, also clean up the child which caused
the error

5 months agopass correct context to timer callback
Alan T. DeKok [Sun, 15 Feb 2026 13:48:15 +0000 (08:48 -0500)] 
pass correct context to timer callback

5 months agoadd test harness for fifo, hash, inet, retry, and trie
Alan T. DeKok [Sun, 15 Feb 2026 13:25:52 +0000 (08:25 -0500)] 
add test harness for fifo, hash, inet, retry, and trie

5 months agochange struct to quiet compiler warnings
Alan T. DeKok [Sun, 15 Feb 2026 13:30:27 +0000 (08:30 -0500)] 
change struct to quiet compiler warnings

5 months agofix RT calculations
Alan T. DeKok [Sun, 15 Feb 2026 13:02:56 +0000 (08:02 -0500)] 
fix RT calculations

5 months agoset inlen if it's -1 on input
Alan T. DeKok [Sat, 14 Feb 2026 14:26:31 +0000 (09:26 -0500)] 
set inlen if it's -1 on input

5 months agoreorder operations for "update" to match "hash"
Alan T. DeKok [Sat, 14 Feb 2026 14:24:18 +0000 (09:24 -0500)] 
reorder operations for "update" to match "hash"

5 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Sun, 15 Feb 2026 05:10:49 +0000 (05:10 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

5 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Sun, 15 Feb 2026 05:10:43 +0000 (05:10 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

5 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Sun, 15 Feb 2026 05:10:02 +0000 (05:10 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

5 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Sun, 15 Feb 2026 05:09:13 +0000 (05:09 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

5 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Sun, 15 Feb 2026 05:09:08 +0000 (05:09 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

5 months agovarious bug fixes for dict_tokenize.c
Alan T. DeKok [Sat, 14 Feb 2026 13:58:48 +0000 (08:58 -0500)] 
various bug fixes for dict_tokenize.c

5 months agovarious bug fixes for dict_util.c
Alan T. DeKok [Sat, 14 Feb 2026 13:58:24 +0000 (08:58 -0500)] 
various bug fixes for dict_util.c

5 months agoset fixup flag for aliases, and clear the correct flag
Alan T. DeKok [Sat, 14 Feb 2026 13:57:52 +0000 (08:57 -0500)] 
set fixup flag for aliases, and clear the correct flag

5 months agofix various bugs in sbuff.c
Alan T. DeKok [Sat, 14 Feb 2026 13:44:32 +0000 (08:44 -0500)] 
fix various bugs in sbuff.c

5 months agoupdate code / docs to match expected usage
Alan T. DeKok [Sat, 14 Feb 2026 13:38:56 +0000 (08:38 -0500)] 
update code / docs to match expected usage

5 months agouse sockaddr_storage
Alan T. DeKok [Sat, 14 Feb 2026 13:37:18 +0000 (08:37 -0500)] 
use sockaddr_storage

5 months agocheck for allocation failure
Alan T. DeKok [Sat, 14 Feb 2026 13:36:37 +0000 (08:36 -0500)] 
check for allocation failure

5 months agovarious bug fixes in trie.c
Alan T. DeKok [Sat, 14 Feb 2026 13:33:51 +0000 (08:33 -0500)] 
various bug fixes in trie.c

5 months agodon't close already closed socket
Alan T. DeKok [Sat, 14 Feb 2026 13:19:46 +0000 (08:19 -0500)] 
don't close already closed socket

5 months agoupdate code to match docs, and add assertions
Alan T. DeKok [Sat, 14 Feb 2026 13:17:22 +0000 (08:17 -0500)] 
update code to match docs, and add assertions

5 months agofix various bugs in inet.c
Alan T. DeKok [Sat, 14 Feb 2026 03:14:45 +0000 (22:14 -0500)] 
fix various bugs in inet.c

5 months agodon't double-close sockfd
Alan T. DeKok [Sat, 14 Feb 2026 03:11:46 +0000 (22:11 -0500)] 
don't double-close sockfd

5 months agoupdate doxygen to match code
Alan T. DeKok [Sat, 14 Feb 2026 03:09:56 +0000 (22:09 -0500)] 
update doxygen to match code

5 months agoshrink the heap after rebalancing it, not before.
Alan T. DeKok [Sat, 14 Feb 2026 03:07:01 +0000 (22:07 -0500)] 
shrink the heap after rebalancing it, not before.

shrink to 1/2 size if the heap is less than 1/3 full.  Which
leaves some room to insert new entries before we have to grow the
heap again.

5 months agoavoid overflow by just looking at actual allocated size
Alan T. DeKok [Sat, 14 Feb 2026 02:59:26 +0000 (21:59 -0500)] 
avoid overflow by just looking at actual allocated size

5 months agofix various bugs in event.c
Alan T. DeKok [Sat, 14 Feb 2026 02:53:29 +0000 (21:53 -0500)] 
fix various bugs in event.c

5 months agofix various bugs in calc.c
Alan T. DeKok [Sat, 14 Feb 2026 02:51:31 +0000 (21:51 -0500)] 
fix various bugs in calc.c

5 months agofix return code and don't free ourselves in a destructor
Alan T. DeKok [Sat, 14 Feb 2026 02:33:29 +0000 (21:33 -0500)] 
fix return code and don't free ourselves in a destructor