]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 months agofix various bugs in value.c
Alan T. DeKok [Sat, 14 Feb 2026 02:32:37 +0000 (21:32 -0500)] 
fix various bugs in value.c

5 months agofix various bugs in the pair code.
Alan T. DeKok [Sat, 14 Feb 2026 02:10:57 +0000 (21:10 -0500)] 
fix various bugs in the pair code.

5 months agofix various bugs in the cbor code
Alan T. DeKok [Sat, 14 Feb 2026 02:10:40 +0000 (21:10 -0500)] 
fix various bugs in the cbor code

5 months agoMinor typo fix.
Marc-Andre Casavant [Fri, 13 Feb 2026 21:33:33 +0000 (16:33 -0500)] 
Minor typo fix.

5 months agoremove redundant code and do tweaks
Alan T. DeKok [Fri, 13 Feb 2026 19:50:15 +0000 (14:50 -0500)] 
remove redundant code and do tweaks

5 months agoadd SRV record
Alan T. DeKok [Fri, 13 Feb 2026 19:44:46 +0000 (14:44 -0500)] 
add SRV record

5 months agocheck for truncated packets and give an error.
Alan T. DeKok [Fri, 13 Feb 2026 19:33:12 +0000 (14:33 -0500)] 
check for truncated packets and give an error.

Truncation means that the packt is well-formed, but that it's not
containing all of the available data.  We then have to re-try the
query over TCP.

For now, this means we don't process the packet.

5 months agofix typos
Alan T. DeKok [Fri, 13 Feb 2026 19:28:58 +0000 (14:28 -0500)] 
fix typos

5 months agoreturn correct error offset for question section
Alan T. DeKok [Fri, 13 Feb 2026 19:25:43 +0000 (14:25 -0500)] 
return correct error offset for question section

5 months agostop when we reach the end of the input
Alan T. DeKok [Fri, 13 Feb 2026 18:59:14 +0000 (13:59 -0500)] 
stop when we reach the end of the input

5 months agonote todo for RFC 2136
Alan T. DeKok [Fri, 13 Feb 2026 18:56:15 +0000 (13:56 -0500)] 
note todo for RFC 2136

5 months agoupdate test harness function to catch error case
Alan T. DeKok [Fri, 13 Feb 2026 17:57:06 +0000 (12:57 -0500)] 
update test harness function to catch error case

5 months agoa DNS label can be zero length.
Alan T. DeKok [Fri, 13 Feb 2026 17:52:58 +0000 (12:52 -0500)] 
a DNS label can be zero length.

but a zero-length label can't then be in an array.

update the API for the encoding function, as none of the callers
looked for "room needed", and the callers did need to see a zero
return as an allowed, non-error return value.

5 months agoensure that "counter" is updated
Alan T. DeKok [Fri, 13 Feb 2026 17:46:20 +0000 (12:46 -0500)] 
ensure that "counter" is updated

5 months agoit doesn't make sense to encode no data for an array member
Alan T. DeKok [Fri, 13 Feb 2026 17:39:41 +0000 (12:39 -0500)] 
it doesn't make sense to encode no data for an array member

5 months agoUPDATE packets use the count fields for different purposes
Alan T. DeKok [Fri, 13 Feb 2026 17:37:18 +0000 (12:37 -0500)] 
UPDATE packets use the count fields for different purposes

5 months agoswap to use correct error codes
Alan T. DeKok [Fri, 13 Feb 2026 17:29:11 +0000 (12:29 -0500)] 
swap to use correct error codes

5 months agofix typo. MX preference is 16 bit.
Alan T. DeKok [Fri, 13 Feb 2026 17:07:09 +0000 (12:07 -0500)] 
fix typo.  MX preference is 16 bit.

5 months agotypos
Alan T. DeKok [Thu, 12 Feb 2026 16:47:24 +0000 (11:47 -0500)] 
typos

5 months agoMaximum-Msg-Size is uint16, not uint32
Alan T. DeKok [Thu, 12 Feb 2026 16:42:04 +0000 (11:42 -0500)] 
Maximum-Msg-Size is uint16, not uint32

5 months agono need to print this as hex
Alan T. DeKok [Thu, 12 Feb 2026 16:41:55 +0000 (11:41 -0500)] 
no need to print this as hex

5 months agoaccept only ethernet
Alan T. DeKok [Thu, 12 Feb 2026 16:28:38 +0000 (11:28 -0500)] 
accept only ethernet

5 months agoremove unused code
Alan T. DeKok [Thu, 12 Feb 2026 16:27:45 +0000 (11:27 -0500)] 
remove unused code

5 months agoallow up to FR_DHCP_CODE_MAX
Alan T. DeKok [Thu, 12 Feb 2026 16:24:40 +0000 (11:24 -0500)] 
allow up to FR_DHCP_CODE_MAX

5 months agoadd assert that fr_dhcpv4_ok() is called before printing
Alan T. DeKok [Thu, 12 Feb 2026 14:58:13 +0000 (09:58 -0500)] 
add assert that fr_dhcpv4_ok() is called before printing

and check for end of options before printing length

5 months agobe more aggressive about cleaning up on error
Alan T. DeKok [Thu, 12 Feb 2026 14:27:45 +0000 (09:27 -0500)] 
be more aggressive about cleaning up on error

there's already an "error" target which does full cleanups, so
use that.

All of the memory was parented from "ctx", so there were no actual
leaks, but it's good practice to be nice.

5 months agoclean up data on memory allocation failure
Alan T. DeKok [Thu, 12 Feb 2026 14:25:01 +0000 (09:25 -0500)] 
clean up data on memory allocation failure

5 months agoaccount for UDP header size, too
Alan T. DeKok [Thu, 12 Feb 2026 14:20:32 +0000 (09:20 -0500)] 
account for UDP header size, too

5 months agofix option field decoding
Alan T. DeKok [Thu, 12 Feb 2026 14:16:00 +0000 (09:16 -0500)] 
fix option field decoding

use macros instead of hard-coded values.

and update tests to match

5 months agofix bounds check
Alan T. DeKok [Thu, 12 Feb 2026 14:13:27 +0000 (09:13 -0500)] 
fix bounds check

5 months agofix typo
Alan T. DeKok [Thu, 12 Feb 2026 14:12:56 +0000 (09:12 -0500)] 
fix typo

5 months agoRe-enable message_set_test
Nick Porter [Thu, 12 Feb 2026 14:45:45 +0000 (14:45 +0000)] 
Re-enable message_set_test

5 months agoAdd test of messages_set where initial ring buffer is smaller than request size
Nick Porter [Thu, 12 Feb 2026 14:44:28 +0000 (14:44 +0000)] 
Add test of messages_set where initial ring buffer is smaller than request size

5 months agoUse fr_exit_now in test in place of fr_assert
Nick Porter [Thu, 12 Feb 2026 14:43:47 +0000 (14:43 +0000)] 
Use fr_exit_now in test in place of fr_assert

So failures give meaningful output.

5 months agoMake message_set_test compile again
Nick Porter [Thu, 12 Feb 2026 14:36:58 +0000 (14:36 +0000)] 
Make message_set_test compile again

5 months agoAllow message set to alloc messages greater than half initial ring buffer
Nick Porter [Fri, 30 Jan 2026 09:33:31 +0000 (09:33 +0000)] 
Allow message set to alloc messages greater than half initial ring buffer

This is optional so the message size protection can be retained for
exsiting network -> worker use

5 months agoTypo
Nick Porter [Fri, 30 Jan 2026 12:09:34 +0000 (12:09 +0000)] 
Typo

5 months agotests for ipv4prefix
Alan T. DeKok [Thu, 12 Feb 2026 02:30:05 +0000 (21:30 -0500)] 
tests for ipv4prefix

5 months agomask off ipv4 prefix bits, to be in compliance with RFC8044 Section 3.11
Alan T. DeKok [Thu, 12 Feb 2026 01:53:43 +0000 (20:53 -0500)] 
mask off ipv4 prefix bits, to be in compliance with RFC8044 Section 3.11

this shouldn't strictly be necessary, as the value-boxes should
already enforce this.  But layers of protection aren't bad.

5 months agoadd secret length to ascend_secret() function
Alan T. DeKok [Thu, 12 Feb 2026 01:44:13 +0000 (20:44 -0500)] 
add secret length to ascend_secret() function

all of the other password encode / decode functions already took
a secret length parameter

5 months agocorrect subtraction of pointers
Alan T. DeKok [Thu, 12 Feb 2026 01:39:45 +0000 (20:39 -0500)] 
correct subtraction of pointers

5 months agomove duplicate check to assert
Alan T. DeKok [Thu, 12 Feb 2026 01:37:29 +0000 (20:37 -0500)] 
move duplicate check to assert

pwlen could never be larger than 253, so there's no need to check
for it being larger than 256

5 months agofix typo for tag, and clarify messages
Alan T. DeKok [Thu, 12 Feb 2026 01:32:47 +0000 (20:32 -0500)] 
fix typo for tag, and clarify messages

5 months agohoist encode tag byte for Tunnel-Password
Alan T. DeKok [Thu, 12 Feb 2026 01:30:21 +0000 (20:30 -0500)] 
hoist encode tag byte for Tunnel-Password

so that we don't double-tag things

5 months agofix decode of NAS-Filter-Rule
Alan T. DeKok [Thu, 12 Feb 2026 00:58:39 +0000 (19:58 -0500)] 
fix decode of NAS-Filter-Rule

check the number of attributes, not the total data length

5 months agofeat: Added batch logging to the linelog module
ethan-thompson [Thu, 29 Jan 2026 20:33:11 +0000 (20:33 +0000)] 
feat: Added batch logging to the linelog module

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
5 months agofeat: Added max_idle config option to linelog file structure which can be useful...
ethan-thompson [Thu, 29 Jan 2026 20:27:35 +0000 (20:27 +0000)] 
feat: Added max_idle config option to linelog file structure which can be useful in testing

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
5 months agomore debug output to show which value failed
Alan T. DeKok [Wed, 11 Feb 2026 19:13:21 +0000 (14:13 -0500)] 
more debug output to show which value failed

5 months agoreplace smart quotes, emdash, etc. with ASCII
Alan T. DeKok [Wed, 11 Feb 2026 16:54:50 +0000 (11:54 -0500)] 
replace smart quotes, emdash, etc. with ASCII

5 months agorule to check for non-ASCII characters.
Alan T. DeKok [Wed, 11 Feb 2026 16:32:52 +0000 (11:32 -0500)] 
rule to check for non-ASCII characters.

while smart quotes are nice, ASCII is nicer. And emdashes are bad.

Add additional rule to clean up non-ASCII characters

5 months agodoc: add introduction and sections overview to virtual tutorial
98manu [Thu, 29 Jan 2026 09:52:37 +0000 (15:22 +0530)] 
doc: add introduction and sections overview to virtual tutorial

doc: add default behavior and best practice to virtual tutorial

doc: add create and enable virtual server sections to virtual tutorial

5 months agodocs: add introduction and goals for proxy tutorial
Tharka Karunanayake [Tue, 3 Feb 2026 09:16:46 +0000 (14:46 +0530)] 
docs: add introduction and goals for proxy tutorial

docs: add Step 1 for creating proxy module instance

docs: add Step 2 for modifying the virtual server

docs: add Step 3 for verifying config and restarting

docs: add Step 4 (Local Testing) to proxy tutorial

docs: add Proxied Testing results and debug output to proxy tutorial

docs: complete proxy tutorial with Questions and Copyright footer

5 months agoupdate now that we have a home_server_pool example.
Alan T. DeKok [Wed, 11 Feb 2026 13:46:25 +0000 (08:46 -0500)] 
update now that we have a home_server_pool example.

5 months agoadd example of converting v3 home_server_pool to v4
Alan T. DeKok [Wed, 11 Feb 2026 13:36:39 +0000 (08:36 -0500)] 
add example of converting v3 home_server_pool to v4

5 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Wed, 11 Feb 2026 05:11:52 +0000 (05:11 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

5 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Wed, 11 Feb 2026 05:10:20 +0000 (05:10 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

5 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Wed, 11 Feb 2026 05:09:49 +0000 (05:09 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

5 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Wed, 11 Feb 2026 05:03:41 +0000 (05:03 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

5 months agoadd proxy.conf as a helpful hint
Alan T. DeKok [Wed, 11 Feb 2026 00:20:28 +0000 (19:20 -0500)] 
add proxy.conf as a helpful hint

which contains pointers to the real docs, and examples of how
the old proxy.conf has moved to the new configuration.

5 months agoallow virtual modules for load-balance and redundant-load-balance
Alan T. DeKok [Tue, 10 Feb 2026 23:25:47 +0000 (18:25 -0500)] 
allow virtual modules for load-balance and redundant-load-balance

so that they can have second names, and also a key.

5 months agoadd sample "proxy" virtual server
Alan T. DeKok [Tue, 10 Feb 2026 17:46:42 +0000 (12:46 -0500)] 
add sample "proxy" virtual server

5 months agofix links and script to produce the right things
Alan T. DeKok [Tue, 10 Feb 2026 17:44:39 +0000 (12:44 -0500)] 
fix links and script to produce the right things

5 months agoadd notes on call vs subrequest
Alan T. DeKok [Tue, 10 Feb 2026 17:30:49 +0000 (12:30 -0500)] 
add notes on call vs subrequest

5 months agoAnother instance of hard coded "Packet-Type"
Alan T. DeKok [Tue, 10 Feb 2026 16:28:46 +0000 (11:28 -0500)] 
Another instance of hard coded "Packet-Type"

it's still not all gone, as we should really update fr_dict_protocol_t
to have a pointer to the packet type attribute.  But it's at least
better.

5 months agominor tweaks and cleanups
Alan T. DeKok [Tue, 10 Feb 2026 14:48:20 +0000 (09:48 -0500)] 
minor tweaks and cleanups

5 months agoadd copyright
Alan T. DeKok [Sun, 8 Feb 2026 22:34:05 +0000 (17:34 -0500)] 
add copyright

5 months agoprint URL help for "Failed binding to socket"
Alan T. DeKok [Sun, 8 Feb 2026 16:50:06 +0000 (11:50 -0500)] 
print URL help for "Failed binding to socket"

and add preliminary page with a description

5 months agodo SUID up/down when binding to low ports
Alan T. DeKok [Sun, 8 Feb 2026 15:54:54 +0000 (10:54 -0500)] 
do SUID up/down when binding to low ports

5 months agoadd trampoline functions for SUID up/down
Alan T. DeKok [Sun, 8 Feb 2026 15:48:44 +0000 (10:48 -0500)] 
add trampoline functions for SUID up/down

some libraries should call suid up/down, but we don't want to
link them to libfreeradius-server.  So we instead createxi
trampoline functions.

5 months agolimit src port ranges to >1024
Alan T. DeKok [Sat, 7 Feb 2026 17:28:57 +0000 (12:28 -0500)] 
limit src port ranges to >1024

and do a few more cleanups.

5 months agoARP should do SUID up/down around binding
Alan T. DeKok [Sat, 7 Feb 2026 16:09:32 +0000 (11:09 -0500)] 
ARP should do SUID up/down around binding

5 months agouse cf_log_err() instead of ERROR()
Alan T. DeKok [Sat, 7 Feb 2026 16:06:26 +0000 (11:06 -0500)] 
use cf_log_err() instead of ERROR()

which prints out more descriptive messages

We should really look at moving to the BIOs.  There is a lot of
code duplication here. :(

5 months agoadd CONF_SECTION to listener
Alan T. DeKok [Sat, 7 Feb 2026 15:18:05 +0000 (10:18 -0500)] 
add CONF_SECTION to listener

so that the APP IO stuff can print out better error messages

5 months agofix and re-enable dictionary parsing tests
Alan T. DeKok [Fri, 6 Feb 2026 21:03:14 +0000 (16:03 -0500)] 
fix and re-enable dictionary parsing tests

5 months agofeature: Added mkdir and rmdir xlats and updated docs and tests
ethan-thompson [Fri, 6 Feb 2026 18:35:12 +0000 (18:35 +0000)] 
feature: Added mkdir and rmdir xlats and updated docs and tests

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
5 months agouse auto-generated tables
Alan T. DeKok [Fri, 6 Feb 2026 18:18:14 +0000 (13:18 -0500)] 
use auto-generated tables

5 months agoas generated
Alan T. DeKok [Fri, 6 Feb 2026 18:10:49 +0000 (13:10 -0500)] 
as generated

5 months agoprint out partial tables
Alan T. DeKok [Fri, 6 Feb 2026 18:08:56 +0000 (13:08 -0500)] 
print out partial tables

5 months agorearrangement and reorganization
Alan T. DeKok [Fri, 6 Feb 2026 17:10:08 +0000 (12:10 -0500)] 
rearrangement and reorganization

split different protocols into different pages

5 months agowhitespace and word smithing
Alan T. DeKok [Fri, 6 Feb 2026 16:43:25 +0000 (11:43 -0500)] 
whitespace and word smithing

5 months agodocs-v4: Update RFCs and organized into section. Updated all links to point to IETF...
nolade [Thu, 5 Feb 2026 23:20:39 +0000 (18:20 -0500)] 
docs-v4: Update RFCs and organized into section. Updated all links to point to IETF site.

5 months agodon't print out redundant messages on OSX
Alan T. DeKok [Thu, 5 Feb 2026 21:23:23 +0000 (16:23 -0500)] 
don't print out redundant messages on OSX

5 months agoTypo
Nick Porter [Fri, 6 Feb 2026 13:54:33 +0000 (13:54 +0000)] 
Typo

5 months agoOnly allocate the next message if there are leftover bytes
Nick Porter [Fri, 6 Feb 2026 12:31:30 +0000 (12:31 +0000)] 
Only allocate the next message if there are leftover bytes

5 months agoAvoid use after free in sql_trunk_query_cancel
Nick Porter [Wed, 4 Feb 2026 19:08:01 +0000 (19:08 +0000)] 
Avoid use after free in sql_trunk_query_cancel

Some SQL drivers will immediately cancel in response to
trunk_request_signal_cancel() resulting the freeing of treq, and due to
the re-parenting, query_ctx.

5 months agofix: Use the more optimized openat method to open a directory since we already can...
Ethan Thompson [Fri, 6 Feb 2026 01:30:37 +0000 (20:30 -0500)] 
fix: Use the more optimized openat method to open a directory since we already can get the fd from a previous mkdir call. Also close the directory fd as we use them, since we no longer need them to be open (#5737)

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
5 months agoprint out the full socket information when decoding fails
Alan T. DeKok [Thu, 5 Feb 2026 18:36:05 +0000 (13:36 -0500)] 
print out the full socket information when decoding fails

5 months agoadd listener to tracking structure
Alan T. DeKok [Thu, 5 Feb 2026 18:28:42 +0000 (13:28 -0500)] 
add listener to tracking structure

which is easier than the alternatives of adding it to all of the
other APIs

5 months agomove duplicate struct to common definition
Alan T. DeKok [Thu, 5 Feb 2026 16:09:20 +0000 (11:09 -0500)] 
move duplicate struct to common definition

5 months agoadd WDEBUG / EDEBUG macros and use them in proto_radius
Alan T. DeKok [Thu, 5 Feb 2026 15:33:33 +0000 (10:33 -0500)] 
add WDEBUG / EDEBUG macros and use them in proto_radius

5 months agoadd more errors with URLs
Alan T. DeKok [Thu, 5 Feb 2026 13:13:48 +0000 (08:13 -0500)] 
add more errors with URLs

5 months agomore docs on networking issues
Alan T. DeKok [Thu, 5 Feb 2026 02:13:08 +0000 (21:13 -0500)] 
more docs on networking issues

5 months agoremove unnecessary code
Alan T. DeKok [Wed, 4 Feb 2026 23:57:32 +0000 (18:57 -0500)] 
remove unnecessary code

6 months agoadd one more file, and print out URL to troubleshooting pages
Alan T. DeKok [Tue, 3 Feb 2026 20:42:01 +0000 (15:42 -0500)] 
add one more file, and print out URL to troubleshooting pages

6 months agotweaks to make it clearer
Alan T. DeKok [Tue, 3 Feb 2026 19:57:12 +0000 (14:57 -0500)] 
tweaks to make it clearer

6 months agoupdate docs for configurable failover and module behavior
Alan T. DeKok [Tue, 3 Feb 2026 19:46:14 +0000 (14:46 -0500)] 
update docs for configurable failover and module behavior

6 months agotypo
Alan T. DeKok [Tue, 3 Feb 2026 17:24:59 +0000 (12:24 -0500)] 
typo

6 months agoAutz-Type is not in v4
Alan T. DeKok [Tue, 3 Feb 2026 14:22:34 +0000 (09:22 -0500)] 
Autz-Type is not in v4

remove all references to it, and note this in the upgrade
documentation.

6 months agotweak and fix typos
Alan T. DeKok [Sun, 1 Feb 2026 21:52:27 +0000 (16:52 -0500)] 
tweak and fix typos

6 months agomove directory and links
Alan T. DeKok [Sun, 1 Feb 2026 21:47:41 +0000 (16:47 -0500)] 
move directory and links