]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
6 years agoadd small / fast random number generator
Alan T. DeKok [Fri, 6 Mar 2020 21:48:19 +0000 (16:48 -0500)] 
add small / fast random number generator

6 years agoeap/value: Remove duplicate macros
Arran Cudbard-Bell [Fri, 6 Mar 2020 22:23:18 +0000 (16:23 -0600)] 
eap/value: Remove duplicate macros

6 years agopair: Establish error codes for decoders
Arran Cudbard-Bell [Fri, 6 Mar 2020 21:48:24 +0000 (15:48 -0600)] 
pair: Establish error codes for decoders

6 years agonet: Missed space
Arran Cudbard-Bell [Fri, 6 Mar 2020 21:19:37 +0000 (15:19 -0600)] 
net: Missed space

6 years agonet: Fix function order
Arran Cudbard-Bell [Fri, 6 Mar 2020 20:54:40 +0000 (14:54 -0600)] 
net: Fix function order

6 years agonet: Use standard names for bytesex conversion functions
Arran Cudbard-Bell [Fri, 6 Mar 2020 20:51:15 +0000 (14:51 -0600)] 
net: Use standard names for bytesex conversion functions

Make all bytesex conversion functions use consistent argument names.

6 years agoMove htonx and ntohx to net.h
Arran Cudbard-Bell [Fri, 6 Mar 2020 16:24:27 +0000 (10:24 -0600)] 
Move htonx and ntohx to net.h

Remove radius_packet_t from net.h

6 years agoWas a two byte typo
Arran Cudbard-Bell [Fri, 6 Mar 2020 13:47:08 +0000 (07:47 -0600)] 
Was a two byte typo

6 years agoTypo
Arran Cudbard-Bell [Fri, 6 Mar 2020 03:51:08 +0000 (21:51 -0600)] 
Typo

6 years agomisc: Add htonx and ntohx
Arran Cudbard-Bell [Thu, 5 Mar 2020 23:55:18 +0000 (17:55 -0600)] 
misc: Add htonx and ntohx

For efficient packing and unpacking of network order integers, where the integer is of a variable size.

6 years agomisc.c: Move DIVIDE_CEIL into misc.h
Arran Cudbard-Bell [Thu, 5 Mar 2020 23:53:26 +0000 (17:53 -0600)] 
misc.c: Move DIVIDE_CEIL into misc.h

6 years agoredis: Cluster coordinator notes
Arran Cudbard-Bell [Thu, 5 Mar 2020 22:20:39 +0000 (16:20 -0600)] 
redis: Cluster coordinator notes

6 years agoredis/pipeline: Formatting
Arran Cudbard-Bell [Thu, 5 Mar 2020 22:00:47 +0000 (16:00 -0600)] 
redis/pipeline: Formatting

6 years agorlm_radius: Consistent terminology
Arran Cudbard-Bell [Thu, 5 Mar 2020 20:09:12 +0000 (14:09 -0600)] 
rlm_radius: Consistent terminology

6 years agorlm_radius: Formatting
Arran Cudbard-Bell [Thu, 5 Mar 2020 20:08:01 +0000 (14:08 -0600)] 
rlm_radius: Formatting

6 years agorlm_radius: Formatting
Arran Cudbard-Bell [Thu, 5 Mar 2020 20:00:27 +0000 (14:00 -0600)] 
rlm_radius: Formatting

6 years agorlm_radius: Finish manual test plan for rlm_radius
Arran Cudbard-Bell [Thu, 5 Mar 2020 19:54:38 +0000 (13:54 -0600)] 
rlm_radius: Finish manual test plan for rlm_radius

6 years agorlm_radius: Use the v3 name for this config item
Arran Cudbard-Bell [Thu, 5 Mar 2020 17:24:22 +0000 (11:24 -0600)] 
rlm_radius: Use the v3 name for this config item

6 years agoclear can_retransmit only for status-server
Alan T. DeKok [Thu, 5 Mar 2020 13:52:15 +0000 (08:52 -0500)] 
clear can_retransmit only for status-server

6 years agorlm_radius_udp: el is used
Arran Cudbard-Bell [Thu, 5 Mar 2020 02:40:31 +0000 (20:40 -0600)] 
rlm_radius_udp: el is used

6 years agotrunk: The correct fix here was to mirror the "init" state, not the failed state
Arran Cudbard-Bell [Thu, 5 Mar 2020 00:32:58 +0000 (18:32 -0600)] 
trunk: The correct fix here was to mirror the "init" state, not the failed state

6 years agotrunk: We don't need to do duplicate work on failed
Arran Cudbard-Bell [Thu, 5 Mar 2020 00:26:55 +0000 (18:26 -0600)] 
trunk: We don't need to do duplicate work on failed

6 years agotrunk: Implement backlog drain on fail
Arran Cudbard-Bell [Thu, 5 Mar 2020 00:26:24 +0000 (18:26 -0600)] 
trunk: Implement backlog drain on fail

6 years agotrunk: Typo
Arran Cudbard-Bell [Thu, 5 Mar 2020 00:26:00 +0000 (18:26 -0600)] 
trunk: Typo

6 years agotrunk: Initial state should be halted
Arran Cudbard-Bell [Wed, 4 Mar 2020 22:43:02 +0000 (16:43 -0600)] 
trunk: Initial state should be halted

6 years agocf_parse: Use consistent macro names
Arran Cudbard-Bell [Wed, 4 Mar 2020 22:38:38 +0000 (16:38 -0600)] 
cf_parse: Use consistent macro names

6 years agoretransmission is obnoxiously long, and rtx is well known
Arran Cudbard-Bell [Wed, 4 Mar 2020 22:36:13 +0000 (16:36 -0600)] 
retransmission is obnoxiously long, and rtx is well known

6 years agoWe use "max" everywhere else
Arran Cudbard-Bell [Wed, 4 Mar 2020 22:34:23 +0000 (16:34 -0600)] 
We use "max" everywhere else

6 years agorlm_radius_udp: Add note
Arran Cudbard-Bell [Wed, 4 Mar 2020 22:30:46 +0000 (16:30 -0600)] 
rlm_radius_udp: Add note

6 years agorlm_radius_udp: This comment is wrong too
Arran Cudbard-Bell [Wed, 4 Mar 2020 22:27:52 +0000 (16:27 -0600)] 
rlm_radius_udp: This comment is wrong too

6 years agorlm_radius_udp: Remove incorrect call to fr_retry_next
Arran Cudbard-Bell [Wed, 4 Mar 2020 22:25:19 +0000 (16:25 -0600)] 
rlm_radius_udp: Remove incorrect call to fr_retry_next

Resending a status-check packet because we want num_to_alive does not count as a retransmission, and should not increase the retransmission interval, and should not be subject to MRD or MRC.

6 years agorlm_radius_udp: Add a simpler implementation status checks that run before the connec...
Arran Cudbard-Bell [Wed, 4 Mar 2020 22:20:07 +0000 (16:20 -0600)] 
rlm_radius_udp: Add a simpler implementation status checks that run before the connection opens

6 years agorlm_radius_udp: Change status check talloc hierarchy to reflect a normal talloc hiera...
Arran Cudbard-Bell [Wed, 4 Mar 2020 21:49:54 +0000 (15:49 -0600)] 
rlm_radius_udp: Change status check talloc hierarchy to reflect a normal talloc hierarchy for requests/resume ctxs

6 years agorlm_radius_udp: Always enforce reply types
Arran Cudbard-Bell [Wed, 4 Mar 2020 21:48:14 +0000 (15:48 -0600)] 
rlm_radius_udp: Always enforce reply types

6 years agotrunk: Typo in timestamp comparison
Arran Cudbard-Bell [Wed, 4 Mar 2020 21:25:25 +0000 (15:25 -0600)] 
trunk: Typo in timestamp comparison

6 years agoBetter debugging on trunk start
Arran Cudbard-Bell [Wed, 4 Mar 2020 21:24:52 +0000 (15:24 -0600)] 
Better debugging on trunk start

6 years agotrunk: Failed and closed should _NOT_ be excluded from the set of connections
Arran Cudbard-Bell [Wed, 4 Mar 2020 21:24:12 +0000 (15:24 -0600)] 
trunk: Failed and closed should _NOT_ be excluded from the set of connections

6 years agotrunk: zero out treq pointers on free
Arran Cudbard-Bell [Wed, 4 Mar 2020 21:23:05 +0000 (15:23 -0600)] 
trunk: zero out treq pointers on free

6 years agorlm_radius_udp: Free handle using a talloc destructor
Arran Cudbard-Bell [Wed, 4 Mar 2020 18:19:26 +0000 (12:19 -0600)] 
rlm_radius_udp: Free handle using a talloc destructor

It's safer

6 years agoconnection: close connections which hit their connection timeout too
Arran Cudbard-Bell [Wed, 4 Mar 2020 18:18:05 +0000 (12:18 -0600)] 
connection: close connections which hit their connection timeout too

shuffle asserts for is_closed

6 years agoconnection: Expose connection state for asserting
Arran Cudbard-Bell [Wed, 4 Mar 2020 18:17:22 +0000 (12:17 -0600)] 
connection: Expose connection state for asserting

6 years agorlm_radius_udp: Explicitly free the status check timer on conn close
Arran Cudbard-Bell [Wed, 4 Mar 2020 16:09:13 +0000 (10:09 -0600)] 
rlm_radius_udp: Explicitly free the status check timer on conn close

6 years agorlm_radius_udp: Explicitly free h on conn close
Arran Cudbard-Bell [Wed, 4 Mar 2020 16:08:42 +0000 (10:08 -0600)] 
rlm_radius_udp: Explicitly free h on conn close

6 years agorlm_radius_udp: More detailed error messages
Arran Cudbard-Bell [Wed, 4 Mar 2020 16:08:25 +0000 (10:08 -0600)] 
rlm_radius_udp: More detailed error messages

6 years agotrunk: Add init state to mirror the connection API's init state
Arran Cudbard-Bell [Wed, 4 Mar 2020 16:07:35 +0000 (10:07 -0600)] 
trunk: Add init state to mirror the connection API's init state

Fixes a wide range of asserts

6 years agotrunk: Remove request count by state for states which cannot have requests
Arran Cudbard-Bell [Wed, 4 Mar 2020 16:03:47 +0000 (10:03 -0600)] 
trunk: Remove request count by state for states which cannot have requests

6 years agoconnection: Use a single event, and free it explicitly when the connection is freed
Arran Cudbard-Bell [Wed, 4 Mar 2020 16:03:06 +0000 (10:03 -0600)] 
connection: Use a single event, and free it explicitly when the connection is freed

Slightly simpler/more robust code

6 years agotrunk: Add function for removing connections from lists
Arran Cudbard-Bell [Wed, 4 Mar 2020 15:22:44 +0000 (09:22 -0600)] 
trunk: Add function for removing connections from lists

Deal with "fail" state properly.

6 years agotrunk: Allow connecting connections to be pruned
Arran Cudbard-Bell [Wed, 4 Mar 2020 15:20:40 +0000 (09:20 -0600)] 
trunk: Allow connecting connections to be pruned

6 years agotrunk: More verbose warning about request limits
Arran Cudbard-Bell [Wed, 4 Mar 2020 15:19:47 +0000 (09:19 -0600)] 
trunk: More verbose warning about request limits

6 years agoUpdate dictionary.erx (#3312)
Arran Cudbard-Bell [Wed, 4 Mar 2020 18:53:43 +0000 (12:53 -0600)] 
Update dictionary.erx (#3312)

Refreshed against upstream documentation linked in the comments.

Also attribute ERX-Cos-Shaping-Rate (177) seen on the wire.

6 years agoconnection: Close failed connections
Arran Cudbard-Bell [Wed, 4 Mar 2020 14:32:13 +0000 (08:32 -0600)] 
connection: Close failed connections

6 years agorlm_radius_udp: check_for_zombie does not nuke u->rr
Arran Cudbard-Bell [Wed, 4 Mar 2020 01:24:40 +0000 (19:24 -0600)] 
rlm_radius_udp: check_for_zombie does not nuke u->rr

6 years agorlm_radius_udp: Reset num_replies to 0 on timeout.
Arran Cudbard-Bell [Wed, 4 Mar 2020 01:22:39 +0000 (19:22 -0600)] 
rlm_radius_udp: Reset num_replies to 0 on timeout.

6 years agorlm_radius_udp: Simplify radius_retry_next call
Arran Cudbard-Bell [Wed, 4 Mar 2020 01:16:02 +0000 (19:16 -0600)] 
rlm_radius_udp: Simplify radius_retry_next call

6 years agorlm_radius_udp: Simplify retry_next call
Arran Cudbard-Bell [Wed, 4 Mar 2020 01:14:01 +0000 (19:14 -0600)] 
rlm_radius_udp: Simplify retry_next call

6 years agorlm_radius_udp: Formatting
Arran Cudbard-Bell [Wed, 4 Mar 2020 01:13:16 +0000 (19:13 -0600)] 
rlm_radius_udp: Formatting

6 years agorlm_radius_udp: Move udp_request_clear
Arran Cudbard-Bell [Wed, 4 Mar 2020 01:12:04 +0000 (19:12 -0600)] 
rlm_radius_udp: Move udp_request_clear

6 years agoAdd HEXDUMP[1-4] macros
Arran Cudbard-Bell [Wed, 4 Mar 2020 01:11:10 +0000 (19:11 -0600)] 
Add HEXDUMP[1-4] macros

6 years agorlm_radius: Make status_check.num_to_alive configurable
Arran Cudbard-Bell [Wed, 4 Mar 2020 01:10:55 +0000 (19:10 -0600)] 
rlm_radius: Make status_check.num_to_alive configurable

6 years agorlm_radius_udp: Add reset function for status_check packets
Arran Cudbard-Bell [Wed, 4 Mar 2020 01:09:55 +0000 (19:09 -0600)] 
rlm_radius_udp: Add reset function for status_check packets

6 years agorlm_radius_udp: Prioritise status check packets
Arran Cudbard-Bell [Wed, 4 Mar 2020 00:49:25 +0000 (18:49 -0600)] 
rlm_radius_udp: Prioritise status check packets

6 years agoAdd support to handle coredumps on FreeBSD (#3310)
Jorge Pereira [Wed, 4 Mar 2020 02:52:07 +0000 (23:52 -0300)] 
Add support to handle coredumps on FreeBSD (#3310)

6 years agotrunk: Typo
Arran Cudbard-Bell [Tue, 3 Mar 2020 23:21:04 +0000 (17:21 -0600)] 
trunk: Typo

6 years agotrunk: Expose more fields in the connection and trunk
Arran Cudbard-Bell [Tue, 3 Mar 2020 22:42:58 +0000 (16:42 -0600)] 
trunk: Expose more fields in the connection and trunk

Make the fields we do expose _CONST, so the API client can't mess with them.

6 years agorlm_radius_udp: Use PERROR so we get the error reason
Arran Cudbard-Bell [Tue, 3 Mar 2020 22:04:50 +0000 (16:04 -0600)] 
rlm_radius_udp: Use PERROR so we get the error reason

6 years agoschedule: Call module thread detach callbacks before stopping the event loop
Arran Cudbard-Bell [Tue, 3 Mar 2020 20:47:04 +0000 (14:47 -0600)] 
schedule: Call module thread detach callbacks before stopping the event loop

Fixes issue where we see multiple failures in the trunk API caused by the event loop exiting with requests still being processed.

6 years agoradmin fixes for systems without readline. Fixes #3309
Alan T. DeKok [Tue, 3 Mar 2020 20:20:36 +0000 (15:20 -0500)] 
radmin fixes for systems without readline.  Fixes #3309

6 years agorename to more consistent naming scheme, and use fr_vqp
Alan T. DeKok [Tue, 3 Mar 2020 18:44:13 +0000 (13:44 -0500)] 
rename to more consistent naming scheme, and use fr_vqp

instead of vmps

6 years agoconvert API to take explicit ctx and destination vps list
Alan T. DeKok [Tue, 3 Mar 2020 18:25:31 +0000 (13:25 -0500)] 
convert API to take explicit ctx and destination vps list

in preparation for moving to FR_TYPE_GROUP

6 years agoconvert API to take explicit ctx and destination vps list
Alan T. DeKok [Tue, 3 Mar 2020 18:09:25 +0000 (13:09 -0500)] 
convert API to take explicit ctx and destination vps list

in preparation for moving to FR_TYPE_GROUP

6 years agouse fr_radius_decode() in preparation for using FR_TYPE_GROUP
Alan T. DeKok [Tue, 3 Mar 2020 15:39:56 +0000 (10:39 -0500)] 
use fr_radius_decode() in preparation for using FR_TYPE_GROUP

6 years agooriginal can be NULL
Alan T. DeKok [Tue, 3 Mar 2020 15:39:17 +0000 (10:39 -0500)] 
original can be NULL

and if so, use packet vector as the decoding vector.

This changes makes the API easier to understand

6 years agoFix __lsan_default_suppressions() return on FreeBSD
Jorge Pereira [Tue, 3 Mar 2020 01:27:31 +0000 (22:27 -0300)] 
Fix __lsan_default_suppressions() return on FreeBSD

6 years agorlm_radius_udp: Write ID to the log too for help with debugging
Arran Cudbard-Bell [Tue, 3 Mar 2020 17:28:22 +0000 (11:28 -0600)] 
rlm_radius_udp: Write ID to the log too for help with debugging

6 years agoradius/base.c: Fixup docs for fr_radius_sign
Arran Cudbard-Bell [Tue, 3 Mar 2020 17:23:58 +0000 (11:23 -0600)] 
radius/base.c: Fixup docs for fr_radius_sign

6 years agotrack: Use RFC terminiology
Arran Cudbard-Bell [Tue, 3 Mar 2020 17:23:36 +0000 (11:23 -0600)] 
track: Use RFC terminiology

6 years agoMove more code into decode, and document
Arran Cudbard-Bell [Tue, 3 Mar 2020 17:23:07 +0000 (11:23 -0600)] 
Move more code into decode, and document

6 years agorlm_radius_udp: Unused field
Arran Cudbard-Bell [Tue, 3 Mar 2020 17:22:47 +0000 (11:22 -0600)] 
rlm_radius_udp: Unused field

6 years agoshut up stupid compiler
Alan T. DeKok [Tue, 3 Mar 2020 14:32:43 +0000 (09:32 -0500)] 
shut up stupid compiler

6 years agoFix rlm_unix build on FreeBSD
Jorge Pereira [Tue, 3 Mar 2020 02:43:46 +0000 (23:43 -0300)] 
Fix rlm_unix build on FreeBSD

6 years agoAlways initialise code
Arran Cudbard-Bell [Tue, 3 Mar 2020 14:31:07 +0000 (08:31 -0600)] 
Always initialise code

6 years agofixes for -Wunused when there's no readline history. Fixes #3307
Alan T. DeKok [Tue, 3 Mar 2020 13:23:21 +0000 (08:23 -0500)] 
fixes for -Wunused when there's no readline history.  Fixes #3307

6 years agorlm_radius_udp: Fix comparison of integers of different signs (#3305)
Jorge Pereira [Tue, 3 Mar 2020 03:23:33 +0000 (00:23 -0300)] 
rlm_radius_udp: Fix comparison of integers of different signs (#3305)

6 years agocall timegm for UTC times. Fixes #3304
Alan T. DeKok [Tue, 3 Mar 2020 02:09:09 +0000 (21:09 -0500)] 
call timegm for UTC times.  Fixes #3304

https://www.openssl.org/docs/man1.1.0/man3/ASN1_TIME_set_string.html

says:

ASN1_TIME_print() currently does not print out the time zone: it either prints out "GMT" or nothing. But all certificates complying with RFC5280 et al use GMT anyway.

6 years agorlm_radius_udp: Move common decode logic into its own function in preparation for...
Arran Cudbard-Bell [Tue, 3 Mar 2020 00:30:10 +0000 (18:30 -0600)] 
rlm_radius_udp: Move common decode logic into its own function in preparation for adding connection based status checks

6 years agorlm_radius_udp: Move allowed replies array
Arran Cudbard-Bell [Tue, 3 Mar 2020 00:28:51 +0000 (18:28 -0600)] 
rlm_radius_udp: Move allowed replies array

6 years agorlm_radius_udp: Produce log messages on write errors
Arran Cudbard-Bell [Tue, 3 Mar 2020 00:28:24 +0000 (18:28 -0600)] 
rlm_radius_udp: Produce log messages on write errors

Ooops, don't know how these were removed

6 years agoradius: More decode error codes
Arran Cudbard-Bell [Tue, 3 Mar 2020 00:26:19 +0000 (18:26 -0600)] 
radius: More decode error codes

6 years agorlm_radius_udp: Move conn_init
Arran Cudbard-Bell [Mon, 2 Mar 2020 21:19:29 +0000 (15:19 -0600)] 
rlm_radius_udp: Move conn_init

6 years agotrunk: Add last_read_success
Arran Cudbard-Bell [Mon, 2 Mar 2020 21:14:10 +0000 (15:14 -0600)] 
trunk: Add last_read_success

6 years agotrunk: Unused field
Arran Cudbard-Bell [Mon, 2 Mar 2020 15:26:53 +0000 (09:26 -0600)] 
trunk: Unused field

6 years agotrunk: Formatting
Arran Cudbard-Bell [Mon, 2 Mar 2020 15:23:20 +0000 (09:23 -0600)] 
trunk: Formatting

6 years agotrunk: Split FULL and INACTIVE states
Arran Cudbard-Bell [Mon, 2 Mar 2020 15:18:33 +0000 (09:18 -0600)] 
trunk: Split FULL and INACTIVE states

6 years agotrunk: Add back previous functionality to allow requests to be assigned to the backlo...
Arran Cudbard-Bell [Mon, 2 Mar 2020 15:17:17 +0000 (09:17 -0600)] 
trunk: Add back previous functionality to allow requests to be assigned to the backlog if the last event was a connection failure

6 years agotrunk: Prevent assert when req_cleanup_delay == 0
Arran Cudbard-Bell [Mon, 2 Mar 2020 15:05:32 +0000 (09:05 -0600)] 
trunk: Prevent assert when req_cleanup_delay == 0

6 years agorlm_radius: Test plan zombie state
Arran Cudbard-Bell [Mon, 2 Mar 2020 14:28:33 +0000 (08:28 -0600)] 
rlm_radius: Test plan zombie state

6 years agorlm_radius: Start of test plan for rlm_radius (incomplete)
Arran Cudbard-Bell [Mon, 2 Mar 2020 00:52:11 +0000 (18:52 -0600)] 
rlm_radius: Start of test plan for rlm_radius (incomplete)

6 years agorlm_radius_udp: Update comments
Arran Cudbard-Bell [Sun, 1 Mar 2020 20:08:42 +0000 (14:08 -0600)] 
rlm_radius_udp: Update comments

6 years agorlm_radius: status_check singular not plural
Arran Cudbard-Bell [Sun, 1 Mar 2020 19:44:01 +0000 (13:44 -0600)] 
rlm_radius: status_check singular not plural