]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
6 years agopoint to the correct field
Alan T. DeKok [Wed, 5 Feb 2020 13:35:07 +0000 (08:35 -0500)] 
point to the correct field

6 years agojust use "4" instead of more magic. Fixes #3277
Alan T. DeKok [Wed, 5 Feb 2020 00:40:46 +0000 (19:40 -0500)] 
just use "4" instead of more magic.  Fixes #3277

6 years agoupdate and document
Alan T. DeKok [Tue, 4 Feb 2020 21:38:55 +0000 (16:38 -0500)] 
update and document

6 years agoclean up
Alan T. DeKok [Tue, 4 Feb 2020 21:10:17 +0000 (16:10 -0500)] 
clean up

6 years agobetter checks for zombie period
Alan T. DeKok [Sun, 2 Feb 2020 02:31:20 +0000 (21:31 -0500)] 
better checks for zombie period

don't start if there's been a long delay since we last sent
a packet.

And if we haven't seen any replies, start zombie_period from
when we last sent a packet.

6 years agomove zombie checks to request_timer
Alan T. DeKok [Sun, 2 Feb 2020 02:22:58 +0000 (21:22 -0500)] 
move zombie checks to request_timer

so that they're only run when a request times out

6 years agoFix cancellation function to do the right think on requeue
Arran Cudbard-Bell [Sat, 1 Feb 2020 22:42:36 +0000 (17:42 -0500)] 
Fix cancellation function to do the right think on requeue

6 years agoRemove treq and request from the udp_request
Arran Cudbard-Bell [Sat, 1 Feb 2020 21:17:35 +0000 (16:17 -0500)] 
Remove treq and request from the udp_request

Fix parenting of the udp_request.  Should be parented from the treq because its lifetime is bound to the treq, not to the REQUEST *.

It doesn't _really_ matter here, but it does mean we can take advantage of the talloc_pool/freelist in the trunk.

Where it does matter is for trunk protocols which do cancellations, as the REQUEST * and the rctx might go away, but the preq needs to live on so we can cancel any upstream queries.

6 years agoExpose the tconn's underlying conn
Arran Cudbard-Bell [Sat, 1 Feb 2020 21:15:51 +0000 (16:15 -0500)] 
Expose the tconn's underlying conn

6 years agoNot needed
Arran Cudbard-Bell [Sat, 1 Feb 2020 20:21:54 +0000 (15:21 -0500)] 
Not needed

6 years agoMake additional fields in conns and treqs public
Arran Cudbard-Bell [Sat, 1 Feb 2020 20:20:13 +0000 (15:20 -0500)] 
Make additional fields in conns and treqs public

6 years agoand another one...
Arran Cudbard-Bell [Sat, 1 Feb 2020 17:11:08 +0000 (12:11 -0500)] 
and another one...

6 years agoFix more NULL issues
Arran Cudbard-Bell [Sat, 1 Feb 2020 16:53:31 +0000 (11:53 -0500)] 
Fix more NULL issues

6 years agoSprinkle nonnull
Arran Cudbard-Bell [Sat, 1 Feb 2020 16:28:53 +0000 (11:28 -0500)] 
Sprinkle nonnull

6 years agoRemove duplicate dst_ipaddr/dst_port fields
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:59:53 +0000 (10:59 -0500)] 
Remove duplicate dst_ipaddr/dst_port fields

6 years agoTypo
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:56:45 +0000 (10:56 -0500)] 
Typo

6 years agoPrint the connection name on failure
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:49:43 +0000 (10:49 -0500)] 
Print the connection name on failure

6 years agoUse the provided el in more places
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:47:34 +0000 (10:47 -0500)] 
Use the provided el in more places

One more to go....

6 years agoFixup I/O functions to use the tconn
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:46:48 +0000 (10:46 -0500)] 
Fixup I/O functions to use the tconn

Yes it makes the error case more complex, oh well.

6 years agoGet the conn from the tconn
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:45:25 +0000 (10:45 -0500)] 
Get the conn from the tconn

6 years agoAdd argument to test muxer
Arran Cudbard-Bell [Sat, 1 Feb 2020 15:00:27 +0000 (10:00 -0500)] 
Add argument to test muxer

6 years agoPass el to the muxer so that it can set timers.
Arran Cudbard-Bell [Sat, 1 Feb 2020 14:57:38 +0000 (09:57 -0500)] 
Pass el to the muxer so that it can set timers.

6 years agoupdate format of Proxy-State
Alan T. DeKok [Sat, 1 Feb 2020 14:31:28 +0000 (09:31 -0500)] 
update format of Proxy-State

4 octets of "my" random number
1 octet of how many of "my" Proxy-State we saw

this lets us know not only the admin configured a proxy loop,
but lets the module be doubly sure that it's a loop

6 years agoremove unused variable
Alan T. DeKok [Sat, 1 Feb 2020 14:24:05 +0000 (09:24 -0500)] 
remove unused variable

6 years agoremove unused variables
Alan T. DeKok [Sat, 1 Feb 2020 14:15:46 +0000 (09:15 -0500)] 
remove unused variables

6 years agomove zombie checks to request_fail
Alan T. DeKok [Sat, 1 Feb 2020 14:14:00 +0000 (09:14 -0500)] 
move zombie checks to request_fail

6 years agomove to use udp_connection_t
Alan T. DeKok [Sat, 1 Feb 2020 13:49:22 +0000 (08:49 -0500)] 
move to use udp_connection_t

as udp_handle_t may change over the lifetime of the request

6 years agoFix clang scan issues in the trunk code
Arran Cudbard-Bell [Sat, 1 Feb 2020 01:37:53 +0000 (20:37 -0500)] 
Fix clang scan issues in the trunk code

6 years agoNow used
Arran Cudbard-Bell [Sat, 1 Feb 2020 00:12:28 +0000 (19:12 -0500)] 
Now used

6 years agoRemove unused macro
Arran Cudbard-Bell [Fri, 31 Jan 2020 23:54:00 +0000 (18:54 -0500)] 
Remove unused macro

6 years agoAdd noreturn in acutest.h
Arran Cudbard-Bell [Fri, 31 Jan 2020 23:53:16 +0000 (18:53 -0500)] 
Add noreturn in acutest.h

6 years agoFix incompatible conversion (#3274)
Jorge Pereira [Fri, 31 Jan 2020 23:38:09 +0000 (20:38 -0300)] 
Fix incompatible conversion (#3274)

The udp_request_free() returns integer.

6 years agoFix typo with 'uctx' (#3275)
Jorge Pereira [Fri, 31 Jan 2020 23:25:15 +0000 (20:25 -0300)] 
Fix typo with 'uctx' (#3275)

6 years agofr_event_timer_delete doesn't need to take el
Arran Cudbard-Bell [Fri, 31 Jan 2020 22:35:52 +0000 (17:35 -0500)] 
fr_event_timer_delete doesn't need to take el

We should probably figure out something for the file descriptors too

6 years agoUse el where already available
Arran Cudbard-Bell [Fri, 31 Jan 2020 22:32:10 +0000 (17:32 -0500)] 
Use el where already available

6 years agomassive changes to switch to trunk API
Alan T. DeKok [Fri, 31 Jan 2020 19:12:55 +0000 (14:12 -0500)] 
massive changes to switch to trunk API

* basic send / receive works
* configuration works, but needs to be cleanup up and normalized
  * the mods-enabled/radius default config hasn't yet been updated
* zombie checks should work
* status-server should work

* it does not yet track "open to fail" states.  i.e. when it has
  multiple open / active connections that all fail, it should
  refuse to open new connections until one connection responds
  to status-server.

6 years agouse uint128.h
Alan T. DeKok [Thu, 30 Jan 2020 20:17:59 +0000 (15:17 -0500)] 
use uint128.h

6 years agoadd right-shift function.
Alan T. DeKok [Thu, 30 Jan 2020 20:17:27 +0000 (15:17 -0500)] 
add right-shift function.

6 years agodoxygen again
Matthew Newton [Thu, 30 Jan 2020 21:26:28 +0000 (21:26 +0000)] 
doxygen again

a bit faster than enabling macros in the Doxyfile

6 years agoAs per feedback from acutest
Arran Cudbard-Bell [Thu, 30 Jan 2020 20:25:07 +0000 (15:25 -0500)] 
As per feedback from acutest

6 years agoHave the parser allocate the connection config struct
Arran Cudbard-Bell [Thu, 30 Jan 2020 20:17:17 +0000 (15:17 -0500)] 
Have the parser allocate the connection config struct

6 years agoRevert "move sub-config to in-line struct"
Arran Cudbard-Bell [Thu, 30 Jan 2020 20:15:19 +0000 (15:15 -0500)] 
Revert "move sub-config to in-line struct"

This reverts commit 09e6ff81d3665fe3047ac86a49561c6a56444b0a.

6 years agoacutest needs to work with compilers other than gcc and clang
Arran Cudbard-Bell [Thu, 30 Jan 2020 20:14:46 +0000 (15:14 -0500)] 
acutest needs to work with compilers other than gcc and clang

6 years agomove sub-config to in-line struct
Alan T. DeKok [Thu, 30 Jan 2020 15:00:40 +0000 (10:00 -0500)] 
move sub-config to in-line struct

the configuration parser for sub-structures / sub-sections
does NOT take a pointer to a pointer.  Instead, it takes a pointer
to a struct.  So we need to include the struct in-line.

Plus, the config parser is called after the module instance is
allocated, but before the module can do anything to it.  So the
trunk code cannot contain a pointer to a sub-struct, because
there is no way to properly initialize the pointer.

6 years agoBuild trunk test utility as part of the standard build
Arran Cudbard-Bell [Thu, 30 Jan 2020 19:20:35 +0000 (14:20 -0500)] 
Build trunk test utility as part of the standard build

6 years agoFix warnings, sync with upstream
Arran Cudbard-Bell [Thu, 30 Jan 2020 19:20:10 +0000 (14:20 -0500)] 
Fix warnings, sync with upstream

6 years agobetter way to fix doxygen
Matthew Newton [Thu, 30 Jan 2020 18:58:05 +0000 (18:58 +0000)] 
better way to fix doxygen

it seems to make the doxygen run a bit slower, but should
avoid any compiler issues

6 years agoAdd semicolon to stop doxygen from getting confused
Matthew Newton [Thu, 30 Jan 2020 17:12:14 +0000 (17:12 +0000)] 
Add semicolon to stop doxygen from getting confused

Hopefully no compilers will complain...

6 years agoMove 128bit math functions into a common library
Arran Cudbard-Bell [Thu, 30 Jan 2020 17:01:34 +0000 (12:01 -0500)] 
Move 128bit math functions into a common library

6 years agoRevert "Reduce graph_max_nodes"
Matthew Newton [Thu, 30 Jan 2020 12:20:00 +0000 (12:20 +0000)] 
Revert "Reduce graph_max_nodes"

Wasn't the issue; make was stuck before calling doxygen.

This reverts commit 727c4a7cc38bbe05948fc7b2a75adc7643c260f7.

6 years agofix find depth arg so make doesn't spin cpu
Matthew Newton [Thu, 30 Jan 2020 12:07:07 +0000 (12:07 +0000)] 
fix find depth arg so make doesn't spin cpu

6 years agoImplement public toggle for preventing management of connections
Arran Cudbard-Bell [Thu, 30 Jan 2020 05:25:16 +0000 (00:25 -0500)] 
Implement public toggle for preventing management of connections

6 years agoImplement limit on number of connecting connections
Arran Cudbard-Bell [Thu, 30 Jan 2020 05:24:52 +0000 (00:24 -0500)] 
Implement limit on number of connecting connections

6 years agotrunk_requests_per_connection should be called after the connection is inserted into...
Arran Cudbard-Bell [Thu, 30 Jan 2020 04:46:45 +0000 (23:46 -0500)] 
trunk_requests_per_connection should be called after the connection is inserted into it its new list, as that's what's used to track connection state counts

6 years agoReduce graph_max_nodes
Arran Cudbard-Bell [Thu, 30 Jan 2020 00:54:53 +0000 (19:54 -0500)] 
Reduce graph_max_nodes

6 years agoWhitespace fixes
Arran Cudbard-Bell [Tue, 28 Jan 2020 16:11:35 +0000 (11:11 -0500)] 
Whitespace fixes

6 years agomove to active heap before counting connections in different states
Alan T. DeKok [Wed, 29 Jan 2020 20:04:06 +0000 (15:04 -0500)] 
move to active heap before counting connections in different states

6 years agocast intermediates to 128-bit values, and only shift off 32 bits
Alan T. DeKok [Wed, 29 Jan 2020 18:18:51 +0000 (13:18 -0500)] 
cast intermediates to 128-bit values, and only shift off 32 bits

because "scale" is a 64-bit fixed number, with 32 bits of fraction.
so we want to get rid of that fraction from the multiplication
result.

6 years agomore comments and handle missed timers
Alan T. DeKok [Tue, 28 Jan 2020 20:09:29 +0000 (15:09 -0500)] 
more comments and handle missed timers

6 years agoword smithing up to about Section 2
Alan T. DeKok [Tue, 28 Jan 2020 13:46:57 +0000 (08:46 -0500)] 
word smithing up to about Section 2

6 years agoadded retransmission API.
Alan T. DeKok [Mon, 27 Jan 2020 23:13:13 +0000 (18:13 -0500)] 
added retransmission API.

Used in multiple protocols now.

6 years agoexpose fr_trunk_connection_state_t so that callers can use it
Alan T. DeKok [Fri, 24 Jan 2020 13:34:52 +0000 (08:34 -0500)] 
expose fr_trunk_connection_state_t so that callers can use it

6 years agodocument priority
Alan T. DeKok [Fri, 24 Jan 2020 13:06:23 +0000 (08:06 -0500)] 
document priority

6 years agoupdate comments and stop when we see a TLV
Alan T. DeKok [Wed, 22 Jan 2020 18:51:35 +0000 (13:51 -0500)] 
update comments and stop when we see a TLV

6 years agoradclient: fix "-i" option
Bjørn Mork [Wed, 10 Apr 2019 19:25:39 +0000 (21:25 +0200)] 
radclient: fix "-i" option

Signed-off-by: Bjørn Mork <bjorn@mork.no>
6 years agoRevert "radclient "-i" didn't work, so just remove it to save confusion"
Bjørn Mork [Wed, 10 Apr 2019 19:25:13 +0000 (21:25 +0200)] 
Revert "radclient "-i" didn't work, so just remove it to save confusion"

This reverts commit ea5b99abaab09645c2a64f27d90d7d324c278684.

Signed-off-by: Bjørn Mork <bjorn@mork.no>
6 years agoSQL IP Pools howto
Terry Burton [Sat, 25 Jan 2020 03:27:57 +0000 (03:27 +0000)] 
SQL IP Pools howto

6 years agoTypo
Arran Cudbard-Bell [Fri, 24 Jan 2020 23:50:45 +0000 (18:50 -0500)] 
Typo

6 years agoAdd more comments about signalling
Arran Cudbard-Bell [Fri, 24 Jan 2020 21:50:35 +0000 (16:50 -0500)] 
Add more comments about signalling

6 years agosqlippool fixes (#3271)
Terry Burton [Fri, 24 Jan 2020 20:40:20 +0000 (20:40 +0000)] 
sqlippool fixes (#3271)

* Reference the sqlippool module by its name in the default site

The default configuraton for the sqlippool module creates the module
directly rather using a named instance so the main_pool name does not
resolve to a module.

Pools are usually differentiated using the Pool-Name control attribute
such that only a single instance is normally required. Multiple
instances are only required where multiple pool have different backend
databases or IP allocation policies (queries, etc.)

* sqlippool: Fix check that the referenced module is an SQL module

Was testing the name of the driver rather than that the module was an
instance of rlm_sql.

* sqlippool: Qualify the value of attribute_name

6 years agoUse talloc_get_type_abort_const
Arran Cudbard-Bell [Fri, 24 Jan 2020 01:57:00 +0000 (20:57 -0500)] 
Use talloc_get_type_abort_const

6 years agoNeed to do this in the per-connection queue too
Arran Cudbard-Bell [Fri, 24 Jan 2020 01:35:17 +0000 (20:35 -0500)] 
Need to do this in the per-connection queue too

6 years agoPrioritse using the preq not the treq.
Arran Cudbard-Bell [Fri, 24 Jan 2020 01:31:36 +0000 (20:31 -0500)] 
Prioritse using the preq not the treq.

6 years agoAdd requeue function
Arran Cudbard-Bell [Thu, 23 Jan 2020 20:43:33 +0000 (15:43 -0500)] 
Add requeue function

6 years agoOracle sqlippools: Many query fixes and align schema and SP with other drivers (...
Terry Burton [Thu, 23 Jan 2020 19:22:00 +0000 (19:22 +0000)] 
Oracle sqlippools: Many query fixes and align schema and SP with other drivers (#3270)

SP-based IP allocation giving of the order of 500 allocs/sec without
specific DB tuning. (Using Docker on a development laptop.)

6 years agofix JSON example, whitespace
Matthew Newton [Wed, 22 Jan 2020 17:45:05 +0000 (17:45 +0000)] 
fix JSON example, whitespace

6 years agoMSSQL schema extensions for processing radacct: Data usage per period (#3259) (#3263)
Terry Burton [Tue, 21 Jan 2020 02:21:29 +0000 (02:21 +0000)] 
MSSQL schema extensions for processing radacct: Data usage per period (#3259) (#3263)

Provides a table, indexes and SP for extracting per-user data usage within
arbitrary periods using the standard radacct table entries.

6 years agoPeriod-based data usage reporting howto (#3267)
Terry Burton [Tue, 21 Jan 2020 02:21:01 +0000 (02:21 +0000)] 
Period-based data usage reporting howto (#3267)

* Period-based data usage reporting howto

* Data usage howto: Tidy. Better markup. Move subordinate to SQL module howto.

6 years agoFix installation for template files
Arran Cudbard-Bell [Mon, 20 Jan 2020 17:59:21 +0000 (12:59 -0500)] 
Fix installation for template files

6 years agoReturn from fr_jason_afrom_pair_list should not be const
Arran Cudbard-Bell [Mon, 20 Jan 2020 17:34:32 +0000 (12:34 -0500)] 
Return from fr_jason_afrom_pair_list should not be const

6 years agoConvert templates.conf to a directory, include it within radiusd.conf again
Arran Cudbard-Bell [Mon, 20 Jan 2020 17:34:09 +0000 (12:34 -0500)] 
Convert templates.conf to a directory, include it within radiusd.conf again

Not sure why the include was removed TBH

6 years agoSQLite schema extensions and script for processing radacct: Data usage per period...
Terry Burton [Sat, 18 Jan 2020 20:48:30 +0000 (20:48 +0000)] 
SQLite schema extensions and script for processing radacct: Data usage per period (#3265)

Provides a table, indexes and SP for extracting per-user data usage within
arbitrary periods using the standard radacct table entries.

6 years agoreturn if alloc failed
Matthew Newton [Fri, 17 Jan 2020 22:50:51 +0000 (22:50 +0000)] 
return if alloc failed

6 years agoOracle schema extensions for processing radacct: Data usage per period (#3259)
Terry Burton [Fri, 17 Jan 2020 21:36:10 +0000 (21:36 +0000)] 
Oracle schema extensions for processing radacct: Data usage per period (#3259)

Provides a table, indexes and SP for extracting per-user data usage within
arbitrary periods using the standard radacct table entries.

6 years agoPostgreSQL schema extensions for processing radacct: Data usage per period (#3258)
Terry Burton [Fri, 17 Jan 2020 21:36:02 +0000 (21:36 +0000)] 
PostgreSQL schema extensions for processing radacct: Data usage per period (#3258)

Provides a table, index and SP for extracting per-user data usage within
arbitrary periods using the standard radacct table entries.

6 years agoprocess-radacct MySQL: Example of calling the SP (#3257)
Terry Burton [Fri, 17 Jan 2020 21:35:51 +0000 (21:35 +0000)] 
process-radacct MySQL: Example of calling the SP (#3257)

6 years agoencode all required struct fields
Alan T. DeKok [Fri, 17 Jan 2020 20:12:40 +0000 (15:12 -0500)] 
encode all required struct fields

i.e. if a struct member is missing at the end of a VP list,
then we still need to encode it.  Silently truncating the struct
is not an option.

6 years agotest multiple rules in the same group
Alan T. DeKok [Fri, 17 Jan 2020 19:50:02 +0000 (14:50 -0500)] 
test multiple rules in the same group

6 years agoclarify text
Alan T. DeKok [Fri, 17 Jan 2020 19:46:41 +0000 (14:46 -0500)] 
clarify text

6 years agoAdd tests for DHCPv6 / rfc7600
Jorge Pereira [Fri, 17 Jan 2020 15:55:24 +0000 (12:55 -0300)] 
Add tests for DHCPv6 / rfc7600

Add for section 4.9.  Provisioning 4rd Parameters to CEs

6 years agoAdd tests for DHCPv6 / rfc7078
Jorge Pereira [Fri, 17 Jan 2020 17:36:44 +0000 (14:36 -0300)] 
Add tests for DHCPv6 / rfc7078

6 years agofix typo
Alan T. DeKok [Fri, 17 Jan 2020 17:43:16 +0000 (12:43 -0500)] 
fix typo

6 years agochildren are already parented from 'vp'
Alan T. DeKok [Fri, 17 Jan 2020 16:58:25 +0000 (11:58 -0500)] 
children are already parented from 'vp'

6 years agomore checks / processing of FR_TYPE_GROUP
Alan T. DeKok [Fri, 17 Jan 2020 15:07:40 +0000 (10:07 -0500)] 
more checks / processing of FR_TYPE_GROUP

6 years agoavoid strlen, as fr_pair_value_from_str() will figure it out
Alan T. DeKok [Fri, 17 Jan 2020 15:20:10 +0000 (10:20 -0500)] 
avoid strlen, as fr_pair_value_from_str() will figure it out

6 years agoconvert IA-PD-Options to data type 'group'
Alan T. DeKok [Thu, 16 Jan 2020 20:27:13 +0000 (15:27 -0500)] 
convert IA-PD-Options to data type 'group'

6 years agoFound an updated Fortinet dictionary. Added details to FreeRADIUS 4.x (#3247)
Stefan Paetow [Fri, 17 Jan 2020 02:47:13 +0000 (02:47 +0000)] 
Found an updated Fortinet dictionary. Added details to FreeRADIUS 4.x (#3247)

6 years agoUpdate copyrights on time code
Arran Cudbard-Bell [Fri, 17 Jan 2020 02:08:06 +0000 (21:08 -0500)] 
Update copyrights on time code

6 years agoOnly retrieve the time once in fr_time_sync
Arran Cudbard-Bell [Fri, 17 Jan 2020 02:00:52 +0000 (21:00 -0500)] 
Only retrieve the time once in fr_time_sync

6 years agoUpdated Aerohive (Extreme) dictionary as per their KB (#3248)
Stefan Paetow [Thu, 16 Jan 2020 23:58:05 +0000 (23:58 +0000)] 
Updated Aerohive (Extreme) dictionary as per their KB (#3248)