]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
6 years agofix this, too
Alan T. DeKok [Thu, 26 Dec 2019 18:41:43 +0000 (13:41 -0500)] 
fix this, too

6 years agoremove unused field and use correct data types for time delta
Alan T. DeKok [Thu, 26 Dec 2019 18:05:11 +0000 (13:05 -0500)] 
remove unused field and use correct data types for time delta

6 years agoremove "original_recv_time", and fix APIs using it
Alan T. DeKok [Thu, 26 Dec 2019 18:02:33 +0000 (13:02 -0500)] 
remove "original_recv_time", and fix APIs using it

we should rely on dedup trees, instead of reaching across
threads.

6 years agowe already have proto_vmps_udp.c
Alan T. DeKok [Thu, 26 Dec 2019 17:00:21 +0000 (12:00 -0500)] 
we already have proto_vmps_udp.c

This file doesn't belong

6 years agoremove field which is not needed
Alan T. DeKok [Thu, 26 Dec 2019 16:46:16 +0000 (11:46 -0500)] 
remove field which is not needed

6 years agoclarify the logic in run_request
Alan T. DeKok [Thu, 26 Dec 2019 16:42:49 +0000 (11:42 -0500)] 
clarify the logic in run_request

if the channel isn't active, we can cancel the request, but
there's no point in sending the reply.

6 years agoAdd tests for 'radmin> stats network'
Jorge Pereira [Tue, 24 Dec 2019 20:10:53 +0000 (17:10 -0300)] 
Add tests for 'radmin> stats network'

6 years agoAdd tests for 'radmin> stats'
Jorge Pereira [Tue, 24 Dec 2019 19:57:18 +0000 (16:57 -0300)] 
Add tests for 'radmin> stats'

6 years agoFix float point exception in radmin
Jorge Pereira [Tue, 24 Dec 2019 19:56:56 +0000 (16:56 -0300)] 
Fix float point exception in radmin

6 years agowhoops, set status, too
Alan T. DeKok [Tue, 24 Dec 2019 19:26:43 +0000 (14:26 -0500)] 
whoops, set status, too

6 years agosend ACK on empty packets
Alan T. DeKok [Tue, 24 Dec 2019 19:16:18 +0000 (14:16 -0500)] 
send ACK on empty packets

6 years agodon't run blank commands
Alan T. DeKok [Tue, 24 Dec 2019 19:14:37 +0000 (14:14 -0500)] 
don't run blank commands

6 years agoprint out better stats
Alan T. DeKok [Sun, 22 Dec 2019 17:41:41 +0000 (12:41 -0500)] 
print out better stats

6 years agoformat output consistently
Alan T. DeKok [Sun, 22 Dec 2019 17:35:36 +0000 (12:35 -0500)] 
format output consistently

6 years agospelling mistake
Alan T. DeKok [Sun, 22 Dec 2019 16:32:42 +0000 (11:32 -0500)] 
spelling mistake

6 years agoupdate run_time to not be always zero.
Alan T. DeKok [Sun, 22 Dec 2019 16:31:43 +0000 (11:31 -0500)] 
update run_time to not be always zero.

6 years agoupdate wait time correctly
Alan T. DeKok [Sun, 22 Dec 2019 16:30:25 +0000 (11:30 -0500)] 
update wait time correctly

6 years agocalculate run time from when we last resumed
Alan T. DeKok [Sun, 22 Dec 2019 16:27:55 +0000 (11:27 -0500)] 
calculate run time from when we last resumed

6 years agoclarifying comments
Alan T. DeKok [Sun, 22 Dec 2019 12:37:24 +0000 (07:37 -0500)] 
clarifying comments

6 years agounused variable
Alan T. DeKok [Sat, 21 Dec 2019 14:29:41 +0000 (09:29 -0500)] 
unused variable

6 years agoadd pre_event for single-threaded mode
Alan T. DeKok [Sat, 21 Dec 2019 13:43:09 +0000 (08:43 -0500)] 
add pre_event for single-threaded mode

so that the worker can restart yielded / resumed requests

6 years agoFix memory leak in radmin
Jorge Pereira [Fri, 20 Dec 2019 20:37:02 +0000 (17:37 -0300)] 
Fix memory leak in radmin

my_readline() needs radmin_free() to avoid leaks.

6 years agoAdd radmin tests for 'show profile'
Jorge Pereira [Fri, 20 Dec 2019 17:08:54 +0000 (14:08 -0300)] 
Add radmin tests for 'show profile'

6 years agovariable is unused
Alan T. DeKok [Fri, 20 Dec 2019 17:22:46 +0000 (12:22 -0500)] 
variable is unused

6 years agoadd post-event only for single-threaded mode
Alan T. DeKok [Fri, 20 Dec 2019 16:51:14 +0000 (11:51 -0500)] 
add post-event only for single-threaded mode

6 years agodon't spam the output with 1000's of similar debug messages
Alan T. DeKok [Fri, 20 Dec 2019 16:45:16 +0000 (11:45 -0500)] 
don't spam the output with 1000's of similar debug messages

6 years agowhitespace
Alan T. DeKok [Fri, 20 Dec 2019 16:07:26 +0000 (11:07 -0500)] 
whitespace

6 years agomove "run request" to the main worker loop
Alan T. DeKok [Fri, 20 Dec 2019 16:04:25 +0000 (11:04 -0500)] 
move "run request" to the main worker loop

and out of the post_event handler.

6 years agoget rid of "to_decode" heap.
Alan T. DeKok [Fri, 20 Dec 2019 15:58:43 +0000 (10:58 -0500)] 
get rid of "to_decode" heap.

Just immediately decode packets, and put them into the runnable queue.

6 years agoremove 'localized' heap.
Alan T. DeKok [Fri, 20 Dec 2019 15:53:10 +0000 (10:53 -0500)] 
remove 'localized' heap.

If the worker is busy, it's not servicing ANY packets. So we don't
need this heap.

6 years agoBetter fixes. Helps with #3219
Alan T. DeKok [Fri, 20 Dec 2019 13:32:12 +0000 (08:32 -0500)] 
Better fixes.  Helps with #3219

6 years agoadd "show profile", and don't allow "profile on" multiple times
Alan T. DeKok [Fri, 20 Dec 2019 13:26:51 +0000 (08:26 -0500)] 
add "show profile", and don't allow "profile on" multiple times

6 years agoavoid cursors where they're not necessary
Alan T. DeKok [Thu, 19 Dec 2019 21:36:20 +0000 (16:36 -0500)] 
avoid cursors where they're not necessary

6 years agoDon't hardcode the src ip address
Arran Cudbard-Bell [Fri, 20 Dec 2019 02:08:31 +0000 (18:08 -0800)] 
Don't hardcode the src ip address

The DHCPv4 code has multiple ways of discovering the correct src IP.  Hardcoding the src IP to 127.0.0.1 means sending responses will fail will obscure errors, which is frustrating.

The server works out-of-the-box biding to '*'.

6 years agoQuiet compiler
Arran Cudbard-Bell [Fri, 20 Dec 2019 00:45:14 +0000 (16:45 -0800)] 
Quiet compiler

6 years agoThis is only an indication *IF* we're waiting
Arran Cudbard-Bell [Thu, 19 Dec 2019 23:24:34 +0000 (15:24 -0800)] 
This is only an indication *IF* we're waiting

6 years agoAlways initialise priority
Arran Cudbard-Bell [Thu, 19 Dec 2019 21:57:45 +0000 (13:57 -0800)] 
Always initialise priority

6 years agoSimplify logic slightly in fr_event_corral
Arran Cudbard-Bell [Thu, 19 Dec 2019 21:53:26 +0000 (13:53 -0800)] 
Simplify logic slightly in fr_event_corral

6 years agoAdd notes on why we call el->time() again
Arran Cudbard-Bell [Thu, 19 Dec 2019 21:52:34 +0000 (13:52 -0800)] 
Add notes on why we call el->time() again

6 years agoNeed to pass GPERFTOOLS_LDFLAGS too
Arran Cudbard-Bell [Thu, 19 Dec 2019 21:17:08 +0000 (13:17 -0800)] 
Need to pass GPERFTOOLS_LDFLAGS too

6 years agoreset time after doing significant work, and before running timers
Alan T. DeKok [Thu, 19 Dec 2019 20:40:12 +0000 (15:40 -0500)] 
reset time after doing significant work, and before running timers

6 years agotry to account for time sleeping
Alan T. DeKok [Thu, 19 Dec 2019 20:36:00 +0000 (15:36 -0500)] 
try to account for time sleeping

6 years agoreturn correct value from all situations
Alan T. DeKok [Thu, 19 Dec 2019 19:37:17 +0000 (14:37 -0500)] 
return correct value from all situations

6 years agoif we get a timeout in kevent(), there MUST be timer events
Alan T. DeKok [Thu, 19 Dec 2019 18:49:00 +0000 (13:49 -0500)] 
if we get a timeout in kevent(), there MUST be timer events

6 years agoremove unused pre-event
Alan T. DeKok [Thu, 19 Dec 2019 18:45:55 +0000 (13:45 -0500)] 
remove unused pre-event

it's only used if the worker is suppressing signals to the
network side.  Since we always signal, this code isn't necessary

6 years agoonly run pre_callbacks if the caller tells us to wait
Alan T. DeKok [Thu, 19 Dec 2019 18:43:07 +0000 (13:43 -0500)] 
only run pre_callbacks if the caller tells us to wait

only the network & worker threads use the pre callbacks.  And,
the only thing they do is lower the wait time.  So if we're told
to not wait, then don't bother asking caller if the timers
should be lowered.

6 years agono need to check for a bool > 0. It is, if it's true
Alan T. DeKok [Thu, 19 Dec 2019 18:42:52 +0000 (13:42 -0500)] 
no need to check for a bool > 0.  It is, if it's true

6 years agotry to simplify wait / timer logic
Alan T. DeKok [Thu, 19 Dec 2019 18:38:08 +0000 (13:38 -0500)] 
try to simplify wait / timer logic

6 years agonotes on profile builds
Alan T. DeKok [Thu, 19 Dec 2019 16:27:47 +0000 (11:27 -0500)] 
notes on profile builds

6 years agodon't need a special profile build
Alan T. DeKok [Thu, 19 Dec 2019 16:24:12 +0000 (11:24 -0500)] 
don't need a special profile build

6 years agoLink radiusd with -lprofiler when gperftools is in use
Terry Burton [Thu, 19 Dec 2019 18:35:22 +0000 (18:35 +0000)] 
Link radiusd with -lprofiler when gperftools is in use

6 years agoFix memory leak in rlm_python (Python 3.x)
Jorge Pereira [Fri, 13 Dec 2019 21:52:23 +0000 (18:52 -0300)] 
Fix memory leak in rlm_python (Python 3.x)

We should release 'inst->module' in Python 3 too.

6 years agohandle is always set. Found by PVS-Studio
Alan T. DeKok [Thu, 19 Dec 2019 15:05:02 +0000 (10:05 -0500)] 
handle is always set.  Found by PVS-Studio

6 years agomove more assignments
Alan T. DeKok [Thu, 19 Dec 2019 15:04:00 +0000 (10:04 -0500)] 
move more assignments

6 years agocheck for Access-Reject, not Access-Accept. Found by PVS-Studio
Alan T. DeKok [Thu, 19 Dec 2019 14:48:17 +0000 (09:48 -0500)] 
check for Access-Reject, not Access-Accept.  Found by PVS-Studio

6 years agocheck before dereferencing. Found by PVS-Studio
Alan T. DeKok [Thu, 19 Dec 2019 14:44:16 +0000 (09:44 -0500)] 
check before dereferencing.  Found by PVS-Studio

6 years agocheck variable before dereferencing it. Found by PVS-Studio
Alan T. DeKok [Thu, 19 Dec 2019 14:23:01 +0000 (09:23 -0500)] 
check variable before dereferencing it.  Found by PVS-Studio

6 years agofix check for UTF-8 characters. Found by PVS-Studio
Alan T. DeKok [Thu, 19 Dec 2019 14:18:49 +0000 (09:18 -0500)] 
fix check for UTF-8 characters.  Found by PVS-Studio

6 years agoadd "set profile status on/off [filename]" command
Alan T. DeKok [Thu, 19 Dec 2019 14:03:20 +0000 (09:03 -0500)] 
add "set profile status on/off [filename]" command

6 years agoThe talloc_* options should be FR_TYPE_HIDDEN (#3217)
Jorge Pereira [Wed, 18 Dec 2019 20:26:05 +0000 (17:26 -0300)] 
The talloc_* options should be FR_TYPE_HIDDEN (#3217)

* Add new 'FR_TYPE_HIDDEN' type

It's helpful to set the developer options.

* The talloc_* options should be FR_TYPE_HIDDEN

* Skip the 'FR_TYPE_HIDDEN' options

6 years agoauth logs are INFO, not (by default) EMERGENCY
Alan T. DeKok [Wed, 18 Dec 2019 19:31:41 +0000 (14:31 -0500)] 
auth logs are INFO, not (by default) EMERGENCY

6 years agoadd "to do" list for timers, too
Alan T. DeKok [Wed, 18 Dec 2019 15:49:42 +0000 (10:49 -0500)] 
add "to do" list for timers, too

New timers were added while running timers. Instead of
being added to the main heap, they were added to the
"in progress" list.  We can now add them to the main
heap.

Doing it this way prevents the server from running
into an infinite loop when it takes a long time to
service FD events.  The timer callback MAY add a new
timer which is in the past.  So the above loop could
run forever.

6 years agois broken on travis. Disabling until we track it down
Alan T. DeKok [Wed, 18 Dec 2019 14:57:12 +0000 (09:57 -0500)] 
is broken on travis.  Disabling until we track it down

6 years agoset min / max size for network ring buffers
Alan T. DeKok [Wed, 18 Dec 2019 14:50:15 +0000 (09:50 -0500)] 
set min / max size for network ring buffers

6 years agoUpdated by 'make dictionary.format'
Jorge Pereira [Wed, 18 Dec 2019 00:31:54 +0000 (21:31 -0300)] 
Updated by 'make dictionary.format'

6 years agouse L_AUTH for authentication logs
Alan T. DeKok [Wed, 18 Dec 2019 14:36:49 +0000 (09:36 -0500)] 
use L_AUTH for authentication logs

6 years agore-add L_AUTH
Alan T. DeKok [Wed, 18 Dec 2019 14:25:26 +0000 (09:25 -0500)] 
re-add L_AUTH

6 years agoNeed to use the 64bit format specifier
Arran Cudbard-Bell [Wed, 18 Dec 2019 05:48:11 +0000 (12:48 +0700)] 
Need to use the 64bit format specifier

6 years agoRedis doesn't like it when you pass the time in nanoseconds
Arran Cudbard-Bell [Wed, 18 Dec 2019 05:46:02 +0000 (12:46 +0700)] 
Redis doesn't like it when you pass the time in nanoseconds

6 years agovb_date was converted to microsecond reslution but rlm_cache wasn't updated to handle...
Arran Cudbard-Bell [Wed, 18 Dec 2019 04:20:29 +0000 (11:20 +0700)] 
vb_date was converted to microsecond reslution but rlm_cache wasn't updated to handle that

6 years agovb_date is microseconds since the epoch, i.e. an external time, and so SHOULD NOT...
Arran Cudbard-Bell [Wed, 18 Dec 2019 03:46:24 +0000 (10:46 +0700)] 
vb_date is microseconds since the epoch, i.e. an external time, and so SHOULD NOT HAVE OUR INTERNAL TIME SUBTRACTED FROM IT

6 years ago...and here
Arran Cudbard-Bell [Wed, 18 Dec 2019 03:33:25 +0000 (10:33 +0700)] 
...and here

6 years agoUse the correct type
Arran Cudbard-Bell [Wed, 18 Dec 2019 03:30:43 +0000 (10:30 +0700)] 
Use the correct type

6 years agoAdd missing field. Fixes #3215
Alan T. DeKok [Wed, 18 Dec 2019 01:08:53 +0000 (20:08 -0500)] 
Add missing field.  Fixes #3215

6 years agoUpdated by 'make doc.check'
Jorge Pereira [Tue, 17 Dec 2019 17:59:19 +0000 (14:59 -0300)] 
Updated by 'make doc.check'

6 years agoUpdate scripts/build/missing-raddb-mod-conf.txt db
Jorge Pereira [Tue, 17 Dec 2019 19:26:54 +0000 (16:26 -0300)] 
Update scripts/build/missing-raddb-mod-conf.txt db

6 years agoAdd capability to verify undocumented 'FR_CONF.*'
Jorge Pereira [Tue, 17 Dec 2019 19:26:50 +0000 (16:26 -0300)] 
Add capability to verify undocumented 'FR_CONF.*'

6 years agoVerify the 'output' parameter
Jorge Pereira [Tue, 17 Dec 2019 19:30:46 +0000 (16:30 -0300)] 
Verify the 'output' parameter

6 years agoUpdate scripts/build/missing-xlat-doc.txt db
Jorge Pereira [Tue, 17 Dec 2019 19:22:09 +0000 (16:22 -0300)] 
Update scripts/build/missing-xlat-doc.txt db

6 years agodon't debug print pairs twice
Alan T. DeKok [Tue, 17 Dec 2019 16:14:34 +0000 (11:14 -0500)] 
don't debug print pairs twice

6 years agomove parsing of workers / threads into scheduler
Alan T. DeKok [Tue, 17 Dec 2019 16:01:33 +0000 (11:01 -0500)] 
move parsing of workers / threads into scheduler

6 years agotypo
Alan T. DeKok [Tue, 17 Dec 2019 15:47:16 +0000 (10:47 -0500)] 
typo

6 years agoparse information for debugging
Alan T. DeKok [Tue, 17 Dec 2019 15:01:57 +0000 (10:01 -0500)] 
parse information for debugging

6 years agopass "thread" CONF_SECTION to scheduler
Alan T. DeKok [Tue, 17 Dec 2019 14:49:10 +0000 (09:49 -0500)] 
pass "thread" CONF_SECTION to scheduler

and on to other things

6 years agoprovisions for print out statistics
Alan T. DeKok [Tue, 17 Dec 2019 14:24:41 +0000 (09:24 -0500)] 
provisions for print out statistics

6 years agoAPI to dump stats to a log
Alan T. DeKok [Tue, 17 Dec 2019 14:17:41 +0000 (09:17 -0500)] 
API to dump stats to a log

6 years agoAPI to dump stats to a log
Alan T. DeKok [Tue, 17 Dec 2019 14:17:25 +0000 (09:17 -0500)] 
API to dump stats to a log

6 years agomove stats to stats structure
Alan T. DeKok [Tue, 17 Dec 2019 13:45:51 +0000 (08:45 -0500)] 
move stats to stats structure

6 years agoNot necessarily an error
Arran Cudbard-Bell [Tue, 17 Dec 2019 12:38:41 +0000 (19:38 +0700)] 
Not necessarily an error

6 years agoPrint out the actual errors instead of just ignoring them
Arran Cudbard-Bell [Tue, 17 Dec 2019 10:47:11 +0000 (17:47 +0700)] 
Print out the actual errors instead of just ignoring them

6 years agoAdd sanity checks to make sure the channel we're signalling on is open
Arran Cudbard-Bell [Tue, 17 Dec 2019 09:37:18 +0000 (16:37 +0700)] 
Add sanity checks to make sure the channel we're signalling on is open

6 years agoFix worker name
Arran Cudbard-Bell [Tue, 17 Dec 2019 09:36:52 +0000 (16:36 +0700)] 
Fix worker name

6 years agoPrint login success/failure messages at the correct point
Arran Cudbard-Bell [Tue, 17 Dec 2019 08:32:39 +0000 (15:32 +0700)] 
Print login success/failure messages at the correct point

6 years agoMore information would be helpful
Arran Cudbard-Bell [Tue, 17 Dec 2019 08:32:13 +0000 (15:32 +0700)] 
More information would be helpful

6 years agoMissed fd delete
Arran Cudbard-Bell [Tue, 17 Dec 2019 08:04:06 +0000 (15:04 +0700)] 
Missed fd delete

6 years agoRemove dependencie on wbclient
Arran Cudbard-Bell [Tue, 17 Dec 2019 04:33:50 +0000 (11:33 +0700)] 
Remove dependencie on wbclient

6 years agoMake wbclient optional
Arran Cudbard-Bell [Tue, 17 Dec 2019 04:15:43 +0000 (11:15 +0700)] 
Make wbclient optional

6 years agoMove ready to process requests
Arran Cudbard-Bell [Tue, 17 Dec 2019 04:04:27 +0000 (11:04 +0700)] 
Move ready to process requests

6 years agoUnused
Arran Cudbard-Bell [Tue, 17 Dec 2019 04:04:11 +0000 (11:04 +0700)] 
Unused

6 years agoRevert "Switch to atomics for shared fields"
Arran Cudbard-Bell [Tue, 17 Dec 2019 00:43:38 +0000 (07:43 +0700)] 
Revert "Switch to atomics for shared fields"

This reverts commit ee803e75e3c430dc2539ed38e9728f5425f7eeb2.

# Conflicts:
# src/lib/io/channel.c