]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
6 years agoDon't populate TLS until we need it
Arran Cudbard-Bell [Mon, 16 Dec 2019 20:35:50 +0000 (03:35 +0700)] 
Don't populate TLS until we need it

6 years agoAddress possible weird interation with threads/pthread API
Arran Cudbard-Bell [Mon, 16 Dec 2019 20:31:30 +0000 (03:31 +0700)] 
Address possible weird interation with threads/pthread API

6 years agomake "enable skips" code to compile
Alan T. DeKok [Mon, 16 Dec 2019 20:23:12 +0000 (15:23 -0500)] 
make "enable skips" code to compile

still doesn't help tho.  likely because other code also needs
to be updated to skip signalling

6 years agoremove get type abort.
Alan T. DeKok [Mon, 16 Dec 2019 20:03:36 +0000 (15:03 -0500)] 
remove get type abort.

the instruction could be any kind of unlang_*_t

6 years agoset track_duplicates flag in the listener
Alan T. DeKok [Mon, 16 Dec 2019 20:01:37 +0000 (15:01 -0500)] 
set track_duplicates flag in the listener

because the master_io handler can track duplicates, but perhaps
the underlying app_io doesn't need that.

6 years agouse correct variable
Alan T. DeKok [Mon, 16 Dec 2019 19:42:43 +0000 (14:42 -0500)] 
use correct variable

6 years agoadd more decoding tests for options with 255 octets of data
Alan T. DeKok [Mon, 16 Dec 2019 19:26:20 +0000 (14:26 -0500)] 
add more decoding tests for options with 255 octets of data

6 years agouse atomic loads for reading atomic variables
Alan T. DeKok [Mon, 16 Dec 2019 19:05:15 +0000 (14:05 -0500)] 
use atomic loads for reading atomic variables

6 years agocheck both ends of the channel, not the same end twice
Alan T. DeKok [Mon, 16 Dec 2019 19:04:56 +0000 (14:04 -0500)] 
check both ends of the channel, not the same end twice

6 years agocache compiled unlang
Alan T. DeKok [Mon, 16 Dec 2019 18:56:38 +0000 (13:56 -0500)] 
cache compiled unlang

which saves almost 10% on the performance tests.

6 years agoallow caching of compiled instruction
Alan T. DeKok [Mon, 16 Dec 2019 18:56:04 +0000 (13:56 -0500)] 
allow caching of compiled instruction

6 years agoremove unused assignment
Alan T. DeKok [Mon, 16 Dec 2019 18:54:27 +0000 (13:54 -0500)] 
remove unused assignment

6 years agoreturn compiled instruction if the caller asks for it
Alan T. DeKok [Mon, 16 Dec 2019 18:33:33 +0000 (13:33 -0500)] 
return compiled instruction if the caller asks for it

6 years agoadd API to push bare instructions into a request
Alan T. DeKok [Mon, 16 Dec 2019 18:28:50 +0000 (13:28 -0500)] 
add API to push bare instructions into a request

which is faster than doing lookups in CONF_SECTIONS

6 years agoupdate reference for newer specification
Alan T. DeKok [Mon, 16 Dec 2019 18:21:54 +0000 (13:21 -0500)] 
update reference for newer specification

6 years agodhcpv4 options can be 257 octets long, not 255.
Alan T. DeKok [Mon, 16 Dec 2019 18:19:16 +0000 (13:19 -0500)] 
dhcpv4 options can be 257 octets long, not 255.

and move the "check for limit" code to decode option, not to
the callers.

6 years agobump up the default sizes for ring buffers.
Alan T. DeKok [Mon, 16 Dec 2019 03:14:16 +0000 (22:14 -0500)] 
bump up the default sizes for ring buffers.

to 128K, which should be lots for most purposes

6 years agoerror messages are good for debugging, but not for the hot loop
Alan T. DeKok [Mon, 16 Dec 2019 03:10:15 +0000 (22:10 -0500)] 
error messages are good for debugging, but not for the hot loop

It turns out that hitting the limits of ring buffers happens
a lot in the load tests.

6 years agoset CLOEXEC on pipes, too
Alan T. DeKok [Mon, 16 Dec 2019 02:06:30 +0000 (21:06 -0500)] 
set CLOEXEC on pipes, too

6 years agoallow bypassing / closing of all pipes and kqueues
Alan T. DeKok [Mon, 16 Dec 2019 01:54:47 +0000 (20:54 -0500)] 
allow bypassing / closing of all pipes and kqueues

if the two ends of the channel are in the same thread, just
run the callback immediately.

6 years agoDon't set defaults which'll cause the server to fail to start
Arran Cudbard-Bell [Mon, 16 Dec 2019 17:52:08 +0000 (00:52 +0700)] 
Don't set defaults which'll cause the server to fail to start

6 years agoNot American
Arran Cudbard-Bell [Mon, 16 Dec 2019 17:34:08 +0000 (00:34 +0700)] 
Not American

6 years agoUse common log prefix for worker messages
Arran Cudbard-Bell [Mon, 16 Dec 2019 15:12:43 +0000 (22:12 +0700)] 
Use common log prefix for worker messages

6 years agoFix fr_value_box_cast_to_octets when dealing with non-numeric and non-ip types.
Arran Cudbard-Bell [Mon, 16 Dec 2019 14:29:20 +0000 (21:29 +0700)] 
Fix fr_value_box_cast_to_octets when dealing with non-numeric and non-ip types.

6 years agodon't try and build rlm_python if we can't configure it
Matthew Newton [Mon, 16 Dec 2019 13:35:40 +0000 (13:35 +0000)] 
don't try and build rlm_python if we can't configure it

6 years agoFix error code return from unit_test_module
Arran Cudbard-Bell [Mon, 16 Dec 2019 13:14:05 +0000 (20:14 +0700)] 
Fix error code return from unit_test_module

6 years agoDon't need to print this repeatedly
Arran Cudbard-Bell [Mon, 16 Dec 2019 13:00:52 +0000 (20:00 +0700)] 
Don't need to print this repeatedly

6 years agoDoesn't need to be atomic
Arran Cudbard-Bell [Mon, 16 Dec 2019 13:00:30 +0000 (20:00 +0700)] 
Doesn't need to be atomic

6 years agoUse more specific error messages
Arran Cudbard-Bell [Mon, 16 Dec 2019 11:37:11 +0000 (18:37 +0700)] 
Use more specific error messages

6 years agoTypo
Arran Cudbard-Bell [Mon, 16 Dec 2019 11:12:43 +0000 (18:12 +0700)] 
Typo

6 years agoRemove fr_worker_exit and strip fr_ prefix off local functions
Arran Cudbard-Bell [Mon, 16 Dec 2019 10:58:01 +0000 (17:58 +0700)] 
Remove fr_worker_exit and strip fr_ prefix off local functions

6 years agoUse active flag on each end of the channel
Arran Cudbard-Bell [Mon, 16 Dec 2019 10:43:08 +0000 (17:43 +0700)] 
Use active flag on each end of the channel

6 years agoChange the way workers are signalled to exit
Arran Cudbard-Bell [Mon, 16 Dec 2019 10:26:17 +0000 (17:26 +0700)] 
Change the way workers are signalled to exit

They now wait for all their channels to close, then signal themselves to exit via their event loop.

6 years agoGeneral cleanups in the worker code
Arran Cudbard-Bell [Mon, 16 Dec 2019 09:50:57 +0000 (16:50 +0700)] 
General cleanups in the worker code

Update comments, normalise debug messages.

6 years agoSwitch to atomics for shared fields
Arran Cudbard-Bell [Mon, 16 Dec 2019 08:40:27 +0000 (15:40 +0700)] 
Switch to atomics for shared fields

6 years agoMinor cleanups in channel code
Arran Cudbard-Bell [Mon, 16 Dec 2019 07:53:35 +0000 (14:53 +0700)] 
Minor cleanups in channel code

Use REQUESTOR in place of "master" and "network", and RESPONDER in place of "worker". The channel code will likely be reused very soon to create module specific thread pools to deal with blocking requests, and it's confusing to use usecase specific terms in generic code.

Move all size_t to uint64_t.  Guessing the original author was just being lazy and didn't want to type %"PRIu64 in a bunch of places.

Rename "ctx" to "uctx" because that's what it is...

6 years agoOnly emmit info messages about systemd if we're running under systemd
Arran Cudbard-Bell [Sun, 15 Dec 2019 14:23:51 +0000 (21:23 +0700)] 
Only emmit info messages about systemd if we're running under systemd

6 years agoWorker starting messages are INFO level, exiting messages should be too
Arran Cudbard-Bell [Sun, 15 Dec 2019 12:35:05 +0000 (19:35 +0700)] 
Worker starting messages are INFO level, exiting messages should be too

6 years agoFree the snmp dictionaries
Arran Cudbard-Bell [Sun, 15 Dec 2019 12:32:27 +0000 (19:32 +0700)] 
Free the snmp dictionaries

6 years agoMissed debug build check
Arran Cudbard-Bell [Sun, 15 Dec 2019 11:44:30 +0000 (18:44 +0700)] 
Missed debug build check

6 years agoStill need to memset...
Arran Cudbard-Bell [Sun, 15 Dec 2019 11:20:51 +0000 (18:20 +0700)] 
Still need to memset...

6 years agoAddress potential memory leak in track structures
Arran Cudbard-Bell [Sun, 15 Dec 2019 11:17:27 +0000 (18:17 +0700)] 
Address potential memory leak in track structures

6 years agoInvalid assert when module is exiting
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:55:51 +0000 (16:55 +0700)] 
Invalid  assert when module is exiting

6 years ago...and a log message
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:45:51 +0000 (16:45 +0700)] 
...and a log message

6 years agoAdd a note...
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:43:52 +0000 (16:43 +0700)] 
Add a note...

6 years agoIgnore sigterm earlier and send kill later
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:42:46 +0000 (16:42 +0700)] 
Ignore sigterm earlier and send kill later

6 years agoStop the scheduler before sending the TERM signal
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:36:18 +0000 (16:36 +0700)] 
Stop the scheduler before sending the TERM signal

6 years agoFix segv
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:30:45 +0000 (16:30 +0700)] 
Fix segv

6 years agoNeeds somewhere to put the event
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:29:14 +0000 (16:29 +0700)] 
Needs somewhere to put the event

6 years agoBetter way of signalling termination
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:25:59 +0000 (16:25 +0700)] 
Better way of signalling termination

6 years agoAdd -e for triggering an exit after N seconds
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:24:54 +0000 (16:24 +0700)] 
Add -e for triggering an exit after N seconds

6 years agoAllow date and time_delta to be flipped
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:10:54 +0000 (16:10 +0700)] 
Allow date and time_delta to be flipped

6 years agoOnly call fr_value_box_hton on numeric types
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:06:30 +0000 (16:06 +0700)] 
Only call fr_value_box_hton on numeric types

6 years agoAdd more context to assert
Arran Cudbard-Bell [Sun, 15 Dec 2019 09:03:11 +0000 (16:03 +0700)] 
Add more context to assert

6 years agoFix struct names
Arran Cudbard-Bell [Sun, 15 Dec 2019 08:25:53 +0000 (15:25 +0700)] 
Fix struct names

6 years agoJust use the list for counting workers
Arran Cudbard-Bell [Sun, 15 Dec 2019 08:02:48 +0000 (15:02 +0700)] 
Just use the list for counting workers

6 years agoRename schedule struct
Arran Cudbard-Bell [Sun, 15 Dec 2019 08:01:42 +0000 (15:01 +0700)] 
Rename schedule struct

6 years agoUse destructor to enforce absolute free order
Arran Cudbard-Bell [Sun, 15 Dec 2019 06:34:44 +0000 (13:34 +0700)] 
Use destructor to enforce absolute free order

6 years agoRename local alloc function
Arran Cudbard-Bell [Sun, 15 Dec 2019 06:34:17 +0000 (13:34 +0700)] 
Rename local alloc function

6 years agorun max_request timer no more than once every max_request time
Alan T. DeKok [Sun, 15 Dec 2019 04:20:44 +0000 (23:20 -0500)] 
run max_request timer no more than once every max_request time

this saves 1/3 to 1/2 in the test runs

6 years agomove timer logic to function that implements the timer.
Alan T. DeKok [Sun, 15 Dec 2019 01:49:26 +0000 (20:49 -0500)] 
move timer logic to function that implements the timer.

6 years agoHandle OpenSSL init/free ourselves
Arran Cudbard-Bell [Sun, 15 Dec 2019 00:45:52 +0000 (07:45 +0700)] 
Handle OpenSSL init/free ourselves

6 years agoFree the right thing
Arran Cudbard-Bell [Sat, 14 Dec 2019 14:18:58 +0000 (21:18 +0700)] 
Free the right thing

6 years agoAvoid calling curl global init more than once
Arran Cudbard-Bell [Sat, 14 Dec 2019 14:18:51 +0000 (21:18 +0700)] 
Avoid calling curl global init more than once

6 years agoFix minor leak on exit
Arran Cudbard-Bell [Sat, 14 Dec 2019 13:35:44 +0000 (20:35 +0700)] 
Fix minor leak on exit

6 years agoGotta catch em all...
Arran Cudbard-Bell [Sat, 14 Dec 2019 13:02:40 +0000 (20:02 +0700)] 
Gotta catch em all...

6 years agoIgnore until we have a proper fix
Arran Cudbard-Bell [Sat, 14 Dec 2019 12:43:53 +0000 (19:43 +0700)] 
Ignore until we have a proper fix

6 years agostack is void
Arran Cudbard-Bell [Sat, 14 Dec 2019 12:34:03 +0000 (19:34 +0700)] 
stack is void

6 years agoFix assert when trying to cancel new requests
Arran Cudbard-Bell [Sat, 14 Dec 2019 12:21:02 +0000 (19:21 +0700)] 
Fix assert when trying to cancel new requests

6 years agoGracefully deal with trunk timer failures
Arran Cudbard-Bell [Sat, 14 Dec 2019 12:16:12 +0000 (19:16 +0700)] 
Gracefully deal with trunk timer failures

6 years agoDeal with failed timer events gracefully in connection.c
Arran Cudbard-Bell [Sat, 14 Dec 2019 12:08:29 +0000 (19:08 +0700)] 
Deal with failed timer events gracefully in connection.c

6 years agoDon't crash on exit in threaded mode when using rlm_radius
Arran Cudbard-Bell [Sat, 14 Dec 2019 11:38:21 +0000 (18:38 +0700)] 
Don't crash on exit in threaded mode when using rlm_radius

6 years agoTypo
Arran Cudbard-Bell [Sat, 14 Dec 2019 11:04:29 +0000 (18:04 +0700)] 
Typo

6 years agoTypo
Arran Cudbard-Bell [Sat, 14 Dec 2019 10:49:40 +0000 (17:49 +0700)] 
Typo

6 years agoDid not allocate this, so shouldn't be freeing it
Arran Cudbard-Bell [Sat, 14 Dec 2019 10:42:24 +0000 (17:42 +0700)] 
Did not allocate this, so shouldn't be freeing it

causes crash on exit

6 years agoFix TOCTOU like issue in conn_closed caused by the a filedescriptor not being removed...
Arran Cudbard-Bell [Sat, 14 Dec 2019 10:40:47 +0000 (17:40 +0700)] 
Fix TOCTOU like issue in conn_closed caused by the a filedescriptor not being removed from the event loop before it's been freed

6 years agoQuiet clang?
Arran Cudbard-Bell [Sat, 14 Dec 2019 10:31:49 +0000 (17:31 +0700)] 
Quiet clang?

6 years agoFix assert in rlm_cache on unknown attributes
Arran Cudbard-Bell [Sat, 14 Dec 2019 10:23:25 +0000 (17:23 +0700)] 
Fix assert in rlm_cache on unknown attributes

6 years agoDon't set tmpl_da and immediately overwrite it
Arran Cudbard-Bell [Sat, 14 Dec 2019 10:04:43 +0000 (17:04 +0700)] 
Don't set tmpl_da and immediately overwrite it

6 years agoDon't emmit warnings if was can't find gigawords
Arran Cudbard-Bell [Sat, 14 Dec 2019 10:04:11 +0000 (17:04 +0700)] 
Don't emmit warnings if was can't find gigawords

6 years agoSet conn to NULL after it's meant to have been freed
Arran Cudbard-Bell [Sat, 14 Dec 2019 10:02:23 +0000 (17:02 +0700)] 
Set conn to NULL after it's meant to have been freed

6 years agoHalt if a connection attempt failed and no reconnect_delay was set
Arran Cudbard-Bell [Sat, 14 Dec 2019 10:01:57 +0000 (17:01 +0700)] 
Halt if a connection attempt failed and no reconnect_delay was set

6 years agoRework time tracking so that it no longer uses an explicit tracking list
Arran Cudbard-Bell [Sat, 14 Dec 2019 06:49:39 +0000 (13:49 +0700)] 
Rework time tracking so that it no longer uses an explicit tracking list

6 years agoMove time tracking code into its own source file
Arran Cudbard-Bell [Fri, 13 Dec 2019 11:51:49 +0000 (18:51 +0700)] 
Move time tracking code into its own source file

6 years agoRevert "add and use sanity check functions for dlists"
Alan T. DeKok [Fri, 13 Dec 2019 18:25:14 +0000 (13:25 -0500)] 
Revert "add and use sanity check functions for dlists"

This reverts commit 147307e922828e5c183ece1c8c05cd699917a432.

nope

6 years agoadd and use sanity check functions for dlists
Alan T. DeKok [Fri, 13 Dec 2019 16:26:44 +0000 (11:26 -0500)] 
add and use sanity check functions for dlists

6 years agoinitialize to be the same as the worker tracking list
Alan T. DeKok [Fri, 13 Dec 2019 16:16:19 +0000 (11:16 -0500)] 
initialize to be the same as the worker tracking list

6 years agoDon't allow the pool to start if we're in check config mode
Arran Cudbard-Bell [Fri, 13 Dec 2019 10:15:43 +0000 (17:15 +0700)] 
Don't allow the pool to start if we're in check config mode

6 years agoEnable gperftools for eveloper builds
Arran Cudbard-Bell [Fri, 13 Dec 2019 10:08:59 +0000 (17:08 +0700)] 
Enable gperftools for eveloper builds

6 years agoBarely noteworthy let alone error worthy
Arran Cudbard-Bell [Fri, 13 Dec 2019 07:39:46 +0000 (14:39 +0700)] 
Barely noteworthy let alone error worthy

6 years agoNot sure how it could ever be a garbage value, but oh well..
Arran Cudbard-Bell [Fri, 13 Dec 2019 07:22:03 +0000 (14:22 +0700)] 
Not sure how it could ever be a garbage value, but oh well..

6 years agoAdd failed state to the trunk code
Arran Cudbard-Bell [Fri, 13 Dec 2019 06:56:15 +0000 (13:56 +0700)] 
Add failed state to the trunk code

Partially mirrors connection's failed state, but only triggers if the connection immediately fails after opening.

6 years agoremove Response-Packet-Type
Alan T. DeKok [Thu, 12 Dec 2019 22:47:34 +0000 (17:47 -0500)] 
remove Response-Packet-Type

now that it's unused everywhere

6 years agoremove Response-Packet-Type
Alan T. DeKok [Thu, 12 Dec 2019 22:46:25 +0000 (17:46 -0500)] 
remove Response-Packet-Type

6 years agoThe 'Response-Packet-Type' was replaced by 'Packet-Type'
Jorge Pereira [Thu, 12 Dec 2019 21:02:42 +0000 (18:02 -0300)] 
The 'Response-Packet-Type' was replaced by 'Packet-Type'

Part of a9e875e74af4b0407fd57cf350fe8203249e74ed

6 years agodocument Response-Packet-Type removal
Alan T. DeKok [Thu, 12 Dec 2019 20:36:47 +0000 (15:36 -0500)] 
document Response-Packet-Type removal

6 years agoremove old things
Alan T. DeKok [Thu, 12 Dec 2019 20:36:35 +0000 (15:36 -0500)] 
remove old things

6 years agoprovisions for running many tests, one after the other.
Alan T. DeKok [Thu, 12 Dec 2019 20:09:14 +0000 (15:09 -0500)] 
provisions for running many tests, one after the other.

in order to stress test the interpreter

6 years agoswitch to use Packet-Type for the reply
Alan T. DeKok [Thu, 12 Dec 2019 19:31:15 +0000 (14:31 -0500)] 
switch to use Packet-Type for the reply

instead of Response-Packet-Type

6 years agoFix LD_PRELOAD
Arran Cudbard-Bell [Thu, 12 Dec 2019 18:16:47 +0000 (01:16 +0700)] 
Fix LD_PRELOAD