]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
6 years agoFix typo (#3015)
Jorge Pereira [Tue, 1 Oct 2019 17:13:51 +0000 (14:13 -0300)] 
Fix typo (#3015)

6 years agoOnly free the existing state_ctx if we're sure it's not the parent's
Arran Cudbard-Bell [Tue, 1 Oct 2019 17:12:04 +0000 (12:12 -0500)] 
Only free the existing state_ctx if we're sure it's not the parent's

6 years agodoxygen
Alan T. DeKok [Tue, 1 Oct 2019 17:02:52 +0000 (13:02 -0400)] 
doxygen

6 years agotry to work around things with unlang_interpret_fixup()
Alan T. DeKok [Tue, 1 Oct 2019 16:41:23 +0000 (12:41 -0400)] 
try to work around things with unlang_interpret_fixup()

which runs things locally via playing with the stack.

6 years agofix return code
Alan T. DeKok [Tue, 1 Oct 2019 14:29:48 +0000 (10:29 -0400)] 
fix return code

6 years agoadd missing declaration
Alan T. DeKok [Tue, 1 Oct 2019 14:29:26 +0000 (10:29 -0400)] 
add missing declaration

6 years agocheck child state_ctx against parent
Alan T. DeKok [Tue, 1 Oct 2019 13:43:40 +0000 (09:43 -0400)] 
check child state_ctx against parent

The EAP code should arguably call request_detach() or something,
but this is a quick and easy fix

6 years agorename "persist" as it's confusing. Use and check "detachable"
Alan T. DeKok [Tue, 1 Oct 2019 13:25:48 +0000 (09:25 -0400)] 
rename "persist" as it's confusing.  Use and check "detachable"

6 years agoonly parent requests are runnable
Alan T. DeKok [Tue, 1 Oct 2019 13:11:52 +0000 (09:11 -0400)] 
only parent requests are runnable

6 years agomore debug messages
Alan T. DeKok [Tue, 1 Oct 2019 12:39:16 +0000 (08:39 -0400)] 
more debug messages

6 years agoDon't leak if failed the MS-CHAP password handle
Jorge Pereira [Mon, 30 Sep 2019 23:15:25 +0000 (20:15 -0300)] 
Don't leak if failed the MS-CHAP password handle

6 years agoReturn correct rcode
Arran Cudbard-Bell [Mon, 30 Sep 2019 21:02:02 +0000 (16:02 -0500)] 
Return correct rcode

6 years agoDump packet in radius encoder
Arran Cudbard-Bell [Mon, 30 Sep 2019 21:01:50 +0000 (16:01 -0500)] 
Dump packet in radius encoder

6 years agoPrint hex blocks with whitespace
Arran Cudbard-Bell [Mon, 30 Sep 2019 20:10:03 +0000 (15:10 -0500)] 
Print hex blocks with whitespace

6 years agoFix eapmschapv2
Arran Cudbard-Bell [Mon, 30 Sep 2019 19:47:16 +0000 (14:47 -0500)] 
Fix eapmschapv2

6 years agoAdd tracing to mschap_challenge_hash
Arran Cudbard-Bell [Mon, 30 Sep 2019 19:46:21 +0000 (14:46 -0500)] 
Add tracing to mschap_challenge_hash

6 years agoFixup rlm_mschap to support EAP-Identity too
Arran Cudbard-Bell [Mon, 30 Sep 2019 19:46:01 +0000 (14:46 -0500)] 
Fixup rlm_mschap to support EAP-Identity too

6 years agouse sw->id which is local
Alan T. DeKok [Mon, 30 Sep 2019 19:34:37 +0000 (15:34 -0400)] 
use sw->id which is local

6 years agouse worker->name
Alan T. DeKok [Mon, 30 Sep 2019 19:34:08 +0000 (15:34 -0400)] 
use worker->name

instead of function call and thread-local storage

6 years agoclarify comments and code structure
Alan T. DeKok [Mon, 30 Sep 2019 18:39:17 +0000 (14:39 -0400)] 
clarify comments and code structure

6 years agoprint "Resuming execution" when we resume
Alan T. DeKok [Mon, 30 Sep 2019 15:55:52 +0000 (11:55 -0400)] 
print "Resuming execution" when we resume

6 years agoget rid of unlang_group_type
Alan T. DeKok [Mon, 30 Sep 2019 15:30:51 +0000 (11:30 -0400)] 
get rid of unlang_group_type

which was always a horrific hack.  Instead, just fix the
compile_action_default() function to sneak a peek at the parent.

Then, add "redundant" as a top-level type / keyword.  which
lets us print out "redundant" in debug mode instead of "group"

6 years agorename func / process to interpret
Alan T. DeKok [Mon, 30 Sep 2019 13:19:24 +0000 (09:19 -0400)] 
rename func / process to interpret

in preparation for adding compile / parse functions to the
unlang_op_t structure

6 years agoSplit out virtual servers and modules used by them
Arran Cudbard-Bell [Mon, 30 Sep 2019 15:02:36 +0000 (10:02 -0500)] 
Split out virtual servers and modules used by them

6 years agoFix clan scan issues
Arran Cudbard-Bell [Mon, 30 Sep 2019 14:55:00 +0000 (09:55 -0500)] 
Fix clan scan issues

6 years agoFix comparators to return a number within a limited range
Arran Cudbard-Bell [Mon, 30 Sep 2019 14:54:51 +0000 (09:54 -0500)] 
Fix comparators to return a number within a limited range

6 years agoNot needed
Arran Cudbard-Bell [Mon, 30 Sep 2019 13:11:25 +0000 (08:11 -0500)] 
Not needed

6 years agoremove deterministic load balancing, and revert to random
Alan T. DeKok [Sun, 29 Sep 2019 22:42:37 +0000 (18:42 -0400)] 
remove deterministic load balancing, and revert to random

which means we have less magic knowledge in the interpreter, and
less recursive code.  At the cost of being less deterministic

6 years agoremove "detach" magic from main interpreter loop
Alan T. DeKok [Sun, 29 Sep 2019 20:17:43 +0000 (16:17 -0400)] 
remove "detach" magic from main interpreter loop

detach now "does the right thing", and behaves appropriately.

6 years agoremove unused parameter to signal()
Alan T. DeKok [Sun, 29 Sep 2019 12:17:03 +0000 (08:17 -0400)] 
remove unused parameter to signal()

6 years agomake UNLANG_TYPE_CALL skip using using resumable frames
Alan T. DeKok [Sun, 29 Sep 2019 11:53:21 +0000 (07:53 -0400)] 
make UNLANG_TYPE_CALL skip using using resumable frames

and now that nothing uses resumable frames, remove them entirely
from the interpreter

6 years agomake UNLANG_TYPE_XLAT skip using resumable frames
Alan T. DeKok [Sat, 28 Sep 2019 19:23:09 +0000 (15:23 -0400)] 
make UNLANG_TYPE_XLAT skip using resumable frames

6 years agoget rid of unlang_module_resume(), as we no longer need it.
Alan T. DeKok [Sat, 28 Sep 2019 19:09:38 +0000 (15:09 -0400)] 
get rid of unlang_module_resume(), as we no longer need it.

And do some other minor cleanups.

6 years agothis shouldn't happen
Alan T. DeKok [Sat, 28 Sep 2019 19:08:11 +0000 (15:08 -0400)] 
this shouldn't happen

6 years agomake UNLANG_TYPE_SUBREQUEST skip using resumable frames
Alan T. DeKok [Sat, 28 Sep 2019 14:06:51 +0000 (10:06 -0400)] 
make UNLANG_TYPE_SUBREQUEST skip using resumable frames

and clean up subrequest_push() so that it skips the
unlang_subrequest_state_init() function, and just calls the
unlang_subrequest_process() function directly.

6 years agoremove "resume" callback as it's no longer used
Alan T. DeKok [Sat, 28 Sep 2019 14:22:19 +0000 (10:22 -0400)] 
remove "resume" callback as it's no longer used

and restructure the code accordingly.

6 years agorename to yielded_set, etc.
Alan T. DeKok [Sat, 28 Sep 2019 12:18:42 +0000 (08:18 -0400)] 
rename to yielded_set, etc.

and fix a couple of bugs where yielded wasn't cleared when
instructions were being run.  And where the current request
wasn't being checked for STOP_PROCESSING

6 years agomake UNLANG_TYPE_PARALLEL skip using resumable frames
Alan T. DeKok [Sat, 28 Sep 2019 11:44:12 +0000 (07:44 -0400)] 
make UNLANG_TYPE_PARALLEL skip using resumable frames

6 years agomake UNLANG_TYPE_MODULE skip using resumable frames
Alan T. DeKok [Fri, 27 Sep 2019 18:56:46 +0000 (14:56 -0400)] 
make UNLANG_TYPE_MODULE skip using resumable frames

The basic tests seem to work.  So let's hope that the rest works.

6 years agomore docs and hand-holding.
Alan T. DeKok [Fri, 27 Sep 2019 17:53:11 +0000 (13:53 -0400)] 
more docs and hand-holding.

Spoon-feeding developers is a good idea.

6 years agoTypo
Arran Cudbard-Bell [Fri, 27 Sep 2019 17:54:40 +0000 (12:54 -0500)] 
Typo

6 years agoOnly build the support eap-aka-sim library if we have OpenSSL
Arran Cudbard-Bell [Fri, 27 Sep 2019 17:51:58 +0000 (12:51 -0500)] 
Only build the support eap-aka-sim library if we have OpenSSL

6 years agodocument and clarify check for missing xlats
Alan T. DeKok [Fri, 27 Sep 2019 17:44:23 +0000 (13:44 -0400)] 
document and clarify check for missing xlats

6 years agomore fixes
Alan T. DeKok [Fri, 27 Sep 2019 17:22:32 +0000 (13:22 -0400)] 
more fixes

6 years agofix authparams. to authparams->
Alan T. DeKok [Fri, 27 Sep 2019 17:19:21 +0000 (13:19 -0400)] 
fix authparams. to authparams->

6 years agoadd "inst" and fix typo
Alan T. DeKok [Fri, 27 Sep 2019 17:15:33 +0000 (13:15 -0400)] 
add "inst" and fix typo

6 years agoDisable test.doc until it meets the following conditions
Arran Cudbard-Bell [Fri, 27 Sep 2019 17:41:47 +0000 (12:41 -0500)] 
Disable test.doc until it meets the following conditions

- Provides hints on how to fix check failures
- Provides a command to run to re-run checks fo failures
- asciidoctor ignores antora includes and stops producing spurious warnings
- Provides a clear indication of what's being used to generate build products

6 years agoReturn error codes in addition to asserting
Arran Cudbard-Bell [Fri, 27 Sep 2019 17:22:53 +0000 (12:22 -0500)] 
Return error codes in addition to asserting

6 years agoFix EAP-SIM includes
Arran Cudbard-Bell [Fri, 27 Sep 2019 16:45:18 +0000 (11:45 -0500)] 
Fix EAP-SIM includes

6 years agoheader files are named for the dictionary directory
Alan T. DeKok [Fri, 27 Sep 2019 16:40:54 +0000 (12:40 -0400)] 
header files are named for the dictionary directory

not the source directory.

6 years agodoxygen fixes
Alan T. DeKok [Fri, 27 Sep 2019 15:46:38 +0000 (11:46 -0400)] 
doxygen fixes

6 years agonotes on how it works, and what to fix in the future
Alan T. DeKok [Fri, 27 Sep 2019 13:59:59 +0000 (09:59 -0400)] 
notes on how it works, and what to fix in the future

6 years agoset parent to be resumable here, too
Alan T. DeKok [Fri, 27 Sep 2019 13:56:36 +0000 (09:56 -0400)] 
set parent to be resumable here, too

6 years agoclean up unlang_interpret_resumable() and parallel
Alan T. DeKok [Fri, 27 Sep 2019 13:27:33 +0000 (09:27 -0400)] 
clean up unlang_interpret_resumable() and parallel

instead of having magic for parallel in unlang_interpret_resumable(),
parallel just pushes a UNLANG_TYPE_FUNCTION into the childs stack.

The function then runs as the last thing before the child exits.
The function can then notify the parent that the child has exited.

6 years agocheck dl_module->dl
Alan T. DeKok [Fri, 27 Sep 2019 13:10:23 +0000 (09:10 -0400)] 
check dl_module->dl

which is NULL if we tried to load a module and failed

6 years agoparallel children are subrequests
Alan T. DeKok [Thu, 26 Sep 2019 23:09:52 +0000 (19:09 -0400)] 
parallel children are subrequests

6 years agoAdd support for allocating frame state pools
Arran Cudbard-Bell [Thu, 26 Sep 2019 23:04:08 +0000 (18:04 -0500)] 
Add support for allocating frame state pools

6 years agoPreprocessor will optimise the calculations away
Arran Cudbard-Bell [Thu, 26 Sep 2019 23:03:52 +0000 (18:03 -0500)] 
Preprocessor will optimise the calculations away

6 years agos/frame_inst/frame_state/g
Arran Cudbard-Bell [Thu, 26 Sep 2019 22:12:49 +0000 (17:12 -0500)] 
s/frame_inst/frame_state/g

6 years agoUninvert the timeout delete function calls
Arran Cudbard-Bell [Thu, 26 Sep 2019 22:08:10 +0000 (17:08 -0500)] 
Uninvert the timeout delete function calls

6 years agothe delay module can have xlat OR module timeouts
Alan T. DeKok [Thu, 26 Sep 2019 21:45:14 +0000 (17:45 -0400)] 
the delay module can have xlat OR module timeouts

6 years agouse frame_inst_size
Alan T. DeKok [Thu, 26 Sep 2019 19:57:11 +0000 (15:57 -0400)] 
use frame_inst_size

6 years agosplit "map" into init / apply
Alan T. DeKok [Thu, 26 Sep 2019 18:03:38 +0000 (14:03 -0400)] 
split "map" into init / apply

6 years agoadd frame_inst_size to unlang_op_t and start using it
Alan T. DeKok [Thu, 26 Sep 2019 17:30:24 +0000 (13:30 -0400)] 
add frame_inst_size to unlang_op_t and start using it

also add frame_setup() function which sets up a new frame.

6 years agoput state into frame->state, and let it manage the lifetime
Alan T. DeKok [Thu, 26 Sep 2019 16:27:44 +0000 (12:27 -0400)] 
put state into frame->state, and let it manage the lifetime

6 years agos/USERLOCK/DISALLOW/g
Arran Cudbard-Bell [Wed, 25 Sep 2019 20:02:21 +0000 (15:02 -0500)] 
s/USERLOCK/DISALLOW/g

6 years agoHacks to allow more EAP methods to function
Arran Cudbard-Bell [Tue, 3 Sep 2019 22:38:01 +0000 (18:38 -0400)] 
Hacks to allow more EAP methods to function

6 years agoCreate unified library for EAP-SIM/AKA/AKA' and make those modules fully async
Arran Cudbard-Bell [Tue, 3 Sep 2019 17:42:09 +0000 (13:42 -0400)] 
Create unified library for EAP-SIM/AKA/AKA' and make those modules fully async

6 years agoCall some EAP methods with a subrequest
Arran Cudbard-Bell [Tue, 3 Sep 2019 21:07:12 +0000 (17:07 -0400)] 
Call some EAP methods with a subrequest

6 years agoAdd fallback for non-zeroed talloc pools
Arran Cudbard-Bell [Thu, 26 Sep 2019 18:25:48 +0000 (13:25 -0500)] 
Add fallback for non-zeroed talloc pools

6 years agotry to quiet analyzer
Alan T. DeKok [Thu, 26 Sep 2019 16:16:06 +0000 (12:16 -0400)] 
try to quiet analyzer

6 years agouse g->num_children instead of manually counting things
Alan T. DeKok [Thu, 26 Sep 2019 16:12:35 +0000 (12:12 -0400)] 
use g->num_children instead of manually counting things

6 years agoalways set presult
Alan T. DeKok [Thu, 26 Sep 2019 15:45:53 +0000 (11:45 -0400)] 
always set presult

6 years agoset presult for non-debug builds, too
Alan T. DeKok [Thu, 26 Sep 2019 14:46:11 +0000 (10:46 -0400)] 
set presult for non-debug builds, too

6 years agonote that load-balance etc. returns the return code of the child
Alan T. DeKok [Thu, 26 Sep 2019 14:45:21 +0000 (10:45 -0400)] 
note that load-balance etc. returns the return code of the child

6 years agodon't set frame->result, it's set by the interpreter
Alan T. DeKok [Thu, 26 Sep 2019 14:39:16 +0000 (10:39 -0400)] 
don't set frame->result, it's set by the interpreter

6 years agoquiet static analyzer
Alan T. DeKok [Thu, 26 Sep 2019 13:43:00 +0000 (09:43 -0400)] 
quiet static analyzer

6 years agotry to quiet static analyzer
Alan T. DeKok [Thu, 26 Sep 2019 02:35:05 +0000 (22:35 -0400)] 
try to quiet static analyzer

6 years agoRename and document some functions in map.c
Arran Cudbard-Bell [Thu, 26 Sep 2019 15:37:54 +0000 (10:37 -0500)] 
Rename and document some functions in map.c

6 years agoRevert correct part
Arran Cudbard-Bell [Thu, 26 Sep 2019 02:46:12 +0000 (21:46 -0500)] 
Revert correct part

6 years agoPartially Revert "Minor tweaks in the interpreter"
Arran Cudbard-Bell [Thu, 26 Sep 2019 02:45:04 +0000 (21:45 -0500)] 
Partially Revert "Minor tweaks in the interpreter"

This reverts commit 60a53e88a54e31e98db6e8bbe40e10bd0608b21c.

6 years agoremove priority from unlang_op_call_t
Alan T. DeKok [Thu, 26 Sep 2019 01:49:16 +0000 (21:49 -0400)] 
remove priority from unlang_op_call_t

it is now handled by the main interpret loop

6 years agohoist priority setting to the main interpret loop
Alan T. DeKok [Thu, 26 Sep 2019 01:16:22 +0000 (21:16 -0400)] 
hoist priority setting to the main interpret loop

which not only minimizes code, but makes it so that the priority
isn't really needed.

6 years agoset an rcode if we return "calculate_result"
Alan T. DeKok [Thu, 26 Sep 2019 01:05:25 +0000 (21:05 -0400)] 
set an rcode if we return "calculate_result"

Otherwise how do we calculate results that don't have results?

unlang keywords shouldn't be returning RLM_MODULE_UNKNOWN.

6 years agoShould use authparams as the ctx
Arran Cudbard-Bell [Thu, 26 Sep 2019 01:11:51 +0000 (20:11 -0500)] 
Should use authparams as the ctx

6 years agoFix various binary safety issues in rlm_mschap
Arran Cudbard-Bell [Wed, 25 Sep 2019 22:25:52 +0000 (17:25 -0500)] 
Fix various binary safety issues in rlm_mschap

6 years agoFix talloc_pooled_object check and add talloc_zero_pooled_object
Arran Cudbard-Bell [Wed, 25 Sep 2019 21:50:45 +0000 (16:50 -0500)] 
Fix talloc_pooled_object check and add talloc_zero_pooled_object

6 years agoMinor tweaks in the interpreter
Arran Cudbard-Bell [Wed, 25 Sep 2019 20:13:14 +0000 (15:13 -0500)] 
Minor tweaks in the interpreter

6 years agomake "update" use frame->process
Alan T. DeKok [Wed, 25 Sep 2019 20:11:02 +0000 (16:11 -0400)] 
make "update" use frame->process

6 years agomake "load-balance" and friends use frame->process
Alan T. DeKok [Wed, 25 Sep 2019 19:16:29 +0000 (15:16 -0400)] 
make "load-balance" and friends use frame->process

6 years agomake "foreach" use frame->process
Alan T. DeKok [Wed, 25 Sep 2019 18:57:11 +0000 (14:57 -0400)] 
make "foreach" use frame->process

6 years agorun the main "foreach" test before this one
Alan T. DeKok [Wed, 25 Sep 2019 18:55:34 +0000 (14:55 -0400)] 
run the main "foreach" test before this one

6 years agoadd process / signal to the unlang stack frame
Alan T. DeKok [Wed, 25 Sep 2019 18:36:58 +0000 (14:36 -0400)] 
add process / signal to the unlang stack frame

so that the process functions can set / reset them as necessary
which then means that we can get rid of the repeat / resume
handling.  And just use the "process" functions

6 years agoMinor typo
Arran Cudbard-Bell [Wed, 25 Sep 2019 18:42:40 +0000 (13:42 -0500)] 
Minor typo

6 years agoMinor typos
Arran Cudbard-Bell [Wed, 25 Sep 2019 18:42:32 +0000 (13:42 -0500)] 
Minor typos

6 years agoturn assert into run-time check. Fixes #3008
Alan T. DeKok [Wed, 25 Sep 2019 17:16:18 +0000 (13:16 -0400)] 
turn assert into run-time check.  Fixes #3008

6 years agoFix the rcode lookup table to be in the right order
Arran Cudbard-Bell [Wed, 25 Sep 2019 14:40:37 +0000 (09:40 -0500)] 
Fix the rcode lookup table to be in the right order

6 years agocp->value can be NULL. Fixes #3008
Alan T. DeKok [Wed, 25 Sep 2019 14:12:11 +0000 (10:12 -0400)] 
cp->value can be NULL.  Fixes #3008

6 years agoFlesh out the return code tutorial
Arran Cudbard-Bell [Wed, 25 Sep 2019 13:56:12 +0000 (08:56 -0500)] 
Flesh out the return code tutorial

6 years agoFix some issues with the update_blocks_and_conditions tutorial
Arran Cudbard-Bell [Wed, 25 Sep 2019 13:56:00 +0000 (08:56 -0500)] 
Fix some issues with the update_blocks_and_conditions tutorial