]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
7 years agocheck for errors
Alan T. DeKok [Fri, 31 May 2019 15:35:04 +0000 (11:35 -0400)] 
check for errors

7 years agoadd "on read" callback for lib_dir. Fixes #2726
Alan T. DeKok [Fri, 31 May 2019 13:52:49 +0000 (09:52 -0400)] 
add "on read" callback for lib_dir.  Fixes #2726

and make it run before the virtual server "namespace" callback

7 years agolist can't be NULL. CID #1445202
Alan T. DeKok [Mon, 27 May 2019 20:22:08 +0000 (16:22 -0400)] 
list can't be NULL.  CID #1445202

7 years agocheck contents of psk_identity, too. CID #1445203
Alan T. DeKok [Mon, 27 May 2019 20:20:34 +0000 (16:20 -0400)] 
check contents of psk_identity, too.  CID #1445203

7 years agowe don't really care about failures here. CID #1445204
Alan T. DeKok [Mon, 27 May 2019 20:15:55 +0000 (16:15 -0400)] 
we don't really care about failures here.  CID #1445204

7 years agocheck return code of value box alloc. CID #1445205
Alan T. DeKok [Mon, 27 May 2019 20:14:35 +0000 (16:14 -0400)] 
check return code of value box alloc.  CID #1445205

7 years ago8/16 bit integers are always within the Lua "unsigned int" range
Alan T. DeKok [Mon, 27 May 2019 20:12:40 +0000 (16:12 -0400)] 
8/16 bit integers are always within the Lua "unsigned int" range

CID #1445205 CID #1445206

7 years agoradclient: Update to use fr_time_delta_t
Jorge Pereira [Tue, 28 May 2019 21:47:16 +0000 (17:47 -0400)] 
radclient: Update to use fr_time_delta_t

7 years agoradclient: Typo
Jorge Pereira [Tue, 28 May 2019 21:29:32 +0000 (17:29 -0400)] 
radclient: Typo

7 years agoradmin: Update to use fr_time_delta_t
Jorge Pereira [Sat, 25 May 2019 01:55:48 +0000 (22:55 -0300)] 
radmin: Update to use fr_time_delta_t

7 years agodo correct calculation. CID #1445645
Alan T. DeKok [Mon, 27 May 2019 20:09:26 +0000 (16:09 -0400)] 
do correct calculation.  CID #1445645

7 years agoremove dead code. CID #1445223
Alan T. DeKok [Sat, 25 May 2019 01:56:16 +0000 (21:56 -0400)] 
remove dead code.  CID #1445223

7 years agoradsnmap: Update to use fr_time_delta_t
Jorge Pereira [Sat, 25 May 2019 01:48:46 +0000 (22:48 -0300)] 
radsnmap: Update to use fr_time_delta_t

7 years agoUse a macro when converting from server epoch time to timeval/timespec
Arran Cudbard-Bell [Sat, 25 May 2019 06:20:02 +0000 (02:20 -0400)] 
Use a macro when converting from server epoch time to timeval/timespec

7 years agoFix docs
Arran Cudbard-Bell [Sat, 25 May 2019 06:02:38 +0000 (02:02 -0400)] 
Fix docs

7 years agorlm_delay: Update to use fr_time_delta_t
Jorge Pereira [Fri, 24 May 2019 22:20:53 +0000 (19:20 -0300)] 
rlm_delay: Update to use fr_time_delta_t

7 years agouse correct variable
Alan T. DeKok [Sat, 25 May 2019 01:54:56 +0000 (21:54 -0400)] 
use correct variable

7 years agoMinor fixes
Arran Cudbard-Bell [Sat, 25 May 2019 00:38:04 +0000 (20:38 -0400)] 
Minor fixes

7 years agoSet default timeout correctly in fr_ldap_result
Arran Cudbard-Bell [Fri, 24 May 2019 22:08:47 +0000 (18:08 -0400)] 
Set default timeout correctly in fr_ldap_result

7 years agoUse a proper enum for time resolution
Arran Cudbard-Bell [Fri, 24 May 2019 22:07:04 +0000 (18:07 -0400)] 
Use a proper enum for time resolution

7 years agoApparently needed?
Arran Cudbard-Bell [Fri, 24 May 2019 22:02:21 +0000 (18:02 -0400)] 
Apparently needed?

7 years agoNot used
Arran Cudbard-Bell [Fri, 24 May 2019 20:52:12 +0000 (16:52 -0400)] 
Not used

7 years agocheck decoded length before using it. CID #1445221
Alan T. DeKok [Fri, 24 May 2019 20:06:58 +0000 (16:06 -0400)] 
check decoded length before using it.  CID #1445221

7 years agotry to avoid integer overflow. CID #1445226
Alan T. DeKok [Fri, 24 May 2019 20:05:03 +0000 (16:05 -0400)] 
try to avoid integer overflow.  CID #1445226

7 years agocheck for bad input. CID #1445233
Alan T. DeKok [Fri, 24 May 2019 20:02:47 +0000 (16:02 -0400)] 
check for bad input.  CID #1445233

7 years agoremove dead code. CID #1445236
Alan T. DeKok [Fri, 24 May 2019 20:00:59 +0000 (16:00 -0400)] 
remove dead code. CID #1445236

7 years agotypo
Alan T. DeKok [Fri, 24 May 2019 20:00:30 +0000 (16:00 -0400)] 
typo

7 years agohoist check to before dereference. CID #1445248
Alan T. DeKok [Fri, 24 May 2019 19:57:57 +0000 (15:57 -0400)] 
hoist check to before dereference.  CID #1445248

7 years agoclose fp before returning. CID #1185992
Alan T. DeKok [Fri, 24 May 2019 19:56:32 +0000 (15:56 -0400)] 
close fp before returning.  CID #1185992

7 years agocheck limits for "data" buffer, too. CID #1198852
Alan T. DeKok [Fri, 24 May 2019 19:54:49 +0000 (15:54 -0400)] 
check limits for "data" buffer, too.  CID #1198852

7 years agoquiet clang scan. ID #1445219
Alan T. DeKok [Fri, 24 May 2019 19:51:46 +0000 (15:51 -0400)] 
quiet clang scan.  ID #1445219

7 years agofree the thing we alloced. CID #1445240
Alan T. DeKok [Fri, 24 May 2019 19:48:46 +0000 (15:48 -0400)] 
free the thing we alloced.  CID #1445240

there's no need to have a value_box here, as we just have a
C string pointer

7 years agocheck size of buffer. CID #1445214
Alan T. DeKok [Fri, 24 May 2019 19:45:37 +0000 (15:45 -0400)] 
check size of buffer.  CID #1445214

7 years agocheck return valid. CID #1445212
Alan T. DeKok [Fri, 24 May 2019 19:43:32 +0000 (15:43 -0400)] 
check return valid.  CID #1445212

7 years agoRemove unused timeval utility functions
Arran Cudbard-Bell [Fri, 24 May 2019 19:58:17 +0000 (15:58 -0400)] 
Remove unused timeval utility functions

7 years agoUse new time delta conversion function in radsniff
Arran Cudbard-Bell [Fri, 24 May 2019 19:58:04 +0000 (15:58 -0400)] 
Use new time delta conversion function in radsniff

7 years agoRemove timeval from ocsp
Arran Cudbard-Bell [Fri, 24 May 2019 19:57:40 +0000 (15:57 -0400)] 
Remove timeval from ocsp

7 years agoRemove timespec subtract
Arran Cudbard-Bell [Fri, 24 May 2019 19:47:28 +0000 (15:47 -0400)] 
Remove timespec subtract

We can probably remove most of the timeval functions too...

7 years agoConvert retry delay to time_delta
Arran Cudbard-Bell [Fri, 24 May 2019 19:46:22 +0000 (15:46 -0400)] 
Convert retry delay to time_delta

7 years agoConvert the rest of the delay and interval values to time_delta
Arran Cudbard-Bell [Fri, 24 May 2019 19:45:48 +0000 (15:45 -0400)] 
Convert the rest of the delay and interval values to time_delta

They were already assumed to be NSEC values in various expressions after the last cleanup... oops.

7 years agoRemove more timevals from the LDAP library
Arran Cudbard-Bell [Fri, 24 May 2019 19:44:54 +0000 (15:44 -0400)] 
Remove more timevals from the LDAP library

7 years agoRemove timeval from ldap_result
Arran Cudbard-Bell [Fri, 24 May 2019 19:35:11 +0000 (15:35 -0400)] 
Remove timeval from ldap_result

7 years agoNot used
Arran Cudbard-Bell [Fri, 24 May 2019 19:33:31 +0000 (15:33 -0400)] 
Not used

7 years agoSimplify setting timeout values on LDAP connections
Arran Cudbard-Bell [Fri, 24 May 2019 19:32:50 +0000 (15:32 -0400)] 
Simplify setting timeout values on LDAP connections

7 years agoRemove timeval from sync_touch
Arran Cudbard-Bell [Fri, 24 May 2019 19:07:02 +0000 (15:07 -0400)] 
Remove timeval from sync_touch

7 years agoRemove fr_event_timer_insert
Arran Cudbard-Bell [Fri, 24 May 2019 19:02:59 +0000 (15:02 -0400)] 
Remove fr_event_timer_insert

7 years agotimeval2ntp and ntp2timeval not actually used anywhere...
Arran Cudbard-Bell [Fri, 24 May 2019 19:02:05 +0000 (15:02 -0400)] 
timeval2ntp and ntp2timeval not actually used anywhere...

7 years agoRemove support for %pT
Arran Cudbard-Bell [Fri, 24 May 2019 19:00:39 +0000 (15:00 -0400)] 
Remove support for %pT

7 years agoRemove timeval from udpfromto
Arran Cudbard-Bell [Fri, 24 May 2019 18:59:47 +0000 (14:59 -0400)] 
Remove timeval from udpfromto

Only a few small uses

7 years agoPass 0 not NULL for timeout
Arran Cudbard-Bell [Fri, 24 May 2019 18:58:18 +0000 (14:58 -0400)] 
Pass 0 not NULL for timeout

7 years agoDie timeval die
Arran Cudbard-Bell [Fri, 24 May 2019 18:58:08 +0000 (14:58 -0400)] 
Die timeval die

7 years agoRemove timeout from dhcpclient
Arran Cudbard-Bell [Fri, 24 May 2019 18:57:05 +0000 (14:57 -0400)] 
Remove timeout from dhcpclient

7 years agoRemove timeval from proto_ldap_sync
Arran Cudbard-Bell [Fri, 24 May 2019 18:50:42 +0000 (14:50 -0400)] 
Remove timeval from proto_ldap_sync

7 years agoRemove timeval from rlm_redis_ippool_tool
Arran Cudbard-Bell [Fri, 24 May 2019 18:49:52 +0000 (14:49 -0400)] 
Remove timeval from rlm_redis_ippool_tool

7 years agoRemove timeval from oracle driver
Arran Cudbard-Bell [Fri, 24 May 2019 18:49:40 +0000 (14:49 -0400)] 
Remove timeval from oracle driver

7 years agoremove timeval from test utilities
Arran Cudbard-Bell [Fri, 24 May 2019 18:49:29 +0000 (14:49 -0400)] 
remove timeval from test utilities

7 years agoFix mod_conn_create in rlm_krb5
Arran Cudbard-Bell [Fri, 24 May 2019 18:17:30 +0000 (14:17 -0400)] 
Fix mod_conn_create in rlm_krb5

7 years agoRemove last traces of FR_TYPE_TIMEVAL
Arran Cudbard-Bell [Fri, 24 May 2019 18:08:30 +0000 (14:08 -0400)] 
Remove last traces of FR_TYPE_TIMEVAL

7 years agoStrip FR_TYPE_TIMEVAL from module configurations and replace with FR_TYPE_TIME_DELTA
Arran Cudbard-Bell [Fri, 24 May 2019 18:04:11 +0000 (14:04 -0400)] 
Strip FR_TYPE_TIMEVAL from module configurations and replace with FR_TYPE_TIME_DELTA

Remove timevals from:
exec API
connection pool API
LDAP library
delay module
many other modules

7 years agoFormatting
Arran Cudbard-Bell [Fri, 24 May 2019 17:34:46 +0000 (13:34 -0400)] 
Formatting

7 years agoinitialize variable. CID #1445211
Alan T. DeKok [Fri, 24 May 2019 17:33:48 +0000 (13:33 -0400)] 
initialize variable.  CID #1445211

7 years agoq cannot be NULL here. CID #1445208
Alan T. DeKok [Fri, 24 May 2019 17:30:48 +0000 (13:30 -0400)] 
q cannot be NULL here.  CID #1445208

7 years agoremove redundant branches. CID #1445207
Alan T. DeKok [Fri, 24 May 2019 17:29:21 +0000 (13:29 -0400)] 
remove redundant branches.  CID #1445207

7 years agocheck for accept_fd <0, not <= 0. CID #1445242
Alan T. DeKok [Fri, 24 May 2019 17:27:15 +0000 (13:27 -0400)] 
check for accept_fd <0, not <= 0.  CID #1445242

7 years agova_end(aq) not ap. CID #1445229
Alan T. DeKok [Fri, 24 May 2019 17:25:16 +0000 (13:25 -0400)] 
va_end(aq) not ap.  CID #1445229

7 years agocheck for fp. CID #1445222
Alan T. DeKok [Fri, 24 May 2019 17:21:54 +0000 (13:21 -0400)] 
check for fp.  CID #1445222

7 years agoskip coverity issues. CID #1445225
Alan T. DeKok [Fri, 24 May 2019 17:20:18 +0000 (13:20 -0400)] 
skip coverity issues.  CID #1445225

7 years agocheck for sock_fd < 0. CID #1271302, 1271303, 1339772
Alan T. DeKok [Fri, 24 May 2019 17:17:34 +0000 (13:17 -0400)] 
check for sock_fd < 0.  CID #127130212713031339772

7 years agofix NULL dereference if the dicts are broken. CID #1445245
Alan T. DeKok [Fri, 24 May 2019 17:15:57 +0000 (13:15 -0400)] 
fix NULL dereference if the dicts are broken.  CID #1445245

7 years agoadd mod-config/csv
Alan T. DeKok [Fri, 24 May 2019 14:20:15 +0000 (10:20 -0400)] 
add mod-config/csv

7 years agoset OK at the end of the function instead of the start
Alan T. DeKok [Fri, 24 May 2019 13:41:48 +0000 (09:41 -0400)] 
set OK at the end of the function instead of the start

Maybe this will un-confuse coverity?

7 years agotime.h: Add nonnull hint
Jorge Pereira [Fri, 24 May 2019 03:07:49 +0000 (00:07 -0300)] 
time.h: Add nonnull hint

7 years agorlm_linelog: Update to use fr_time_delta_t
Jorge Pereira [Fri, 24 May 2019 03:00:20 +0000 (00:00 -0300)] 
rlm_linelog: Update to use fr_time_delta_t

7 years agomisc.c: Update fr_writev() to use fr_time_delta_t
Jorge Pereira [Fri, 24 May 2019 03:00:16 +0000 (00:00 -0300)] 
misc.c: Update fr_writev() to use fr_time_delta_t

7 years agomain_loop.c: Fix typo
Jorge Pereira [Fri, 24 May 2019 02:42:02 +0000 (23:42 -0300)] 
main_loop.c: Fix typo

7 years agomisc.c: Fix redefinition of 'NSEC'
Jorge Pereira [Fri, 24 May 2019 02:36:38 +0000 (23:36 -0300)] 
misc.c: Fix redefinition of 'NSEC'

7 years agoSwitch to initialiser macros for fr_time_delta_to_timeval and fr_time_delta_to_timspec
Arran Cudbard-Bell [Fri, 24 May 2019 02:33:12 +0000 (22:33 -0400)] 
Switch to initialiser macros for fr_time_delta_to_timeval and fr_time_delta_to_timspec

7 years agoFix FR_TIME_DELTA_BOUND_CHECK to take NSEC, so we can easily pass other fr_time_delta...
Arran Cudbard-Bell [Fri, 24 May 2019 02:11:18 +0000 (22:11 -0400)] 
Fix FR_TIME_DELTA_BOUND_CHECK to take NSEC, so we can easily pass other fr_time_delta_t values in as the _bound

7 years agoFR_TYPE_TIME_DELTA case
Arran Cudbard-Bell [Thu, 23 May 2019 20:36:32 +0000 (16:36 -0400)] 
FR_TYPE_TIME_DELTA case

7 years agoFix type check for FR_TYPE_TIME_DELTA
Arran Cudbard-Bell [Thu, 23 May 2019 20:31:52 +0000 (16:31 -0400)] 
Fix type check for FR_TYPE_TIME_DELTA

7 years agocall realloc for strings so that they're the right size
Alan T. DeKok [Thu, 23 May 2019 19:32:09 +0000 (15:32 -0400)] 
call realloc for strings so that they're the right size

7 years agoenable data type tests
Alan T. DeKok [Thu, 23 May 2019 15:23:14 +0000 (11:23 -0400)] 
enable data type tests

7 years agomove 'rt' to fr_time_delta_t
Alan T. DeKok [Thu, 23 May 2019 15:20:20 +0000 (11:20 -0400)] 
move 'rt' to fr_time_delta_t

7 years agomove to using fr_time_delta_t
Alan T. DeKok [Thu, 23 May 2019 15:17:39 +0000 (11:17 -0400)] 
move to using fr_time_delta_t

7 years agomove to using fr_time_t
Alan T. DeKok [Thu, 23 May 2019 15:12:28 +0000 (11:12 -0400)] 
move to using fr_time_t

7 years agoMerge pull request #2711 from mattrose/checkout-url
Alan DeKok [Thu, 23 May 2019 14:38:23 +0000 (10:38 -0400)] 
Merge pull request #2711 from mattrose/checkout-url

get git url from job configuration

7 years agoget git url from job configuration 2711/head
Matt Rose [Fri, 17 May 2019 18:03:44 +0000 (14:03 -0400)] 
get git url from job configuration

7 years agodo print / parse / cmp for data type comparisons
Alan T. DeKok [Thu, 23 May 2019 13:26:57 +0000 (09:26 -0400)] 
do print / parse / cmp for data type comparisons

to be sure that when we parse something and then print it,
the thing we printed can get parsed to be the same thing

7 years agoremove reference to gettimeofday from comments
Alan T. DeKok [Thu, 23 May 2019 11:31:46 +0000 (07:31 -0400)] 
remove reference to gettimeofday from comments

7 years agoremove WIN32 wrapper for gettimeofday
Alan T. DeKok [Thu, 23 May 2019 11:30:37 +0000 (07:30 -0400)] 
remove WIN32 wrapper for gettimeofday

we haven't built on Windows in a long time

7 years agorlm_sigtran: Move to fr_time_t
Jorge Pereira [Thu, 23 May 2019 00:39:20 +0000 (21:39 -0300)] 
rlm_sigtran: Move to fr_time_t

7 years agosrc/modules: Move to fr_time_t
Jorge Pereira [Wed, 22 May 2019 22:54:24 +0000 (19:54 -0300)] 
src/modules: Move to fr_time_t

7 years agosrc/lib: Move to fr_time_t
Jorge Pereira [Wed, 22 May 2019 22:54:16 +0000 (19:54 -0300)] 
src/lib: Move to fr_time_t

7 years agosrc/tests: Move to fr_time_t
Jorge Pereira [Wed, 22 May 2019 22:53:43 +0000 (19:53 -0300)] 
src/tests: Move to fr_time_t

7 years agorlm_redis_ippol: Move to fr_time_t
Jorge Pereira [Wed, 22 May 2019 22:23:46 +0000 (19:23 -0300)] 
rlm_redis_ippol: Move to fr_time_t

7 years agotests/util/message_set_test.c: Move to fr_time_t
Jorge Pereira [Wed, 22 May 2019 22:21:53 +0000 (19:21 -0300)] 
tests/util/message_set_test.c: Move to fr_time_t

7 years agoldap/connection.c: Fix _ldap_connection_init()
Jorge Pereira [Thu, 23 May 2019 00:46:28 +0000 (21:46 -0300)] 
ldap/connection.c: Fix _ldap_connection_init()

7 years agoRevert "ldap/connection.c: Fix _ldap_connection_init()"
Arran Cudbard-Bell [Wed, 22 May 2019 23:56:47 +0000 (19:56 -0400)] 
Revert "ldap/connection.c: Fix _ldap_connection_init()"

7 years agoMerge pull request #2707 from jpereira/v4/fix22
Alan DeKok [Wed, 22 May 2019 21:48:23 +0000 (17:48 -0400)] 
Merge pull request #2707 from jpereira/v4/fix22

ldap/connection.c: Fix _ldap_connection_init()

7 years agoldap/connection.c: Fix _ldap_connection_init() 2707/head
Jorge Pereira [Wed, 22 May 2019 21:24:54 +0000 (18:24 -0300)] 
ldap/connection.c: Fix _ldap_connection_init()