]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
7 years agoAdd devcflags and ldflags last so they don't much with autoconf
Arran Cudbard-Bell [Tue, 12 Mar 2019 07:57:46 +0000 (15:57 +0800)] 
Add devcflags and ldflags last so they don't much with autoconf

7 years ago...apparently not
Arran Cudbard-Bell [Tue, 12 Mar 2019 07:41:55 +0000 (15:41 +0800)] 
...apparently not

7 years agoSee if this fixes normal redis tests
Arran Cudbard-Bell [Tue, 12 Mar 2019 07:19:11 +0000 (15:19 +0800)] 
See if this fixes normal redis tests

7 years agoFix cluster reset
Arran Cudbard-Bell [Tue, 12 Mar 2019 06:39:17 +0000 (14:39 +0800)] 
Fix cluster reset

7 years agoAny tests which checks for error output has to touch the receipt file itself if it...
Arran Cudbard-Bell [Tue, 12 Mar 2019 06:39:05 +0000 (14:39 +0800)] 
Any tests which checks for error output has to touch the receipt file itself if it finds what it expected

7 years agoUse the same reset script for ippool and normal redis tests
Arran Cudbard-Bell [Tue, 12 Mar 2019 04:41:03 +0000 (12:41 +0800)] 
Use the same reset script for ippool and normal redis tests

7 years agoNo longer used
Arran Cudbard-Bell [Tue, 12 Mar 2019 02:51:24 +0000 (10:51 +0800)] 
No longer used

7 years agoAlloc tp_ctx from the autofree ctx
Arran Cudbard-Bell [Tue, 12 Mar 2019 02:10:24 +0000 (10:10 +0800)] 
Alloc tp_ctx from the autofree ctx

7 years agoAssert if dl_loader struct isn't initialised and initialist the dl_loader struct...
Arran Cudbard-Bell [Tue, 12 Mar 2019 01:35:40 +0000 (09:35 +0800)] 
Assert if dl_loader struct isn't initialised and initialist the dl_loader struct in unit_test_attribute Closes #2568

7 years agoremove output file on error
Alan T. DeKok [Mon, 11 Mar 2019 21:59:52 +0000 (17:59 -0400)] 
remove output file on error

7 years agomore use $(OUTPUT)
Alan T. DeKok [Mon, 11 Mar 2019 21:46:17 +0000 (17:46 -0400)] 
more use $(OUTPUT)

7 years agoone last typo?
Alan T. DeKok [Mon, 11 Mar 2019 21:18:53 +0000 (17:18 -0400)] 
one last typo?

7 years agotypos
Alan T. DeKok [Mon, 11 Mar 2019 20:42:03 +0000 (16:42 -0400)] 
typos

7 years agomore $(BUILD_DIR)/tests/keywords to $(OUTPUT)
Alan T. DeKok [Mon, 11 Mar 2019 20:40:45 +0000 (16:40 -0400)] 
more $(BUILD_DIR)/tests/keywords to $(OUTPUT)

7 years agomove to new template
Alan T. DeKok [Mon, 11 Mar 2019 20:02:39 +0000 (16:02 -0400)] 
move to new template

7 years agomore simplifications
Alan T. DeKok [Mon, 11 Mar 2019 19:53:06 +0000 (15:53 -0400)] 
more simplifications

7 years agoreset more re-used names
Alan T. DeKok [Mon, 11 Mar 2019 19:52:39 +0000 (15:52 -0400)] 
reset more re-used names

7 years agomove to new template
Alan T. DeKok [Mon, 11 Mar 2019 19:52:26 +0000 (15:52 -0400)] 
move to new template

7 years agomove to new test template
Alan T. DeKok [Mon, 11 Mar 2019 19:39:24 +0000 (15:39 -0400)] 
move to new test template

7 years agothis file doesn't exist
Alan T. DeKok [Mon, 11 Mar 2019 19:36:55 +0000 (15:36 -0400)] 
this file doesn't exist

7 years agomake sure that the file isn't empty
Alan T. DeKok [Mon, 11 Mar 2019 19:31:08 +0000 (15:31 -0400)] 
make sure that the file isn't empty

otherwise Make will re-run the rules on every build

7 years agoreorganize and clean up
Alan T. DeKok [Mon, 11 Mar 2019 19:09:45 +0000 (15:09 -0400)] 
reorganize and clean up

so that the definitions come from templates as much as possible,
instead of re-doing everything

7 years agoformatting
Alan T. DeKok [Sun, 10 Mar 2019 15:24:38 +0000 (11:24 -0400)] 
formatting

7 years agorlm_lua: Print the version
Jorge Pereira [Sat, 9 Mar 2019 20:19:15 +0000 (17:19 -0300)] 
rlm_lua: Print the version

7 years agoFix test target
Arran Cudbard-Bell [Mon, 11 Mar 2019 11:40:32 +0000 (19:40 +0800)] 
Fix test target

7 years agoFix circular dependency which causes the tests to always run
Arran Cudbard-Bell [Mon, 11 Mar 2019 11:34:09 +0000 (19:34 +0800)] 
Fix circular dependency which causes the tests to always run

7 years agoManually touch receipt file if the test is meant to error
Arran Cudbard-Bell [Mon, 11 Mar 2019 10:36:28 +0000 (18:36 +0800)] 
Manually touch receipt file if the test is meant to error

7 years agoMore test fixups
Arran Cudbard-Bell [Mon, 11 Mar 2019 10:00:31 +0000 (18:00 +0800)] 
More test fixups

7 years agoFix whitespace
Arran Cudbard-Bell [Mon, 11 Mar 2019 08:40:54 +0000 (16:40 +0800)] 
Fix whitespace

7 years agoChange rcode to ret
Arran Cudbard-Bell [Mon, 11 Mar 2019 08:08:06 +0000 (16:08 +0800)] 
Change rcode to ret

7 years agoUse EXIT_WITH_FAILURE macros in more utilities
Arran Cudbard-Bell [Mon, 11 Mar 2019 07:46:18 +0000 (15:46 +0800)] 
Use EXIT_WITH_FAILURE macros in more utilities

7 years agotests: Add '-r' (receipt_file) option in unit tools
Arran Cudbard-Bell [Fri, 8 Mar 2019 20:10:52 +0000 (17:10 -0300)] 
tests: Add '-r' (receipt_file) option in unit tools

7 years agotests: Fix missing '&' in src/tests/map/count-error
Jorge Pereira [Fri, 8 Mar 2019 16:33:17 +0000 (13:33 -0300)] 
tests: Fix missing '&' in src/tests/map/count-error

7 years agotests: Add missed 'clean.tests.' target
Jorge Pereira [Fri, 8 Mar 2019 19:23:19 +0000 (16:23 -0300)] 
tests: Add missed 'clean.tests.' target

7 years agotests: Fix clean.tests.modules target
Jorge Pereira [Fri, 8 Mar 2019 19:24:36 +0000 (16:24 -0300)] 
tests: Fix clean.tests.modules target

ff

7 years agomisc.c: Add new fr_file_touch/fr_file_unlink
Jorge Pereira [Fri, 8 Mar 2019 19:45:43 +0000 (16:45 -0300)] 
misc.c: Add new fr_file_touch/fr_file_unlink

7 years agoAdd missed 'clean.tests' target
Jorge Pereira [Fri, 8 Mar 2019 19:20:30 +0000 (16:20 -0300)] 
Add missed 'clean.tests' target

7 years agoUse lua_tonumber for floats and lua_tointeger for integers
Arran Cudbard-Bell [Mon, 11 Mar 2019 07:12:45 +0000 (15:12 +0800)] 
Use lua_tonumber for floats and lua_tointeger for integers

7 years agoFormatting
Arran Cudbard-Bell [Mon, 11 Mar 2019 07:12:30 +0000 (15:12 +0800)] 
Formatting

7 years agoFix log level typedef
Arran Cudbard-Bell [Mon, 11 Mar 2019 07:11:58 +0000 (15:11 +0800)] 
Fix log level typedef

7 years agoAdd example invocations back
Arran Cudbard-Bell [Mon, 11 Mar 2019 07:02:44 +0000 (15:02 +0800)] 
Add example invocations back

7 years agodo_lua doesn't access global instance data
Arran Cudbard-Bell [Mon, 11 Mar 2019 03:36:23 +0000 (11:36 +0800)] 
do_lua doesn't access global instance data

7 years agoRemove key/mutex from rlm_lua
Arran Cudbard-Bell [Mon, 11 Mar 2019 03:32:22 +0000 (11:32 +0800)] 
Remove key/mutex from rlm_lua

The original code was pre-thread-instances.  This is like vestigial.

7 years agoMerge pull request #2564 from jpereira/v4/rlm_lua-update
Alan DeKok [Sun, 10 Mar 2019 15:21:05 +0000 (11:21 -0400)] 
Merge pull request #2564 from jpereira/v4/rlm_lua-update

rlm_lua: Update the sample src/modules/rlm_lua/example.lua

7 years agoLet PgPool detect the stored procedure as needing a write transaction.
Nathan Ward [Sat, 9 Mar 2019 02:27:54 +0000 (15:27 +1300)] 
Let PgPool detect the stored procedure as needing a write transaction.

- Add an SQL comment, and documentation for the same, which triggers PgPool to not load balance this to a read-only server, and instead send it to a write server. As noted, this does not have any negative effect if PgPool is not in use, so it is useful to have here to avoid problems caused by someone starting to used this procedure when they've got a working PgPool/PostgreSQL installation already.

Signed-off-by: Nathan Ward <nward@searchlight.nz>
7 years agoFix the NULL comparison.
Nathan Ward [Sat, 9 Mar 2019 02:27:34 +0000 (15:27 +1300)] 
Fix the NULL comparison.

Signed-off-by: Nathan Ward <nward@searchlight.nz>
7 years agorlm_lua: Update the sample src/modules/rlm_lua/example.lua 2564/head
Jorge Pereira [Sat, 9 Mar 2019 20:28:07 +0000 (17:28 -0300)] 
rlm_lua: Update the sample src/modules/rlm_lua/example.lua

7 years agouse lua_tointeger()
Alan T. DeKok [Sat, 9 Mar 2019 13:52:02 +0000 (08:52 -0500)] 
use lua_tointeger()

which is more likely what we want.  That returns ptrdiff_t,
which is likely OK

7 years agouse correct type
Alan T. DeKok [Sat, 9 Mar 2019 13:44:27 +0000 (08:44 -0500)] 
use correct type

7 years agostupid doxygen nonsense
Alan T. DeKok [Sat, 9 Mar 2019 13:42:53 +0000 (08:42 -0500)] 
stupid doxygen nonsense

7 years agojlibtool: special case linking against rlm_ libraries
Matthew Newton [Fri, 8 Mar 2019 22:15:02 +0000 (22:15 +0000)] 
jlibtool: special case linking against rlm_ libraries

They don't start with "lib"...

7 years agoReturn 0 if internal dict not loaded in fr_dict_attr_by_name_substr
Arran Cudbard-Bell [Fri, 8 Mar 2019 10:16:37 +0000 (18:16 +0800)] 
Return 0 if internal dict not loaded in fr_dict_attr_by_name_substr

7 years agoBoth args can be NULL
Arran Cudbard-Bell [Fri, 8 Mar 2019 05:50:14 +0000 (13:50 +0800)] 
Both args can be NULL

7 years agoTypo
Arran Cudbard-Bell [Fri, 8 Mar 2019 05:49:55 +0000 (13:49 +0800)] 
Typo

7 years agoTry with just the ippool tests
Arran Cudbard-Bell [Fri, 8 Mar 2019 05:46:57 +0000 (13:46 +0800)] 
Try with just the ippool tests

7 years agoUse the cast functions in the lua unmarshalling code
Arran Cudbard-Bell [Fri, 8 Mar 2019 03:26:28 +0000 (11:26 +0800)] 
Use the cast functions in the lua unmarshalling code

7 years agoAdd fr_value_box_bstrndup_shallow
Arran Cudbard-Bell [Fri, 8 Mar 2019 03:24:42 +0000 (11:24 +0800)] 
Add fr_value_box_bstrndup_shallow

Fix other shallow functions to use a void return type

7 years agoUse the fancy error marker macro to point to where the field lookups fail
Arran Cudbard-Bell [Fri, 8 Mar 2019 02:50:07 +0000 (10:50 +0800)] 
Use the fancy error marker macro to point to where the field lookups fail

7 years agoReturn with error code if internal dictionaries are not available
Arran Cudbard-Bell [Fri, 8 Mar 2019 02:32:47 +0000 (10:32 +0800)] 
Return with error code if internal dictionaries are not available

7 years agoFix flm_lua_get_field
Arran Cudbard-Bell [Fri, 8 Mar 2019 02:31:53 +0000 (10:31 +0800)] 
Fix flm_lua_get_field

7 years agoUse CRYPTO_memcmp in more places in the sim library
Arran Cudbard-Bell [Fri, 8 Mar 2019 01:18:27 +0000 (09:18 +0800)] 
Use CRYPTO_memcmp in more places in the sim library

7 years agoRemove trigger_exec_free() call. We don't use triggers here
Arran Cudbard-Bell [Fri, 8 Mar 2019 00:47:16 +0000 (08:47 +0800)] 
Remove trigger_exec_free() call.  We don't use triggers here

7 years agoUpdate ippool help text
Arran Cudbard-Bell [Fri, 8 Mar 2019 00:46:59 +0000 (08:46 +0800)] 
Update ippool help text

7 years agoMove set inside of cluster setup loop in case it takes a while for the cluster to...
Arran Cudbard-Bell [Thu, 7 Mar 2019 13:32:17 +0000 (21:32 +0800)] 
Move set inside of cluster setup loop in case it takes a while for the cluster to come up

7 years agoReduce amount of debug output when waiting for the cluster to come up
Arran Cudbard-Bell [Thu, 7 Mar 2019 09:43:36 +0000 (17:43 +0800)] 
Reduce amount of debug output when waiting for the cluster to come up

7 years agoUse talloc_get_type_abort_const in redis xlat functions
Arran Cudbard-Bell [Thu, 7 Mar 2019 08:27:06 +0000 (16:27 +0800)] 
Use talloc_get_type_abort_const in redis xlat functions

7 years agoFix update where no range identifier is specified when the addresses where added
Arran Cudbard-Bell [Thu, 7 Mar 2019 08:22:25 +0000 (16:22 +0800)] 
Fix update where no range identifier is specified when the addresses where added

7 years agoDon't free the reply if we're skipping over the element, redisReplyFree walks over...
Arran Cudbard-Bell [Thu, 7 Mar 2019 08:18:54 +0000 (16:18 +0800)] 
Don't free the reply if we're skipping over the element, redisReplyFree walks over structures recursively freeing all elements

7 years agoEnable the Redis and Redis IP Pool tests
Arran Cudbard-Bell [Thu, 7 Mar 2019 07:37:16 +0000 (15:37 +0800)] 
Enable the Redis and Redis IP Pool tests

7 years agoUpdate the redis_ippool test cases so they use newer unlang/xlat syntax where appropriate
Arran Cudbard-Bell [Thu, 7 Mar 2019 07:37:01 +0000 (15:37 +0800)] 
Update the redis_ippool test cases so they use newer unlang/xlat syntax where appropriate

Use RADIUS attributes everywhere instead of DHCP (we don't allow DHCP outside of DHCP virtual servers now.

and fix other minor things like utility paths...

7 years agoTypo in redis cluster log message
Arran Cudbard-Bell [Thu, 7 Mar 2019 06:19:54 +0000 (14:19 +0800)] 
Typo in redis cluster log message

7 years agoFix issue where no ips are added where the initial request triggers a cluster remap...
Arran Cudbard-Bell [Thu, 7 Mar 2019 06:19:23 +0000 (14:19 +0800)] 
Fix issue where no ips are added where the initial request triggers a cluster remap and the number of IPs allocated is less than MAX_PIPLINED

7 years agodon't actually need to set module name
Arran Cudbard-Bell [Thu, 7 Mar 2019 06:16:11 +0000 (14:16 +0800)] 
don't actually need to set module name

7 years agoCleanup log output in rlm_redis_ippool_tool
Arran Cudbard-Bell [Thu, 7 Mar 2019 05:48:57 +0000 (13:48 +0800)] 
Cleanup log output in rlm_redis_ippool_tool

7 years agoFix request leak in unit_test_module on error, by smashing it with a big hammer...
Arran Cudbard-Bell [Thu, 7 Mar 2019 05:24:38 +0000 (13:24 +0800)] 
Fix request leak in unit_test_module on error, by smashing it with a big hammer...

7 years agoSwitch fr_redis_pipline_free to inline function
Arran Cudbard-Bell [Thu, 7 Mar 2019 05:24:05 +0000 (13:24 +0800)] 
Switch fr_redis_pipline_free to inline function

7 years agoFormatting
Arran Cudbard-Bell [Thu, 7 Mar 2019 05:23:51 +0000 (13:23 +0800)] 
Formatting

7 years agoRename reply_num to reply_cnt
Arran Cudbard-Bell [Thu, 7 Mar 2019 05:23:44 +0000 (13:23 +0800)] 
Rename reply_num to reply_cnt

7 years agoFormatting
Arran Cudbard-Bell [Thu, 7 Mar 2019 05:22:49 +0000 (13:22 +0800)] 
Formatting

7 years agoDon't leak reply objects the any time the script needs to be loaded
Arran Cudbard-Bell [Thu, 7 Mar 2019 05:22:32 +0000 (13:22 +0800)] 
Don't leak reply objects the any time the script needs to be loaded

This is a pretty minor leak as the scripts are usually only loaded on startup, but if someone kept trashing the script cache, this could become an issue.

7 years agoUse proper type for s_ret so we get enum values in the debugger
Arran Cudbard-Bell [Thu, 7 Mar 2019 05:21:17 +0000 (13:21 +0800)] 
Use proper type for s_ret so we get enum values in the debugger

7 years agoRemove trigger and dictionary init from rlm_redis_ipool_tool
Arran Cudbard-Bell [Wed, 6 Mar 2019 12:40:03 +0000 (20:40 +0800)] 
Remove trigger and dictionary init from rlm_redis_ipool_tool

Fix leak of conf->cs too so we get a clean exit under ASAN

7 years agoFix memory leak in fr_redis_get_version
Arran Cudbard-Bell [Wed, 6 Mar 2019 12:10:51 +0000 (20:10 +0800)] 
Fix memory leak in fr_redis_get_version

7 years agoAdd additional redis_node and redis_remap xlats so that we can get the redis tests...
Arran Cudbard-Bell [Wed, 6 Mar 2019 12:10:28 +0000 (20:10 +0800)] 
Add additional redis_node and redis_remap xlats so that we can get the redis tests functioning reliably again

The root cause of this problem is that the utility used to setup the cluster no longer assigned key ranges in a deterministic way.

The tests assumed data would be written to one node, and it was instead written to another.

7 years agoAdd additional functions to allow remaps to be triggered, and to lookup the node...
Arran Cudbard-Bell [Wed, 6 Mar 2019 11:50:33 +0000 (19:50 +0800)] 
Add additional functions to allow remaps to be triggered, and to lookup the node that should be serviced by a key

7 years agoFormatting
Arran Cudbard-Bell [Wed, 6 Mar 2019 11:49:25 +0000 (19:49 +0800)] 
Formatting

7 years agoFix edge case with fr_vasprintf
Arran Cudbard-Bell [Wed, 6 Mar 2019 11:23:52 +0000 (19:23 +0800)] 
Fix edge case with fr_vasprintf

%pV:%u would print the boxed value and a pointer to the box.

7 years agoDeal with REDIS_RCODE_MOVE for directed queries (queries against a specific node)
Arran Cudbard-Bell [Wed, 6 Mar 2019 02:31:47 +0000 (10:31 +0800)] 
Deal with REDIS_RCODE_MOVE for directed queries (queries against a specific node)

Before the xlat would just return an empty result and not indicate why

7 years agoCreate value boxes from status messages and errors too
Arran Cudbard-Bell [Wed, 6 Mar 2019 02:30:42 +0000 (10:30 +0800)] 
Create value boxes from status messages and errors too

This is actually pretty useful now we have %pV which didn't exist at the time the function was written...

7 years agoHave fr_redis_reply_free set the pointer containing the reply to NULL
Arran Cudbard-Bell [Wed, 6 Mar 2019 02:30:02 +0000 (10:30 +0800)] 
Have fr_redis_reply_free set the pointer containing the reply to NULL

7 years agocomment out test until we figure out why it fails
Alan T. DeKok [Wed, 6 Mar 2019 16:21:05 +0000 (11:21 -0500)] 
comment out test until we figure out why it fails

7 years agoMerge pull request #2556 from jpereira/v4/test1
Alan DeKok [Wed, 6 Mar 2019 15:13:14 +0000 (10:13 -0500)] 
Merge pull request #2556 from jpereira/v4/test1

The 'make test' should call 'tests.bin' first

7 years agoMerge pull request #2555 from jpereira/v4/fix-test
Alan DeKok [Wed, 6 Mar 2019 15:13:00 +0000 (10:13 -0500)] 
Merge pull request #2555 from jpereira/v4/fix-test

binary unit tests

7 years agoThe 'make test' should call 'tests.bin' first 2556/head
Jorge Pereira [Tue, 5 Mar 2019 23:13:52 +0000 (20:13 -0300)] 
The 'make test' should call 'tests.bin' first

7 years agotests.bin: Add unit_test_attribute test 2555/head
Jorge Pereira [Tue, 5 Mar 2019 22:53:41 +0000 (19:53 -0300)] 
tests.bin: Add unit_test_attribute test

7 years agotests.bin: Add tests for smbencrypt result
Jorge Pereira [Tue, 5 Mar 2019 22:15:02 +0000 (19:15 -0300)] 
tests.bin: Add tests for smbencrypt result

7 years agoAdd length parameter to 'ring_buffer_test'
Jorge Pereira [Tue, 5 Mar 2019 22:04:34 +0000 (19:04 -0300)] 
Add length parameter to 'ring_buffer_test'

7 years agotests.bin: Add radsniff interface list test
Jorge Pereira [Tue, 5 Mar 2019 21:54:28 +0000 (18:54 -0300)] 
tests.bin: Add radsniff interface list test

7 years agotests.bin: Add message's set test
Jorge Pereira [Tue, 5 Mar 2019 21:52:17 +0000 (18:52 -0300)] 
tests.bin: Add message's set test

7 years agotests.bin: Add control's test
Jorge Pereira [Tue, 5 Mar 2019 21:50:12 +0000 (18:50 -0300)] 
tests.bin: Add control's test