]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 months agoinitialize buffer to quiet compiler
Alan T. DeKok [Fri, 28 Nov 2025 14:41:45 +0000 (09:41 -0500)] 
initialize buffer to quiet compiler

8 months agoadd more dict functions, and run more dict tests for unit tests
Alan T. DeKok [Thu, 27 Nov 2025 20:56:33 +0000 (15:56 -0500)] 
add more dict functions, and run more dict tests for unit tests

8 months agoupdate with notes for the test that is still failing
Alan T. DeKok [Thu, 27 Nov 2025 20:53:10 +0000 (15:53 -0500)] 
update with notes for the test that is still failing

8 months agomove fixup of attr ref to place where it is called more often
Alan T. DeKok [Thu, 27 Nov 2025 20:43:36 +0000 (15:43 -0500)] 
move fixup of attr ref to place where it is called more often

which results in better tmpl attribute references when there are
aliases

@todo - maybe the check for parent needs to check for FR_TYPE_GROUP,
too?

8 months agocorrect the name
Alan T. DeKok [Thu, 27 Nov 2025 20:20:07 +0000 (15:20 -0500)] 
correct the name

8 months agoadd missing CR/LF
Alan T. DeKok [Thu, 27 Nov 2025 18:16:48 +0000 (13:16 -0500)] 
add missing CR/LF

8 months agocorrect error message
Alan T. DeKok [Thu, 27 Nov 2025 18:02:22 +0000 (13:02 -0500)] 
correct error message

8 months agonote why unions have a key ref
Alan T. DeKok [Thu, 27 Nov 2025 17:52:02 +0000 (12:52 -0500)] 
note why unions have a key ref

arguably this could be replaced by more caching on the stack
during the dictionary parse phase.  But that wouldn't work if new
union members were defined in a different file

8 months agotypo
Alan T. DeKok [Wed, 26 Nov 2025 21:40:20 +0000 (16:40 -0500)] 
typo

8 months agoadd functions to print information about attributes
Alan T. DeKok [Wed, 26 Nov 2025 21:39:17 +0000 (16:39 -0500)] 
add functions to print information about attributes

8 months agoprint out more flags
Alan T. DeKok [Wed, 26 Nov 2025 21:38:35 +0000 (16:38 -0500)] 
print out more flags

8 months agosuppress protocol name after the first level
Alan T. DeKok [Wed, 26 Nov 2025 21:02:17 +0000 (16:02 -0500)] 
suppress protocol name after the first level

8 months agoadd assert to quiet coverity
Alan T. DeKok [Wed, 26 Nov 2025 20:33:44 +0000 (15:33 -0500)] 
add assert to quiet coverity

8 months agoadd recursive option for printing dictionary entries
Alan T. DeKok [Wed, 26 Nov 2025 20:06:25 +0000 (15:06 -0500)] 
add recursive option for printing dictionary entries

8 months agodon't print out the entire environment, and add radict wrapper
Alan T. DeKok [Wed, 26 Nov 2025 19:40:00 +0000 (14:40 -0500)] 
don't print out the entire environment, and add radict wrapper

8 months agofix comment
Alan T. DeKok [Wed, 26 Nov 2025 19:36:27 +0000 (14:36 -0500)] 
fix comment

8 months agoaliases have no data type
Alan T. DeKok [Wed, 26 Nov 2025 19:36:12 +0000 (14:36 -0500)] 
aliases have no data type

8 months agoit helps to check for success, and to produce meaningful errors
Alan T. DeKok [Wed, 26 Nov 2025 18:59:43 +0000 (13:59 -0500)] 
it helps to check for success, and to produce meaningful errors

8 months agoadd more assertions to ensure proper parent/child order
Alan T. DeKok [Wed, 26 Nov 2025 15:08:01 +0000 (10:08 -0500)] 
add more assertions to ensure proper parent/child order

8 months agolimit where ALIASes can go.
Alan T. DeKok [Wed, 26 Nov 2025 14:05:29 +0000 (09:05 -0500)] 
limit where ALIASes can go.

because it doesn't make sense to have them in 'group', for example

8 months agoallow for copying of aliases.
Alan T. DeKok [Wed, 26 Nov 2025 13:36:24 +0000 (08:36 -0500)] 
allow for copying of aliases.

However, the copy code is not done.  Instead, it produces an error
message.  This is better than silently not copying the ALIAS

8 months agodouble-check and limit which type of attributes can have aliases
Alan T. DeKok [Tue, 25 Nov 2025 21:57:02 +0000 (16:57 -0500)] 
double-check and limit which type of attributes can have aliases

8 months agoset a flag when an attribute has an alias
Alan T. DeKok [Tue, 25 Nov 2025 21:56:03 +0000 (16:56 -0500)] 
set a flag when an attribute has an alias

8 months agoclean up and relax checks when copying ENUMs
Alan T. DeKok [Tue, 25 Nov 2025 21:43:00 +0000 (16:43 -0500)] 
clean up and relax checks when copying ENUMs

we can copy ENUMs cross protocol, so long as the fields aren't
'key=..' or FR_TYPE_ATTR

8 months agono need to create an intermediate attribute when cloning
Alan T. DeKok [Tue, 25 Nov 2025 21:42:22 +0000 (16:42 -0500)] 
no need to create an intermediate attribute when cloning

8 months agoleaf attributes no longer get cloned, so delete unused code
Alan T. DeKok [Tue, 25 Nov 2025 17:55:25 +0000 (12:55 -0500)] 
leaf attributes no longer get cloned, so delete unused code

8 months agouse new data type uint32 instead of old integer
Alan T. DeKok [Tue, 25 Nov 2025 16:41:40 +0000 (11:41 -0500)] 
use new data type uint32 instead of old integer

perl -p -i -e 's/(\s+)integer64/$1uint64/;s/(\s+)integer/$1uint32/g' share/dictionary/radius/dictionary.*

8 months agoinsert enum cloning into the correct list
Alan T. DeKok [Tue, 25 Nov 2025 15:04:43 +0000 (10:04 -0500)] 
insert enum cloning into the correct list

instead of the wrong one.

And fix the sanity checks so that they're correct

8 months agoerror out if source DA has no children
Alan T. DeKok [Tue, 25 Nov 2025 03:04:04 +0000 (22:04 -0500)] 
error out if source DA has no children

8 months agotweak sanity checks for src/dst when cloning attributes
Alan T. DeKok [Tue, 25 Nov 2025 02:43:10 +0000 (21:43 -0500)] 
tweak sanity checks for src/dst when cloning attributes

8 months agono need to call dict_attr_acopy_enumv() for enum=...
Alan T. DeKok [Tue, 25 Nov 2025 02:35:46 +0000 (21:35 -0500)] 
no need to call dict_attr_acopy_enumv() for enum=...

now that the ext copy routine for enums does the casts

8 months agoif necessary, cast the enums when copying
Alan T. DeKok [Tue, 25 Nov 2025 02:18:45 +0000 (21:18 -0500)] 
if necessary, cast the enums when copying

8 months agoremove dict_attr_acopy_dict(), and update dict_attr_acopy()
Alan T. DeKok [Mon, 24 Nov 2025 21:07:22 +0000 (16:07 -0500)] 
remove dict_attr_acopy_dict(), and update dict_attr_acopy()

The two functions had some overlap, and dict_attr_acopy() would
initialize the copy with the _sources_ parent, which was wrong.
many of the copy routines need the correct parent during the copy.

8 months agokeys can no longer have children
Alan T. DeKok [Mon, 24 Nov 2025 20:45:36 +0000 (15:45 -0500)] 
keys can no longer have children

8 months agodocs-v4: Update Concepts landing page and nav panel HIVE 4414/6
nolade [Fri, 11 Jul 2025 18:26:48 +0000 (14:26 -0400)] 
docs-v4: Update Concepts landing page and nav panel HIVE 4414/6

8 months agodocs: Reference landing page Updates PR #5678
nolade [Wed, 6 Aug 2025 16:39:10 +0000 (12:39 -0400)] 
docs: Reference landing page Updates PR #5678

8 months agodocs-v4: Build fix - added table delilmiter
nolade [Wed, 19 Nov 2025 16:32:07 +0000 (11:32 -0500)] 
docs-v4: Build fix - added table delilmiter

8 months agolet's clone the various flags, too
Alan T. DeKok [Mon, 24 Nov 2025 17:38:19 +0000 (12:38 -0500)] 
let's clone the various flags, too

8 months agotweak checks for type size
Alan T. DeKok [Mon, 24 Nov 2025 17:19:06 +0000 (12:19 -0500)] 
tweak checks for type size

8 months agoprint types and length, too
Alan T. DeKok [Mon, 24 Nov 2025 17:18:05 +0000 (12:18 -0500)] 
print types and length, too

8 months agomore checks for aliases
Alan T. DeKok [Mon, 24 Nov 2025 13:43:57 +0000 (08:43 -0500)] 
more checks for aliases

8 months agotypo
Alan T. DeKok [Mon, 24 Nov 2025 13:13:06 +0000 (08:13 -0500)] 
typo

8 months agoUpdate docs from sample raddb
Nick Porter [Mon, 24 Nov 2025 10:00:19 +0000 (10:00 +0000)] 
Update docs from sample raddb

8 months agoTypo
Nick Porter [Mon, 24 Nov 2025 09:56:25 +0000 (09:56 +0000)] 
Typo

8 months agoRemove rlm_date config info from sample rlm_cache config
Nick Porter [Mon, 24 Nov 2025 09:54:17 +0000 (09:54 +0000)] 
Remove rlm_date config info from sample rlm_cache config

8 months agoFormatting
Nick Porter [Mon, 24 Nov 2025 09:51:29 +0000 (09:51 +0000)] 
Formatting

8 months agoRemove & from comments
Nick Porter [Mon, 24 Nov 2025 09:47:29 +0000 (09:47 +0000)] 
Remove & from comments

8 months agoAdd client_hello_parse option to enable extraction of Client Hello data
Nick Porter [Mon, 24 Nov 2025 09:46:54 +0000 (09:46 +0000)] 
Add client_hello_parse option to enable extraction of Client Hello data

8 months agoDefine callback for extracting data from TLS Client Hello
Nick Porter [Mon, 24 Nov 2025 09:32:52 +0000 (09:32 +0000)] 
Define callback for extracting data from TLS Client Hello

8 months agoAdd dictionary entries for TLS Client Hello
Nick Porter [Mon, 24 Nov 2025 09:29:55 +0000 (09:29 +0000)] 
Add dictionary entries for TLS Client Hello

8 months agoUse log_request_proto_pair_list when reporting what will be sent
Nick Porter [Mon, 24 Nov 2025 08:45:02 +0000 (08:45 +0000)] 
Use log_request_proto_pair_list when reporting what will be sent

So we don't incorrectly report internal attributes as being sent.

8 months agoremove migration flag for unions
Alan T. DeKok [Mon, 24 Nov 2025 01:36:43 +0000 (20:36 -0500)] 
remove migration flag for unions

8 months agoremove hacks for key fields
Alan T. DeKok [Mon, 24 Nov 2025 01:33:02 +0000 (20:33 -0500)] 
remove hacks for key fields

8 months agoremove STRUCT dictionary keyword
Alan T. DeKok [Mon, 24 Nov 2025 01:19:19 +0000 (20:19 -0500)] 
remove STRUCT dictionary keyword

it is no longer necessary

8 months agostart removing the ability for key fields to have children
Alan T. DeKok [Sun, 23 Nov 2025 19:07:27 +0000 (14:07 -0500)] 
start removing the ability for key fields to have children

8 months agomove final tests to new union syntax
Alan T. DeKok [Sun, 23 Nov 2025 14:35:45 +0000 (09:35 -0500)] 
move final tests to new union syntax

8 months agoprint out the filter pairs, for laziness
Alan T. DeKok [Sun, 23 Nov 2025 14:34:15 +0000 (09:34 -0500)] 
print out the filter pairs, for laziness

8 months agomove fprintf pair routines to pair_print
Alan T. DeKok [Sun, 23 Nov 2025 14:14:39 +0000 (09:14 -0500)] 
move fprintf pair routines to pair_print

8 months agotake the raw attribute number from the value of the key field
Alan T. DeKok [Sun, 23 Nov 2025 14:02:17 +0000 (09:02 -0500)] 
take the raw attribute number from the value of the key field

8 months agoadd helper function to turn any integer type into uint64_t
Alan T. DeKok [Sun, 23 Nov 2025 13:58:01 +0000 (08:58 -0500)] 
add helper function to turn any integer type into uint64_t

8 months agowe can't use BEGIN/END on structs
Alan T. DeKok [Sun, 23 Nov 2025 13:41:58 +0000 (08:41 -0500)] 
we can't use BEGIN/END on structs

for now, we do auto-push.

8 months agono need for BEGIN/END of struct
Alan T. DeKok [Sun, 23 Nov 2025 12:58:20 +0000 (07:58 -0500)] 
no need for BEGIN/END of struct

8 months agomove the rest of DHCPv6 to the new union syntax
Alan T. DeKok [Sun, 23 Nov 2025 01:21:55 +0000 (20:21 -0500)] 
move the rest of DHCPv6 to the new union syntax

DUID.foo --> foo
Hardware-Type.foo --> foo

8 months agotoken names must be local, and not relative or absolute
Alan T. DeKok [Sun, 23 Nov 2025 01:21:24 +0000 (20:21 -0500)] 
token names must be local, and not relative or absolute

8 months agogive more context for errors
Alan T. DeKok [Sun, 23 Nov 2025 01:16:23 +0000 (20:16 -0500)] 
give more context for errors

8 months agoadd note that copying ALIAS isn't done yet
Alan T. DeKok [Sun, 23 Nov 2025 01:12:56 +0000 (20:12 -0500)] 
add note that copying ALIAS isn't done yet

8 months agoPartially move DHCPv6 to new union syntax
Alan T. DeKok [Sat, 22 Nov 2025 17:22:04 +0000 (12:22 -0500)] 
Partially move DHCPv6 to new union syntax

8 months agotweak assertion again
Alan T. DeKok [Sat, 22 Nov 2025 17:21:56 +0000 (12:21 -0500)] 
tweak assertion again

8 months agomove DHCPv4 to new union syntax
Alan T. DeKok [Sat, 22 Nov 2025 17:04:25 +0000 (12:04 -0500)] 
move DHCPv4 to new union syntax

8 months agoprint the attribute name, and not the enum name
Alan T. DeKok [Sat, 22 Nov 2025 16:00:00 +0000 (11:00 -0500)] 
print the attribute name, and not the enum name

8 months agomove BFD to new union syntax
Alan T. DeKok [Sat, 22 Nov 2025 14:26:53 +0000 (09:26 -0500)] 
move BFD to new union syntax

which also fixes some encoding errors in the previous code

8 months agosome fields can be raw
Alan T. DeKok [Sat, 22 Nov 2025 14:26:32 +0000 (09:26 -0500)] 
some fields can be raw

8 months agodon't check for encode_pair in union encoder
Alan T. DeKok [Sat, 22 Nov 2025 14:17:26 +0000 (09:17 -0500)] 
don't check for encode_pair in union encoder

the encode_pair function is needed only by encode_tlv, which already
checks for the existence of encode_pair

8 months agodon't assert if we fail to instantiate the dictionaries
Alan T. DeKok [Sat, 22 Nov 2025 14:12:39 +0000 (09:12 -0500)] 
don't assert if we fail to instantiate the dictionaries

8 months agomove to new union syntax
Alan T. DeKok [Sat, 22 Nov 2025 13:58:42 +0000 (08:58 -0500)] 
move to new union syntax

8 months agoadd notes on inter-attribute codes
Alan T. DeKok [Sat, 22 Nov 2025 13:58:29 +0000 (08:58 -0500)] 
add notes on inter-attribute codes

8 months agomove DNS to using new UNIONs
Alan T. DeKok [Sat, 22 Nov 2025 00:30:26 +0000 (19:30 -0500)] 
move DNS to using new UNIONs

8 months agoglue in copying of key attributes.
Alan T. DeKok [Fri, 21 Nov 2025 21:44:30 +0000 (16:44 -0500)] 
glue in copying of key attributes.

including creating enums in the correct order, and adding aliases
for children of a UNION

8 months agocopy STRUCT children in order
Alan T. DeKok [Fri, 21 Nov 2025 16:28:07 +0000 (11:28 -0500)] 
copy STRUCT children in order

so that we can define KEY attributes before fields which need them.

8 months agothe new child is always parented by the new dst DA
Alan T. DeKok [Fri, 21 Nov 2025 21:37:51 +0000 (16:37 -0500)] 
the new child is always parented by the new dst DA

otherwise the child is marked up as having the old parent, which
is wrong.

8 months agorefactor inner loop to function, in preparation for future work
Alan T. DeKok [Fri, 21 Nov 2025 16:07:04 +0000 (11:07 -0500)] 
refactor inner loop to function, in preparation for future work

8 months agosimplify and correct enum ext copying
Alan T. DeKok [Fri, 21 Nov 2025 14:49:27 +0000 (09:49 -0500)] 
simplify and correct enum ext copying

8 months agodocs-v4: Update path for users.adoc xref link in src/original file
nolade [Thu, 20 Nov 2025 20:57:37 +0000 (15:57 -0500)] 
docs-v4: Update path for users.adoc xref link in src/original file

8 months agomove key_child_ref to extension
Alan T. DeKok [Fri, 21 Nov 2025 01:05:42 +0000 (20:05 -0500)] 
move key_child_ref to extension

8 months agouse internal print, so we can do %pV and %pP
Alan T. DeKok [Thu, 20 Nov 2025 20:40:04 +0000 (15:40 -0500)] 
use internal print, so we can do %pV and %pP

8 months agowe only need one begin/end
Alan T. DeKok [Thu, 20 Nov 2025 20:33:11 +0000 (15:33 -0500)] 
we only need one begin/end

8 months agoDNS doesn't have attribute numbers, so use DEFINE
Alan T. DeKok [Thu, 20 Nov 2025 20:24:06 +0000 (15:24 -0500)] 
DNS doesn't have attribute numbers, so use DEFINE

8 months agoallow FR_TYPE_ATTR to have enums (or not)
Alan T. DeKok [Wed, 19 Nov 2025 21:41:59 +0000 (16:41 -0500)] 
allow FR_TYPE_ATTR to have enums (or not)

so that the code works properly in both cases

8 months agolimit the scope of 'clone='
Alan T. DeKok [Wed, 19 Nov 2025 15:17:49 +0000 (10:17 -0500)] 
limit the scope of 'clone='

and produce better errors, earlier

8 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/der.tar
github-actions[bot] [Wed, 19 Nov 2025 04:25:34 +0000 (04:25 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/der.tar

8 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/cbor.tar
github-actions[bot] [Wed, 19 Nov 2025 04:24:58 +0000 (04:24 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/cbor.tar

8 months agoWe cannot copy KEY refs.
Alan T. DeKok [Wed, 19 Nov 2025 02:19:25 +0000 (21:19 -0500)] 
We cannot copy KEY refs.

because they point to a key which is in the same parent as the
union.  So copying the union would copy the key ref, which is bad.

the only way to copy a union would be to set a new key ref while
we're copying it.

8 months agowe cannot re-allocate or move a da which is a target of a ref
Alan T. DeKok [Wed, 19 Nov 2025 02:10:35 +0000 (21:10 -0500)] 
we cannot re-allocate or move a da which is a target of a ref

otherwise we have DAs which point to the old definitions, and
that's bad

8 months agomove to using explicit include list when checking for valid types
Alan T. DeKok [Tue, 18 Nov 2025 20:37:03 +0000 (15:37 -0500)] 
move to using explicit include list when checking for valid types

8 months agocheck parent/child relationships in fr_dict_attr_add() too
Alan T. DeKok [Tue, 18 Nov 2025 16:51:08 +0000 (11:51 -0500)] 
check parent/child relationships in fr_dict_attr_add() too

8 months agolimit the places where we allow rcodes
Alan T. DeKok [Mon, 17 Nov 2025 19:13:15 +0000 (14:13 -0500)] 
limit the places where we allow rcodes

we can't do math, so (-ok) is not allowed.  but !ok is allowed.

Add xlat_purify_cond function.  update tests to match.

8 months agowe can't do math on rcodes
Alan T. DeKok [Mon, 17 Nov 2025 18:25:48 +0000 (13:25 -0500)] 
we can't do math on rcodes

so "invalid-packet" is not "invalid - packet"

8 months agoEnable process tests
Nick Porter [Mon, 17 Nov 2025 15:57:54 +0000 (15:57 +0000)] 
Enable process tests

8 months agoAdd simple test of Relay-Forward
Nick Porter [Mon, 17 Nov 2025 14:59:56 +0000 (14:59 +0000)] 
Add simple test of Relay-Forward

8 months agoCorrect xlat arguments
Nick Porter [Mon, 17 Nov 2025 14:57:36 +0000 (14:57 +0000)] 
Correct xlat arguments