]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 years agoJoin threads for a more orderly exit
Arran Cudbard-Bell [Tue, 3 Apr 2018 14:49:24 +0000 (15:49 +0100)] 
Join threads for a more orderly exit

8 years agoinstall unlang library too
Alan T. DeKok [Tue, 3 Apr 2018 14:28:48 +0000 (10:28 -0400)] 
install unlang library too

8 years agos/map_unlang/unlang_map/
Alan T. DeKok [Tue, 3 Apr 2018 14:19:33 +0000 (10:19 -0400)] 
s/map_unlang/unlang_map/

8 years agorename module_call and modcall to just module
Alan T. DeKok [Tue, 3 Apr 2018 14:15:10 +0000 (10:15 -0400)] 
rename module_call and modcall to just module

There's no "module" keyword, but it's clear what the intent is.
Any reference to a module is when we *call* a module.

8 years agos/module_unlang/unlang_module/
Alan T. DeKok [Tue, 3 Apr 2018 14:09:41 +0000 (10:09 -0400)] 
s/module_unlang/unlang_module/

like the last commit

8 years agorename xlat_unlang func/struct to unlang_xlat
Alan T. DeKok [Tue, 3 Apr 2018 13:54:12 +0000 (09:54 -0400)] 
rename xlat_unlang func/struct to unlang_xlat

While they're all xlat functions.. their main purpose is to
glue unlang to xlat.  So FWIW, they should be called unlang_xlat.

8 years agotoo many "unlang_foo" things. Move to src/unlang/foo
Alan T. DeKok [Tue, 3 Apr 2018 13:45:55 +0000 (09:45 -0400)] 
too many "unlang_foo" things.  Move to src/unlang/foo

the eventual goal is to have each keyword defined in src/unlang/foo
for now, we've just moved / renamed files.  Nothing else has
been changed.

8 years agoCache rad_module_t in thread instance data to fix use after free issues
Arran Cudbard-Bell [Tue, 3 Apr 2018 10:18:10 +0000 (11:18 +0100)] 
Cache rad_module_t in thread instance data to fix use after free issues

8 years agoFix use after free in fr_syserror and fr_strerror
Arran Cudbard-Bell [Mon, 2 Apr 2018 17:54:47 +0000 (18:54 +0100)] 
Fix use after free in fr_syserror and fr_strerror

This ocurred when something called fr_strerror_printf in another thread local destructor, after the memory had been freed.

8 years agoTry and fix use after free in logging buffer
Arran Cudbard-Bell [Mon, 2 Apr 2018 17:02:46 +0000 (18:02 +0100)] 
Try and fix use after free in logging buffer

8 years agoReturn ret
Arran Cudbard-Bell [Mon, 2 Apr 2018 13:51:34 +0000 (14:51 +0100)] 
Return ret

8 years agoLink to util library not server
Arran Cudbard-Bell [Mon, 2 Apr 2018 10:18:06 +0000 (11:18 +0100)] 
Link to util library not server

8 years agoAutoload rlm_digest attributes
Arran Cudbard-Bell [Sun, 1 Apr 2018 22:28:19 +0000 (23:28 +0100)] 
Autoload rlm_digest attributes

8 years agoAdd dictionary lookup utility
Arran Cudbard-Bell [Sun, 1 Apr 2018 19:15:48 +0000 (20:15 +0100)] 
Add dictionary lookup utility

Only works with new directory structure

8 years agoAutoload rlm_detail attributes
Arran Cudbard-Bell [Sun, 1 Apr 2018 19:11:13 +0000 (20:11 +0100)] 
Autoload rlm_detail attributes

8 years agoRemove rlm_cram dictionary
Arran Cudbard-Bell [Sun, 1 Apr 2018 18:47:11 +0000 (19:47 +0100)] 
Remove rlm_cram dictionary

8 years agoAutoload rlm_cram attributes
Arran Cudbard-Bell [Sun, 1 Apr 2018 18:43:56 +0000 (19:43 +0100)] 
Autoload rlm_cram attributes

8 years agoAutoload rlm_couchbase attributes
Arran Cudbard-Bell [Sun, 1 Apr 2018 18:22:21 +0000 (19:22 +0100)] 
Autoload rlm_couchbase attributes

8 years agoTypo
Arran Cudbard-Bell [Sun, 1 Apr 2018 18:21:55 +0000 (19:21 +0100)] 
Typo

8 years agoRename dhcp to dhcpv4
Arran Cudbard-Bell [Sun, 1 Apr 2018 18:05:35 +0000 (19:05 +0100)] 
Rename dhcp to dhcpv4

8 years agoAutoload rlm_chap attributes
Arran Cudbard-Bell [Sun, 1 Apr 2018 15:33:43 +0000 (16:33 +0100)] 
Autoload rlm_chap attributes

8 years agoAdd alias auto-enumerator
Arran Cudbard-Bell [Sun, 1 Apr 2018 15:33:23 +0000 (16:33 +0100)] 
Add alias auto-enumerator

8 years agoAdd explicit ordering to the symbol autoloader
Arran Cudbard-Bell [Sun, 1 Apr 2018 15:33:02 +0000 (16:33 +0100)] 
Add explicit ordering to the symbol autoloader

8 years agoDon't SEGV if there's no dictionary defined
Arran Cudbard-Bell [Sun, 1 Apr 2018 15:32:13 +0000 (16:32 +0100)] 
Don't SEGV if there's no dictionary defined

8 years agoFix issues in rlm_attr_filter
Arran Cudbard-Bell [Sun, 1 Apr 2018 15:31:46 +0000 (16:31 +0100)] 
Fix issues in rlm_attr_filter

8 years agoAdd function to safely imcrement boxes values
Arran Cudbard-Bell [Sun, 1 Apr 2018 14:16:18 +0000 (15:16 +0100)] 
Add function to safely imcrement boxes values

8 years agotake names from dictionaries, not hard-coded into header
Alan T. DeKok [Sun, 1 Apr 2018 13:07:16 +0000 (09:07 -0400)] 
take names from dictionaries, not hard-coded into header

8 years agoinclude new header file, and use names instead of numbers
Alan T. DeKok [Sun, 1 Apr 2018 13:01:42 +0000 (09:01 -0400)] 
include new header file, and use names instead of numbers

8 years agoinclude dhcpv4 definitions
Alan T. DeKok [Sun, 1 Apr 2018 12:56:47 +0000 (08:56 -0400)] 
include dhcpv4 definitions

As these are now legion, we should probably have a separate
include directory for them.  e.g. src/include/dictionary/

8 years agoremove unused enum
Alan T. DeKok [Fri, 30 Mar 2018 19:20:57 +0000 (15:20 -0400)] 
remove unused enum

8 years agoMerge pull request #2204 from nchaigne/4.0.x-201804-dhcp-decode-overload
Alan DeKok [Sun, 1 Apr 2018 12:54:03 +0000 (08:54 -0400)] 
Merge pull request #2204 from nchaigne/4.0.x-201804-dhcp-decode-overload

Decode additional DHCP options according to option Overload

8 years agoDecode additional DHCP options according to option Overload. 2204/head
nchaigne [Sun, 1 Apr 2018 11:05:28 +0000 (13:05 +0200)] 
Decode additional DHCP options according to option Overload.

If option Overload is present in the 'options' field, then fields 'file' and/or 'sname' are used to hold more options. They are partitioned and must be interpreted in sequence (cf. RFC 2131 and 2132).

8 years agoRemove dict argument from enum lookup functions
Arran Cudbard-Bell [Sun, 1 Apr 2018 10:32:11 +0000 (11:32 +0100)] 
Remove dict argument from enum lookup functions

8 years agoRemove duplicate
Arran Cudbard-Bell [Sun, 1 Apr 2018 08:27:58 +0000 (09:27 +0100)] 
Remove duplicate

8 years agoAutoload rlm_attr_filter
Arran Cudbard-Bell [Sat, 31 Mar 2018 19:33:41 +0000 (20:33 +0100)] 
Autoload rlm_attr_filter

8 years agoAutoload for rlm_cache
Arran Cudbard-Bell [Sat, 31 Mar 2018 18:51:15 +0000 (19:51 +0100)] 
Autoload for rlm_cache

8 years agoFix stupid errors in the autoload code
Arran Cudbard-Bell [Sat, 31 Mar 2018 17:17:52 +0000 (18:17 +0100)] 
Fix stupid errors in the autoload code

8 years agoAuto load dict_vmps and dict_vmps
Arran Cudbard-Bell [Fri, 30 Mar 2018 20:27:26 +0000 (21:27 +0100)] 
Auto load dict_vmps and dict_vmps

8 years agoAuto load dict_arp and dict_bfd
Arran Cudbard-Bell [Fri, 30 Mar 2018 20:23:55 +0000 (21:23 +0100)] 
Auto load dict_arp and dict_bfd

8 years agoFixup rlm_rest to use dynamic dictionary loader
Arran Cudbard-Bell [Fri, 30 Mar 2018 20:15:40 +0000 (21:15 +0100)] 
Fixup rlm_rest to use dynamic dictionary loader

8 years agoFixup rlm_wimax to use dynamic dictionary loader
Arran Cudbard-Bell [Fri, 30 Mar 2018 20:10:45 +0000 (21:10 +0100)] 
Fixup rlm_wimax to use dynamic dictionary loader

 Behold the horror *sigh*

8 years agoAdd additional pair functions
Arran Cudbard-Bell [Fri, 30 Mar 2018 20:05:46 +0000 (21:05 +0100)] 
Add additional pair functions

8 years agoDisable dict autoloading so we can work with the single dictionary until everything...
Arran Cudbard-Bell [Fri, 30 Mar 2018 19:37:38 +0000 (20:37 +0100)] 
Disable dict autoloading so we can work with the single dictionary until everything has been converted

8 years agoUpdate ChangeLog
Arran Cudbard-Bell [Sat, 31 Mar 2018 07:30:09 +0000 (08:30 +0100)] 
Update ChangeLog

8 years agoFixup heap return codes
Arran Cudbard-Bell [Fri, 30 Mar 2018 19:28:02 +0000 (20:28 +0100)] 
Fixup heap return codes

8 years agoUnderscores ftw
Arran Cudbard-Bell [Fri, 30 Mar 2018 18:47:47 +0000 (19:47 +0100)] 
Underscores ftw

8 years agoSimplify fr_heap_pop so it doesn't confuse clang scan
Arran Cudbard-Bell [Fri, 30 Mar 2018 18:47:35 +0000 (19:47 +0100)] 
Simplify fr_heap_pop  so it doesn't confuse clang scan

8 years agoAdd dictionary autoloader callbacks
Arran Cudbard-Bell [Fri, 30 Mar 2018 18:29:05 +0000 (19:29 +0100)] 
Add dictionary autoloader callbacks

8 years agoMake clang scan happy
Arran Cudbard-Bell [Fri, 30 Mar 2018 18:28:38 +0000 (19:28 +0100)] 
Make clang scan happy

8 years agodocumentation updates
Matthew Newton [Mon, 19 Mar 2018 11:54:38 +0000 (11:54 +0000)] 
documentation updates

8 years agoMinor fixes to OCSP code
Arran Cudbard-Bell [Fri, 30 Mar 2018 08:26:55 +0000 (09:26 +0100)] 
Minor fixes to OCSP code

8 years agoMerge pull request #2202 from frenche/ocsp_fixes_v4
Arran Cudbard-Bell [Fri, 30 Mar 2018 08:02:38 +0000 (09:02 +0100)] 
Merge pull request #2202 from frenche/ocsp_fixes_v4

OCSP fixes v4

8 years agoStupid fat libpcap, we hates it precious
Arran Cudbard-Bell [Thu, 29 Mar 2018 19:01:09 +0000 (20:01 +0100)] 
Stupid fat libpcap, we hates it precious

8 years agoAllow .1q tagged RADIUS packets in the default radsniff filter
Arran Cudbard-Bell [Thu, 29 Mar 2018 18:44:17 +0000 (19:44 +0100)] 
Allow .1q tagged RADIUS packets in the default radsniff filter

8 years agoOCSP: Fix intermediate CA flow 2202/head
Isaac Boukris [Tue, 27 Mar 2018 20:34:16 +0000 (23:34 +0300)] 
OCSP: Fix intermediate CA flow

It appears X509_STORE_CTX_get1_issuer() will only return
a trusted certificate, so in case of intermediate CA (not
trusted by it self) it may return null.
Use current_issuer instead, as the chain is already
validated (so we should have issuer certificate).

Also, if for some reason we still cannot get issuer, then
only allow skip if conf allows softfail.

8 years agoWe always store the heap id in the struct
Arran Cudbard-Bell [Wed, 28 Mar 2018 19:50:12 +0000 (20:50 +0100)] 
We always store the heap id in the struct

8 years agoDoxygen
Arran Cudbard-Bell [Wed, 28 Mar 2018 19:39:34 +0000 (20:39 +0100)] 
Doxygen

8 years agoAdd talloc type verification to fifos
Arran Cudbard-Bell [Wed, 28 Mar 2018 19:14:56 +0000 (20:14 +0100)] 
Add talloc type verification to fifos

8 years agoNot needed
Arran Cudbard-Bell [Wed, 28 Mar 2018 19:13:43 +0000 (20:13 +0100)] 
Not needed

8 years agoMore conversions
Arran Cudbard-Bell [Wed, 28 Mar 2018 18:55:15 +0000 (19:55 +0100)] 
More conversions

8 years agoMissing uint32_t?
Arran Cudbard-Bell [Wed, 28 Mar 2018 18:44:39 +0000 (19:44 +0100)] 
Missing uint32_t?

8 years agoTalloc type safety for rbtree
Arran Cudbard-Bell [Wed, 28 Mar 2018 18:41:16 +0000 (19:41 +0100)] 
Talloc type safety for rbtree

8 years agoCheck the type of talloced heap elements
Arran Cudbard-Bell [Wed, 28 Mar 2018 15:52:13 +0000 (16:52 +0100)] 
Check the type of talloced heap elements

8 years agoA heap size of INT32_MAX elements is OK
Arran Cudbard-Bell [Wed, 28 Mar 2018 15:51:41 +0000 (16:51 +0100)] 
A heap size of INT32_MAX elements is OK

8 years agoMore type fixes
Arran Cudbard-Bell [Wed, 28 Mar 2018 15:45:02 +0000 (16:45 +0100)] 
More type fixes

8 years agoCheck for overflow when expanding
Arran Cudbard-Bell [Wed, 28 Mar 2018 15:28:56 +0000 (16:28 +0100)] 
Check for overflow when expanding

Provide errors
Check for realloc failure
More type fixes
Formatting

8 years agoallow moving of only one packet
Alan T. DeKok [Wed, 28 Mar 2018 15:00:46 +0000 (11:00 -0400)] 
allow moving of only one packet

8 years agolook up address, not AF. And print descriptive message
Alan T. DeKok [Wed, 28 Mar 2018 14:58:17 +0000 (10:58 -0400)] 
look up address, not AF.  And print descriptive message

8 years agoChange how fr_heap_create is called to allow talloc type validation
Arran Cudbard-Bell [Wed, 28 Mar 2018 14:48:46 +0000 (15:48 +0100)] 
Change how fr_heap_create is called to allow talloc type validation

8 years agomake heap_id be int32_t
Alan T. DeKok [Wed, 28 Mar 2018 14:16:46 +0000 (10:16 -0400)] 
make heap_id be int32_t

8 years agoclean up dynamic client expiry
Alan T. DeKok [Tue, 27 Mar 2018 19:03:38 +0000 (15:03 -0400)] 
clean up dynamic client expiry

- we now have idle_timeout, not lifetime
  - this is because dynamic clients can't be connected (for now)
- simplify and unify the "clean up packet" code
- don't have an "expired" flag in the socket.
- don't have an "expired" flag in the client.
- track client->outstanding only for dynamic clients
- decrement client->outstanding only when the packet is cleaned up

8 years agoAdd heap_id field to fr_pool_connection
Arran Cudbard-Bell [Wed, 28 Mar 2018 10:57:00 +0000 (11:57 +0100)] 
Add heap_id field to fr_pool_connection

8 years agoTake offset of correct structure for connection pool last_released/reserved_cmp
Arran Cudbard-Bell [Wed, 28 Mar 2018 10:45:59 +0000 (11:45 +0100)] 
Take offset of correct structure for connection pool last_released/reserved_cmp

8 years agoMake sure the field storing the heap_id agrees with the rest of the heap code
Arran Cudbard-Bell [Wed, 28 Mar 2018 10:45:34 +0000 (11:45 +0100)] 
Make sure the field storing the heap_id agrees with the rest of the heap code

8 years agoDeal with error writing the delimiter
Arran Cudbard-Bell [Tue, 27 Mar 2018 18:18:06 +0000 (19:18 +0100)] 
Deal with error writing the delimiter

8 years agostop gcc 7 complaining
Arran Cudbard-Bell [Tue, 27 Mar 2018 16:06:43 +0000 (17:06 +0100)] 
stop gcc 7 complaining

8 years agoc_rehash the correct dir, and do the same for ecc certs
Arran Cudbard-Bell [Tue, 27 Mar 2018 15:23:41 +0000 (16:23 +0100)] 
c_rehash the correct dir, and do the same for ecc certs

8 years agoUse GCC7
Arran Cudbard-Bell [Tue, 27 Mar 2018 15:16:38 +0000 (16:16 +0100)] 
Use GCC7

8 years agodocument --allow-mschapv2
Alan T. DeKok [Tue, 27 Mar 2018 12:22:37 +0000 (08:22 -0400)] 
document --allow-mschapv2

8 years agoexpand the *unescaped* string, not the raw `...` string.
Alan T. DeKok [Tue, 27 Mar 2018 13:14:28 +0000 (09:14 -0400)] 
expand the *unescaped* string, not the raw `...` string.

Manual port of commit 5f8d05da

8 years agoEnsure -Wimplicit-fallthrough is enabled
Arran Cudbard-Bell [Tue, 27 Mar 2018 11:22:26 +0000 (12:22 +0100)] 
Ensure -Wimplicit-fallthrough is enabled

8 years agoFormatting
Arran Cudbard-Bell [Mon, 26 Mar 2018 13:09:55 +0000 (14:09 +0100)] 
Formatting

8 years agoMerge pull request #2200 from nchaigne/4.0.x-201803-dhcp-fixes
Alan DeKok [Mon, 26 Mar 2018 18:31:01 +0000 (14:31 -0400)] 
Merge pull request #2200 from nchaigne/4.0.x-201803-dhcp-fixes

A few fixes in fr_dhcpv4_packet_decode

8 years agoA few fixes in fr_dhcpv4_packet_decode 2200/head
nchaigne [Mon, 26 Mar 2018 18:24:44 +0000 (20:24 +0200)] 
A few fixes in fr_dhcpv4_packet_decode

1) Options 26 and 57 are short => use vp_uint16

2) Field "opcode" is byte => use vp_uint8

3) Value 3 does not exist for field "Opcode". Client request is 1.
Option 63 should have been 60 (Vendor Class Identifier).
That said, I don't think this "MSFT 98" code ever worked - unless MS does some really weird stuff with DHCP. So maybe it's worth considering removing this altogether ? I'll let you decide. :)

8 years agoadd missing "break"
Alan T. DeKok [Mon, 26 Mar 2018 18:09:33 +0000 (14:09 -0400)] 
add missing "break"

8 years agoadd missing "break"
Alan T. DeKok [Mon, 26 Mar 2018 18:08:02 +0000 (14:08 -0400)] 
add missing "break"

8 years agoadd missing "breaks"
Alan T. DeKok [Mon, 26 Mar 2018 18:07:36 +0000 (14:07 -0400)] 
add missing "breaks"

8 years agoAdd the client's TLS alert number as an attribute
Arran Cudbard-Bell [Mon, 26 Mar 2018 13:00:19 +0000 (14:00 +0100)] 
Add the client's TLS alert number as an attribute

8 years agoFail if we can't parse the virtual servers
Arran Cudbard-Bell [Mon, 26 Mar 2018 11:32:32 +0000 (12:32 +0100)] 
Fail if we can't parse the virtual servers

8 years agoNew line
Arran Cudbard-Bell [Sun, 25 Mar 2018 09:22:13 +0000 (10:22 +0100)] 
New line

8 years agoSet string encoding in ocsp.cnf too
Arran Cudbard-Bell [Sun, 25 Mar 2018 09:21:10 +0000 (10:21 +0100)] 
Set string encoding in ocsp.cnf too

8 years agoFix leak in unit_test_attribute
Arran Cudbard-Bell [Sun, 25 Mar 2018 09:20:16 +0000 (10:20 +0100)] 
Fix leak in unit_test_attribute

8 years agoDon't strip the first letter from the cipher description
Arran Cudbard-Bell [Sun, 25 Mar 2018 08:46:24 +0000 (09:46 +0100)] 
Don't strip the first letter from the cipher description

8 years agoCorrectly nul-terminated empty strings have length 1
Matthew Newton [Sat, 24 Mar 2018 23:59:14 +0000 (23:59 +0000)] 
Correctly nul-terminated empty strings have length 1

This would trip up regex compares where the subcapture didn't
match anything, so had length 0. Then trying to assign it to an
attribute the RHS was FR_TYPE_INVALID as fr_value_box_strsteal
exited early and never set it to FR_TYPE_STRING.

8 years agoset string_mask to utf8.
Alan T. DeKok [Sun, 25 Mar 2018 00:08:56 +0000 (20:08 -0400)] 
set string_mask to utf8.

OSX uses "nombstr", which is non-UTF8.  That's not what we want.

8 years agogenerate ecc and rsa. Update Makefile to match.
Alan T. DeKok [Sat, 24 Mar 2018 21:20:49 +0000 (17:20 -0400)] 
generate ecc and rsa.  Update Makefile to match.

8 years agothis isn't needed
Alan T. DeKok [Sat, 24 Mar 2018 21:20:07 +0000 (17:20 -0400)] 
this isn't needed

8 years agotypo
Alan T. DeKok [Sat, 24 Mar 2018 19:55:35 +0000 (15:55 -0400)] 
typo

8 years agoPrint index starting at zero
Arran Cudbard-Bell [Sat, 24 Mar 2018 21:17:46 +0000 (21:17 +0000)] 
Print index starting at zero

8 years agoDisplay cipher list and priority at dbg lvl 3
Arran Cudbard-Bell [Sat, 24 Mar 2018 21:15:59 +0000 (21:15 +0000)] 
Display cipher list and priority at dbg lvl 3

It's nice to know what cipher suites are actually in use