]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 years agoPrint index starting at zero
Arran Cudbard-Bell [Sat, 24 Mar 2018 21:17:46 +0000 (21:17 +0000)] 
Print index starting at zero

8 years agoDisplay cipher list and priority at dbg lvl 3
Arran Cudbard-Bell [Sat, 24 Mar 2018 21:15:59 +0000 (21:15 +0000)] 
Display cipher list and priority at dbg lvl 3

It's nice to know what cipher suites are actually in use

8 years agoCheck that there are some virtual servers defined
Arran Cudbard-Bell [Sat, 24 Mar 2018 20:06:56 +0000 (20:06 +0000)] 
Check that there are some virtual servers defined

8 years agoDon't allocate defaults with name2 if its the magic wildcard value
Arran Cudbard-Bell [Sat, 24 Mar 2018 20:06:36 +0000 (20:06 +0000)] 
Don't allocate defaults with name2 if its the magic wildcard value

8 years agomake certs/{rsa,ecc}/ directories, too.
Alan T. DeKok [Sat, 24 Mar 2018 18:35:46 +0000 (14:35 -0400)] 
make certs/{rsa,ecc}/ directories, too.

Both for raddb and src/tests

8 years agoclean ups
Alan T. DeKok [Sat, 24 Mar 2018 18:34:26 +0000 (14:34 -0400)] 
clean ups

.PHONY needs a target.  Intemermediate targets should be
directories, and not phony targets.

8 years agotv_usec / 1000 will always fit within "int"
Alan T. DeKok [Sat, 24 Mar 2018 18:26:59 +0000 (14:26 -0400)] 
tv_usec / 1000 will always fit within "int"

8 years agoiline number is not order.
Alan T. DeKok [Sat, 24 Mar 2018 17:50:02 +0000 (13:50 -0400)] 
iline number is not order.

The "users" file may have multiple $INCLUDES.
We DON'T want a "user" entry at line 266 of "$INCLUDE 1" to conflict
with a "DEFAULT" entry at line 266 of "$INCLUDE 2".

So we add an "order", which tracks the entry number.  The "lineno"
is no longer used for ordering comparisons.  Instead, it's only
used for debugging.

Manual port of commit bee85afcc61

8 years agoremove unnecessary variable
Alan T. DeKok [Sat, 24 Mar 2018 17:46:23 +0000 (13:46 -0400)] 
remove unnecessary variable

8 years agoCreate ECC version of all certificates
Arran Cudbard-Bell [Sat, 24 Mar 2018 17:14:03 +0000 (17:14 +0000)] 
Create ECC version of all certificates

8 years agoRevert "Fail if we leak memory (maybe)" - Can't do that until libkqueue is fixed
Arran Cudbard-Bell [Fri, 23 Mar 2018 15:59:26 +0000 (15:59 +0000)] 
Revert "Fail if we leak memory (maybe)" - Can't do that until libkqueue is fixed

This reverts commit c83748c58d77d41748e7407fd73187adfc64aeb0.

8 years agoFail if we leak memory (maybe)
Arran Cudbard-Bell [Fri, 23 Mar 2018 15:29:58 +0000 (15:29 +0000)] 
Fail if we leak memory (maybe)

8 years agoStop the leak checker complaining
Arran Cudbard-Bell [Fri, 23 Mar 2018 15:25:34 +0000 (15:25 +0000)] 
Stop the leak checker complaining

8 years agoSome editors trim trailing whitespace...
Arran Cudbard-Bell [Fri, 23 Mar 2018 15:25:17 +0000 (15:25 +0000)] 
Some editors trim trailing whitespace...

8 years agoRegression tests for list existence
Arran Cudbard-Bell [Fri, 23 Mar 2018 14:43:04 +0000 (14:43 +0000)] 
Regression tests for list existence

8 years agoFix memory leaks in xlat fmt parsing and map processor registration
Arran Cudbard-Bell [Fri, 23 Mar 2018 14:33:35 +0000 (14:33 +0000)] 
Fix memory leaks in xlat fmt parsing and map processor registration

8 years agoFix leak in module_find_with_method
Arran Cudbard-Bell [Fri, 23 Mar 2018 13:58:34 +0000 (13:58 +0000)] 
Fix leak in module_find_with_method

8 years agoFix some debug messages in fr_worker_get_request
Arran Cudbard-Bell [Fri, 23 Mar 2018 13:42:50 +0000 (13:42 +0000)] 
Fix some debug messages in fr_worker_get_request

8 years ago*actually* deregister all the xlat functions when the tree is freed
Arran Cudbard-Bell [Fri, 23 Mar 2018 13:40:46 +0000 (13:40 +0000)] 
*actually* deregister all the xlat functions when the tree is freed

8 years agoOne set of LSAN_OPTIONS...
Arran Cudbard-Bell [Fri, 23 Mar 2018 11:12:45 +0000 (11:12 +0000)] 
One set of LSAN_OPTIONS...

8 years agoBad tab
Arran Cudbard-Bell [Fri, 23 Mar 2018 11:11:52 +0000 (11:11 +0000)] 
Bad tab

8 years agoTry and get more malloc ctx info
Arran Cudbard-Bell [Thu, 22 Mar 2018 20:58:42 +0000 (20:58 +0000)] 
Try and get more malloc ctx info

8 years agoMore address sanitizer flags
Arran Cudbard-Bell [Thu, 22 Mar 2018 20:56:57 +0000 (20:56 +0000)] 
More address sanitizer flags

8 years agoreopen if we can't stat it
Alan T. DeKok [Thu, 22 Mar 2018 12:25:28 +0000 (08:25 -0400)] 
reopen if we can't stat it

8 years agoremove junk files
Matthew Newton [Thu, 22 Mar 2018 00:29:46 +0000 (00:29 +0000)] 
remove junk files

8 years agoWhen TMPL_TYPE_LIST, vpt->tmpl_da is NULL if the list is empty
Matthew Newton [Wed, 21 Mar 2018 23:27:07 +0000 (23:27 +0000)] 
When TMPL_TYPE_LIST, vpt->tmpl_da is NULL if the list is empty

8 years agoMicroseconds part can be 0 to 999999 so 32bits is fine
Matthew Newton [Wed, 21 Mar 2018 14:20:34 +0000 (09:20 -0500)] 
Microseconds part can be 0 to 999999 so 32bits is fine

8 years agos/FR_TYPE_INT8/FR_TYPE_UINT8/g
Arran Cudbard-Bell [Wed, 21 Mar 2018 13:52:02 +0000 (13:52 +0000)] 
s/FR_TYPE_INT8/FR_TYPE_UINT8/g

8 years agoPrint system error on localtime_r/gtime_failure
Arran Cudbard-Bell [Wed, 21 Mar 2018 13:50:13 +0000 (13:50 +0000)] 
Print system error on localtime_r/gtime_failure

8 years agoUse string not array so we don't expand random junk
Matthew Newton [Wed, 21 Mar 2018 12:34:51 +0000 (07:34 -0500)] 
Use string not array so we don't expand random junk

8 years agoTidy code into a slightly neater order
Matthew Newton [Wed, 21 Mar 2018 11:52:50 +0000 (06:52 -0500)] 
Tidy code into a slightly neater order

8 years agoBeing consistent is nice whether numbers or strings
Matthew Newton [Wed, 21 Mar 2018 11:44:34 +0000 (06:44 -0500)] 
Being consistent is nice whether numbers or strings

8 years agoIf values need to be zero padded they should be fed into the padding expansions
Arran Cudbard-Bell [Wed, 21 Mar 2018 08:34:21 +0000 (08:34 +0000)] 
If values need to be zero padded they should be fed into the padding expansions

It's not ok to mess with the underlying data type just to get a particular presentation format.

The whole point of reworking the xlat code to take discreet boxed values is that upstream consumers of the output can use real types to make proper casting and comparison decisions.

By forcing these values to strings there's a high chance that they'll be fed into a lexicographic comparison function instead of the server just using integer comparisons (they would be now anyway, but we're moving towards something better).

8 years agogive rlm_date ability to return request/now time in different formats
Matthew Newton [Tue, 20 Mar 2018 23:57:31 +0000 (18:57 -0500)] 
give rlm_date ability to return request/now time in different formats

8 years agorlm_date: separate logic from encoding/conversion
Matthew Newton [Tue, 20 Mar 2018 23:12:37 +0000 (18:12 -0500)] 
rlm_date: separate logic from encoding/conversion

and get rid of all the gotos in the process

8 years agoadd utc option to rlm_date
Matthew Newton [Tue, 20 Mar 2018 18:53:54 +0000 (13:53 -0500)] 
add utc option to rlm_date

8 years agoTidy time expansions
Matthew Newton [Tue, 20 Mar 2018 17:02:01 +0000 (12:02 -0500)] 
Tidy time expansions

Make it easier to produce dates in particular formats by always
using fixed length strings; add ISO format; fix milliseconds.

What was %T is now %S.%M (or %S.000000 to be exact...)

8 years agoMerge pull request #2198 from nchaigne/4.0.x-201803-dhcp-encode
Arran Cudbard-Bell [Tue, 20 Mar 2018 18:05:39 +0000 (18:05 +0000)] 
Merge pull request #2198 from nchaigne/4.0.x-201803-dhcp-encode

Do not encode htype and hlen by default for DHCPv4

8 years agoDo not encode htype and hlen by default for DHCPv4 2198/head
nchaigne [Tue, 20 Mar 2018 17:36:41 +0000 (18:36 +0100)] 
Do not encode htype and hlen by default for DHCPv4

DHCP fields "htype" and "hlen" should not be encoded to 1 and 6 (respectively) by default.
They don't need to, because they are automatically set if there is an Ethernet address in field "chaddr".

For a Lease Query request, as described in RFC 4388, it is possible to query: 1) by IP address, 2) by MAC address, 3) by Client-identifier option.
In cases 1) and 3) "The values of htype, hlen, and chaddr MUST be set to zero.".

So I think that if no "chaddr" is provided, it's better to leave "htype" and "hlen" to 0.

This proposed pull request implements this change.

8 years agoRemove '.' from dictionary names, in preparation for marking it as an disallowed...
Arran Cudbard-Bell [Tue, 20 Mar 2018 09:38:35 +0000 (09:38 +0000)] 
Remove '.' from dictionary names, in preparation for marking it as an disallowed character.

8 years agoRemove invalid assert
Arran Cudbard-Bell [Tue, 20 Mar 2018 08:53:09 +0000 (08:53 +0000)] 
Remove invalid assert

8 years agoTypo
Arran Cudbard-Bell [Tue, 20 Mar 2018 08:48:47 +0000 (08:48 +0000)] 
Typo

8 years agodon't stat meaningless data off the end of the list
Matthew Newton [Mon, 19 Mar 2018 22:50:46 +0000 (22:50 +0000)] 
don't stat meaningless data off the end of the list

8 years agoBoth referencer and referencee must be TLVs
Arran Cudbard-Bell [Mon, 19 Mar 2018 14:23:32 +0000 (14:23 +0000)] 
Both referencer and referencee must be TLVs

8 years agoDoxygen
Arran Cudbard-Bell [Mon, 19 Mar 2018 14:09:28 +0000 (14:09 +0000)] 
Doxygen

8 years agoAdd missing INTERNAL_IF_NULL
Arran Cudbard-Bell [Mon, 19 Mar 2018 14:08:03 +0000 (14:08 +0000)] 
Add missing INTERNAL_IF_NULL

8 years agoDoxygen
Arran Cudbard-Bell [Mon, 19 Mar 2018 11:58:14 +0000 (11:58 +0000)] 
Doxygen

8 years agoPENs are explicitly 32bit
Arran Cudbard-Bell [Mon, 19 Mar 2018 11:53:26 +0000 (11:53 +0000)] 
PENs are explicitly 32bit

8 years agos/vendorpec/pen/g
Arran Cudbard-Bell [Mon, 19 Mar 2018 11:44:22 +0000 (11:44 +0000)] 
s/vendorpec/pen/g

It's Private Enterprise Number (now?)

8 years agoReorganise dict.c
Arran Cudbard-Bell [Mon, 19 Mar 2018 11:23:41 +0000 (11:23 +0000)] 
Reorganise dict.c

8 years agoclang scan
Arran Cudbard-Bell [Mon, 19 Mar 2018 10:55:55 +0000 (10:55 +0000)] 
clang scan

8 years agoReorganise attribute adding/validation functions and add support for internal diction...
Arran Cudbard-Bell [Mon, 19 Mar 2018 10:52:33 +0000 (10:52 +0000)] 
Reorganise attribute adding/validation functions and add support for internal dictionary references.

References allow one attribute to internally reference another TLV or a dictionary root.

This allows us to create "group" attributes which allow any attribute to be encoded within the group and foreign protocol attributes which allow RADIUS to be encoded within DHCP (for example).

Attribute references are also needed to mix protocols in the same virtual server, as the template validation functions can retrieve the foreign dictionary context from the talloc hierarchy.

8 years agoInline some string format functions
Arran Cudbard-Bell [Sun, 18 Mar 2018 20:11:05 +0000 (20:11 +0000)] 
Inline some string format functions

8 years agoDoxygen
Arran Cudbard-Bell [Sat, 17 Mar 2018 22:32:14 +0000 (22:32 +0000)] 
Doxygen

8 years agoRe-order dictionary functions
Arran Cudbard-Bell [Sat, 17 Mar 2018 22:21:31 +0000 (22:21 +0000)] 
Re-order dictionary functions

8 years agoStrip global prefix from internal dict.c functions
Arran Cudbard-Bell [Sat, 17 Mar 2018 22:04:55 +0000 (22:04 +0000)] 
Strip global prefix from internal dict.c functions

8 years agofr_dict_print_attr_oid is a public function
Arran Cudbard-Bell [Sat, 17 Mar 2018 21:55:36 +0000 (21:55 +0000)] 
fr_dict_print_attr_oid is a public function

8 years agoRemove duplicate declaration
Arran Cudbard-Bell [Sat, 17 Mar 2018 21:53:17 +0000 (21:53 +0000)] 
Remove duplicate declaration

8 years agoAdd protocol dictionary load functions
Arran Cudbard-Bell [Sat, 17 Mar 2018 21:27:10 +0000 (21:27 +0000)] 
Add protocol dictionary load functions

8 years agoFix scan warnings
Arran Cudbard-Bell [Sat, 17 Mar 2018 20:34:26 +0000 (20:34 +0000)] 
Fix scan warnings

8 years agoFormatting
Arran Cudbard-Bell [Sat, 17 Mar 2018 19:14:01 +0000 (19:14 +0000)] 
Formatting

8 years agoSprinkle VERIFY_DA statements
Arran Cudbard-Bell [Sat, 17 Mar 2018 15:51:19 +0000 (15:51 +0000)] 
Sprinkle VERIFY_DA statements

8 years agoFormatting
Arran Cudbard-Bell [Sat, 17 Mar 2018 15:41:31 +0000 (15:41 +0000)] 
Formatting

8 years agoDoxument dict_from_file_ctx_t
Arran Cudbard-Bell [Sat, 17 Mar 2018 15:41:17 +0000 (15:41 +0000)] 
Doxument dict_from_file_ctx_t

8 years agoAdd protocol lookup function
Arran Cudbard-Bell [Sat, 17 Mar 2018 14:12:50 +0000 (14:12 +0000)] 
Add protocol lookup function

8 years agoMinor cleanups
Arran Cudbard-Bell [Fri, 16 Mar 2018 20:46:01 +0000 (20:46 +0000)] 
Minor cleanups

8 years agoSame treatment for vendors...
Arran Cudbard-Bell [Fri, 16 Mar 2018 20:30:01 +0000 (20:30 +0000)] 
Same treatment for vendors...

8 years agoDoxygen
Arran Cudbard-Bell [Fri, 16 Mar 2018 20:16:25 +0000 (20:16 +0000)] 
Doxygen

8 years agoAllocate a pool for the fr_dict_attr_t and allocate the name buffer in that
Arran Cudbard-Bell [Fri, 16 Mar 2018 19:43:13 +0000 (19:43 +0000)] 
Allocate a pool for the fr_dict_attr_t and allocate the name buffer in that

Means we can use talloc_array_length(da->name) - 1, and have specialisations of fr_dict_attr_t.

Code is also smaller/simpler.

8 years agoRemove .is_pointer from dictionary flags
Arran Cudbard-Bell [Fri, 16 Mar 2018 17:46:43 +0000 (17:46 +0000)] 
Remove .is_pointer from dictionary flags

8 years agoadd API to get size of the tracking table
Alan T. DeKok [Thu, 8 Mar 2018 14:51:09 +0000 (09:51 -0500)] 
add API to get size of the tracking table

8 years agoincrement the number of entries, too
Alan T. DeKok [Thu, 8 Mar 2018 14:50:17 +0000 (09:50 -0500)] 
increment the number of entries, too

8 years agoDH too
Arran Cudbard-Bell [Fri, 16 Mar 2018 14:01:40 +0000 (14:01 +0000)] 
DH too

8 years agoAdd tls-key-agility feature
Arran Cudbard-Bell [Fri, 16 Mar 2018 12:42:55 +0000 (12:42 +0000)] 
Add tls-key-agility feature

8 years agoLimit warning about multiple chains of same type
Arran Cudbard-Bell [Fri, 16 Mar 2018 08:27:00 +0000 (08:27 +0000)] 
Limit warning about multiple chains of same type

8 years agoClarify what should included in certificate_file
Arran Cudbard-Bell [Thu, 15 Mar 2018 19:12:03 +0000 (19:12 +0000)] 
Clarify what should included in certificate_file

8 years agoAdd targets to generate EC CA and Server certs
Arran Cudbard-Bell [Thu, 15 Mar 2018 18:29:35 +0000 (18:29 +0000)] 
Add targets to generate EC CA and Server certs

8 years agoEnable address-sanitizer support in dev packages
Arran Cudbard-Bell [Thu, 15 Mar 2018 17:14:13 +0000 (17:14 +0000)] 
Enable address-sanitizer support in dev packages

8 years agoAdd support for controlling certificate chain precompilation
Arran Cudbard-Bell [Thu, 15 Mar 2018 16:35:09 +0000 (16:35 +0000)] 
Add support for controlling certificate chain precompilation

8 years agoFix fp leak on cert load in rlm_cipher
Arran Cudbard-Bell [Thu, 15 Mar 2018 16:34:25 +0000 (16:34 +0000)] 
Fix fp leak on cert load in rlm_cipher

8 years agoRename key_pairs -> chains and certificate section to chain section
Arran Cudbard-Bell [Thu, 15 Mar 2018 12:06:17 +0000 (12:06 +0000)] 
Rename key_pairs -> chains and certificate section to chain section

This is more inline with OpenSSL’s terminiology, and makes more sense when you start looking at it in terms of managing different, independent, certificate chains for different key types.

8 years agoFixup tls_strerror_printf to use the new fr_strerror_printf stack
Arran Cudbard-Bell [Thu, 15 Mar 2018 12:01:26 +0000 (12:01 +0000)] 
Fixup tls_strerror_printf to use the new fr_strerror_printf stack

8 years agoImprove chain debug output
Arran Cudbard-Bell [Thu, 15 Mar 2018 10:31:47 +0000 (10:31 +0000)] 
Improve chain debug output

8 years agoSet mode before loading any certficates
Arran Cudbard-Bell [Thu, 15 Mar 2018 10:21:29 +0000 (10:21 +0000)] 
Set mode before loading any certficates

8 years agoAdd function for getting the name of an X509 cert pkey
Arran Cudbard-Bell [Thu, 15 Mar 2018 10:18:23 +0000 (10:18 +0000)] 
Add function for getting the name of an X509 cert pkey

8 years ago_tls_ctx_print_cert_line not needed unless we’re building with OpenSSL >= 1.0.2
Arran Cudbard-Bell [Wed, 14 Mar 2018 23:02:22 +0000 (23:02 +0000)] 
_tls_ctx_print_cert_line not needed unless we’re building with OpenSSL >= 1.0.2

8 years agoCert fmt table should be static too
Arran Cudbard-Bell [Wed, 14 Mar 2018 23:00:53 +0000 (23:00 +0000)] 
Cert fmt table should be static too

8 years agoPre-validate the certificate chains
Arran Cudbard-Bell [Wed, 14 Mar 2018 21:29:40 +0000 (21:29 +0000)] 
Pre-validate the certificate chains

This also re-orders certs if they were listed out of order

8 years agoTables should be static, and we should gracefully fallback to real names
Arran Cudbard-Bell [Wed, 14 Mar 2018 21:28:17 +0000 (21:28 +0000)] 
Tables should be static, and we should gracefully fallback to real names

8 years agoFix OCSP staple memory leak
Arran Cudbard-Bell [Wed, 14 Mar 2018 19:44:52 +0000 (19:44 +0000)] 
Fix OCSP staple memory leak

8 years agoOnly call SSL_CTX_set_mode if there are modes to set
Arran Cudbard-Bell [Wed, 14 Mar 2018 15:30:52 +0000 (15:30 +0000)] 
Only call SSL_CTX_set_mode if there are modes to set

Just in case this messes up the default mode

8 years agoDon’t set ctx options in the tls client session init function
Arran Cudbard-Bell [Wed, 14 Mar 2018 15:29:46 +0000 (15:29 +0000)] 
Don’t set ctx options in the tls client session init function

8 years agoShouldn’t be BOOL
Arran Cudbard-Bell [Wed, 14 Mar 2018 08:26:21 +0000 (08:26 +0000)] 
Shouldn’t be BOOL

8 years agoAdd DER as an alias for ASN1
Arran Cudbard-Bell [Wed, 14 Mar 2018 08:04:47 +0000 (08:04 +0000)] 
Add DER as an alias for ASN1

8 years agoDocument certificate format config item
Arran Cudbard-Bell [Wed, 14 Mar 2018 07:34:09 +0000 (07:34 +0000)] 
Document certificate format config item

8 years agoDoxygen
Arran Cudbard-Bell [Wed, 14 Mar 2018 07:33:26 +0000 (07:33 +0000)] 
Doxygen

8 years agoAllow multiple keypairs to be specified for crypto agility
Arran Cudbard-Bell [Tue, 13 Mar 2018 07:09:04 +0000 (13:09 +0600)] 
Allow multiple keypairs to be specified for crypto agility

8 years agoFix multi section pass2 parsing
Arran Cudbard-Bell [Tue, 13 Mar 2018 18:13:18 +0000 (18:13 +0000)] 
Fix multi section pass2 parsing

8 years agoradclient "-i" didn't work, so just remove it to save confusion
Matthew Newton [Mon, 12 Mar 2018 10:37:42 +0000 (10:37 +0000)] 
radclient "-i" didn't work, so just remove it to save confusion

8 years agoTypo
Arran Cudbard-Bell [Sat, 10 Mar 2018 15:44:20 +0000 (21:44 +0600)] 
Typo