]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 years agoClear the error buffer on successful tests, else it gets really confusing
Arran Cudbard-Bell [Fri, 16 Feb 2018 23:24:36 +0000 (23:24 +0000)] 
Clear the error buffer on successful tests, else it gets really confusing

8 years agoExplicitly include packet.h in dhcpv4.h
Arran Cudbard-Bell [Fri, 16 Feb 2018 22:28:31 +0000 (22:28 +0000)] 
Explicitly include packet.h in dhcpv4.h

8 years agoFix warnings in map.c
Arran Cudbard-Bell [Fri, 16 Feb 2018 22:20:39 +0000 (22:20 +0000)] 
Fix warnings in map.c

8 years agoTests! (for DHCPv6 encoder)
Arran Cudbard-Bell [Fri, 16 Feb 2018 22:14:30 +0000 (22:14 +0000)] 
Tests! (for DHCPv6 encoder)

Just a few of the simple types, more needed...

8 years agoFix a few issues in DHCPv6 encoder
Arran Cudbard-Bell [Fri, 16 Feb 2018 22:13:14 +0000 (22:13 +0000)] 
Fix a few issues in DHCPv6 encoder

Now skips false bools properly and doesn't crash

8 years agoNeed to build base.c in dhcpv6 code
Arran Cudbard-Bell [Fri, 16 Feb 2018 22:12:12 +0000 (22:12 +0000)] 
Need to build base.c in dhcpv6 code

8 years agoIgnore false bools too
Arran Cudbard-Bell [Fri, 16 Feb 2018 17:18:18 +0000 (17:18 +0000)] 
Ignore false bools too

8 years agoRename DHCPv4 test
Arran Cudbard-Bell [Fri, 16 Feb 2018 17:18:07 +0000 (17:18 +0000)] 
Rename DHCPv4 test

8 years agoadd FALL-THROUGH for newer compilers
Alan T. DeKok [Fri, 16 Feb 2018 20:50:18 +0000 (15:50 -0500)] 
add FALL-THROUGH for newer compilers

8 years agoMerge pull request #2181 from pwdng/v4.0.x
Alan DeKok [Fri, 16 Feb 2018 20:42:30 +0000 (15:42 -0500)] 
Merge pull request #2181 from pwdng/v4.0.x

Fix when skipping record

8 years agoFix when skipping record 2181/head
Philippe Wooding [Fri, 16 Feb 2018 18:14:07 +0000 (19:14 +0100)] 
Fix when skipping record

8 years agoone more attempt
Alan T. DeKok [Fri, 16 Feb 2018 16:45:16 +0000 (11:45 -0500)] 
one more attempt

8 years agoadd rules to create / link directories
Alan T. DeKok [Fri, 16 Feb 2018 16:14:23 +0000 (11:14 -0500)] 
add rules to create / link directories

8 years agoremove "util". It's not needed
Alan T. DeKok [Fri, 16 Feb 2018 16:14:05 +0000 (11:14 -0500)] 
remove "util". It's not needed

8 years agoSkip false boolean attributes in SIM/AKA/AKA' encoder
Arran Cudbard-Bell [Fri, 16 Feb 2018 14:19:45 +0000 (14:19 +0000)] 
Skip false boolean attributes in SIM/AKA/AKA' encoder

8 years agoFix stupid GCC warnings
Arran Cudbard-Bell [Fri, 16 Feb 2018 13:59:42 +0000 (13:59 +0000)] 
Fix stupid GCC warnings

8 years agoRemove doxygen until we use the function
Arran Cudbard-Bell [Fri, 16 Feb 2018 13:56:49 +0000 (13:56 +0000)] 
Remove doxygen until we use the function

8 years agoAdd preliminary DHCPv6 dictionary
Arran Cudbard-Bell [Fri, 16 Feb 2018 13:36:29 +0000 (13:36 +0000)] 
Add preliminary DHCPv6 dictionary

8 years agocache leftover data when retransmitting
Alan T. DeKok [Thu, 15 Feb 2018 21:37:17 +0000 (16:37 -0500)] 
cache leftover data when retransmitting

8 years agoOptions not attributes
Arran Cudbard-Bell [Thu, 15 Feb 2018 20:46:24 +0000 (20:46 +0000)] 
Options not attributes

8 years agoAdd v6 encoder test point
Arran Cudbard-Bell [Thu, 15 Feb 2018 20:42:26 +0000 (20:42 +0000)] 
Add v6 encoder test point

8 years agoConvert all encoders from vp_cursor_t to fr_cursor_t
Arran Cudbard-Bell [Thu, 15 Feb 2018 20:33:22 +0000 (20:33 +0000)] 
Convert all encoders from vp_cursor_t to fr_cursor_t

Add (untested) code for DHCPv6 encoder

8 years agoDescribe how pair_encode/pair_decode functions *should* work and define some standard...
Arran Cudbard-Bell [Thu, 15 Feb 2018 17:33:31 +0000 (17:33 +0000)] 
Describe how pair_encode/pair_decode functions *should* work and define some standard return values.

8 years agoAdd CHECK_FREESPACE macro
Arran Cudbard-Bell [Thu, 15 Feb 2018 17:32:56 +0000 (17:32 +0000)] 
Add CHECK_FREESPACE macro

In general the internal encoder functions *should* return how much extra buffer they needed, so that their callers can make decisions about TLV nesting

8 years agoDefine SSIZE_MIN if missing
Arran Cudbard-Bell [Thu, 15 Feb 2018 17:31:44 +0000 (17:31 +0000)] 
Define SSIZE_MIN if missing

8 years agonotes for dynamic clients and connected sockets
Alan T. DeKok [Thu, 15 Feb 2018 18:19:45 +0000 (13:19 -0500)] 
notes for dynamic clients and connected sockets

8 years agoremove NAT configuration for clients.
Alan T. DeKok [Thu, 15 Feb 2018 18:05:29 +0000 (13:05 -0500)] 
remove NAT configuration for clients.

Instead, if we have dynamic clients *and* we're using
connected sockets, THEN the clients should be connection-specific.

The remaining "todo" is to check for multiple packets from the
same source IP, but with different source ports... and to
track those separately.

8 years agoremove erroneous NAT code
Alan T. DeKok [Thu, 15 Feb 2018 18:01:03 +0000 (13:01 -0500)] 
remove erroneous NAT code

this should now be handled automatically by mod_read()

8 years agoclarify check
Alan T. DeKok [Thu, 15 Feb 2018 17:59:08 +0000 (12:59 -0500)] 
clarify check

8 years agosend a 1 byte NAK back
Alan T. DeKok [Thu, 15 Feb 2018 17:45:30 +0000 (12:45 -0500)] 
send a 1 byte NAK back

8 years agoupdate the right fields, and if_index, too
Alan T. DeKok [Thu, 15 Feb 2018 17:37:43 +0000 (12:37 -0500)] 
update the right fields, and if_index, too

8 years agoadd debug3 message
Alan T. DeKok [Thu, 15 Feb 2018 17:34:55 +0000 (12:34 -0500)] 
add debug3 message

8 years agoclean up mod_read()
Alan T. DeKok [Thu, 15 Feb 2018 17:11:57 +0000 (12:11 -0500)] 
clean up mod_read()

instead of having horrible if / goto stuff, split up the code.
There's now a mod_read_packet(), which gets a packet from one
of N possible sources.  This function also updates address,
address.client, and track.

The mod_read() routine then does checks on address.client and
track as necessary.

Test with UDP packets.  Untested with dynamic clients or connections.

8 years agohoist checks for connected socket to before client lookup
Alan T. DeKok [Thu, 15 Feb 2018 16:30:38 +0000 (11:30 -0500)] 
hoist checks for connected socket to before client lookup

because if we have a connected socket, then we don't need to
look up the client.  Instead, we just send the packet to the
connected socket.

8 years agonotes on removing the mutex lock
Alan T. DeKok [Thu, 15 Feb 2018 16:16:50 +0000 (11:16 -0500)] 
notes on removing the mutex lock

8 years agocomments
Alan T. DeKok [Thu, 15 Feb 2018 16:05:40 +0000 (11:05 -0500)] 
comments

8 years agodocument "work" subsection
Alan T. DeKok [Wed, 14 Feb 2018 19:19:13 +0000 (14:19 -0500)] 
document "work" subsection

8 years agoremove worker configuration from the directory watcher
Alan T. DeKok [Wed, 14 Feb 2018 19:15:15 +0000 (14:15 -0500)] 
remove worker configuration from the directory watcher

8 years agoin files are annoying
Alan T. DeKok [Wed, 14 Feb 2018 16:41:28 +0000 (11:41 -0500)] 
in files are annoying

8 years agorename for Windows.
Alan T. DeKok [Wed, 14 Feb 2018 16:21:29 +0000 (11:21 -0500)] 
rename for Windows.

8 years agosrc and dst may be the same
Alan T. DeKok [Tue, 13 Feb 2018 15:52:36 +0000 (10:52 -0500)] 
src and dst may be the same

8 years agoRemove unused arg
Arran Cudbard-Bell [Tue, 13 Feb 2018 17:22:08 +0000 (17:22 +0000)] 
Remove unused arg

8 years agoConvert JSON integers to the smallest signed or unsigned integer type
Arran Cudbard-Bell [Tue, 13 Feb 2018 16:55:00 +0000 (16:55 +0000)] 
Convert JSON integers to the smallest signed or unsigned integer type

When the code was first writen we didn't have the full range of signed types.

8 years agoFix double free in acct_redundant
Arran Cudbard-Bell [Tue, 13 Feb 2018 15:10:08 +0000 (15:10 +0000)] 
Fix double free in acct_redundant

8 years agocopy the leftover data if necessary
Alan T. DeKok [Tue, 13 Feb 2018 14:37:30 +0000 (09:37 -0500)] 
copy the leftover data if necessary

8 years agopass "leftover" explicitly
Alan T. DeKok [Tue, 13 Feb 2018 14:33:14 +0000 (09:33 -0500)] 
pass "leftover" explicitly

8 years agocasts
Alan T. DeKok [Tue, 13 Feb 2018 14:33:04 +0000 (09:33 -0500)] 
casts

8 years agoRemove debugging fprintf in fr_inet_pton
Arran Cudbard-Bell [Tue, 13 Feb 2018 10:49:21 +0000 (10:49 +0000)] 
Remove debugging fprintf in fr_inet_pton

8 years agoBreak out cast to unsigned integer into functions
Arran Cudbard-Bell [Sat, 10 Feb 2018 22:09:21 +0000 (22:09 +0000)] 
Break out cast to unsigned integer into functions

Fixes issues like not being able to cast a bool to a uint32

8 years agoclean up fr_inet_pton()
Alan T. DeKok [Tue, 13 Feb 2018 00:37:13 +0000 (19:37 -0500)] 
clean up fr_inet_pton()

Walk over the *whole* string, checking
*all* of the characters.  The issue with the earlier code was
that it bailed too early, and forced IPv4 even when the address
was IPv6.

manual port of 5452b13cef

8 years agoif the entry is too large for the buffer, discard the file
Alan T. DeKok [Mon, 12 Feb 2018 20:50:28 +0000 (15:50 -0500)] 
if the entry is too large for the buffer, discard the file

8 years agoconvert assert to run-time check
Alan T. DeKok [Fri, 9 Feb 2018 14:15:07 +0000 (09:15 -0500)] 
convert assert to run-time check

8 years agoWait to remove the candle from the mandle
Arran Cudbard-Bell [Fri, 9 Feb 2018 13:48:01 +0000 (13:48 +0000)] 
Wait to remove the candle from the mandle

8 years agoTAG_ANY is ok too
Arran Cudbard-Bell [Thu, 8 Feb 2018 21:38:03 +0000 (21:38 +0000)] 
TAG_ANY is ok too

8 years agoIf action is NULL return NOOP
Arran Cudbard-Bell [Thu, 8 Feb 2018 21:28:17 +0000 (21:28 +0000)] 
If action is NULL return NOOP

8 years agoBetter errors in fr_event_list_alloc decides to fail
Arran Cudbard-Bell [Thu, 8 Feb 2018 20:37:11 +0000 (20:37 +0000)] 
Better errors in fr_event_list_alloc decides to fail

8 years agoPrint an error message for everything that could fail in fr_event_list_alloc
Arran Cudbard-Bell [Thu, 8 Feb 2018 20:17:17 +0000 (20:17 +0000)] 
Print an error message for everything that could fail in fr_event_list_alloc

Because it's currently failing randomly and we have no idea why

8 years agoFix more files to have doxygen style headers
Arran Cudbard-Bell [Thu, 8 Feb 2018 20:16:50 +0000 (20:16 +0000)] 
Fix more files to have doxygen style headers

8 years agoRename files.c to users_file.c
Arran Cudbard-Bell [Thu, 8 Feb 2018 20:15:24 +0000 (20:15 +0000)] 
Rename files.c to users_file.c

8 years agocreate CHAP-Challenge if it doesn't already exist
Alan T. DeKok [Thu, 8 Feb 2018 17:39:57 +0000 (12:39 -0500)] 
create CHAP-Challenge if it doesn't already exist

8 years agos/FR_SIGNAL_DONE/FR_SIGNAL_CANCEL/
Alan T. DeKok [Thu, 8 Feb 2018 17:31:58 +0000 (12:31 -0500)] 
s/FR_SIGNAL_DONE/FR_SIGNAL_CANCEL/

the request has been cancelled, but it might not be done.

8 years agoRevert "make fr_network_socket_delete() thread-safe"
Alan T. DeKok [Thu, 8 Feb 2018 13:41:12 +0000 (08:41 -0500)] 
Revert "make fr_network_socket_delete() thread-safe"

This reverts commit 5dc5d9b97f523607c7829bdeaeed448bac49d8ba.

fr_network_socket_delete() should only be called by the IO
handler, which is already in the network thread

8 years agoStore current module, and set old_backlog correctly when calling unlang_interpret_syn...
Arran Cudbard-Bell [Wed, 7 Feb 2018 23:12:38 +0000 (23:12 +0000)] 
Store current module, and set old_backlog correctly when calling unlang_interpret_synchronous

8 years agoDoxygen
Arran Cudbard-Bell [Wed, 7 Feb 2018 22:18:41 +0000 (22:18 +0000)] 
Doxygen

8 years agoOnly build proto_tls_cache.c if we have OpenSSL
Arran Cudbard-Bell [Wed, 7 Feb 2018 22:16:42 +0000 (22:16 +0000)] 
Only build proto_tls_cache.c if we have OpenSSL

8 years agoAdd stub proto_tls_cache module to compile tls_cache sections
Arran Cudbard-Bell [Wed, 7 Feb 2018 21:32:22 +0000 (21:32 +0000)] 
Add stub proto_tls_cache module to compile tls_cache sections

8 years agoIgnore all subdirectories in src/include
Arran Cudbard-Bell [Wed, 7 Feb 2018 21:06:50 +0000 (21:06 +0000)] 
Ignore all subdirectories in src/include

Because manually updating .gitignore every time we create a new library or protocol is going to get very tedious

8 years agothis shouldn't be commited either
Alan T. DeKok [Wed, 7 Feb 2018 20:37:08 +0000 (15:37 -0500)] 
this shouldn't be commited either

8 years agoignore DHCP things
Alan T. DeKok [Wed, 7 Feb 2018 20:35:22 +0000 (15:35 -0500)] 
ignore DHCP things

8 years agothis should NOT be committed
Alan T. DeKok [Wed, 7 Feb 2018 20:34:56 +0000 (15:34 -0500)] 
this should NOT be committed

8 years agoCall/compile TLS Session and OCSP server sections
Arran Cudbard-Bell [Wed, 7 Feb 2018 17:50:37 +0000 (17:50 +0000)] 
Call/compile TLS Session and OCSP server sections

This is technically async safe, but the calls are still potentially blocking.  More work needed to fix that.

There's no advantage to having them actually async capable until the cache module is async capable anyway...

8 years agoCheck permissions last, right before we call the panic action
Arran Cudbard-Bell [Wed, 7 Feb 2018 16:12:07 +0000 (16:12 +0000)] 
Check permissions last, right before we call the panic action

8 years agoadd assertion that deletion succeeds
Alan T. DeKok [Wed, 7 Feb 2018 15:39:35 +0000 (10:39 -0500)] 
add assertion that deletion succeeds

8 years agoclarify debug message
Alan T. DeKok [Wed, 7 Feb 2018 15:28:21 +0000 (10:28 -0500)] 
clarify debug message

8 years agoAdd the -f back into LN-SF
Arran Cudbard-Bell [Wed, 7 Feb 2018 14:23:08 +0000 (14:23 +0000)] 
Add the -f back into LN-SF

8 years agoDoxygen
Arran Cudbard-Bell [Wed, 7 Feb 2018 14:15:38 +0000 (14:15 +0000)] 
Doxygen

8 years agoUpdate kqueue FD removal assert to print errno
Arran Cudbard-Bell [Wed, 7 Feb 2018 13:44:28 +0000 (13:44 +0000)] 
Update kqueue FD removal assert to print errno

8 years agoMove all rad_cond_assert to fr_cond_assert
Arran Cudbard-Bell [Wed, 7 Feb 2018 12:47:23 +0000 (12:47 +0000)] 
Move all rad_cond_assert to fr_cond_assert

The distinction isn't that important, and they ended up being mixed in the source files anyway.

8 years agoBoilerplate functions for DHCPv6 (hey it's a start)
Arran Cudbard-Bell [Wed, 7 Feb 2018 12:44:43 +0000 (12:44 +0000)] 
Boilerplate functions for DHCPv6 (hey it's a start)

8 years agomake fr_network_socket_delete() thread-safe
Alan T. DeKok [Tue, 6 Feb 2018 20:14:25 +0000 (15:14 -0500)] 
make fr_network_socket_delete() thread-safe

8 years agocall fr_network_socket_delete() before closing the FDs
Alan T. DeKok [Tue, 6 Feb 2018 20:08:53 +0000 (15:08 -0500)] 
call fr_network_socket_delete() before closing the FDs

8 years agoallow listeners to remove themselves from the network
Alan T. DeKok [Tue, 6 Feb 2018 20:05:52 +0000 (15:05 -0500)] 
allow listeners to remove themselves from the network

8 years agolimit max_outstanding to 1
Alan T. DeKok [Mon, 5 Feb 2018 14:24:21 +0000 (09:24 -0500)] 
limit max_outstanding to 1

8 years agoport #2175 from v3.0.x
Alan T. DeKok [Fri, 2 Feb 2018 15:51:35 +0000 (10:51 -0500)] 
port #2175 from v3.0.x

8 years agoclean up error handling
Alan T. DeKok [Fri, 2 Feb 2018 14:10:30 +0000 (09:10 -0500)] 
clean up error handling

8 years agorely on parent function to insert retry timer
Alan T. DeKok [Fri, 2 Feb 2018 14:06:25 +0000 (09:06 -0500)] 
rely on parent function to insert retry timer

8 years agoallow faster retries for empty files
Alan T. DeKok [Fri, 2 Feb 2018 14:04:38 +0000 (09:04 -0500)] 
allow faster retries for empty files

8 years agodeal with race conditions on duplicate packets
Alan T. DeKok [Thu, 1 Feb 2018 22:41:38 +0000 (17:41 -0500)] 
deal with race conditions on duplicate packets

Untested as of yet. :(

8 years agodo de-dup detection for accounting packets, too
Alan T. DeKok [Thu, 1 Feb 2018 18:48:48 +0000 (13:48 -0500)] 
do de-dup detection for accounting packets, too

8 years agomore sanity checks
Alan T. DeKok [Thu, 1 Feb 2018 18:31:46 +0000 (13:31 -0500)] 
more sanity checks

8 years agomake code/id 8-bit values
Alan T. DeKok [Thu, 1 Feb 2018 18:29:13 +0000 (13:29 -0500)] 
make code/id 8-bit values

that's all we need

8 years agoI hate my life
Alan T. DeKok [Thu, 1 Feb 2018 18:28:34 +0000 (13:28 -0500)] 
I hate my life

8 years agorely on talloc to clean things up
Alan T. DeKok [Thu, 1 Feb 2018 13:49:49 +0000 (08:49 -0500)] 
rely on talloc to clean things up

8 years agodon't pass bad values to the encoder
Alan T. DeKok [Thu, 1 Feb 2018 12:48:08 +0000 (07:48 -0500)] 
don't pass bad values to the encoder

i.e. we have layers of checks, just in case one layer breaks

8 years agofail accounting == do not respond
Alan T. DeKok [Thu, 1 Feb 2018 12:45:32 +0000 (07:45 -0500)] 
fail accounting == do not respond

8 years agomove assert to run-time check
Alan T. DeKok [Thu, 1 Feb 2018 12:43:01 +0000 (07:43 -0500)] 
move assert to run-time check

8 years agoDon't leak message buffers
Arran Cudbard-Bell [Thu, 1 Feb 2018 03:03:15 +0000 (20:03 -0700)] 
Don't leak message buffers

8 years agoDon't leak xlat_thread_instances for epehemeral xlats
Arran Cudbard-Bell [Thu, 1 Feb 2018 02:56:01 +0000 (19:56 -0700)] 
Don't leak xlat_thread_instances for epehemeral xlats

8 years agoDoxygen
Arran Cudbard-Bell [Thu, 1 Feb 2018 02:14:12 +0000 (19:14 -0700)] 
Doxygen

8 years agodeveloper build should have debug symbols in it
Matthew Newton [Thu, 1 Feb 2018 01:47:07 +0000 (01:47 +0000)] 
developer build should have debug symbols in it