]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 years agoFix handling of NULL RHS in update sections
Arran Cudbard-Bell [Sun, 28 Jan 2018 23:06:14 +0000 (16:06 -0700)] 
Fix handling of NULL RHS in update sections

8 years agoReset alternate on an additional code path
Arran Cudbard-Bell [Sun, 28 Jan 2018 22:53:24 +0000 (15:53 -0700)] 
Reset alternate on an additional code path

8 years ago...an xlat can yield multiple times
Arran Cudbard-Bell [Sun, 28 Jan 2018 22:36:30 +0000 (15:36 -0700)] 
...an xlat can yield multiple times

8 years agoImprove xlat evaluation debugging
Arran Cudbard-Bell [Sun, 28 Jan 2018 22:27:26 +0000 (15:27 -0700)] 
Improve xlat evaluation debugging

It should be about equivalent to the synchronous debug output, with the added bonus feature of printing the function fmt string and the expanded arguments.

8 years agoAdd function for copying value_box lists and for checking list taint
Arran Cudbard-Bell [Sun, 28 Jan 2018 22:24:45 +0000 (15:24 -0700)] 
Add function for copying value_box lists and for checking list taint

8 years agomore hacks for tmpl_verify
Alan T. DeKok [Sun, 28 Jan 2018 19:58:20 +0000 (14:58 -0500)] 
more hacks for tmpl_verify

8 years agoDoxygen
Arran Cudbard-Bell [Sun, 28 Jan 2018 04:35:38 +0000 (21:35 -0700)] 
Doxygen

8 years agoFix inifinite loop in xlat evaluator where both expansions in an alternate expansion...
Arran Cudbard-Bell [Sun, 28 Jan 2018 04:12:07 +0000 (21:12 -0700)] 
Fix inifinite loop in xlat evaluator where both expansions in an alternate expansion evaluate to NULL

8 years agoUse ephemeral xlat instantiation in unit tests
Arran Cudbard-Bell [Sun, 28 Jan 2018 04:11:37 +0000 (21:11 -0700)] 
Use ephemeral xlat instantiation in unit tests

8 years agoAdd cancellation function for rest xlats
Arran Cudbard-Bell [Sat, 27 Jan 2018 15:38:15 +0000 (08:38 -0700)] 
Add cancellation function for rest xlats

8 years agoExtra sanity check
Arran Cudbard-Bell [Sat, 27 Jan 2018 06:46:19 +0000 (23:46 -0700)] 
Extra sanity check

8 years agoif vp is NULL.... don't dereference it
Alan T. DeKok [Sat, 27 Jan 2018 13:16:01 +0000 (08:16 -0500)] 
if vp is NULL.... don't dereference it

8 years agoMake debug message clearer
Arran Cudbard-Bell [Sat, 27 Jan 2018 01:33:25 +0000 (18:33 -0700)] 
Make debug message clearer

8 years agoDon't leave stale REST-HTTP-Status-Code attributes around
Arran Cudbard-Bell [Sat, 27 Jan 2018 00:56:11 +0000 (17:56 -0700)] 
Don't leave stale REST-HTTP-Status-Code attributes around

8 years agotalloc_get_type is only in debug builds
Alan T. DeKok [Sat, 27 Jan 2018 00:55:31 +0000 (19:55 -0500)] 
talloc_get_type is only in debug builds

8 years agodoxygen
Alan T. DeKok [Sat, 27 Jan 2018 00:53:51 +0000 (19:53 -0500)] 
doxygen

8 years ago...and another
Arran Cudbard-Bell [Sat, 27 Jan 2018 00:51:36 +0000 (17:51 -0700)] 
...and another

8 years agoTypo
Arran Cudbard-Bell [Sat, 27 Jan 2018 00:50:28 +0000 (17:50 -0700)] 
Typo

8 years agoPrint out more of the error stack
Arran Cudbard-Bell [Sat, 27 Jan 2018 00:41:09 +0000 (17:41 -0700)] 
Print out more of the error stack

...and fix EAP AKA/SIM identity parsing so it says exactly why it thinks the permanent ID is invalid

8 years agoadd const
Alan T. DeKok [Sat, 27 Jan 2018 00:28:00 +0000 (19:28 -0500)] 
add const

8 years agoFix talloc_list_get_type_abort when get_type_abort is disabled
Arran Cudbard-Bell [Sat, 27 Jan 2018 00:01:23 +0000 (17:01 -0700)] 
Fix talloc_list_get_type_abort when get_type_abort is disabled

8 years agoFix input to map processors to be async
Arran Cudbard-Bell [Sat, 27 Jan 2018 00:01:06 +0000 (17:01 -0700)] 
Fix input to map processors to be async

8 years agoTypo
Arran Cudbard-Bell [Fri, 26 Jan 2018 23:29:25 +0000 (16:29 -0700)] 
Typo

8 years agoDon't double alloc the output box in xlat_bin
Arran Cudbard-Bell [Fri, 26 Jan 2018 20:47:04 +0000 (13:47 -0700)] 
Don't double alloc the output box in xlat_bin

8 years agoFormatting
Arran Cudbard-Bell [Fri, 26 Jan 2018 20:44:08 +0000 (13:44 -0700)] 
Formatting

8 years agoMove private structures into a private header file
Arran Cudbard-Bell [Fri, 26 Jan 2018 20:43:25 +0000 (13:43 -0700)] 
Move private structures into a private header file

8 years agoOrganisation
Arran Cudbard-Bell [Fri, 26 Jan 2018 20:42:52 +0000 (13:42 -0700)] 
Organisation

8 years agoCheck for list taint
Arran Cudbard-Bell [Fri, 26 Jan 2018 20:42:41 +0000 (13:42 -0700)] 
Check for list taint

8 years agoAdd incr_ref argumet to fr_value_box_copy_shallow
Arran Cudbard-Bell [Fri, 26 Jan 2018 20:42:12 +0000 (13:42 -0700)] 
Add incr_ref argumet to fr_value_box_copy_shallow

We don't want to increment reference counts when shallow copying globally allocated boxes

8 years agoAdd a value box 'meta' type
Arran Cudbard-Bell [Fri, 26 Jan 2018 20:41:32 +0000 (13:41 -0700)] 
Add a value box 'meta' type

8 years agoAdd fr_value_box_alloc_null
Arran Cudbard-Bell [Fri, 26 Jan 2018 20:40:20 +0000 (13:40 -0700)] 
Add fr_value_box_alloc_null

To allocate null value boxes which are then populated with another function in the value.c API.

This means you don't have to pass the taint/enumv flags in twice (which looked stupid).

8 years agodon't re-define macro
Alan T. DeKok [Fri, 26 Jan 2018 23:13:29 +0000 (18:13 -0500)] 
don't re-define macro

8 years agoupdate track, too
Alan T. DeKok [Fri, 26 Jan 2018 19:52:08 +0000 (14:52 -0500)] 
update track, too

8 years agoDon't crash if an async function is used in the legacy xlat functions
Arran Cudbard-Bell [Fri, 26 Jan 2018 18:25:50 +0000 (11:25 -0700)] 
Don't crash if an async function is used in the legacy xlat functions

8 years agoAdd generic talloc_list_get_type_abort function
Arran Cudbard-Bell [Fri, 26 Jan 2018 18:02:40 +0000 (11:02 -0700)] 
Add generic talloc_list_get_type_abort function

...and use it to verify the state of the result xlat eval result list

8 years agoit's now allowed to delete entries with 0 timestamp
Alan T. DeKok [Fri, 26 Jan 2018 14:11:47 +0000 (09:11 -0500)] 
it's now allowed to delete entries with 0 timestamp

because we may receive packet A (slow).  The NAS gives up and
sends packet B, which we reply to.  After that, packet A is done.
At that point, the tracking entry has timestamp=0, uses=1, so
we can now delete it.

8 years agoreference count tracking table entries
Alan T. DeKok [Fri, 26 Jan 2018 14:07:42 +0000 (09:07 -0500)] 
reference count tracking table entries

8 years agoif we found an entry in the tree, don't re-insert it...
Alan T. DeKok [Fri, 26 Jan 2018 14:07:23 +0000 (09:07 -0500)] 
if we found an entry in the tree, don't re-insert it...

8 years agopass recv_time to tracking entry delete
Alan T. DeKok [Fri, 26 Jan 2018 13:59:09 +0000 (08:59 -0500)] 
pass recv_time to tracking entry delete

so that it can do all of the logic necessary for cleanups

8 years agoZero out input value box
Arran Cudbard-Bell [Fri, 26 Jan 2018 03:47:34 +0000 (20:47 -0700)] 
Zero out input value box

Else we get a garabage enumv field and that breaks everything else

8 years agoDon't try and use result after passing it into xlat functions
Arran Cudbard-Bell [Fri, 26 Jan 2018 03:47:14 +0000 (20:47 -0700)] 
Don't try and use result after passing it into xlat functions

8 years agoCompule recv Access-Request in TLS verify virtual server
Arran Cudbard-Bell [Fri, 26 Jan 2018 03:18:44 +0000 (20:18 -0700)] 
Compule recv Access-Request in TLS verify virtual server

8 years agoIf no input...
Arran Cudbard-Bell [Fri, 26 Jan 2018 02:56:35 +0000 (19:56 -0700)] 
If no input...

8 years agoDeal with empty xlat expansions in a sane way
Arran Cudbard-Bell [Fri, 26 Jan 2018 02:47:37 +0000 (19:47 -0700)] 
Deal with empty xlat expansions in a sane way

8 years agoWe actually want a pointer to a NULL pointer because the value box code gets excited
Arran Cudbard-Bell [Fri, 26 Jan 2018 02:14:43 +0000 (19:14 -0700)] 
We actually want a pointer to a NULL pointer because the value box code gets excited

8 years agoConcat input arguments into URL string
Arran Cudbard-Bell [Fri, 26 Jan 2018 02:12:57 +0000 (19:12 -0700)] 
Concat input arguments into URL string

8 years agoFix empty result in xlat_frame_eval
Arran Cudbard-Bell [Fri, 26 Jan 2018 02:12:36 +0000 (19:12 -0700)] 
Fix empty result in xlat_frame_eval

8 years agoBoth variants?
Arran Cudbard-Bell [Fri, 26 Jan 2018 01:55:01 +0000 (18:55 -0700)] 
Both variants?

8 years agoPass empty result when calling xlat_frame_eval_repeat internally
Arran Cudbard-Bell [Fri, 26 Jan 2018 01:51:05 +0000 (18:51 -0700)] 
Pass empty result when calling xlat_frame_eval_repeat internally

8 years agoNeed to pass in **result so xlat_frame_eval and functions can indicate when they...
Arran Cudbard-Bell [Fri, 26 Jan 2018 01:48:01 +0000 (18:48 -0700)] 
Need to pass in **result so xlat_frame_eval and functions can indicate when they've consumed result boxes

8 years agoSet Accouting-Response code on handled
Arran Cudbard-Bell [Fri, 26 Jan 2018 00:43:28 +0000 (17:43 -0700)] 
Set Accouting-Response code on handled

8 years agocheck map, too
Alan T. DeKok [Fri, 26 Jan 2018 00:22:07 +0000 (19:22 -0500)] 
check map, too

8 years agoRevert "Target needs to be absolute for the rule to run in the correct order"
Alan T. DeKok [Thu, 25 Jan 2018 23:07:42 +0000 (18:07 -0500)] 
Revert "Target needs to be absolute for the rule to run in the correct order"

This reverts commit e46e496911ae57ce8843d8434bb257bbbc7996e1.

which breaks the build on most systems

8 years agotemporary hack
Alan T. DeKok [Thu, 25 Jan 2018 22:34:03 +0000 (17:34 -0500)] 
temporary hack

8 years agoassert that the pointer is of the right data type
Alan T. DeKok [Thu, 25 Jan 2018 22:19:21 +0000 (17:19 -0500)] 
assert that the pointer is of the right data type

8 years agomemdup the packet we're injecting
Alan T. DeKok [Thu, 25 Jan 2018 22:19:09 +0000 (17:19 -0500)] 
memdup the packet we're injecting

8 years agoTarget needs to be absolute for the rule to run in the correct order
Arran Cudbard-Bell [Thu, 25 Jan 2018 21:15:55 +0000 (14:15 -0700)] 
Target needs to be absolute for the rule to run in the correct order

8 years agoFixup more tests
Arran Cudbard-Bell [Thu, 25 Jan 2018 21:05:34 +0000 (14:05 -0700)] 
Fixup more tests

Adding [0] in conditions and & before attribute references

8 years agorhel7 libwbclient RPM dependencies
Matthew Newton [Thu, 25 Jan 2018 20:57:32 +0000 (20:57 +0000)] 
rhel7 libwbclient RPM dependencies

8 years agoDoxygen
Arran Cudbard-Bell [Thu, 25 Jan 2018 20:27:02 +0000 (13:27 -0700)] 
Doxygen

8 years agoUse generic talloc list free function
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:50:57 +0000 (12:50 -0700)] 
Use generic talloc list free function

8 years agoDoxygen
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:50:25 +0000 (12:50 -0700)] 
Doxygen

8 years agoclean up pointers on clone
Alan T. DeKok [Thu, 25 Jan 2018 19:31:15 +0000 (14:31 -0500)] 
clean up pointers on clone

and only free in the master

8 years agoretransmits start at 1, not at 0. Fixes #2166
Alan T. DeKok [Thu, 25 Jan 2018 19:12:04 +0000 (14:12 -0500)] 
retransmits start at 1, not at 0.  Fixes #2166

The "total packet" counters are maintained separately.
So we need to count retransmits starting from 1, not 0.

Which also means we *print* retransmits starting from 1, not 0

8 years agoHack dynamic LHS functionality back in
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:10:25 +0000 (12:10 -0700)] 
Hack dynamic LHS functionality back in

...I will fix this mess when there's not an impending deadline

8 years agoMove &foo -> &foo[*] fix to the update section fix function
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:09:36 +0000 (12:09 -0700)] 
Move &foo -> &foo[*] fix to the update section fix function

8 years agoCompile update section LHS
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:08:40 +0000 (12:08 -0700)] 
Compile update section LHS

8 years agoAdvance output cursor so we print debug correctly in xlat_eval
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:08:17 +0000 (12:08 -0700)] 
Advance output cursor so we print debug correctly in xlat_eval

8 years agoWhen calling legacy xlat functions and we don't have any input, pass in a zero length...
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:07:59 +0000 (12:07 -0700)] 
When calling legacy xlat functions and we don't have any input, pass in a zero length string

8 years agoStrip quotes correctly in fr_json_from_string
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:07:34 +0000 (12:07 -0700)] 
Strip quotes correctly in fr_json_from_string

8 years agoUse concat
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:07:09 +0000 (12:07 -0700)] 
Use concat

8 years agoUse instances explicitly
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:07:02 +0000 (12:07 -0700)] 
Use instances explicitly

8 years agoSpecify instances explicitly
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:06:45 +0000 (12:06 -0700)] 
Specify instances explicitly

8 years agoSplit update sections in quote.unlang
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:06:31 +0000 (12:06 -0700)] 
Split update sections in quote.unlang

8 years agoUse talloc_typed_strdup in more places
Arran Cudbard-Bell [Thu, 25 Jan 2018 19:06:08 +0000 (12:06 -0700)] 
Use talloc_typed_strdup in more places

So talloc_get_type_abort(foo, char) works.

8 years agoVarious test fixes
Arran Cudbard-Bell [Thu, 25 Jan 2018 17:38:11 +0000 (10:38 -0700)] 
Various test fixes

8 years agoMove unlang update code into a separate source file
Arran Cudbard-Bell [Thu, 25 Jan 2018 17:37:50 +0000 (10:37 -0700)] 
Move unlang update code into a separate source file

8 years agoBix list concat should set head box to NULL if it's freed
Arran Cudbard-Bell [Thu, 25 Jan 2018 17:37:05 +0000 (10:37 -0700)] 
Bix list concat should set head box to NULL if it's freed

8 years agoFormatting
Arran Cudbard-Bell [Thu, 25 Jan 2018 17:36:30 +0000 (10:36 -0700)] 
Formatting

8 years agoPrint (null) for null vb in %pM
Arran Cudbard-Bell [Thu, 25 Jan 2018 06:38:10 +0000 (23:38 -0700)] 
Print (null) for null vb in %pM

8 years agoMake result input to xlat functions a straight fr_value_box_t
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:56:22 +0000 (20:56 -0700)] 
Make result input to xlat functions a straight fr_value_box_t

If they need to track state over resumes, they can just keep track of it in their own cursor.

8 years agoAdd list 'o boxes free function
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:54:19 +0000 (20:54 -0700)] 
Add list 'o boxes free function

8 years agoDon't shallow copy anything...
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:27:30 +0000 (20:27 -0700)] 
Don't shallow copy anything...

8 years agoPrint the length of hash we expect
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:27:16 +0000 (20:27 -0700)] 
Print the length of hash we expect

8 years agoExplicitly specify instances
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:27:05 +0000 (20:27 -0700)] 
Explicitly specify instances

8 years agoAdd &
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:26:47 +0000 (20:26 -0700)] 
Add &

8 years ago...again have to specify Class[0] explicitly
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:26:25 +0000 (20:26 -0700)] 
...again have to specify Class[0] explicitly

8 years agoThere's no implicit [0] anymore
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:26:05 +0000 (20:26 -0700)] 
There's no implicit [0] anymore

8 years agoAdd &
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:25:40 +0000 (20:25 -0700)] 
Add &

8 years agoSpecify instances explicitly
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:25:24 +0000 (20:25 -0700)] 
Specify instances explicitly

8 years agoAdd &
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:25:05 +0000 (20:25 -0700)] 
Add &

8 years agoRegression test for multiple !* ANY maps
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:24:51 +0000 (20:24 -0700)] 
Regression test for multiple !* ANY maps

8 years agoNeed to use the first instance explicitly now
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:24:20 +0000 (20:24 -0700)] 
Need to use the first instance explicitly now

8 years agoMake update-remove-tag atomic update section safe
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:24:05 +0000 (20:24 -0700)] 
Make update-remove-tag atomic update section safe

8 years agoPrint when we create new xlat instances (debug3)
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:20:11 +0000 (20:20 -0700)] 
Print when we create new xlat instances (debug3)

8 years agoBetter safe than sorry...
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:19:56 +0000 (20:19 -0700)] 
Better safe than sorry...

8 years agoAdd new concat and bin functions
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:19:26 +0000 (20:19 -0700)] 
Add new concat and bin functions

concat joins the output of multivalued expansions together with a ',' and bin converts hex strings to binary strings

8 years agoPrint expansion of more values
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:18:43 +0000 (20:18 -0700)] 
Print expansion of more values

8 years agoDon't do shallow copies of string buffers in xlat_eval.c
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:17:56 +0000 (20:17 -0700)] 
Don't do shallow copies of string buffers in xlat_eval.c

It breaks things in subtle ways... more thinking required

8 years agoMake logic clearer in talloc_buffer_append_buffer
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:16:53 +0000 (20:16 -0700)] 
Make logic clearer in talloc_buffer_append_buffer

... and \0 terminate the output string, oops