]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 years agoDon't do shallow copies of string buffers in xlat_eval.c
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:17:56 +0000 (20:17 -0700)] 
Don't do shallow copies of string buffers in xlat_eval.c

It breaks things in subtle ways... more thinking required

8 years agoMake logic clearer in talloc_buffer_append_buffer
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:16:53 +0000 (20:16 -0700)] 
Make logic clearer in talloc_buffer_append_buffer

... and \0 terminate the output string, oops

8 years agoIf input to %pV was null substitute for (null) as with strings
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:15:56 +0000 (20:15 -0700)] 
If input to %pV was null substitute for (null) as with strings

8 years agoAllow custom format specifiers at the start of the format string
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:15:35 +0000 (20:15 -0700)] 
Allow custom format specifiers at the start of the format string

"%pV" wasn't working...

8 years agoFix fr_cursor_merge so to_append are always inserted in the correct order
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:14:58 +0000 (20:14 -0700)] 
Fix fr_cursor_merge so to_append are always inserted in the correct order

Previously they'd be reversed, which is fine for things that don't care about item ordering, but not fine for attribute lists

8 years agoRename append functions and fix logix in value.c
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:14:19 +0000 (20:14 -0700)] 
Rename append functions and fix logix in value.c

8 years agoMany many map logic fixes
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:13:35 +0000 (20:13 -0700)] 
Many many map logic fixes

8 years agoAdd map_afrom_vp which... creates a map from a VP
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:12:56 +0000 (20:12 -0700)] 
Add map_afrom_vp which... creates a map from a VP

8 years agoMove map alloc functions and add list_mod_alloc
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:12:29 +0000 (20:12 -0700)] 
Move map alloc functions and add list_mod_alloc

8 years agoRename cursor free functions to make it clearer what they do
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:11:29 +0000 (20:11 -0700)] 
Rename cursor free functions to make it clearer what they do

8 years agoFix copy/pasted typo
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:07:42 +0000 (20:07 -0700)] 
Fix copy/pasted typo

8 years agoNeed to shallow copy the map for !* ANY
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:06:10 +0000 (20:06 -0700)] 
Need to shallow copy the map for !* ANY

8 years agoPrint more friendly exec debug information
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:05:34 +0000 (20:05 -0700)] 
Print more friendly exec debug information

8 years agoPerform xlat instantiation in the right order in unit_test_module.c
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:04:27 +0000 (20:04 -0700)] 
Perform xlat instantiation in the right order in unit_test_module.c

8 years agoFormatting
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:04:07 +0000 (20:04 -0700)] 
Formatting

8 years agoFormatting
Arran Cudbard-Bell [Thu, 25 Jan 2018 03:03:59 +0000 (20:03 -0700)] 
Formatting

8 years agoShould be an error...
Arran Cudbard-Bell [Wed, 24 Jan 2018 00:54:30 +0000 (17:54 -0700)] 
Should be an error...

8 years agoUse the len argument iterator for lengths
Arran Cudbard-Bell [Wed, 24 Jan 2018 00:38:08 +0000 (17:38 -0700)] 
Use the len argument iterator for lengths

8 years agoSimplify %pM
Arran Cudbard-Bell [Wed, 24 Jan 2018 00:37:48 +0000 (17:37 -0700)] 
Simplify %pM

8 years agoPrint state of the request after update
Arran Cudbard-Bell [Wed, 24 Jan 2018 00:37:13 +0000 (17:37 -0700)] 
Print state of the request after update

8 years agoHave foreach allocate its own buffers
Arran Cudbard-Bell [Wed, 24 Jan 2018 00:36:55 +0000 (17:36 -0700)] 
Have foreach allocate its own buffers

8 years agoAdd utility functions for appending to and concatenating boxed values
Arran Cudbard-Bell [Tue, 23 Jan 2018 23:49:54 +0000 (16:49 -0700)] 
Add utility functions for appending to and concatenating boxed values

8 years agoFix vb strsteal function name
Arran Cudbard-Bell [Tue, 23 Jan 2018 23:49:28 +0000 (16:49 -0700)] 
Fix vb strsteal function name

8 years agoFix value box foreach macro
Arran Cudbard-Bell [Tue, 23 Jan 2018 23:48:58 +0000 (16:48 -0700)] 
Fix value box foreach macro

8 years agoAdd next pointer to vp_list_mod
Arran Cudbard-Bell [Tue, 23 Jan 2018 23:48:47 +0000 (16:48 -0700)] 
Add next pointer to vp_list_mod

8 years agoTypes which should have quotes
Arran Cudbard-Bell [Tue, 23 Jan 2018 23:48:36 +0000 (16:48 -0700)] 
Types which should have quotes

8 years agoFormatting
Arran Cudbard-Bell [Tue, 23 Jan 2018 23:46:24 +0000 (16:46 -0700)] 
Formatting

8 years agoParent buffer values correctly in xlat_frame_eval
Arran Cudbard-Bell [Tue, 23 Jan 2018 23:46:12 +0000 (16:46 -0700)] 
Parent buffer values correctly in xlat_frame_eval

8 years agoprocess new conflicting packets
Alan T. DeKok [Thu, 25 Jan 2018 16:55:48 +0000 (11:55 -0500)] 
process new conflicting packets

8 years agoremove extraneous debug messages
Alan T. DeKok [Thu, 25 Jan 2018 16:51:12 +0000 (11:51 -0500)] 
remove extraneous debug messages

8 years agomissing space
Matthew Newton [Thu, 25 Jan 2018 15:43:28 +0000 (15:43 +0000)] 
missing space

8 years agodon't delete entries which are too old
Alan T. DeKok [Thu, 25 Jan 2018 05:24:27 +0000 (00:24 -0500)] 
don't delete entries which are too old

8 years agoreturn error if we can't assert at run-time
Alan T. DeKok [Thu, 25 Jan 2018 05:22:00 +0000 (00:22 -0500)] 
return error if we can't assert at run-time

8 years agoinitialize list for dynamic clients
Alan T. DeKok [Wed, 24 Jan 2018 16:59:48 +0000 (11:59 -0500)] 
initialize list for dynamic clients

8 years ago8K is probably too much
Alan T. DeKok [Wed, 24 Jan 2018 08:43:06 +0000 (03:43 -0500)] 
8K is probably too much

8 years agoFix stats timer argument order
Arran Cudbard-Bell [Tue, 23 Jan 2018 17:15:26 +0000 (10:15 -0700)] 
Fix stats timer argument order

Fix from pwdng

8 years agocopy the unknown VP, due to pool issues
Alan T. DeKok [Tue, 23 Jan 2018 13:13:24 +0000 (08:13 -0500)] 
copy the unknown VP, due to pool issues

8 years agoset a larger pool
Alan T. DeKok [Tue, 23 Jan 2018 13:06:11 +0000 (08:06 -0500)] 
set a larger pool

it's temporary.  But a small pool will cause it to just use
normal allocs.

8 years agoDoxygen
Arran Cudbard-Bell [Tue, 23 Jan 2018 04:17:14 +0000 (21:17 -0700)] 
Doxygen

8 years agoNew version of map_to_request and map_to_vp
Arran Cudbard-Bell [Tue, 23 Jan 2018 03:53:03 +0000 (20:53 -0700)] 
New version of map_to_request and map_to_vp

These assume xlat evaluation will be done by the caller with the results being passed in and also allow the creation and application of a linked list of modifications, so that updates can be atomic again (yay!).

8 years agoClarify use of xlat_unlang_push
Arran Cudbard-Bell [Tue, 23 Jan 2018 03:33:16 +0000 (20:33 -0700)] 
Clarify use of xlat_unlang_push

8 years agoFormatting
Arran Cudbard-Bell [Tue, 23 Jan 2018 03:32:50 +0000 (20:32 -0700)] 
Formatting

8 years agoIterator for next_by_da for new cusor code
Arran Cudbard-Bell [Tue, 23 Jan 2018 03:32:40 +0000 (20:32 -0700)] 
Iterator for next_by_da for new cusor code

8 years agoFormatting
Arran Cudbard-Bell [Tue, 23 Jan 2018 03:30:10 +0000 (20:30 -0700)] 
Formatting

8 years agoFormatting
Arran Cudbard-Bell [Tue, 23 Jan 2018 03:30:00 +0000 (20:30 -0700)] 
Formatting

8 years agoSet next pointer to NULL in fr_value_box_copy_meta
Arran Cudbard-Bell [Tue, 23 Jan 2018 03:29:48 +0000 (20:29 -0700)] 
Set next pointer to NULL in fr_value_box_copy_meta

8 years agoPrint helpful error strings in tmpl_cursor_init
Arran Cudbard-Bell [Tue, 23 Jan 2018 03:29:08 +0000 (20:29 -0700)] 
Print helpful error strings in tmpl_cursor_init

8 years agodisable client tries until issues have been worked out
Alan T. DeKok [Sun, 21 Jan 2018 15:02:04 +0000 (10:02 -0500)] 
disable client tries until issues have been worked out

8 years agoDoxygen
Arran Cudbard-Bell [Sat, 20 Jan 2018 19:37:13 +0000 (12:37 -0700)] 
Doxygen

8 years agoMove to dynamically allocated redundant state
Arran Cudbard-Bell [Sat, 20 Jan 2018 19:23:43 +0000 (12:23 -0700)] 
Move to dynamically allocated redundant state

With the static states gone the stack should be much smaller.  The foreach state removed the stack for each request is now 4K smaller, which is non-negligable when you're dealing with 100s of thousands of requests.

8 years agoMove to dynamically allocated foreach state
Arran Cudbard-Bell [Sat, 20 Jan 2018 19:14:51 +0000 (12:14 -0700)] 
Move to dynamically allocated foreach state

8 years agoThey're frame states not stack states
Arran Cudbard-Bell [Sat, 20 Jan 2018 18:52:23 +0000 (11:52 -0700)] 
They're frame states not stack states

8 years agoGeneral reshuffling of unlang/xlat things into their proper places
Arran Cudbard-Bell [Sat, 20 Jan 2018 18:42:51 +0000 (11:42 -0700)] 
General reshuffling of unlang/xlat things into their proper places

The signal enum needs to be in its own header, because it's used by the proto module state machines and the unlang interpreter, but the two really shouldn't know about each other.

8 years agoNew compiler, new warnings
Arran Cudbard-Bell [Sat, 20 Jan 2018 18:38:54 +0000 (11:38 -0700)] 
New compiler, new warnings

8 years agoSmall tweaks/fixes
Arran Cudbard-Bell [Sat, 20 Jan 2018 01:14:28 +0000 (18:14 -0700)] 
Small tweaks/fixes

8 years agoBe forgiving when calling access functions on NULL cursors
Arran Cudbard-Bell [Sat, 20 Jan 2018 01:10:06 +0000 (18:10 -0700)] 
Be forgiving when calling access functions on NULL cursors

8 years agoRemove old interpreter.h
Arran Cudbard-Bell [Fri, 19 Jan 2018 23:34:07 +0000 (16:34 -0700)] 
Remove old interpreter.h

8 years agoDon't mess with request->module on resumption
Arran Cudbard-Bell [Fri, 19 Jan 2018 23:33:44 +0000 (16:33 -0700)] 
Don't mess with request->module on resumption

We need a better way of handling this...

8 years agoFixes in rest async xlat
Arran Cudbard-Bell [Fri, 19 Jan 2018 23:33:24 +0000 (16:33 -0700)] 
Fixes in rest async xlat

8 years agoMove async xlat fully out of the interpreter
Arran Cudbard-Bell [Fri, 19 Jan 2018 23:33:07 +0000 (16:33 -0700)] 
Move async xlat fully out of the interpreter

There's still good separation between the xlat interpreter and the unlang interpeter though, which is nice, as it means we can write a "synchronous" loop around the new async xlat interpreter for use in utilities.

8 years agoAdd %pM to print multiple value boxes as a concatenated string
Arran Cudbard-Bell [Fri, 19 Jan 2018 23:31:33 +0000 (16:31 -0700)] 
Add %pM to print multiple value boxes as a concatenated string

8 years agoConsistency
Arran Cudbard-Bell [Fri, 19 Jan 2018 21:41:54 +0000 (14:41 -0700)] 
Consistency

8 years agore-add (commented out) old client code again
Alan T. DeKok [Fri, 19 Jan 2018 20:57:34 +0000 (15:57 -0500)] 
re-add (commented out) old client code again

8 years agoFix more things so they use the strerror stack
Arran Cudbard-Bell [Fri, 19 Jan 2018 20:35:45 +0000 (13:35 -0700)] 
Fix more things so they use the strerror stack

8 years agodoxygen
Alan T. DeKok [Fri, 19 Jan 2018 19:24:56 +0000 (14:24 -0500)] 
doxygen

8 years agoFix unknown attributes when created by use in unlang
Arran Cudbard-Bell [Fri, 19 Jan 2018 19:15:21 +0000 (12:15 -0700)] 
Fix unknown attributes when created by use in unlang

8 years agoPrint the full error stack in map.c
Arran Cudbard-Bell [Fri, 19 Jan 2018 18:39:40 +0000 (11:39 -0700)] 
Print the full error stack in map.c

8 years agomake tmpl_verify() happy
Alan T. DeKok [Fri, 19 Jan 2018 14:31:13 +0000 (09:31 -0500)] 
make tmpl_verify() happy

8 years agoclarify the code
Alan T. DeKok [Fri, 19 Jan 2018 14:24:03 +0000 (09:24 -0500)] 
clarify the code

We probably also want to check for names / da being NULL...
which seems to be an issue in rlm_cache.c:412

8 years agoUse different name for module and thread instance data in modules.c
Arran Cudbard-Bell [Fri, 19 Jan 2018 18:15:08 +0000 (11:15 -0700)] 
Use different name for module and thread instance data in modules.c

Makes it slightly less confusing. ish...

8 years agoAdd rlm_rest xlat back as an async expansion
Arran Cudbard-Bell [Fri, 19 Jan 2018 02:01:24 +0000 (19:01 -0700)] 
Add rlm_rest xlat back as an async expansion

It sends requests at least... More work needed to call the resume function properly

8 years agoVarious fixes in xlat_inst.c
Arran Cudbard-Bell [Fri, 19 Jan 2018 02:00:27 +0000 (19:00 -0700)] 
Various fixes in xlat_inst.c

8 years agoAllow thread instances to be looked up with module instances
Arran Cudbard-Bell [Fri, 19 Jan 2018 01:59:56 +0000 (18:59 -0700)] 
Allow thread instances to be looked up with module instances

8 years agoSimplify xlat instance destructors and xlat destructors
Arran Cudbard-Bell [Thu, 18 Jan 2018 23:47:48 +0000 (16:47 -0700)] 
Simplify xlat instance destructors and xlat destructors

8 years agoSome dumb hacks that solve a bunch of ordering issues with rbtrees and destructors
Arran Cudbard-Bell [Thu, 18 Jan 2018 23:30:50 +0000 (16:30 -0700)] 
Some dumb hacks that solve a bunch of ordering issues with rbtrees and destructors

8 years agoPlumb in xlat instances
Arran Cudbard-Bell [Thu, 18 Jan 2018 21:25:00 +0000 (14:25 -0700)] 
Plumb in xlat instances

Delay instantiation of xlats until xlat_instantiate() is called.

This means the boostrap phase of the server is fully complete by the time we start creating xlat instances.

8 years agomodule_thread_instance_find returns a module_thread_instance_t
Arran Cudbard-Bell [Thu, 18 Jan 2018 20:20:28 +0000 (13:20 -0700)] 
module_thread_instance_find returns a module_thread_instance_t

8 years agoFixup number of elements in the tree
Arran Cudbard-Bell [Thu, 18 Jan 2018 20:19:19 +0000 (13:19 -0700)] 
Fixup number of elements in the tree

It's visible to children being freed

8 years agotypo
Alan T. DeKok [Thu, 18 Jan 2018 17:39:32 +0000 (12:39 -0500)] 
typo

8 years agocomnvert asserts to run-time checks
Alan T. DeKok [Thu, 18 Jan 2018 17:05:32 +0000 (12:05 -0500)] 
comnvert asserts to run-time checks

8 years agouse rad_assert
Alan T. DeKok [Thu, 18 Jan 2018 16:23:38 +0000 (11:23 -0500)] 
use rad_assert

8 years agouse consistent names for variables
Alan T. DeKok [Thu, 18 Jan 2018 15:40:25 +0000 (10:40 -0500)] 
use consistent names for variables

8 years agomake reparent return the trie
Alan T. DeKok [Thu, 18 Jan 2018 15:31:44 +0000 (10:31 -0500)] 
make reparent return the trie

a bit more complex, but less code for each call,
and easier to automatically verify assignments

8 years agorename trie to entry
Alan T. DeKok [Thu, 18 Jan 2018 15:16:57 +0000 (10:16 -0500)] 
rename trie to entry

8 years agoAdd xlat instantiation framework
Arran Cudbard-Bell [Thu, 18 Jan 2018 01:50:16 +0000 (18:50 -0700)] 
Add xlat instantiation framework

8 years agoGroup xlat functions in unlang_op.c
Arran Cudbard-Bell [Thu, 18 Jan 2018 01:30:30 +0000 (18:30 -0700)] 
Group xlat functions in unlang_op.c

8 years agodoxygen
Alan T. DeKok [Thu, 18 Jan 2018 01:23:33 +0000 (20:23 -0500)] 
doxygen

8 years agowell-known clients cannot be behind a NAT
Alan T. DeKok [Wed, 17 Jan 2018 22:25:14 +0000 (17:25 -0500)] 
well-known clients cannot be behind a NAT

8 years agodynamic clients behind a NAT gateway are not in any list
Alan T. DeKok [Wed, 17 Jan 2018 22:09:23 +0000 (17:09 -0500)] 
dynamic clients behind a NAT gateway are not in any list

instead, they cause a connection to be created, and that's that...

8 years agorename to "behind_nat"
Alan T. DeKok [Wed, 17 Jan 2018 21:52:10 +0000 (16:52 -0500)] 
rename to "behind_nat"

note that the admin CANNOT set static or dynamic clients as
being NAT gateways.  Instead, the code does that internally

8 years agomore handling of nat'd clients
Alan T. DeKok [Wed, 17 Jan 2018 21:41:10 +0000 (16:41 -0500)] 
more handling of nat'd clients

8 years agodon't immediately delete NATed clients
Alan T. DeKok [Wed, 17 Jan 2018 21:28:37 +0000 (16:28 -0500)] 
don't immediately delete NATed clients

8 years agogeneralize handling of conflicting packets
Alan T. DeKok [Wed, 17 Jan 2018 21:17:02 +0000 (16:17 -0500)] 
generalize handling of conflicting packets

8 years agoInclude unlang.h where it's needed
Arran Cudbard-Bell [Wed, 17 Jan 2018 22:23:19 +0000 (15:23 -0700)] 
Include unlang.h where it's needed

8 years agoCreate public/private heders for unlang code
Arran Cudbard-Bell [Wed, 17 Jan 2018 21:42:52 +0000 (14:42 -0700)] 
Create public/private heders for unlang code

Move operations to basic registration API.  Needs more work, but at least we can now move the xlat stuff out of the interpreter.

8 years agotidy random symlinks added in 8404a2a1
Matthew Newton [Wed, 17 Jan 2018 17:34:15 +0000 (17:34 +0000)] 
tidy random symlinks added in 8404a2a1

8 years ago'&' is not a valid attribute or list name
Alan T. DeKok [Wed, 17 Jan 2018 16:09:45 +0000 (11:09 -0500)] 
'&' is not a valid attribute or list name

8 years agosockfd is unused
Alan T. DeKok [Wed, 17 Jan 2018 15:59:50 +0000 (10:59 -0500)] 
sockfd is unused

8 years agoinitialize all of "address"
Alan T. DeKok [Wed, 17 Jan 2018 15:12:19 +0000 (10:12 -0500)] 
initialize all of "address"

8 years agolimit number of packets we read from one socket
Alan T. DeKok [Wed, 17 Jan 2018 14:54:08 +0000 (09:54 -0500)] 
limit number of packets we read from one socket

so that we don't starve other sockets