]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
8 years agoRefer to the resume ctx as rctx
Arran Cudbard-Bell [Fri, 24 Nov 2017 15:18:04 +0000 (15:18 +0000)] 
Refer to the resume ctx as rctx

8 years agoThere's no reason to store the module instance when we can get it from the previous...
Arran Cudbard-Bell [Fri, 24 Nov 2017 14:40:01 +0000 (14:40 +0000)] 
There's no reason to store the module instance when we can get it from the previous instruction

8 years agoRevert "move code to before Message-Authenticator calculation"
Alan T. DeKok [Thu, 23 Nov 2017 19:48:03 +0000 (14:48 -0500)] 
Revert "move code to before Message-Authenticator calculation"

This reverts commit 211870f2bf7773179ccba9f9d0aa79783c94796b.

8 years agomore cleanups for dynamic clients
Alan T. DeKok [Thu, 23 Nov 2017 19:37:05 +0000 (14:37 -0500)] 
more cleanups for dynamic clients

8 years agorun "deny" section
Alan T. DeKok [Thu, 23 Nov 2017 19:29:28 +0000 (14:29 -0500)] 
run "deny" section

8 years agoremove more old dynamic client fields / code
Alan T. DeKok [Thu, 23 Nov 2017 19:07:59 +0000 (14:07 -0500)] 
remove more old dynamic client fields / code

8 years agomake 'dynamic' boolean, and clean up dynamic logic.
Alan T. DeKok [Thu, 23 Nov 2017 19:04:23 +0000 (14:04 -0500)] 
make 'dynamic' boolean, and clean up dynamic logic.

clients from SQL / LDAP are no longer dynamic ones.  They're
static and can't be deleted after startup.

Once we finish the new dynamic client code, the old SQL / LDAP
"read client" functionality should be deleted.

8 years agodynamic clients must contain at least an IP and shared secret
Alan T. DeKok [Thu, 23 Nov 2017 18:57:13 +0000 (13:57 -0500)] 
dynamic clients must contain at least an IP and shared secret

8 years agosuppress errors
Alan T. DeKok [Thu, 23 Nov 2017 18:32:56 +0000 (13:32 -0500)] 
suppress errors

8 years agostupid compilers are becoming annoying
Alan T. DeKok [Thu, 23 Nov 2017 17:35:45 +0000 (12:35 -0500)] 
stupid compilers are becoming annoying

8 years agomore static analysis
Alan T. DeKok [Thu, 23 Nov 2017 17:17:46 +0000 (12:17 -0500)] 
more static analysis

8 years agotypo
Alan T. DeKok [Thu, 23 Nov 2017 16:15:36 +0000 (11:15 -0500)] 
typo

8 years agotypo
Alan T. DeKok [Thu, 23 Nov 2017 16:12:55 +0000 (11:12 -0500)] 
typo

8 years agostupid compiler static analysis
Alan T. DeKok [Thu, 23 Nov 2017 15:56:06 +0000 (10:56 -0500)] 
stupid compiler static analysis

8 years agoassert we have a packet
Alan T. DeKok [Thu, 23 Nov 2017 15:43:09 +0000 (10:43 -0500)] 
assert we have a packet

8 years agoalways save packet in case of retransmission/ Fixes #2118
Alan T. DeKok [Thu, 23 Nov 2017 15:19:17 +0000 (10:19 -0500)] 
always save packet in case of retransmission/  Fixes #2118

8 years agowhoops... length is in [1], not [2]. Helps with #2118
Alan T. DeKok [Thu, 23 Nov 2017 15:16:36 +0000 (10:16 -0500)] 
whoops... length is in [1], not [2].  Helps with #2118

8 years agotrack outstanding packets
Alan T. DeKok [Thu, 23 Nov 2017 15:14:04 +0000 (10:14 -0500)] 
track outstanding packets

8 years agomore stupid static analysis
Alan T. DeKok [Thu, 23 Nov 2017 13:58:05 +0000 (08:58 -0500)] 
more stupid static analysis

8 years agodoxygen
Alan T. DeKok [Thu, 23 Nov 2017 13:56:40 +0000 (08:56 -0500)] 
doxygen

8 years agoTrim trailing whitespace
Arran Cudbard-Bell [Thu, 23 Nov 2017 12:24:57 +0000 (12:24 +0000)] 
Trim trailing whitespace

8 years agoStupid static analysis
Arran Cudbard-Bell [Thu, 23 Nov 2017 12:16:19 +0000 (12:16 +0000)] 
Stupid static analysis

8 years agohandle conflicting packets in dynamic clients
Alan T. DeKok [Wed, 22 Nov 2017 21:43:12 +0000 (16:43 -0500)] 
handle conflicting packets in dynamic clients

8 years agotry to silence apparently random C compiler warnings?
Alan T. DeKok [Wed, 22 Nov 2017 21:35:45 +0000 (16:35 -0500)] 
try to silence apparently random C compiler warnings?

8 years agocache nr, too
Alan T. DeKok [Wed, 22 Nov 2017 21:19:25 +0000 (16:19 -0500)] 
cache nr, too

8 years agocall app_io->encode if it exists
Alan T. DeKok [Wed, 22 Nov 2017 21:19:03 +0000 (16:19 -0500)] 
call app_io->encode if it exists

in preparation for encoding RADCLIENT (sort of...)

8 years agodon't print out packet, just attributes
Alan T. DeKok [Wed, 22 Nov 2017 20:58:43 +0000 (15:58 -0500)] 
don't print out packet, just attributes

8 years agomore debug
Alan T. DeKok [Wed, 22 Nov 2017 20:56:59 +0000 (15:56 -0500)] 
more debug

8 years agotypo
Alan T. DeKok [Wed, 22 Nov 2017 20:56:49 +0000 (15:56 -0500)] 
typo

8 years agomash all encrypted attributes to empty
Alan T. DeKok [Wed, 22 Nov 2017 20:53:05 +0000 (15:53 -0500)] 
mash all encrypted attributes to empty

instead of giving garbage data to the admin

8 years agosecrets are talloc'd
Alan T. DeKok [Wed, 22 Nov 2017 20:39:58 +0000 (15:39 -0500)] 
secrets are talloc'd

8 years agocan't allocate client list parented from CONF_SECTION
Alan T. DeKok [Wed, 22 Nov 2017 20:38:45 +0000 (15:38 -0500)] 
can't allocate client list parented from CONF_SECTION

because it's frozen after parsing..

8 years agostart of fixes to mod_write() for dynamic clients
Alan T. DeKok [Wed, 22 Nov 2017 20:36:06 +0000 (15:36 -0500)] 
start of fixes to mod_write() for dynamic clients

8 years agodo prefix masking
Alan T. DeKok [Wed, 22 Nov 2017 20:35:46 +0000 (15:35 -0500)] 
do prefix masking

8 years agoinitialize dynamic client list.
Alan T. DeKok [Wed, 22 Nov 2017 19:45:22 +0000 (14:45 -0500)] 
initialize dynamic client list.

And as a nice side-effect, allow for per-server static clients
again.

8 years agoinstantiate proto_radius_dynamic_client, too
Alan T. DeKok [Wed, 22 Nov 2017 19:36:15 +0000 (14:36 -0500)] 
instantiate proto_radius_dynamic_client, too

8 years agotypo
Alan T. DeKok [Wed, 22 Nov 2017 19:36:06 +0000 (14:36 -0500)] 
typo

8 years agoput clients / packets into lists
Alan T. DeKok [Wed, 22 Nov 2017 19:27:32 +0000 (14:27 -0500)] 
put clients / packets into lists

8 years agoflesh out packet save / restore
Alan T. DeKok [Wed, 22 Nov 2017 18:46:07 +0000 (13:46 -0500)] 
flesh out packet save / restore

8 years agoresign packets only once
Alan T. DeKok [Wed, 22 Nov 2017 18:20:52 +0000 (13:20 -0500)] 
resign packets only once

8 years agocheck for num_pending_packets and flesh it out a little more
Alan T. DeKok [Wed, 22 Nov 2017 18:03:53 +0000 (13:03 -0500)] 
check for num_pending_packets and flesh it out a little more

8 years agoexpose proto_radius_dynamic_client to set_process function
Alan T. DeKok [Wed, 22 Nov 2017 18:03:24 +0000 (13:03 -0500)] 
expose proto_radius_dynamic_client to set_process function

8 years agoMerge pull request #2131 from dulin/fix-missing-id-column
Arran Cudbard-Bell [Wed, 22 Nov 2017 17:50:38 +0000 (17:50 +0000)] 
Merge pull request #2131 from dulin/fix-missing-id-column

Fix missing id column in radusergroup

8 years agomore fleshing out of dynamic client code
Alan T. DeKok [Wed, 22 Nov 2017 16:43:36 +0000 (11:43 -0500)] 
more fleshing out of dynamic client code

8 years agomove checks to bootstrap, and load proto_radius_dynamic_client
Alan T. DeKok [Wed, 22 Nov 2017 16:13:39 +0000 (11:13 -0500)] 
move checks to bootstrap, and load proto_radius_dynamic_client

8 years agouse new "OK_MISSING".
Alan T. DeKok [Wed, 22 Nov 2017 16:13:00 +0000 (11:13 -0500)] 
use new "OK_MISSING".

which means we don't always create "dynamic_clients" subsections,
even if they don't exist

8 years agoallow subsections to be missing
Alan T. DeKok [Wed, 22 Nov 2017 16:11:06 +0000 (11:11 -0500)] 
allow subsections to be missing

if so, they are not parsed or printed

8 years agostart of dynamic client code
Alan T. DeKok [Mon, 20 Nov 2017 19:11:41 +0000 (14:11 -0500)] 
start of dynamic client code

8 years agoFix missing id column in radusergroup 2131/head
Martin Dulin [Wed, 22 Nov 2017 11:57:47 +0000 (11:57 +0000)] 
Fix missing id column in radusergroup

8 years agoWire in async xlat functions
Arran Cudbard-Bell [Tue, 21 Nov 2017 21:33:36 +0000 (21:33 +0000)] 
Wire in async xlat functions

8 years agocreate and add a new client.
Alan T. DeKok [Tue, 21 Nov 2017 19:25:06 +0000 (14:25 -0500)] 
create and add a new client.

8 years agoTest the rlm_delay cancellation point works
Arran Cudbard-Bell [Tue, 21 Nov 2017 19:18:48 +0000 (19:18 +0000)] 
Test the rlm_delay cancellation point works

8 years agoAdd cancellation point for rlm_delay
Arran Cudbard-Bell [Tue, 21 Nov 2017 19:12:46 +0000 (19:12 +0000)] 
Add cancellation point for rlm_delay

8 years agoRemove unused fr_state_action_t
Arran Cudbard-Bell [Tue, 21 Nov 2017 19:12:32 +0000 (19:12 +0000)] 
Remove unused fr_state_action_t

8 years agomove assert to run-time check
Alan T. DeKok [Tue, 21 Nov 2017 19:13:34 +0000 (14:13 -0500)] 
move assert to run-time check

8 years agosignal children to be DONE when exiting a parallel section
Alan T. DeKok [Tue, 21 Nov 2017 18:55:54 +0000 (13:55 -0500)] 
signal children to be DONE when exiting a parallel section

i.e. tell the children that they're cancelled.

8 years agoAdd tests for parallel rcodes
Arran Cudbard-Bell [Tue, 21 Nov 2017 17:54:22 +0000 (17:54 +0000)] 
Add tests for parallel rcodes

8 years agomove code to before Message-Authenticator calculation
Alan T. DeKok [Tue, 21 Nov 2017 17:12:48 +0000 (12:12 -0500)] 
move code to before Message-Authenticator calculation

8 years agocache the signed vector for checking response authenticators
Alan T. DeKok [Tue, 21 Nov 2017 17:11:36 +0000 (12:11 -0500)] 
cache the signed vector for checking response authenticators

8 years agostart of dynamic_client_alloc()
Alan T. DeKok [Tue, 21 Nov 2017 16:45:09 +0000 (11:45 -0500)] 
start of dynamic_client_alloc()

8 years agostart of dynamic client code
Alan T. DeKok [Tue, 21 Nov 2017 16:27:43 +0000 (11:27 -0500)] 
start of dynamic client code

8 years ago...because you know static analysis is going to flag that at some point *sigh*
Arran Cudbard-Bell [Tue, 21 Nov 2017 16:29:17 +0000 (16:29 +0000)] 
...because you know static analysis is going to flag that at some point *sigh*

8 years agoUse current result not frame->result when yielding
Arran Cudbard-Bell [Tue, 21 Nov 2017 16:26:18 +0000 (16:26 +0000)] 
Use current result not frame->result when yielding

and don't mess with frame->result

8 years agoRevert "Set frame->result when yielding"
Arran Cudbard-Bell [Tue, 21 Nov 2017 16:22:00 +0000 (16:22 +0000)] 
Revert "Set frame->result when yielding"

This reverts commit 1f7ceeb44c90809c668d68f07e749c85c52a9f8b.

8 years agothere is always a module return code.
Alan T. DeKok [Tue, 21 Nov 2017 16:19:19 +0000 (11:19 -0500)] 
there is always a module return code.

This goes along with commit a262092bf41c

8 years agofix for EAP-FAST.
Alan T. DeKok [Tue, 21 Nov 2017 16:12:24 +0000 (11:12 -0500)] 
fix for EAP-FAST.

The parent TLV has been decoded into a "struct".  So we can't
check the sizes.  And the sizes of the various fields are 8-bit,
not 32-bit

8 years agofmt is parented from node, not node->fmt
Alan T. DeKok [Mon, 20 Nov 2017 20:09:08 +0000 (15:09 -0500)] 
fmt is parented from node, not node->fmt

8 years agoallow COMBO_IP_PREFIX too
Alan T. DeKok [Tue, 21 Nov 2017 16:05:40 +0000 (11:05 -0500)] 
allow COMBO_IP_PREFIX too

8 years agorequest->rcode is return code from last module call
Alan T. DeKok [Tue, 21 Nov 2017 15:49:49 +0000 (10:49 -0500)] 
request->rcode is return code from last module call

8 years ago0 is RLM_MODULE_REJECT, which is a valid rcode
Alan T. DeKok [Tue, 21 Nov 2017 15:45:44 +0000 (10:45 -0500)] 
0 is RLM_MODULE_REJECT, which is a valid rcode

8 years agoadd combo IP address / prefix
Alan T. DeKok [Mon, 20 Nov 2017 21:00:03 +0000 (16:00 -0500)] 
add combo IP address / prefix

8 years agoclang scan fix
Arran Cudbard-Bell [Tue, 21 Nov 2017 15:08:20 +0000 (15:08 +0000)] 
clang scan fix

8 years agoAdd a test for yielding within a parallel section
Arran Cudbard-Bell [Tue, 21 Nov 2017 14:50:29 +0000 (14:50 +0000)] 
Add a test for yielding within a parallel section

8 years agoAdd a delay module that we can use to force requests to yield and be immediately...
Arran Cudbard-Bell [Tue, 21 Nov 2017 14:50:05 +0000 (14:50 +0000)] 
Add a delay module that we can use to force requests to yield and be immediately rescheduled

8 years agoCheck the current rcode not the frame rcode for the UNLANG_ACTION_YIELD hack
Arran Cudbard-Bell [Tue, 21 Nov 2017 14:49:36 +0000 (14:49 +0000)] 
Check the current rcode not the frame rcode for the UNLANG_ACTION_YIELD hack

8 years agoCheck for an attempt to pop the top frame and deal with that explicitly by breaking...
Arran Cudbard-Bell [Tue, 21 Nov 2017 14:49:04 +0000 (14:49 +0000)] 
Check for an attempt to pop the top frame and deal with that explicitly by breaking out the interpreter loop

This allows the function to return at the right point without decrementing stack->depth

8 years agoFormatting
Arran Cudbard-Bell [Tue, 21 Nov 2017 14:48:06 +0000 (14:48 +0000)] 
Formatting

8 years agoFlesh out unlang_interpret_synchronous some more so it has a fake backlog to go with...
Arran Cudbard-Bell [Tue, 21 Nov 2017 14:47:07 +0000 (14:47 +0000)] 
Flesh out unlang_interpret_synchronous some more so it has a fake backlog to go with its fake event list

8 years agoBetter name
Arran Cudbard-Bell [Tue, 21 Nov 2017 14:45:19 +0000 (14:45 +0000)] 
Better name

8 years agoSet frame->result when yielding
Arran Cudbard-Bell [Tue, 21 Nov 2017 12:21:13 +0000 (12:21 +0000)] 
Set frame->result when yielding

8 years agoIgnore bad binding attributes
Arran Cudbard-Bell [Tue, 21 Nov 2017 11:50:07 +0000 (11:50 +0000)] 
Ignore bad binding attributes

8 years agoUse a proper event loop in unit_test_module.c and remove proto_radius from the test...
Arran Cudbard-Bell [Tue, 21 Nov 2017 11:03:31 +0000 (11:03 +0000)] 
Use a proper event loop in unit_test_module.c and remove proto_radius from the test path

We're testing unlang keywords, not the proto_radius module

8 years agoAllow zero delay in rlm_delay (just forces the request to be rescheduled)
Arran Cudbard-Bell [Tue, 21 Nov 2017 10:46:44 +0000 (10:46 +0000)] 
Allow zero delay in rlm_delay (just forces the request to be rescheduled)

8 years agoset THREADID callbacks instead of global callbacks
Alan T. DeKok [Mon, 20 Nov 2017 18:53:28 +0000 (13:53 -0500)] 
set THREADID callbacks instead of global callbacks

when we have them.

8 years agoeap-fast: fail on crypto-binding mismatch
Alan T. DeKok [Fri, 17 Nov 2017 21:05:33 +0000 (16:05 -0500)] 
eap-fast: fail on crypto-binding mismatch
as per rfc 4851, an invalid crypto-binding tlv is a
fatal error, handle accordingly.

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
8 years agocheck sizes, and port fixes from 3.0
Alan T. DeKok [Mon, 20 Nov 2017 18:42:58 +0000 (13:42 -0500)] 
check sizes, and port fixes from 3.0

8 years agoUpdate dockerbuild script to match Arran's new names
Matthew Newton [Mon, 20 Nov 2017 18:41:00 +0000 (18:41 +0000)] 
Update dockerbuild script to match Arran's new names

8 years agoRename the Dockerfile that builds the dependencies to Dockerfile.deps not Dockerfile...
Arran Cudbard-Bell [Mon, 20 Nov 2017 16:05:06 +0000 (16:05 +0000)] 
Rename the Dockerfile that builds the dependencies to Dockerfile.deps not Dockerfile.source

8 years agodon't add quotes. GNU Make is very literal about it
Alan T. DeKok [Sat, 18 Nov 2017 14:29:08 +0000 (09:29 -0500)] 
don't add quotes.  GNU Make is very literal about it

and doesn't need them

8 years agoPull libkqueue from the official freeradius fork
Arran Cudbard-Bell [Mon, 20 Nov 2017 15:48:15 +0000 (15:48 +0000)] 
Pull libkqueue from the official freeradius fork

8 years agoCID 1422228
Arran Cudbard-Bell [Mon, 20 Nov 2017 15:05:16 +0000 (15:05 +0000)] 
CID 1422228

8 years agoAdd registration functions and a new prototype for async xlats
Arran Cudbard-Bell [Sun, 19 Nov 2017 11:32:23 +0000 (11:32 +0000)] 
Add registration functions and a new prototype for async xlats

8 years agoFix strict-prototypes warnings in MySQL
Arran Cudbard-Bell [Sun, 19 Nov 2017 10:56:49 +0000 (10:56 +0000)] 
Fix strict-prototypes warnings in MySQL

8 years agoAdd xlat_init function
Arran Cudbard-Bell [Sat, 18 Nov 2017 20:21:11 +0000 (20:21 +0000)] 
Add xlat_init function

8 years agoDefine mem macro in control_test.c
Arran Cudbard-Bell [Sat, 18 Nov 2017 13:03:23 +0000 (13:03 +0000)] 
Define mem macro in control_test.c

8 years agoFormatting
Arran Cudbard-Bell [Sat, 18 Nov 2017 13:03:13 +0000 (13:03 +0000)] 
Formatting

8 years agoMove MEM to debug.h so we can use it in utilities
Arran Cudbard-Bell [Fri, 17 Nov 2017 23:39:38 +0000 (23:39 +0000)] 
Move MEM to debug.h so we can use it in utilities

8 years agoUse EXIT_FAILURE for portability
Arran Cudbard-Bell [Fri, 17 Nov 2017 23:39:22 +0000 (23:39 +0000)] 
Use EXIT_FAILURE for portability

Apparently not all systems use 1 to indicate failure.  C99 says "Finally, control is returned to the host environment. If the value of status is zero or EXIT_SUCCESS, an implementation-defined form of the status successful termination is returned. If the value of status is EXIT_FAILURE, an implementation-defined form of the status unsuccessful termination is returned. Otherwise the status returned is implementation-defined."

8 years agoMemory allocation check
Arran Cudbard-Bell [Fri, 17 Nov 2017 23:31:47 +0000 (23:31 +0000)] 
Memory allocation check

8 years agoMemory allocation check, and call fr_exit_now not _exit
Arran Cudbard-Bell [Fri, 17 Nov 2017 23:31:30 +0000 (23:31 +0000)] 
Memory allocation check, and call fr_exit_now not _exit

So we know where we exited...