]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
13 months agoAlways set repeatable if we have a repeat function
Arran Cudbard-Bell [Fri, 6 Jun 2025 06:04:53 +0000 (00:04 -0600)] 
Always set repeatable if we have a repeat function

This means the start function will run as the stack is burned down

13 months agoDon't check for operation failures in ldap_check_userobj_resume
Arran Cudbard-Bell [Fri, 6 Jun 2025 06:04:23 +0000 (00:04 -0600)] 
Don't check for operation failures in ldap_check_userobj_resume

13 months agoPrint list of attributes we're retrieving
Arran Cudbard-Bell [Fri, 6 Jun 2025 06:03:54 +0000 (00:03 -0600)] 
Print list of attributes we're retrieving

13 months agoUse correct field in map ctx
Arran Cudbard-Bell [Fri, 6 Jun 2025 06:02:34 +0000 (00:02 -0600)] 
Use correct field in map ctx

13 months agoDon't do exclusivity check if we're checking the config
Arran Cudbard-Bell [Fri, 6 Jun 2025 06:02:18 +0000 (00:02 -0600)] 
Don't do exclusivity check if we're checking the config

13 months agoOutput what group attribute we looked for
Arran Cudbard-Bell [Thu, 5 Jun 2025 17:14:22 +0000 (11:14 -0600)] 
Output what group attribute we looked for

13 months agoMake the query available immediately after resumption
Arran Cudbard-Bell [Thu, 5 Jun 2025 17:14:07 +0000 (11:14 -0600)] 
Make the query available immediately after resumption

13 months agoShouldn't default to returning ok in mod_authorize_resume
Arran Cudbard-Bell [Thu, 5 Jun 2025 17:13:47 +0000 (11:13 -0600)] 
Shouldn't default to returning ok in mod_authorize_resume

13 months agoAdd debugging functions to dump LDAP messages
Arran Cudbard-Bell [Thu, 5 Jun 2025 17:13:26 +0000 (11:13 -0600)] 
Add debugging functions to dump LDAP messages

13 months agoAdd sbuff array concat function
Arran Cudbard-Bell [Thu, 5 Jun 2025 17:12:48 +0000 (11:12 -0600)] 
Add sbuff array concat function

13 months agotmp;s failing should unwind the current frame
Arran Cudbard-Bell [Thu, 5 Jun 2025 04:02:07 +0000 (22:02 -0600)] 
tmp;s failing should unwind the current frame

regexes should return fail if they can't find a group

13 months agoAdd the ability to print instruction priorities to stack_dump
Arran Cudbard-Bell [Thu, 5 Jun 2025 03:59:37 +0000 (21:59 -0600)] 
Add the ability to print instruction priorities to stack_dump

13 months agoExplicitly check for failure
Arran Cudbard-Bell [Thu, 5 Jun 2025 02:23:06 +0000 (20:23 -0600)] 
Explicitly check for failure

13 months agoadd rctx into user_modify_resume if we're calling it directly
Arran Cudbard-Bell [Mon, 2 Jun 2025 05:25:00 +0000 (23:25 -0600)] 
add rctx into user_modify_resume if we're calling it directly

13 months agoUse correct check for ldap_initialize success
Arran Cudbard-Bell [Mon, 2 Jun 2025 05:20:29 +0000 (23:20 -0600)] 
Use correct check for ldap_initialize success

13 months agoDuplicate a bunch of code in unlang/function.c *sigh* and allow it to work when the...
Arran Cudbard-Bell [Mon, 2 Jun 2025 05:12:54 +0000 (23:12 -0600)] 
Duplicate a bunch of code in unlang/function.c *sigh* and allow it to work when the function yields

13 months agoAssert _before_ allowing talloc_get_type_abort to trip
Arran Cudbard-Bell [Mon, 2 Jun 2025 05:12:07 +0000 (23:12 -0600)] 
Assert _before_ allowing talloc_get_type_abort to trip

13 months agoFix order of yield and search in LDAP mod_modify
Arran Cudbard-Bell [Mon, 2 Jun 2025 05:11:45 +0000 (23:11 -0600)] 
Fix order of yield and search in  LDAP mod_modify

13 months agoLDAP_OPT_X_TLS_PROTOCOL_TLS1_3 not available in every libldap...
Arran Cudbard-Bell [Mon, 2 Jun 2025 05:06:05 +0000 (23:06 -0600)] 
LDAP_OPT_X_TLS_PROTOCOL_TLS1_3 not available in every libldap...

13 months agoFix const
Arran Cudbard-Bell [Mon, 2 Jun 2025 03:33:30 +0000 (21:33 -0600)] 
Fix const

13 months agoFix minor issue in rlm_lua
Arran Cudbard-Bell [Mon, 2 Jun 2025 03:25:45 +0000 (21:25 -0600)] 
Fix minor issue in rlm_lua

13 months agop_result may be NULL
Arran Cudbard-Bell [Mon, 2 Jun 2025 03:25:25 +0000 (21:25 -0600)] 
p_result may be NULL

13 months agoAdd variant of functions which do not produce a result
Arran Cudbard-Bell [Mon, 2 Jun 2025 02:30:30 +0000 (20:30 -0600)] 
Add variant of functions which do not produce a result

13 months agoCan't use stack variables for p_result
Arran Cudbard-Bell [Sun, 1 Jun 2025 21:22:13 +0000 (15:22 -0600)] 
Can't use stack variables for p_result

13 months agoOnly resolve priorities if the rcode is actually set
Arran Cudbard-Bell [Sun, 1 Jun 2025 21:21:53 +0000 (15:21 -0600)] 
Only resolve priorities if the rcode is actually set

13 months agoFrames always have an instruction
Arran Cudbard-Bell [Sun, 1 Jun 2025 20:25:34 +0000 (14:25 -0600)] 
Frames always have an instruction

13 months agoMore p_result fixes
Arran Cudbard-Bell [Sun, 1 Jun 2025 19:52:07 +0000 (13:52 -0600)] 
More p_result fixes

13 months agoAllow p_result to be set for rlm_ldap_find_user_async
Arran Cudbard-Bell [Sun, 1 Jun 2025 18:33:58 +0000 (12:33 -0600)] 
Allow p_result to be set for rlm_ldap_find_user_async

13 months agoSwitch ldap modifications to using process functions
Arran Cudbard-Bell [Sun, 1 Jun 2025 18:20:12 +0000 (12:20 -0600)] 
Switch ldap modifications to using process functions

13 months agoAdd sanity check in unlang_module_yield
Arran Cudbard-Bell [Sun, 1 Jun 2025 18:12:24 +0000 (12:12 -0600)] 
Add sanity check in unlang_module_yield

Why?  Because if the yield is done _AFTER_ a function has been pushed onto the stack, we get undefined reuslts

13 months agoRun the ldap.authorize method as module methods, not functions
Arran Cudbard-Bell [Sun, 1 Jun 2025 17:52:41 +0000 (11:52 -0600)] 
Run the ldap.authorize method as module methods, not functions

13 months agoAudit more uses of unlang_function_push
Arran Cudbard-Bell [Sun, 1 Jun 2025 17:36:02 +0000 (11:36 -0600)] 
Audit more uses of unlang_function_push

13 months agoResults for call_env expansion are written to env_result
Arran Cudbard-Bell [Sun, 1 Jun 2025 17:08:05 +0000 (11:08 -0600)] 
Results for call_env expansion are written to env_result

13 months agoNotes on unlang_function_push calls in virtual servers
Arran Cudbard-Bell [Sun, 1 Jun 2025 17:05:02 +0000 (11:05 -0600)] 
Notes on unlang_function_push calls in virtual servers

13 months agoNothing seems to use the rcode result from ldap_trunk_query_results, so remove the...
Arran Cudbard-Bell [Sun, 1 Jun 2025 16:49:23 +0000 (10:49 -0600)] 
Nothing seems to use the rcode result from ldap_trunk_query_results, so remove the return codes as they're confusing

13 months agoReturn UNLANG_ACTION_FAIL from RETURN_UNLANG_FAIL
Arran Cudbard-Bell [Sun, 1 Jun 2025 16:44:39 +0000 (10:44 -0600)] 
Return UNLANG_ACTION_FAIL from RETURN_UNLANG_FAIL

13 months agoExplicitly store the result of edit get password operations
Arran Cudbard-Bell [Sun, 1 Jun 2025 16:28:06 +0000 (10:28 -0600)] 
Explicitly store the result of edit get password operations

13 months agoExplicitly store the result of bind operations in the calling frame in LDAP
Arran Cudbard-Bell [Sun, 1 Jun 2025 16:24:53 +0000 (10:24 -0600)] 
Explicitly store the result of bind operations in the calling frame in LDAP

13 months agoAdd note on using unlang_interpret_result to make unlang functions transparent
Arran Cudbard-Bell [Sun, 1 Jun 2025 16:08:48 +0000 (10:08 -0600)] 
Add note on using unlang_interpret_result to make unlang functions transparent

13 months agoMake the eap_virtual_server_resume function transparent in terms of rcodes
Arran Cudbard-Bell [Sun, 1 Jun 2025 16:04:41 +0000 (10:04 -0600)] 
Make the eap_virtual_server_resume function transparent in terms of rcodes

13 months agoHandshake resume function writes out results to eap_tls_session->state so we don...
Arran Cudbard-Bell [Sun, 1 Jun 2025 16:04:00 +0000 (10:04 -0600)] 
Handshake resume function writes out results to eap_tls_session->state so we don't need to pass through the rcode

13 months agoMake the logging destination resumption function transparent in terms of rcodes
Arran Cudbard-Bell [Sun, 1 Jun 2025 16:03:23 +0000 (10:03 -0600)] 
Make the logging destination resumption function transparent in terms of rcodes

13 months agoMake the result pointer for the current frame available
Arran Cudbard-Bell [Sun, 1 Jun 2025 16:02:43 +0000 (10:02 -0600)] 
Make the result pointer for the current frame available

13 months agos/unlang_interpret_result/unlang_interpret_rcode/
Arran Cudbard-Bell [Sun, 1 Jun 2025 16:01:58 +0000 (10:01 -0600)] 
s/unlang_interpret_result/unlang_interpret_rcode/

13 months agoWe discard the return codes from triggers because they're fully async
Arran Cudbard-Bell [Sun, 1 Jun 2025 15:45:44 +0000 (09:45 -0600)] 
We discard the return codes from triggers because they're fully async

13 months agoAdd better notes on sigmasks
Arran Cudbard-Bell [Sun, 1 Jun 2025 15:45:03 +0000 (09:45 -0600)] 
Add better notes on sigmasks

13 months agoCheck unlang_module_yield return code in ttls.c
Arran Cudbard-Bell [Sun, 1 Jun 2025 15:41:16 +0000 (09:41 -0600)] 
Check unlang_module_yield return code in ttls.c

13 months agoNotes on how subrequests are handled in peap.c
Arran Cudbard-Bell [Sun, 1 Jun 2025 15:39:32 +0000 (09:39 -0600)] 
Notes on how subrequests are handled in peap.c

13 months agopeap: Cancel child request's frames
Arran Cudbard-Bell [Sun, 1 Jun 2025 15:39:08 +0000 (09:39 -0600)] 
peap: Cancel child request's frames

13 months agoPass unlang_result_t to modules instead of rlm_rcode_t
Nick Porter [Tue, 17 Jun 2025 19:42:06 +0000 (20:42 +0100)] 
Pass unlang_result_t to modules instead of rlm_rcode_t

13 months agoPopulate this frame's result with the results of the resolutions
Arran Cudbard-Bell [Sun, 1 Jun 2025 02:34:41 +0000 (20:34 -0600)] 
Populate this frame's result with the results of the resolutions

13 months agoFix scan issues
Arran Cudbard-Bell [Sun, 1 Jun 2025 02:10:12 +0000 (20:10 -0600)] 
Fix scan issues

13 months agoUse a dummy instruction in frame[0]
Arran Cudbard-Bell [Sun, 1 Jun 2025 02:10:00 +0000 (20:10 -0600)] 
Use a dummy instruction in frame[0]

13 months agoAllow the rcode from virtual servers to be redirected
Arran Cudbard-Bell [Sun, 1 Jun 2025 01:42:18 +0000 (19:42 -0600)] 
Allow the rcode from virtual servers to be redirected

13 months agoMake discarding function rcodes official
Arran Cudbard-Bell [Sun, 1 Jun 2025 01:42:01 +0000 (19:42 -0600)] 
Make discarding function rcodes official

13 months agoCheck we can find slapd
Arran Cudbard-Bell [Sun, 1 Jun 2025 01:40:48 +0000 (19:40 -0600)] 
Check we can find slapd

13 months agoFix arg order to unlang_subrequest_child_push
Arran Cudbard-Bell [Sun, 1 Jun 2025 01:40:29 +0000 (19:40 -0600)] 
Fix arg order to unlang_subrequest_child_push

13 months agoOnly assert if the child request is runnable
Arran Cudbard-Bell [Sun, 1 Jun 2025 01:39:41 +0000 (19:39 -0600)] 
Only assert if the child request is runnable

13 months agoSet priority of the process_reply function high enough to bubble up
Arran Cudbard-Bell [Sun, 1 Jun 2025 01:38:01 +0000 (19:38 -0600)] 
Set priority of the process_reply function high enough to bubble up

13 months agoHelp tracing the crazyness
Arran Cudbard-Bell [Sun, 1 Jun 2025 01:37:28 +0000 (19:37 -0600)] 
Help tracing the crazyness

13 months agoYielded makes more sense than resumable
Arran Cudbard-Bell [Sat, 31 May 2025 23:52:56 +0000 (17:52 -0600)] 
Yielded makes more sense than resumable

13 months agoEnsure that if the child hasn't completed, then its parent must be yielded if it...
Arran Cudbard-Bell [Sat, 31 May 2025 23:52:42 +0000 (17:52 -0600)] 
Ensure that if the child hasn't completed, then its parent must be yielded if it's signalled

13 months agoDon't crash on request timeout
Arran Cudbard-Bell [Sat, 31 May 2025 22:14:48 +0000 (16:14 -0600)] 
Don't crash on request timeout

13 months agoUse section result from rctx in eap_aka_sim state machine
Arran Cudbard-Bell [Sat, 31 May 2025 22:05:01 +0000 (16:05 -0600)] 
Use section result from rctx in eap_aka_sim state machine

13 months agoUse unlang_map_yield for LDAP maps
Arran Cudbard-Bell [Sat, 31 May 2025 21:08:59 +0000 (15:08 -0600)] 
Use unlang_map_yield for LDAP maps

13 months agoFix header include in dict.h
Arran Cudbard-Bell [Sat, 31 May 2025 19:26:42 +0000 (13:26 -0600)] 
Fix header include in dict.h

13 months agoRemove useless calls to unlang_function_push and just use unlang_module_yield
Arran Cudbard-Bell [Sat, 31 May 2025 19:26:30 +0000 (13:26 -0600)] 
Remove useless calls to unlang_function_push and just use unlang_module_yield

Adding new stack frames is expensive, and there's no need to do this as we can just mutate the module's frame

13 months agoAdd better support for async maps
Arran Cudbard-Bell [Sat, 31 May 2025 19:25:12 +0000 (13:25 -0600)] 
Add better support for async maps

We really don't want to push additional frames if we can help it

13 months agoNo reason to use a function to represent module state when processing accounting...
Arran Cudbard-Bell [Mon, 19 May 2025 04:19:11 +0000 (22:19 -0600)] 
No reason to use a function to represent module state when processing accounting queries

13 months agoReduce stack dumpage
Arran Cudbard-Bell [Mon, 19 May 2025 03:28:21 +0000 (21:28 -0600)] 
Reduce stack dumpage

13 months agoNo need to use functions to resume in the rlm_files module
Arran Cudbard-Bell [Mon, 19 May 2025 03:28:09 +0000 (21:28 -0600)] 
No need to use functions to resume in the rlm_files module

13 months agotry-no-sibling test needs to set the rcode back to ok
Arran Cudbard-Bell [Sun, 18 May 2025 21:16:52 +0000 (15:16 -0600)] 
try-no-sibling test needs to set the rcode back to ok

13 months agoNow that rcode works correctly, having OR or AND fail when their children fail causes...
Arran Cudbard-Bell [Sun, 18 May 2025 21:16:35 +0000 (15:16 -0600)] 
Now that rcode works correctly, having OR or AND fail when their children fail causes tests to fail

13 months agoHave xlat push functions take a result_p
Arran Cudbard-Bell [Sun, 18 May 2025 21:16:05 +0000 (15:16 -0600)] 
Have xlat push functions take a result_p

13 months agoPrint what's being expanded in stack_dump
Arran Cudbard-Bell [Sun, 18 May 2025 19:30:49 +0000 (13:30 -0600)] 
Print what's being expanded in stack_dump

13 months agoTransactions need to operate on the result of the child section, not the current...
Arran Cudbard-Bell [Sun, 18 May 2025 02:10:08 +0000 (20:10 -0600)] 
Transactions need to operate on the result of the child section, not the current frame result

13 months agoRework interpreter to make handling of rcodes sane, and to discard rcodes entirely...
Arran Cudbard-Bell [Sun, 18 May 2025 00:51:48 +0000 (18:51 -0600)] 
Rework interpreter to make handling of rcodes sane, and to discard rcodes entirely when a frame is popped

13 months agoUse common function to print closing section debug
Arran Cudbard-Bell [Sun, 18 May 2025 00:51:25 +0000 (18:51 -0600)] 
Use common function to print closing section debug

13 months agoCorrect calculation of overall result for parallel keyword
Arran Cudbard-Bell [Sun, 18 May 2025 00:49:54 +0000 (18:49 -0600)] 
Correct calculation of overall result for parallel keyword

13 months agoLook in the correct place for transaction results
Arran Cudbard-Bell [Sun, 18 May 2025 00:49:28 +0000 (18:49 -0600)] 
Look in the correct place for transaction results

13 months agoFix auto-added headers
Arran Cudbard-Bell [Sun, 18 May 2025 00:48:37 +0000 (18:48 -0600)] 
Fix auto-added headers

13 months agoUse new rcode location in catch
Arran Cudbard-Bell [Sun, 18 May 2025 00:06:35 +0000 (18:06 -0600)] 
Use new rcode location in catch

13 months agoNot finding a capture group should not be fail, it's just a NULL result
Arran Cudbard-Bell [Sun, 18 May 2025 00:06:17 +0000 (18:06 -0600)] 
Not finding a capture group should not be fail, it's just a NULL result

13 months agoGlobal timeout is the only thing that produces a timeout rcode outside of a module now
Arran Cudbard-Bell [Sun, 18 May 2025 00:05:54 +0000 (18:05 -0600)] 
Global timeout is the only thing that produces a timeout rcode outside of a module now

13 months agoRemove RETURN_MODULE_TRANSPARENT
Arran Cudbard-Bell [Sun, 18 May 2025 00:05:10 +0000 (18:05 -0600)] 
Remove RETURN_MODULE_TRANSPARENT

13 months agoDon't overwrite frame state in dhcpv6 state machine
Arran Cudbard-Bell [Sun, 18 May 2025 00:04:49 +0000 (18:04 -0600)] 
Don't overwrite frame state in dhcpv6 state machine

13 months agoDiscard rcodes from finally
Arran Cudbard-Bell [Sun, 18 May 2025 00:04:22 +0000 (18:04 -0600)] 
Discard rcodes from finally

13 months agoDon't include ourselves...
Arran Cudbard-Bell [Wed, 14 May 2025 23:55:05 +0000 (17:55 -0600)] 
Don't include ourselves...

13 months agoSwitch to using unlang_result_t for process functions, and unlang functions
Arran Cudbard-Bell [Wed, 14 May 2025 22:32:35 +0000 (16:32 -0600)] 
Switch to using unlang_result_t for process functions, and unlang functions

13 months agoAdd macros to populate unlang_result_t
Arran Cudbard-Bell [Wed, 14 May 2025 19:43:31 +0000 (13:43 -0600)] 
Add macros to populate unlang_result_t

13 months agoRework state machines so that they operate consistently with new result structure
Arran Cudbard-Bell [Wed, 14 May 2025 22:00:24 +0000 (16:00 -0600)] 
Rework state machines so that they operate consistently with new result structure

Fix pre-existing issue in DHCPv4 where the default section rcode for send sections would cause the packet type to switch to Do-Not-Response

Add unlang_result_t to hold both a priority and a rcode

13 months agoAllow modules to specify the size and type of the rctx to allocate
Arran Cudbard-Bell [Mon, 12 May 2025 20:10:55 +0000 (14:10 -0600)] 
Allow modules to specify the size and type of the rctx to allocate

This mostly saves on boilerplate at the top of every module call.

13 months agoPass arguments to push functions in a structure
Arran Cudbard-Bell [Sun, 11 May 2025 21:34:28 +0000 (15:34 -0600)] 
Pass arguments to push functions in a structure

Makes it easier to add or remove args

13 months agoWe don't return yield anymore
Arran Cudbard-Bell [Sun, 11 May 2025 21:31:37 +0000 (15:31 -0600)] 
We don't return yield anymore

13 months agoStart simplifying rcode handling
Arran Cudbard-Bell [Sat, 10 May 2025 19:57:34 +0000 (13:57 -0600)] 
Start simplifying rcode handling

13 months agoUse proper type for the rcode priority
Arran Cudbard-Bell [Sat, 10 May 2025 01:01:42 +0000 (19:01 -0600)] 
Use proper type for the rcode priority

13 months agoMinor interpreter cleanups
Arran Cudbard-Bell [Sat, 10 May 2025 00:25:04 +0000 (18:25 -0600)] 
Minor interpreter cleanups

13 months agoNo customers here...
Arran Cudbard-Bell [Fri, 9 May 2025 21:34:03 +0000 (15:34 -0600)] 
No customers here...

13 months agoMake the delay module transparent for rcodes
Arran Cudbard-Bell [Fri, 9 May 2025 21:33:51 +0000 (15:33 -0600)] 
Make the delay module transparent for rcodes

13 months agothere is no 6th expansion, so we don't expand it
Alan T. DeKok [Tue, 17 Jun 2025 17:58:05 +0000 (13:58 -0400)] 
there is no 6th expansion, so we don't expand it