]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoif retries are 1, timeout is IRT, not MRD
Alan T. DeKok [Thu, 23 May 2024 11:46:04 +0000 (07:46 -0400)] 
if retries are 1, timeout is IRT, not MRD

2 years agomove to struct initialization
Alan T. DeKok [Thu, 23 May 2024 11:45:43 +0000 (07:45 -0400)] 
move to struct initialization

to ensure that all fields are initialized

2 years agoAdd missing quotes
Tim van Dijen [Tue, 28 May 2024 14:51:31 +0000 (16:51 +0200)] 
Add missing quotes

2 years agoAdd str.printable to check if a string only consists of printable i.e. non-whitespace...
Arran Cudbard-Bell [Mon, 27 May 2024 23:23:24 +0000 (19:23 -0400)] 
Add str.printable to check if a string only consists of printable i.e. non-whitespace, non-control chars, and valid utf8 sequences

2 years agoReduce iterations
Arran Cudbard-Bell [Mon, 27 May 2024 21:35:55 +0000 (17:35 -0400)] 
Reduce iterations

2 years agoAdd str.uf8 validation function
Arran Cudbard-Bell [Mon, 27 May 2024 15:35:06 +0000 (11:35 -0400)] 
Add str.uf8 validation function

2 years agoSort module methods to ensure a consistent order
Arran Cudbard-Bell [Mon, 27 May 2024 03:38:35 +0000 (23:38 -0400)] 
Sort module methods to ensure a consistent order

2 years agoReference count dl modules from 1
Arran Cudbard-Bell [Mon, 27 May 2024 03:04:11 +0000 (23:04 -0400)] 
Reference count dl modules from 1

2 years agoDefine a common section name struct, and use pointers to those structs
Arran Cudbard-Bell [Sun, 26 May 2024 03:07:38 +0000 (23:07 -0400)] 
Define a common section name struct, and use pointers to those structs

Will allow slightly faster comparisons in some cases, and allow common module method names to be defined

2 years agoFix include
Arran Cudbard-Bell [Sun, 26 May 2024 01:43:58 +0000 (21:43 -0400)] 
Fix include

2 years agoNeed syserror in dependency.c
Arran Cudbard-Bell [Sat, 25 May 2024 11:57:41 +0000 (07:57 -0400)] 
Need syserror in dependency.c

2 years agoBase more operations around virtual_server_t
Arran Cudbard-Bell [Sat, 25 May 2024 03:06:25 +0000 (23:06 -0400)] 
Base more operations around virtual_server_t

2 years agoRegister sections to compile against individual virtual_server_t structs
Arran Cudbard-Bell [Sat, 25 May 2024 02:19:27 +0000 (22:19 -0400)] 
Register sections to compile against individual virtual_server_t structs

2 years agoRename cf_debug to cf_item_debug
Arran Cudbard-Bell [Sat, 25 May 2024 02:03:50 +0000 (22:03 -0400)] 
Rename cf_debug to cf_item_debug

2 years agoRemove server/base.h from some source files
Arran Cudbard-Bell [Sat, 25 May 2024 02:03:13 +0000 (22:03 -0400)] 
Remove server/base.h from some source files

2 years agoFixup parent search functions to take CONF_ITEMs not just CONF_SECTIONs
Arran Cudbard-Bell [Fri, 24 May 2024 22:51:42 +0000 (18:51 -0400)] 
Fixup parent search functions to take CONF_ITEMs not just CONF_SECTIONs

2 years agoRemove the last of the XLAT_MONO code
Arran Cudbard-Bell [Fri, 24 May 2024 16:13:22 +0000 (12:13 -0400)] 
Remove the last of the XLAT_MONO code

Looks like this enables some purification that wasn't happening previously.  The parts of tests removed were either useless, or the tests were incorrect.

2 years agoReinstate default begin and commit queries
Nick Porter [Fri, 24 May 2024 10:56:44 +0000 (11:56 +0100)] 
Reinstate default begin and commit queries

2 years agoMark src dirctory safe for crossbuild
Nick Porter [Fri, 24 May 2024 10:19:08 +0000 (11:19 +0100)] 
Mark src dirctory safe for crossbuild

2 years agoWhen ldap sync callback returns < 0, avoid path that frees msg
Nick Porter [Thu, 23 May 2024 17:17:23 +0000 (18:17 +0100)] 
When ldap sync callback returns < 0, avoid path that frees msg

The callback has already freed the msg

2 years agoGive different response when cookie is being ignored
Nick Porter [Thu, 23 May 2024 17:14:28 +0000 (18:14 +0100)] 
Give different response when cookie is being ignored

So we don't also give the "Missing cookie" error

2 years agoimplement callback for "no reply to sent packet"
Alan T. DeKok [Thu, 23 May 2024 02:03:11 +0000 (22:03 -0400)] 
implement callback for "no reply to sent packet"

along with various other cleanups to make it work better.

2 years agoadd retry && release callbacks for packet bio
Alan T. DeKok [Wed, 22 May 2024 18:50:31 +0000 (14:50 -0400)] 
add retry && release callbacks for packet bio

so that the application can do something (e.g. print stuff)
on retry.  And then clean up the packet on release.

It's partially glued into radclint-ng, via the simple expedient
of having an assert() on release.  Later code will add actual
cleanups

2 years agotypos and minor fixes
Alan T. DeKok [Wed, 22 May 2024 17:41:31 +0000 (13:41 -0400)] 
typos and minor fixes

2 years agoreset timer, and add some assertions
Alan T. DeKok [Wed, 22 May 2024 17:41:08 +0000 (13:41 -0400)] 
reset timer, and add some assertions

2 years agostart of updating Acct-Delay-Time
Alan T. DeKok [Wed, 22 May 2024 17:05:34 +0000 (13:05 -0400)] 
start of updating Acct-Delay-Time

2 years agoexpose the fr_retry_t, and add rewrite_ctx
Alan T. DeKok [Wed, 22 May 2024 14:49:09 +0000 (10:49 -0400)] 
expose the fr_retry_t, and add rewrite_ctx

2 years agoAdd test for 'zero' index in substr
Arran Cudbard-Bell [Wed, 22 May 2024 17:41:45 +0000 (13:41 -0400)] 
Add test for 'zero' index in substr

2 years agotrack sent / replied timers
Alan T. DeKok [Tue, 21 May 2024 19:23:38 +0000 (15:23 -0400)] 
track sent / replied timers

in preparation for adding application-layer watchdogs

2 years agohandle WOULD_BLOCK on connect()
Alan T. DeKok [Tue, 21 May 2024 18:12:29 +0000 (14:12 -0400)] 
handle WOULD_BLOCK on connect()

2 years agoglue in activate / shutdown to fd bio.
Alan T. DeKok [Mon, 20 May 2024 12:55:25 +0000 (08:55 -0400)] 
glue in activate / shutdown to fd bio.

call activate() when the socket is ready, i.e. when it's
connected.

call shutdown() when the socket is closed, in the destructor.

when fr_bio_shutdown() is called manually, it also mangles the
shutdown callback, so that the fd bio doesn't call it again in
its destructor.

2 years agoadd Proxy-State if requested
Alan T. DeKok [Sun, 19 May 2024 14:40:44 +0000 (10:40 -0400)] 
add Proxy-State if requested

2 years agohoist encode / sign to client bio
Alan T. DeKok [Fri, 17 May 2024 15:48:09 +0000 (11:48 -0400)] 
hoist encode / sign to client bio

which isn't much more code, but allows us to add functionality
from rlm_radius_udp

2 years agoRemove MONO functions for the majority of modules
Arran Cudbard-Bell [Mon, 20 May 2024 21:46:28 +0000 (17:46 -0400)] 
Remove MONO functions for the majority of modules

2 years agoCoverity 1598300 is a false positive. The array IS terminated correctly
Arran Cudbard-Bell [Mon, 20 May 2024 15:59:32 +0000 (11:59 -0400)] 
Coverity 1598300 is a false positive.  The array IS terminated correctly

We should likely just default to not allowing any arguments unless they're explicitly set.

This commit doesn't fix anything, it just removes the call to "xlat_func_mono_set" which we should be moving away from.

2 years agoStupid const
Arran Cudbard-Bell [Sun, 19 May 2024 17:22:57 +0000 (11:22 -0600)] 
Stupid const

2 years agoWords hard
Arran Cudbard-Bell [Sun, 19 May 2024 17:14:48 +0000 (11:14 -0600)] 
Words hard

2 years agoImprove the performance of `if ('rcode')` by doing the string to integer conversion...
Arran Cudbard-Bell [Sun, 19 May 2024 17:10:07 +0000 (11:10 -0600)] 
Improve the performance of `if ('rcode')` by doing the string to integer conversion, once, on startup

This also involves splitting the function into two, one that does the comparison, and one that can return the current rcode.

2 years agoOnly update request->rcode for a few unlang_ops
Arran Cudbard-Bell [Sun, 19 May 2024 01:10:52 +0000 (19:10 -0600)] 
Only update request->rcode for a few unlang_ops

2 years agos/set_rcode/rcode_set/
Arran Cudbard-Bell [Sun, 19 May 2024 01:09:32 +0000 (19:09 -0600)] 
s/set_rcode/rcode_set/

2 years agoRename resume function in call...
Arran Cudbard-Bell [Sun, 19 May 2024 01:08:49 +0000 (19:08 -0600)] 
Rename resume function in call...

2 years agoAdd unpredictable macro
Arran Cudbard-Bell [Sun, 19 May 2024 00:53:47 +0000 (18:53 -0600)] 
Add unpredictable macro

2 years agoQuiet coverity
Arran Cudbard-Bell [Fri, 17 May 2024 20:53:30 +0000 (14:53 -0600)] 
Quiet coverity

2 years agoMake DEBUG3 output less noisy
Nick Porter [Fri, 17 May 2024 17:21:21 +0000 (18:21 +0100)] 
Make DEBUG3 output less noisy

2 years agoDon't crash when we fail thread instantiation
Arran Cudbard-Bell [Fri, 17 May 2024 16:15:44 +0000 (10:15 -0600)] 
Don't crash when we fail thread instantiation

2 years agodefine enough things to shut up compiler
Alan T. DeKok [Fri, 17 May 2024 14:46:18 +0000 (10:46 -0400)] 
define enough things to shut up compiler

2 years agoadd read / write pause / resume debounce functions
Alan T. DeKok [Fri, 17 May 2024 14:27:29 +0000 (10:27 -0400)] 
add read / write pause / resume debounce functions

2 years agoundef const
Alan T. DeKok [Fri, 17 May 2024 14:26:51 +0000 (10:26 -0400)] 
undef const

2 years agoTypo
Arran Cudbard-Bell [Fri, 17 May 2024 14:30:28 +0000 (08:30 -0600)] 
Typo

2 years ago...and actually use the new enum
Arran Cudbard-Bell [Fri, 17 May 2024 14:29:36 +0000 (08:29 -0600)] 
...and actually use the new enum

2 years agoshhh compiler
Arran Cudbard-Bell [Fri, 17 May 2024 14:28:53 +0000 (08:28 -0600)] 
shhh compiler

2 years agoRemove components (MOD_AUTHORIZE, MOD_AUTHENTICATE, etc..) from the server
Arran Cudbard-Bell [Fri, 17 May 2024 00:21:32 +0000 (18:21 -0600)] 
Remove components (MOD_AUTHORIZE, MOD_AUTHENTICATE, etc..) from the server

We rely entirely on named methods now.

This breaks policy lookups, where the policy name is <policy>.<component>.  This needs to be fixed, by looking up <policy>[.<name1>][.<name2>].

2 years agos/name/name1/g
Arran Cudbard-Bell [Thu, 16 May 2024 22:48:01 +0000 (16:48 -0600)] 
s/name/name1/g

2 years agoSome minor tweaks to expose problems in rlm_rest
Arran Cudbard-Bell [Thu, 16 May 2024 22:00:28 +0000 (16:00 -0600)] 
Some minor tweaks to expose problems in rlm_rest

2 years agoPull in the dictionary header in module_method.h
Arran Cudbard-Bell [Thu, 16 May 2024 16:39:57 +0000 (10:39 -0600)] 
Pull in the dictionary header in module_method.h

2 years agoIt's fine to allocate pool data from the module_instance_t
Arran Cudbard-Bell [Thu, 16 May 2024 14:39:31 +0000 (08:39 -0600)] 
It's fine to allocate pool data from the module_instance_t

2 years agotypo
Alan T. DeKok [Thu, 16 May 2024 13:38:31 +0000 (09:38 -0400)] 
typo

2 years agomake cast const-qualified
Alan T. DeKok [Thu, 16 May 2024 13:29:18 +0000 (09:29 -0400)] 
make cast const-qualified

2 years agomove pasue / resume callbacks to client config structure
Alan T. DeKok [Thu, 16 May 2024 13:13:26 +0000 (09:13 -0400)] 
move pasue / resume callbacks to client config structure

2 years agoAllow '.' back in, for now
Arran Cudbard-Bell [Thu, 16 May 2024 05:54:24 +0000 (23:54 -0600)] 
Allow '.' back in, for now

2 years agoTypo
Arran Cudbard-Bell [Thu, 16 May 2024 05:40:59 +0000 (23:40 -0600)] 
Typo

2 years agoAdd allowed chars merge function
Arran Cudbard-Bell [Thu, 16 May 2024 05:18:38 +0000 (23:18 -0600)] 
Add allowed chars merge function

2 years agoMake module instance allowed chars available
Arran Cudbard-Bell [Thu, 16 May 2024 05:18:28 +0000 (23:18 -0600)] 
Make module instance allowed chars available

2 years agoUnconst the module instance
Arran Cudbard-Bell [Thu, 16 May 2024 05:17:56 +0000 (23:17 -0600)] 
Unconst the module instance

2 years agoPass in the module instance to the rlm_mschap connection function
Arran Cudbard-Bell [Wed, 15 May 2024 23:32:20 +0000 (17:32 -0600)] 
Pass in the module instance to the rlm_mschap connection function

2 years agoRestrict the acceptable char set for module names
Arran Cudbard-Bell [Wed, 15 May 2024 23:22:58 +0000 (17:22 -0600)] 
Restrict the acceptable char set for module names

2 years agoRemove more module-list specific lookup functions
Arran Cudbard-Bell [Wed, 15 May 2024 21:50:10 +0000 (15:50 -0600)] 
Remove more module-list specific lookup functions

rlm_sql_ippool and rlm_sql_counter won't work with dynamic modules... but that's OK, because the way they depend on other modules is stupid, and needs to be fixed anyway.

2 years agoRemove a call to module_rlm_by_name
Arran Cudbard-Bell [Wed, 15 May 2024 21:31:26 +0000 (15:31 -0600)] 
Remove a call to module_rlm_by_name

2 years agoRemove all the module_rlm_by_data lookup functions
Arran Cudbard-Bell [Wed, 15 May 2024 21:24:20 +0000 (15:24 -0600)] 
Remove all the module_rlm_by_data lookup functions

2 years agoUpdate links in the howto for EAP
Arran Cudbard-Bell [Wed, 15 May 2024 19:33:55 +0000 (13:33 -0600)] 
Update links in the howto for EAP

2 years agostats is now in inst->mutable
Nick Porter [Wed, 15 May 2024 19:38:22 +0000 (20:38 +0100)] 
stats is now in inst->mutable

2 years agoMore mutable data in stats
Arran Cudbard-Bell [Wed, 15 May 2024 16:57:17 +0000 (10:57 -0600)] 
More mutable data in stats

2 years agoDon't write to instance data in rlm_stats
Arran Cudbard-Bell [Wed, 15 May 2024 16:27:27 +0000 (10:27 -0600)] 
Don't write to instance data in rlm_stats

2 years agoadd and set write pause / resume callbacks
Alan T. DeKok [Wed, 15 May 2024 13:21:30 +0000 (09:21 -0400)] 
add and set write pause / resume callbacks

2 years agotypo
Alan T. DeKok [Wed, 15 May 2024 13:21:18 +0000 (09:21 -0400)] 
typo

2 years agomove fd_info to client_info structure
Alan T. DeKok [Wed, 15 May 2024 12:56:47 +0000 (08:56 -0400)] 
move fd_info to client_info structure

2 years agoadd framework for RADIUS client bio write blocked / resume callbacks
Alan T. DeKok [Tue, 14 May 2024 23:59:04 +0000 (19:59 -0400)] 
add framework for RADIUS client bio write blocked / resume callbacks

2 years agoWe need to resume iterating from the previous configuration item
Arran Cudbard-Bell [Wed, 15 May 2024 04:58:11 +0000 (22:58 -0600)] 
We need to resume iterating from the previous configuration item

2 years agoAdd dynamic module list
Arran Cudbard-Bell [Wed, 15 May 2024 04:27:32 +0000 (22:27 -0600)] 
Add dynamic module list

2 years agoAdd more cf boilerplate, and have cf_item_remove return the previous item to make...
Arran Cudbard-Bell [Wed, 15 May 2024 03:55:35 +0000 (21:55 -0600)] 
Add more cf boilerplate, and have cf_item_remove return the previous item to make iterating easier

2 years agoMove packet global free to the atexit handlers
Arran Cudbard-Bell [Wed, 15 May 2024 01:59:50 +0000 (19:59 -0600)] 
Move packet global free to the atexit handlers

2 years agoMove trigger free to the atexit handlers
Arran Cudbard-Bell [Wed, 15 May 2024 01:52:11 +0000 (19:52 -0600)] 
Move trigger free to the atexit handlers

2 years agoMove password free to the atexit handlers
Arran Cudbard-Bell [Wed, 15 May 2024 01:46:13 +0000 (19:46 -0600)] 
Move password free to the atexit handlers

2 years agoMove tmpl free to the atexit handlers
Arran Cudbard-Bell [Wed, 15 May 2024 01:45:58 +0000 (19:45 -0600)] 
Move tmpl free to the atexit handlers

2 years agoAuto unload SNMP attributes
Arran Cudbard-Bell [Wed, 15 May 2024 01:25:52 +0000 (19:25 -0600)] 
Auto unload SNMP attributes

2 years agoPrint the addresses mprotect actually protects
Arran Cudbard-Bell [Wed, 15 May 2024 00:37:32 +0000 (18:37 -0600)] 
Print the addresses mprotect actually protects

2 years agoThis could equal to the length of the pool
Arran Cudbard-Bell [Wed, 15 May 2024 00:36:15 +0000 (18:36 -0600)] 
This could equal to the length of the pool

2 years agoFix mprotect to it hands back the correct end address
Arran Cudbard-Bell [Wed, 15 May 2024 00:10:24 +0000 (18:10 -0600)] 
Fix mprotect to it hands back the correct end address

2 years agohandle the case of write blocked due to all IDs being used.
Alan T. DeKok [Tue, 14 May 2024 23:41:59 +0000 (19:41 -0400)] 
handle the case of write blocked due to all IDs being used.

The next few commits should add and use the various callback
functions to actually handle write blocked / resume

2 years agochange function prototype to make more sense
Alan T. DeKok [Tue, 14 May 2024 23:41:15 +0000 (19:41 -0400)] 
change function prototype to make more sense

2 years agomissed in previous commit
Alan T. DeKok [Tue, 14 May 2024 23:41:02 +0000 (19:41 -0400)] 
missed in previous commit

2 years agocleanups for coverity complaints about unused code
Alan T. DeKok [Tue, 14 May 2024 21:15:06 +0000 (17:15 -0400)] 
cleanups for coverity complaints about unused code

2 years agouse better function signatures for read / write pause / resume
Alan T. DeKok [Tue, 14 May 2024 21:06:44 +0000 (17:06 -0400)] 
use better function signatures for read / write pause / resume

2 years agoremove callbacks from fd_alloc()
Alan T. DeKok [Tue, 14 May 2024 20:46:33 +0000 (16:46 -0400)] 
remove callbacks from fd_alloc()

the caller can set it themselves, and it looks like every bio
may need to set the callbacks

and move the "set callback" code to a common bio function.

It's a bit more work for the caller when it's needed, but it's
much less work when it's not needed.

2 years agoadd read blocked / resume callbacks
Alan T. DeKok [Tue, 14 May 2024 18:58:47 +0000 (14:58 -0400)] 
add read blocked / resume callbacks

2 years agoadd callbacks for read/write blocked, and read/write resume
Alan T. DeKok [Tue, 14 May 2024 18:36:07 +0000 (14:36 -0400)] 
add callbacks for read/write blocked, and read/write resume

for now, only write blocked/resume is plumbed in.

2 years agoEnable write protection on a per-module list basis
Arran Cudbard-Bell [Tue, 14 May 2024 14:57:47 +0000 (08:57 -0600)] 
Enable write protection on a per-module list basis

2 years agoTemporary fix
Arran Cudbard-Bell [Tue, 14 May 2024 04:13:34 +0000 (22:13 -0600)] 
Temporary fix

2 years agoExplicitly free the listener in the socket destructor
Arran Cudbard-Bell [Tue, 14 May 2024 03:48:53 +0000 (21:48 -0600)] 
Explicitly free the listener in the socket destructor

2 years agoUse talloc get type abort for safety...
Arran Cudbard-Bell [Tue, 14 May 2024 02:40:24 +0000 (20:40 -0600)] 
Use talloc get type abort for safety...