]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoUpdate URLs: http:// → https://
Dimitri Papadopoulos [Mon, 25 Dec 2023 14:41:04 +0000 (15:41 +0100)] 
Update URLs: http:// → https://

2 years agoAttempt to keep coverity from being silly (CID #1551707)
James Jones [Tue, 23 Jan 2024 17:21:44 +0000 (11:21 -0600)] 
Attempt to keep coverity from being silly (CID #1551707)

For some unknown reason, Coverity skips the declaration of subst in
fr_vasprintf_internal()...and said declaration initializes it, so
that later, when substr is used, Coverity complains that subst is
not initialized!

To try to avoid this; we move the declaration of subst out of the
do {} while () loop it was in, to the outer block of the function
body, and then just assign to it in the loop.

2 years agoupdate Radius dictionary form Extreme Networks
Markus Nikulski [Thu, 25 Jan 2024 11:12:41 +0000 (12:12 +0100)] 
update Radius dictionary form Extreme Networks

extend the dictionary with the current status of Extreme Networks

2 years agoadd foreign encoders for RADIUS
Alan T. DeKok [Thu, 25 Jan 2024 17:03:37 +0000 (12:03 -0500)] 
add foreign encoders for RADIUS

2 years agoadd encode / decode callbacks for dictionaries
Alan T. DeKok [Thu, 25 Jan 2024 16:49:40 +0000 (11:49 -0500)] 
add encode / decode callbacks for dictionaries

with forward definitions for fr_pair_list_t, and fr_dbuff_t,
so that we don't have circular references

2 years agoadd radclient-ng, and allow it to be used in tests
Alan T. DeKok [Thu, 25 Jan 2024 14:14:17 +0000 (09:14 -0500)] 
add radclient-ng, and allow it to be used in tests

but install it to a build directory, so that it doesn't muck up
the packages

2 years agomove client programs to new API
Alan T. DeKok [Thu, 25 Jan 2024 14:06:53 +0000 (09:06 -0500)] 
move client programs to new API

We're gradually getting rid of the fr_radius_packet_foo() APIs.
They're essentially tiny wrappers around the fr_radius_foo()
functions, and they make it more difficult to switch to using
bios.

2 years agouse better names
Alan T. DeKok [Thu, 25 Jan 2024 14:00:39 +0000 (09:00 -0500)] 
use better names

2 years agotypo
Alan T. DeKok [Thu, 25 Jan 2024 13:33:04 +0000 (08:33 -0500)] 
typo

2 years agoensure that decode_ctx->request_authenticator is initialized
Alan T. DeKok [Thu, 25 Jan 2024 13:31:44 +0000 (08:31 -0500)] 
ensure that decode_ctx->request_authenticator is initialized

2 years agothe expected result should be listed first
Alan T. DeKok [Thu, 25 Jan 2024 13:29:23 +0000 (08:29 -0500)] 
the expected result should be listed first

2 years agohoist reply checks to core code
Alan T. DeKok [Thu, 25 Jan 2024 13:21:45 +0000 (08:21 -0500)] 
hoist reply checks to core code

2 years agoAdd libfreeradius-bio.so to Debian packaging
Nick Porter [Thu, 25 Jan 2024 13:17:21 +0000 (13:17 +0000)] 
Add libfreeradius-bio.so to Debian packaging

2 years agoremove erroneous assert. should help with #5276
Alan T. DeKok [Thu, 25 Jan 2024 08:49:47 +0000 (03:49 -0500)] 
remove erroneous assert.  should help with #5276

The code for NAK later assumes that there is a connection, so the
assert is wrong

2 years agouse length from struct instead of talloc_array_length
Alan T. DeKok [Thu, 25 Jan 2024 01:33:59 +0000 (20:33 -0500)] 
use length from struct instead of talloc_array_length

2 years agostart removing duplicate APIs
Alan T. DeKok [Thu, 25 Jan 2024 01:18:15 +0000 (20:18 -0500)] 
start removing duplicate APIs

2 years agomove to using request_authenticator for encode, too
Alan T. DeKok [Thu, 25 Jan 2024 01:12:48 +0000 (20:12 -0500)] 
move to using request_authenticator for encode, too

2 years agomove to using decode_ctx for public APIs, v2
Alan T. DeKok [Thu, 25 Jan 2024 01:04:19 +0000 (20:04 -0500)] 
move to using decode_ctx for public APIs, v2

2 years agotypo
Alan T. DeKok [Thu, 25 Jan 2024 00:51:27 +0000 (19:51 -0500)] 
typo

2 years agoRevert "move to using decode_ctx for public APIs."
Alan T. DeKok [Thu, 25 Jan 2024 00:16:51 +0000 (19:16 -0500)] 
Revert "move to using decode_ctx for public APIs."

This reverts commit 6bcda326683aea8b877a4c6e2f5fb4dff6eb0871.

2 years agoinitialize rcode
Alan T. DeKok [Thu, 25 Jan 2024 00:07:54 +0000 (19:07 -0500)] 
initialize rcode

2 years agoRename ldap escape and unescape xlats...
Arran Cudbard-Bell [Wed, 24 Jan 2024 23:09:44 +0000 (17:09 -0600)] 
Rename ldap escape and unescape xlats...

2 years agoMerge ERX/Unisphere, nuke ERX
Arran Cudbard-Bell [Wed, 24 Jan 2024 22:41:31 +0000 (16:41 -0600)] 
Merge ERX/Unisphere, nuke ERX

2 years agoclean up duplicate APIs
Alan T. DeKok [Wed, 24 Jan 2024 21:11:01 +0000 (16:11 -0500)] 
clean up duplicate APIs

2 years agomove to using decode_ctx for public APIs.
Alan T. DeKok [Wed, 24 Jan 2024 17:25:52 +0000 (12:25 -0500)] 
move to using decode_ctx for public APIs.

2 years agowhitespace
Alan T. DeKok [Wed, 24 Jan 2024 18:16:19 +0000 (13:16 -0500)] 
whitespace

2 years agoremove unnecessary "break"
Alan T. DeKok [Wed, 24 Jan 2024 18:13:46 +0000 (13:13 -0500)] 
remove unnecessary "break"

2 years agoadd basic test for proxying
Alan T. DeKok [Wed, 24 Jan 2024 15:48:48 +0000 (10:48 -0500)] 
add basic test for proxying

and ensure we re-run the tests when the handlers change

2 years agoAdd test for [*] filter in files comparison
Nick Porter [Wed, 24 Jan 2024 19:36:49 +0000 (19:36 +0000)] 
Add test for [*] filter in files comparison

2 years agoUse tmpl_dcursor in radius_lecacy_map_cmp
Nick Porter [Wed, 24 Jan 2024 19:25:42 +0000 (19:25 +0000)] 
Use tmpl_dcursor in radius_lecacy_map_cmp

Allows for the lhs to use the [*] filter

2 years agobind to unix sockets correctly for ACCEPT
Alan T. DeKok [Wed, 24 Jan 2024 15:27:12 +0000 (10:27 -0500)] 
bind to unix sockets correctly for ACCEPT

2 years agomore sanity checks so that files are only connected bios
Alan T. DeKok [Wed, 24 Jan 2024 14:13:09 +0000 (09:13 -0500)] 
more sanity checks so that files are only connected bios

2 years agomove to run-time error instead of build error
Alan T. DeKok [Wed, 24 Jan 2024 14:11:36 +0000 (09:11 -0500)] 
move to run-time error instead of build error

FreeBSD has IP_RECVIF, not SO_BINDTODEVICE.  And IP_RECVIF only
works for datagram sockets, and has to be used with recvmsg()

So until we get that code working, just disallow binding to an
interface.

2 years agopass original vector to verify / sign
Alan T. DeKok [Wed, 24 Jan 2024 13:31:44 +0000 (08:31 -0500)] 
pass original vector to verify / sign

instead of the complete packet.  This makes later changes easier

2 years ago.diff files can have trailing whitespace
Nick Porter [Wed, 24 Jan 2024 13:42:30 +0000 (13:42 +0000)] 
.diff files can have trailing whitespace

2 years agoFix debian packaging patch file
Nick Porter [Wed, 24 Jan 2024 13:09:48 +0000 (13:09 +0000)] 
Fix debian packaging patch file

2 years agows
Nick Porter [Wed, 24 Jan 2024 12:17:04 +0000 (12:17 +0000)] 
ws

2 years agoInitialise the correct member
Nick Porter [Wed, 24 Jan 2024 12:16:54 +0000 (12:16 +0000)] 
Initialise the correct member

2 years agoQuiet compiler warning
Arran Cudbard-Bell [Wed, 24 Jan 2024 00:58:12 +0000 (18:58 -0600)] 
Quiet compiler warning

2 years agoAllow the OID of a pair to be printed
Arran Cudbard-Bell [Wed, 24 Jan 2024 00:50:31 +0000 (18:50 -0600)] 
Allow the OID of a pair to be printed

2 years agoUse better type to hash/trie/rb mappings
Arran Cudbard-Bell [Tue, 23 Jan 2024 22:53:07 +0000 (16:53 -0600)] 
Use better type to hash/trie/rb mappings

2 years agoFix integer (and other) comparisons for switch
Arran Cudbard-Bell [Tue, 23 Jan 2024 22:35:43 +0000 (16:35 -0600)] 
Fix integer (and other) comparisons for switch

2 years agoaddress coverity issues
Alan T. DeKok [Tue, 23 Jan 2024 21:32:38 +0000 (16:32 -0500)] 
address coverity issues

2 years agoallow domain sockets to be opened as root
Alan T. DeKok [Tue, 23 Jan 2024 19:30:00 +0000 (14:30 -0500)] 
allow domain sockets to be opened as root

which is likely imperfect, but whatever

2 years agoremove old / unused commented-out config items
Alan T. DeKok [Tue, 23 Jan 2024 19:27:47 +0000 (14:27 -0500)] 
remove old / unused commented-out config items

2 years agomake reply checks more stringent
Alan T. DeKok [Tue, 23 Jan 2024 19:23:41 +0000 (14:23 -0500)] 
make reply checks more stringent

2 years agoremove unused macro
Alan T. DeKok [Tue, 23 Jan 2024 19:21:04 +0000 (14:21 -0500)] 
remove unused macro

2 years agomove to using bios for at least part of the control socket
Alan T. DeKok [Tue, 23 Jan 2024 18:55:55 +0000 (13:55 -0500)] 
move to using bios for at least part of the control socket

2 years agoRemove setting of Message-Success-Message from sqlippool
Nick Porter [Tue, 23 Jan 2024 17:05:09 +0000 (17:05 +0000)] 
Remove setting of Message-Success-Message from sqlippool

Equivalent functionality can be done by observing the module return code
and use of xlats.

2 years agouse new defs
Alan T. DeKok [Tue, 23 Jan 2024 17:04:53 +0000 (12:04 -0500)] 
use new defs

2 years agosplit encode / decode context into two different fields
Alan T. DeKok [Tue, 23 Jan 2024 16:22:55 +0000 (11:22 -0500)] 
split encode / decode context into two different fields

and add a common context with secret, etc.

2 years agoallow opening /dev/stdout and /dev/stderr
Alan T. DeKok [Tue, 23 Jan 2024 14:19:40 +0000 (09:19 -0500)] 
allow opening /dev/stdout and /dev/stderr

2 years agoLinux has AF_FILE==AF_LOCAL
Alan T. DeKok [Tue, 23 Jan 2024 13:59:17 +0000 (08:59 -0500)] 
Linux has AF_FILE==AF_LOCAL

so use our own AF_FILE_BIO

2 years agoadd support for file IO in bios
Alan T. DeKok [Tue, 23 Jan 2024 13:51:44 +0000 (08:51 -0500)] 
add support for file IO in bios

2 years agouse AF_LOCAL, as AF_UNIX is deprecated
Alan T. DeKok [Tue, 23 Jan 2024 13:50:50 +0000 (08:50 -0500)] 
use AF_LOCAL, as AF_UNIX is deprecated

2 years agojust call write()
Alan T. DeKok [Tue, 23 Jan 2024 13:19:10 +0000 (08:19 -0500)] 
just call write()

2 years agoadd cfg to alloc routine, too
Alan T. DeKok [Tue, 23 Jan 2024 13:04:17 +0000 (08:04 -0500)] 
add cfg to alloc routine, too

2 years ago<sigh>
Alan T. DeKok [Tue, 23 Jan 2024 12:55:04 +0000 (07:55 -0500)] 
<sigh>

2 years agomight as well cache cfg, too
Alan T. DeKok [Tue, 23 Jan 2024 12:33:51 +0000 (07:33 -0500)] 
might as well cache cfg, too

2 years agotry to quiet the static analyzer
Alan T. DeKok [Tue, 23 Jan 2024 12:30:43 +0000 (07:30 -0500)] 
try to quiet the static analyzer

2 years agodon't return things which are missing in NDEBUG builds
Alan T. DeKok [Tue, 23 Jan 2024 02:38:27 +0000 (21:38 -0500)] 
don't return things which are missing in NDEBUG builds

2 years agothis is unused
Alan T. DeKok [Tue, 23 Jan 2024 02:27:16 +0000 (21:27 -0500)] 
this is unused

add it back in when we fix it, and start using it

2 years agoonly need this for debug builds
Alan T. DeKok [Tue, 23 Jan 2024 02:25:20 +0000 (21:25 -0500)] 
only need this for debug builds

2 years agoshut up stupid compiler
Alan T. DeKok [Tue, 23 Jan 2024 02:24:13 +0000 (21:24 -0500)] 
shut up stupid compiler

2 years agomore quiet static analysis
Alan T. DeKok [Tue, 23 Jan 2024 02:11:19 +0000 (21:11 -0500)] 
more quiet static analysis

2 years agoand more build fixes
Alan T. DeKok [Tue, 23 Jan 2024 00:42:26 +0000 (19:42 -0500)] 
and more build fixes

2 years ago...and RPM fixes
Arran Cudbard-Bell [Tue, 23 Jan 2024 00:25:51 +0000 (18:25 -0600)] 
...and RPM fixes

2 years agoand more build fixes
Alan T. DeKok [Tue, 23 Jan 2024 00:22:13 +0000 (19:22 -0500)] 
and more build fixes

2 years agoDon't apply body restrictions to xlat calls
Arran Cudbard-Bell [Tue, 23 Jan 2024 00:18:49 +0000 (18:18 -0600)] 
Don't apply body restrictions to xlat calls

2 years agomore build fixes
Alan T. DeKok [Tue, 23 Jan 2024 00:06:06 +0000 (19:06 -0500)] 
more build fixes

2 years agoclang on OSX does not produce nearly enough errors.
Alan T. DeKok [Mon, 22 Jan 2024 23:58:45 +0000 (18:58 -0500)] 
clang on OSX does not produce nearly enough errors.

CI produces many more errors and complaints.

2 years agoFirst pass at bio handlers.
Alan T. DeKok [Mon, 22 Jan 2024 23:44:41 +0000 (18:44 -0500)] 
First pass at bio handlers.

The FD bio works.  The others are "compile tested"

2 years agowe don't need these fields. The bio code has been updated
Alan T. DeKok [Mon, 22 Jan 2024 22:09:01 +0000 (17:09 -0500)] 
we don't need these fields.  The bio code has been updated

2 years agostart moving more code to centralized RADIUS library
Alan T. DeKok [Mon, 22 Jan 2024 21:35:38 +0000 (16:35 -0500)] 
start moving more code to centralized RADIUS library

2 years agodocument source of fast rng
Alan T. DeKok [Mon, 22 Jan 2024 19:31:07 +0000 (14:31 -0500)] 
document source of fast rng

2 years agoRename json xlat functions
Arran Cudbard-Bell [Mon, 22 Jan 2024 22:33:53 +0000 (16:33 -0600)] 
Rename json xlat functions

2 years agocall the correct function
Alan T. DeKok [Mon, 22 Jan 2024 19:02:09 +0000 (14:02 -0500)] 
call the correct function

2 years agot_rules may be NULL. CID 1558812
Alan T. DeKok [Mon, 22 Jan 2024 18:51:51 +0000 (13:51 -0500)] 
t_rules may be NULL. CID 1558812

2 years agojust trust /dev/random
Alan T. DeKok [Mon, 22 Jan 2024 14:25:49 +0000 (09:25 -0500)] 
just trust /dev/random

there's little utility in mixing in other data

2 years agominor cleanups
Alan T. DeKok [Mon, 22 Jan 2024 14:19:18 +0000 (09:19 -0500)] 
minor cleanups

2 years agorename functions for clarity
Alan T. DeKok [Mon, 22 Jan 2024 14:08:01 +0000 (09:08 -0500)] 
rename functions for clarity

in preparation for allowing forced seeds

2 years agono need to call encode / sign / write. just call fr_radius_send()
Alan T. DeKok [Mon, 22 Jan 2024 13:04:00 +0000 (08:04 -0500)] 
no need to call encode / sign / write.  just call fr_radius_send()

2 years agoRevert to main eapol_test repo
Nick Porter [Mon, 22 Jan 2024 18:04:53 +0000 (18:04 +0000)] 
Revert to main eapol_test repo

We only pull from the repo if we don't have a cached copy, so don't pull
very often.

2 years agoInvalid comment
Arran Cudbard-Bell [Sat, 20 Jan 2024 15:09:06 +0000 (09:09 -0600)] 
Invalid comment

2 years agoDon't reallocate the uri escape ctx on every request
Arran Cudbard-Bell [Sat, 20 Jan 2024 02:48:47 +0000 (20:48 -0600)] 
Don't reallocate the uri escape ctx on every request

2 years agoMajor rework in rlm_rest
Arran Cudbard-Bell [Sat, 20 Jan 2024 02:26:19 +0000 (20:26 -0600)] 
Major rework in rlm_rest

- Remove all synchronous expansions.  data, uri, username, password are now passed in as a call_envs
- Perform uri escaping within call_env evaluation for module section calls
- Split config items into request/response sections, and document which config items can't be used as xlats
- Remove legacy uri expansion and escaping
- Have test json-api endpoints echo back headers, args, and body data, and fix up xlat tests to check what we sent over
- Start of response header parsing and output
- Support taking body data, and headers, from ANY tmpl type not just xlats

2 years agoRemove orphaned params
Arran Cudbard-Bell [Sat, 20 Jan 2024 02:20:42 +0000 (20:20 -0600)] 
Remove orphaned params

2 years agoMake fr_uri_escape work as a value box escape function
Arran Cudbard-Bell [Sat, 20 Jan 2024 02:19:09 +0000 (20:19 -0600)] 
Make fr_uri_escape work as a value box escape function

No major changes here, we just record the current uri_part in a new fr_uri_escape_ctx_t struct.  The original function is retained as fr_uri_escape_list which processes a list of value boxes.

2 years agoDon't crash when decoding empty base64 strings
Arran Cudbard-Bell [Sat, 20 Jan 2024 02:18:02 +0000 (20:18 -0600)] 
Don't crash when decoding empty base64 strings

2 years agoAdd "secret" call_env flag. Not currently respected because we don't print anything...
Arran Cudbard-Bell [Sat, 20 Jan 2024 02:17:46 +0000 (20:17 -0600)] 
Add "secret" call_env flag.  Not currently respected because we don't print anything, but we don't want to lose the secret flag during conversions

2 years agoWordsmithing
Arran Cudbard-Bell [Sat, 20 Jan 2024 02:17:15 +0000 (20:17 -0600)] 
Wordsmithing

2 years agoBetter assert message for bad quoting type
Arran Cudbard-Bell [Sat, 20 Jan 2024 02:17:03 +0000 (20:17 -0600)] 
Better assert message for bad quoting type

2 years agoAdd support for ephemeral uctx initialisation
Arran Cudbard-Bell [Sat, 20 Jan 2024 02:14:22 +0000 (20:14 -0600)] 
Add support for ephemeral uctx initialisation

Allow escape functions to return error codes

2 years agoDon't print out certificate messages if there are no certificates
Arran Cudbard-Bell [Sat, 20 Jan 2024 01:17:36 +0000 (19:17 -0600)] 
Don't print out certificate messages if there are no certificates

2 years agoMake the openresty setup script work on macOS with homebrew
Arran Cudbard-Bell [Fri, 19 Jan 2024 00:11:25 +0000 (18:11 -0600)] 
Make the openresty setup script work on macOS with homebrew

2 years agoRemove dead code (CID #1504016)
James Jones [Fri, 19 Jan 2024 18:57:03 +0000 (12:57 -0600)] 
Remove dead code (CID #1504016)

In fr_value_box_from_substr(), the first switch on dst_type handles
the FR_TYPE_COMBO_IP_{ADDR, PREFIX} cases, so that dst_type can't
have those values when the second switch on dst_type is executed.

2 years agoRemove un-used module option
Nick Porter [Fri, 19 Jan 2024 10:41:23 +0000 (10:41 +0000)] 
Remove un-used module option

2 years agoDebian sid has removed fakeroot from build-essential
Nick Porter [Fri, 19 Jan 2024 09:48:55 +0000 (09:48 +0000)] 
Debian sid has removed fakeroot from build-essential

2 years agoCorrect documentation
Nick Porter [Thu, 18 Jan 2024 18:09:04 +0000 (18:09 +0000)] 
Correct documentation

2 years agoBetter English
Nick Porter [Thu, 18 Jan 2024 17:57:58 +0000 (17:57 +0000)] 
Better English