]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoupdate CC_HINT for removed argument
Alan T. DeKok [Thu, 16 Nov 2023 15:09:09 +0000 (10:09 -0500)] 
update CC_HINT for removed argument

2 years agoremove alternation from defaults, too
Alan T. DeKok [Thu, 16 Nov 2023 13:39:10 +0000 (08:39 -0500)] 
remove alternation from defaults, too

2 years agoRevert "Copy, don't link, schemas"
Alan T. DeKok [Thu, 16 Nov 2023 13:24:51 +0000 (08:24 -0500)] 
Revert "Copy, don't link, schemas"

This reverts commit 823ad7a63550597682582c4d70010f536db4b7be.

this breaks CI

2 years agomove xlat printing to new function syntax
Alan T. DeKok [Thu, 16 Nov 2023 13:05:14 +0000 (08:05 -0500)] 
move xlat printing to new function syntax

2 years agoremove XLAT_ALTERNATE from the source
Alan T. DeKok [Thu, 16 Nov 2023 12:49:23 +0000 (07:49 -0500)] 
remove XLAT_ALTERNATE from the source

2 years agoremove old comment
Alan T. DeKok [Wed, 15 Nov 2023 21:46:18 +0000 (16:46 -0500)] 
remove old comment

2 years agoenumvs always have names. Look for ones with values
Alan T. DeKok [Wed, 15 Nov 2023 18:56:49 +0000 (13:56 -0500)] 
enumvs always have names.  Look for ones with values

2 years agoRename some call env structures in preparation for additional changes
Arran Cudbard-Bell [Wed, 15 Nov 2023 22:04:11 +0000 (16:04 -0600)] 
Rename some call env structures in preparation for additional changes

2 years agoCopy, don't link, schemas
Arran Cudbard-Bell [Wed, 15 Nov 2023 22:05:48 +0000 (16:05 -0600)] 
Copy, don't link, schemas

This lets us add extra custom schemas later

2 years agorun through codespell, and regenerate antora
Alan T. DeKok [Wed, 15 Nov 2023 17:10:11 +0000 (12:10 -0500)] 
run through codespell, and regenerate antora

there isn't much point in updating the antora (outout) docs when
the raddb (input) files haven't been updated

2 years agouse local dictionary
Alan T. DeKok [Wed, 15 Nov 2023 15:30:53 +0000 (10:30 -0500)] 
use local dictionary

2 years agouse local variable
Alan T. DeKok [Wed, 15 Nov 2023 15:27:43 +0000 (10:27 -0500)] 
use local variable

2 years agomore "remove Tmp-*"
Alan T. DeKok [Wed, 15 Nov 2023 15:25:00 +0000 (10:25 -0500)] 
more "remove Tmp-*"

2 years agoRemove needless annotation. (#5220)
James Jones [Wed, 15 Nov 2023 00:18:41 +0000 (18:18 -0600)] 
Remove needless annotation. (#5220)

2 years agoFix typos in documentation (#5219)
Dimitri Papadopoulos Orfanos [Tue, 14 Nov 2023 23:10:34 +0000 (01:10 +0200)] 
Fix typos in documentation (#5219)

Misspellings found by codespell.

2 years agoAvoid fr_nbo_to_uint16() to get EAP packet length (CID #1243443)
James Jones [Tue, 14 Nov 2023 19:58:02 +0000 (13:58 -0600)] 
Avoid fr_nbo_to_uint16() to get EAP packet length (CID #1243443)

Moved to talloc_array_length() instead, which worked much better
after I looked at the source and saw it's a macro that uses
the type of the argument, so it requires casting to pointer to
the type it was allocated with.

2 years agocache: Move key resolution to callenv
Arran Cudbard-Bell [Tue, 14 Nov 2023 01:05:40 +0000 (19:05 -0600)] 
cache: Move key resolution to callenv

...weird intractable problems trying to get an old DHCPv4 config, easier to fix the code than debug it.

2 years agoLess confusing error
Arran Cudbard-Bell [Tue, 14 Nov 2023 00:06:15 +0000 (18:06 -0600)] 
Less confusing error

2 years agoCopy ldap config over to base dir
Arran Cudbard-Bell [Fri, 10 Nov 2023 18:41:07 +0000 (12:41 -0600)] 
Copy ldap config over to base dir

2 years agoDon't immediately overwrite the specified socketpath
Arran Cudbard-Bell [Fri, 10 Nov 2023 17:39:42 +0000 (11:39 -0600)] 
Don't immediately overwrite the specified socketpath

2 years agoAllow overriding the socket path to work around weird permissions issues
Arran Cudbard-Bell [Thu, 9 Nov 2023 23:29:20 +0000 (17:29 -0600)] 
Allow overriding the socket path to work around weird permissions issues

2 years agotouching the socket just produces another error
Arran Cudbard-Bell [Thu, 9 Nov 2023 22:03:02 +0000 (16:03 -0600)] 
touching the socket just produces another error

2 years agoPre-create ldap socket file
Arran Cudbard-Bell [Thu, 9 Nov 2023 21:36:35 +0000 (15:36 -0600)] 
Pre-create ldap socket file

2 years agoRemove comment
Arran Cudbard-Bell [Thu, 9 Nov 2023 21:18:37 +0000 (15:18 -0600)] 
Remove comment

2 years agoBuild and scan with all available cores
Arran Cudbard-Bell [Thu, 9 Nov 2023 21:18:19 +0000 (15:18 -0600)] 
Build and scan with all available cores

2 years agoldap: Add extra schemas for tacacs
Arran Cudbard-Bell [Thu, 9 Nov 2023 16:41:02 +0000 (10:41 -0600)] 
ldap: Add extra schemas for tacacs

2 years agojson: Add nested encoding tests
Arran Cudbard-Bell [Thu, 9 Nov 2023 16:37:21 +0000 (10:37 -0600)] 
json: Add nested encoding tests

2 years agouse radius_pairmove(), which does the same thing and more
Alan T. DeKok [Wed, 8 Nov 2023 15:17:56 +0000 (16:17 +0100)] 
use radius_pairmove(), which does the same thing and more

in an attempt to get rid of old / duplicate APIs

2 years agoRemove autosave file
Nick Porter [Wed, 8 Nov 2023 10:27:06 +0000 (10:27 +0000)] 
Remove autosave file

2 years agoInst is const when used in the xlat function
Arran Cudbard-Bell [Wed, 8 Nov 2023 01:35:50 +0000 (19:35 -0600)] 
Inst is const when used in the xlat function

2 years agoCan't have more than one local variable!
Arran Cudbard-Bell [Wed, 8 Nov 2023 01:33:41 +0000 (19:33 -0600)] 
Can't have more than one local variable!

2 years agoAdd test for using local attributes in eval
Arran Cudbard-Bell [Wed, 8 Nov 2023 01:18:13 +0000 (19:18 -0600)] 
Add test for using local attributes in eval

2 years agoAllow local attributes to be referenced in eval xlats
Arran Cudbard-Bell [Wed, 8 Nov 2023 00:57:47 +0000 (18:57 -0600)] 
Allow local attributes to be referenced in eval xlats

2 years agoRemove dict from xlat_exp_head_t
Arran Cudbard-Bell [Wed, 8 Nov 2023 01:11:56 +0000 (19:11 -0600)] 
Remove dict from xlat_exp_head_t

It's already in the nodes it needs to be in

2 years agoRemove async from name of instantiate set functions
Arran Cudbard-Bell [Wed, 8 Nov 2023 01:10:58 +0000 (19:10 -0600)] 
Remove async from name of instantiate set functions

2 years agoRename xlat instance registration functions
Arran Cudbard-Bell [Tue, 7 Nov 2023 23:34:46 +0000 (17:34 -0600)] 
Rename xlat instance registration functions

Bootstrap is a distinct phase for modules, and calling the registration phase "bootstrap" is confusing as there's no bootstrap function available to xlats...

2 years agoDisable performance tests on FreeBSD
Nick Porter [Fri, 3 Nov 2023 17:13:24 +0000 (17:13 +0000)] 
Disable performance tests on FreeBSD

It's a VM inside a VM so not going to be consistent / fast

2 years agoSwitch hypervisors for FreeBSD tests
Nick Porter [Fri, 3 Nov 2023 15:59:40 +0000 (15:59 +0000)] 
Switch hypervisors for FreeBSD tests

2 years agoDon't print undefined string
Nick Porter [Fri, 3 Nov 2023 13:39:21 +0000 (13:39 +0000)] 
Don't print undefined string

2 years agoluajit 2.0 is deprecated, 2.1 is current
Nick Porter [Fri, 3 Nov 2023 13:00:33 +0000 (13:00 +0000)] 
luajit 2.0 is deprecated, 2.1 is current

2 years agolua tests: pairs is a field in fr.request
Nick Porter [Fri, 3 Nov 2023 11:29:14 +0000 (11:29 +0000)] 
lua tests: pairs is a field in fr.request

2 years agoWe don't marshal structured attributes to lua yet
Nick Porter [Fri, 3 Nov 2023 11:28:09 +0000 (11:28 +0000)] 
We don't marshal structured attributes to lua yet

2 years agolua ffi.load doesn't search multiple paths
Nick Porter [Fri, 3 Nov 2023 09:43:45 +0000 (09:43 +0000)] 
lua ffi.load doesn't search multiple paths

2 years agoFix compiler warnings on FreeBSD
Nick Porter [Thu, 2 Nov 2023 20:43:33 +0000 (20:43 +0000)] 
Fix compiler warnings on FreeBSD

2 years agoUse cross-platform actions for FreeBSD tests
Nick Porter [Thu, 2 Nov 2023 12:14:02 +0000 (12:14 +0000)] 
Use cross-platform actions for FreeBSD tests

This action appears to be under more active development / maintenance than vmactions/freebsd-vm

2 years agoCheck for node == NULL in xlat_validate_function_arg() (CID #1548367) (#5213)
James Jones [Thu, 2 Nov 2023 15:11:45 +0000 (10:11 -0500)] 
Check for node == NULL in xlat_validate_function_arg() (CID #1548367) (#5213)

2 years agoNo point evaluating SQL-User-Name after the query has been built
Nick Porter [Thu, 2 Nov 2023 11:40:49 +0000 (11:40 +0000)] 
No point evaluating SQL-User-Name after the query has been built

To use SQL-User-Name in an SQL map, it needs to be populated before the
value box list of the query is created.

2 years agoUse taloc_typed_strdup when xlat_eval returns no values
Nick Porter [Thu, 2 Nov 2023 11:17:54 +0000 (11:17 +0000)] 
Use taloc_typed_strdup when xlat_eval returns no values

Otherwise using the resulting string in
fr_pair_value_bstrdup_buffer_shallow() or other functions which check
the talloc type will fail.

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:47 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:43 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:41 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:34 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:28 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:26 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:23 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:11 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

2 years agoremove manual fr_extend_lowat()
Alan T. DeKok [Wed, 1 Nov 2023 23:58:55 +0000 (19:58 -0400)] 
remove manual fr_extend_lowat()

2 years agoadd missing function
Alan T. DeKok [Wed, 1 Nov 2023 23:58:29 +0000 (19:58 -0400)] 
add missing function

2 years agoremove unnecessary ; after function
Alan T. DeKok [Wed, 1 Nov 2023 23:57:13 +0000 (19:57 -0400)] 
remove unnecessary ; after function

2 years agoxlat: Don't leave dangling marker
Arran Cudbard-Bell [Wed, 1 Nov 2023 22:35:22 +0000 (16:35 -0600)] 
xlat: Don't leave dangling marker

2 years agoInitialise max
Arran Cudbard-Bell [Wed, 1 Nov 2023 22:28:03 +0000 (16:28 -0600)] 
Initialise max

2 years agosbuff: When performing prefix matches, always extend by the longest needle
Arran Cudbard-Bell [Wed, 1 Nov 2023 21:20:06 +0000 (15:20 -0600)] 
sbuff: When performing prefix matches, always extend by the longest needle

2 years agotypo
Alan T. DeKok [Wed, 1 Nov 2023 20:40:09 +0000 (16:40 -0400)] 
typo

2 years agoRevert "move extend out of users_file.c to sbuff.c"
Alan T. DeKok [Wed, 1 Nov 2023 20:24:51 +0000 (16:24 -0400)] 
Revert "move extend out of users_file.c to sbuff.c"

This reverts commit 02ec7cdac5cbaa13305eb2503a23210d3af9084d.

it turns out extending things in the sbuff code causes other
problems.  So we leave some hacks in the users_file parser.

2 years agomove to RADIUS attributes
Alan T. DeKok [Wed, 1 Nov 2023 20:02:38 +0000 (16:02 -0400)] 
move to RADIUS attributes

2 years agoadd test for large users file
Alan T. DeKok [Wed, 1 Nov 2023 19:23:36 +0000 (15:23 -0400)] 
add test for large users file

the default buffer size is 8K, so we add a file larger than that.
If the sbuff extension only looks for one byte at a time, then
we will run out of data in the buffer while there is still pending
data to read.  The users file reader will then return an error.

By updating the sbuffs to read more than 1 character, we ensure
that there's enough data in the buffer for most parsing purposes.

2 years agomove extend out of users_file.c to sbuff.c
Alan T. DeKok [Wed, 1 Nov 2023 19:20:21 +0000 (15:20 -0400)] 
move extend out of users_file.c to sbuff.c

If we're processing substantial amounts of input in a loop,
it doesn't help to extend the buffer by 32 bytes at a time.
Doing so will help decrease the calls to "extend", and ensures
that the application no longer needs to manually extend the
buffers.

2 years agorelease markers and extend buffer when reading pairs
Alan T. DeKok [Wed, 1 Nov 2023 14:10:29 +0000 (10:10 -0400)] 
release markers and extend buffer when reading pairs

we would _like_ the sbuff functions to automatically extend the
buffers at a low water marker.  But instead that has to be done
manually.

2 years agoreply packets use request authenticator for Message-Authenticator
Alan T. DeKok [Tue, 31 Oct 2023 22:13:53 +0000 (18:13 -0400)] 
reply packets use request authenticator for Message-Authenticator

manually port 1d8b14342 from v3.2.x branch

2 years agorun recv when receiving packets, not send
Alan T. DeKok [Tue, 31 Oct 2023 22:12:34 +0000 (18:12 -0400)] 
run recv when receiving packets, not send

2 years agoupdate documentation for new behavior
Alan T. DeKok [Tue, 31 Oct 2023 20:43:55 +0000 (16:43 -0400)] 
update documentation for new behavior

2 years agoset rules to zero
Alan T. DeKok [Tue, 31 Oct 2023 20:30:28 +0000 (16:30 -0400)] 
set rules to zero

2 years agowe need to set SQL-Group, too
Alan T. DeKok [Tue, 31 Oct 2023 20:29:18 +0000 (16:29 -0400)] 
we need to set SQL-Group, too

2 years agolimit child allocation depth to MAX_TLV_STACK
Alan T. DeKok [Tue, 31 Oct 2023 19:36:23 +0000 (15:36 -0400)] 
limit child allocation depth to MAX_TLV_STACK

2 years agore-add User-Profile behavior
Alan T. DeKok [Tue, 31 Oct 2023 19:14:58 +0000 (15:14 -0400)] 
re-add User-Profile behavior

2 years agomove get group things to its own function
Alan T. DeKok [Tue, 31 Oct 2023 19:07:01 +0000 (15:07 -0400)] 
move get group things to its own function

2 years agoremove default_user_profile, etc.
Alan T. DeKok [Tue, 31 Oct 2023 18:33:49 +0000 (14:33 -0400)] 
remove default_user_profile, etc.

2 years agocheck parenting for list operations
Alan T. DeKok [Tue, 31 Oct 2023 15:17:05 +0000 (11:17 -0400)] 
check parenting for list operations

2 years agoclean up for clang scan
Alan T. DeKok [Tue, 31 Oct 2023 15:14:51 +0000 (11:14 -0400)] 
clean up for clang scan

2 years agoUse new xlat function syntax in inline comments
Nick Porter [Tue, 31 Oct 2023 08:56:07 +0000 (08:56 +0000)] 
Use new xlat function syntax in inline comments

2 years agonote that we can't do &list1 := &list2 + &list3
Alan T. DeKok [Tue, 31 Oct 2023 14:47:24 +0000 (10:47 -0400)] 
note that we can't do &list1 := &list2 + &list3

it's better to give a descriptive error than crash

2 years agolet's try to use our local repo for pulling from hostap
Alan T. DeKok [Tue, 31 Oct 2023 12:59:03 +0000 (08:59 -0400)] 
let's try to use our local repo for pulling from hostap

so that we don't bug Jouni with endless pull requests

2 years agoremove unused function
Alan T. DeKok [Mon, 30 Oct 2023 18:44:04 +0000 (14:44 -0400)] 
remove unused function

2 years agoallow internal groups to be parents too
Alan T. DeKok [Mon, 30 Oct 2023 18:10:36 +0000 (14:10 -0400)] 
allow internal groups to be parents too

2 years agoremove %pack()
Alan T. DeKok [Mon, 30 Oct 2023 17:52:06 +0000 (13:52 -0400)] 
remove %pack()

2 years agoremove %module
Alan T. DeKok [Mon, 30 Oct 2023 17:48:48 +0000 (13:48 -0400)] 
remove %module

we now use %interpeter('module')

2 years agomove away from backticks, and use %exec()
Alan T. DeKok [Mon, 30 Oct 2023 13:25:45 +0000 (09:25 -0400)] 
move away from backticks, and use %exec()

It looks harder to use.  Instead of passing one string which is
then split by exec, we pass multiple strings as function arguments.

However, this is likely safer, too.

2 years agoadd tainted flag
Alan T. DeKok [Mon, 30 Oct 2023 12:56:08 +0000 (08:56 -0400)] 
add tainted flag

so that we don't have to walk down the list of VPs after creating
them.

2 years agoTypo
James Jones [Mon, 30 Oct 2023 16:29:18 +0000 (11:29 -0500)] 
Typo

Found while looking into CID #1548348

2 years agodocument KRB5_CLIENT_KTNAME
Alan T. DeKok [Sun, 29 Oct 2023 22:32:22 +0000 (18:32 -0400)] 
document KRB5_CLIENT_KTNAME

2 years agoremove this, too
Alan T. DeKok [Sun, 29 Oct 2023 22:28:48 +0000 (18:28 -0400)] 
remove this, too

2 years agoremove unused variable. CID #1548348
Alan T. DeKok [Sun, 29 Oct 2023 22:13:23 +0000 (18:13 -0400)] 
remove unused variable.  CID #1548348

2 years agoallow zero input
Alan T. DeKok [Sun, 29 Oct 2023 16:21:00 +0000 (12:21 -0400)] 
allow zero input

2 years agoremove legacy function
Alan T. DeKok [Sun, 29 Oct 2023 15:52:20 +0000 (11:52 -0400)] 
remove legacy function

2 years agocatch corner case of empty input buffer
Alan T. DeKok [Sun, 29 Oct 2023 15:47:08 +0000 (11:47 -0400)] 
catch corner case of empty input buffer

2 years agomake fr_pair_list_afrom_file() use the new API
Alan T. DeKok [Sun, 29 Oct 2023 15:29:17 +0000 (11:29 -0400)] 
make fr_pair_list_afrom_file() use the new API

and touch up one unit test, as the key field was auto-created,
but created with operator '=' instead of '=='

2 years agowe don't need this any more
Alan T. DeKok [Sun, 29 Oct 2023 15:28:46 +0000 (11:28 -0400)] 
we don't need this any more

2 years agominor tweaks
Alan T. DeKok [Sun, 29 Oct 2023 15:28:05 +0000 (11:28 -0400)] 
minor tweaks

keep going on ,<CR>, too.

produce better error messages when the child attribute is not
found.

2 years agomove detail reader to new API
Alan T. DeKok [Sun, 29 Oct 2023 14:38:22 +0000 (10:38 -0400)] 
move detail reader to new API

with comments that much of the detail file reader won't handle
nested attributes properly. :(