]>
git.ipfire.org Git - thirdparty/freeradius-server.git/log
Catalina Pineros [Mon, 16 Mar 2026 18:32:33 +0000 (14:32 -0400)]
fix typos
Catalina Pineros [Mon, 16 Mar 2026 16:19:27 +0000 (12:19 -0400)]
fix same typo in comment, in different files
Catalina Pineros [Mon, 16 Mar 2026 16:14:54 +0000 (12:14 -0400)]
fix typo in comment
Catalina Pineros [Mon, 16 Mar 2026 16:03:07 +0000 (12:03 -0400)]
fix typo in comment
Catalina Pineros [Mon, 16 Mar 2026 15:58:19 +0000 (11:58 -0400)]
fix typo in comment
Catalina Pineros [Mon, 16 Mar 2026 14:55:13 +0000 (10:55 -0400)]
fix misplaced parenthesis
tolower(cmd_str[1] != s ) does not actually turn anything into lowercase, since it is evaluating a number and not a char
Alan T. DeKok [Mon, 16 Mar 2026 22:18:39 +0000 (18:18 -0400)]
fr_value_box_cmp() is used in stable sorts
and therefore can't call fr_digest_cmp().
Alan T. DeKok [Mon, 16 Mar 2026 22:18:07 +0000 (18:18 -0400)]
use MEMCMP_FIELDS() in paircmp() too
and add note about the secret flag
Alan T. DeKok [Mon, 16 Mar 2026 21:47:10 +0000 (17:47 -0400)]
define MEMCMP_FIELDS() and use it
which is a little clearer (and less wrappers) than MEMCMP_RETURN
Alan T. DeKok [Mon, 16 Mar 2026 20:54:40 +0000 (16:54 -0400)]
just call cache_expire() instead of doing it locally
which handles more corner cases.
also other minor tweaks
Alan T. DeKok [Mon, 16 Mar 2026 20:51:56 +0000 (16:51 -0400)]
try to clear out 3 cache entries for every 1 lookup
which lets us clean up old entries more quickly after a spike of
traffic
ethan-thompson [Mon, 16 Mar 2026 16:21:51 +0000 (12:21 -0400)]
restore write errno after ftruncate in partial header write path
Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
ethan-thompson [Mon, 16 Mar 2026 15:43:22 +0000 (11:43 -0400)]
fix int truncation of ssize_t return from fr_concatv
Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
ethan-thompson [Mon, 16 Mar 2026 15:36:05 +0000 (11:36 -0400)]
skip NULL request pointers when marking batch entries runnable
Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
ethan-thompson [Mon, 16 Mar 2026 15:27:47 +0000 (11:27 -0400)]
use fr_hash_string for file table lookup to match filename_hash
Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
Alan T. DeKok [Mon, 16 Mar 2026 18:18:40 +0000 (14:18 -0400)]
always return "updated" if we updated something
Alan T. DeKok [Mon, 16 Mar 2026 18:16:39 +0000 (14:16 -0400)]
cache xlat can succeed if it returns no data.
i.e. "no data in cache" isn't an xlat failure, it's an xlat
success with no data.
Alan T. DeKok [Mon, 16 Mar 2026 18:09:36 +0000 (14:09 -0400)]
set_ttl with TTL=0 is a noop
Alan T. DeKok [Mon, 16 Mar 2026 14:44:30 +0000 (10:44 -0400)]
fix cache it logic
so that it follows the documentation
Alan T. DeKok [Mon, 16 Mar 2026 14:44:09 +0000 (10:44 -0400)]
pass correct pointer to handle
Alan T. DeKok [Mon, 16 Mar 2026 14:42:33 +0000 (10:42 -0400)]
return 0 on count error, not negative.
because the return value is unsigned.
Alan T. DeKok [Mon, 16 Mar 2026 15:27:51 +0000 (11:27 -0400)]
allow tests without the full re-run of all tests
Alan T. DeKok [Mon, 16 Mar 2026 15:20:08 +0000 (11:20 -0400)]
cache_foo depends on rlm_cache, too
Nick Porter [Mon, 16 Mar 2026 08:32:20 +0000 (08:32 +0000)]
Correct section name
Alan T. DeKok [Sun, 15 Mar 2026 22:57:08 +0000 (18:57 -0400)]
minor cleanups in thread code
Alan T. DeKok [Sun, 15 Mar 2026 22:47:58 +0000 (18:47 -0400)]
move fd management to narrower scope
and use fileno(fp), so that we have fewer concerns with managing
the fd
Alan T. DeKok [Sun, 15 Mar 2026 19:02:28 +0000 (15:02 -0400)]
move common code to fr_thread_start / fr_thread_exit
Alan T. DeKok [Sun, 15 Mar 2026 18:32:08 +0000 (14:32 -0400)]
rename fr_thread functions for clarity
Alan T. DeKok [Sun, 15 Mar 2026 17:54:58 +0000 (13:54 -0400)]
move thread information to a common data structure
Alan T. DeKok [Sun, 15 Mar 2026 15:30:18 +0000 (11:30 -0400)]
move thread create && wait to common functions
Alan T. DeKok [Sun, 15 Mar 2026 15:16:50 +0000 (11:16 -0400)]
move thread setup to common function
Alan T. DeKok [Sun, 15 Mar 2026 15:13:03 +0000 (11:13 -0400)]
move thread instantiation to common function
Alan T. DeKok [Thu, 12 Mar 2026 17:28:55 +0000 (13:28 -0400)]
simplify the names
less shouting is good.
Marc-Andre Casavant [Mon, 23 Feb 2026 19:00:48 +0000 (14:00 -0500)]
Initial baseline multi-server tests for load-generator -> 5 homeserver and load-generator -> 1 proxy -> 2 homeserver scenarios.
Alan T. DeKok [Sun, 15 Mar 2026 13:15:00 +0000 (09:15 -0400)]
tweaks, and use fr_dlist_foreach() in more places
Alan T. DeKok [Sun, 15 Mar 2026 13:01:54 +0000 (09:01 -0400)]
wrap multi-line macro in do/while
Alan T. DeKok [Sun, 15 Mar 2026 12:59:12 +0000 (08:59 -0400)]
free dbuff on encode failure
Alan T. DeKok [Sun, 15 Mar 2026 12:58:28 +0000 (08:58 -0400)]
minimize includes
Nick Porter [Sun, 15 Mar 2026 12:31:10 +0000 (12:31 +0000)]
Pacify Coverity (CID #
1686327 )
Nick Porter [Sun, 15 Mar 2026 12:28:42 +0000 (12:28 +0000)]
Check return (CID #
1686328 )
Nick Porter [Sun, 15 Mar 2026 12:28:16 +0000 (12:28 +0000)]
Check return (CID #
1686329 )
Alan T. DeKok [Sun, 15 Mar 2026 02:42:17 +0000 (22:42 -0400)]
da can't be NULL here
Alan T. DeKok [Sun, 15 Mar 2026 02:40:56 +0000 (22:40 -0400)]
return failure on error
Alan T. DeKok [Sun, 15 Mar 2026 02:40:16 +0000 (22:40 -0400)]
check the return code of adding the compile list
Alan T. DeKok [Sun, 15 Mar 2026 02:39:45 +0000 (22:39 -0400)]
typo
Alan T. DeKok [Sun, 15 Mar 2026 02:38:30 +0000 (22:38 -0400)]
unify code which warns about unused processing sections
Alan T. DeKok [Sun, 15 Mar 2026 02:27:44 +0000 (22:27 -0400)]
spelling mistakes
Catalina Pineros [Fri, 13 Mar 2026 20:23:47 +0000 (16:23 -0400)]
fix error message typo
Catalina Pineros [Fri, 13 Mar 2026 20:13:55 +0000 (16:13 -0400)]
check return value
if pthread_mutex_init does not succeed,
then trigger_mutex is not intialized,
so return -1
Catalina Pineros [Fri, 13 Mar 2026 18:53:15 +0000 (14:53 -0400)]
typo in comment
Catalina Pineros [Fri, 13 Mar 2026 18:46:31 +0000 (14:46 -0400)]
fix typo in comment
Catalina Pineros [Fri, 13 Mar 2026 17:43:28 +0000 (13:43 -0400)]
fix insert/remove from free_request with preprocessor macro
instead of using dlist functions and manually tracking head/tail,
use wrapper functions named for the list being updated, with
clearer and more descriptive names.
Catalina Pineros [Fri, 13 Mar 2026 16:24:04 +0000 (12:24 -0400)]
fix comment and debug message typos
Catalina Pineros [Fri, 13 Mar 2026 16:01:49 +0000 (12:01 -0400)]
fail connection with proper variable values, send error message
set state.last_failed to now,
decrement state.pending to avoid misleading "already at max" error message,
give information in error message when mem alloc fails for a new connection.
Catalina Pineros [Thu, 12 Mar 2026 17:19:00 +0000 (13:19 -0400)]
fix memory leak
close(fd) before returning
Alan T. DeKok [Fri, 13 Mar 2026 14:18:53 +0000 (10:18 -0400)]
parser functions return ssize_t
Alan T. DeKok [Fri, 13 Mar 2026 12:00:57 +0000 (08:00 -0400)]
no need to do head && then remove. Just do pop_head()
Catalina Pineros [Thu, 12 Mar 2026 19:44:09 +0000 (15:44 -0400)]
insert new trunc requests at head
because we free from the tail
Catalina Pineros [Thu, 12 Mar 2026 19:11:02 +0000 (15:11 -0400)]
fix typo in comments
Catalina Pineros [Thu, 12 Mar 2026 19:01:08 +0000 (15:01 -0400)]
fix typo in comments
to to, in in, is is
Catalina Pineros [Thu, 12 Mar 2026 18:44:20 +0000 (14:44 -0400)]
fix typo in comments
the the
Catalina Pineros [Thu, 12 Mar 2026 18:33:04 +0000 (14:33 -0400)]
fix typo in comments
is is
Catalina Pineros [Thu, 12 Mar 2026 18:07:40 +0000 (14:07 -0400)]
fix comment
Catalina Pineros [Thu, 12 Mar 2026 17:42:48 +0000 (13:42 -0400)]
fix whitespace stripping that never executes
buff[2][slen] is set to '/0', which is not a whitespace character, so we need to check buff[2][slen - 1] to actually remove trailing whitespace
Catalina Pineros [Thu, 12 Mar 2026 17:30:10 +0000 (13:30 -0400)]
fix error message typo
Alan T. DeKok [Fri, 13 Mar 2026 11:51:13 +0000 (07:51 -0400)]
correct error path when failing to open file
Alan T. DeKok [Fri, 13 Mar 2026 11:50:46 +0000 (07:50 -0400)]
remove extra semicolon
Catalina Pineros [Wed, 11 Mar 2026 14:26:49 +0000 (10:26 -0400)]
initialize var
Alan T. DeKok [Fri, 13 Mar 2026 11:43:16 +0000 (07:43 -0400)]
we can enter closed from shutdown && timeout, too
_connection_free() and connection_signal_shutdown() both enter
the closed state from the timout state.
Nick Porter [Fri, 13 Mar 2026 09:43:25 +0000 (09:43 +0000)]
Clean up on failure
Nick Porter [Thu, 26 Feb 2026 17:40:19 +0000 (17:40 +0000)]
Clarify comment
Control planes can be multi-producer, single consumer - so mulitple
threads can send / push a message.
Nick Porter [Wed, 18 Feb 2026 10:01:10 +0000 (10:01 +0000)]
Add coordinator startup / shutdown into scheduler
Nick Porter [Wed, 18 Feb 2026 09:57:26 +0000 (09:57 +0000)]
Add coord_attach callback to modules
Nick Porter [Wed, 18 Feb 2026 09:31:18 +0000 (09:31 +0000)]
Add support for pair list worker <-> coordinator data
On the coordinator side the pair list is then converted to a request and run through an interpreter.
Nick Porter [Tue, 3 Mar 2026 11:39:01 +0000 (11:39 +0000)]
Add API for coordniator callback instances
Allows callbacks to register an instance create function to create instance data and a set of callbacks to run as part of the event loop.
Nick Porter [Wed, 18 Feb 2026 09:02:28 +0000 (09:02 +0000)]
Add coordinator frame work for sending data messages worker <-> coordinator
Nick Porter [Tue, 18 Nov 2025 10:37:11 +0000 (10:37 +0000)]
Add fr_control_wait() to wait for a control message
Nick Porter [Thu, 19 Feb 2026 19:40:57 +0000 (19:40 +0000)]
Use a semaphore to ensure master thread has started before workers
Nick Porter [Tue, 18 Nov 2025 08:57:09 +0000 (08:57 +0000)]
Use mmapped memory for POSIX semaphores
In preparation for using separate processes in place of threads
Nick Porter [Fri, 24 Oct 2025 14:07:51 +0000 (15:07 +0100)]
Dynamically allocate the number of control plane callbacks
To allow the control plane to be used for an arbitrary number of message
IDs
Nick Porter [Fri, 24 Oct 2025 13:10:05 +0000 (14:10 +0100)]
Move control message IDs into headers relating to their use
Alan T. DeKok [Thu, 12 Mar 2026 22:28:28 +0000 (18:28 -0400)]
print out packet type and ID too
Alan T. DeKok [Thu, 12 Mar 2026 18:57:26 +0000 (14:57 -0400)]
clean up printing for regexes
Alan T. DeKok [Thu, 12 Mar 2026 18:15:10 +0000 (14:15 -0400)]
print out strerror, too
Alan T. DeKok [Thu, 12 Mar 2026 17:55:01 +0000 (13:55 -0400)]
flush the output, just in case
Alan T. DeKok [Thu, 12 Mar 2026 11:47:38 +0000 (07:47 -0400)]
run scripts/build/min-includes.pl
to minimize the number of duplicate includes
Alan T. DeKok [Thu, 12 Mar 2026 11:43:08 +0000 (07:43 -0400)]
remove duplicate headers
perl -ni -e 'print unless (/<(stdbool|stdint|stddef|string).h>/)' $(git grep -l stdbool.h src | grep '\.[ch]' | egrep -v 'build|autoconf' )
Nick Porter [Thu, 12 Mar 2026 10:14:19 +0000 (10:14 +0000)]
Include stdbool.h in default headers
Nick Porter [Thu, 12 Mar 2026 09:40:51 +0000 (09:40 +0000)]
Return on negative value (CID #
1684172 )
Alan T. DeKok [Wed, 11 Mar 2026 22:25:17 +0000 (18:25 -0400)]
only call marker() functions once.
one the second pass, call set()
Catalina Pineros [Wed, 11 Mar 2026 20:09:17 +0000 (16:09 -0400)]
changed error message
replaced hardcoded value with the more useful library->autoinit->name
Catalina Pineros [Wed, 11 Mar 2026 19:57:55 +0000 (15:57 -0400)]
fix error message typo
Catalina Pineros [Wed, 11 Mar 2026 19:06:50 +0000 (15:06 -0400)]
fix debug message typo
Catalina Pineros [Wed, 11 Mar 2026 17:53:51 +0000 (13:53 -0400)]
fix warning message typo
Catalina Pineros [Wed, 11 Mar 2026 17:41:46 +0000 (13:41 -0400)]
fix warning message format specifiers
%d is for signed ints. index is uint_32 so it should use %u, which is for unsigned ints.
Catalina Pineros [Wed, 11 Mar 2026 16:05:01 +0000 (12:05 -0400)]
fix error message typo
Catalina Pineros [Wed, 11 Mar 2026 15:33:25 +0000 (11:33 -0400)]
initialize var
Alan T. DeKok [Wed, 11 Mar 2026 21:32:28 +0000 (17:32 -0400)]
move function needing sbuff out of talloc.c
because otherwise we have circular includes of talloc to sbuff
to talloc, and things don't always work as well as they should.
Alan T. DeKok [Wed, 11 Mar 2026 21:11:47 +0000 (17:11 -0400)]
minimize the number of includes for a core header file
Alan T. DeKok [Wed, 11 Mar 2026 20:27:30 +0000 (16:27 -0400)]
fix uses of fr_sbuff_marker() vs fr_sbuff_set()
fr_sbuff_marker() is run once, and only once. after that,
fr_sbuff_set() is used to update the marker