Jonathan Wakely [Wed, 1 Apr 2026 17:11:34 +0000 (18:11 +0100)]
libstdc++: Rename parameters of unordered erase(K&&) members
This fixes some Doxygen warnings caused by inconsistent parameter names,
which do not match the names used in the Doxygen comments:
include/bits/unordered_map.h:899: warning: argument '__x' of command @param is not found in the argument list of std::unordered_map< _Key, _Tp, _Hash, _Pred, _Alloc >::erase(_Kt &&__key)
include/bits/unordered_map.h:899: warning: The following parameter of std::unordered_map::erase(_Kt &&__key) is not documented:
parameter '__key'
libstdc++-v3/ChangeLog:
* include/bits/unordered_map.h (unordered_map::erase(K&&)):
Change parameter name to __x.
* include/bits/unordered_set.h (unordered_set::erase(K&&))
(unordered_multiset::erase(K&&)): Likewise.
Reviewed-by: Tomasz Kamiński <tkaminsk@redhat.com>
Jonathan Wakely [Wed, 1 Apr 2026 14:13:23 +0000 (15:13 +0100)]
libstdc++: Fix Doxygen grouping
libstdc++-v3/ChangeLog:
* include/bits/ostream.h (operator<<): Do not include deleted
overloads in @{ group.
* include/bits/stl_queue.h (priority_queue): Add @{ group around
constructors.
* include/bits/unordered_map.h: Remove stray @{. Move #endif to
encompass @} that is within the #if group.
Reviewed-by: Tomasz Kamiński <tkaminsk@redhat.com>
Jonathan Wakely [Wed, 1 Apr 2026 14:06:21 +0000 (15:06 +0100)]
libstdc++: Remove Doxygen @return on void functions
With the latest version of Doxygen this gives a warning about using
@return on a function that returns void. Stating it explicitly adds very
little value, anybody can see from the signature that a function returns
void.
Jonathan Wakely [Wed, 1 Apr 2026 09:41:29 +0000 (10:41 +0100)]
libstdc++: Tweak Doxygen config file to include C++26 components
This updates the __cplusplus value used by Doxygen, so that C++26
components are included in the generated docs. It also suppresses
documentation for some macros that are implementation details or just
uninteresting for users.
libstdc++-v3/ChangeLog:
* doc/doxygen/user.cfg.in (INPUT): Add <debugging> header.
(EXCLUDE_SYMBOLS): Exclude include guards and other internal
macros from generated documentation.
(PREDEFINED): Update __cplusplus to C++26 value. Remove
unnecessary spaces in macro expansions. Add missing
_GLIBCXX_ABI_TAG_CXX11 macro.
Reviewed-by: Tomasz Kamiński <tkaminsk@redhat.com>
Jonathan Wakely [Wed, 1 Apr 2026 09:37:09 +0000 (10:37 +0100)]
libstdc++: Update Doxygen config to 1.17.0
The changes were done automatically using 'doxygen -u' to rebase the
config on Doxygen 1.17.0, which added a number of new config options and
removed HTML_TIMESTAMP and LATEX_TIMESTAMP.
libstdc++-v3/ChangeLog:
* doc/doxygen/user.cfg.in: Update Doxygen config.
Reviewed-by: Tomasz Kamiński <tkaminsk@redhat.com>
Jonathan Wakely [Wed, 1 Apr 2026 14:16:38 +0000 (15:16 +0100)]
libstdc++: Use __cpp_lib_map_try_emplace feature test macro
Check the relevant macro for insert_or_assign members, instead of just
checking the value of __cplusplus.
Also use Doxygen grouping to make docs for try_emplace apply to all
three overloads.
libstdc++-v3/ChangeLog:
* include/bits/stl_map.h (map::try_emplace): Move #endif and use
Doxygen's @{ to document all three overloads.
(map::insert_or_assign): Use relevant feature test macro.
Reviewed-by: Tomasz Kamiński <tkaminsk@redhat.com>
Tomasz Kamiński [Mon, 26 Jan 2026 11:20:48 +0000 (12:20 +0100)]
libstdc++: Change meaning of strided_slice::extent per P3982R2
This patch implements the changes suggested in P3982R2 (and PL007 NB comment)
for C++26, but changing the strided_slice::extent to indicate number of
elements (extent) in the produced (output) mdspan, instead of input.
libstdc++-v3/ChangeLog:
* include/std/mdspan (__mdspan::__static_slice_extent)
(__mdspan::__dynamic_slice_extent): Return unmodified extent
value for strided_slice.
(__mdspan::__substrides_generic, __mdspan::__substrides_standardized):
Multipliy stride, if more than one element is requested.
(__mdspan::__canonical_range_slice): Define.
(__mdspan::__slice_cast): Use __canonical_range_slice for range_slice
and two elements tuples.
(__mdspan::__check_inrange_index): Define.
(__mdspan::__check_valid_slice): Validate if slice.offset +
(slice.extent - 1) * slice.stride fits into extent of given
dimension. Check stride if slice.extent > 1.
* testsuite/23_containers/mdspan/submdspan/canonical_slices.cc:
Add test for range_slice.
* testsuite/23_containers/mdspan/submdspan/canonical_slices_neg.cc:
Add tests validating new conditions.
* testsuite/23_containers/mdspan/submdspan/selections/testcases.h:
Adjusted for change of meaing of strided_slice::extent.
* testsuite/23_containers/mdspan/submdspan/subextents.cc:
Adjusted for change of meaing of strided_slice::extent. And expanded
range_slice tests.
* testsuite/23_containers/mdspan/submdspan/subextents_neg.cc:
Adjusted for change of meaing of strided_slice::extent.
* testsuite/23_containers/mdspan/submdspan/submdspan_neg.cc:
Adjust test for stride value.
Reviewed-by: Jonathan Wakely <jwakely@redhat.com> Signed-off-by: Tomasz Kamiński <tkaminsk@redhat.com>
Tomasz Kamiński [Tue, 16 Dec 2025 17:03:23 +0000 (18:03 +0100)]
libstdc++: Implement range_slice from P3982R2.
This patch add a range_slice a class, and maps it to strided_slice
with the original meanning. This is usefull for benchmark, as effects
of strided_slice remain stable before and after the change.
This is to be able to ignore invalid versions to allow some portability
of code using target_clones attributes.
Add warning tests for invalid target_clones versions.
gcc/ChangeLog:
* config/loongarch/loongarch-protos.h
(loongarch_parse_fmv_features): Modify parameter type.
* config/loongarch/loongarch-target-attr.cc
(loongarch_parse_fmv_features): Some errors have been
changed to warnings.
* config/loongarch/loongarch.cc
(loongarch_process_target_version_attr): Update parameters.
(loongarch_check_target_clone_version): Likewise.
(loongarch_option_same_function_versions): Likewise.
(TARGET_CHECK_TARGET_CLONE_VERSION): Define.
gcc/testsuite/ChangeLog:
* gcc.target/loongarch/attr-check-error-message8.c: Removed.
* gcc.target/loongarch/attr-check-error-message9.c: Removed.
* gcc.target/loongarch/attr-check-warning-message1.c: New test.
* gcc.target/loongarch/attr-check-warning-message2.c: New test.
* gcc.target/loongarch/attr-check-warning-message3.c: New test.
Jonathan Wakely [Wed, 1 Apr 2026 14:25:14 +0000 (15:25 +0100)]
libstdc++: Check right value of __cpp_lib_format for dynamic_string
This doesn't matter in practice, but strictly speaking the right value
for defining std::dynamic_format is 202603 not 202311 (which was the
macro value for the old name, std::runtime_format).
libstdc++-v3/ChangeLog:
* include/std/format (dynamic_format): Check new value for
feature test macro.
Reviewed-by: Tomasz Kamiński <tkaminsk@redhat.com>
fortran: Fix assumed-rank repacking for contiguous dummies [PR124751]
When an assumed-rank actual is packed for a contiguous dummy argument,
create a descriptor for the packed temporary instead of reusing the
original descriptor metadata with stale strides and offsets.
The updated testcase keeps the original ICE coverage from PR100194 and
adds runtime coverage for the remaining wrong-code cases reported after
r16-8375.
PR fortran/124751
gcc/fortran/ChangeLog:
* trans-array.cc (gfc_conv_array_parameter): Build a packed
descriptor for assumed-rank actual arguments instead of reusing
stale metadata from the original descriptor.
gcc/testsuite/ChangeLog:
* gfortran.dg/pr100194.f90: Run the testcase and add runtime
coverage for packed assumed-rank sections.
Co-authored-by: Paul Thomas <pault@gcc.gnu.org> Signed-off-by: Christopher Albert <albert@tugraz.at>
Roger Sayle [Wed, 1 Apr 2026 22:54:50 +0000 (23:54 +0100)]
PR target/123238: VCOND_MASK regression on aarch64.
This patch fixes the regression PR target/123238 on aarch64, using the
changes to aarch64's aarch64_rtx_costs proposed by Tamar Christina.
To explain and motivate things for aarch64:
void foo(char c[])
{
for (int i = 0; i < 8; i++)
c[i] = c[i] != 'a' ? 'c' : 'e';
}
currently generates with -O2 the following:
foo: movi v30.8b, 0x61
ldr d0, [x0]
movi v29.8b, 0x63
movi v31.8b, 0x65
cmeq v30.8b, v0.8b, v30.8b
not v30.8b, v30.8b
bit v31.8b, v29.8b, v30.8b
str d31, [x0]
ret
where a cmeq followed by a not is used to implement NE_EXPR.
c.f. the comment "Handle NE as !EQ" in aarch64-simd.md's expander
of vec_cmp<mode><mode>. With the patch for PR 123238, including this
change to aarch64_rtx_costs to indicate that NE is more expensive
than EQ, the middle-end swaps the VCOND_EXPR, reducing the number of
instructions in the example above [to what it was in GCC 14].
2026-04-01 Tamar Christina <tamar.christina@arm.com>
Roger Sayle <roger@nextmovesoftware.com>
gcc/ChangeLog
PR target/123238
* config/aarch64/aarch64.cc (aarch64_rtx_costs) <case NE/EQ>:
Provide improved costs for scalar and vector comparisons.
gcc/testsuite/ChangeLog
PR target/123238
* gcc.target/aarch64/pr123238.c: New test case.
Roger Sayle [Wed, 1 Apr 2026 22:52:26 +0000 (23:52 +0100)]
PR target/123238: VCOND_MASK regression on x86_64.
This patch is my revised fix for (the regression aspects of) PR123238,
a code quality regression on x86_64 triggered by the generation of
VCOND_MASK. The regression is actually just bad luck. From gimple,
VCOND_MASK(a==b,c,d) is equivalent to VCOND_MASK(a!=b,d,c), and which
form gets generated was previously arbitrary. This is reasonable for
many (most?) targets, but on x86_64 there's an asymmetry, equality
can be performed in 1 instruction, but inequality requires three.
Teaching the middle-end's expand pass which form is preferred could
in theory be done with a new (very specific) target hook, that would
require documentation, but a more generic solution is for expand's
expand_vec_cond_mask_optab_fn to make use of rtx_costs, and reverse
the sense of VCOND_MASK if that would be an improvement. This has
the convenient property that the default rtx_costs of all comparison
operators is the same, resulting in no change unless explicitly
specified by the backend.
This revision incorporates the feedback from both Andrew Pinksi and
Richard Biener, using get_gimple_for_ssa_name instead of
SSA_NAME_DEF_STMT, and Andrew's suggestion to log expand's
decision to the dump file, which now contains lines such as:
;; swapping operands of .VCOND_MASK
;; cost of original ne: 8
;; cost of replacement eq: 4
or (for failure)
;; not swapping operands of .VCOND_MASK
;; cost of original eq: 4
;; cost of replacement ne: 8
Thanks to Richard and Hongtao for approvals.
2026-04-01 Roger Sayle <roger@nextmovesoftware.com>
gcc/ChangeLog
PR target/123238
* expr.cc (convert_tree_comp_to_rtx): Make global.
* expr.h (convert_tree_comp_to_rtx): Prototype here.
* internal-fn.cc (expand_vec_cond_mask_optab_fn): Use rtx_costs
to determine whether swapping operands would result in better
code.
* config/i386/i386-expand.cc (ix86_expand_int_vec_cmp): On
AVX512 targets use a ternlog instead of a comparison to negate
the mask (requires one instruction instead of two).
* config/i386/i386.cc (ix86_rtx_costs): Refactor code for UNSPEC.
Provide costs for UNSPEC_BLENDV and UNSPEC_MOVMSK. Provide
costs for comparison operators of integer vector modes.
Gonzalosilvalde [Sat, 28 Mar 2026 11:22:42 +0000 (12:22 +0100)]
fortran: Fix host association in module procedure interface bodies [PR79330]
Named constants from the host scope were not accessible in module
procedure interface bodies, causing bind(C, name=...) expressions
referencing such constants to fail. The compiler treated the constant
as an implicitly typed REAL(4) variable instead of resolving it from
the enclosing module scope.
The fix sets has_import_set on the current namespace when a module
procedure is detected inside an interface block, before bind(C) is
parsed, so that symbol lookup can reach the host scope.
gcc/fortran/ChangeLog:
PR fortran/79330
* decl.cc (gfc_match_subroutine): Set has_import_set when
matching a module procedure inside an interface block.
(gfc_match_function_decl): Likewise.
gcc/testsuite/ChangeLog:
PR fortran/79330
* gfortran.dg/bind_c_module_proc.f90: New test.
The code for reloading the register inside paradoxical subreg is assumed
to require that the subreg is located in more than one hard reg. But the check was
omitted and this resulted in LRA cycling through series of reloads,
secondary memory reloads, and subreg reloads. The patch fixes this.
gcc/ChangeLog:
PR rtl-optimization/124696
* lra-constraints.cc (simplify_operand_subreg): Reload
paradoxical subreg only if it requires more than one hard reg.
* dmd/MERGE: Merge upstream dmd 55e64690bc.
* dmd/VERSION: Bump version to v2.113.0-beta.1.
* d-codegen.cc (d_build_call): Check if argument is already a
TARGET_EXPR.
* decl.cc (DeclVisitor::visit (FuncDeclaration *)): Don't use
`__result' decl as named return value if it's a ref type.
* expr.cc (ExprVisitor::visit (StructLiteralExp *)): Force TARGET_EXPR
if init symbol needs to be mutable.
* runtime.def (ARRAYSETLENGTHT): Remove.
(ARRAYSETLENGTHIT): Remove.
(ARRAYCOPY): Remove.
(ARRAYAPPENDCTX): Remove.
* typeinfo.cc (TypeInfoVisitor::visit (TypeInfoClassDeclaration *)):
Only scan class fields for pointer members.
Jakub Jelinek [Wed, 1 Apr 2026 18:13:23 +0000 (20:13 +0200)]
c++: Implement CWG3124 - Disallow annotations on block-scope externs and non-unique friend declarations
This issue says it is invalid to declare annotations on local externs or
non-defining friends and their arguments (if any).
2026-04-01 Jakub Jelinek <jakub@redhat.com>
* name-lookup.cc (push_local_extern_decl_alias): Diagnose annotations
on local externs and their arguments.
* decl.cc (grokdeclarator): Diagnose annotations on non-defining
friends and their arguments.
Jakub Jelinek [Wed, 1 Apr 2026 17:19:19 +0000 (19:19 +0200)]
c++: Change ^^:: mangling from LDmngE to LDmgsE
In
https://github.com/itanium-cxx-abi/cxx-abi/issues/208#issuecomment-3518384358
Richard Smith suggested (among other things) to use gs instead of ng
for ^^:: mangling, because gs is already used elsewhere in the grammar for
similar purposes (like [gs] nw <expression>* _ <type> E etc.).
This patch changes that, plus added the part I forgot to update when
mangling the annotations.
Note, in
https://github.com/itanium-cxx-abi/cxx-abi/issues/208#issuecomment-3571323241
Tim Song mentioned that perhaps for L Dm ta ... E we should be including
both the <alias prefix> and underlying <type> (probably with some
separation), because different TUs could have different aliases. Or shall
all decls which refer to type aliases be TU local?
2026-04-01 Jakub Jelinek <jakub@redhat.com>
* mangle.cc (write_reflection): Change ^^:: mangling in grammar
from LDmngE to LDmgsE.
* reflect.cc (reflection_mangle_prefix): Set prefix to "gs" rather
than "ng" for global_namespace.
* g++.dg/reflect/mangle1.C: Expect _Z3barILi310ELDmgsEEvv
rather than _Z3barILi310ELDmngEEvv.
Jakub Jelinek [Wed, 1 Apr 2026 17:15:51 +0000 (19:15 +0200)]
libstdc++: Attempt to implement LWG4537 - Improve define_static_array
The following patch attempts to implement
https://cplusplus.github.io/LWG/lwg-active.html#4537
I've also added tests for the returned type.
2026-04-01 Jakub Jelinek <jakub@redhat.com>
* include/std/meta (std::meta::__detail::__statically_sized): New
concept.
(std::meta::define_static_array): Change return type to auto. If
__statically_sized<_Rg>, return span with ranges::size(__r) as
second argument.
* g++.dg/reflect/define_static_array1.C (l): Another variable
with define_static_array test from array<int, 0>.
Add static assertions for types of the define_static_array results.
François Dumont [Mon, 30 Mar 2026 20:18:50 +0000 (22:18 +0200)]
libstdc++: [_GLIBCXX_DEBUG] Fix COW string valid range check
In revision 698a6af5dcbae5d935bcda8a461dea8458c658dc the _GLIBCXX_DEBUG code
for the Library Defect 438 has been removed as starting in C++11 the iterator
type is constrained through the _RequireInputIter requirement.
But the COW basic_string implementation used when _GLIBCXX_USE_CXX11_ABI=0 is
missing the _RequireInputIter constraint on a number of methods resulting in test
failures.
For the moment move the culprit __glibcxx_requires_valid_range call in the COW
basic_string implementation in a method where the iterator type has already been
checked.
libstdc++-v3/ChangeLog:
* include/bits/cow_string.h
(basic_string::replace(iterator, iterator, _InputIte, _InputIte)): Move
__glibcxx_requires_valid_range to...
(basic_string::_M_replace_dispatch(iterator, iterator, _InputIte,
_InputIte, __fase_type)): ...here.
* testsuite/21_strings/basic_string/debug/append_neg.cc: New test case.
* testsuite/21_strings/basic_string/debug/assign_neg.cc: New test case.
* testsuite/21_strings/basic_string/debug/construct_neg.cc: New test case.
* testsuite/21_strings/basic_string/debug/insert_neg.cc: New test case.
* testsuite/21_strings/basic_string/debug/replace_neg.cc: New test case.
Co-authored-by: Jonathan Wakely <jwakely@redhat.com> Reviewed-by: Jonathan Wakely <jwakely@redhat.com>
David Faust [Wed, 1 Apr 2026 16:28:10 +0000 (09:28 -0700)]
MAINTAINERS: Update Qing Zhao email address
Qing has retired from Oracle, and asked me to update her email address
in MAINTAINERS on her behalf, as she temporarily does not have a
machine set up to push to the repo.
Patrick Palka [Wed, 1 Apr 2026 15:34:27 +0000 (11:34 -0400)]
libstdc++/ranges: Inline hidden friends' member function helpers
These helpers were needed to work around GCC's historically strict
interpretation of friendship for hidden friends whereby they did not
inherit the friends of the containing class. But this has been relaxed
in r13-465 which granted hidden friends the same access as any other
member declaration, and <ranges> additions since then rely on this
relaxed interpretation. (Note that Clang also has this relaxed
interpretation, but MSVC / EDG seem to have the strict interpretation.)
This patch removes these now redundant member functions and inlines
their logic directly into the respective friend operators, making
things simpler and more consistent.
libstdc++-v3/ChangeLog:
* include/std/ranges (iota_view::_Sentinel): Remove _M_equal and
_M_distance_from. Inline logic into friend operators.
(basic_istream_view::_Iterator): Remove _M_at_end. Inline logic
into operator==.
(transform_view::_Sentinel): Remove __distance_from and __equal.
Inline logic into friend operators.
(join_view::_Sentinel): Remove __equal. Inline logic into operator==.
(lazy_split_view::_OuterIter): Remove __at_end. Inline logic into
operator==.
(split_view::_Sentinel): Remove _M_equal. Inline logic into operator==.
(elements_view::_Sentinel): Remove _M_equal and _M_distance_from.
Inline logic into friend operators.
gcc/config/s390/s390.cc: In function ‘void print_operand(FILE*, rtx, int)’:
gcc/config/s390/s390.cc:8974:15: warning: format not a string literal and no format arguments [-Wformat-security]
8974 | fprintf (file, s390_branch_condition_mnemonic (x, FALSE));
| ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc/config/s390/s390.cc:8978:15: warning: format not a string literal and no format arguments [-Wformat-security]
8978 | fprintf (file, s390_branch_condition_mnemonic (x, TRUE));
| ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc/ChangeLog:
* config/s390/s390.cc (print_operand): Use fputs instead of
fprintf.
doc: Update docs for character set support and environment variables [PR70917]
The "Environment Variables" section of the GCC manual had
long-obsolete (20+ years!) information about environment variables
affecting character sets and encodings. In particular, GCC stopped
using environment variables to control how input files are parsed
in 2004.
gcc/ChangeLog
PR preprocessor/70917
* doc/invoke.texi (Environment Variables): Clarify that LC_ALL,
LC_CTYPE, LC_MESSAGES, and LANG affect only diagnostics and
informational output from GCC, not the encodings of input and
output files. Remove separate bit-rotten entry for LANG.
Jonathan Wakely [Mon, 30 Mar 2026 11:13:39 +0000 (12:13 +0100)]
libstdc++: Rename std::runtime_format for C++26 (P3953R3)
Last week in Croydon we approved P3953R3 to rename std::runtime_format
for C++26. The rationale is that with compile-time std::format, the name
std::runtime_format doesn't make sense. It's std::dynamic_format now
instead.
libstdc++-v3/ChangeLog:
* include/bits/chrono_io.h (__formatter_chrono::_S_empty_fs)
(__formatter_chrono::_M_C_y_Y, __formatter_chrono::_M_D_x)
(__formatter_chrono::_M_F, __formatter_chrono::_M_subsecs)
(__formatter_chrono_info::_M_format_to): Use
_Dynamic_format_string instead of _Runtime_format_string.
* include/bits/version.def (format): Bump value.
* include/bits/version.h: Regenerate.
* include/std/format (_Runtime_format_string): Rename to
_Dynamic_format_string.
(runtime_format): Rename to dynamic_format.
* include/std/print (println): Adjust comment to refer to
dynamic_format instead of runtime_format.
* testsuite/std/format/runtime_format.cc: Move to...
* testsuite/std/format/dynamic_format.cc: ...here.
Reviewed-by: Tomasz Kamiński <tkaminsk@redhat.com>
Andrew Pinski [Wed, 1 Apr 2026 02:56:00 +0000 (19:56 -0700)]
forwprop: Add missing NULL check on vdef in optimize_aggr_zeroprop [PR124742]
When I converted optimize_aggr_zeroprop into a forward walk instead of
a backward walk, I missed that the vdef of a memset call could be NULL.
This only happens when there is "undefined" declaration of memset exists.
Anyways this fixes the ICE by adding the NULL check and an early out.
Bootstrapped and tested on x86_64-linux-gnu.
PR tree-optimization/124742
gcc/ChangeLog:
* tree-ssa-forwprop.cc (optimize_aggr_zeroprop): Exit
if the vdef on the stmt is NULL.
gcc/testsuite/ChangeLog:
* gcc.dg/torture/pr124742-1.c: New test.
Signed-off-by: Andrew Pinski <andrew.pinski@oss.qualcomm.com>
H.J. Lu [Tue, 31 Mar 2026 15:59:50 +0000 (08:59 -0700)]
Check BIGGEST_ALIGNMENT when forcing a local copy
BIGGEST_ALIGNMENT is the biggest alignment that any data type can require
on the target machine. It is not the biggest alignment that is supported,
just the biggest alignment that, when violated, may cause a fault.
MAX_SUPPORTED_STACK_ALIGNMENT is the maximum stack alignment guaranteed by
the backend. If SUPPORTS_STACK_ALIGNMENT is false, it is defined as
PREFERRED_STACK_BOUNDARY.
Adjust alignment check forcing a local copy if the argument on stack is
not aligned to its type and the current alignment is less than the
minimum of BIGGEST_ALIGNMENT and MAX_SUPPORTED_STACK_ALIGNMENT.
gcc/
PR middle-end/124697
* function.cc (assign_parm_adjust_stack_rtl): Force a local copy
if the current alignment is less than the minimum of
BIGGEST_ALIGNMENT and MAX_SUPPORTED_STACK_ALIGNMENT.
Martin Uecker [Fri, 27 Mar 2026 18:45:42 +0000 (19:45 +0100)]
c: Fix ICE related to field members that are arrays of pointers to structs [PR124635]
We get a checking error in verify_type, because I did not copy
TYPE_REVERSE_STORAGE_ORDER over from the original when reconstructing
derived types during the contruction of canonical types.
Richard Biener [Tue, 31 Mar 2026 17:48:30 +0000 (19:48 +0200)]
middle-end/124634 - add internal function internals documentation section
The following adds documentation for internal function details. I
have populated the internal function tables via macro expansion
of the internal-fn.def file, so it's quite boiler-plate and asks
for manual amending in more complicated places.
Without such a place it's quite difficult to tell people to document
things when they add new internal functions. We might want to split
the table into two, separating direct internal functions from others.
I have added some overall sentences related to internal functions
and builtins but left the API section as a FIXME.
I'm not sure we need a separate index - I have used IFN_ prefixes
which separates them nicely. Removing those would warrant a
separate index.
I've placed the contents after the GENERIC/GIMPLE chapters.
v2: wrap long lines and integrate Sandras changes
Built and inspected using texinfo 7.1.
PR middle-end/124634
* doc/ifn.texi: New file.
* doc/gccint.texi: Include ifn.texi.
* Makefile.in (TEXI_GCCINT_FILES): Add ifn.texi.
doc: Fix wrong documentation for -finput-charset [PR61896]
This patch fixes long-standing bugs in the documentation for
-finput-charset. Support for getting the default charset from the
locale has been disabled since 2004. The error behavior has never been
documented, and now there is -Winvalid-utf8 that should be mentioned
in this context too.
doc: Add copyright notices to .texi files that don't have one
I realized I'd forgotten to add a copyright notice to specs.texi when I
split that from invoke.texi a while back. Scanning the other .texi files
in the same directory, I found poly-int.texi was also missing a copyright.
Both are fixed with this patch.
fortran: Fix ICE in gfc_trans_create_temp_array for assumed-rank [PR100194]
When a non-contiguous assumed-rank actual argument is passed to a
contiguous assumed-rank dummy, the compiler routes it through
gfc_conv_subref_array_arg which uses the scalarizer. The scalarizer
requires known rank at compile time, but assumed-rank arrays have
rank = -1, hitting gcc_assert (ss->dimen > 0).
Skip the scalarizer path for assumed-rank expressions and let them
fall through to gfc_conv_array_parameter, which handles assumed-rank
via the runtime pack/unpack functions.
gcc/fortran/ChangeLog:
PR fortran/100194
* trans-expr.cc (gfc_conv_procedure_call): Skip
gfc_conv_subref_array_arg for assumed-rank actual arguments
(e->rank == -1) when the dummy is contiguous.
gcc/testsuite/ChangeLog:
PR fortran/100194
* gfortran.dg/pr100194.f90: New test.
Signed-off-by: Christopher Albert <albert@tugraz.at>
Jakub Jelinek [Tue, 31 Mar 2026 22:22:46 +0000 (00:22 +0200)]
c++: Fix up access_context::current and current_namespace
On Mon, Mar 30, 2026 at 01:15:07PM +0200, Tomasz Kaminski wrote:
> > auto
> > Q::baz () -> typename [: current_namespace () == ^^Q ? ^^int : ^^:: :]
> > {
> > return 0;
> > }
> > part also fails, there I don't know what's right but possibly it should
> > be in Q; in that case it would be a pre-existing bug already for
> > std::meta::access_context::current () too.
> >
> My reading of the standard may be wrong here.
I think you're right, but because it is a preexisting bug on
access_context, sending this as a separate patch rather than
updating the current_* patch.
2026-04-01 Jakub Jelinek <jakub@redhat.com>
* reflect.cc (reflect_current_scope): Use decl_namespace_list->last ()
in preference to current_namespace.
Jakub Jelinek [Tue, 31 Mar 2026 22:14:04 +0000 (00:14 +0200)]
c++: Handle annotations in data_member_spec/define_aggregate
The following patch attempts to implement another part of P3795R2,
in particular the addition of annotations to data_member_options
and handling it in data_member_spec/define_aggregate etc.
2026-03-31 Jakub Jelinek <jakub@redhat.com>
libstdc++-v3/
* include/std/meta (std::meta::data_member_options): Add annotations
member.
gcc/cp/
* reflect.cc (get_range_elts): If N is negative, just use the tree
as object to extract range from instead of finding Nth argument
of a call.
(eval_is_bit_field, eval_type_of, eval_size_of, eval_alignment_of,
eval_bit_size_of, eval_has_identifier, eval_identifier_of): Adjust
function comments from P3795R2.
(eval_display_string_of): Handle annotations in
REFLECT_DATA_MEMBER_SPEC.
(eval_annotations_of): Adjust function comments from P3795R2.
(eval_data_member_spec): Likewise. Read and diagnose annotations.
(eval_define_aggregate): Adjust function comments from P3795R2.
Create annotations.
(compare_reflections): Compare REFLECT_DATA_MEMBER_SPEC annotations.
* mangle.cc (write_reflection): Mangle REFLECT_DATA_MEMBER_SPEC
annotations.
gcc/testsuite/
* g++.dg/reflect/data_member_spec5.C: New test.
* g++.dg/reflect/data_member_spec6.C: New test.
* g++.dg/reflect/display_string_of1.C: Expect extra ", {}" before
closing paren for empty annotations, otherwise a list of annotations.
* g++.dg/reflect/u8display_string_of1.C: Likewise.
* g++.dg/reflect/define_aggregate9.C: New test.
* g++.dg/reflect/mangle1.C: Test mangling of REFLECT_DATA_MEMBER_SPEC
annotations.
Reviewed-by: Jason Merrill <jason@redhat.com> Reviewed-by: Jonathan Wakely <jwakely@redhat.com>
Jakub Jelinek [Tue, 31 Mar 2026 21:42:38 +0000 (23:42 +0200)]
c++, libstdc++: Implement current_{function,class,namespace} metafn addition from P3795R2
The following patch implements addition of std::meta::current_function,
std::meta::current_class, std::meta::current_namespace metafunctions
from P3795R2 - Miscellaneous Reflection Cleanup paper.
2026-03-31 Jakub Jelinek <jakub@redhat.com>
gcc/cp/
* metafns.gperf (enum metafn_code): Add METAFN_CURRENT_FUNCTION,
METAFN_CURRENT_CLASS and METAFN_CURRENT_NAMESPACE.
(enum metafn_kind): Add METAFN_KIND_INFO_VOID.
(current_function, current_class, current_namespace): New
metafunctions.
* pt.cc (value_dependent_expression_p): Make current_function(),
current_class() and current_namespace() calls dependent if they
are inside of template.
* reflect.cc (reflect_current_scope, eval_current_function,
eval_current_class, eval_current_namespace): New functions.
(eval_access_context_current): Use reflect_current_scope.
(process_metafunction): Handle METAFN_CURRENT_FUNCTION,
METAFN_CURRENT_CLASS and METAFN_CURRENT_NAMESPACE.
* metafns.h: Regenerate.
gcc/testsuite/
* g++.dg/reflect/current_function1.C: New test.
* g++.dg/reflect/current_function2.C: New test.
* g++.dg/reflect/current_class1.C: New test.
* g++.dg/reflect/current_class2.C: New test.
* g++.dg/reflect/current_namespace1.C: New test.
libstdc++-v3/
* include/std/meta (std::meta::current_function,
std::meta::current_class, std::meta::current_namespace): New
declarations.
* src/c++23/std.cc.in: Export those 3.
Reviewed-by: Jason Merrill <jason@redhat.com> Reviewed-by: Jonathan Wakely <jwakely@redhat.com>
Jakub Jelinek [Tue, 31 Mar 2026 21:38:11 +0000 (23:38 +0200)]
c++: Use anon enums in eval_data_member_spec
On Mon, Mar 30, 2026 at 03:46:57PM -0400, Jason Merrill wrote:
> Maybe it would be helpful to have local enums to name the indices in args?
Here is incremental patch to use local enums for those.
Tested on x86_64-linux, ok for trunk (it conflicts with the annotations
addition patch, but it can be easily resolved)?
2026-03-31 Jakub Jelinek <jakub@redhat.com>
* reflect.cc (eval_data_member_spec): Add anonymous enums for
fields in std::meta::data_member_options and
std::meta::data_member_options::_Name and use them instead of
hardcoded constants.
Dimitar Dimitrov [Sat, 28 Mar 2026 09:19:00 +0000 (11:19 +0200)]
testsuite: Require effective target fstack_protector for pr124041.c
Fix this spurious error on targets without stack protection ability:
FAIL: gcc.dg/torture/pr124041.c -O0 (test for excess errors)
Excess errors:
cc1: warning: '-fstack-protector' not supported for this target
Dimitar Dimitrov [Sun, 22 Mar 2026 09:12:09 +0000 (11:12 +0200)]
testsuite: Require int32plus effective target for pr122925.c
The test case logic relies on the constant literal -4 being promoted to
32-bit int. But on AVR and other targets with 16-bit int types, the
literal is promoted to 16-bit int, which changes the expression value
and ultimately failing the test:
FAIL: gcc.dg/pr122925.c execution test
Fix by requiring an effective target with at least 32-bit ints.
Eric Botcazou [Tue, 31 Mar 2026 16:42:19 +0000 (18:42 +0200)]
Fix internal error on non-byte-sized reference in GIMPLE DSE
This is a regression present on all the active branches and a sibling of:
https://gcc.gnu.org/pipermail/gcc-patches/2024-February/646628.html
during GIMPLE pass: dse
+===========================GNAT BUG DETECTED==============================+
| 16.0.1 20260331 (experimental) [master r16-8354-gbf6989de817] GCC error:|
| in exact_div, at poly-int.h:2179 |
| Error detected around opt107.adb:26:11 |
| Compiling opt107.adb
At least one caller of compute_trims, namely maybe_trim_constructor_store,
expects ref->size to be a multiple of a byte for trimming, and that is most
probably the case for others in practice, from a cursory reading. Therefore
the patch adds the same test on ref->size as the one added to ref->offset.
gcc/
* tree-ssa-dse.cc (compute_trims): Bail out if ref->size is not
byte aligned either.
gcc/testsuite/
* gnat.dg/opt107.adb: New test.
* gnat.dg/opt107_pkg.ads: New helper.
The gcc.dg/analyzer/null-deref-pr123981-1.c test FAILs on 64-bit x86
targets with -m32:
FAIL: gcc.dg/analyzer/null-deref-pr123981-1.c (test for excess errors)
gcc.dg/analyzer/null-deref-pr123981-1.c:10:3: error: implicit declaration of function '_writegsbase_u64' [-Wimplicit-function-declaration]
gcc.dg/analyzer/null-deref-pr123981-1.c:10:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
As always, restricting x86 tests by target triplet is wrong: instead of
target x86_64-*-* this needs to be x86 && lp64.
Tested on amd64-pc-solaris2.11, i386-pc-solaris2.11, and
x86_64-pc-linux-gnu.
Mikael Morin [Tue, 31 Mar 2026 13:34:29 +0000 (15:34 +0200)]
fortran: Give up reference factoring in case of shared tree [PR124661]
When we are about to create a variable to factor a subreference of an
array descriptor, check whether that subreference is shared with some of
the preliminary code and abort the factoring in that case.
In the example from the PR, the preliminary code contained bounds
checking code and the replacement of the subreferences by fresh
variables was causing those variables to be used before they were
defined in that bounds checking code.
PR fortran/121185
PR fortran/124661
gcc/fortran/ChangeLog:
* trans-array.cc (maybe_save_ref): New wrapper function around
save ref.
(set_factored_descriptor_value): Use the new wrapper function.
Add argument PRELIMINARY_CODE.
(gfc_conv_ss_descriptor): Update caller.
H.J. Lu [Sun, 29 Mar 2026 21:30:28 +0000 (14:30 -0700)]
x86: Call ix86_access_stack_p only for larger alignment
ix86_access_stack_p can be quite expensive. Don't check symbolic constant
load. Instead, call ix86_access_stack_p only if an INSN needs alignment
> stack alignment. This reduces the compile time of PR target/124684 from
185 seconds to 24 seconds. The compile time of PR target/124165 test is
unchanged.
PR target/124165
PR target/124684
* config/i386/i386.cc (ix86_symbolic_const_load_p_1): Renamed to
...
(ix86_need_alignment_p_1): This.
(ix86_symbolic_const_load_p): Renamed to ...
(ix86_need_alignment_p): This.
(ix86_find_max_used_stack_alignment): Call ix86_access_stack_p
only if the INSN needs alignment > stack alignment.
This patch incorporates changes to this file in Binutils
since October 2025. This file includes the new system
registers in the 2025 architecture extensions.
gcc/ChangeLog:
* config/aarch64/aarch64-sys-regs.def: Copy from Binutils.
Eric Botcazou [Tue, 31 Mar 2026 07:50:11 +0000 (09:50 +0200)]
Ada: Fix compiler crash on nested reduce attribute
This plugs a loophole in the resolution of reduction expressions, which
currently cannot be resolved when their immediate context is ambiguous,
for example in the case of a reduction expression nested in another one.
gcc/ada/
* sem_attr.adb (Analyze_Attribute) <Attribute_Reduce>: Rewrite the
analysis of a non-overloaded reducer. Moreover, when both actuals
are overloaded, compute the set of possible interpretations.
(Resolve_Attribute) <Attribute_Reduce>: Streamline the processing.
Jakub Jelinek [Tue, 31 Mar 2026 08:16:14 +0000 (10:16 +0200)]
c++: Fix up eval_data_member_spec
Ivan Lazaric reported privately a bug in eval_data_member_spec,
which I think can't be easily tested.
This is preceded by
if (!cpp_translate_string (parse_in, &istr, &ostr,
j == 2 ? CPP_STRING : CPP_UTF8STRING,
true))
so for j == 2 it does reverse conversion from -fnarrow-character-set= to
SOURCE_CHARSET (typically UTF-8) and otherwise (j == 1) from
UTF-8 to SOURCE_CHARSET, but the messages of exceptions were reversed.
Now, unless SOURCE_CHARSET is UTF-EBCDIC on s390x-tpf (dunno if that works
at all, but in theory could) and there is some character only in UTF-8 and
not in UTF-EBCDIC, or there is some narrow character set supported by iconv
which has characters not represented in UTF-8 (am not aware of those),
then cpp_translate_string shouldn't fail, so the code in there is just
for a theoretical case.
2026-03-31 Jakub Jelinek <jakub@redhat.com>
* reflect.cc (eval_data_member_spec): Fix up check for diagnostics
when reverse conversion fails.
Alexandre Oliva [Tue, 31 Mar 2026 00:58:19 +0000 (21:58 -0300)]
testsuite: x86: move alias-checks.C into vect
g++.dg/alias-checks.C requires vect_double outside vect.exp, where
-msse2 would have got enabled, but that effective_target is not
supposed to be used in such circumstances: it passes even when SSE2 is
disabled. Without enabling SSE2, vectors of doubles aren't really
available, so we don't get the expected vectorizations and the test
fails.
Instead of adding machine-specific options to alias-checks.C, I'm
moving it under g++.dg/vect/ and renaming it so that it gets, and
doesn't override, the default vector options for each platform.
Alexandre Oliva [Tue, 31 Mar 2026 00:58:01 +0000 (21:58 -0300)]
testsuite: x86: bump unroll insn limit for pr83403-*.c
Like rv32 and other targets, pr83403-[12].c need to bump
max-completely-peeled-insns to get the loops unrolled on x86 without
sse2 so as to enable the expected store motions.
for gcc/testsuite/ChangeLog
* gcc.dg/tree-ssa/pr83403-1.c: Bump
max-completely-peeled-insns on x86.
* gcc.dg/tree-ssa/pr83403-2.c: Likewise.
Alexandre Oliva [Tue, 31 Mar 2026 00:57:56 +0000 (21:57 -0300)]
testsuite: select -mfpmath=sse for pr32964.c on x86
When using the 387 FPU, we don't perform the expected optimization of
unions to floats. Setting -fexcess-precision=standard. doesn't fix it
for x86, but selecting -mfpmath=sse and forcing sse enabled does.
for gcc/testsuite/ChangeLog
* gcc.dg/tree-ssa/pr32964.c: Select the SSE FPU on x86.
Alexandre Oliva [Tue, 31 Mar 2026 00:57:48 +0000 (21:57 -0300)]
testsuite: drop loop optimizations in fstack-protector-strong.c
gcc.dg/fstack-protector-strong.c used to expect one stack_chk_fail per
function. When vectorizer improvements caused foo2 to get vectorized
to the point of enabling the loop and the automatic array-containing
data structure to be optimized away entirely, it no longer required
stack protection, and the expected pattern count was decreased.
However, on platforms that don't or can't vectorize the loop, it isn't
optimized away, and then we find the wrong pattern count.
Reverse the decrease and disable optimizations of the loop that could
cause it to be optimized out, so that we get the originally-expected
stack protection everywhere.
Alexandre Oliva [Tue, 31 Mar 2026 00:57:44 +0000 (21:57 -0300)]
testsuite: x86: pr115863-1.c should include stdint.h
stdint-gcc.h isn't necessarily installed by GCC or available from C
libraries. VxWorks ports don't generally have such a header
available. Include stdint.h instead.
Alexandre Oliva [Tue, 31 Mar 2026 00:57:34 +0000 (21:57 -0300)]
testsuite: analyzer: drop stderr from deref-before-check-2.c
On some VxWorks targets, stderr is #defined to a function call, and
this confuses the analyzer in test_1, so we skip the warning. That
appears to reveal a bug in the analyzer, but it doesn't seem to be
what the test was meant to test, so I'm dropping this unintended
feature from this testcase and filing PR124672 with a testcase to
reproduce it elsewhere.
for gcc/testsuite/ChangeLog
* c-c++-common/analyzer/deref-before-check-2.c (test_1):
Drop stderr.
H.J. Lu [Fri, 27 Jun 2025 22:27:25 +0000 (06:27 +0800)]
Adjust check for addressable misaligned stack argument
Adjust alignment check forcing a local copy if the argument on stack is
not aligned to its type and the current alignment, which is determined
by the backend, is less than MAX_SUPPORTED_STACK_ALIGNMENT when the
parameter has its address taken.
For x86, ignore argument passed on stack when updating stack alignment
since caller is responsible to align the outgoing stack for arguments
passed on stack.
gcc/
PR target/120839
PR middle-end/124671
* function.cc (assign_parm_adjust_stack_rtl): Get the parameter
as argument. Adjust alignment check forcing a local copy.
(assign_parms): Adjust.
* config/i386/i386.cc (ix86_argument_passed_on_stack_p): New.
(ix86_update_stack_alignment): Ignore argument passed on stack.
Jerry DeLisle [Mon, 30 Mar 2026 17:40:43 +0000 (10:40 -0700)]
fortran: Fix several issues with INQUIRE and unconnected units.
PR libfortran/124543
libgfortran/ChangeLog:
* io/inquire.c (inquire_via_unit): Fix return value for
NAMED. Add check for ACTION. Fix return values for
ENCODING, PENDING, READ, WRITE, READWRITE.
(inquire_via_filename): Add checks for ACTION, DELIM,
ASYNCHRONOUS, and PENDING. Fix return value for
ENCODING.
* io/unix.c (inquire_access): Change return value from no
to unknown.
Vineet Gupta [Mon, 30 Mar 2026 20:15:04 +0000 (13:15 -0700)]
bpf: md: Enable zero_extend{hi,qi}di2 to generate wN regs ...
... by adjusting the asm template reg string to 'W', similar to commit
gbd275e81812c for zero_extendsidi2. However unlike that change, this is
not a bug fix: zero_extendsidi2 relies on wN reg move to achieve the
32->64 semantics. A {8,16}->64 extension needs to be emulated anyways
by masking out extra bits so the reg used is not important.
However wN reg based codegen is still preferable in general:
- It is easier on verifier as it has to track fewer bits and avoids
corner case false positives.
- Better native codegen as upper bits are guaranteed to be zero and can
leverage target ISA mechanisms to achieve that mostly for free.
- Better native codegen on 32-bit targets which need to use 2 regs for
rN regs.
gcc/ChangeLog:
* config/bpf/bpf.md (zero_extendhidi2): Add alternates for
alu32 and use 'W' for reg operands.
(zero_extendqidi2): Ditto.
gcc/testsuite/ChangeLog:
* gcc.target/bpf/zero-ext.c: Add tests for {HI,QI}mode values.
Piyush Raj [Tue, 24 Feb 2026 20:17:54 +0000 (01:47 +0530)]
testsuite: bpf: Add initial BPF runtime tests
This patch adds runtime tests for BPF target.
These tests are based on existing compile-time tests and depends on
bpf.exp baseboard
To run the testsuite:
make check-gcc RUNTESTFLAGS="--target_board=bpf-vmtest bpf-torture.exp KERNEL_VERSION=6.15 LOG_LEVEL=ERROR"
Options:
KERNEL_VERSION (default: 6.15)
LOG_LEVEL (default: ERROR)
Note: VMTEST_DIR must be set in the environment.
See the bpf-vmtest-tool README for details.
gcc/testsuite/ChangeLog:
* gcc.target/bpf/torture/bpf-torture.exp: New testsuite.
* gcc.target/bpf/torture/invalid-memory-access.c: New test.
* gcc.target/bpf/torture/memcpy.c: New test.
* gcc.target/bpf/torture/memmove.c: New test.
* gcc.target/bpf/torture/memset.c: New test.
* gcc.target/bpf/torture/naked.c: New test.
* gcc.target/bpf/torture/nop.c: New test.
* gcc.target/bpf/torture/trace_openat.c: New test.
Richard Biener [Mon, 30 Mar 2026 12:30:45 +0000 (14:30 +0200)]
tree-optimization/124692 - update stmt before folding
The following makes sure SSA operands are up-to-date before folding.
Esp. when replace_uses_by is invoked from SCEV cprop which now has
ranger enabled we can otherwise end up ICEing where purpoted SSA
names now are constants. This follows what forwprop does.
PR tree-optimization/124692
* tree-cfg.cc (replace_uses_by): Call update_stmt after
substitution and before folding.
fortran: Fix free-form mixed OpenACC/OpenMP continuation state
Clear the opposite directive flag only for fresh free-form OpenMP/OpenACC
sentinel lines so continued directives do not leak OpenACC/OpenMP state into
the next independent directive.
PR fortran/108382
gcc/fortran/ChangeLog:
* scanner.cc (skip_free_oacc_sentinel): Clear openmp_flag only for
fresh OpenACC directive lines.
(skip_free_omp_sentinel): Clear openacc_flag only for fresh OpenMP
directive lines.
gcc/testsuite/ChangeLog:
* gfortran.dg/goacc/omp-108382.f90: New test.
Signed-off-by: Christopher Albert <albert@tugraz.at>
The values for chip IDs and the LITTLE.big variants have been confirmed
in the XNU sources (xnu/osfmk/arm/cpuid.h).
gcc/ChangeLog:
* config/aarch64/aarch64-cores.def (AARCH64_CORE): Add Apple M5
cores.
* config/aarch64/aarch64-tune.md: Regenerate.
* doc/invoke.texi: Add apple-m5 core to the ones listed
for arch and tune selections.
projects / thirdparty / gcc.git / log
