Paul Eggert [Fri, 19 Jun 2026 17:07:47 +0000 (10:07 -0700)]
fstatat: don’t mess with CFLAGS
* m4/fstatat.m4 (gl_FUNC_FSTATAT): Remove stray code left
over from an aborted attempt to mess with CFLAGS.
Problem reported by Bruno Haible in:
https://lists.gnu.org/r/bug-gnulib/2026-06/msg00084.html
Paul Eggert [Fri, 19 Jun 2026 16:27:30 +0000 (09:27 -0700)]
openat2-tests: port to NFS
* tests/test-openat2.c (do_test_basic): Close fd before
removing its file. This fixes a file descriptor leak,
and ports the test to NFS, where removing an unclosed
file leaves behind a .nfs* file that prevents the
parent directory from being removed.
Paul Eggert [Fri, 19 Jun 2026 16:17:04 +0000 (09:17 -0700)]
openat2: fix typo for circa-2012 Linux
* lib/openat2.c (dirstat) [FSTAT_O_PATH_BUG]: Fix typo (a missing
arg) in workaround for this bug in Linux kernel 2.6.39 (2011)
through 3.5.7 (2012). Evidently nobody compiles on these old
platforms, but we might as well fix the code if we’re going to
have it at all.
Paul Eggert [Thu, 18 Jun 2026 20:33:58 +0000 (13:33 -0700)]
fstatat: support NULL if AT_EMPTY_PATH
On platforms that define AT_EMPTY_PATH, allow a null pointer to be
passed as a file name. This is GNU behavior as of glibc 2.41 +
Linux kernel 6.11, and can be supported on older kernels, older
glibcs, and on recent FreeBSD and z/OS.
* lib/fstatat.c (rpl_fstatat): Support AT_EMPTY_PATH,
if it exists, on null pointers.
* m4/fstatat.m4 (gl_FUNC_FSTATAT): Replace fstatat if
AT_EMPTY_PATH is defined but does not work on null pointers.
Also, define HAVE_WORKING_FSTATAT_ZERO_FLAG, if it is discovered,
regardless of whether replacing fstatat. This refactoring makes
config.h a bit less confusing.
* tests/test-fstatat.c (main): Test AT_EMPTY_PATH if defined.
Paul Eggert [Thu, 18 Jun 2026 16:29:15 +0000 (09:29 -0700)]
fchmodat: fix AT_FDCWD + AT_EMPTY_PATH
* lib/fchmodat.c (fchmodat): When following symlinks and with
AT_FDCWD and an empty filename, don’t use fchmod as it will fail.
Instead, fall back on the usual orig_fchmodat call, as this does
the right thing if AT_EMPTY_PATH support is present there.
Using chmod (".", ...) wouldn’t be quite right here, as it would
go awry if the working directory is not searchable.
Problem reported by Bruno Haible in:
https://lists.gnu.org/r/bug-gnulib/2026-06/msg00068.html
Paul Eggert [Wed, 17 Jun 2026 07:19:35 +0000 (00:19 -0700)]
openat2: fix bug with trailing "/./"
Problem reported by Kinan Al-Falakh in:
https://lists.gnu.org/r/bug-gnulib/2026-06/msg00070.html
* lib/openat2.c (do_openat2): When opening a dotlike component at
file name end, also set the G and H indexes appropriately for ".".
This matters if the file name ends in something like "/./" so the
last component "." is not at file name end.
* tests/test-openat2.c (do_test_resolve): Test for the bug.
Paul Eggert [Wed, 17 Jun 2026 06:59:47 +0000 (23:59 -0700)]
openat2: set HAVE_OPENAT2=0 if openat2 is missing
* m4/openat2.m4 (gl_FUNC_OPENAT2): The recent ‘fcntl-h: glibc now
has openat2’ patch changed HAVE_OPENAT2’s default to 1. Adjust to
this here by setting it to 0 when openat2 is not found, rather than
setting it to 1 when it is found.
Paul Eggert [Tue, 16 Jun 2026 16:46:20 +0000 (09:46 -0700)]
fchownat: don’t mishandle AT_EMPTY_PATH
This has the same motivation as the recent fchmodat change.
* lib/fchownat.c (AT_EMPTY_PATH): Default to 0.
(FCHOWNAT_EMPTY_FILENAME_BUG): Remove; no longer needed.
(rpl_fchownat): Do not mishandle AT_EMPTY_PATH if specified
and if the underlying library+kernel supports it.
* m4/fchownat.m4 (gl_FUNC_FCHOWNAT):
Don’t define FCHOWNAT_EMPTY_FILENAME_BUG, as it is no longer needed.
Paul Eggert [Tue, 16 Jun 2026 16:46:03 +0000 (09:46 -0700)]
fchmodat: don’t mishandle AT_EMPTY_PATH
This does not add support for AT_EMPTY_PATH on platforms lacking it.
It merely fixes bugs in handling AT_EMPTY_PATH on platforms
that already have AT_EMPTY_PATH. This is complicated by
the fact that glibc may define AT_EMPTY_PATH even though the
underlying kernel lacks support for it, and by the fact that
in recent kernels, AT_EMPTY_PATH allows the file name to be
a null pointer.
* lib/fchmodat.c (AT_EMPTY_PATH): Default to 0.
(rpl_fchmodat): Do not mishandle AT_EMPTY_PATH if specified
and if the underlying library+kernel supports it.
Paul Eggert [Tue, 16 Jun 2026 16:45:39 +0000 (09:45 -0700)]
fstatat etc.: fix wrong machine code for calls
Without this fix, compilers can generate incorrect machine code
for functions that call to fstatat-like functions, as the
compilers incorrectly assume that the calls’ arguments cannot be
null pointers. This assumption became false with the release of
Linux kernel 6.11 (2024).
* lib/sys_stat.in.h (fchmodat, fstatat, utimensat):
* lib/unistd.in.h (faccessat, fchownat): Do not mark file args
with _GL_ARG_NONNULL, as the args are allowed to be null pointers
in Linux kernel 6.11+, possibly with glibc 2.41+ involved.
Paul Eggert [Tue, 16 Jun 2026 16:44:54 +0000 (09:44 -0700)]
faccessat: support "" and NULL file
* lib/faccessat.c (LSTAT_FOLLOWS_SLASHED_SYMLINK): Default to 0.
(rpl_faccessat): Don’t mishandle empty string, or null pointer for
that matter. Also, do not call fstatat if
LSTAT_FOLLOWS_SLASHED_SYMLINK, as there is no need in that case.
Collin Funk [Tue, 16 Jun 2026 02:36:06 +0000 (19:36 -0700)]
xstrtol tests: Fix link error on FreeBSD and macOS (regr. 2026-06-13).
* modules/xstrtol-tests (Makefile.am): Link the test programs to
$(LIBUNISTRING), $(MBRTOWC_LIB), and $(LIBC32CONV).
* modules/xstrtoimax-tests (Makefile.am): Likewise.
* modules/xstrtoumax-tests (Makefile.am): Likewise.
* modules/xstrtoll-tests (Makefile.am): Likewise. Use @LIBINTL@ instead
of $(LIBINTL).
Bruno Haible [Mon, 8 Jun 2026 10:57:03 +0000 (12:57 +0200)]
localeconv: Detect invalid writes to the returned struct in some cases.
* lib/locale.in.h (localeconv): Change the return type to
'const struct lconv *'.
(GNULIB_defined_localeconv): New macro.
* lib/localeconv.c (localeconv): Change the return type to
'const struct lconv *'. Change a variable from 'struct lconv *' to
'const struct lconv *'.
* doc/posix-functions/localeconv.texi: Document that Gnulib uses the
return type 'const struct lconv *'.
* NEWS: Mention the change.
* m4/localeconv.m4 (gl_FUNC_LOCALECONV): Change a variable from
'struct lconv *' to 'const struct lconv *'.
* tests/test-localeconv.c (localeconv): Update expected signature.
(main): Change a variable from 'struct lconv *' to
'const struct lconv *'.
* tests/test-locale-h-c++.cc (GNULIB_NAMESPACE::localeconv): Update
expected signature.
Bruno Haible [Sun, 7 Jun 2026 12:57:38 +0000 (14:57 +0200)]
setlocale: Detect invalid writes to the returned string in some cases.
* lib/locale.in.h (setlocale): Change the return type to 'const char *'.
* lib/setlocale.c (setlocale_mtsafe, setlocale_unixlike): Change the
return type to 'const char *'. Remove a cast.
(setlocale_single): Change the return type to 'const char *'.
(setlocale_improved): Change the return type to 'const char *'. Change
three variables from 'char *' to 'const char *'. Add local variable
old_locale.
* lib/localcharset.c (locale_charset): Change two variables from
'char *' to 'const char *'.
* doc/posix-functions/setlocale.texi: Document that Gnulib uses the
return type 'const char *'.
* NEWS: Mention the change.
* m4/mbrtowc.m4 (gl_MBRTOWC_C_LOCALE): Change a variable from 'char *'
to 'const char *'.
* m4/mbrtoc32.m4 (gl_MBRTOC32_C_LOCALE, gl_MBRTOC32_UTF8_LOCALE):
Likewise.
* m4/mbrtoc16.m4 (gl_MBRTOC16_C_LOCALE): Likewise.
* tests/test-setlocale-w32utf8.c (main): Likewise.
* tests/test-setlocale1.c (setlocale): Update expected signature.
* tests/test-locale-h-c++.cc (GNULIB_NAMESPACE::setlocale): Likewise.
Bruno Haible [Sun, 7 Jun 2026 10:27:28 +0000 (12:27 +0200)]
intprops, stdbit-h: Fix error on MSVC in C++ mode (regr. 2024-12-19).
* lib/intprops-internal.h (_GL_HAVE___TYPEOF__): Set to 0 on MSVC in
C++ mode.
* lib/stdbit.in.h (_GL_STDBIT_TYPEOF_CAST): Don't use __typeof__ on MSVC
in C++ mode.
Bruno Haible [Tue, 2 Jun 2026 20:17:38 +0000 (22:17 +0200)]
mbrtowc: Work around a NetBSD bug in UTF-8 locales, part 2.
* m4/mbsrtowcs.m4 (gl_FUNC_MBSRTOWCS): Also set REPLACE_MBSRTOWCS
to 1 if gl_MBRTOWC_INVALID_UTF8 reports "no".
* m4/mbsnrtowcs.m4 (gl_FUNC_MBSNRTOWCS): Also set REPLACE_MBSNRTOWCS
to 1 if gl_MBRTOWC_INVALID_UTF8 reports "no".
Bruno Haible [Tue, 2 Jun 2026 11:13:20 +0000 (13:13 +0200)]
mbrtowc, mbrlen: Work around a NetBSD bug in UTF-8 locales.
* m4/mbrtowc.m4 (gl_MBRTOWC_INVALID_UTF8): New macro.
(gl_FUNC_MBRTOWC): Invoke it. Define MBRTOWC_INVALID_UTF8_BUG if mbrtowc
does not recognize some invalid UTF-8 byte sequences.
* lib/mbrtowc.c (is_locale_utf8, is_locale_utf8_cached): Define also if
MBRTOWC_INVALID_UTF8_BUG.
(rpl_mbrtowc): Handle UTF-8 locales specially also on NetBSD.
* tests/test-mbrtowc.c (main): Add more test cases for the UTF-8
encoding.
* tests/test-mbrlen.c (main): Likewise.
* doc/posix-functions/mbrtowc.texi: Mention the NetBSD bug.
* doc/posix-functions/mbrlen.texi: Likewise.
Paul Eggert [Sun, 31 May 2026 07:32:30 +0000 (00:32 -0700)]
quotearg: remove SIZE_MAX, INT_BITS
This is a minor cleanup, as quotearg can assume
* modules/quotearg (Depends-on): Add limits-h.
* lib/quotearg.c (SIZE_MAX): Remove; <stdint.h> defines this now.
(INT_BITS): Remove. All uses replaced by UINT_WIDTH,
which <limits.h> defines.
Paul Eggert [Sun, 31 May 2026 04:57:03 +0000 (21:57 -0700)]
quotearg: escape C1 codes in C locale
Problem reported by Lasse Collin <https://bugs.gnu.org/81135#29>.
For lib/quotearg.c, m4/quotearg.m4 and modules/quotearg,
go back to the old way of doing things, without the recently-added
USE_C_LOCALE stuff. Then make the following changes instead:
* lib/quotearg.c [_QUOTEARG_AVOID_UCHAR_H]: Don’t include <uchar.h>.
(mbrto2c, mbstate_t) [_QUOTEARG_AVOID_UCHAR_H && defined __UCLIBC__
&& !defined __UCLIBC_HAS_WCHAR__]: New macros.
Also, don’t include <wchar.h> or <wctype.h>.
(char32_t, c32isprint, mbrtoc32, GNULIB_MBRTOC32_REGULAR)
[_QUOTEARG_AVOID_UCHAR_H]: New macros.
(mbszero) [!GNULIB_defined_mbszero]: New macro.
Paul Eggert [Fri, 29 May 2026 20:56:42 +0000 (13:56 -0700)]
quotearg: improve USE_C_LOCALE + UTF-8
Problem reported by Bruno Haible <https://bugs.gnu.org/81135>.
* lib/quotearg.c (chisprint, wchisprint) [USE_C_LOCALE]:
Treat unassigned characters as printable.
Paul Eggert [Tue, 26 May 2026 00:08:48 +0000 (17:08 -0700)]
quotearg: be nicer on macOS etc
Problem reported by Bruno Haible in:
https://lists.gnu.org/r/bug-gnulib/2026-05/msg00150.html
* lib/quotearg.c (C_LOCALE_MIGHT_BE_MULTIBYTE): New macro.
(wch, mbstate, mbs_clear, mbrtowch, chisprint, wchisprint
(quotearg_buffer_restyled): Fall back on <wchar.h> and <wctype.h>
functions if USE_C_LOCALE and C_LOCALE_MIGHT_BE_MULTIBYTE.
Bruno Haible [Mon, 25 May 2026 23:29:29 +0000 (01:29 +0200)]
mbuiterf: Implement multi-byte per encoding error (MEE) consistently.
* lib/mbuiterf.h: Include mbiter-aux.h.
(struct mbuif_state): Add field is_utf8.
(mbuiterf_next): Invoke mbiter_is_utf8, mbiter_utf8_maximal_subpart.
(mbuif_init): Initialize the field is_utf8.
* modules/mbuiterf (Depends-on): Add mbiter-aux.
* tests/test-mbslen.c (OR): New macro, copied from
tests/test-mbsnlen.c.
(main): Add more test cases with incomplete characters.
* tests/test-mbschr2.sh: Renamed from tests/test-mbschr.sh.
* tests/test-mbschr2.c: Renamed from tests/test-mbschr.c.
* tests/test-mbschr1.sh: New file, based on
tests/test-mbmemcasecmp-3.sh.
* tests/test-mbschr1.c: New file.
* modules/mbschr-tests (Files): Update accordingly. Add locale-en.m4,
locale-fr.m4.
(configure.ac): Invoke gt_LOCALE_EN_UTF8, gt_LOCALE_FR_UTF8.
(Makefile.am): Arrange to compile test-mbschr1 and test-mbschr2 and to
run test-mbschr1.sh, test-mbschr2.sh.
* tests/test-mbsrchr2.sh: Renamed from tests/test-mbsrchr.sh.
* tests/test-mbsrchr2.c: Renamed from tests/test-mbsrchr.c.
* tests/test-mbsrchr1.sh: New file, based on
tests/test-mbmemcasecmp-3.sh.
* tests/test-mbsrchr1.c: New file.
* modules/mbsrchr-tests (Files): Update accordingly. Add locale-en.m4,
locale-fr.m4.
(configure.ac): Invoke gt_LOCALE_EN_UTF8, gt_LOCALE_FR_UTF8.
(Makefile.am): Arrange to compile test-mbsrchr1 and test-mbsrchr2 and to
run test-mbsrchr1.sh, test-mbsrchr2.sh.
* tests/test-mbscspn.c (OR): New macro, copied from
tests/test-mbsnlen.c.
(main): Add test cases with incomplete characters.
* tests/test-mbspbrk.c (OR): New macro, copied from
tests/test-mbsnlen.c.
(main): Add test cases with incomplete characters.
* tests/test-mbsspn.c (OR): New macro, copied from
tests/test-mbsnlen.c.
(main): Add test cases with incomplete characters.
Bruno Haible [Mon, 25 May 2026 22:42:39 +0000 (00:42 +0200)]
mbiterf: Implement multi-byte per encoding error (MEE) consistently.
* lib/mbiterf.h: Include mbiter-aux.h.
(struct mbif_state): Add field is_utf8.
(mbiterf_next): Invoke mbiter_is_utf8, mbiter_utf8_maximal_subpart.
(mbif_init): Initialize the field is_utf8.
* modules/mbiterf (Depends-on): Add mbiter-aux.
* tests/test-mbsnlen.c (main): Add test cases with incomplete characters
not at the end of the string.
Bruno Haible [Mon, 25 May 2026 17:06:55 +0000 (19:06 +0200)]
mbiter: Implement multi-byte per encoding error consistently.
* lib/mbiter.h: Include mbiter-aux.h.
(struct mbiter_multi): Add field is_utf8.
(mbiter_multi_next): Invoke mbiter_is_utf8, mbiter_utf8_maximal_subpart.
(mbi_init): Initialize the field is_utf8.
* modules/mbiter (Depends-on): Add mbiter-aux.
* tests/test-mbs_startswith2.c (main): Add test cases with incomplete
characters not at the end of the string.
* tests/test-mbs_endswith2.c (OR): New macro, copied from
tests/test-mbsnlen.c.
(main): Add test cases with incomplete characters not at the end of the
string.
Paul Eggert [Mon, 25 May 2026 21:30:05 +0000 (14:30 -0700)]
quotearg: support USE_C_LOCALE variant
This is for gzip, which does not use setlocale,
but does need to quote file names.
* lib/quotearg.c (USE_C_LOCALE): Default to 0. If set, include
c-ctype.h instead of ctype.h, gettext.h, uchar.h, wchar.h; and
define _ to be an identity macro.
(wch, mbstate): New types.
(mbs_clear, mbrtowch, wchisprint, chisprint): New functions.
(gettext_quote, quotearg_buffer_restyled): Use them.
Paul Eggert [Mon, 25 May 2026 18:32:32 +0000 (11:32 -0700)]
quotearg: lessen dependencies
* lib/quotearg.c: Do not include c-strcaseeq.h, as its
macros are no longer used here.
* modules/quotearg (Depends-on): Remove c-strcaseeq.
Also remove memcmp, since the code no longer uses memcmp.
Bruno Haible [Mon, 25 May 2026 16:32:18 +0000 (18:32 +0200)]
mbspcasecmp tests: Enhance tests.
* tests/test-mbspcasecmp.c (test_ascii): New function, extracted from
main.
(test_utf_8): Likewise. Add test cases with incomplete characters.
(main): Invoke them. Accept a numeric argument.
* tests/test-mbspcasecmp-4.sh: Renamed from tests/test-mbspcasecmp.sh.
* tests/test-mbspcasecmp-3.sh: New file, based on
tests/test-mbmemcasecmp-3.sh.
* modules/mbspcasecmp-tests (Files): Update after rename. Add
locale-en.m4, locale-fr.m4.
(configure.ac): Invoke gt_LOCALE_EN_UTF8, gt_LOCALE_FR_UTF8.
(Makefile.am): Arrange to run test-mbspcasecmp-3.sh,
test-mbspcasecmp-4.sh, instead of test-mbspcasecmp.sh.
Bruno Haible [Mon, 25 May 2026 16:27:18 +0000 (18:27 +0200)]
mbsncasecmp tests: Enhance tests.
* tests/test-mbsncasecmp.c (test_ascii): New function, extracted from
main.
(test_utf_8): Likewise. Add test cases with incomplete characters.
(main): Invoke them. Accept a numeric argument.
* tests/test-mbsncasecmp-4.sh: Renamed from tests/test-mbsncasecmp.sh.
* tests/test-mbsncasecmp-3.sh: New file, based on
tests/test-mbmemcasecmp-3.sh.
* modules/mbsncasecmp-tests (Files): Update after rename. Add
locale-en.m4, locale-fr.m4.
(configure.ac): Invoke gt_LOCALE_EN_UTF8, gt_LOCALE_FR_UTF8.
(Makefile.am): Arrange to run test-mbsncasecmp-3.sh,
test-mbsncasecmp-4.sh, instead of test-mbsncasecmp.sh.
Bruno Haible [Mon, 25 May 2026 16:20:40 +0000 (18:20 +0200)]
mbscasecmp tests: Enhance tests.
* tests/test-mbscasecmp.c (test_ascii): New function, extracted from
main.
(test_utf_8): Likewise. Add test cases with incomplete characters.
(main): Invoke them. Accept a numeric argument.
* tests/test-mbscasecmp-4.sh: Renamed from tests/test-mbscasecmp.sh.
* tests/test-mbscasecmp-3.sh: New file, based on
tests/test-mbmemcasecmp-3.sh.
* modules/mbscasecmp-tests (Files): Update after rename. Add
locale-en.m4, locale-fr.m4.
(configure.ac): Invoke gt_LOCALE_EN_UTF8, gt_LOCALE_FR_UTF8.
(Makefile.am): Arrange to run test-mbscasecmp-3.sh,
test-mbscasecmp-4.sh, instead of test-mbscasecmp.sh.
Bruno Haible [Mon, 25 May 2026 15:55:56 +0000 (17:55 +0200)]
mbs_startswith tests: Enhance tests.
* tests/test-mbs_startswith2.c (OR): New macro, copied from
tests/test-mbsnlen.c.
(main): Add more test cases. Add more comments.
* tests/test-mbs_startswith1.c: Update comments.
* tests/test-mbs_startswith3.c: Likewise.
Paul Eggert [Sun, 24 May 2026 17:48:54 +0000 (10:48 -0700)]
regex: pacify 16.1.1 -Wanalyzer-out-of-bounds
* lib/regex_internal.c (re_node_set_insert): Add a DEBUG_ASSERT.
Needed for gcc 16.1.1 20260515 (Red Hat 16.1.1-2) on x86-64 when
_REGEX_AVOID_UCHAR_H is defined.
Paul Eggert [Sun, 24 May 2026 17:44:42 +0000 (10:44 -0700)]
regex: new _REGEX_AVOID_UCHAR_H option
This is for GNU Emacs, where the regex code is only auxiliary,
probably not enough to justify the hassle of incorporating
Gnulib’s uchar-h module and its dependencies.
The following changes are in effect only if _REGEX_AVOID_UCHAR_H,
and cause the code to avoid the need for Gnulib’s uchar-h module.
* lib/regcomp.c: Don’t include localeinfo.h.
(re_set_fastmap_icase): Don’t use localeinfo.h functions,
as they rely on char32_t.
* lib/regex_internal.h: Just use of wchar_t, wctype_t and related
functions, instead of using char32_t and related functions.
Bruno Haible [Tue, 19 May 2026 00:17:49 +0000 (02:17 +0200)]
thread-optim: Add some optional rudimentary logging.
* lib/thread-optim.c (DEBUG_ELF, dbg_printf): New macros.
(inspect_one_GOT): Log the return value through dbg_printf.
(gl_multithreaded): Log the override through dbg_printf.
Bruno Haible [Mon, 18 May 2026 23:52:40 +0000 (01:52 +0200)]
term-style-control: Make multithread-safe, part 6: Link dependencies.
* m4/pthread_kill.m4: New file.
* modules/term-style-control (Files): Add it.
(configure.ac): Invoke gl_FUNC_PTHREAD_KILL.
(Link): Add $(PTHREAD_SIGMASK_LIB) and $(PTHREAD_KILL_LIB).
* modules/term-style-control-tests (Makefile.am): Link
test-term-style-control-hello and test-term-style-control-yes with
$(PTHREAD_SIGMASK_LIB) and $(PTHREAD_KILL_LIB).
Bruno Haible [Mon, 18 May 2026 08:40:20 +0000 (10:40 +0200)]
term-style-control: Make multithread-safe, part 5: SIGCONT handler.
* lib/term-style-control.c (stopped_controller, stopped_user_data,
stopped_signal_handler_needs_reinstall): New variables.
(stopping_signal_handler): Set these variables.
(continuing_signal_handler): Use these variables instead of
active_controller and active_control_data, that may already be NULL
at this point.
(activate_term_style_controller): Initialize
stopped_signal_handler_needs_reinstall.
Bruno Haible [Mon, 18 May 2026 08:33:54 +0000 (10:33 +0200)]
term-style-control: Make multithread-safe, part 4: Redirect signals.
* lib/term-style-control.c (active_thread): New variable.
(fatal_signal_handler, stopping_signal_handler): Redirect the signal
from the current thread to the active_thread.
(activate_term_non_default_mode): Initialize active_thread.
(deactivate_term_non_default_mode): Reset active_thread to NULL.
Bruno Haible [Mon, 18 May 2026 07:58:41 +0000 (09:58 +0200)]
term-style-control: Make multithread-safe, part 2: Improve logging.
* lib/term-style-control.c: Include <stdint.h>, <pthread.h>.
(HAVE_POSIX_THREADS): New macro.
(log_message): Preserve errno.
(sprintf_integer_hex): New function.
(log_signal_handler_called): Show also the current thread ID.
(fatal_or_stopping_signal_handler): Add log_message invocations to show
the taken code path.
* modules/term-style-control (Depends-on): Add stdint-h.
(configure.ac): Test for <pthread.h>.
Bruno Haible [Mon, 18 May 2026 07:43:37 +0000 (09:43 +0200)]
term-style-control tests: Add a test with multithreading.
* tests/test-term-style-control-yes.h: New file, based on
tests/test-term-style-control-yes.c.
* tests/test-term-style-control-yes.c: Move most definitions to
tests/test-term-style-control-yes.h.
Include test-term-style-control-yes.h.
(main): Just invoke styled_yes_loop.
* tests/test-term-style-control-yes-mt.c: New file.
* modules/term-style-control-tests (Files): Add
tests/test-term-style-control-yes.h,
tests/test-term-style-control-yes-mt.c.
(Depends-on): Add thread, nanosleep.
(Makefile.am): Arrange to build test-term-style-control-yes-mt.
Bruno Haible [Sat, 16 May 2026 21:36:09 +0000 (23:36 +0200)]
fatal-signal: Make really multithread-safe.
* lib/fatal-signal.h (block_fatal_signals): Document a constraint
regarding thread creation.
* lib/fatal-signal.c: Include sigdelay.h.
(fatal_signals_block_initially_mt): New variable.
(block_fatal_signals, unblock_fatal_signals): In a multithreaded
process, use sigdelay instead of pthread_sigmask.
* modules/fatal-signal (Depends-on): Add sigdelay.
Bruno Haible [Sat, 16 May 2026 10:41:01 +0000 (12:41 +0200)]
thread-optim: Port to older glibc, musl libc, *BSD, Solaris, Android.
* lib/thread-optim.h: Include <stdbool.h>.
(gl_multithreaded): Define differently on ELF platforms.
(_GL_MULTITHREADED_ALWAYS_TRUE, _GL_MULTITHREADED_VIA_ELF): New macros.
(gl_set_multithreaded): New declaration.
* lib/thread-optim.c: New file.
* lib/thread-creators.gperf: New file.
* lib/thread-optim-proto.c: New file.
* modules/thread-optim (Files): Add these files.
(Depends-on): Add gperf, bool, stdint-h.
(configure.ac): Test for <link.h>, dl_iterate_phdr.
(Makefile.am): Compile thread-optim.c. Create thread-creators.h through
gperf.
Bruno Haible [Wed, 13 May 2026 10:51:40 +0000 (12:51 +0200)]
intprops: Fix compilation error in MSVC.
* lib/intprops.h (TYPE_IS_INTEGER, TYPE_MINIMUM, TYPE_MAXIMUM): Don't
use _Generic to distinguish between 'char' and 'signed char' with MSVC
before version 14.44.
* lib/intprops-internal.h (_GL_TYPE_SIGNED): Likewise.
Bruno Haible [Tue, 12 May 2026 08:49:49 +0000 (10:49 +0200)]
stdc_bit_floor, stdc_bit_ceil: Work around Solaris 11 OpenIndiana bug.
* lib/stdbit.in.h (stdc_bit_floor, stdc_bit_ceil): Override the macro
definition from Solaris 11.
* doc/posix-functions/stdc_bit_floor.texi: Mention the Solaris 11
OpenIndiana bug.
* doc/posix-functions/stdc_bit_ceil.texi: Likewise.