global: add API to retrieve library configuration at run time

Signed-off-by: Daiki Ueno <ueno@gnu.org>

configure.ac: emit feature summary as C macro

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'wip/dueno/build-fixes3' into 'master'

Minor build fixes for 3.7.3 release (part 2)

See merge request gnutls/gnutls!1516

tests: suppress GCC -fanalyzer warnings

Signed-off-by: Daiki Ueno <ueno@gnu.org>

.gitignore: ignore more files

Signed-off-by: Daiki Ueno <ueno@gnu.org>

src: avoid overriding noinst_PROGRAMS

In src, we now have two helper programs: systemkey and dumpcfg.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

build: hide maintainer tool invocation behind AM_V_GEN

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'wip/dueno/remove-autogen' into 'master'

remove autogen dependency

Closes #775, #774, and #773

See merge request gnutls/gnutls!1506

tests: use more aliases in tests for better alias testing coverage

Signed-off-by: Alexander Sosedkin <asosedkin@redhat.com>

.gitlab-ci.yml: run static analyzers on Python files

This runs a couple of code analysis on the Python scripts added to
remove AutoGen dependency.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

.gitlab-ci.yml: bump cache key for python3 detection

Signed-off-by: Daiki Ueno <ueno@gnu.org>

README.md: mention Python as requirement instead of AutoGen

Signed-off-by: Daiki Ueno <ueno@gnu.org>

src: remove AutoGen .def files

As neither the tools nor documentation depends on AutoGen, we don't
need to include the AutoGen definition files.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

doc: generate man-pages from JSON

This replaces man-pages generation previously provided by the autogen
-Tagman.tpl command with a Python script (gen-cmd-man.py).

Signed-off-by: Daiki Ueno <ueno@gnu.org>

doc: generate texinfo files from JSON

This replaces texinfo generation previously provided by the autogen
-Tagtexi.tpl command with a Python script (gen-cmd-texi.py).

Signed-off-by: Daiki Ueno <ueno@gnu.org>

src: remove included copy of libopts

As no tools link with libopts anymore, we don't need to include it in
the distribution.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

src: replace autoopts/libopts with minimal config parser

This replaces configuration file parsing code previously provided by
<autoopts/options.h>, with a minimal compatible implementation.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

src: generate option handling code from JSON

This replaces AutoGen based command-line parser with a Python
script (gen-getopt.py), which takes JSON description as the input.
The included JSON files were converted one-off using the parse-autogen
program: https://gitlab.com/dueno/parse-autogen.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

python: add library for handling JSON-based option description

This adds the jsonopts Python module used by the command-line parser
generator and documentation generators in the following commits.  This
also bumps the required Python interpreter version to 3.6.

Signed-off-by: Daiki Ueno <ueno@gnu.org>
Co-authored-by: Alexander Sosedkin <asosedkin@redhat.com>

Merge branch 'wip/dueno/gost-pkcs12' into 'master'

pkcs12: use the correct MAC algorithm for GOST key generation

Closes #1225

See merge request gnutls/gnutls!1514

pkcs12: use the correct MAC algorithm for GOST key generation

According to the latest TC-26 requirements, the MAC algorithm used for
PBKDF2 should always be HMAC_GOSTR3411_2012_512.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'wip/dueno/build-fixes2' into 'master'

Minor build fixes before the 3.7.3 release

See merge request gnutls/gnutls!1511

Merge branch 'wip/dueno/cpuid' into 'master'

accelerated: fix CPU feature detection for Intel CPUs

See merge request gnutls/gnutls!1487

Merge branch 'curve-keygen-allowlist-test' into 'master'

Extend system-override-curves-allowlist test with key generation

See merge request gnutls/gnutls!1500

tests: simple: check if the digest algorithm is compiled in

When the library is built with --disable-gost, gnutls_digest_get_id
returns GNUTLS_DIG_UNKNOWN for GOST algorithms.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

x509: fix potential wrong usage of memcpy

Spotted by GCC analyzer:

  common.c:552:17: warning: use of NULL 'out.data' where non-null expected [CWE-476] [-Wanalyzer-null-argument]
    552 |                 memcpy(output_data, out.data, (size_t) out.size);
        |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Daiki Ueno <ueno@gnu.org>

cert-auth: suppress false-positive warnings with GCC analyzer

When compiled with gcc -fanalyzer, it reports:

  cert.c: In function '_gnutls_pcert_to_auth_info':
  cert.c:85:17: error: dereference of NULL 'info' [CWE-476] [-Werror=analyzer-null-dereference]
     85 |         if (info->raw_certificate_list != NULL) {

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'wip/dueno/pkcs12' into 'master'

certtool: --to-p12: use modern algorithms by default

See merge request gnutls/gnutls!1499

gnutls_pkcs12_generate_mac: use SHA256 by default

Signed-off-by: Daiki Ueno <ueno@gnu.org>

.gitlab-ci.yml: reduce PKCS#12 iteration count while testing

Signed-off-by: Daiki Ueno <ueno@gnu.org>

tests: check algorithms for generating PKCS#12 file

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'wip/dueno/fipscontext' into 'master'

fips: add functions to inspect thread-local FIPS operation state

See merge request gnutls/gnutls!1465

cipher-api-test: mention why it is written using fork

Signed-off-by: Daiki Ueno <ueno@gnu.org>

fips: plumb service indicator to symmetric key crypto operations

Signed-off-by: Daiki Ueno <ueno@gnu.org>
Co-authored-by: Pedro Monreal <pmonrealgonzalez@suse.de>

fips: plumb service indicator to public key crypto operations

This installs service indicator state transitions in certain public
key operations in gnutls_crypto_pk_st, namely:

* fallible operations
  - encrypt
  - sign
  - generate_keys
  - derive

* infallible operations
  - decrypt, decrypt2
  - verify

other operations, such as generate_params, are not considered as
crypto operation.  Note that fallible operations above mean that those
return value could indicate error, while infallible operations do not
have distinction between errors and failures: decrypt/verify failures
are treated as a successful completion of the operation.

Signed-off-by: Daiki Ueno <ueno@gnu.org>
Co-authored-by: Pedro Monreal <pmonrealgonzalez@suse.de>

_gnutls_pkcs_generate_key: use HMAC-SHA256 for PBKDF2

Signed-off-by: Daiki Ueno <ueno@gnu.org>

pkcs12: determine iteration count for MAC at build time

Signed-off-by: Daiki Ueno <ueno@gnu.org>

pkcs7: determine iteration count for PBKDF2 at build time

Signed-off-by: Daiki Ueno <ueno@gnu.org>

certtool: --to-p12: use modern algorithms by default

Currently certtool uses PKCS12-3DES-SHA1 for encrypting keys in
PKCS#12, while it is suggested to migrate to more modern algorithms,
namely AES-128-CBC with PBKDF2 and SHA-256:
https://bugzilla.redhat.com/show_bug.cgi?id=1759982

Signed-off-by: Daiki Ueno <ueno@gnu.org>

fips: add functions to inspect thread-local FIPS operation state

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'tmp-2022-gtkdoc' into 'master'

Fix gtk-doc build, Debian bug #1003075

See merge request gnutls/gnutls!1507

Drop unquoted angle brackets in gtk-doc comment.

Signed-off-by: Andreas Metzler <ametzler@bebt.de>

Fix gtk-doc build, use http URI in sgml master.

Signed-off-by: Andreas Metzler <ametzler@bebt.de>

Merge branch 'p11tool-always-auth' into 'master'

p11tool: add --mark-always-authenticate option

See merge request gnutls/gnutls!1504

p11tool: add --mark-always-authenticate option

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>

Merge branch 'copyright' into 'master'

doc: updated copyrights for 2022

See merge request gnutls/gnutls!1505

doc: updated copyrights for 2022

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>

accelerated: fix CPU feature detection for Intel CPUs

This fixes read_cpuid_vals to correctly read the CPUID quadruple, as
well as to set the bit the ustream CRYPTOGAMS uses to identify Intel
CPUs.

Suggested by Rafael Gieschke in:
https://gitlab.com/gnutls/gnutls/-/issues/1282

Signed-off-by: Daiki Ueno <ueno@gnu.org>

padlock: reset _gnutls_x86_cpuid_s only after padlock check succeeds

Otherwise it clears _gnutls_x86_cpuid_s which may already hold valid
CPUID detected for Intel and AMD CPUs.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'wip/dueno/nettle-hash' into 'master'

wrap_nettle_hash_fast: avoid calling _update with zero-length input

See merge request gnutls/gnutls!1503

Merge branch 'wip/dueno/hash-copy-doc' into 'master'

gnutls_{hash,hmac}_copy: mention the functions do not always work

See merge request gnutls/gnutls!1502

wrap_nettle_hash_fast: avoid calling _update with zero-length input

As Nettle's hash update functions internally call memcpy, providing
zero-length input may cause undefined behavior.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

gnutls_{hash,hmac}_copy: mention the functions do not always work

It is known that some built-in accelerated implementation, such as
AF_ALG, does not support copying hash/hmac contexts.  This expands the
documentation to suggest checking the return value of those functions.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

tests: extend system-override-curves-allowlist with key generation

Signed-off-by: Alexander Sosedkin <asosedkin@redhat.com>

tests: tweak system-override-curves-allowlist insignificantly

Signed-off-by: Alexander Sosedkin <asosedkin@redhat.com>

Merge branch 'tpm2-dep-correction' into 'master'

README: document tpm2-tss-engine test dependency

See merge request gnutls/gnutls!1498

README: document tpm2-tss-engine test dependency

Signed-off-by: Alexander Sosedkin <asosedkin@redhat.com>

Merge branch 'ktls_api' into 'master'

ktls: API

See merge request gnutls/gnutls!1477

Merge branch 'aarch64-sha384' into 'master'

use sha384_digest in lib/accelerated/aarch64/sha-aarch64.c sha384

See merge request gnutls/gnutls!1497

use sha384_digest in lib/accelerated/aarch64/sha-aarch64.c sha384

Mirrors https://gitlab.com/gnutls/gnutls/-/merge_requests/1466

Signed-off-by: Alexander Sosedkin <asosedkin@redhat.com>

ktls: flags

ktls enum flags API

Signed-off-by: Frantisek Krenzelok <krenzelok.frantisek@gmail.com>

KTLS: API

ktls is enabled by default, we can check if inicialization was
succesfull with gnutls_transport_is_ktls_enabled

Signed-off-by: Frantisek Krenzelok <krenzelok.frantisek@gmail.com>

Merge branch 'fix-asan-out-of-tree' into 'master'

tests: fix out of tree builds with ASAN

See merge request gnutls/gnutls!1496

Merge branch 'wip/dueno/sct' into 'master'

Minor cleanup on the new X509 CT code

See merge request gnutls/gnutls!1495

.gitignore: ignore tests/x509cert-ct

Signed-off-by: Daiki Ueno <ueno@gnu.org>

X509 CT: defer filling in the length field

This eliminates the need of precalculating the payload size, to make
it easier to adapt to new format.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

tests: fix out of tree builds with ASAN

Signed-off-by: Alexander Sosedkin <asosedkin@redhat.com>

Merge branch 'test-allowlisting-proto-tcp' into 'master'

test for gnutls_protocol_set_enabled, TCP

See merge request gnutls/gnutls!1494

tests: add protocol-set-allowlist

Signed-off-by: Alexander Sosedkin <asosedkin@redhat.com>

tests: add tcp_connect to utils

Signed-off-by: Alexander Sosedkin <asosedkin@redhat.com>

X509 CT: use size_t for array index instead of unsigned

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'aja-certificate-transparency' into 'master'

Read Certificate Transparency (RFC 6962) SCT extension

Closes #232

See merge request gnutls/gnutls!1367

Update symbols

Signed-off-by: Ander Juaristi <a@juaristi.eus>

devel: Suppress new API functions

Signed-off-by: Ander Juaristi <a@juaristi.eus>

x509 CT: Add tests

Signed-off-by: Ander Juaristi <a@juaristi.eus>

x509 CT: implement new public API

This commit implements import and export functions for the X.509
Certificate Transparency Signed Certificate Timestamp (SCT) extension
(RFC 6962).

A new constant GNUTLS_X509EXT_OID_CT_SCT is introduced
with the value "1.3.6.1.4.1.11129.2.4.2".

The following new public API functions are introduced:

    - gnutls_x509_ext_ct_scts_init
    - gnutls_x509_ext_ct_scts_deinit
    - gnutls_x509_ext_ct_import_scts
    - gnutls_x509_ext_ct_export_scts
    - gnutls_x509_ct_sct_get_version
    - gnutls_x509_ct_sct_get

Signed-off-by: Ander Juaristi <a@juaristi.eus>

Merge branch 'wip/dueno/abi-check-latest' into 'master'

build: stop running abi-dump-latest at "make files-update"

See merge request gnutls/gnutls!1491

devel/libgnutls.abignore: ignore drbg_aes_* functions

These functions are only defined when compiled with
--enable-fips140-mode.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'wip/dueno/config-allowlisting' into 'master'

priority: support allowlisting in configuration file

Closes #1172

See merge request gnutls/gnutls!1427

priority: support allowlisting in configuration file

This adds a new mode of interpreting the [overrides] section.  If
"override-mode" is set to "allowlisting" in the [global] section, all
the algorithms (hashes, signature algorithms, curves, and versions)
are initially marked as insecure/disabled.  Then the user can enable
them by specifying allowlisting keywords such as "secure-hash" in the
[overrides] section.

Signed-off-by: Daiki Ueno <ueno@gnu.org>
Co-authored-by: Alexander Sosedkin <asosedkin@redhat.com>

Merge branch 'wip/dueno/valgrind-tests' into 'master'

build: update to use the latest valgrind-tests module from Gnulib

Closes #1253

See merge request gnutls/gnutls!1488

CONTRIBUTING.md: clarify how to introduce new API

Signed-off-by: Daiki Ueno <ueno@gnu.org>

release-steps: "make abi-dump-latest" at release time

Signed-off-by: Daiki Ueno <ueno@gnu.org>

build: stop running abi-dump-latest at "make files-update"

The procedure of registering ABI updates has changed in
bd3c78b9d10937adb1855b85bca1864972a1c986.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

build: update to use the latest valgrind-tests module from Gnulib

This adjust the existing valgrind invocations in the test suite with:
https://www.gnu.org/software/gnulib/manual/html_node/Valgrind-options.html

- make --suppressions option to per directory, using AM_VALGRINDFLAGS
- use LOG_VALGRIND for LOG_COMPILER
- quote '$(LOG_VALGRIND)' in TESTS_ENVIRONMENT
- move gl_VALGRIND_TESTS_DEFAULT_NO call before gl_INIT

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'fix_non_vla_02' into 'master'

sockets: fixed building for Windows with compilers without VLA support (alternative version)

See merge request gnutls/gnutls!1490

sockets: fixed compiler warning on Windows x32

Signed-off-by: Evgeny Grin <k2k@narod.ru>

sockets: fixed building for Windows with compilers without VLA support

Signed-off-by: Evgeny Grin <k2k@narod.ru>

priority: refactor config file parsing

This adds the following refactoring:

- avoid side-effects during parsing the config file, by separating
  application phase; the parsed configuration can be applied globally
  with cfg_apply, after validation
- make _gnutls_*_mark_{disabled,insecure} take an ID instead of the
  name

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'wip/dueno/thr' into 'master'

locks: couple of improvements using Gnulib glthread

See merge request gnutls/gnutls!1485

locks: deprecate gnutls_global_set_mutex

As the library now uses static mutexes, rwlocks, and onces, it doesn't
make much sense to only replace dynamic mutex usage.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

locks: use once execution for on-demand initialization of globals

This makes sure that the global variables are initialized only once.
Most of those variables are initialized at ELF constructor, though a
couple of occasions they are initialized on-demand: the global keylog
file pointer and TPM2 TCTI context.  To properly protect the
initialization this patch uses gl_once provided by Gnulib.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

locks: rework rwlock primitives

Remove GNUTLS_STATIC_RWLOCK_*LOCK macros and respect return values of
rwlock primitives.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

pkcs11: switch to using static mutex

Signed-off-by: Daiki Ueno <ueno@gnu.org>

verify-tofu: switch to using static mutex for locking

Signed-off-by: Daiki Ueno <ueno@gnu.org>

locks: replace custom mutex wrappers with "glthread/lock.h"

As Gnulib provides portability wrappers of mutex implementations, we
don't need to provide similar wrappers by ourselves.

Signed-off-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'wip/dueno/tpm2' into 'master'

Port openconnect TPM2 code

Closes #594

See merge request gnutls/gnutls!1460

Port openconnect TPM2 code

This introduces transparent loading of TPM2 keys which are in PEM
form by gnutls_privkey_import_x509_raw() and higher level functions
which wrap it.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
Co-authored-by: David Woodhouse <dwmw2@infradead.org>
Co-authored-by: Daiki Ueno <ueno@gnu.org>

Merge branch 'abs-top-builddir-fix' into 'master'

tests: pass $abs_top_builddir more consistently

See merge request gnutls/gnutls!1484

tests: set $abs_top_builddir in more places

`$abs_top_builddir` has been used all across tests' subdirectories
(through tests/scripts/common.sh)
but has only been defined for tests/suite/ ones.
Defining it in other Makefiles where `top_builddir` is being passed.

Signed-off-by: Alexander Sosedkin <asosedkin@redhat.com>