]> git.ipfire.org Git - thirdparty/gnutls.git/log
thirdparty/gnutls.git
7 years agoabi-check: supply --hd2 to abi-check-latest target
Daiki Ueno [Mon, 29 Apr 2019 11:15:33 +0000 (13:15 +0200)] 
abi-check: supply --hd2 to abi-check-latest target

To suppress changes in internal structures.
Suggested by Nikos Mavrogiannopoulos.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agoMerge branch 'tmp-rsa-pss-cert-fix' into 'master'
Nikos Mavrogiannopoulos [Thu, 25 Apr 2019 08:12:40 +0000 (08:12 +0000)] 
Merge branch 'tmp-rsa-pss-cert-fix' into 'master'

certtool: generate RSA-PSS certificates from RSA keys

See merge request gnutls/gnutls!980

7 years agocerttool: refuse to accept an incompatible key type
Nikos Mavrogiannopoulos [Sat, 20 Apr 2019 16:46:23 +0000 (18:46 +0200)] 
certtool: refuse to accept an incompatible key type

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agocerttool: generate RSA-PSS certificates from RSA keys
Nikos Mavrogiannopoulos [Mon, 15 Apr 2019 12:32:55 +0000 (14:32 +0200)] 
certtool: generate RSA-PSS certificates from RSA keys

When generating certificates it was not possible to generate
an RSA-PSS certificate from an RSA key (common scenario). This
fixes the certificate generation to include such a method.

Ironically there was a test for this scenario but the test
was limited to checking that the combination of certtool parameters
succeeded; modified the test to check the textual expression of
the certificate for the RSA-PSS indicators.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
7 years agoMerge branch 'autoopts_guix' into 'master'
Nikos Mavrogiannopoulos [Sat, 20 Apr 2019 07:25:00 +0000 (07:25 +0000)] 
Merge branch 'autoopts_guix' into 'master'

Makefile.am: Don't assume autoopts-config returns a single dash.

See merge request gnutls/gnutls!976

7 years agoMerge branch 'tmp-p11tool-pin' into 'master'
Nikos Mavrogiannopoulos [Sat, 20 Apr 2019 07:24:34 +0000 (07:24 +0000)] 
Merge branch 'tmp-p11tool-pin' into 'master'

p11tool: copy vendor query attributes when listing privkeys

See merge request gnutls/gnutls!982

7 years agoMerge branch 'tmp-early-exporter' into 'master'
Daiki Ueno [Fri, 19 Apr 2019 21:19:25 +0000 (21:19 +0000)] 
Merge branch 'tmp-early-exporter' into 'master'

prf: add function to retrieve early keying material

Closes #736 and #329

See merge request gnutls/gnutls!894

7 years agotls13/session_ticket: use the same ticket_age_add regardless of endianness
Daiki Ueno [Fri, 19 Apr 2019 20:04:24 +0000 (22:04 +0200)] 
tls13/session_ticket: use the same ticket_age_add regardless of endianness

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agotls13/session_ticket: avoid UB regarding 64-bit time encoding
Daiki Ueno [Fri, 19 Apr 2019 14:59:31 +0000 (16:59 +0200)] 
tls13/session_ticket: avoid UB regarding 64-bit time encoding

On 32-bit platform, struct timespec.tv_sec can be signed 32-bit and
thus right shifting 32 could be an undefined behavior.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agotests: make datefudge check robuster
Daiki Ueno [Fri, 19 Apr 2019 06:12:56 +0000 (08:12 +0200)] 
tests: make datefudge check robuster

When checking datefudge availability under cross-compiling environment
with a binfmt wrapper, it is not sufficient to check against the host
executable.  This instead uses a test executable compiled for the
target architecture.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agoserv, cli: add --keymatexport option
Daiki Ueno [Thu, 11 Apr 2019 12:35:32 +0000 (14:35 +0200)] 
serv, cli: add --keymatexport option

This adds --keymatexport and --keymatexportsize options to both
gnutls-serv and gnutls-cli.  Those would be useful for testing
interoperability with other implementations.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agoprf: add function to retrieve early keying material
Daiki Ueno [Thu, 11 Apr 2019 10:11:00 +0000 (12:11 +0200)] 
prf: add function to retrieve early keying material

This adds a new function gnutls_prf_early, which shall be called in a
handshake hook waiting for GNUTLS_HANDSHAKE_CLIENT_HELLO.  The test
needs to be run in a datefudge wrapper as the early secrets depend on
the current time (through PSK).

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agohandshake: generate early exporter secret
Daiki Ueno [Thu, 11 Apr 2019 10:07:00 +0000 (12:07 +0200)] 
handshake: generate early exporter secret

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agohandshake: move early secrets calculation to pre_shared_key
Daiki Ueno [Thu, 11 Apr 2019 10:00:46 +0000 (12:00 +0200)] 
handshake: move early secrets calculation to pre_shared_key

TLS 1.3 Early Secret and the derived keys are calculated upon a PSK
being selected, thus the code fits better in ext/pre_shared_key.c.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agotests/tls13/prf: check if the exported material matches on server
Daiki Ueno [Thu, 11 Apr 2019 10:10:00 +0000 (12:10 +0200)] 
tests/tls13/prf: check if the exported material matches on server

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agoprf: centrally define "exporter" label in handshake.h
Daiki Ueno [Thu, 11 Apr 2019 09:23:26 +0000 (11:23 +0200)] 
prf: centrally define "exporter" label in handshake.h

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agoMerge branch 'tmp-abigail' into 'master'
Nikos Mavrogiannopoulos [Thu, 18 Apr 2019 18:39:14 +0000 (18:39 +0000)] 
Merge branch 'tmp-abigail' into 'master'

Use libabigail for tracking ABI changes

See merge request gnutls/gnutls!972

7 years agoMerge branch 'tmp-ametzler-doc-GNUTLS_CERT_IGNORE' into 'master'
Nikos Mavrogiannopoulos [Thu, 18 Apr 2019 18:16:34 +0000 (18:16 +0000)] 
Merge branch 'tmp-ametzler-doc-GNUTLS_CERT_IGNORE' into 'master'

doc: Add documentation for GNUTLS_CERT_IGNORE

See merge request gnutls/gnutls!983

7 years agoMerge branch 'certs' into 'master'
Nikos Mavrogiannopoulos [Thu, 18 Apr 2019 18:15:21 +0000 (18:15 +0000)] 
Merge branch 'certs' into 'master'

Extend test cert to 2049-05-27

See merge request gnutls/gnutls!979

7 years agodoc: Add documentation for GNUTLS_CERT_IGNORE
Andreas Metzler [Thu, 18 Apr 2019 16:43:30 +0000 (18:43 +0200)] 
doc: Add documentation for GNUTLS_CERT_IGNORE

Signed-off-by: Andreas Metzler <ametzler@bebt.de>
7 years agop11tool: copy vendor query attributes when listing privkeys
Daiki Ueno [Tue, 16 Apr 2019 12:27:10 +0000 (14:27 +0200)] 
p11tool: copy vendor query attributes when listing privkeys

When listing private keys on a specified token, "pin-value" is
ignored and the tool looks for GNUTLS_PIN, because it internally
strips out vendor query attributes from the original URL.

This also replaces the global uses of GNUTLS_PIN envvar in
testpkcs11.sh to check the case where the envvar is not in effect.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agoabi-check: simplify ABI comparison using libabigail tools
Nikos Mavrogiannopoulos [Sun, 7 Apr 2019 11:22:21 +0000 (13:22 +0200)] 
abi-check: simplify ABI comparison using libabigail tools

These have output ABI format compatibility and that means we can
take snapshots to test ABI against. We also hard-code explicitly
the SONAME version to ensure no accidental SONAME bumps happen.

This patch also moves symbols.last in the devel/ subdirectory
and no internal files are shipped.

Relates: #292

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years ago.gitignore: ignore tests/libpkcs11mock2.la
Nikos Mavrogiannopoulos [Sun, 7 Apr 2019 16:29:02 +0000 (18:29 +0200)] 
.gitignore: ignore tests/libpkcs11mock2.la

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agognutls.h: re-define GNUTLS_CRT_RAWPK
Nikos Mavrogiannopoulos [Sun, 7 Apr 2019 12:30:30 +0000 (14:30 +0200)] 
gnutls.h: re-define GNUTLS_CRT_RAWPK

This was available before 3.6.4, and was incorrectly removed.
It was found using libabigail tools.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agoMerge branch 'tmp-mingw-fix' into 'master'
Tim Rühsen [Mon, 15 Apr 2019 19:08:00 +0000 (19:08 +0000)] 
Merge branch 'tmp-mingw-fix' into 'master'

Fix WIN32 custom push/pull functions

Closes #751

See merge request gnutls/gnutls!978

7 years agoExtend test cert to 2049-05-27
Bernhard M. Wiedemann [Sun, 14 Apr 2019 14:53:52 +0000 (16:53 +0200)] 
Extend test cert to 2049-05-27

instead of expiring in 2024-02-29
This update did not trigger y2038 bugs on 32-bit systems.

Without this patch, one test fails after 2024:
 doit:124: rsa pss key: gnutls_x509_crt_verify_data2                    |
 FAIL x509sign-verify (exit status: 1)

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
7 years agoMerge branch 'tmp-ametzler-gcc9-build-error' into 'master'
Tim Rühsen [Sun, 14 Apr 2019 15:25:31 +0000 (15:25 +0000)] 
Merge branch 'tmp-ametzler-gcc9-build-error' into 'master'

Fix link errors with gcc-9

See merge request gnutls/gnutls!966

7 years agoFix link error with gcc-9
Andreas Metzler [Sun, 14 Apr 2019 15:25:31 +0000 (15:25 +0000)] 
Fix link error with gcc-9

Use LDADD instead of LDFLAGS to link test cipher-openssl-compat against
libcrypto. This fixes a build error with gcc9 which passes the linker
option --as-needed by default.

Signed-off-by: Andreas Metzler <ametzler@bebt.de>
7 years agodoc: mark TLS1.2 functions as such [ci skip]
Nikos Mavrogiannopoulos [Sun, 14 Apr 2019 14:15:23 +0000 (16:15 +0200)] 
doc: mark TLS1.2 functions as such [ci skip]

gnutls_cipher_suite_get_name and gnutls_session_get_master_secret
are marked as TLS1.2 or earlier-only as they cannot be used with
TLS 1.3.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agognutlsxx.h: removed fixme comments [ci skip]
Nikos Mavrogiannopoulos [Sat, 13 Apr 2019 06:37:50 +0000 (08:37 +0200)] 
gnutlsxx.h: removed fixme comments [ci skip]

They served no purpose.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agognutls-cli: renamed global variable name
Nikos Mavrogiannopoulos [Sat, 13 Apr 2019 06:33:57 +0000 (08:33 +0200)] 
gnutls-cli: renamed global variable name

That is because the same variable name is used by local
variables as well.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agoFix WIN32 custom push/pull functions
Tim Rühsen [Thu, 11 Apr 2019 07:46:21 +0000 (09:46 +0200)] 
Fix WIN32 custom push/pull functions

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
Reported-by: J. Ali Harlow (@j_ali on Gitlab.com)
7 years agoMerge branch 'tmp-fix-pha-pkcs11-test' into 'master'
Nikos Mavrogiannopoulos [Wed, 10 Apr 2019 13:12:21 +0000 (13:12 +0000)] 
Merge branch 'tmp-fix-pha-pkcs11-test' into 'master'

tests: fix race condition in tls13/post-handshake-with-cert-pkcs11

See merge request gnutls/gnutls!977

7 years agotests: fix race condition in tls13/post-handshake-with-cert-pkcs11
Daiki Ueno [Tue, 9 Apr 2019 16:20:15 +0000 (18:20 +0200)] 
tests: fix race condition in tls13/post-handshake-with-cert-pkcs11

The test had a strange setup of server/client processes: the server
runs in a child process and the client runs in a parent process.  The
intention behind this was to detect softhsm availability in the parent
process and exit with 77 if missing.  However, there was a potential
race when the server exits and proceeds to the next call of start().

This fixes the process setup and moves the softhsm detection at the
program startup.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agoMerge branch 'guile' into 'master'
Nikos Mavrogiannopoulos [Wed, 10 Apr 2019 08:35:14 +0000 (08:35 +0000)] 
Merge branch 'guile' into 'master'

build: allow override guile system location

Closes #748

See merge request gnutls/gnutls!968

7 years agoMerge branch 'tmp-check-even' into 'master'
Tim Rühsen [Tue, 9 Apr 2019 19:04:06 +0000 (19:04 +0000)] 
Merge branch 'tmp-check-even' into 'master'

Pass CI commit check if branches are 'even'

See merge request gnutls/gnutls!975

7 years agobuild: rename guile variables to match upstream names
Alon Bar-Lev [Tue, 9 Apr 2019 16:01:46 +0000 (19:01 +0300)] 
build: rename guile variables to match upstream names

Reduce confusion between the upstream terms and the gnutls terms.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
7 years agobuild: allow override guile system location
Alon Bar-Lev [Wed, 3 Apr 2019 15:42:26 +0000 (18:42 +0300)] 
build: allow override guile system location

guile has three settings acquired from system:
* GUILE_SITE
* GUILE_SITE_CCACHE
* GUILE_EXTENSION

The <guile-2.2 m4 macro exposed only GUILE_SITE while build tried to guess the
other variables based on the $libdir of the gnutls which may be different.

The >=guile-2.2 m4 macro provides all settings for build to use as default,
while allowing to override each.

Resolves: #748
Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
7 years agoMakefile.am: Don't assume autoopts-config returns a single dash.
Marius Bakke [Tue, 9 Apr 2019 12:17:09 +0000 (14:17 +0200)] 
Makefile.am: Don't assume autoopts-config returns a single dash.

On distributions such as Nix or Guix, `autoopts-config libsrc` may
return something along the lines of
"/gnu/store/...-autogen-5.18.16/share/autogen/libopts-42.1.17.tar.gz".

* Makefile.am (libopts-check): Print only the last field from
autoopts-config output.

Signed-off-by: Marius Bakke <mbakke@fastmail.com>
7 years agoPass CI commit check if branches are 'even'
Tim Rühsen [Tue, 9 Apr 2019 10:19:00 +0000 (12:19 +0200)] 
Pass CI commit check if branches are 'even'

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
7 years agoMerge branch 'tests' into 'master'
Tim Rühsen [Tue, 9 Apr 2019 08:04:56 +0000 (08:04 +0000)] 
Merge branch 'tests' into 'master'

tests: cert-tests: crl: cleanup files

See merge request gnutls/gnutls!973

7 years agotests: cert-tests: crl: cleanup files
Alon Bar-Lev [Mon, 8 Apr 2019 17:34:24 +0000 (20:34 +0300)] 
tests: cert-tests: crl: cleanup files

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
7 years agoMerge branch 'ci' into 'master'
Nikos Mavrogiannopoulos [Tue, 9 Apr 2019 06:22:44 +0000 (06:22 +0000)] 
Merge branch 'ci' into 'master'

ci: refresh the cache due to failures in debian

See merge request gnutls/gnutls!974

7 years agoci: refresh the cache due to failures in debian
Alon Bar-Lev [Tue, 9 Apr 2019 04:59:53 +0000 (07:59 +0300)] 
ci: refresh the cache due to failures in debian

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
7 years agoMerge branch 'tmp-include-unit-testing-doc' into 'master'
Nikos Mavrogiannopoulos [Sun, 7 Apr 2019 16:22:59 +0000 (16:22 +0000)] 
Merge branch 'tmp-include-unit-testing-doc' into 'master'

CONTRIBUTING.md: document unit testing method of internal functions [ci skip]

Closes #749

See merge request gnutls/gnutls!971

7 years agoCONTRIBUTING.md: document unit testing method of internal functions [ci skip]
Nikos Mavrogiannopoulos [Sun, 7 Apr 2019 11:03:20 +0000 (13:03 +0200)] 
CONTRIBUTING.md: document unit testing method of internal functions [ci skip]

Resolves: #749

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agoMerge branch 'tmp-client-auth-decline' into 'master'
Daiki Ueno [Sun, 7 Apr 2019 07:46:14 +0000 (07:46 +0000)] 
Merge branch 'tmp-client-auth-decline' into 'master'

cert auth: reject auth if no signature algorithm is usable in TLS 1.3

Closes #730

See merge request gnutls/gnutls!967

7 years agotests: add post-handshake auth test using PKCS#11 token
Daiki Ueno [Thu, 4 Apr 2019 14:51:28 +0000 (16:51 +0200)] 
tests: add post-handshake auth test using PKCS#11 token

This adds a test that exercise the client's auth rejection logic,
using the RSA-PSS disabled PKCS #11 token.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agotests: add mock PKCS#11 module disabling RSA-PSS
Daiki Ueno [Thu, 4 Apr 2019 14:40:11 +0000 (16:40 +0200)] 
tests: add mock PKCS#11 module disabling RSA-PSS

This adds libpkcs11mock2.so, which wraps SoftHSM but filters out the
use of the CKM_RSA_PKCS_PSS mechanism.  That way we can simulate the
situation where the certificate is RSA while the private key cannot be
used for RSA-PSS.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agoMerge branch 'tmp-cmac-cfb8-fix' into 'master'
Tim Rühsen [Sat, 6 Apr 2019 12:36:38 +0000 (12:36 +0000)] 
Merge branch 'tmp-cmac-cfb8-fix' into 'master'

nettle: include config.h before checking for definitions

See merge request gnutls/gnutls!970

7 years agonettle: include config.h before checking for definitions
Nikos Mavrogiannopoulos [Sat, 6 Apr 2019 06:34:43 +0000 (08:34 +0200)] 
nettle: include config.h before checking for definitions

This makes sure that we don't include the internal backport
if compiled with a version of nettle that includes that code.
We also exclude nettle/backport from the static analyzer's list
as it contains files outside our control (from nettle project).

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agoMerge branch 'master' into 'master'
Tim Rühsen [Fri, 5 Apr 2019 18:07:11 +0000 (18:07 +0000)] 
Merge branch 'master' into 'master'

[OSCP] Fix : null pointer resp

See merge request gnutls/gnutls!969

7 years agognutls_memset(): calling explicit_bzero() is enough to zero-fill a buffer
Maciej S. Szmigiero [Thu, 28 Mar 2019 22:04:13 +0000 (23:04 +0100)] 
gnutls_memset(): calling explicit_bzero() is enough to zero-fill a buffer

If we use explicit_bzero() to zero-fill a buffer in gnutls_memset() we
don't need to zero it again via a volatile trick later in this function.

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
7 years ago[OSCP] Fix : null pointer resp
Elta Koepp [Fri, 5 Apr 2019 14:04:12 +0000 (10:04 -0400)] 
[OSCP] Fix : null pointer resp

Signed-off-by: Elta Koepp <elta_koepp@gmail.com>
7 years agocert auth: reject auth if no signature algorithm is usable in TLS 1.3
Daiki Ueno [Thu, 4 Apr 2019 15:01:24 +0000 (17:01 +0200)] 
cert auth: reject auth if no signature algorithm is usable in TLS 1.3

Previously, when there is no overlap between usable signature
algorithms and the "signature_algorithms" extension in Certificate
Request, the client failed in sending Certificate Verify, followed by
a connection close.  In TLS 1.3, it is possible to keep the connection
but reject the authentication by not sending Certificate Verify.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years agohandshake: remove unnecessary HSK_CRT_SENT flag
Daiki Ueno [Mon, 1 Apr 2019 12:14:12 +0000 (14:14 +0200)] 
handshake: remove unnecessary HSK_CRT_SENT flag

Previously, while the flag HSK_CRT_SENT was checked in
_gnutls13_send_certificate_verify, the flag was never set anywhere.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
7 years ago.gitlab-ci.yml: do not run commit-check on master branch
Nikos Mavrogiannopoulos [Wed, 3 Apr 2019 09:59:37 +0000 (11:59 +0200)] 
.gitlab-ci.yml: do not run commit-check on master branch

That is, because there are no diffs to check.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
7 years agoMerge branch 'check_if_signed' into 'master'
Nikos Mavrogiannopoulos [Tue, 2 Apr 2019 09:36:29 +0000 (09:36 +0000)] 
Merge branch 'check_if_signed' into 'master'

Fix check_if_signed

See merge request gnutls/gnutls!964

7 years agoFix check_if_signed
Simo Sorce [Fri, 29 Mar 2019 18:01:14 +0000 (14:01 -0400)] 
Fix check_if_signed

Fix the target branch we check against by adding upstream as remote.

Drop the use of set -e as this causes the shell to immediately exit on
errors instead of allowing the code to check the failure and report what
it faled about.

Also print which commits are being checked and what information was found
so that a CI failure can be better diagnosed.

Signed-off-by: Simo Sorce <simo@redhat.com>
7 years agodoc update [ci skip]
Nikos Mavrogiannopoulos [Sat, 30 Mar 2019 04:37:02 +0000 (05:37 +0100)] 
doc update [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agoVendor in XTS functionality from Nettle
Simo Sorce [Fri, 19 Oct 2018 19:53:27 +0000 (15:53 -0400)] 
Vendor in XTS functionality from Nettle

If nettle's XTS is not available, use a vendored in version from master.
This is necessary as long as we need to link against 3.4 for ABI
compatibility reasons.

Signed-off-by: Simo Sorce <simo@redhat.com>
7 years agofuzz: improvements in gnutls_x509_verify_fuzzer [ci skip]
Nikos Mavrogiannopoulos [Fri, 29 Mar 2019 05:08:06 +0000 (06:08 +0100)] 
fuzz: improvements in gnutls_x509_verify_fuzzer [ci skip]

Added a larger set of corpus (generated with afl-fuzz), and made
sure that the fuzzer application crashes if verification succeeds.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agoMerge branch 'tmp-fail-sigcheck' into 'master'
Tim Rühsen [Thu, 28 Mar 2019 21:27:00 +0000 (21:27 +0000)] 
Merge branch 'tmp-fail-sigcheck' into 'master'

Let check_if_signed fail if git fails

See merge request gnutls/gnutls!962

7 years agoLet check_if_signed fail if git fails
Tim Rühsen [Thu, 28 Mar 2019 09:41:13 +0000 (10:41 +0100)] 
Let check_if_signed fail if git fails

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
7 years agoMerge branch 'master' into 'master'
Tim Rühsen [Wed, 27 Mar 2019 16:49:00 +0000 (16:49 +0000)] 
Merge branch 'master' into 'master'

Detect malloc failure.

See merge request gnutls/gnutls!960

7 years agoUpdate ocsptool-common.c
Elta Koepp [Wed, 27 Mar 2019 13:38:50 +0000 (13:38 +0000)] 
Update ocsptool-common.c

7 years agoDetect malloc failure.
Elta Koepp [Wed, 27 Mar 2019 12:55:55 +0000 (12:55 +0000)] 
Detect malloc failure.

malloc(data.size + 1) maybe returns NULL on failure.

7 years agoreleased 3.6.7 gnutls_3_6_7
Nikos Mavrogiannopoulos [Wed, 27 Mar 2019 06:21:31 +0000 (07:21 +0100)] 
released 3.6.7

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agohandshake: add missing initialization of local variable
Daiki Ueno [Mon, 25 Mar 2019 15:06:39 +0000 (16:06 +0100)] 
handshake: add missing initialization of local variable

Resolves: #704

Signed-off-by: Daiki Ueno <dueno@redhat.com>
Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
7 years agofuzz: added fuzzer for certificate verification
Nikos Mavrogiannopoulos [Mon, 25 Mar 2019 14:47:51 +0000 (15:47 +0100)] 
fuzz: added fuzzer for certificate verification

This also adds a reproducer for CVE-2019-3829.

Resolves: #694

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
7 years agoMerge branch 'sha3_selftests' into 'master'
Nikos Mavrogiannopoulos [Tue, 26 Mar 2019 18:14:15 +0000 (18:14 +0000)] 
Merge branch 'sha3_selftests' into 'master'

fips140: Perform SHA-3 self tests

See merge request gnutls/gnutls!958

7 years agobumped version
Nikos Mavrogiannopoulos [Tue, 26 Mar 2019 15:11:42 +0000 (16:11 +0100)] 
bumped version

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
7 years agoMerge branch 'tmp-increase-nr-of-tickets' into 'master'
Nikos Mavrogiannopoulos [Tue, 26 Mar 2019 14:33:55 +0000 (14:33 +0000)] 
Merge branch 'tmp-increase-nr-of-tickets' into 'master'

handshake: increase the default number of tickets we send to 2

Closes #596

See merge request gnutls/gnutls!942

7 years agofips140: Perform SHA-3 self tests
Anderson Toshiyuki Sasaki [Tue, 26 Mar 2019 10:05:06 +0000 (11:05 +0100)] 
fips140: Perform SHA-3 self tests

It is required to perform the self tests to validate SHA-3
implementation.

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
7 years agoMerge branch 'tmp-security-update' into 'master'
Dmitry Eremin-Solenikov [Tue, 26 Mar 2019 08:55:12 +0000 (08:55 +0000)] 
Merge branch 'tmp-security-update' into 'master'

SECURITY.md: updated to reflect the current practice

See merge request gnutls/gnutls!951

7 years agoMerge branch 'guile' into 'master'
Nikos Mavrogiannopoulos [Sun, 24 Mar 2019 12:18:48 +0000 (12:18 +0000)] 
Merge branch 'guile' into 'master'

configure.ac: remove --with-guile-site-dir

See merge request gnutls/gnutls!957

7 years agotools: removed unused code
Nikos Mavrogiannopoulos [Sun, 24 Mar 2019 07:37:05 +0000 (08:37 +0100)] 
tools: removed unused code

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agognutls-cli: Fix output with option "--logfile"
Ke Zhao [Thu, 21 Mar 2019 15:27:24 +0000 (11:27 -0400)] 
gnutls-cli: Fix output with option "--logfile"

The X.509 connection would still print informational message to the
stdout by default. Move that output to logfile and add x509 functionality
test in the test suite.

Signed-off-by: Ke Zhao <kzhao@redhat.com>
7 years agoconfigure.ac: remove --with-guile-site-dir
Alon Bar-Lev [Fri, 22 Mar 2019 22:38:17 +0000 (00:38 +0200)] 
configure.ac: remove --with-guile-site-dir

The hack of distcheck is not known and should not be the default as the
GUILE_SITE_DIR macro is the default expected behavior.

There is little value in specifying any other location of the site-dir as it
is out of the guile configuration so best to remove.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
7 years agoMerge branch 'tmp-improve-session-resumption' into 'master'
Nikos Mavrogiannopoulos [Fri, 22 Mar 2019 14:35:32 +0000 (14:35 +0000)] 
Merge branch 'tmp-improve-session-resumption' into 'master'

Improved estimation of wait in gnutls_session_get_data2

Closes #706

See merge request gnutls/gnutls!936

7 years ago_x509_en/decode_provable_seed: clarified purpose of functions [ci skip]
Nikos Mavrogiannopoulos [Wed, 20 Mar 2019 10:40:15 +0000 (11:40 +0100)] 
_x509_en/decode_provable_seed: clarified purpose of functions [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
7 years agohandshake: increase the default number of tickets we send to 2
Nikos Mavrogiannopoulos [Fri, 1 Mar 2019 10:15:47 +0000 (11:15 +0100)] 
handshake: increase the default number of tickets we send to 2

This makes it easier for clients which perform multiple connections
to the server to use the tickets sent by a default server. That's
because 2 tickets allow for 2 new connections (if one is using each
ticket once as recommended), which in turn lead to 4 new and so on.

Resolves: #596

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
7 years agoMerge branch 'tmp-fix-pkcs11-so' into 'master'
Nikos Mavrogiannopoulos [Tue, 19 Mar 2019 16:46:01 +0000 (16:46 +0000)] 
Merge branch 'tmp-fix-pkcs11-so' into 'master'

pkcs11: security officer login implies writable session

Closes #721

See merge request gnutls/gnutls!953

7 years agoImproved estimation of wait in gnutls_session_get_data2
Nikos Mavrogiannopoulos [Sat, 23 Feb 2019 20:02:56 +0000 (21:02 +0100)] 
Improved estimation of wait in gnutls_session_get_data2

Previously we would wait an arbitrary value of 50ms for the
server to send session tickets. This change makes the client
wait for the estimated single trip time + 60 ms for the server
to calculate the session tickets. This improves the chance
to obtain tickets from internet servers during the call of
gnutls_session_get_data2().

Resolves: #706

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agoMerge branch 'tmp-remove-fixme' into 'master'
Tim Rühsen [Sat, 16 Mar 2019 19:26:16 +0000 (19:26 +0000)] 
Merge branch 'tmp-remove-fixme' into 'master'

Removed all FIXME comments in code

See merge request gnutls/gnutls!955

7 years agodoc update
Nikos Mavrogiannopoulos [Sat, 16 Mar 2019 18:59:07 +0000 (19:59 +0100)] 
doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agognutls-cli: Add option "--logfile" to redirect information message output
Ke Zhao [Wed, 6 Mar 2019 18:23:24 +0000 (13:23 -0500)] 
gnutls-cli: Add option "--logfile" to redirect information message output

First, add an option "--logfile" so user could choose a specific file to
store all the informational messages. In some cases, informational
messages may cause unexpected result if the output is standard output.

With this option, user could redirect these messages to a specific
file. This will be helpful in testing and tracking.

Second, replace printf() function with log_msg() function

This log_msg() function is used when "--logfile" is enabled.

Third, add a functionality test for "--logfile" option

Add a test script to test if "--logfile" option works as it should be.

Signed-off-by: Ke Zhao <kzhao@redhat.com>
7 years agoRemoved all FIXME comments in code [ci skip]
Nikos Mavrogiannopoulos [Fri, 15 Mar 2019 16:00:17 +0000 (17:00 +0100)] 
Removed all FIXME comments in code [ci skip]

We expand informational comments on limitations, but with removing
FIXME (keyword didn't help fixing these), and remove completely unhelpful
comments, obsolete ones, or comments about ideas.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
7 years agopkcs11: security officer login implies writable session
Nikos Mavrogiannopoulos [Wed, 13 Mar 2019 14:14:37 +0000 (15:14 +0100)] 
pkcs11: security officer login implies writable session

According to the PKCS#11 v2.30, 6.7.1 there are no read-only Security Officer
sessions.

Resolves: #721

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
7 years agoMerge branch 'tmp-use-https' into 'master'
Tim Rühsen [Wed, 13 Mar 2019 19:32:45 +0000 (19:32 +0000)] 
Merge branch 'tmp-use-https' into 'master'

Change HTTP:// references to HTTPs:// (generally)

See merge request gnutls/gnutls!910

7 years agoMerge branch 'inet_ntop' into 'master'
Nikos Mavrogiannopoulos [Wed, 13 Mar 2019 14:54:28 +0000 (14:54 +0000)] 
Merge branch 'inet_ntop' into 'master'

inet_ntop is available in Windows but not via arpa/inet.h

See merge request gnutls/gnutls!947

7 years agoinet_ntop is available in Windows but not via arpa/inet.h
Steve Lhomme [Wed, 13 Mar 2019 14:54:28 +0000 (14:54 +0000)] 
inet_ntop is available in Windows but not via arpa/inet.h

It's found in ws2tcpip.h which is already included in gnutls_int.h

arpa/inet.h doesn't exist on Windows, so add arpa_inet to the list of headers
replaced by gnulib if not found.

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
7 years agoUpdate the GNU Free Documentation License (FDL)
Tim Rühsen [Thu, 7 Mar 2019 09:16:46 +0000 (10:16 +0100)] 
Update the GNU Free Documentation License (FDL)

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
7 years agoFix URL of ABI compliance checker
Tim Rühsen [Mon, 25 Feb 2019 09:36:36 +0000 (10:36 +0100)] 
Fix URL of ABI compliance checker

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
7 years agoFix URLs of p11-kit
Tim Rühsen [Mon, 25 Feb 2019 09:32:24 +0000 (10:32 +0100)] 
Fix URLs of p11-kit

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
7 years agoUse https:// in lib/, src/, and m4/
Tim Rühsen [Tue, 5 Feb 2019 16:00:41 +0000 (17:00 +0100)] 
Use https:// in lib/, src/, and m4/

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
7 years agoUse https:// for arbitrary files #1
Tim Rühsen [Tue, 5 Feb 2019 15:56:08 +0000 (16:56 +0100)] 
Use https:// for arbitrary files #1

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
7 years agoUse https:// for www.iana.org
Tim Rühsen [Tue, 5 Feb 2019 15:44:37 +0000 (16:44 +0100)] 
Use https:// for www.iana.org

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
7 years agoUse https:// for csrc.nist.gov
Tim Rühsen [Tue, 5 Feb 2019 15:25:25 +0000 (16:25 +0100)] 
Use https:// for csrc.nist.gov

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
7 years agoUse https:// for www.gnu.org and www.example.com
Tim Rühsen [Tue, 5 Feb 2019 15:22:43 +0000 (16:22 +0100)] 
Use https:// for www.gnu.org and www.example.com

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>