Make tlsproxy/buffer.c compilable by gcc 4.4.7

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

_gnutls_check_key_purpose: eliminated dead code

Resolves #573

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

manpages: do not generate any manpages for openpgp.h

This API is no longer functional and is only available as stubs
for backwards binary compatibility.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

manpage generation: cleanup

Recognize parameters of the form unsigned char name[8], and
do not print obscure warnings. Furthermore gdoc will fail
when a function parameter is not described or when no
function is found. This addresses the generation of undetected
errors in generated manpages.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc: fixed missing function and enumeration parameters

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: removed unused file

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Merge branch 'tmp-fix-mech-list-generation' into 'master'

mech-list.h: generate unique entries

See merge request gnutls/gnutls!761

mech-list.h: generate unique entries

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

released 3.6.4

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: pkcs12-utf8 depend on bash

The NetBSD default shell cannot handle the UTF-8 strings we use
in that script.

Resolves #544

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

bumped versions and updated NEWS file

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Enable the TLS1.3 protocol by default

As the protocol has been finalized, and the implementation is
stable and interoperable, there is no need to enable it conditionally.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Merge branch 'tmp-pkcs11-lax-search' into 'master'

Provide a less restrictive PKCS#11 search of certificates

Closes #569

See merge request gnutls/gnutls!757

Merge branch 'tmp-be-strict-on-crls' into 'master'

gnutls-cli enables CRL validation on startup

Closes #564

See merge request gnutls/gnutls!752

Merge branch 'tmp-session-ticket-key-rotation-ajuaristi' into 'master'

Session ticket key rotation with TOTP

Closes #184

See merge request gnutls/gnutls!695

gnutls-cli: enable CRL validation on startup

This also makes the failure in adding CRLs or CAs, a fatal error.

Resolves #564

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Provide a more flexible PKCS#11 search of trust store certificates

This addresses the problem where the CA certificate doesn't
have a subject key identifier whereas the end certificates
have an authority key identifier.

Resolves #569

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

trust list: added flag to force failure on CRL validation error

This allows an application to be notified of the addition of invalid
CRLs in the trust list.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Merge branch 'tmp-rm-mech-list' into 'master'

Remove auto-generated src/mech-list.h from repo

See merge request gnutls/gnutls!753

Remove auto-generated src/mech-list.h from repo

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

Merge branch 'tmp-res-prio' into 'master'

Fix issue introduced in 20886264fe

See merge request gnutls/gnutls!756

Fix issue introduced in 20886264fe

This makes _gnutls_resolve_priorities() return a string that is always
allocated with the gnutls memory functions.

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

session tickets: check timestamp for validity

We were previously only relying on the client's view of the
ticket lifetime for TLS1.3 tickets. This makes sure that we
only resume tickets that the server considers valid and consolidates
the expiration time checks to _gnutls_check_resumed_params().

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

ECC export/import: updated documentation on EdDSA curves

This clarifies the format that parameters in the EdDSA curves
will be returned, and also ensures that the import/export
functions fail on unsupported curves.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Merge branch 'gost-endianness' into 'master'

GOST endianness

See merge request gnutls/gnutls!755

tests: use virt-time.h in resumption tests

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Added session ticket key rotation with TOTP

This introduces session ticket key rotation on server side. The
key set with gnutls_session_ticket_enable_server() is used as a
master key to generate time-based keys for tickets. The rotation
relates to the gnutls_db_set_cache_expiration() period.

Resolves #184

Signed-off-by: Ander Juaristi <a@juaristi.eus>

certtool: print GOST public key with MSB first

OpenSSL and other libraries print MSB first, when printing GOST public
keys. Let's return to this convention.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

x509: print_pubkey: print GOST public key with MSB first

OpenSSL and other libraries print MSB first, when printing GOST public
keys. Let's return to this convention.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

lib: use little endian when importing/exporting GOST keys

GOST R 34.10 native format is little endian. It is better for the
application code to use native format data to interface library, rather
than convert buffers on their own.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

mpi: add function to dprint mpi in little endianness

Add little endian counterpart to _gnutls_mpi_dprint and
_gnutls_mpi_dprint_le.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

Merge branch 'fix-gost-docs' into 'master'

gnutls.h: correct GOST R number references

See merge request gnutls/gnutls!750

gnutls.h: correct GOST R number references [ci skip]

Fix numeric GOST R ids used in documentation, too many numbers:
 - GOST R 34.11 is digest function
 - GOST R 34.10-2001 is a digital signature over GOST R 34.11-94 digest
 - GOST R 34.10-2012 is a digital signature over GOST R 34.11-2012 digest

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

Update git submodules via ./bootstrap

Setting $SUBMODULE_NOFETCH to a non-empty value adds
--no-fetch to the git command (for CI speedup).

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

tests: pkcs1-pad: run with SHA-1 enabled or disabled

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitlab-ci.yml: enable run with SHA-1 enabled

This adds a CI run with SHA-1 enabled, and corrects issues in the
testsuite when that's the case.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_trust_list_add_trust_mem: fix behavior with unaccounted certs

If gnutls_x509_trust_list_add_cas returns less than clist_size, the additional
unaccounted certificates will never be freed.

Relates #552

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_trust_list_add_cas: corrected return value

When the flag GNUTLS_TL_USE_IN_TLS is used and add_new_ca_to_rdn_seq
the return value did not include the last certificate added to the
list. This corrects its return value.

Relates #552

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

fixed documentation in trust list functions

That clarifies and addresses issues in the documentation of
gnutls_x509_trust_list_add_crls() and gnutls_x509_trust_list_add_cas()

Relates #552

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Merge branch 'tmp-crl' into 'master'

certtool: crl handling updates

See merge request gnutls/gnutls!747

tests: added CRL verification tests

This tests CRL verification with certtool --verify-crl on correct
and incorrect cases.

Relates #564

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

certtool: updates in documentation in messages for CRL generation

This fixes the messages printed for the generation of a CRL, and
makes the return code of the CRL verification depending on the
verification result.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

Fix variable used in reallocation

This corrects the variable name used in the sizeof argument
for realloc. This does not alter the actual allocation size,
but rather it fixes a logic error.

Relates: #554

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitignore: updated

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

dtls: recover when a NewSessionTicket message is lost

When the server's NewSessionTicket gets lost while the ChangeCipherSpec
goes through, the client did not request retransmission by retransmitting
his last flight, and the handshake was blocked. This commit addresses
the issue and adds a reproducer.

Resolves #543

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tlsfuzzer: remove duplicate tests and sort them alphabetically

Signed-off-by: Daiki Ueno <dueno@redhat.com>

doc: fix reference to invocation nodes

Signed-off-by: Andreas Schwab <schwab@suse.de>

priority: be backwards compatible with priority strings starting with NONE

That is, we allow priority strings which do not enable any groups to
work, by disabling TLS1.3. For example
'NONE:+VERS-TLS-ALL:+MAC-ALL:+RSA:+AES-128-GCM:+SIGN-ALL:+COMP-NULL'
is still operational, but no TLS1.3 is enabled when specified.

Resolves: #549

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Merge branch 'tmp-strdup' into 'master'

Use gnutls_strdup() in library code

See merge request gnutls/gnutls!742

Use gnutls_strdup() instead of strdup() in library code

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

Remove gnulib work-around '#undef strdup'

The 'issue' should be fixed already. Even if not, it has to
addressed in gnulib.

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

Merge branch 'tmp-psk-ext-refactor' into 'master'

tls13/psk_ext_parser: simplify the iterator interface

See merge request gnutls/gnutls!736

ext/pre_shared_key: use consistent name for regitration entry

Signed-off-by: Daiki Ueno <dueno@redhat.com>

ext/pre_shared_key: make ticket age calculation consistent

Previously we used a pattern like this:

  uint32_t obfuscated_ticket_age, ticket_age_add;
  time_t ticket_age;

  ticket_age = obfuscated_ticket_age - ticket_age_add;
  if (ticket_age < 0) {
   ...
  }

This always evaluates to false, because subtraction between unsigned
integers yields an unsigned integer.  Let's do the comparison before
subtraction and also use correct types for representing time: uint32_t
for protocol time and time_t for system time.

Signed-off-by: Daiki Ueno <dueno@redhat.com>

tls13/psk_ext_parser: simplify the iterator interface

Previously it was unclear whether psk_ext_parser_st is stateful or
not.  This change introduces the simpler API to iterate over the
immutable data (psk_ext_parser_st), following the iterator pattern.

Signed-off-by: Daiki Ueno <dueno@redhat.com>

gnutls-cli-debug: mention RFC8446 for TLS1.3 and RFC8422 for X25519

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Merge branch 'tmp-gnulib-use-git' into 'master'

Remove --no-git from ./bootstrap

See merge request gnutls/gnutls!739

Remove --no-git from ./bootstrap [ci skip]

This removes the --no-git option as bootstrap itself does not use
the remote repository for cloning. At least as long $GNULIB_SRCDIR
points to a recent enough local gnulib git repo.

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>

Merge branch 'tmp-update-version-numbers' into 'master'

Update library to use the final RFC8446 version numbers

Closes #542 and #359

See merge request gnutls/gnutls!730

handshake: do not negotiate TLS1.3 using the legacy version field

Previously we could end-up with a TLS1.3 connection if the TLS1.3
ID was seen on the wire. We now explicitly fallback to TLS1.2
when we see a protocol with TLS1.3 semantics in an SSL2.0 or
in the legacy version of the client hello.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

handshake: simplified protocol version checking functions

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tlsfuzzer: modify to use the final code points

Relates #542

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

fuzz: updated traces for final TLS1.3 version

Resolves #359

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

protocols: bumped TLS1.3 version number to RFC8446 value

This adds support of the final RFC numbers.

Resolves #542

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

Merge branch 'rfc7250_cert-types' into 'master'

RFC7250 certificate type negotiation

See merge request gnutls/gnutls!498

Implemented RFC7250 certificate type negotiation extensions.

Signed-off-by: Tom Vrancken <dev@tomvrancken.nl>

Merge branch 'tmp-record-size-limit' into 'master'

record_size_limit extension

Closes #524

See merge request gnutls/gnutls!733

ext/record_size_limit: new extension

This implements the record_size_limit extension as defined in RFC 8449.

Although it obsoletes the max_record_size extension, for compatibility
reasons GnuTLS still sends it on certain occasions.  For example, when
the new size is representable as the codepoint defined for
max_record_size.

Signed-off-by: Daiki Ueno <dueno@redhat.com>

ext/max_record: remove use of extension private data

As the extension data is always stored in
session->security_parameters.max_record_send_size, it shouldn't be
necessary to track it with the private data.

Signed-off-by: Daiki Ueno <dueno@redhat.com>

Merge branch 'tmp-fix-resumption-requested' into 'master'

Fix gnutls_session_resumption_requested

Closes #546

See merge request gnutls/gnutls!735

gnutls_session_resumption_requested: fixed behavior under TLS1.3

This makes gnutls_session_resumption_requested() functional under
TLS1.3 and introduces a unit test of the function.

Resolves #546

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Merge branch 'tmp-no-git-in-bootstrap' into 'master'

.gitlab-ci.yml: use --no-git to bootstrap

Closes #547

See merge request gnutls/gnutls!737

.gitlab-ci.yml: use --no-git to bootstrap

That is, to reduce CI time, and avoid failures due to
non-availability of the gnulib git repo.

Resolves #547

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

hello_ext: removed bogus comment

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitmodules: gnulib submodule is now synced from libidn's mirror

This mirror is updated hourly and is hosted on gitlab, meaning
less dependency on external sites downtime.

Resolves: #547

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Merge branch 'tmp-ametzler-typo-guarranteed_overriden' into 'master'

Fix two typos (overriden/guarranteed)

See merge request gnutls/gnutls!734

Fix two typos (overriden/guarranteed)

Signed-off-by: Andreas Metzler <ametzler@bebt.de>

Merge branch 'tmp-document-none' into 'master'

doc: document the non-portability of NONE priority string

See merge request gnutls/gnutls!731

doc: document the non-portability of NONE priority string

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

Merge branch 'tmp-fixes-cov' into 'master'

Fixes for issues identified by static analyzers

Closes #518

See merge request gnutls/gnutls!729

tools: check output of called functions

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

write_oid_and_params: moved nullity check of params earlier

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

gnutls_session_set_premaster: corrected error checks

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

pubkey_verify_hashed_data: apply algorithm checks

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

privkey_sign_raw_data: use assert to mark code which always succeeds

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_send_change_cipher_spec: removed unnecessary test

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.travis.yml: do not run brew upgrade

This addresses issue with travis compilation on MacOSX.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

Merge branch 'tmp-use-explicit-bzero' into 'master'

gnutls_memset: use explicit_bzero

Closes #230

See merge request gnutls/gnutls!728

gnutls_memset: use explicit_bzero

That is, use the glibc function when available and the second
parameter is zero.

Resolves #230

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Merge branch 'tmp-consistent-falltrough' into 'master'

use a consistent method to mark fall-through in switch cases

Closes #306

See merge request gnutls/gnutls!726

use a consistent method to mark fall-through in switch cases

Also document that method in contribution guide.

Resolves #306

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

Merge branch 'tmp-tlsfuzzer-update-tls13' into 'master'

tlsfuzzer: update to the latest version to enable more TLS 1.3 tests

Closes #537

See merge request gnutls/gnutls!727

ext/pre_shared_key: prevent crash if no server credentials are set

Previously, if server is configured without PSK credentials and the
client authenticated with PSK, the server crashed with:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7b190ba in server_recv_params (session=0x636fc0, data=0x634e6e "",
    len=46, pskcred=0x0) at pre_shared_key.c:523
523                             prf = pskcred->binder_algo;

Signed-off-by: Daiki Ueno <dueno@redhat.com>

tlsfuzzer: update to the latest version

Also enable test-tls13-ffdhe-sanity.py,
test-tls13-session-resumption.py, and
test-tls13-unrecognised-groups.py.

Signed-off-by: Daiki Ueno <dueno@redhat.com>

alert: map GNUTLS_E_NO_COMMON_KEY_SHARE to handshake_failure

Previously, when server received a ClientHello that does include only
groups from unassigned ranges in supported_groups, it aborted the
connection with an illegal_parameter.

Resolves #537

Signed-off-by: Daiki Ueno <dueno@redhat.com>

algorithms: add support for FFDHE6144

Signed-off-by: Daiki Ueno <dueno@redhat.com>

Merge branch 'tmp-fix-ecdsa-pubkey-import' into 'master'

Corrected the importing of ECDSA public keys

Closes #538

See merge request gnutls/gnutls!725

Corrected the importing of ECDSA public keys

This seems to be a regression since EdDSA support. The call to
_gnutls_x509_get_pk_algorithm() in public key import was unnecessary
and in fact it was overriding the available curve with a curve associated
with the OID. As the ECDSA OID doesn't include the curve, that had the
result of deleting the already read curve.

Resolves #538

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

Ensure we are sending the right protocol version on second client hello

That is, when we respond to a Hello Retry Request as client, we put
the TLS1.2 version on the second client hello to send a hello that is
as close as possible to the original hello. That effectively separates
the handling of TLS1.2 rehandshake and TLS1.3 hello retry request
when sending a client hello.

Resolves #535

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc: improved text on certifications

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>