serv: increase cache size used for resumption

That allows sessions with longer parameters to be able
to be resumed.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

CONTRIBUTING.md: check the issue closing as part of review [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls-cli: no longer print certificate types or compression methods

We don't support any other compression methods than the null compression,
nor any other certificate types.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Inline version macros into its users.

This fixes a problem in _gnutls_version_is_supported() where we want to
use preprocessing directives in the loop body. Doing this within a macro
argument is undefined behaviour according to the C standard, and not
supported by the system compiler on AIX.

Signed-off-by: Jay Foad <jay.foad@gmail.com>
Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

updated auto-generated files

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

certtool: deprecated the --certificate-pubkey option

That option is duplicate since --pubkey-info can provide the same
information.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

certtool: avoid duplicate deinitialization on --certificate-pubkey

Resolves #368

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

dh: document why BER decoding rules are allows

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

pubkey: use the strict DER decoder for SubjectPublicKeyInfo

Although there is no explicit RFC mentioning the SubjectPublicKeyInfo
encoding, this structure is a subset of the X.509 certificate's structure
and as such it is expected to be in DER form.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

pk: document need for the generic BER decoder

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: check whether deletion of a certificate object works

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

p11tool: corrected issue preventing the deletion of objects in batch mode

Previously initialization of PIN callbacks would only happen during listing
of objects, which happened only in non-batch mode.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

p11tool: corrected type affecting use of --only-urls

It would enable batch mode accidentally.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: pkcs11/tls-neg-pkcs11-key: updated for softhsm with PKCS#11 support

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

added sub-section on selecting the right return value [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc update [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

examples: use gnutls_certificate_set_x509_system_trust

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: privkey-verify-broken: addressed uninitialized var use

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: check whether get_mtu() functions relate to the set values

That is, verify that gnutls_dtls_set_data_mtu() value would be
reflected into gnutls_dtls_get_data_mtu(), as well as the
gnutls_dtls_set_mtu() to gnutls_dtls_get_mtu().

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added unit test for _gnutls_record_overhead()

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

DTLS: improved data MTU calculation under CBC ciphersuites

The data MTU calculation under CBC ciphersuites takes into
account that the overhead of these ciphersuites is constant (IV +
hash + 1 byte padding), though the capacity varies due to the padding
block. That is, on 16-byte padding block, one padding byte is the
overhead but the rest 15 bytes are accounted for data MTU.

That also has the side effect that setting a data MTU using
gnutls_dtls_set_data_mtu(), is not definite, and the actual
MTU may be larger for these ciphersuites --i.e., the
return value of gnutls_dtls_get_data_mtu().

Resolves #360

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

fuzz: added reproducer for leak in gnutls_x509_crl_list_import

That was detected by oss-fuzz in:
  https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4930

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_crt_list_import: eliminated memory leak

That leak would be triggered if GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED
flag was used and the input data would exceed the maximum limit.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

libtasn1: updated to latest libtasn1 master branch

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_pkcs12_key_parser_fuzzer.in: added reproducer for oss-fuzz #4890

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc update [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

doc: updated copyright year for manual

That eliminates the 'make syntax-check' error.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added reproducer for self-signed verification error

Relates #347

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

x509/verify: when verifying against a self signed certificate ignore issuer

That is, ignore issuer when checking the issuer's parameters strength. That
resolves the issue of marking self-signed certificates as with insecure
parameters during verification.

Resolves #347

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

gnutls_pk_self_test: include ECDSA tests on GNUTLS_PK_EC

Previously when a request for a specific self check on GNUTLS_PK_EC
was done, only ECDH tests would be run. This change includes the ECDSA
tests as well (GNUTLS_PK_EC and GNUTLS_PK_ECDSA are an alias to each other).

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: hash-large: increase parallelism to allow fast run in CI

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc: reference gnutls_prf_rfc5705 instead of gnutls_prf

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: utils.h: forbid compilation with NDEBUG

This allows to rely on the assert() macro being functional on
the test suite.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: p11-kit-load.sh: verify that all modules are loaded after a private key operation

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: enhanced pkcs11/list-tokens

This not only creates a trust list with the system certificates, but
also attempts to verify a certificate, increasing the number of calls
to PKCS#11 verification API (and thus ensuring there are no calls
which may trigger the load of other modules).

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

pkcs11 verification: always use the GNUTLS_PKCS11_OBJ_FLAG_PRESENT_IN_TRUSTED_MODULE

That is, make sure that all our calls to PKCS#11 subsystem for verification
will only trigger the trust module initialization, and not the generic
PKCS#11 initialization.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

pkcs11: simplify trusted module loading state

That is always utilize the same flags (GNUTLS_PKCS11_OBJ_FLAG_PRESENT_IN_TRUSTED_MODULE)
to determine whether to initialize trusted modules only or
proceed with general initialization.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_pkcs11_check_init: improved transition between states

The init_level_t for PKCS#11 modules, was incorrectly handled as a
linear state transition, causing few cases in the transition to be
incorrectly handled. Define precisely the state transitions and
enforce them in _gnutls_pkcs11_check_init.

That addresses a regression introduced by the previous state handling
addition, which made impossible to switch from the trusted state to
the all modules.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: corrected destructive/p11-kit-load.sh error checking

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls-serv: fix double-free on inactivity timeout

Previously, gnutls-serv --echo segfaulted when closing client
connection after inactivity timeout.  Here is the valgrind output:

==20246== Invalid free() / delete / delete[] / realloc()
==20246==    at 0x4C2FD18: free (vg_replace_malloc.c:530)
==20246==    by 0x405310: listener_free (serv.c:154)
==20246==    by 0x408B57: tcp_server (serv.c:1568)
==20246==    by 0x407DA6: main (serv.c:1231)
==20246==  Address 0x6ed4fe0 is 0 bytes inside a block of size 3 free'd
==20246==    at 0x4C2FD18: free (vg_replace_malloc.c:530)
==20246==    by 0x408A1D: tcp_server (serv.c:1548)
==20246==    by 0x407DA6: main (serv.c:1231)
==20246==  Block was alloc'd at
==20246==    at 0x4C2EB6B: malloc (vg_replace_malloc.c:299)
==20246==    by 0x6A64489: strdup (in /usr/lib64/libc-2.25.so)
==20246==    by 0x407310: get_response (serv.c:948)
==20246==    by 0x408840: tcp_server (serv.c:1492)
==20246==    by 0x407DA6: main (serv.c:1231)
==20246==

Signed-off-by: Daiki Ueno <dueno@redhat.com>

.dir-locals.el: new file

This forces Emacs to use the Linux kernel coding style for all C code.

Signed-off-by: Daiki Ueno <dueno@redhat.com>

build: remove m4 files pulled in by autopoint

Having these files in the git repository causes unnecessary changes
after "make bootstrap".

Signed-off-by: Daiki Ueno <dueno@redhat.com>

gnutls_aead_cipher_init: corrected potential memory leak

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc: provided basic documentation of the FIPS140-2 mode [ci skip]

Resolves #332

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: verify whether group remains the same after resumption

Resolves #331

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

_gnutls_set_resumed_parameters: restore the group from resumed parameters

That allows resumed sessions to have the original group information such as
curve used for key exchange or FFDHE parameters.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: removed unnecessary assert

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: delete temporary files

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

session state: use the right type for send_cert_req variable

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: client-fastopen: introduce child signal handler and delay prior to starting

This addresses a hang issue on freebsd builds.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

psktool: allow up to 512-byte keys

This aligns the psktool --help output with the psktool operation.

Suggested by Jack Lloyd.

Resolves #327

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

getfuncs-map.pl: added gnutls_srp_8192_group* symbols to ignore list

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

updated auto-generated files

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

srptool: --create-conf no longer includes 1024-bit parameters

In addition it includes the 8192-bit parameters, and
the default params used for a new user are the 2k ones.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: updated SRP checks

Test 1024, 1536, 2048, 3072, 4096 and 8192 bit parameters.
In addition, verify that parameters not in the SRP spec are
rejected by a gnutls client.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitlab-ci.yml: move destructive tests after trust store tests

That is, to ensure they are only run after the trust store
is complete and that it doesn't affect its output.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: include the 8192-bit SRP prime into param checks

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

srp: added the 8192-bit prime

As we now reject any primes not in the SRP spec, we include
that parameter to ensure we can handle clients within the
spec but with large parameters.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

srp: reject any parameters not in the SRP draft

This implements the SHOULD requirement from RFC5054, i.e., to
only accept group parameters that come from a trusted source,
such as those listed in Appendix A.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

fuzz: srp-client: decreased acceptable prime bits to 1024 [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: combined key and cert tests

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: windows subdir is only included on windows builds

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: dtls subdir was merged into main tests

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

fuzz: srp-client: restrict prime bits to 1537 [ci skip]

That avoids timeouts in the oss-fuzz infrastructure:
  https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3277

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc: corrected typo

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

doc: better detect acronym keyword on latex output

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc: latex: resolve all citation issues

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc: citations translate into references in texinfo

That makes the citations to be links in the generated html manual.

Resolves: #321

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

p11tool: renamed pkcs11_set_pin() to allow static linking

Resolves #322

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

cfg.mk: do not include reproducer files into syntax checks

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_x509_ext_import_proxy: corrected memory leak

Also added reproducer for the memory leak found.

Issue found using oss-fuzz:
  https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3159

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tools: do not access unused variables

This avoids warnings by static analyzers.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitlab-ci.yml: disabled gcc warnings on CI builds and use dash

That should decrease the time spent in configure. Based on suggestions
by Tim Ruehsen.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

.gitlab-ci.yml: use configure cache file and ccache

That reduces the total time spent per build by caching configure
checks, and compilation artifacts.

Also that patch set no longer uploads coverage files as artifacts.
These files are not generally useful, and removing that "feature"
will reduce CI running time.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

doc: corrected typo [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

tests: list-tokens: not only list but also verify whether module is operational

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

pkcs11: refuse to load modules with duplicate information

That is, when ck_info matches, we soft fail loading the module.
That is, because in several cases the pointers got by p11-kit
may differ for the same modules.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: enhanced PKCS#11 loading test

Test whether implicit initialization in trusted module (e.g.,
via verification), would result to proper initialization of additional
modules once a PCKS#11 function is called.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

tests: added PKCS#11 module loading test

This checks:
 1. Whether all modules are loaded from p11-kit when
    no explicit gnutls_pkcs11_init() is called and
    pkcs11 calls are accessed.
 2. Whether only the trusted modules are loaded from
    p11-kit and no other PKCS#11 calls than PKCS#11
    cert validation is performed.
 3. Whether the trusted modules are loaded when
    gnutls_pkcs11_init() is called with manual
    flag.

Resolves #315
Resolves #316

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

pkcs11: allow loading trusted modules when pkcs11 was initialized in manual mode

When a PKCS#11 trust module is used in the system, but gnutls_pkcs11_init()
is explicitly called with GNUTLS_PKCS11_FLAG_MANUAL flag, then the PKCS#11
trust store was not loaded, and thus prevent any certificate validation.

This change allows initializing the trust modules only even if generic
PKCS#11 support is disabled by the application.

Relates #316

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

pkcs11: introduce multiple levels of loading

That allows to load the PKCS#11 trusted modules (on systems which use them)
without loading all the potentially present PKCS#11 modules.

Relates #315

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

CONTRIBUTING.md: added a short text on reviewing code [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

Fix non-null warning

Help the compiler understand the control flow in the MATCH_FUNC and
INVALID_MATCH_FUNC macros.

Because we are using macros, the compiler is not able to correlate the
replaced values of the macro variables to each other yielding non-null
warnings. Introduce a C variable to mimic the macro variable helping
the compiler understanding the control flow.

tests: test whether PKCS#11 generation works without login

Resolves #147

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

p11tool: attempt to auto-login when the token requires it

In operations like generation or writing objects, run as if --login
was given if the token is marked to require login.

Relates #147

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

p11tool: print PKCS#11 token flags in --list-tokens

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

pkcs11: forward token flags to applications

That is, gnutls_pkcs11_token_get_flags() will not return the
most common/useful PKCS#11 token flags, in addition to trusted and HW
flags.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

doc update [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

doc update [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls_server_name_set: Clarify meaning of the name_length parameter [ci skip]

Signed-off-by: Thomas Klute <thomas2.klute@uni-dortmund.de>

doc: mention SHA224 removal in upgrade guide

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

bumped version

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

gnutls-serv: print the right error code on OCSP request setting

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

ocsptool: doc update

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

doc update [ci skip]

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>

cmp_hsk_types: fixed check for SSLv2 hello

Previously, if SSLv2 hello support was disabled, the check for
the expected TLS message was incorrect.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>